Re: [Qemu-devel] [RFC PATCH v3 16/49] target-i386: update fp status fix

2014-07-31 Thread Alex Bennée
Pavel Dovgalyuk writes: This patch adds calls to update_fp_status() function from several places where FPU state is changed. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- target-i386/cpu.c|1 + target-i386/cpu.h|1 + target-i386/fpu_helper.c |5

Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 17:49, Pavel Dovgalyuk ha scritto: We cannot calculate timers in post_load, because it requires correct value of virtual clock. And at that moment replay data structures could be not loaded yet. Then this patch (and similarly others in this early part of the series) should be

Re: [Qemu-devel] [RFC PATCH v3 22/49] cpu: invent instruction count for accurate replay

2014-07-31 Thread Alex Bennée
Pavel Dovgalyuk writes: This patch adds instructions count fields to cpu structure and invents several functions for increasing this counter while executing translation blocks. snip @@ -1186,6 +1188,7 @@ void qemu_init_vcpu(CPUState *cpu) cpu-nr_cores = smp_cores; cpu-nr_threads

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 18:13, Ming Lei ha scritto: Follows 'perf report' result on cycles event for with/without bypass coroutine: http://pastebin.com/ae0vnQ6V From the profiling result, looks bdrv_co_do_preadv() is a bit slow without bypass coroutine. Yeah, I can count at least 3.3% time

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2014-07-31 Thread Serge Hallyn
** Changed in: qemu (Ubuntu) Status: New = Confirmed ** Changed in: qemu (Ubuntu) Importance: High = Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1350435 Title: tcg.c:1693:

Re: [Qemu-devel] [PATCH 24/28] ahci: Add test_pci_spec to ahci-test.

2014-07-31 Thread John Snow
On 07/31/2014 09:19 AM, Stefan Hajnoczi wrote: On Mon, Jul 07, 2014 at 02:18:05PM -0400, John Snow wrote: +#ifdef AHCI_13_STRICT Please drop the #ifdef. #ifdefs mean dead code that is not being compiled or tested. Just decide which case we should take and keep that one. OK. It might be nice

Re: [Qemu-devel] [PATCH] vmdk: improve streamOptimized vmdk support

2014-07-31 Thread Milos Vyletel
I will update description in v2 with more info. On Wed, Jul 30, 2014 at 4:09 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jul 29, 2014 at 3:49 PM, Milos Vyletel milos.vyle...@gmail.com wrote: On Tue, Jul 29, 2014 at 10:37 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jul 29,

Re: [Qemu-devel] [PATCH] vmdk: improve streamOptimized vmdk support

2014-07-31 Thread Milos Vyletel
On Wed, Jul 30, 2014 at 3:51 AM, Fam Zheng f...@redhat.com wrote: On Mon, 07/07 10:54, Milos Vyletel wrote: VMDK's streamOptimized format is different that regular sparse format. s/that/from/ L1(GD) and L2(GT) tables are not predefined but rather generated and written during image creation

[Qemu-devel] [Bug 1297487] Re: MTU not honored in virtio vnet

2014-07-31 Thread mp
I believe this bug may be breaking Salt by breaking ZeroMQ in certain virtualized environments. Additional information here: https://github.com/saltstack/salt/issues/12248 ** Also affects: salt Importance: Undecided Status: New -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH 26/28] ahci: Add test_hba_spec to ahci-test.

2014-07-31 Thread John Snow
On 07/31/2014 10:01 AM, Stefan Hajnoczi wrote: On Mon, Jul 07, 2014 at 02:18:07PM -0400, John Snow wrote: +if (bitset(cap, AHCI_CAP_SAM)) { +g_test_message(Supports AHCI-Only Mode: GHC_AE is Read-Only.); +assert_bit_set(reg, AHCI_GHC_AE); +} else { +

Re: [Qemu-devel] [PATCH 3/4] libqos: add a simple first-fit memory allocator

2014-07-31 Thread John Snow
On 07/31/2014 06:13 AM, Stefan Hajnoczi wrote: On Wed, Jul 30, 2014 at 06:28:28PM -0400, John Snow wrote: +#define bitany(X, MASK) ((X) (MASK)) +#define bitset(X, MASK) (bitany((X), (MASK)) == (MASK)) This is subjective but macros like this should be avoided. This macro does not encapsulate

Re: [Qemu-devel] [PATCH 03/28] ide-test: add test for werror=stop

2014-07-31 Thread John Snow
On 07/31/2014 06:58 AM, Stefan Hajnoczi wrote: On Mon, Jul 07, 2014 at 02:17:44PM -0400, John Snow wrote: +static void test_retry_flush(void) +{ +uint8_t data; +const char *s; + +prepare_blkdebug_script(debug_path, flush_to_disk); + +ide_test_start( +-vnc none +

Re: [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors

2014-07-31 Thread John Snow
On 07/31/2014 08:23 AM, Stefan Hajnoczi wrote: On Mon, Jul 07, 2014 at 02:17:56PM -0400, John Snow wrote: From: Paolo Bonzini pbonz...@redhat.com This will provide a hook for sending the result of the command via the FIS receive area. Signed-off-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH 0/7] icount migration and clock.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com Those are some icount patches required for reverse execution. It introduces an icount clock which is only growing with icount. It allows QEMU to migrate icount so virtual clock is kept if the VM is migrated in icount mode (which is mandatory for

[Qemu-devel] [PATCH 6/7] icount: make icount extra computed on icount clock as well.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This takes icount clock in account for icount extra computation so icount clock's timers will be triggered at the exact time. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 10

[Qemu-devel] [PATCH 2/7] migration: migrate icount fields.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. It adds a subsection timer/icount to vmstate_timers so icount is migrated only when needed. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Amit Shah

[Qemu-devel] [PATCH 1/7] icount: put icount variables into TimerState.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This puts qemu_icount and qemu_icount_bias into TimerState structure to allow them to be migrated. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 29

[Qemu-devel] [PATCH 3/7] migration: make qemu_savevm_state public.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This makes qemu_savevm_state public for reverse-execution. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Amit Shah amit.s...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- include/sysemu/sysemu.h | 1 +

[Qemu-devel] [PATCH 4/7] icount: introduce icount timer.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This introduces a new timer based only on instruction counter and without any compensation. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- cpus.c | 21 + include/qemu/timer.h | 9 -

[Qemu-devel] [PATCH 5/7] icount: check for icount clock deadline when cpu loop exits.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com Notify events on icount clock when CPU loop exits. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpus.c b/cpus.c index

[Qemu-devel] [PATCH 7/7] timer: add cpu_icount_to_ns function.

2014-07-31 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This adds cpu_icount_to_ns function which is needed for reverse execution. It returns the time for a specific instruction. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c

Re: [Qemu-devel] vfio in the guest: no available reset mechanism

2014-07-31 Thread Le Tan
Hi Alex, 2014-07-30 22:46 GMT+08:00 Alex Williamson alex.william...@redhat.com: On Wed, 2014-07-30 at 22:16 +0800, Le Tan wrote: Hi Michael, 2014-07-30 21:16 GMT+08:00 Michael S. Tsirkin m...@redhat.com: On Wed, Jul 30, 2014 at 08:24:04PM +0800, Le Tan wrote: Hi, I am testing vfio in L1

Re: [Qemu-devel] [PATCH] po: Add Chinese translation

2014-07-31 Thread chen.fan.f...@cn.fujitsu.com
On Thu, 2014-07-31 at 10:44 +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- po/zh_CN.po | 86 + 1 file changed, 86 insertions(+) create mode 100644 po/zh_CN.po diff --git a/po/zh_CN.po b/po/zh_CN.po new

Re: [Qemu-devel] [PATCH] po: Add Chinese translation

2014-07-31 Thread Fam Zheng
On Fri, 08/01 01:46, chen.fan.f...@cn.fujitsu.com wrote: Hi, I think this should be 视图. Yes, I have already posted V2. Please review. Thanks, Fam

[Qemu-devel] [PATCH v2 3/8] audio: a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/audio/gus.c | 2 +- hw/audio/hda-codec.c | 3 ++- hw/audio/sb16.c | 6 +++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index

[Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com $WHATEVER: don't use 'Yoda conditions' 'Yoda conditions' are not part of idiomatic QEMU coding style, so rewrite them in the more usual order. v2: - add more specific commit messages suggested by PMM, thanks. - introduce section of conditional statement

[Qemu-devel] [PATCH v2 8/8] vmxnet3: a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/net/vmxnet3.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 77bea6f..34c5aff 100644 --- a/hw/net/vmxnet3.c +++

[Qemu-devel] [PATCH v2 6/8] spice: a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- ui/spice-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 7bb91e6..ff54dac 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -677,7

[Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Yoda conidtions lack of readability, and QEMU have a strict compiler configuration for checking a common mistake like if (dev = NULL). Make it a written rule. Signed-off-by: Gonglei arei.gong...@huawei.com --- CODING_STYLE | 19 +++ 1 file

[Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/dev-audio.c | 2 +- hw/usb/dev-mtp.c | 4 ++-- hw/usb/hcd-ehci.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index

[Qemu-devel] [PATCH v2 5/8] a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- qdev-monitor.c | 2 +- qemu-char.c | 2 +- util/qemu-sockets.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index f87f3d8..3e30d38

[Qemu-devel] [PATCH v2 7/8] vl: a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index fe451aa..69f0f20 100644 --- a/vl.c +++ b/vl.c @@ -1136,7 +1136,7 @@ static int drive_init_func(QemuOpts *opts,

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 23:44, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 06:12:32PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at

[Qemu-devel] [PATCH v2 4/8] isa-bus: a trivial code change for more idiomatic writing style

2014-07-31 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/isa/isa-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index b28981b..851f953 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -50,7

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 23:47, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:10:53PM +0800, Chen, Tiejun wrote: On 2014/7/31 18:12, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S.

Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions

2014-07-31 Thread Eric Blake
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com $WHATEVER: don't use 'Yoda conditions' 'Yoda conditions' are not part of idiomatic QEMU coding style, so rewrite them in the more usual order. v2: - add more specific commit messages suggested

Re: [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode

2014-07-31 Thread Ming Lei
On Fri, Aug 1, 2014 at 12:30 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 31/07/2014 18:13, Ming Lei ha scritto: Follows 'perf report' result on cycles event for with/without bypass coroutine: http://pastebin.com/ae0vnQ6V From the profiling result, looks bdrv_co_do_preadv() is a bit

Re: [Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement

2014-07-31 Thread Eric Blake
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Yoda conidtions lack of readability, and QEMU have a s/conidtions/conditions/ s/of // s/have/has/ strict compiler configuration for checking a common mistake like if (dev = NULL). Make it a written

Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

2014-07-31 Thread Eric Blake
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/dev-audio.c | 2 +- hw/usb/dev-mtp.c | 4 ++-- hw/usb/hcd-ehci.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-31 Thread Ming Lei
On Thu, Jul 31, 2014 at 4:52 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 31/07/2014 05:47, Ming Lei ha scritto: On Wed, Jul 30, 2014 at 11:25 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/07/2014 17:12, Michael S. Tsirkin ha scritto: Dataplane must not be a change to the guest ABI.

[Qemu-devel] [PATCH v5 0/6] Obtain dirty bitmap via VM logging

2014-07-31 Thread Sanidhya Kashyap
Hi, The following patches introduce the support of the dirty bitmap logging and dumping to a specified file. This patch series addresses the previous issues raised by David and Eric. v4 -- v5 * Removed the runstates code (Eric's and David's advice). * Now, using global variable to resolve the

[Qemu-devel] [PATCH v5 1/6] generic function between migration and bitmap dump

2014-07-31 Thread Sanidhya Kashyap
I have modified the functions to be more generic i.e. I have used the counter variable which stores the required value. If the value of counter is 0, it means bitmap dump process whereas the value of 1 means migration. Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- arch_init.c

[Qemu-devel] [PATCH v5 2/6] BitmapLog: bitmap dump code

2014-07-31 Thread Sanidhya Kashyap
In this patch, I have incorporated an enum named QemuProcess which defines what kind of process is being executed i.e. none -- no other process except the VM execution migration -- migration is being executed bitmap-dump -- bitmap dump process is undergoing Besides this, I have tried to

[Qemu-devel] [PATCH v5 3/6] BitmapLog: get the information about the parameters

2014-07-31 Thread Sanidhya Kashyap
No functional change except the variable name. Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- hmp-commands.hx | 2 ++ hmp.c| 19 +++ hmp.h| 1 + monitor.c| 7 +++ qapi-schema.json | 28

[Qemu-devel] [PATCH v5 4/6] BitmapLog: cancel mechanism for an already running dump bitmap process

2014-07-31 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- hmp-commands.hx | 14 ++ hmp.c| 5 + hmp.h| 1 + qapi-schema.json | 9 + qmp-commands.hx | 20 savevm.c | 14 ++ 6 files changed, 63

[Qemu-devel] [PATCH v5 6/6] BitmapLog: python script for extracting bitmap from a binary file

2014-07-31 Thread Sanidhya Kashyap
The file not only extracts the bitmap from the file but also draws the figure if required. Currently, figure is drawn for all the bitmaps. Later, I'll make the change to draw for different blocks. The picture is drawn by generating a matrix of 0s and 1s from the bitmap. The dimensions are

[Qemu-devel] [PATCH v5 5/6] BitmapLog: set the period of the dump bitmap process

2014-07-31 Thread Sanidhya Kashyap
No functional change except the variable name -- frequency has been modified to period. Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- hmp-commands.hx | 15 +++ hmp.c| 12 hmp.h| 1 + qapi-schema.json | 12

[Qemu-devel] about -enable-kvm options

2014-07-31 Thread Gareth
Hi all What does '-enable-kvm' option mean? I have heard two versions of answers: a) guest OS would have /dev/kvm device and which could help vm in guest OS (nested vm) b) use /dev/kvm and intel-vt on host OS which could help vm run more fast than pure emulator. Thanks -- Gareth *Cloud

Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions

2014-07-31 Thread Gonglei (Arei)
Hi, Subject: Re: [PATCH v2 for-2.2 0/8] about Yoda conditions On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com $WHATEVER: don't use 'Yoda conditions' 'Yoda conditions' are not part of idiomatic QEMU coding style, so rewrite them in the

Re: [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-31 Thread Ming Lei
On Fri, Aug 1, 2014 at 11:09 AM, Ming Lei ming@canonical.com wrote: On Thu, Jul 31, 2014 at 4:52 PM, Paolo Bonzini pbonz...@redhat.com wrote: It doesn't matter, changing features between dataplane and non-dataplane is not something that you can do. Actually it is easy to support multi

Re: [Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement

2014-07-31 Thread Gonglei (Arei)
Hi, Subject: Re: [PATCH v2 1/8] CODING_STYLE: Section about conditional statement On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Yoda conidtions lack of readability, and QEMU have a s/conidtions/conditions/ s/of // s/have/has/ OK.

Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

2014-07-31 Thread Gonglei (Arei)
Hi, Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/dev-audio.c | 2 +-

Re: [Qemu-devel] [PATCH 08/15] virtio: decrease size of VirtQueueElement

2014-07-31 Thread Ming Lei
On Thu, Jul 31, 2014 at 5:38 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 31/07/2014 04:07, Ming Lei ha scritto: On Wed, Jul 30, 2014 at 9:51 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/07/2014 13:39, Ming Lei ha scritto: diff --git a/include/hw/virtio/virtio.h

Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

2014-07-31 Thread Andreas Färber
Am 01.08.2014 05:32, schrieb Gonglei (Arei): Hi, Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com ---

Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style

2014-07-31 Thread Gonglei (Arei)
Hi, Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style Am 01.08.2014 05:32, schrieb Gonglei (Arei): Hi, Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style On 07/31/2014 08:32 PM, arei.gong...@huawei.com

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases

2014-07-31 Thread Slava Pestov
Why are you guys merging requests in qemu at all? Just submit them to the kernel and let the kernel do it. On Wed, Jul 30, 2014 at 1:11 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jul 29, 2014 at 4:11 PM, Eric Blake ebl...@redhat.com wrote: On 07/29/2014 06:41 AM, Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH 7/7] cpus: reclaim allocated vCPU objects

2014-07-31 Thread Gu Zheng
Hi Anshul, Thanks for your test. On 07/30/2014 10:31 PM, Anshul Makkar wrote: Hi, I am testing the cpu-hotunplug patches. I observed that after the deletion of the cpu with id = x, if I cpu-add the same cpu again id = x, then qemu exits with the error that file descriptor already exists.

Re: [Qemu-devel] about -enable-kvm options

2014-07-31 Thread Jules Wang
I choose b) 在2014年08月01 11时15分, Garethacademicgar...@gmail.com写道: Hi all What does '-enable-kvm' option mean? I have heard two versions of answers: a) guest OS would have /dev/kvm device and which could help vm in guest OS (nested vm) b) use /dev/kvm and intel-vt on host OS which

Re: [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize

2014-07-31 Thread Amit Shah
On (Tue) 29 Jul 2014 [19:28:56], John Snow wrote: My previous commit, 713e8a10, did not address the fact that the error checking pathways do not attempt to call virtio_cleanup and thus can leak memory in hotplug scenarios. This patchset shuffles around the error checking so it does not need

[Qemu-devel] [PATCH v1 03/24] monitor: Extract monitor-system.h header

2014-07-31 Thread Benoît Canet
This header will allow to split monitor in two parts. Signed-off-by: Benoit Canet ben...@irqsave.net --- include/monitor/monitor-system.h | 99 monitor.c| 57 ++- 2 files changed, 102 insertions(+), 54

[Qemu-devel] [PATCH v1 02/24] monitor: Make some function public

2014-07-31 Thread Benoît Canet
Next commits will split monitor.c in monitor.c and monitor-system.c. Change some function from static to public in order to prepare this. Signed-off-by: Benoit Canet ben...@irqsave.net --- include/monitor/monitor.h | 10 ++ monitor.c | 24 ++-- 2

[Qemu-devel] [PATCH v1 06/24] monitor: Extract qmp_human_monitor_command into monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 43 +++ monitor.c| 44 2 files changed, 43 insertions(+), 44 deletions(-) diff --git a/monitor-system.c b/monitor-system.c index

[Qemu-devel] [PATCH v1 22/24] qemu-nbd: build QAPI block core into qemu-nbd

2014-07-31 Thread Benoît Canet
Compile and link QAPI block core code into qemu-nbd. This patch circle around unwanted dependecies by stubing some functions in the stubs directory. Signed-off-by: Benoit Canet ben...@irqsave.net --- Makefile| 33 +++-- Makefile.objs

[Qemu-devel] [PATCH v1 04/24] monitor: Make monitor_fprintf public before extracting it

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- disas.c | 10 -- include/monitor/monitor.h | 2 ++ monitor.c | 4 ++-- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/disas.c b/disas.c index 44a019a..b174f26 100644 --- a/disas.c +++

[Qemu-devel] [PATCH v1 16/24] monitor: Move more functions from monitor.c to monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 69 monitor.c| 69 2 files changed, 69 insertions(+), 69 deletions(-) diff --git a/monitor-system.c

[Qemu-devel] [PATCH v1 09/24] monitor: Make do_info_help public

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- include/monitor/monitor-system.h | 1 + monitor.c| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/monitor/monitor-system.h b/include/monitor/monitor-system.h index 6cbf2a4..76d87c7 100644 ---

[Qemu-devel] [PATCH v1 12/24] monitor: Make do_loadvm public before moving it to monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- include/monitor/monitor-system.h | 1 + monitor.c| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/monitor/monitor-system.h b/include/monitor/monitor-system.h index 2e98091..3bc7167 100644 ---

[Qemu-devel] [PATCH v1 17/24] monitor: Move two net functions from monitor.c to monitor-system.c

2014-07-31 Thread Benoît Canet
With this move the monitor.c/monitor-system.c split is complete. Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 49 + monitor.c| 49 - 2 files changed, 49 insertions(+),

[Qemu-devel] [PATCH v1 10/24] monitor: Extract do_info_help in monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 5 + monitor.c| 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor-system.c b/monitor-system.c index 25a132a..f5fb15a 100644 --- a/monitor-system.c +++ b/monitor-system.c @@ -231,3

[Qemu-devel] [PATCH v1 08/24] monitor: Extract a couple of function to monitor-system.c

2014-07-31 Thread Benoît Canet
The extracted function are help_cmd, do_help_cmd, do_trace_event_set_state, and do_trace_file. Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 121 +++ monitor.c| 121

[Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c

2014-07-31 Thread Benoît Canet
This patch will allow to link qmp.o with utility binaries without dragging too much unrelated object files and externals dependencies. Signed-off-by: Benoit Canet ben...@irqsave.net --- Makefile.objs | 2 +- qmp-system.c | 376 ++ qmp.c

[Qemu-devel] [PATCH v1 24/24] qemu-nbd: Add --qmp option to qemu-nbd.

2014-07-31 Thread Benoît Canet
This patch add a -qmp parameter to the qemu-nbd command line in order to be able to manipulate the qemu-nbd block devices via qmp. This could be used with containers to easily migrate from qemu to a container. Signed-off-by: Benoit Canet ben...@irqsave.net --- Makefile.objs |

[Qemu-devel] [PATCH v1 00/24] Extract qmp.c and monitor.c core and wire QMP into qemu-nbd

2014-07-31 Thread Benoît Canet
Hi, Here are the follow up patches to the block QAPI extractions patches. After this patchset the qemu-nbd command has a -qmp parameters allowing the user to execute block related qmp commands. Best regards Benoît Benoît Canet (24): qmp: Extract system emulation related code from qmp.c into

[Qemu-devel] [PATCH v1 14/24] monitor: Make commands public before moving them to monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index d2e56f8..560d5e4 100644 --- a/monitor.c +++ b/monitor.c @@ -173,10 +173,10 @@ static QLIST_HEAD(mon_list, Monitor) mon_list;

[Qemu-devel] [PATCH v1 15/24] monitor: Move mon_cmd_t arrays and some function from monitor.c to monitor-system.c

2014-07-31 Thread Benoît Canet
Also add sizeof variables for mon_cmd_t arrays for cross modules usage. Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 984 monitor.c| 1010 ++ 2 files

[Qemu-devel] [PATCH v1 21/24] monitor: Cleanup monitor.c includes after extracting monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/monitor.c b/monitor.c index 85484c3..bc7f3d3 100644 --- a/monitor.c +++ b/monitor.c @@ -22,64 +22,29 @@ * THE SOFTWARE. */ #include dirent.h

[Qemu-devel] [PATCH v1 05/24] monitor: Extract monitor_fprintf to monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- Makefile.target | 1 + disas.c | 10 ++ include/monitor/monitor-system.h | 3 ++ include/monitor/monitor.h| 2 -- monitor-system.c | 69

[Qemu-devel] [PATCH v1 11/24] monitor: Make some monitor functions public before moving them in monitor-system.c

2014-07-31 Thread Benoît Canet
This will allow monitor.c to access these functions once they are moved in monitor-system.c Signed-off-by: Benoit Canet ben...@irqsave.net --- include/monitor/monitor-system.h | 37 ++ monitor-system.c | 1163 ++ monitor.c

[Qemu-devel] [PATCH v1 23/24] qapi: Add a script to filter qmp-commands-old.h to generate a subset of it.

2014-07-31 Thread Benoît Canet
Since qmp-command-olds.h is generated from qmp-commands.hx we will sometime want to include only a subset of it. For example when linking qapi block commands with qemu-nbd. Signed-off-by: Benoit Canet ben...@irqsave.net --- Makefile | 7 +++

[Qemu-devel] [PATCH v1 20/24] monitor: Extract hardware dependent completion function from monitor.c to monitor-system.c

2014-07-31 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- monitor-system.c | 283 +++ monitor.c| 281 -- 2 files changed, 283 insertions(+), 281 deletions(-) diff --git a/monitor-system.c

Re: [Qemu-devel] [PATCH 4/4] layout: Add generators of L1/L2 tables

2014-07-31 Thread Stefan Hajnoczi
On Thu, Jul 24, 2014 at 04:32:29PM +0400, Maria Kustova wrote: ['I', offset, 0x6803f857, 'ext_magic'], -['I', offset + UINT32_S, len(feature_tables)*48, 'ext_length'] +# Length of one feature table equals to 3 fields and 48 bytes +

Re: [Qemu-devel] [PATCH V4 2/5] runner: Tool for fuzz tests execution

2014-07-31 Thread Stefan Hajnoczi
On Mon, Jul 21, 2014 at 02:18:09PM +0400, Maria Kustova wrote: +def execute(self, input_commands=None, fuzz_config=None): + Execute a test. + +The method creates backing and test images, runs test app and analyzes +its exit status. If the application was killed

Re: [Qemu-devel] [PATCH V4 3/5] fuzz: Fuzzing functions for qcow2 images

2014-07-31 Thread Stefan Hajnoczi
On Mon, Jul 21, 2014 at 02:18:10PM +0400, Maria Kustova wrote: +def random_from_intervals(intervals): +Select a random integer number from the list of specified intervals + +Each interval is a tuple of lower and upper limits of the interval. The +limits are included. Intervals in

<    1   2   3