[Qemu-devel] [Bug 925405] Re: VNC server does not work with Mac Screen Sharing

2014-09-02 Thread Hendrik
affects me as well. versions: qemu-system-common 2.0.0+dfsg-2ubuntu1.2 (current as of 14.04) Mac OS X: 10.9.4, xnu-2422.110.17, Screen Sharing 1.4 (481.1) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-09-02 Thread Alexey Kardashevskiy
On 09/02/2014 03:56 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 11:19 AM, Alexey Kardashevskiy wrote: On 09/02/2014 03:25 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 09:39 AM, Alexey Kardashevskiy wrote: On 09/01/2014 09:23 PM, Aravinda Prasad wrote: On Monday

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Amit Shah
On (Mon) 01 Sep 2014 [20:52:46], Zhang Haoyu wrote: Hi, all I start a VM with virtio-serial (default ports number: 31), and found that virtio-blk performance degradation happened, about 25%, this problem can be reproduced 100%. without virtio-serial: 4k-read-random 1186 IOPS

[Qemu-devel] [PATCH] gtk.c: Fix memory leak in gd_set_keycode_type()

2014-09-02 Thread Chen Fan
this memory leak is introduced by the original commit 3158a3482b0093e41f2b2596fba50774ea31ae08 valgrind out showing: ==14553== 21,459 (72 direct, 21,387 indirect) bytes in 1 blocks are definitely lost in loss record 8,055 of 8,082 ==14553==at 0x4A06BC3: calloc (vg_replace_malloc.c:618)

Re: [Qemu-devel] [PATCH v1 4/6] qom: Move cpu.o to obj-y.

2014-09-02 Thread Paolo Bonzini
Il 02/09/2014 00:56, Peter Crosthwaite ha scritto: On Tue, Sep 2, 2014 at 3:43 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 26 August 2014 01:58, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: It's not really a common object In what sense isn't it a common object? It's only

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-02 Thread Peter Crosthwaite
On Tue, Sep 2, 2014 at 12:13 PM, Gonglei (Arei) arei.gong...@huawei.com wrote: From: peter.crosthwa...@petalogix.com [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite Sent: Tuesday, September 02, 2014 6:51 AM On Mon, Sep 1, 2014 at 3:50 PM, arei.gong...@huawei.com

Re: [Qemu-devel] [PATCH 1/5] s390x/gdb: don't touch the cc if tcg is not enabled

2014-09-02 Thread Christian Borntraeger
On 02/09/14 00:39, Alexander Graf wrote: On 29.08.14 15:52, Jens Freimann wrote: From: David Hildenbrand d...@linux.vnet.ibm.com When reading/writing the psw mask, the condition code may only be touched if running on tcg. Why? Shouldn't we be able to set CC from gdb as well? You

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-09-02 Thread Aravinda Prasad
On Tuesday 02 September 2014 12:04 PM, Alexey Kardashevskiy wrote: On 09/02/2014 03:56 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 11:19 AM, Alexey Kardashevskiy wrote: On 09/02/2014 03:25 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 09:39 AM, Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-02 Thread Gonglei (Arei)
-Original Message- From: peter.crosthwa...@petalogix.com [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite Sent: Tuesday, September 02, 2014 3:00 PM To: Gonglei (Arei) Cc: Huangweidong (C); Michael S. Tsirkin; Luonengjun; qemu-devel@nongnu.org Developers;

[Qemu-devel] arm: vexpress SMP broken?

2014-09-02 Thread Peter Crosthwaite
Hi All, I'm having trouble getting SMP to work on the vexpress platform. Looks like a regression. Following these instructions using latest QEMU: http://wiki.ecg.rice.edu/doku.php?id=xzl:tutorial:arm_qemu section Try ARM Linux prebuilt image on QEMU with addition of -smp 2 argument, it fails

Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module

2014-09-02 Thread Eric Auger
On 09/01/2014 07:41 PM, Alexander Graf wrote: Am 01.09.2014 um 18:31 schrieb Eric Auger eric.au...@linaro.org: On 08/13/2014 09:59 PM, Alex Williamson wrote: On Tue, 2014-08-12 at 08:09 +0200, Eric Auger wrote: On 08/11/2014 09:25 PM, Alex Williamson wrote: On Sat, 2014-08-09 at 15:25

[Qemu-devel] [Bug 1364249] [NEW] guest can't get ip when create guest with bridge using virtio driver.

2014-09-02 Thread chao zhou
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):linux kvm.git Commit:c77dcacb397519b6ade8f08201a4a90a7f4f751e qemu.git Commit:f2c85a2f36f57f155cda7bc9f7c42b44f1a2439e Host Kernel Version:3.16.0

[Qemu-devel] [Bug 1364249] Re: guest can't get ip when create guest with bridge using virtio driver.

2014-09-02 Thread chao zhou
kvm.git+ qemu.git:fd275235_8b303011 kernel version:3.17.0_rc1 test on Ivytown_EP the bug can reproduce -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1364249 Title: guest can't get ip when create

[Qemu-devel] [Bug 1364249] Re: guest can't get ip when create guest with bridge using virtio driver.

2014-09-02 Thread chao zhou
the first bad commit is commit cc943c36faa192cd4b32af8fe5edb31894017d35 Author: Jan Kiszka jan.kis...@siemens.com Date: Sun Jul 27 09:08:29 2014 +0200 pci: Use bus master address space for delivering MSI/MSI-X messages The spec says (and real HW confirms this) that, if the bus master

[Qemu-devel] [PATCH 0/2] fix: unix sockets created for virtio-serail has insufficient permissions

2014-09-02 Thread Chunyan Liu
https://sourceware.org/bugzilla/show_bug.cgi?id=13078#c11 https://bugzilla.novell.com/show_bug.cgi?id=888166 To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g.: -device virtio-serial \ -chardev

[Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Chunyan Liu
To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev socket,path=/tmp/foo,server,nowait,id=foo \ -device virtserialport,chardev=foo,name=org.fedoraproject.port.0 Check

[Qemu-devel] [PATCH 2/2] qemu: add umask(002) to virtio-serial chardev commandline

2014-09-02 Thread Chunyan Liu
To use virtio-serial device, unix socket created for communication with default umask(022) has insufficient permissions. e.g. 1. Setup a virtual machine with a virtio-serial device: # virsh edit myvm (...) channel type='unix' source mode='bind' path='/tmp/somefile.sock'/ target

[Qemu-devel] [PATCH 07/14] console: add qemu_pixman_linebuf_copy

2014-09-02 Thread Gerd Hoffmann
Helper function for copying data from linebuf to framebuffer using pixman, possibly converting in case src and dst formats differ. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/qemu-pixman.h | 2 ++ ui/qemu-pixman.c | 9 + 2 files changed, 11 insertions(+) diff

[Qemu-devel] [PATCH 11/14] pl110: move resize

2014-09-02 Thread Gerd Hoffmann
Handle display resizes in the update callback. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/pl110.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/hw/display/pl110.c b/hw/display/pl110.c index 78b146b..f788382 100644 ---

[Qemu-devel] [PATCH 05/14] console: add qemu_create_displaysurface_guestmem

2014-09-02 Thread Gerd Hoffmann
This patch adds a qemu_create_displaysurface_guestmem helper function. Works simliar to qemu_create_displaysurface_from, but accepts a guest address instead of a host pointer and it handles cpu_physical_memory_{map,unmap} for you. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 00/14] console/pl110: pixman conversion continued

2014-09-02 Thread Gerd Hoffmann
Hi, Here is a two-in-one patch series. The first part makes the console code use pixman format codes internally. It also adds some helper functions for gfx emulation code. If you wanna see that in action check the second part of the series ;) I consider the first part being close to ready

[Qemu-devel] [PATCH 09/14] pl110: add framebuffer_update_display_swap_pixman

2014-09-02 Thread Gerd Hoffmann
Works like framebuffer_update_display, but accepts a (newly introduced) swapmode and a pixman format instead of a callback function. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/framebuffer.c | 129 +++ hw/display/framebuffer.h | 17

[Qemu-devel] [PATCH 14/14] [wip] pl110: start handling paletted images via pixman

2014-09-02 Thread Gerd Hoffmann
Supporting paletted images in pixman turned out to be pretty easy ;) Pixman supports 1+4+8 bit/pixel, 2 bpp is missing. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/framebuffer.c| 2 ++ hw/display/framebuffer.h| 1 + hw/display/pl110.c | 20

[Qemu-devel] [PATCH 03/14] console: reimplement qemu_default_pixelformat

2014-09-02 Thread Gerd Hoffmann
Use the new qemu_pixelformat_from_pixman and qemu_default_pixman_format functions to reimplement qemu_default_pixelformat (qemu_different_endianness_pixelformat too). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 117 ++-

[Qemu-devel] [PATCH 06/14] console: add dpy_gfx_update_dirty

2014-09-02 Thread Gerd Hoffmann
Calls dpy_gfx_update for all dirty scanlines. Works for DisplaySurfaces backed by guest memory (i.e. the ones created using qemu_create_displaysurface_guestmem). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 4 ui/console.c | 61

[Qemu-devel] [PATCH 10/14] pl100: Drop support for depths other than 32bpp.

2014-09-02 Thread Gerd Hoffmann
DisplaySurfaces created by qemu_create_displaysurface (called indirectly via by qemu_console_resize) are always 32bpp in host byte order. So this is the only format we have to support when converting the guest framebuffer for the host user interface (i.e. gtk / vnc / ...). Signed-off-by: Gerd

[Qemu-devel] [PATCH 12/14] [wip] pl110: start using pixman

2014-09-02 Thread Gerd Hoffmann
Turn pl110_draw_fn into a struct, carrying both conversion function and pixman format for a given guest framebuffer layout. Create a DisplaySurface backed by guest memory in case pixman can handle the format, thereby collecting the low-hanging fruits. A common case (linux kernel running pl111

[Qemu-devel] [PATCH v4 0/4] Refactor device_set_realized to avoid resource leak.

2014-09-02 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com after committing [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API If devcie hotplugging failed, will casuse resource leak. This patch series include address resouce leak and two other issuses. v4 - v3: - add patch

Re: [Qemu-devel] Running programs that dynamically generate code

2014-09-02 Thread Byron Hawkins
-Original Message- From: Peter Maydell [mailto:peter.mayd...@linaro.org] Sent: Friday, August 29, 2014 2:23 AM To: Byron Hawkins Cc: QEMU Developer List Subject: Re: [Qemu-devel] Running programs that dynamically generate code On 29 August 2014 03:24, Byron Hawkins

Re: [Qemu-devel] [PATCH v4 1/4] qdev: using error_abort instead of using local_err

2014-09-02 Thread Gonglei (Arei)
From: Gonglei (Arei) Sent: Tuesday, September 02, 2014 4:04 PM Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err Importance: High From: Gonglei arei.gong...@huawei.com This error can not happen normally. If it happens indicates something very wrong, we should

Re: [Qemu-devel] [PATCH v4 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread Peter Crosthwaite
On Tue, Sep 2, 2014 at 6:04 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Forcefully unrealize all children regardless of early-iteration errors(if happened). We should keep going with cleanup operation rather than report a error immediately. Signed-off-by:

Re: [Qemu-devel] [PATCH v4 1/4] qdev: using error_abort instead of using local_err

2014-09-02 Thread Michael S. Tsirkin
On Tue, Sep 02, 2014 at 08:19:22AM +, Gonglei (Arei) wrote: From: Gonglei (Arei) Sent: Tuesday, September 02, 2014 4:04 PM Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err Importance: High From: Gonglei arei.gong...@huawei.com This error can not

[Qemu-devel] [PATCH v2] dump: let dump_error return error info to caller

2014-09-02 Thread zhanghailiang
The second parameter of dump_error is unused, but one purpose of using this function is to report the error info. Use error_set to return the error info to the caller. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- V2: - Return the error reason to the caller which suggested by

Re: [Qemu-devel] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael S. Tsirkin
On Wed, Aug 27, 2014 at 12:35:57PM -0500, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v2.1.1: https://github.com/mdroth/qemu/commits/stable-2.1-staging The release is planned for 2014-09-08: http://wiki.qemu.org/Planning/2.1 Please

Re: [Qemu-devel] [PATCH v4 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread Gonglei (Arei)
Forcefully unrealize all children regardless of early-iteration errors(if happened). We should keep going with cleanup operation rather than report a error immediately. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/core/qdev.c | 9 +++-- 1 file changed, 3

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-09-02 Thread Alexey Kardashevskiy
On 09/02/2014 05:07 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 12:04 PM, Alexey Kardashevskiy wrote: On 09/02/2014 03:56 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 11:19 AM, Alexey Kardashevskiy wrote: On 09/02/2014 03:25 PM, Aravinda Prasad wrote: On Tuesday

[Qemu-devel] [PATCH v1 3/6] memory: Add address_space_init_shareable()

2014-09-02 Thread Peter Crosthwaite
This will either create a new AS or return a pointer to an already existing equivalent one. Both name and root mr must match. The motivation is to reuse address spaces as much as possible. It's going to be quite common that bus masters out in device land have pointers to the same memory region

Re: [Qemu-devel] arm: vexpress SMP broken?

2014-09-02 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 05:12:26PM +1000, Peter Crosthwaite wrote: Hi All, I'm having trouble getting SMP to work on the vexpress platform. Looks like a regression. Following these instructions using latest QEMU: http://wiki.ecg.rice.edu/doku.php?id=xzl:tutorial:arm_qemu section Try

Re: [Qemu-devel] [PATCH v1 0/6] PMA phase 2 - per CPU address spaces

2014-09-02 Thread Peter Crosthwaite
On Tue, Sep 2, 2014 at 3:40 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 26 August 2014 01:56, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi All, This series sets up CPUs with configurable address spaces. This follows on from Edgars original work and moves towards

Re: [Qemu-devel] [PATCH v4 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread Peter Crosthwaite
On Tue, Sep 2, 2014 at 6:39 PM, Gonglei (Arei) arei.gong...@huawei.com wrote: Forcefully unrealize all children regardless of early-iteration errors(if happened). We should keep going with cleanup operation rather than report a error immediately. Signed-off-by: Gonglei

Re: [Qemu-devel] Running programs that dynamically generate code

2014-09-02 Thread Peter Maydell
On 2 September 2014 09:16, Byron Hawkins byr...@uci.edu wrote: Thanks Peter. Can you tell me how much translated code is flushed when a write is detected in an executable region? Is it just the code translated from the one modified page? It should just be the code translated in that page

Re: [Qemu-devel] [PATCH v4 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread Gonglei (Arei)
From: peter.crosthwa...@petalogix.com Forcefully unrealize all children regardless of early-iteration errors(if happened). We should keep going with cleanup operation rather than report a error immediately. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/core/qdev.c

Re: [Qemu-devel] arm: vexpress SMP broken?

2014-09-02 Thread Alex Bligh
On 2 Sep 2014, at 09:44, Stefan Hajnoczi stefa...@redhat.com wrote: No but it does seem something is broken with timers. The CPU1: Booted secondary processor message comes from the second CPU. The first CPU is waiting for it to come online. The timeout code is probably misbehaving. Yup.

Re: [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Daniel P. Berrange
On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev socket,path=/tmp/foo,server,nowait,id=foo \ -device

[Qemu-devel] [PULL 2/2] spice: use console index as display id

2014-09-02 Thread Gerd Hoffmann
... instead of maintaining our own numbering. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 1a2fb4b..17a2ed3 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@

[Qemu-devel] [PULL 1/2] qxl-render: add more sanity checks

2014-09-02 Thread Gerd Hoffmann
Damn, the dirty rectangle values are signed integers. So the checks added by commit 788fbf042fc6d5aaeab56757e6dad622ac5f0c21 are not good enough, we also have to make sure they are not negative. [ Note: There must be something broken in spice-server so we get negative values in the first

[Qemu-devel] [PULL 0/2] spice patch queue

2014-09-02 Thread Gerd Hoffmann
/tags/pull-target-arm-20140829' into staging (2014-08-29 15:48:15 +0100) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140902-1 for you to fetch changes up to cd56cc6b079f44fbcca3d8a773ae87f7479c6585: spice: use console index as display id

Re: [Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-09-02 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 07:40:18PM +0100, Stefan Hajnoczi wrote: On Tue, Aug 26, 2014 at 04:06:17PM +0800, zhanghailiang wrote: For all NICs(except virtio-net) emulated by qemu, Such as e1000, rtl8139, pcnet and ne2k_pci, Qemu can still receive packets when VM is not running. If this

Re: [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Chun Yan Liu
On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient

Re: [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Daniel P. Berrange
On Tue, Sep 02, 2014 at 03:08:51AM -0600, Chun Yan Liu wrote: On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-09-02 Thread Peter Lieven
On 22.08.2014 05:57, Amit Shah wrote: On (Thu) 21 Aug 2014 [23:57:46], Peter Lieven wrote: Am 11.07.2014 um 14:52 schrieb Amit Shah amit.s...@redhat.com: On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: On 9 July 2014 11:56, Amit Shah amit.s...@redhat.com wrote: On (Wed) 09 Jul 2014

[Qemu-devel] [PATCH] ui/vnc: set TCP_NODELAY

2014-09-02 Thread Peter Lieven
we currently have the Nagle algorithm enabled for all outgoing VNC updates. This may delay sensitive updates as mouse movements or typing in the console. As we currently prepare all data in a buffer and then send as much as we can this should not cause big trouble. Well established VNC servers

Re: [Qemu-devel] tcmu-runner and QEMU

2014-09-02 Thread Stefan Hajnoczi
On Fri, Aug 29, 2014 at 07:22:18PM +0200, Benoît Canet wrote: Listening at Palo's suggestion I started discussing privately with Andy about integrating LIO and the QEMU block layer together using tcmu-runner: https://github.com/agrover/tcmu-runner. I looked at this briefly when Andy posted the

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-09-02 Thread Aravinda Prasad
On Tuesday 02 September 2014 02:10 PM, Alexey Kardashevskiy wrote: On 09/02/2014 05:07 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 12:04 PM, Alexey Kardashevskiy wrote: On 09/02/2014 03:56 PM, Aravinda Prasad wrote: On Tuesday 02 September 2014 11:19 AM, Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH] ui/vnc: set TCP_NODELAY

2014-09-02 Thread Peter Maydell
On 2 September 2014 10:21, Peter Lieven p...@kamp.de wrote: we currently have the Nagle algorithm enabled for all outgoing VNC updates. This may delay sensitive updates as mouse movements or typing in the console. As we currently prepare all data in a buffer and then send as much as we can

Re: [Qemu-devel] [PATCH v5] block: Introduce null drivers

2014-09-02 Thread Stefan Hajnoczi
On Mon, Sep 01, 2014 at 05:22:04PM +0800, Fam Zheng wrote: +{ 'type': 'BlockdevOptionsNull', + 'base': 'BlockdevOptionsFile', + 'data': { '*size': 'int' } } Why inherit from BlockdevOptionsFile? No other blockdev options type does that. Unless there is a real inheritance relationship,

Re: [Qemu-devel] [PATCH v2 12/12] pl031: add missed field to vmstate

2014-09-02 Thread Pavel Dovgaluk
From: Peter Maydell [mailto:peter.mayd...@linaro.org] On 28 August 2014 12:19, Pavel Dovgalyuk pavel.dovga...@ispras.ru wrote: This patch adds timer which uses virtual clock to the VMState. Such timers are required for saving because virtual clock is the part of the virtual machine state.

Re: [Qemu-devel] [PATCH] ui/vnc: set TCP_NODELAY

2014-09-02 Thread Peter Lieven
On 02.09.2014 11:36, Peter Maydell wrote: On 2 September 2014 10:21, Peter Lieven p...@kamp.de wrote: we currently have the Nagle algorithm enabled for all outgoing VNC updates. This may delay sensitive updates as mouse movements or typing in the console. As we currently prepare all data in a

Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-02 Thread Stefan Hajnoczi
On Mon, Sep 01, 2014 at 11:11:37PM +0200, Marc Marí wrote: El Mon, 1 Sep 2014 18:27:34 +0200 Marc Marí marc.mari.barc...@gmail.com escribió: El Mon, 1 Sep 2014 18:09:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com escribió: On Mon, 1 Sep 2014 12:07:58 +0200 Marc Marí

[Qemu-devel] [PATCH v2 1/2] qemu-img: clarify src_cache option documentation

2014-09-02 Thread Stefan Hajnoczi
The source cache option takes the same values as the cache option. The documentation reads a little strange because it starts with In contrast the src_cache option The fact that this is comparing with the previous documented option (the 'cache' option) is implicit. Readers may be confused,

[Qemu-devel] [PATCH v2 0/2] qemu-img: src_mode option documentation improvements

2014-09-02 Thread Stefan Hajnoczi
v2: * Fix backing file files - backing files typo [Fam] These patches clarify and fix the documentation for the recent qemu-img src_mode (-T) option. Stefan Hajnoczi (2): qemu-img: clarify src_cache option documentation qemu-img: fix rebase src_cache option documentation qemu-img.c| 3

[Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option documentation

2014-09-02 Thread Stefan Hajnoczi
The src_cache option (-T) specifies the cache mode for backing files. It applies both the image's old backing file as well as the new backing file: ret = bdrv_open(bs_old_backing, backing_name, NULL, NULL, src_flags, old_backing_drv, local_err); if (ret) { ... } if

Re: [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Chun Yan Liu
On 9/2/2014 at 05:16 PM, in message 20140902091655.gb21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:08:51AM -0600, Chun Yan Liu wrote: On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange

Re: [Qemu-devel] [PATCH v2 0/2] block: Always compile virtio-blk dataplane

2014-09-02 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 11:42:14AM +0800, Fam Zheng wrote: v2: Import virtio_vring.h. Fam Zheng (2): virtio: Import virtio_vring.h block: Always compile virtio-blk dataplane configure | 21 + hw/block/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI

2014-09-02 Thread Peter Maydell
Convert the udp char backend to the new style QAPI framework. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- qemu-char.c | 69 +++-- 1 file changed, 54 insertions(+), 15 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH v2 2/5] util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram()

2014-09-02 Thread Peter Maydell
Currently you can specify whether you want a UDP chardev backend to be IPv4 or IPv6 using the ipv4 or ipv6 options if you use the QemuOpts parsing code in inet_dgram_opts(). However the QMP struct parsing code in socket_dgram() doesn't provide this flexibility (which in turn prevents us from

[Qemu-devel] [PATCH v2 1/5] qemu-char: Convert socket backend to QAPI

2014-09-02 Thread Peter Maydell
Convert the socket char backend to the new style QAPI framework; this allows it to return an Error ** to callers who might not want it to print directly about socket failures. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- qemu-char.c | 112

[Qemu-devel] [PATCH v2 5/5] qemu-char: Rename register_char_driver_qapi() to register_char_driver()

2014-09-02 Thread Peter Maydell
Now we have removed the legacy register_char_driver() we can rename register_char_driver_qapi() to the more obvious and shorter name. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- backends/baum.c | 2 +- backends/msmouse.c| 2 +- backends/testdev.c| 2 +-

[Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI

2014-09-02 Thread Peter Maydell
This patchset converts the two remaining legacy chardevs ('socket' and 'udp') to use the new-style parse/kind mechanisms, and removes all the no-longer-required legacy machinery. Patch 1 was posted to the list back in June (https://patches.linaro.org/32298/). I've fixed the obvious bug picked up

Re: [Qemu-devel] [PULL 0/2] spice patch queue

2014-09-02 Thread Peter Maydell
8b3030114a449e66c68450acaac4b66f26d91416: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140829' into staging (2014-08-29 15:48:15 +0100) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140902-1 for you to fetch changes up

[Qemu-devel] [PATCH v2 4/5] qemu-char: Remove register_char_driver() machinery

2014-09-02 Thread Peter Maydell
Now that all the char backends have been converted to the QAPI framework we can remove the machinery for handling old style backends. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/sysemu/char.h | 1 - qemu-char.c | 126

Re: [Qemu-devel] [PATCH] slirp: Honour vlan/stack in hostfwd_remove commands

2014-09-02 Thread Peter Maydell
On 8 July 2014 12:40, Peter Maydell peter.mayd...@linaro.org wrote: On 26 June 2014 13:35, Peter Maydell peter.mayd...@linaro.org wrote: On 16 June 2014 16:47, Peter Maydell peter.mayd...@linaro.org wrote: The hostfwd_add and hostfwd_remove monitor commands allow the user to optionally specify

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_hcall.c: Fix typo in function names

2014-09-02 Thread Peter Maydell
On 8 July 2014 16:05, Alexander Graf ag...@suse.de wrote: On 08.07.14 17:02, Peter Maydell wrote: Fix a typo in the names of a couple of functions (s/resouce/resource/). Signed-off-by: Peter Maydell peter.mayd...@linaro.org Thanks, applied to ppc-next-2.2. Ping? This doesn't seem to

Re: [Qemu-devel] [PATCH] slirp: Honour vlan/stack in hostfwd_remove commands

2014-09-02 Thread Jan Kiszka
On 2014-09-02 12:33, Peter Maydell wrote: On 8 July 2014 12:40, Peter Maydell peter.mayd...@linaro.org wrote: On 26 June 2014 13:35, Peter Maydell peter.mayd...@linaro.org wrote: On 16 June 2014 16:47, Peter Maydell peter.mayd...@linaro.org wrote: The hostfwd_add and hostfwd_remove monitor

Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-09-02 Thread Stefan Hajnoczi
On Thu, Aug 28, 2014 at 03:41:25PM +0800, Jason Wang wrote: Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean

Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix rebase src_cache option documentation

2014-09-02 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 10:52:53AM +0800, Fam Zheng wrote: On Mon, 09/01 16:11, Stefan Hajnoczi wrote: The src_cache option (-T) specifies the cache mode for backing files. It applies both the image's old backing file as well as the new backing file: ret = bdrv_open(bs_old_backing,

Re: [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev

Re: [Qemu-devel] [PATCH v3 2/8] block: Add bdrv_aio_cancel_async

2014-09-02 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 10:49:10AM +0800, Fam Zheng wrote: +/* Async version of aio cancel. The caller is not blocked if the acb implements + * cancel_async, otherwise fall back to bdrv_aio_cancel. In both cases, acb-cb + * is guarenteed to be called, before or after function returns. */

[Qemu-devel] [PATCH v2 0/4] pcie: Add support for Single Root I/O Virtualization

2014-09-02 Thread Knut Omang
This patch set implements generic support for SR/IOV as an extension to the core PCIe functionality, similar to the way other capabilities such as AER is implemented. There is no implementation of any device that provides SR/IOV support included, but I have implemented a test example which can

[Qemu-devel] [PATCH v2 4/4] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2014-09-02 Thread Knut Omang
This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang knut.om...@oracle.com --- hw/pci/Makefile.objs| 2 +- hw/pci/pci.c| 97

[Qemu-devel] [PATCH v2 3/4] pci: Update pci_regs header

2014-09-02 Thread Knut Omang
Pulls in latest version from kernel v3.16 msi: Removed local definitions now in pci_regs.h Also replace usage of PCI_MSIX_FLAGS_BIRMASK with PCI_MSIX_TABLE_BIR to keep in sync with the kernel for future updates. Signed-off-by: Knut Omang knut.om...@oracle.com --- hw/i386/kvm/pci-assign.c | 4

[Qemu-devel] [PATCH v2 1/4] pci: Make use of the devfn property when registering new devices

2014-09-02 Thread Knut Omang
Without this, the devfn argument to pci_create_*() does not affect the assigned devfn. Needed to support (VF_STRIDE,VF_OFFSET) values other than (1,1) for SR/IOV. Signed-off-by: Knut Omang knut.om...@oracle.com --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 2/4] pci: Avoid losing config updates to MSI/MSIX cap regs

2014-09-02 Thread Knut Omang
Introduce an extra local variable to avoid that the shifting in the for loop causes updates to msi/msix capability registers to get lost in pci_default_write_config. Signed-off-by: Knut Omang knut.om...@oracle.com --- hw/pci/pci.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-02 Thread Greg Kurz
On Mon, 1 Sep 2014 18:27:34 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: El Mon, 1 Sep 2014 18:09:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com escribió: On Mon, 1 Sep 2014 12:07:58 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH v2 0/3] target-sparc: fixed unused function warnings

2014-09-02 Thread Peter Maydell
These patchsets fix clang 3.4 warnings about unused static inline functions (clang now warns about these if they're defined in a .c file but then not used; gcc doesn't). The first patch just removes two totally unused functions; the second two patches use ifdeffery to avoid defining the functions

[Qemu-devel] [PATCH v2 3/3] target-sparc: is_translating_asi() is TARGET_SPARC64 only

2014-09-02 Thread Peter Maydell
Move the is_translating_asi() inside the TARGET_SPARC64 ifdef (and remove the unimplemented 32-bit codepath), as it is only called from TARGET_SPARC64 code. This fixes a clang 3.4 unused-function warning. Again, this allows us to remove an 'inline' tag that was there largely to suppress gcc

[Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only

2014-09-02 Thread Peter Maydell
The address_mask() and asi_address_mask() functions are only used in TARGET_SPARC64 configs, so guard with ifdefs to avoid warnings about unused functions in 32-bit builds. Since the main reason these functions were marked 'inline' was to suppress unused-function warnings with gcc, we remove the

[Qemu-devel] [PATCH v2 1/3] target-sparc: Remove unused gen_op_subi_cc and gen_op_addi_cc

2014-09-02 Thread Peter Maydell
The functions gen_op_addi_cc() and gen_op_subi_cc() are unused; remove them. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-sparc/translate.c | 24 1 file changed, 24 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index

[Qemu-devel] [PATCH v5 0/4] Refactor device_set_realized to avoid resource leak.

2014-09-02 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com after committing [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API If devcie hotplugging failed, will casuse resource leak. This patch series include address resouce leak and two other issuses. v5 - v4: - add patch 1/4

[Qemu-devel] [PATCH v5 4/4] pcie: don't assert when hotplug a PCIe device with 'function != 0'

2014-09-02 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com It's enough to report an error. Assert() is not acceptable because the error is not a fatal error. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/pci/pcie.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie.c

[Qemu-devel] [PATCH v5 3/4] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-02 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com At present, this function doesn't have partial cleanup implemented, which will cause resource leak in some scenarios. Example: 1. Assuming that dc-realize(dev, local_err) execute successful and local_err == NULL; 2. Executing device hotplug in

[Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of using local_err

2014-09-02 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com This error can not happen normally. If it happens indicates something very wrong, we should abort QEMU. moreover, The user can only refer to /machine/peripheral, not /machine/unattached. Meanwhile remove superfluous check about local_err. Signed-off-by:

[Qemu-devel] [PATCH v5 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Forcefully unrealize all children regardless of early-iteration errors(if happened). We should keep going with cleanup operation rather than report a error immediately, meanwhile store the first child unrealize failure and propagate it at the end. We also

Re: [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in archive symbols

2014-09-02 Thread Paolo Bonzini
Il 02/09/2014 03:19, Fam Zheng ha scritto: Thanks both of you for tracking down the problem. Let's add 2/dev/null to suppress the warning. Actually I think the warning would complicate tracking down real problems. We can fix the source of the warnings, especially since they already occur with

Re: [Qemu-devel] KVM call for agenda for 2014-09-02

2014-09-02 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. As there are no topics, call gets cancelled. Have a nice day, Juan. Thanks, Juan. Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every two weeks By popular demand, a google

Re: [Qemu-devel] sparc64/virtio: unable to init msix vectors to 2

2014-09-02 Thread Mark Cave-Ayland
On 27/08/14 07:15, Mark Cave-Ayland wrote: Hi all, When creating a qemu-system-sparc64 machine with a virtio interface, both QEMU 2.1.0 and current git master emit the above warning: $ ./qemu-system-sparc64 -drive file=/tmp/file.txt,if=virtio,index=0 -nographic qemu-system-sparc64: -drive

[Qemu-devel] [PATCH] block/archipelago: Use QEMU atomic builtins

2014-09-02 Thread Chrysostomos Nanakos
Replace __sync builtins with ones provided by QEMU for atomic operations. Special thanks goes to Paolo Bonzini for his refactoring suggestion in order to use the already existing atomic builtins interface. Signed-off-by: Chrysostomos Nanakos cnana...@grnet.gr --- block/archipelago.c | 76

Re: [Qemu-devel] ARM Cortex-M IRQs can not be globally disabled

2014-09-02 Thread Peter Maydell
On 1 September 2014 19:34, David Hoover s...@boiteauxlettres.sent.at wrote: Hi, It seems that interrupts are not disabled by CPSIE instruction. The current code apparently ignores (daifPSTATE_I) for Cortex-M. The patch below is basically identical to the patch that was attached to the

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-02 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer gham...@redhat.com --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py

[Qemu-devel] [PATCH 0/2 V2] Virtual Machine Generation ID

2014-09-02 Thread Gal Hammer
Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The first one add a new ACPI directive which allow to use a 16-bytes buffer in an ACPI table. This buffer is for storing the VM's UUID. The second is the ACPI tables changes and the actual device.

  1   2   3   >