Re: [Qemu-devel] [PATCH 02/17] ppc: avoid excessive TLB flushing

2014-09-05 Thread David Gibson
On Thu, Aug 28, 2014 at 09:35:27PM +0200, Paolo Bonzini wrote: Il 28/08/2014 19:30, Peter Maydell ha scritto: On 28 August 2014 18:14, Paolo Bonzini pbonz...@redhat.com wrote: [snip] Does PPC hardware do lots of TLB flushes on user-kernel transitions, or does it have some sort of info in

Re: [Qemu-devel] [libvirt] NBD TLS support in QEMU

2014-09-05 Thread Michal Privoznik
On 03.09.2014 18:44, Stefan Hajnoczi wrote: Hi, QEMU offers both NBD client and server functionality. The NBD protocol runs unencrypted, which is a problem when the client and server communicate over an untrusted network. This is not problem for NBD only, but for the rest of data that qemu

[Qemu-devel] [PATCH] target-ppc: Fix kvmppc_set_compat to use negotiated cpu-version

2014-09-05 Thread Alexey Kardashevskiy
By mistake, QEMU uses the maximum compatibility level from the command line instead of the value negotiated in client-architecture-support call. This replaces @max_compat with @cpu_version. This only affects guests which do not support the host CPU. Signed-off-by: Alexey Kardashevskiy

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/17] ppc: avoid excessive TLB flushing

2014-09-05 Thread Alexander Graf
On 28.08.14 19:14, Paolo Bonzini wrote: PowerPC TCG flushes the TLB on every IR/DR change, which basically means on every user-kernel context switch. Use the 6-element TLB array as a cache, where each MMU index is mapped to a different state of the IR/DR/PR/HV bits. This brings the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/17] ppc: fix monitor access to CR

2014-09-05 Thread Alexander Graf
On 03.09.14 20:21, Tom Musta wrote: On 8/28/2014 12:14 PM, Paolo Bonzini wrote: This was off-by-one. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 34cee74..ec73dd4 100644

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/17] ppc: use CRF_* in int_helper.c

2014-09-05 Thread Alexander Graf
On 03.09.14 20:28, Tom Musta wrote: On 8/28/2014 12:15 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-ppc/int_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c

Re: [Qemu-devel] [PATCH 2/3] s390x/css: support format-0 ccws

2014-09-05 Thread Christian Borntraeger
On 05/09/14 00:29, Alexander Graf wrote: On 04.09.14 17:32, Jens Freimann wrote: From: Cornelia Huck cornelia.h...@de.ibm.com Add support for format-0 ccws in channel programs. As a format-1 ccw contains the same information as format-0 ccws, only supporting larger addresses, simply

Re: [Qemu-devel] [PATCH 2/3] s390x/css: support format-0 ccws

2014-09-05 Thread Alexander Graf
On 05.09.14 09:23, Christian Borntraeger wrote: On 05/09/14 00:29, Alexander Graf wrote: On 04.09.14 17:32, Jens Freimann wrote: From: Cornelia Huck cornelia.h...@de.ibm.com Add support for format-0 ccws in channel programs. As a format-1 ccw contains the same information as format-0

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/17] ppc: fix result of DLMZB when no zero bytes are found

2014-09-05 Thread Alexander Graf
On 03.09.14 20:28, Tom Musta wrote: On 8/28/2014 12:15 PM, Paolo Bonzini wrote: It must return 8 and place 8 in XER, but the current code uses i directly which is 9 at this point of the code. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-ppc/int_helper.c | 1 + 1 file

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/17] ppc: rename gen_set_cr6_from_fpscr

2014-09-05 Thread Alexander Graf
On 03.09.14 21:41, Tom Musta wrote: On 8/28/2014 12:15 PM, Paolo Bonzini wrote: It sets CR1, not CR6 (and the spec agrees). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-ppc/translate.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/5] s390x/gdb: don't touch the cc if tcg is not enabled

2014-09-05 Thread Christian Borntraeger
On 03/09/14 11:27, Alexander Graf wrote: On 02.09.14 09:07, Christian Borntraeger wrote: On 02/09/14 00:39, Alexander Graf wrote: On 29.08.14 15:52, Jens Freimann wrote: From: David Hildenbrand d...@linux.vnet.ibm.com When reading/writing the psw mask, the condition code may only be

Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/17] ppc: compute mask from BI using right shift

2014-09-05 Thread Alexander Graf
On 03.09.14 22:59, Tom Musta wrote: On 8/28/2014 12:15 PM, Paolo Bonzini wrote: This will match the code we use in fpu_helper.c when we flip CRF_* bit-endianness. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-ppc/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PATCH 3/3] s390x/css: catch ccw sequence errors

2014-09-05 Thread Jens Freimann
From: Cornelia Huck cornelia.h...@de.ibm.com We must not allow chains of more than 255 ccws without data transfer. Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 0/3 RESEND] s390x: css patches and small sclp cleanup

2014-09-05 Thread Jens Freimann
Cornelia, Christian, Alex, here are two css patches and a small sclp cleanup. Patch 1 remove duplicate defines in SCLP code Patch 2 adds support for format-0 ccws Patch 3 a css bugfix adding a limit of 255 to ccws chains without data transfer regards Jens Cornelia Huck (2): s390x/css:

[Qemu-devel] [PATCH 2/3] s390x/css: support format-0 ccws

2014-09-05 Thread Jens Freimann
From: Cornelia Huck cornelia.h...@de.ibm.com Add support for format-0 ccws in channel programs. As a format-1 ccw contains the same information as format-0 ccws, only supporting larger addresses, simply convert every ccw to format-1 as we walk the chain. Reviewed-by: David Hildenbrand

[Qemu-devel] [PATCH 1/3] s390x: remove duplicate defines in SCLP code

2014-09-05 Thread Jens Freimann
Let's get rid of these duplicate defines. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com --- include/hw/s390x/sclp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index 5c43574..ec07a11 100644 --- a/include/hw/s390x/sclp.h +++

Re: [Qemu-devel] [PATCH] target-ppc: Fix kvmppc_set_compat to use negotiated cpu-version

2014-09-05 Thread Alexander Graf
On 05.09.14 09:04, Alexey Kardashevskiy wrote: By mistake, QEMU uses the maximum compatibility level from the command line instead of the value negotiated in client-architecture-support call. This replaces @max_compat with @cpu_version. This only affects guests which do not support the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/4] target-ppc: Extend rtas-blob

2014-09-05 Thread Alexander Graf
On 04.09.14 13:13, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Signed-off-by: Aravinda Prasad aravi...@linux.vnet.ibm.com --- hw/ppc/spapr.c |4 1 file changed, 4 insertions(+)

Re: [Qemu-devel] [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Frank Blaschka
On Thu, Sep 04, 2014 at 07:16:24AM -0600, Alex Williamson wrote: On Thu, 2014-09-04 at 12:52 +0200, frank.blasc...@de.ibm.com wrote: This set of patches implements pci pass-through support for qemu/KVM on s390. PCI support on s390 is very different from other platforms. Major differences

Re: [Qemu-devel] [CVE-2014-3615 PATCH v2 3/3] spice: make sure we don't overflow ssd-buf

2014-09-05 Thread Laszlo Ersek
On 09/04/14 09:04, Gerd Hoffmann wrote: Related spice-only bug. We have a fixed 16 MB buffer here, being presented to the spice-server as qxl video memory in case spice is used with a non-qxl card. It's also used with qxl in vga mode. When using display resolutions requiring more than 16

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/4] target-ppc: Extend rtas-blob

2014-09-05 Thread Aravinda Prasad
On Friday 05 September 2014 01:12 PM, Alexander Graf wrote: On 04.09.14 13:13, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Signed-off-by: Aravinda Prasad aravi...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] target-ppc: Build error log

2014-09-05 Thread Alexander Graf
On 04.09.14 13:13, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If the memory address in error belongs to guest address space then guest kernel is responsible to take action.

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-09-05 Thread Zhangjie (HZ)
On 2014/9/1 16:18, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 06:40:24PM +0800, Zhangjie (HZ) wrote: On 2014/8/27 20:59, Michael S. Tsirkin wrote: On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: On 2014/8/21 14:53, Jason Wang wrote: On 08/21/2014 02:28 PM, Zhangjie

Re: [Qemu-devel] [PATCH v2 3/4] target-ppc: Build error log

2014-09-05 Thread Aravinda Prasad
On Friday 05 September 2014 07:44 AM, Alexey Kardashevskiy wrote: On 09/04/2014 09:13 PM, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If the memory address in error belongs to

Re: [Qemu-devel] [libvirt] NBD TLS support in QEMU

2014-09-05 Thread Daniel P. Berrange
On Fri, Sep 05, 2014 at 08:23:17AM +0200, Michal Privoznik wrote: On 03.09.2014 18:44, Stefan Hajnoczi wrote: Hi, QEMU offers both NBD client and server functionality. The NBD protocol runs unencrypted, which is a problem when the client and server communicate over an untrusted network.

Re: [Qemu-devel] NBD TLS support in QEMU

2014-09-05 Thread Daniel P. Berrange
On Fri, Sep 05, 2014 at 12:02:18AM +0200, Wouter Verhelst wrote: [Cc: to nbd-general list added] On Wed, Sep 03, 2014 at 05:44:17PM +0100, Stefan Hajnoczi wrote: Hi, QEMU offers both NBD client and server functionality. The NBD protocol runs unencrypted, which is a problem when the

Re: [Qemu-devel] [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Alexander Graf
On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: This set of patches implements pci pass-through support for qemu/KVM on s390. PCI support on s390 is very different from other platforms. Major differences are: 1) all PCI operations are driven by special s390 instructions 2) all s390

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] target-ppc: Build error log

2014-09-05 Thread Aravinda Prasad
On Friday 05 September 2014 01:34 PM, Alexander Graf wrote: On 04.09.14 13:13, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If the memory address in error belongs to guest

Re: [Qemu-devel] [RFC][patch 3/6] KVM: s390: Add GISA support

2014-09-05 Thread Alexander Graf
On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch adds GISA (Guest Interrupt State Area) support to s390 kvm. GISA can be used for exitless interrupts. The patch provides a set of functions for GISA related operations like

Re: [Qemu-devel] [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Alexander Graf
On 05.09.14 09:46, Frank Blaschka wrote: On Thu, Sep 04, 2014 at 07:16:24AM -0600, Alex Williamson wrote: On Thu, 2014-09-04 at 12:52 +0200, frank.blasc...@de.ibm.com wrote: This set of patches implements pci pass-through support for qemu/KVM on s390. PCI support on s390 is very different

Re: [Qemu-devel] [RFC][patch 4/6] KVM: s390: Add PCI pass-through support

2014-09-05 Thread Alexander Graf
On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch implemets PCI pass-through kernel support for s390. Design approach is very similar to the x86 device assignment. User space executes the KVM_ASSIGN_PCI_DEVICE ioctl to create a

[Qemu-devel] [PATCH v7 00/28] modify boot order of guest, and take effect after rebooting

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Sometimes, we want to modify boot order of a guest, but no need to shutdown it. We can call dynamic changing bootindex of a guest, which can be assured taking effect just after the guest rebooting. For example, in P2V scene, we boot a guest and then attach a

[Qemu-devel] [PATCH v7 14/28] spapr_lian: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 11/28] ne2000: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 16/28] usb-net: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 19/28] pci-assign: remove bootindex property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/i386/kvm/pci-assign.c | 13 - 1 file

[Qemu-devel] [PATCH v7 13/28] rtl8139: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 07/28] bootindex: add a setter/getter functions wrapper for bootindex property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com when we remove bootindex form qdev.property to qom.property, we can use those functions set/get bootindex property for all correlative devices. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c| 70

[Qemu-devel] [PATCH v7 03/28] bootindex: add del_boot_device_path function

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Introduce del_boot_device_path() to clean up fw_cfg content when hot-unplugging a device that refers to a bootindex. Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Chenliang chenlian...@huawei.com --- bootdevice.c| 21

[Qemu-devel] [PATCH v7 21/28] redirect: remove bootindex property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/redirect.c | 13 - 1 file

[Qemu-devel] [PATCH v7 23/28] scsi: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 17/28] net: remove bootindex property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Meanwhile set the initial value of bootindex to -1. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 15/28] vmxnet3: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 26/28] block: remove bootindex property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Meanwhile set the initial value of bootindex to -1. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/host-libusb.c | 13 - 1 file

[Qemu-devel] [PATCH v7 20/28] vfio: remove bootindex property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/misc/vfio.c | 13 - 1 file changed,

[Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 22/28] isa-fdc: remove bootindexA/B property from qdev to qom

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindexA/B form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/block/fdc.c | 17 +++-- 1 file

[Qemu-devel] [PATCH v7 12/28] pcnet: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] target-ppc: Build error log

2014-09-05 Thread Alexander Graf
On 05.09.14 10:28, Aravinda Prasad wrote: On Friday 05 September 2014 01:34 PM, Alexander Graf wrote: On 04.09.14 13:13, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If

[Qemu-devel] [PATCH v7 09/28] e1000: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 05/28] bootindex: rework add_boot_device_path function

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add the function of updating bootindex about fw_boot_order list in add_boot_device_path(). We should delete the old one if a device has existed in global fw_boot_order list. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 30

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-09-05 Thread Alexander Graf
On 04.09.14 15:49, Aravinda Prasad wrote: On Thursday 04 September 2014 06:39 PM, Alexander Graf wrote: Am 04.09.2014 um 10:25 schrieb Aravinda Prasad aravi...@linux.vnet.ibm.com: On Friday 29 August 2014 03:46 AM, Alexander Graf wrote: On 28.08.14 19:42, Aravinda Prasad wrote:

[Qemu-devel] [PATCH v7 28/28] bootindex: delete bootindex when device is removed

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Device should be removed from global boot list when it is hot-unplugged. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index e95d085..1255c06 100644 ---

[Qemu-devel] [PATCH v7 25/28] virtio-blk: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

Re: [Qemu-devel] NBD TLS support in QEMU

2014-09-05 Thread Hani Benhabiles
On Wed, Sep 03, 2014 at 05:44:17PM +0100, Stefan Hajnoczi wrote: Hi, QEMU offers both NBD client and server functionality. The NBD protocol runs unencrypted, which is a problem when the client and server communicate over an untrusted network. The particular use case that prompted this mail

[Qemu-devel] [PATCH v7 02/28] bootindex: add check bootindex function

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Determine whether a given bootindex exists or not. If exists, we report an error. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c| 15 +++ include/sysemu/sysemu.h | 1 + 2 files changed, 16 insertions(+) diff --git

[Qemu-devel] [PATCH v7 04/28] fw_cfg: add fw_cfg_machine_reset function

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com We must assure that the changed bootindex can take effect when guest is rebooted. So we introduce fw_cfg_machine_reset(), which change the fw_cfg file's bootindex data using the new global fw_boot_order list. Signed-off-by: Chenliang chenlian...@huawei.com

[Qemu-devel] [PATCH v7 06/28] bootindex: support to set a existent device's bootindex to -1

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com When set a device's bootindex to -1, we remove it from global fw_boot_order list. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bootdevice.c b/bootdevice.c index 6f430ec..484d0c9 100644

[Qemu-devel] [PATCH v7 10/28] eepro100: add bootindex to qom property

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v7 01/28] bootdevice: move bootdevice related code to new file bootdevice.c

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- Makefile.target | 2 +- bootdevice.c| 142 include/sysemu/sysemu.h | 1 + vl.c| 118

Re: [Qemu-devel] [CVE-2014-3615 PATCH v2 3/3] spice: make sure we don't overflow ssd-buf

2014-09-05 Thread Gerd Hoffmann
Hi, I can't track this back far enough. I'd feel safer if you checked that the multiplication can't overflow even in uint64_t. Effectively it comes from the emulated graphics hardware (anything in hw/display/*). The gfx emulation must make sure that the framebuffer fits into the video

[Qemu-devel] [PATCH v7 27/28] bootindex: move calling add_boot_device_patch to bootindex setter function

2014-09-05 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com On this way, we can assure the new bootindex take effect during vm rebooting. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 2 ++ hw/block/fdc.c | 3 --- hw/block/virtio-blk.c| 2 -- hw/i386/kvm/pci-assign.c | 2

Re: [Qemu-devel] [PATCH] translate-all.c: fix debug memory maps printing

2014-09-05 Thread Mikhail Ilin
I've also found that this issue in walker API leads to creating a misformed core file. elf_core_dump() uses walk_memory_regions() to build memory mapping for a core file. As a result the core file has a very small size and doesn't contain page snapshots of mapped libraries. I've compiled a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-09-05 Thread Aravinda Prasad
On Friday 05 September 2014 02:16 PM, Alexander Graf wrote: On 04.09.14 15:49, Aravinda Prasad wrote: On Thursday 04 September 2014 06:39 PM, Alexander Graf wrote: Am 04.09.2014 um 10:25 schrieb Aravinda Prasad aravi...@linux.vnet.ibm.com: On Friday 29 August 2014 03:46 AM,

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread Claudio Fontana
Just to point out that for the client there is also a DEBUG_LOG to uppercase, just like already pointed out for the server. diff --git a/contrib/ivshmem-client/ivshmem-client.c b/contrib/ivshmem-client/ivshmem-client.c new file mode 100644 index 000..ad210c8 --- /dev/null +++

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-09-05 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 09/04/2014 12:13 PM, Stefan Hajnoczi wrote: This patch seems to break tests/bios-tables-test.c: ERROR:tests/bios-tables-test.c:744:test_acpi_one: assertion failed (signature == SIGNATURE): (0x == 0xdead) GTester: last random seed:

Re: [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with simple backend

2014-09-05 Thread Stefan Hajnoczi
On Wed, Sep 03, 2014 at 11:44:54AM +0800, Fam Zheng wrote: In any other cases the object file is effectively empty, which is disliked by ranlib and nm on Mac OS X. Reported-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Fam Zheng f...@redhat.com --- trace/Makefile.objs | 3 +--

Re: [Qemu-devel] [PATCH] qemu-char: fix terminal crash when using -monitor stdio -nographic

2014-09-05 Thread Markus Armbruster
Li Liu john.li...@huawei.com writes: Ping, any more comments? Thanks. I'd like to hear Gerd's opinion (cc'ed). On 2014/8/27 15:40, Li Liu wrote: On 2014/8/27 14:44, Markus Armbruster wrote: john.liuli john.li...@huawei.com writes: From: Li Liu john.li...@huawei.com Eeay to

Re: [Qemu-devel] [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom

2014-09-05 Thread Gerd Hoffmann
+static void usb_host_instance_init(Object *obj) +{ +USBDevice *udev = USB_DEVICE(obj); +USBHostDevice *s = USB_HOST_DEVICE(udev); + +device_add_bootindex_property(obj, s-bootindex, + bootindex, NULL, +

Re: [Qemu-devel] [CVE-2014-3615 PATCH v2 3/3] spice: make sure we don't overflow ssd-buf

2014-09-05 Thread Laszlo Ersek
On 09/05/14 10:58, Gerd Hoffmann wrote: Hi, I can't track this back far enough. I'd feel safer if you checked that the multiplication can't overflow even in uint64_t. Effectively it comes from the emulated graphics hardware (anything in hw/display/*). The gfx emulation must make sure

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] PPC: kvm: Fix incorrect remapping of in-kernel MPIC

2014-09-05 Thread Alexander Graf
On 03.09.14 20:36, Bogdan Purcareata wrote: On target-ppc, the kvm-openpic memory region is part of the E500-CCSR memory region. On the kernel side, the MPIC is mapped at the same offset as the kvm-openpic within the address space. When adding the PCI BAR0 memory region, an alias is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] PPC: kvm: Fix incorrect remapping of in-kernel MPIC

2014-09-05 Thread Alexander Graf
On 03.09.14 20:36, Bogdan Purcareata wrote: On target-ppc, the kvm-openpic memory region is part of the E500-CCSR memory region. On the kernel side, the MPIC is mapped at the same offset as the kvm-openpic within the address space. When adding the PCI BAR0 memory region, an alias is

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Gonglei (Arei)
Hi, CC'ing Stefan and qemu-stable@ for more attention. :) Best regards, -Gonglei -Original Message- From: Gonglei (Arei) Sent: Thursday, September 04, 2014 7:42 PM To: qemu-devel@nongnu.org Cc: m...@redhat.com; Huangweidong (C); Gonglei (Arei) Subject: [PATCH] virtio-pci: fix

Re: [Qemu-devel] [PATCH] translate-all.c: fix debug memory maps printing

2014-09-05 Thread Peter Maydell
On 5 September 2014 09:59, Mikhail Ilin m.i...@samsung.com wrote: I also wonder we have separate linux-user emulators for i386 (32 bit ABI + 32 bit address space) and amd64 binaries (64 bit ABI + 64 bit address space). And we can not run 32 bits apps under qemu-x86_64 but MIPS N32 looks in

Re: [Qemu-devel] [PATCH v13 2/6] block: don't convert file size to sector size

2014-09-05 Thread Hu Tao
On Thu, Sep 04, 2014 at 11:57:58AM +0200, Kevin Wolf wrote: Am 29.08.2014 um 10:33 hat Hu Tao geschrieben: and avoid converting it back later. Signed-off-by: Hu Tao hu...@cn.fujitsu.com diff --git a/block/raw-posix.c b/block/raw-posix.c index 9c22e3f..abe0759 100644 ---

Re: [Qemu-devel] [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom

2014-09-05 Thread Gonglei (Arei)
Hi, From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Friday, September 05, 2014 5:06 PM Subject: Re: [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom +static void usb_host_instance_init(Object *obj) +{ +USBDevice *udev = USB_DEVICE(obj); +

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-05 Thread Kevin Wolf
Am 04.09.2014 um 17:43 hat Stefan Hajnoczi geschrieben: On Thu, Sep 04, 2014 at 04:10:14PM +0200, Kevin Wolf wrote: Am 04.09.2014 um 15:51 hat Stefan Hajnoczi geschrieben: On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote:

Re: [Qemu-devel] [PATCH] qemu-char: fix terminal crash when using -monitor stdio -nographic

2014-09-05 Thread Gerd Hoffmann
On Fr, 2014-09-05 at 11:04 +0200, Markus Armbruster wrote: Li Liu john.li...@huawei.com writes: Ping, any more comments? Thanks. I'd like to hear Gerd's opinion (cc'ed). But is having multiple character devices use the same terminal valid? No (guess we should catch that case in stdio

Re: [Qemu-devel] [CVE-2014-3615 PATCH v2 3/3] spice: make sure we don't overflow ssd-buf

2014-09-05 Thread Gerd Hoffmann
On Fr, 2014-09-05 at 11:06 +0200, Laszlo Ersek wrote: Makes sense. I think it is easier to just multiply in 64bit, then check the result is small enougth (new patch attached). Okay, if you can guarantee that the product fits in uint64_t, then such a check would suffice. New patch has

Re: [Qemu-devel] [PATCH v4 0/2] add resize callback to ide/core

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 11:42:15PM -0400, John Snow wrote: This patch series fixes incorrect IDENTIFY data returned for an IDE drive after a block_resize event by adding a resize callback for IDE devices. Inconsistencies between identify routines are also removed so that they read easier.

Re: [Qemu-devel] [PATCH 0/2] vmdk: fix leaks in vmdk_parse_extents()

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 09:04:41PM +0100, Stefan Hajnoczi wrote: See patches for the specific leaks. Stefan Hajnoczi (2): vmdk: fix vmdk_parse_extents() extent_file leaks vmdk: fix buf leak in vmdk_parse_extents() block/vmdk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 1/4] block: Correct bs-growable

2014-09-05 Thread Kevin Wolf
Am 04.09.2014 um 22:01 hat Max Reitz geschrieben: On 20.08.2014 13:40, Kevin Wolf wrote: Am 12.07.2014 um 00:23 hat Max Reitz geschrieben: Currently, the field growable in a BDS is set iff the BDS is opened in protocol mode (with O_BDRV_PROTOCOL). However, not every protocol block driver

Re: [Qemu-devel] I/O parallelism on QCOW2

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 12:32:12PM -0400, Xingbo Wu wrote: After running a 16-thread sync-random-write test against qcow2, It is observed that QCOW2 seems to be serializing all its metadata-related writes. If qcow2 is designed to do this,* then what is the concern?* What would go wrong if

Re: [Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 10:43:58PM +0800, Gordon Gong wrote: From fd3f0fd9c53d7782d4d835597c8a07b897bec3d0 Mon Sep 17 00:00:00 2001 From: Xiaodong Gong gordongong0...@gmail.com Date: Sat, 30 Aug 2014 03:17:03 +0800 Subject: Fix improper usage of cpu_to_be32 in vpc cpu_to_be32() is

Re: [Qemu-devel] [RFC PATCH v2] Support vhd type VHD_DIFFERENCING

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 10:49:43PM +0800, Gordon Gong wrote: [Qemu-devel][RFC PATCH v2] Support vhd type VHD_DIFFERENCING From 5387a2a7b6ad052659a08a1fc7e89595708396d1 Mon Sep 17 00:00:00 2001 From: Xiaodong Gong gordongong0...@gmail.com Date: Thu, 4 Sep 2014 01:14:59 +0800

Re: [Qemu-devel] [PATCH] gtk.c: Fix memory leak in gd_set_keycode_type()

2014-09-05 Thread Gerd Hoffmann
On Di, 2014-09-02 at 14:33 +0800, Chen Fan wrote: this memory leak is introduced by the original commit 3158a3482b0093e41f2b2596fba50774ea31ae08 added to gtk queue. thanks, Gerd

Re: [Qemu-devel] [PULL for-2.1 0/7] QOM devices patch queue 2014-09-04

2014-09-05 Thread Peter Maydell
On 4 September 2014 18:21, Andreas Färber afaer...@suse.de wrote: Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell peter.mayd...@linaro.org Cc: Michael S. Tsirkin m...@redhat.com The following changes since commit

Re: [Qemu-devel] [CVE-2014-3615 PATCH v2 3/3] spice: make sure we don't overflow ssd-buf

2014-09-05 Thread Laszlo Ersek
On 09/05/14 11:33, Gerd Hoffmann wrote: On Fr, 2014-09-05 at 11:06 +0200, Laszlo Ersek wrote: Makes sense. I think it is easier to just multiply in 64bit, then check the result is small enougth (new patch attached). Okay, if you can guarantee that the product fits in uint64_t, then

Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-05 Thread Kevin Wolf
Am 01.09.2014 um 12:52 hat Jun Li geschrieben: When every item of refcount block is NULL, free refcount block and reset the corresponding item of refcount table with NULL. Signed-off-by: Jun Li address@hidden The commit message should also describe why this is a relevant improvement for some

Re: [Qemu-devel] [PATCH v5 3/3] ivshmem: add check on protocol version in QEMU

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:51:01PM +0200, David Marchand wrote: diff --git a/contrib/ivshmem-client/ivshmem-client.c b/contrib/ivshmem-client/ivshmem-client.c index ad210c8..0c4e016 100644 --- a/contrib/ivshmem-client/ivshmem-client.c +++ b/contrib/ivshmem-client/ivshmem-client.c @@ -184,10

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Michael S. Tsirkin
On Thu, Sep 04, 2014 at 07:41:32PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of

Re: [Qemu-devel] [PATCH v5 2/3] docs: update ivshmem device spec

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:51:00PM +0200, David Marchand wrote: Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-05 Thread Peter Maydell
On 4 September 2014 23:17, Alexander Graf ag...@suse.de wrote: Peter, please pull the same tag name again - I updated it with the now working state. Doesn't build on Windows: hw/ppc/spapr.o: In function `spapr_populate_memory': /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:708:

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:50:59PM +0200, David Marchand wrote: When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz

Re: [Qemu-devel] [RFC][patch 3/6] KVM: s390: Add GISA support

2014-09-05 Thread Frank Blaschka
On Fri, Sep 05, 2014 at 10:29:26AM +0200, Alexander Graf wrote: On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: From: Frank Blaschka frank.blasc...@de.ibm.com This patch adds GISA (Guest Interrupt State Area) support to s390 kvm. GISA can be used for exitless interrupts. The

Re: [Qemu-devel] [PATCH v4 04/20] block: Convert bdrv_em_aiocb_info.cancel to .cancel_async

2014-09-05 Thread Fam Zheng
On Thu, 09/04 17:21, Benoît Canet wrote: The Wednesday 03 Sep 2014 à 19:23:39 (+0800), Fam Zheng wrote : All the difference is that the old .cancel doesn't call cb, but .cancel_async does. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 5 - 1 file changed, 4

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-05 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Thu, Sep 04, 2014 at 04:10:14PM +0200, Kevin Wolf wrote: Am 04.09.2014 um 15:51 hat Stefan Hajnoczi geschrieben: On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: On-disk structures

Re: [Qemu-devel] [PATCH v4 04/20] block: Convert bdrv_em_aiocb_info.cancel to .cancel_async

2014-09-05 Thread Benoît Canet
The Friday 05 Sep 2014 à 18:55:51 (+0800), Fam Zheng wrote : On Thu, 09/04 17:21, Benoît Canet wrote: The Wednesday 03 Sep 2014 à 19:23:39 (+0800), Fam Zheng wrote : All the difference is that the old .cancel doesn't call cb, but .cancel_async does. Signed-off-by: Fam Zheng

  1   2   3   >