[Qemu-devel] [PATCH 2/2] rdma: Fix incorrect description in comments

2014-09-12 Thread zhanghailiang
Since we have supported memory hotplug, VM's ram include pc.ram and hotplug-memory. Fix the confused description for rdma migration: pc.ram - VM's ram Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- docs/rdma.txt| 6 +++--- migration-rdma.c | 4 ++-- 2 files changed, 5

[Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-12 Thread zhanghailiang
It should be valid for the follow configure: -m 256,slots=0 -m 256,maxmem=256M -m 256,slots=0,maxmem=256M -m 256,slots=x,maxmem=y where x 0 and y 256M Fix the confused code logic and use error_report instead of fprintf. Printing the maxmem in hex, same with ram_size. Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Hongyang Yang
在 08/01/2014 11:03 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: implement colo checkpoint protocol. Checkpoint synchronzing points. Primary Secondary NEW @ Suspend

Re: [Qemu-devel] [RFC PATCH 16/17] COLO ram cache: implement colo ram cache on slaver

2014-09-12 Thread Hongyang Yang
在 08/01/2014 11:10 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: The ram cache was initially the same as PVM's memory. At checkpoint, we cache the dirty memory of PVM into ram cache (so that ram cache always the same as PVM's memory at every checkpoint), flush

Re: [Qemu-devel] ui causes latest master build failure on rhel6

2014-09-12 Thread Gerd Hoffmann
pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA. We don't check for a minimum version. RHEL-6 is probably older. Uhm, well, it isn't (any more): [root@rhel6 ~]# rpm -q pixman pixman-0.26.2-5.1.el6_5.x86_64 Seems to be rebased somewhen (used to be 0.16 for RHEL-6.0 IIRC).

Re: [Qemu-devel] [RFC PATCH 04/17] COLO info: use colo info to tell migration target colo is enabled

2014-09-12 Thread Hongyang Yang
在 08/01/2014 10:43 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: migrate colo info to migration target to tell the target colo is enabled. If I understand this correctly this means that you send a 'colo info' device information for migrations that don't have

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-12 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 09/11/2014 01:34 PM, Benoît Canet wrote: The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: EOF --- If you have feedback or questions, let us know. The process can be tweaked as time goes on so we can continue to improve. Great mail. Yup. Let's see how it works out. Now we need a wiki entry describing the process. Also we need

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread Gonglei (Arei)
Subject: Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive \ file=/home/win7_32_2U,if=none,id=drive-ide0-0-0 -device

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-12 Thread Gerd Hoffmann
Hi, With OVMF, I have EHCI with the high-speed (and working) keyboard+mouse, but ONLY ONE UHCI device (UHCI3). UHCI1 UHCI2 do not get detected. Now *that* is really strange, especially as UHCI1 is pci function 0, without probing that successfully you wouldn't see the other pci functions

Re: [Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-12 Thread Li Liu
On 2014/9/12 13:58, zhanghailiang wrote: It should be valid for the follow configure: -m 256,slots=0 -m 256,maxmem=256M -m 256,slots=0,maxmem=256M -m 256,slots=x,maxmem=y where x 0 and y 256M Fix the confused code logic and use error_report instead of fprintf. Printing the maxmem

Re: [Qemu-devel] [PATCH 0/2] Monitor-related fixes

2014-09-12 Thread Markus Armbruster
You neglected to cc maintainers. Stratos Psomadakis pso...@grnet.gr writes: Hi, the first patch fixes an issue with HMP monitors, which was exposed with v2.1.0 (commits cdaa86a and 812c10). Copying Luiz. The second one fixes a typo in a helper C program used in qemu-iotests. Copying

Re: [Qemu-devel] [PATCH 1/2] monitor: Reset HMP mon-rs on CHR_EVENT_CLOSED

2014-09-12 Thread Markus Armbruster
Stratos Psomadakis pso...@grnet.gr writes: Commit cdaa86a54 (Add G_IO_HUP handler for socket chardev) exposed a bug in the way the HMP monitor handles its input. When a client closes the connection to the monitor, tcp_chr_read() will catch the HUP 'signal' and call tcp_chr_disconnect() to

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
Hi, Subject: Re: [Qemu-devel] New requirement for getting block layer patches merged Benoît Canet benoit.ca...@irqsave.net writes: EOF --- If you have feedback or questions, let us know. The process can be tweaked as time goes on so we can continue to improve. Great mail.

Re: [Qemu-devel] [PATCH 2/2] iotests: Send the correct fd in socket_scm_helper

2014-09-12 Thread Markus Armbruster
Stratos Psomadakis pso...@grnet.gr writes: Make sure to pass the correct fd via SCM_RIGHTS in socket_scm_helper.c (i.e. fd_to_send, not socket-fd). Signed-off-by: Stratos Psomadakis pso...@grnet.gr Signed-off-by: Dimitris Aragiorgis dim...@grnet.gr ---

[Qemu-devel] [PATCH] virtio-balloon: Add some trace events

2014-09-12 Thread zhanghailiang
Add some trace events for easier debugging Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/virtio/virtio-balloon.c | 6 ++ trace-events | 4 2 files changed, 10 insertions(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index

Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-12 Thread Markus Armbruster
arei.gong...@huawei.com writes: From: Gonglei arei.gong...@huawei.com qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Gonglei (2): redirect.c: Don't use qerror_report() dev-network: Don't use

Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Friday, September 12, 2014 3:11 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; Huangweidong (C); kra...@redhat.com Subject: Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report arei.gong...@huawei.com writes: From: Gonglei

[Qemu-devel] [PATCH v2 1/2] redirect.c: Don't use qerror_report()

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Replace by error_report(). Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com ---

[Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. v2 - v1: - update including head files, remove qerror.h and monitor.h, add error-report.h (Markus) - add 'Reviewed-by'

[Qemu-devel] [PATCH v2 2/2] dev-network: Don't use qerror_report_err()

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com qerror_report_err() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com --- hw/usb/dev-network.c

[Qemu-devel] [RFC PATCH v3] Add HMP command info memory-devices

2014-09-12 Thread Zhu Guihua
Provides HMP equivalent of QMP query-memory-devices command. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- Changes since v2: - print address in hex. - change the loop control from while to for. - modify some variables' name. - optimize the time to print memory devices' kind. Changes

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-12 Thread Bharata B Rao
On Fri, Sep 12, 2014 at 6:54 AM, Gu Zheng guz.f...@cn.fujitsu.com wrote: Is guest os enabled acpi cpu hotplug? What's the guest's cpu info? Please try latest QEMU, and any feedback is welcome. Tried with latest QEMU git + your patchset and Fedora 20 guest, but QEMU monitor still shows the

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Kevin Wolf
Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: Hi, Subject: Re: [Qemu-devel] New requirement for getting block layer patches merged Benoît Canet benoit.ca...@irqsave.net writes: EOF --- If you have feedback or questions, let us know. The process can be tweaked

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 11:40:16AM +0200, Marc Marí wrote: Increase the clock step to avoid Travis failure in some builds due to overagressive timeout. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio.c |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-12 Thread Peter Maydell
On 12 September 2014 09:27, Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, Sep 11, 2014 at 11:40:16AM +0200, Marc Marí wrote: Increase the clock step to avoid Travis failure in some builds due to overagressive timeout. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com ---

Re: [Qemu-devel] [PATCH 2/2] iotests: Send the correct fd in socket_scm_helper

2014-09-12 Thread Kevin Wolf
Am 12.09.2014 um 09:04 hat Markus Armbruster geschrieben: Stratos Psomadakis pso...@grnet.gr writes: Make sure to pass the correct fd via SCM_RIGHTS in socket_scm_helper.c (i.e. fd_to_send, not socket-fd). Signed-off-by: Stratos Psomadakis pso...@grnet.gr Signed-off-by: Dimitris

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
From: Kevin Wolf [mailto:kw...@redhat.com] Sent: Friday, September 12, 2014 4:14 PM Subject: Re: [Qemu-devel] New requirement for getting block layer patches merged Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: Hi, Subject: Re: [Qemu-devel] New requirement for getting block

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 09:30, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. v2 - v1: - update including head files, remove qerror.h and

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Kevin Wolf
Am 12.09.2014 um 10:32 hat Gonglei (Arei) geschrieben: From: Kevin Wolf [mailto:kw...@redhat.com] Sent: Friday, September 12, 2014 4:14 PM Subject: Re: [Qemu-devel] New requirement for getting block layer patches merged Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: Hi,

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, September 12, 2014 4:35 PM To: Gonglei (Arei); qemu-devel@nongnu.org Cc: Huangweidong (C); kra...@redhat.com; arm...@redhat.com Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report Il

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
From: Kevin Wolf [mailto:kw...@redhat.com] Sent: Friday, September 12, 2014 4:46 PM To: Gonglei (Arei) Cc: Markus Armbruster; Benoît Canet; qemu-devel@nongnu.org; Stefan Hajnoczi Subject: Re: [Qemu-devel] New requirement for getting block layer patches merged Am 12.09.2014 um 10:32 hat

[Qemu-devel] [PATCH] ohci: Convert fprint/DPRINTF/print to traces

2014-09-12 Thread Alexey Kardashevskiy
This converts many kinds of debug prints to traces. This implements packets logging to avoid unnecessary calculations if usb_ohci_td_pkt_short/usb_ohci_td_pkt_long is not enabled. This makes OHCI errors (such as DMA error) invisible by default. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru

[Qemu-devel] qemu-img: unable to convert raw image 2GB with git master

2014-09-12 Thread Mark Cave-Ayland
Hi all, I've been trying to convert a raw disk partition from my laptop for use on VMWare player and I'm seeing the following error from qemu-img git master during conversion: # qemu-img convert -f raw -O vmdk /dev/mapper/vm-raw out.vmdk qemu-img: error while writing sector 4247552: Invalid

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: Any chance you could convert USB from init to realize, instead? Then you can remove the error printing altogether, and just the obsolete functions. As far as I can tell, almost all devices belong to USB sub-system are using init method.

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Markus Armbruster
Gonglei (Arei) arei.gong...@huawei.com writes: From: Kevin Wolf [mailto:kw...@redhat.com] [...] I'll probably keep reviewing paches without an R-b when they are simple or in my area of expertise (like qcow2), like any other reviewer should. The point is just that when I don't, before you ping

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Friday, September 12, 2014 5:02 PM To: Gonglei (Arei) Cc: Kevin Wolf; Benoît Canet; Stefan Hajnoczi; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] New requirement for getting block layer patches merged Gonglei (Arei)

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, September 12, 2014 4:59 PM Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: Any chance you could convert USB from init to realize,

Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: diff --git a/docs/specs/virtio-gpu.txt b/docs/specs/virtio-gpu.txt new file mode 100644 index 000..9455383 --- /dev/null +++ b/docs/specs/virtio-gpu.txt @@ -0,0 +1,165 @@ +virtio-gpu specification +

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 10:14:01AM +0200, Kevin Wolf wrote: Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: Now we need a wiki entry describing the process. Also we need something reminding who is the maintainer of the current week. Usually obvious from the applied to my

[Qemu-devel] [PATCH V2 0/7] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-09-12 Thread Gu Zheng
Previously we use cpu_added_notifiers to register cpu hotplug notifier callback which is not able to pass/handle errors, so we switch it to unified hotplug handler API which allows to pass errors and would allow to cancel device_add in case of error. Thanks very much for Igor's review and

[Qemu-devel] [PATCH V2 1/7] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-12 Thread Gu Zheng
--- v2: -add errp argument to catch error. -return error instead of aborting if cpu id is invalid. -make acpi_cpu_plug_cb as a wrapper around AcpiCpuHotplug_add. --- Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c | 17 +

[Qemu-devel] [PATCH V2 2/7] acpi:ich9: convert cpu hotplug handle to hotplug_handler API

2014-09-12 Thread Gu Zheng
Convert notifier based hotplug handle to hotplug_handler API. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/ich9.c | 14 +++--- include/hw/acpi/ich9.h |1 - 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index

[Qemu-devel] [PATCH V2 3/7] acpi:piix4: convert cpu hotplug handle to hotplug_handler API

2014-09-12 Thread Gu Zheng
Convert notifier based hotplug handle to hotplug_handler API, and remove the unused AcpiCpuHotplug_add(). Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c | 14 ++ hw/acpi/piix4.c | 14 ++ include/hw/acpi/cpu_hotplug.h |

[Qemu-devel] [PATCH V2 4/7] pc: add cpu hotplug handler to PC_MACHINE

2014-09-12 Thread Gu Zheng
Add cpu hotplug handler to PC_MACHINE, which will perform the acpi cpu hotplug callback via hotplug_handler API. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/i386/pc.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/hw/i386/pc.c

[Qemu-devel] [PATCH V2 5/7] pc: Update rtc_cmos in pc_cpu_plug

2014-09-12 Thread Gu Zheng
Update rtc_cmos in pc_cpu_plug directly instead of the notifier, with this change, there will no user of CPU hot-plug notifier any more, so remove it. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/i386/pc.c| 25 ++--- include/sysemu/sysemu.h |3 ---

[Qemu-devel] [PATCH V2 6/7] cpu-hotplug: rename function for better readability

2014-09-12 Thread Gu Zheng
Rename: AcpiCpuHotplug_init -- acpi_cpu_hotplug_init AcpiCpuHotplug_ops -- acpi_cpu_hotplug_ops for better readability, just cleanup. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c |4 ++-- hw/acpi/ich9.c|4 ++-- hw/acpi/piix4.c

[Qemu-devel] [PATCH V2 7/7] acpi/cpu-hotplug: introduce help function to keep bit setting in one place

2014-09-12 Thread Gu Zheng
Introduce help function acpi_set_local_sts() to simplify acpi_cpu_plug_cb and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c | 22 +++--- 1 files changed, 15 insertions(+), 7

Re: [Qemu-devel] [PATCH v15 0/5] qcow2, raw: add preallocation=full and preallocation=falloc

2014-09-12 Thread Hu Tao
ping? On Wed, Sep 10, 2014 at 05:05:44PM +0800, Hu Tao wrote: This series adds two preallocation mode to qcow2 and raw: Option preallocation=full preallocates disk space for image by writing zeros to disk, this ensures disk space in any cases. Option preallocation=falloc preallocates disk

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-12 Thread BALATON Zoltan
On Thu, 11 Sep 2014, Gabriel L. Somlo wrote: On Thu, Sep 11, 2014 at 11:34:03PM +0200, Alexander Graf wrote: XNU also populates its device tree based on the DSDT. Maybe there's a subtle difference there? This was the low hanging fruit, so I checked it first :) Pulled the DSDT using the OS X

Re: [Qemu-devel] qemu-img: unable to convert raw image 2GB with git master

2014-09-12 Thread Fam Zheng
On Fri, 09/12 09:57, Mark Cave-Ayland wrote: Hi all, I've been trying to convert a raw disk partition from my laptop for use on VMWare player and I'm seeing the following error from qemu-img git master during conversion: # qemu-img convert -f raw -O vmdk /dev/mapper/vm-raw out.vmdk

[Qemu-devel] [PATCH v10 04/30] fw_cfg: add fw_cfg_machine_reset function

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com We must assure that the changed bootindex can take effect when guest is rebooted. So we introduce fw_cfg_machine_reset(), which change the fw_cfg file's bootindex data using the new global fw_boot_order list. Signed-off-by: Chenliang chenlian...@huawei.com

[Qemu-devel] [PATCH v10 09/30] e1000: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Sometimes, we want to modify boot order of a guest, but no need to shutdown it. We can call dynamic changing bootindex of a guest, which can be assured taking effect just after the guest rebooting. For example, in P2V scene, we boot a guest and then attach a

[Qemu-devel] [PATCH v10 13/30] rtl8139: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 05/30] bootindex: rework add_boot_device_path function

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add the function of updating bootindex about fw_boot_order list in add_boot_device_path(). We should delete the old one if a device has existed in global fw_boot_order list. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 2 ++ 1 file

[Qemu-devel] [PATCH v10 02/30] bootindex: add check bootindex function

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Determine whether a given bootindex exists or not. If exists, we report an error. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c| 15 +++ include/sysemu/sysemu.h | 1 + 2 files changed, 16 insertions(+) diff --git

[Qemu-devel] [PATCH v10 01/30] bootdevice: move bootdevice related code to new file bootdevice.c

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- Makefile.target | 2 +- bootdevice.c| 142 include/sysemu/sysemu.h | 1 + vl.c| 118

[Qemu-devel] [PATCH v10 15/30] vmxnet3: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 08/30] virtio-net: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 11/30] ne2000: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 26/30] virtio-blk: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 14/30] spapr_lian: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 19/30] host-libusb: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/host-libusb.c | 12 +++- 1 file

[Qemu-devel] [PATCH v10 16/30] usb-net: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 24/30] scsi: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PATCH v10 18/30] virtio-net: alias bootindex property explicitly for virt-net-pci/ccw/s390

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Since the bootindex property is a QOM property and not a qdev property now, we must alias it explicitly for virtio-net-pci, as well as CCW and s390-virtio. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/s390x/s390-virtio-bus.c | 2 ++

[Qemu-devel] [PATCH v10 17/30] net: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- include/net/net.h | 3 +-- 1 file changed, 1

[Qemu-devel] [PATCH v10 27/30] block: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/scsi/scsi-disk.c | 1 -

[Qemu-devel] [PATCH v10 20/30] pci-assign: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/i386/kvm/pci-assign.c | 12 +++- 1 file

[Qemu-devel] [PATCH v10 23/30] isa-fdc: remove bootindexA/B property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindexA/B form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/block/fdc.c | 15 +-- 1 file

[Qemu-devel] [PATCH v10 22/30] redirect: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/redirect.c | 12 +++- 1 file changed,

[Qemu-devel] [PATCH v10 30/30] bootindex: delete bootindex when device is removed

2014-09-12 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Device should be removed from global boot list when it is hot-unplugged. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index db72098..f816259 100644 ---

[Qemu-devel] checkpatch.pl false positive

2014-09-12 Thread Gerd Hoffmann
Hi, Hooked up checkpatch to my testbuild-patch-series script. Catched some issues, now trapped into what I think is a false positive: ERROR: Macros with complex values should be enclosed in parenthesis #995: FILE: include/hw/virtio/virtio-gpu.h:99: +#define

Re: [Qemu-devel] checkpatch.pl false positive

2014-09-12 Thread Peter Maydell
On 12 September 2014 11:35, Gerd Hoffmann kra...@redhat.com wrote: Hi, Hooked up checkpatch to my testbuild-patch-series script. Catched some issues, now trapped into what I think is a false positive: ERROR: Macros with complex values should be enclosed in parenthesis #995: FILE:

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-12 Thread Gerd Hoffmann
Hi, @@ -0,0 +1,158 @@ +#ifndef VIRTGPU_HW_H +#define VIRTGPU_HW_H Non-trivial file, deserves a copyright and license notice. Added. + +enum virtgpu_ctrl_type { +VIRTGPU_UNDEFINED = 0, + +/* 2d commands */ +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-12 Thread Anshul Makkar
During plugging we can see this event: echo 1 cpu8/online. But during unplugging , we can't see the event echo 0 cpu8/online. Just for additional check, in my code I have added following udev rule echo 0 cpu[0-9]*/online. May be this is of any help. Thanks Anshul Makkar On Fri, Sep 12,

[Qemu-devel] [PATCH v2] Add skip_dump flag to ignore memory region during dump

2014-09-12 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com --- V1: * Make the flag generic in place of using vfio_mmap (Alex) hw/misc/vfio.c| 1 + include/exec/memory.h

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Gerd Hoffmann
Hi, +++ b/docs/specs/virtio-gpu.txt @@ -0,0 +1,165 @@ +virtio-gpu specification I know you are just following existing bad practice in this directory, but it would be nice to declare copyright and license on this file. Added copyright for now. Dunno about license, IIRC GPLv2 isn't

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 06:44:08PM +0100, Dr. David Alan Gilbert wrote: (I've cc'd in Fam, Stefan, and Kevin for Block stuff, and Yang and Eddie for Colo) * Walid Nouri (walid.no...@gmail.com) wrote: Hello Michael, Hello Paolo i have ???studied??? the available

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Dr. David Alan Gilbert
* Hongyang Yang (yan...@cn.fujitsu.com) wrote: ??? 08/01/2014 11:03 PM, Dr. David Alan Gilbert ??: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: snip +static int do_colo_transaction(MigrationState *s, QEMUFile *control, + QEMUFile *trans) +{ +int

[Qemu-devel] [PATCHv2 1/4] BlockLimits: introduce max_transfer_length

2014-09-12 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block.c |4 include/block/block_int.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/block.c b/block.c index d06dd51..c87e9fd 100644 --- a/block.c +++

[Qemu-devel] [PATCHv2 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-12 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 965e9bc..2b9be99 100644 --- a/block.c +++ b/block.c @@ -4554,6 +4554,11 @@ static int

[Qemu-devel] [PATCHv2 3/4] block/iscsi: set max_transfer_length

2014-09-12 Thread Peter Lieven
the limit of 0xff for 16 byte CDBs is intentional to avoid overflows on 32-bit architectures. Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCHv2 0/4] introduce max_transfer_length

2014-09-12 Thread Peter Lieven
This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix. Discussed reporting of this maximum in the SCSI Disk Inquiry

[Qemu-devel] [PATCHv2 2/4] block: immediately cancel oversized read/write requests

2014-09-12 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block.c | 14 ++ trace-events |2 ++ 2 files changed, 16 insertions(+) diff --git a/block.c b/block.c index c87e9fd..965e9bc 100644 --- a/block.c +++ b/block.c @@ -3215,6 +3215,13 @@ static int coroutine_fn

Re: [Qemu-devel] [PATCH v3 03/47] Start documenting how postcopy works.

2014-09-12 Thread Dr. David Alan Gilbert
* Hongyang Yang (yan...@cn.fujitsu.com) wrote: ??? 08/28/2014 11:03 PM, Dr. David Alan Gilbert (git) ??: From: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- +Postcopy can be combined with precopy (i.e. normal migration) so

Re: [Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread Gonglei (Arei)
Subject: Re: [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting On Fr, 2014-09-12 at 17:35 +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Sometimes, we want to modify boot order of a guest, but no need to shutdown it. We can call

Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Gerd Hoffmann
On Fr, 2014-09-12 at 10:10 +0100, Stefan Hajnoczi wrote: On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: diff --git a/docs/specs/virtio-gpu.txt b/docs/specs/virtio-gpu.txt new file mode 100644 index 000..9455383 --- /dev/null +++ b/docs/specs/virtio-gpu.txt @@ -0,0

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Hongyang Yang
在 09/12/2014 07:17 PM, Dr. David Alan Gilbert 写道: * Hongyang Yang (yan...@cn.fujitsu.com) wrote: ??? 08/01/2014 11:03 PM, Dr. David Alan Gilbert ??: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: snip +static int do_colo_transaction(MigrationState *s, QEMUFile *control, +

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-12 Thread Peter Lieven
Am 08.09.2014 um 18:29 schrieb Paolo Bonzini: Il 08/09/2014 18:18, Peter Lieven ha scritto: When copying data, gparted will try using very large I/O sizes. Of course if something breaks it will just use a smaller size, but it would make performance worse. I tried now (with local storage,

Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports

2014-09-12 Thread Gonglei (Arei)
Ping... Any comments will be appreciated! Best regards, -Gonglei -Original Message- From: Gonglei (Arei) Sent: Tuesday, September 09, 2014 2:35 PM To: qemu-devel@nongnu.org Cc: m...@redhat.com; pbonz...@redhat.com; stefa...@redhat.com; Huangweidong (C); ag...@suse.de; Huangpeng

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Dr. David Alan Gilbert
* Hongyang Yang (yan...@cn.fujitsu.com) wrote: ??? 09/12/2014 07:17 PM, Dr. David Alan Gilbert ??: * Hongyang Yang (yan...@cn.fujitsu.com) wrote: ??? 08/01/2014 11:03 PM, Dr. David Alan Gilbert ??: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: snip +static int

[Qemu-devel] [PATCH 0/2] target-arm: implement architectural breakpoints

2014-09-12 Thread Peter Maydell
Implement support for the ARM architecturally mandated hardware breakpoints, for ARMv8 and ARMv7. Tested that hardware bps work for both v7 and v8 kernels (including v8 compat userspace in a 32 bit kernel). There are a few odd subfeatures which we don't implement (yet): * address-mismatch

[Qemu-devel] [PATCH 2/2] target-arm: Implement handling of breakpoint firing

2014-09-12 Thread Peter Maydell
Implement handling of breakpoint event firing to correctly inject the debug exception into the guest. Since the breakpoint and watchpoint control register format is very similar we adjust wp_matches() to also handle breakpoints as well rather than using a separate function. Signed-off-by: Peter

[Qemu-devel] [PATCH 1/2] target-arm: Implement setting guest breakpoints

2014-09-12 Thread Peter Maydell
This patch adds support for setting guest breakpoints based on values the guest writes to the DBGBVR and DBGBCR registers. (It doesn't include the code to handle when these breakpoints fire, so has no guest-visible effect.) Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-12 Thread Erik Rull
Confirmed - the current kvm.git without any ipipe patch also causes the issue. Trace File attached. ** Attachment added: trace.tgz https://bugs.launchpad.net/qemu/+bug/1366836/+attachment/4202192/+files/trace.tgz -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [question] virtio-blk performance degradation happened with virito-serial

2014-09-12 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 11:21:37AM +0800, Zhang Haoyu wrote: If virtio-blk and virtio-serial share an IRQ, the guest operating system has to check each virtqueue for activity. Maybe there is some inefficiency doing that. AFAIK virtio-serial registers 64 virtqueues (on 31 ports +

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-12 Thread Eric Blake
On 09/12/2014 04:44 AM, Gerd Hoffmann wrote: +enum virtgpu_ctrl_type { +VIRTGPU_UNDEFINED = 0, + +/* 2d commands */ +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, Please consider also adding: #define VIRTGPU_CMD_GET_DISPLAY_INFO VIRTGPU_CMD_GET_DISPLAY_INFO and

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-12 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 09:39:16AM +0800, TeLeMan wrote: On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini pbonz...@redhat.com wrote: Uses the same select/WSAEventSelect scheme as main-loop.c. WSAEventSelect() is edge-triggered, so it cannot be used directly, but it is still used as a way to

  1   2   3   >