So it gets properly unregistered on hot-unplug.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/audio/ac97.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index 0e22bb9..111ec0e 100644
--- a/hw/audio/ac97.c
+++
Cc'ing Gerd for additional chardev expertise.
Zifei Tong zifeit...@gmail.com writes:
After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP
in tcp_chr_read for tcp chardev), the connection is disconnected when in
G_IO_HUP condition.
However, it's possible that the channel is
From: Marc-André Lureau marcandre.lur...@gmail.com
Don't call SPICE API directly to set password given in command line, but
use the internal API, saving password for later calls.
This solves losing password when changing expiration in qemu monitor.
repository at:
git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140916-2
for you to fetch changes up to 07d49a53b6394941ed833486a3acb5c480d87db2:
spice: call qemu_spice_set_passwd() during init (2014-09-16 08:09:03 +0200
With Qemu 2.0.0 it works
** Changed in: qemu
Status: New = Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1247122
Title:
kernel guest 3.10.6 boot failure at sha_transform
Status in
Hi,
I write the data to the rx-ring and write the fd to notify the guest but there
is no interrupts in the guest.
my notify code:
uint64_t kick_it = 1;
write(vring[0]-kickfd, kick_it, sizeof(kick_it));
cat /proc/interrupts in the guest:
41: 0 PCI-MSI-EDGEvirtio0-input
42: 0
Make a few keys works correctly in SDL2.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
ui/sdl2-keymap.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/sdl2-keymap.h b/ui/sdl2-keymap.h
index 5a12f45..cbedaa4 100644
--- a/ui/sdl2-keymap.h
+++ b/ui/sdl2-keymap.h
://git.kraxel.org/qemu tags/pull-sdl-20140916-1
for you to fetch changes up to 0d61f7dcc6c04e7e825417c74e50362d990330bf:
sdl2: keymap fixups (2014-09-16 08:07:05 +0200)
Two minor sdl2 fixes
It isn't used.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
ui/sdl2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index fcac87b..1ad74ba 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -35,7 +35,6 @@
#include ui/console.h
#include ui/input.h
#include
Add a flag to EHCIPCIInfo saying whenever the controller supports
companions or not. Make sure we only allow registering companions for
ehci versions supporting that. Enable pci hotplug for the ehci
variants not supporting companions.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
FIXME: turn off hotplug for companions
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-ohci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 83bec34..8113b5a 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -2116,7 +2116,6 @@
Hi,
This series the usb host adapters hot-pluggable. Problem is that we
can NOT hotplug host adapters which are part of a companion setup. The
way this is tackled now is to split the usb host adapter variants into
two groups:
* All ich9-* variants (both uhci and ehci) support companion
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 73ced1f..c556367 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3874,7 +3874,6 @@ static void xhci_class_init(ObjectClass
From: Gonglei arei.gong...@huawei.com
Because of we now support usb hcds hotplugging, and
collect all hcds hotplugging tests into one file
for code sharing.
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
tests/Makefile | 2 ++
uhci hostadapters in companion setups can't be hotplugged. So leave
hotplug disabled for all ich9 variants (which are already tagged with
unplug = true in the info struct). For the other variants we'll enable
hotplug and remove the companion setup properties.
Signed-off-by: Gerd Hoffmann
On Tue, Sep 16, 2014 at 2:06 PM, Markus Armbruster arm...@redhat.com wrote:
Cc'ing Gerd for additional chardev expertise.
Zifei Tong zifeit...@gmail.com writes:
After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP
in tcp_chr_read for tcp chardev), the connection is
On 2014/9/15 2:41, Michael S. Tsirkin wrote:
From: Damjan Marion damar...@cisco.com
Header length check should happen only if backend is kernel. For user
backend there is no reason to reset this bit.
vhost-user code does not define .has_vnet_hdr_len so
VIRTIO_NET_F_MRG_RXBUF cannot be
On Mon, 09/15 12:17, Paolo Bonzini wrote:
Il 15/09/2014 07:23, Fam Zheng ha scritto:
SCSIRequest *sreq;
size_t resp_size;
enum SCSIXferMode mode;
-QEMUIOVector resp_iov;
union {
VirtIOSCSICmdResp cmd;
VirtIOSCSICtrlTMFResp tmf;
@@
v3: Small tweak on cmd in 1/2 and sreq in 2/2.
Zeroing is relatively expensive since we have big request structures.
VirtQueueElement (48k!) and sense_buf (256 bytes) are two points to look at.
This visibly reduces overhead of request handling when testing with the
unmerged null driver and
The VirtQueueElement is a very big structure (48k!), since it will be
initialzed by virtqueue_pop, we can save the expensive zeroing here.
This saves a few microseconds per request in my test:
[fio-test] rw bs iodepthjobs bw iops
latency
Zeroing sense buffer for each scsi request is not efficient, we can just
leave it uninitialized because sense_len is set to 0.
Move the implicitly zeroed fields to the end of the structure and use a
partial memset.
The explicitly initialized fields (by scsi_req_alloc or scsi_req_new)
are moved
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Sep 15, 2014 at 05:57:51PM +0200, Paolo Bonzini wrote:
Il 15/09/2014 16:44, arei.gong...@huawei.com ha scritto:
From: Gonglei arei.gong...@huawei.com
At present, people have no way to know they should
have a specific format for alias
Hi,
In original code, Function dump_error ignores its second parameter which
contains
error reason, it is better to return the error message to the caller.
Here we use error_setg to return the error info to caller.
And at the same time, we turn functions like write_elf64_note() to void,
Because
The second parameter of dump_error is unused, but one purpose of
using this function is to report the error info.
Use error_set to return the error info to the caller.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
dump.c | 165
Functions shouldn't return an error code and an Error object at the same time.
Turn all these functions that returning Error object to void.
We also judge if a function success or fail by reference to the *errp.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
dump.c | 244
From: ChenLiang chenlian...@huawei.com
kvm_pit is running in kmod. kvm_pit is going to inject
interrupt to vm before cpu_synchronize_all_post_init at
dest side. vcpu will lose the pit interrupt, but
ack_irq(in kmod) has been 0. ack_irq become 1 after
vcpu responds pit interrupt. pit interruptcan
From: Markus Armbruster [mailto:arm...@redhat.com]
Sent: Tuesday, September 16, 2014 3:28 PM
Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on
qdev_device_help()
arei.gong...@huawei.com writes:
From: Gonglei arei.gong...@huawei.com
Normally,
Hi,
Subject: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable
Hi,
This series the usb host adapters hot-pluggable. Problem is that we
can NOT hotplug host adapters which are part of a companion setup. The
way this is tackled now is to split the usb host adapter variants
Il 15/09/2014 18:31, John Snow ha scritto:
On 09/13/2014 03:50 PM, Paolo Bonzini wrote:
Il 13/09/2014 15:26, Paolo Bonzini ha scritto:
+if (ad-dp_intr_req) {
+ahci_trigger_irq(ad-hba, ad, PORT_IRQ_SG_DONE);
+ad-dp_intr_req = 0;
+}
Is it also needed in the error
In error message, maxmem is printed in Dec but ram_size in Hex.
It is better to print them in same format.
Also use error_report instead of fprintf.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
v2:
- Remove redundant qemu: in error message, for error_report already prepend
a
Luiz Capitulino lcapitul...@redhat.com writes:
When a QMP client changes the polling interval time by setting
the guest-stats-polling-interval property, the interval value
is stored and manipuled as an int64_t variable.
However, the balloon_stats_change_timer() function, which is
used to
Il 15/09/2014 22:07, John Snow ha scritto:
-/* free sglist that was created in ahci_populate_sglist() */
-qemu_sglist_destroy(s-sg);
+/* free sglist, update byte count */
+ahci_commit_buf(dma, true);
Perhaps you should make dma_buf_commit public (and add the call to the
From: Markus Armbruster [mailto:arm...@redhat.com]
Sent: Tuesday, September 16, 2014 3:21 PM
To: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Sep 15, 2014 at 05:57:51PM +0200, Paolo
Gonglei (Arei) arei.gong...@huawei.com writes:
From: Markus Armbruster [mailto:arm...@redhat.com]
Sent: Tuesday, September 16, 2014 3:28 PM
Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on
qdev_device_help()
arei.gong...@huawei.com writes:
From: Gonglei
arei.gong...@huawei.com writes:
From: Gonglei arei.gong...@huawei.com
Normally, qmp_device_list_properties() may return NULL when
a device haven't special properties excpet Object and DeviceState
properties, such as virtio-balloon-device.
We just need check local_err instead of prop_list.
From: Markus Armbruster [mailto:arm...@redhat.com]
Sent: Tuesday, September 16, 2014 4:00 PM
To: Gonglei (Arei)
Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on
qdev_device_help()
Gonglei (Arei) arei.gong...@huawei.com writes:
From: Markus Armbruster
Juan Quintela quint...@redhat.com wrote:
Hi
Please, send any topic that you are interested in covering.
People have complained on the past that I don't cancel the call until
the very last minute. So, what do you think that deadline for
submitting topics is 23:00UTC on Monday?
ok, no
Il 15/09/2014 22:01, Richard Henderson ha scritto:
@@ -1006,6 +1006,7 @@ void helper_fstenv(CPUX86State *env, target_ulong
ptr, int data32)
cpu_stw_data(env, ptr + 10, 0);
cpu_stw_data(env, ptr + 12, 0);
}
+update_fp_status(env);
}
Why does this need to
Hi,
OK, so I forgot to articulate that with the above patch, I'm seeing
*both* uhci2 and uhci3, but not uhci1. Basically, if uhciX has an
irq_pin less than 2, it won't show up in OSX if booted with ovmf.
We're no longer looking at PIIX, this is q35 with ovmf or without.
Can you test what
Il 16/09/2014 09:16, Fam Zheng ha scritto:
On Mon, 09/15 12:17, Paolo Bonzini wrote:
Il 15/09/2014 07:23, Fam Zheng ha scritto:
SCSIRequest *sreq;
size_t resp_size;
enum SCSIXferMode mode;
-QEMUIOVector resp_iov;
union {
VirtIOSCSICmdResp cmd;
Il 16/09/2014 09:20, Fam Zheng ha scritto:
v3: Small tweak on cmd in 1/2 and sreq in 2/2.
Zeroing is relatively expensive since we have big request structures.
VirtQueueElement (48k!) and sense_buf (256 bytes) are two points to look at.
This visibly reduces overhead of request handling
Il 16/09/2014 09:21, Markus Armbruster ha scritto:
The rebase onto QOM renamed name to legacy_name, to free name for use as
QOM type name (commit cafe5bd).
Also, the QOM type name has strict rules:
- either it is a QAPI type (primitive, enum or struct)
- or it is linkqom-type-name
- or it is
Il 15/09/2014 19:49, Michael S. Tsirkin ha scritto:
On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
At present, people have no way to know they should
have a specific format for alias properties.
Example:
before output:
Hi Igor,
On 09/04/2014 09:22 PM, Igor Mammedov wrote:
On Wed, 27 Aug 2014 16:08:35 +0800
Tang Chen tangc...@cn.fujitsu.com wrote:
From: Hu Tao hu...@cn.fujitsu.com
Implement bus-less device hot-remove in qdev_unplug(). It will call PCMachine
callback introduced in previous patch.
Il 16/09/2014 09:26, arei.gong...@huawei.com ha scritto:
From: ChenLiang chenlian...@huawei.com
kvm_pit is running in kmod. kvm_pit is going to inject
interrupt to vm before cpu_synchronize_all_post_init at
dest side. vcpu will lose the pit interrupt, but
ack_irq(in kmod) has been 0.
If event_notifier_init fails QEMU exits without printing
any error information to the user. This commit adds an error
message on failure:
# qemu [...]
qemu: Failed to initialize event notifier: Too many open files in system
qemu: qemu_init_main_loop failed
Signed-off-by: Chrysostomos Nanakos
v1-v2
--
* aio_context_new() returns NULL if the initialization of event notifier fails.
* Add descriptive error messages if aio_context_new() and event_notifier_init()
fail.
* Fix gpollfds leak.
Chrysostomos Nanakos (1):
async: aio_context_new(): Handle event_notifier_init failure
Il 05/09/2014 15:52, Marcelo Tosatti ha scritto:
Regression fix tested with fio and ping-pong migration.
I applied the patches, but in a different order (2-3-1) to keep them
bisectable.
Can you send a follow-up patch, adding a comment before the call to
cpu_clean_all_dirty that explains what's
On Tue, 16 Sep 2014 15:45:32 +0800
zhanghailiang zhang.zhanghaili...@huawei.com wrote:
In error message, maxmem is printed in Dec but ram_size in Hex.
It is better to print them in same format.
Also use error_report instead of fprintf.
Signed-off-by: zhanghailiang
Fix a typo introduced by 94c80a438c85f2c19698547fbb115ea46d80c5f1
Signed-off-by: Chrysostomos Nanakos cnana...@grnet.gr
---
block/archipelago.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/archipelago.c b/block/archipelago.c
index 93fb7c0..f4982fa 100644
---
Chrysostomos Nanakos (1):
block/archipelago: Fix typo in qemu_archipelago_truncate()
block/archipelago.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.10.4
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/09/2014 09:21, Markus Armbruster ha scritto:
The rebase onto QOM renamed name to legacy_name, to free name for use as
QOM type name (commit cafe5bd).
Also, the QOM type name has strict rules:
- either it is a QAPI type (primitive, enum or
On 2014/9/16 17:12, Igor Mammedov wrote:
On Tue, 16 Sep 2014 15:45:32 +0800
zhanghailiangzhang.zhanghaili...@huawei.com wrote:
In error message, maxmem is printed in Dec but ram_size in Hex.
It is better to print them in same format.
Also use error_report instead of fprintf.
Signed-off-by:
This is obviously wrong, we have to put a \0 to separate the two options.
But thee question remains, should we mark that as arm,armv8-timer compatible?
Thanks,
Claudio
On 15 September 2014 10:14, hw.clau...@gmail.com wrote:
From: Claudio Fontana claudio.font...@huawei.com
Signed-off-by:
Il 16/09/2014 11:16, Markus Armbruster ha scritto:
I think both str and linkblock-backend actually are a small degradation
compared to drive, and this is why I kept the legacy_name. But overall I
think it's not really worth the layering violation that patches 2 and 3 are;
and it's definitely
Hi Igor,
On 09/04/2014 10:20 PM, Igor Mammedov wrote:
..
+
+acpi_handle_ost_event(mdev);
_OST is optional and OSPM doesn't have to call it at all,
it was already discussed on list and using _OST for device removal
was evaluated as not usable.
We use _OST here as supplementary
ping...
On Fri, Sep 12, 2014 at 05:22:45PM +0800, Hu Tao wrote:
ping?
On Wed, Sep 10, 2014 at 05:05:44PM +0800, Hu Tao wrote:
This series adds two preallocation mode to qcow2 and raw:
Option preallocation=full preallocates disk space for image by writing
zeros to disk, this ensures
On Tue, Sep 16, 2014 at 10:19:33AM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Normally, qmp_device_list_properties() may return NULL when
a device haven't special properties excpet Object and DeviceState
properties, such as virtio-balloon-device.
We just
On Mon, Sep 15, 2014 at 02:52:58PM +0200, Paolo Bonzini wrote:
If ret is WAIT_TIMEOUT and there was an event returned by select(),
we can write to a location after the end of the array. But in
that case we can retry the WaitForMultipleObjects call with the
same set of events, so just move the
On Mon, Sep 15, 2014 at 11:47:02AM -0600, Eric Blake wrote:
On 09/11/2014 12:09 AM, Fam Zheng wrote:
v7: Add Benoît's rev-by line in patch 2.
Improved help text in patch 1. (Benoît)
v6: Don't inherit from BlockdevOptionsFile. (Stefan)
Use .bdrv_co_readv instead of .bdrv_read.
When do memory hotplug, if there is numa node, we should add
the memory size to the corresponding node memory size.
For now, it mainly affects the result of hmp command info numa.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
hw/i386/pc.c| 1 +
Hi,
In qemu, We do not update the numa node memory size after hotplug memory,
There will be a confused result for hmp command info numa after hotplug
memory.
Also, if we do not configure numa option, we can't hotplug memory, i think this
is
a bug.
This patch series fix them.
zhanghailiang
If we do not configure numa option, memory hotplug should work as well.
It should not depend on numa option.
Steps to reproduce:
(1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G
(2) Hotplug memory
It will fail and reports:
'DIMM property node has value 0' which exceeds the number of numa nodes: 0
In error message, maxmem is printed in Dec but ram_size in Hex.
It is better to print them in same format.
Also use error_report instead of fprintf.
Reviewed-By: Igor Mammedov imamm...@redhat.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
v3:
- fix an indent error
- add
Il 16/09/2014 12:37, Michael S. Tsirkin ha scritto:
str really should be for free-form strings.
It makes as much sense to call it as string
Yes, that's why I said drive-str is a degradation. The question is,
how important is that degradation?
as it is to call an integer a string because you
Am 16.09.2014 um 12:10 hat Hu Tao geschrieben:
ping...
Sorry, forgot to send the mail when I merged it. This is in master now.
Kevin
On Fri, Sep 12, 2014 at 05:22:45PM +0800, Hu Tao wrote:
ping?
On Wed, Sep 10, 2014 at 05:05:44PM +0800, Hu Tao wrote:
This series adds two
On Tue, Sep 16, 2014 at 11:34:07AM +0200, Paolo Bonzini wrote:
Il 16/09/2014 11:16, Markus Armbruster ha scritto:
I think both str and linkblock-backend actually are a small
degradation
compared to drive, and this is why I kept the legacy_name. But overall I
think it's not really worth
On Sat, Sep 13, 2014 at 09:45:21AM -0700, Richard Henderson wrote:
Cc: Edgar E. Iglesias edgar.igles...@gmail.com
Signed-off-by: Richard Henderson r...@twiddle.net
Both CRIS and MicroBlaze look good, thanks.
Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com
---
cpu-exec.c
On Tue, 16 Sep 2014 18:39:16 +0800
zhanghailiang zhang.zhanghaili...@huawei.com wrote:
When do memory hotplug, if there is numa node, we should add
the memory size to the corresponding node memory size.
For now, it mainly affects the result of hmp command info numa.
Signed-off-by:
On Tue, 16 Sep 2014 18:12:02 +0800
Tang Chen tangc...@cn.fujitsu.com wrote:
Hi Igor,
On 09/04/2014 10:20 PM, Igor Mammedov wrote:
..
+
+acpi_handle_ost_event(mdev);
_OST is optional and OSPM doesn't have to call it at all,
it was already discussed on list and using
On Fri, Sep 12, 2014 at 07:04:17PM +0100, Peter Maydell wrote:
GDB assumes that watchpoint set via the gdbstub remote protocol will
behave in the same way as hardware watchpoints for the target. In
particular, whether the CPU stops with the PC before or after the insn
which triggers the
Hi!
I am having problems when migrate a guest via libvirt like this:
virsh migrate --live --persistent --undefinesource --copy-storage-all
--verbose --desturi qemu+ssh://legkvm/system --domain chig1
The XML used to create the guest is at the end of this mail.
I see NBD FLUSH command after the
Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto:
I am having problems when migrate a guest via libvirt like this:
virsh migrate --live --persistent --undefinesource --copy-storage-all
--verbose --desturi qemu+ssh://legkvm/system --domain chig1
The XML used to create the guest is at
Conflicts with current master now. I'll rebase.
On 09/15/2014 11:51 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
s/poniter/pointer/ in the subject
In this way, we can use target object and get its qdev
property legacy_name etc.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Dear All
I am new to this list. Does any on list know if there is a softwareHSM for
qemu similiar to that for OpenVZ described here?:-
https://openvz.org/Virtual_HSM
thanks in advance
sincerely
Sibu
On 09/16/2014 04:30 AM, Stefan Hajnoczi wrote:
On Mon, Sep 15, 2014 at 11:47:02AM -0600, Eric Blake wrote:
On 09/11/2014 12:09 AM, Fam Zheng wrote:
v7: Add Benoît's rev-by line in patch 2.
Improved help text in patch 1. (Benoît)
v6: Don't inherit from BlockdevOptionsFile. (Stefan)
Am 16.09.2014 um 14:10 hat Paolo Bonzini geschrieben:
Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto:
I am having problems when migrate a guest via libvirt like this:
virsh migrate --live --persistent --undefinesource --copy-storage-all
--verbose --desturi qemu+ssh://legkvm/system
On Tue, 16 Sep 2014 09:25:02 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
When a QMP client changes the polling interval time by setting
the guest-stats-polling-interval property, the interval value
is stored and manipuled as an int64_t
Il 16/09/2014 14:34, Kevin Wolf ha scritto:
I think bdrv_invalidate_cache() really needs to call bdrv_drain_all()
before starting to reopen stuff. There could be requests in flight
without holding the lock and if you can indeed reopen their BDS under
their feet without breaking things (I doubt
+DriveInfo *blk_legacy_dinfo(BlockBackend *blk)
+{
+return blk-legacy_dinfo;
+}
+
+/*
+ * Set @blk's DriveInfo to @dinfo, and return it.
+ * @blk must not have a DriveInfo set already.
+ * No other BlockBackend may have the same DriveInfo set.
Must we try to assert this ?
This would
On Sat, Sep 13, 2014 at 05:00:09PM +0200, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/block-backend.c | 15 +++
blockdev.c| 13 -
include/sysemu/blockdev.h | 1 -
stubs/Makefile.objs | 1 -
Am 16.09.2014 um 14:35 hat Paolo Bonzini geschrieben:
Il 16/09/2014 14:34, Kevin Wolf ha scritto:
I think bdrv_invalidate_cache() really needs to call bdrv_drain_all()
before starting to reopen stuff. There could be requests in flight
without holding the lock and if you can indeed reopen
/* blkdev-bs is not create by us, we get a reference
* so we can bdrv_unref() unconditionally */
-bdrv_ref(blkdev-bs);
+/* Except we don't bdrv_unref() anymore, we blk_unref().
Is this dot extra ? ^
The following
Il 16/09/2014 14:52, Kevin Wolf ha scritto:
Yes, that's true. We can't fix this problem in qcow2, though, because
it's a more general one. I think we must make sure that
bdrv_invalidate_cache() doesn't yield.
Either by forbidding to run bdrv_invalidate_cache() in a coroutine and
moving the
Hi,
A two parts patch to add a QEmu support for Microsoft's Virtual Machine
Generation ID device.
The first one add a new ACPI directive which allow to use a 16-bytes
buffer in an ACPI table. This buffer is for storing the VM's UUID.
The second is the ACPI tables changes and the actual device.
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an
ACPI table.
Signed-off-by: Gal Hammer gham...@redhat.com
---
scripts/acpi_extract.py | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py
Based on Microsoft's sepecifications (paper can be dowloaded from
http://go.microsoft.com/fwlink/?LinkId=260709), add a device
description to the SSDT ACPI table.
The GUID is set using a new vmgenid device.
Signed-off-by: Gal Hammer gham...@redhat.com
---
default-configs/i386-softmmu.mak | 1
@@ -4717,10 +4699,14 @@ static void monitor_find_completion_by_table(Monitor
*mon,
break;
case 'B':
/* block device name completion */
-mbs.mon = mon;
-mbs.input = str;
readline_set_completion_index(mon-rs,
#include qemu-common.h
-#include block/block_int.h
+#include block/block.h
+#include qemu/error-report.h
+#include qemu/main-loop.h
That's a lot of include fiddling I am not sure to understand them while looking
at the following diff.
#include hw/hw.h
#include qemu/queue.h
#include
1.9.3
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Hi,
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Tuesday, September 16, 2014 6:46 PM
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties
Il 16/09/2014 12:37, Michael S. Tsirkin ha scritto:
str really should be for free-form strings.
It makes as much
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Tuesday, September 16, 2014 8:23 PM
Subject: Re: [PATCH v2 2/3] qom: add AliasProperty struct poniter for alias
property in ObjectProperty
On 09/15/2014 11:51 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
On Thu, Sep 11, 2014 at 02:09:55PM +0800, Fam Zheng wrote:
v7: Add Benoît's rev-by line in patch 2.
Improved help text in patch 1. (Benoît)
v6: Don't inherit from BlockdevOptionsFile. (Stefan)
Use .bdrv_co_readv instead of .bdrv_read. (Kevin)
Sort items in qapi schema
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hmp.c b/hmp.c
index 40a90da..31fb6a1 100644
--- a/hmp.c
+++ b/hmp.c
@@ -679,6 +679,8 @@ void hmp_info_block_jobs(Monitor *mon, const QDict *qdict)
When a QMP client changes the polling interval time by setting
the guest-stats-polling-interval property, the interval value
is stored and manipulated as an int64_t variable.
However, the balloon_stats_change_timer() function, which is
used to set the actual timer with the interval value, takes
On Mon, Sep 15, 2014 at 01:30:40PM -0700, Peter Maydell wrote:
On 14 September 2014 11:41, Michael S. Tsirkin m...@redhat.com wrote:
The following changes since commit 4c24f4004089a308c5de8ed720cf6bd1746aedd8:
Merge remote-tracking branch
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 16 Sep 2014 09:25:02 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
When a QMP client changes the polling interval time by setting
the guest-stats-polling-interval property, the
On Tue, 16 Sep 2014 15:43:14 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 16 Sep 2014 09:25:02 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
When a QMP client changes the
On Fri, Sep 5, 2014 at 6:29 PM, Philipp Gesang
philipp.ges...@intra2net.com wrote:
fallocate() is needed for snapshotting. If it isn’t whitelisted
$ qemu-img create -f qcow2 x.qcow 1G
Formatting 'x.qcow', fmt=qcow2 size=1073741824 encryption=off
cluster_size=65536 lazy_refcounts=off
1 - 100 of 255 matches
Mail list logo
