Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges.

2014-10-25 Thread Knut Omang
On Sat, 2014-10-25 at 14:24 +0200, Jan Kiszka wrote: > On 2014-10-25 13:36, Jan Kiszka wrote: > > On 2014-10-21 00:34, Knut Omang wrote: > >> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c > >> index 40c97b1..e6832c4 100644 > >> --- a/hw/pci/pci_bridge.c > >> +++ b/hw/pci/pci_bridge.c > >>

[Qemu-devel] network traffic throttling

2014-10-25 Thread William Dauchy
Hi, I'm looking for a way to limit the number of PPS using vhost-net interface in kvm. I saw http://www.linux-kvm.org/page/NetworkingTodo network traffic throttling block implemented "continuous leaky bucket" for throttling we can use continuous leaky bucket to network IOPS/BPS * RX/TX/TOTAL Dev

Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes

2014-10-25 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 06:55:45PM -0400, John Snow wrote: > Based off of feedback from the RFC of the same name, > this series batches together a group of fixes that > improve the AHCI device to fix a number of bugs. > > A number of fixes included in the RFC that provide more > radical changes ar

[Qemu-devel] Solaris 8 SPARC, Web Start Launcher Crashing

2014-10-25 Thread P. Wilhelm
In late May of 2011, Brian Vandenberg queried this group about failures he was having trying to install Solaris 8 SPARC 02/04 on a Qemu VM. The interaction seemed to have ended with Blue Swirl indicating that Brian should run with "-d in_ascm,int" and that the debug output would likely be usefu

[Qemu-devel] [PATCHv3 6/6] block: fix qemu-iotest reference output for test 067

2014-10-25 Thread Peter Lieven
Output is changed by the addition of the write-merging parameter Signed-off-by: Peter Lieven Reviewed-by: Max Reitz --- tests/qemu-iotests/067.out | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/067.out b/tests/qemu-iotests/067.out index 0f72d

[Qemu-devel] [PATCHv3 0/6] multiwrite patches for 2.2

2014-10-25 Thread Peter Lieven
This adds some preparing patches for upcoming multiwrite modifications. I will leave the dangerous patches for after 2.2 release. Due to oversized lines in the iotest output please pull from: g...@github.com:plieven/qemu.git -b multiwrite_22_v3 v2->v3: - Removed statistic output for merged read

[Qemu-devel] [PATCHv3 5/6] block: add qemu-iotest for write-merge parameter

2014-10-25 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/109 | 113 tests/qemu-iotests/109.out | 68 ++ tests/qemu-iotests/group |1 + 3 files changed, 182 insertions(+) create mode 100755 tests/qemu-iotests/109 create

[Qemu-devel] [PATCHv3 3/6] block: add a knob to disable multiwrite_merge

2014-10-25 Thread Peter Lieven
The block layer silently merges write requests since commit 40b4f539. This patch adds a knob to disable this feature as there has been some discussion lately if multiwrite is a good idea at all and as it falsifies benchmarks. Signed-off-by: Peter Lieven Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCHv3 2/6] block: introduce bdrv_runtime_opts

2014-10-25 Thread Peter Lieven
This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. The list will absorb all options that belong to the BDS (and not the BlockBackend) and will be parsed and handled in bdrv_open_common. Signed-off-by: Kevin Wolf Signed-off-by: Peter Lieven Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCHv3 4/6] hw/virtio-blk: add a constant for max number of merged requests

2014-10-25 Thread Peter Lieven
As it was not obvious (at least for me) where the 32 comes from; add a constant for it. Signed-off-by: Peter Lieven Reviewed-by: Max Reitz --- hw/block/virtio-blk.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index b19b

[Qemu-devel] [PATCHv3 1/6] block: add accounting for merged requests

2014-10-25 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c|2 ++ block/accounting.c |7 +++ block/qapi.c |1 + hmp.c |4 +++- include/block/accounting.h |3 +++ qapi/block-core.json |7 ++- 6 files changed, 22 inser

[Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length

2014-10-25 Thread Peter Lieven
Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. Signed-off-by: Peter Lieven --- block/iscsi.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 233f462..1ae4add 100644 --- a/blo

[Qemu-devel] [PATCHv5 2/6] BlockLimits: introduce max_transfer_length

2014-10-25 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Max Reitz --- block.c |4 include/block/block_int.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/block.c b/block.c index 88f6d9b..76fcc1d 100644 --- a/block.c +++ b/block.c @@ -519,6 +519,7 @@ void bdrv_refresh_lim

[Qemu-devel] [PATCHv5 1/6] util: introduce MIN_NON_ZERO

2014-10-25 Thread Peter Lieven
at least in block layer we have the case of limits being defined for a BlockDriverState. However, in this context often zero (0) has the special meanining of undefined which means no limit. If two of those limits are combined and the minimum is needed the minimum function should only return zero if

[Qemu-devel] [PATCHv5 5/6] block/iscsi: limit to INT_MAX throughout iscsi_refresh_limits

2014-10-25 Thread Peter Lieven
As Max pointed out there is a hidden cast from int64_t to int. So use the newly introduced nb_sectors_lun2qemu for all limits. Signed-off-by: Peter Lieven --- block/iscsi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c

[Qemu-devel] [PATCHv5 6/6] block/iscsi: check for oversized requests

2014-10-25 Thread Peter Lieven
Cancel oversized requests early. They would generate an iSCSI protocol error anyway; after having transferred possibly a lot of data over the wire. Suggested-By: Max Reitz Signed-off-by: Peter Lieven --- block/iscsi.c | 12 1 file changed, 12 insertions(+) diff --git a/block/isc

[Qemu-devel] [PATCHv5 0/6] introduce max_transfer_length

2014-10-25 Thread Peter Lieven
This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix. Splitting up requests according to the max_transfer_length will fo

[Qemu-devel] [PATCHv5 4/6] block: avoid creating oversized writes in multiwrite_merge

2014-10-25 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg Reviewed-by: Max Reitz --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 76fcc1d..4179341 100644 --- a/block.c +++ b/block.c @@ -4446,6 +4446,11 @@ static int multiwrite_merge(BlockDriverState

Re: [Qemu-devel] [PATCHv4 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-10-25 Thread Peter Lieven
Am 23.10.2014 um 13:23 schrieb Max Reitz: > On 2014-10-16 at 09:54, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> Reviewed-by: Ronnie Sahlberg >> --- >> block.c |5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/block.c b/block.c >> index 0fbf916..9ad2287 100644 >> ---

Re: [Qemu-devel] [PATCHv4 3/4] block/iscsi: set max_transfer_length

2014-10-25 Thread Peter Lieven
Am 23.10.2014 um 13:18 schrieb Max Reitz: > On 2014-10-16 at 09:54, Peter Lieven wrote: >> the limit of 0xff for 16 byte CDBs is intentional to >> avoid overflows on 32-bit architectures. > > How is it related to 32 bit? I somehow feel like it has to do something with > the result of sector_lu

Re: [Qemu-devel] [PATCH 19/18] Introduce "xen-load-devices-state"

2014-10-25 Thread Stefano Stabellini
On Fri, 24 Oct 2014, Wen Congyang wrote: > Introduce a "xen-load-devices-state" QAPI command that can be used to load > the state of all devices, but not the RAM or the block devices of the > VM. > > We only have hmp commands savevm/loadvm, and qmp commands > xen-save-devices-state. > > We use th

[Qemu-devel] [PATCH] block: qemu-iotest 107 supports NFS

2014-10-25 Thread Peter Lieven
As discussed during review a follow up for Max's fix. Signed-off-by: Peter Lieven --- tests/qemu-iotests/107 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/107 b/tests/qemu-iotests/107 index cad1cf9..9862030 100755 --- a/tests/qemu-iotests/107 +++ b/tes

Re: [Qemu-devel] [PATCH] block: qemu-iotests change _supported_proto to file once more.

2014-10-25 Thread Peter Lieven
Am 22.10.2014 um 14:03 schrieb Kevin Wolf: > Am 20.10.2014 um 13:47 hat Peter Lieven geschrieben: >> In preparation to possible automatic regression and performance >> testing for the block layer I found that the iotests don't work >> for all protocols anymore. >> >> In commit 1f7bf7d0 I started to

Re: [Qemu-devel] dynamic sysbus instantiation and load_dtb implementation

2014-10-25 Thread David Gibson
On Thu, Oct 23, 2014 at 01:26:08PM +0200, Alexander Graf wrote: > > > On 23.10.14 13:24, Peter Maydell wrote: > > On 23 October 2014 12:23, Alexander Graf wrote: > >> On 23.10.14 12:19, Ard Biesheuvel wrote: > >>> The reason for this change was that, before, the DTB would only be > >>> generated

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges.

2014-10-25 Thread Jan Kiszka
On 2014-10-21 00:34, Knut Omang wrote: > @@ -1801,8 +1792,7 @@ static IOMMUTLBEntry vtd_iommu_translate(MemoryRegion > *iommu, hwaddr addr, > return ret; > } > > -vtd_do_iommu_translate(vtd_as, vtd_as->bus_num, vtd_as->devfn, addr, > - is_write, &ret);

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges.

2014-10-25 Thread Jan Kiszka
On 2014-10-25 13:36, Jan Kiszka wrote: > On 2014-10-21 00:34, Knut Omang wrote: >> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c >> index 40c97b1..e6832c4 100644 >> --- a/hw/pci/pci_bridge.c >> +++ b/hw/pci/pci_bridge.c >> @@ -376,8 +376,14 @@ int pci_bridge_initfn(PCIDevice *dev, const ch

Re: [Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously

2014-10-25 Thread Jan Kiszka
On 2014-10-25 13:34, Gonglei wrote: > Hi, > >> Subject: [Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and >> SIGTERM synchronously >> >> Add the termination signals SIGINT, SIGHUP and SIGTERM to the >> list of signals which we handle synchronously via a signalfd. >> This avoids a race co

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges.

2014-10-25 Thread Jan Kiszka
On 2014-10-21 00:34, Knut Omang wrote: > diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c > index 40c97b1..e6832c4 100644 > --- a/hw/pci/pci_bridge.c > +++ b/hw/pci/pci_bridge.c > @@ -376,8 +376,14 @@ int pci_bridge_initfn(PCIDevice *dev, const char > *typename) > sec_bus->address_space

Re: [Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously

2014-10-25 Thread Gonglei
Hi, > Subject: [Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and > SIGTERM synchronously > > Add the termination signals SIGINT, SIGHUP and SIGTERM to the > list of signals which we handle synchronously via a signalfd. > This avoids a race condition where if we took the SIGTERM > in the

[Qemu-devel] [PATCH v6 7/7] netduino2: Add the Netduino 2 Machine

2014-10-25 Thread Alistair Francis
This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis --- hw/arm/Makefile.objs | 1 + hw/arm/netduino2.c | 54 2

[Qemu-devel] [PATCH v6 5/7] target_arm: Parameterise the irq lines for armv7m_init

2014-10-25 Thread Alistair Francis
This patch allows the board to specifiy the number of NVIC interrupt lines when using armv7m_init. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/armv7m.c | 7 --- hw/arm/stellaris.c | 5 - include/hw/arm/arm.h | 2 +- 3 files changed, 9 insertions(+),

[Qemu-devel] [PATCH v6 6/7] stm32f205: Add the stm32f205 SoC

2014-10-25 Thread Alistair Francis
This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine. Signed-off-by: Alistair Francis --- V6: - Correct the number of USART/UART devices - Use macros to define how many devices are inited - Update the memory regions name from netduino.* to STM32F205.*

[Qemu-devel] [PATCH v6 2/7] stm32f2xx_USART: Add the stm32f2xx USART Controller

2014-10-25 Thread Alistair Francis
This patch adds the stm32f2xx USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis --- V6: - Rename to STM32F2XX - Fix up unimplemented printing - Add a qemu_chr_accept() V3: - Update debug printing V2: - Drop charecters if the device is not enabled - Th

[Qemu-devel] [PATCH v6 4/7] target_arm: Remove memory region init from armv7m_init

2014-10-25 Thread Alistair Francis
This patch moves the memory region init code from the armv7m_init function to the stellaris_init function Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V3: - Rename the flash_size argument to mem_size - Remove the sram_size and related code - Thanks to Peter C V2: - C

[Qemu-devel] [PATCH v6 0/7] Netduino 2 Machine Model

2014-10-25 Thread Alistair Francis
This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at: https://github.com/alistair23/qemu/tree/netduino2.6 This patch series makes some changes to the armv7m_init function that allow

[Qemu-devel] [PATCH v6 3/7] stm32f2xx_SYSCFG: Add the stm32f2xx SYSCFG

2014-10-25 Thread Alistair Francis
This patch adds the stm32f2xx System Configuration Controller. This is used to configure what memory is mapped at address 0 (although that is not supported) as well as configure how the EXTI interrupts work (also not supported at the moment). This device is not required for basic examples, but mor

[Qemu-devel] [PATCH v6 1/7] stm32f2xx_timer: Add the stm32f2xx Timer

2014-10-25 Thread Alistair Francis
This patch adds the stm32f2xx timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis --- V6: - Rename to STM32F2XX - Change the timer calculations to use ns - Update the value to timer_mod to ensure it is in ns - Account for reloadable/resetable timer - Thanks to Peter

Re: [Qemu-devel] [Nbd] spec, RFC: TLS support for NBDµ

2014-10-25 Thread Wouter Verhelst
Hi all, I haven't seen a reply to this anymore. Do people still have comments? I'm planning on doing a release of nbd later this weekend, and would like to include this (not the TLS implementation yet, but at least the spec) Thanks, On Tue, Oct 21, 2014 at 08:30:05PM +0200, Wouter Verhelst wrote

[Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-25 Thread john.liuli
From: Li Liu This set of patches try to implemet irqfd support of vhost-net based on virtio-mmio. I had posted a mail to talking about the status of vhost-net on kvm-arm refer to http://www.spinics.net/lists/kvm-arm/msg10804.html. Some dependent patches are listed in the mail too. Basically th

[Qemu-devel] [RFC PATCH 1/2] Add a new register offset let interrupt reason available

2014-10-25 Thread john.liuli
From: Li Liu Add a new register offset VIRTIO_MMIO_ISRMEM which help to estblish a shared memory region between virtio-mmio driver and qemu with two purposes: 1.Guest virtio-mmio driver can get the interrupt reason. 2.Check irqfd enabled or not to register different irq handler. Signed-off-by:

[Qemu-devel] [RFC PATCH 2/2] Assign a new irq handler while irqfd enabled

2014-10-25 Thread john.liuli
From: Li Liu This irq handler will get the interrupt reason from a shared memory. And will be assigned only while irqfd enabled. Signed-off-by: Li Liu --- drivers/virtio/virtio_mmio.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/driv

Re: [Qemu-devel] slirp-smb broken with Samba 4.1

2014-10-25 Thread Jan Kiszka
On 2014-10-24 22:43, Michael Tokarev wrote: > But I really wonder if we should run a helper script to set things > up instead of hardcoding it all into qemu binary... It is so much > easier to modify and debug the script. Yes, seems reasonable. I would review and test a patch if you like to look

Re: [Qemu-devel] [PATCH] net/slirp: specify logbase for smbd

2014-10-25 Thread Jan Kiszka
On 2014-10-24 22:37, Michael Tokarev wrote: > It looks like smbd always logs to /var/log/samba/log.$progname > even if config file specifies different logfile -- when it needs > to log something before completing reading the config file. But > if it can't open it for writing, it fails and exits.

[Qemu-devel] [question] How is the progress of optimizing qcow2_check_metadata_overlap() with reagard to cpu overhead?

2014-10-25 Thread Zhang Haoyu
Hi, Max How is the progress of optimizing qcow2_check_metadata_overlap? http://thread.gmane.org/gmane.comp.emulators.kvm.devel/127037/focus=127364 Thanks, Zhang Haoyu