[Qemu-devel] [PATCH v3 1/2] main-loop: Introduce context parameter for qemu_poll_ns

2014-10-27 Thread Fam Zheng
So that qemu_poll_ns can save state in the context in the future. Signed-off-by: Fam Zheng f...@redhat.com --- aio-posix.c | 2 +- include/block/aio.h | 2 ++ include/qemu/timer.h | 7 ++- main-loop.c | 7 +-- qemu-timer.c | 3 ++- 5 files changed, 16

[Qemu-devel] [PATCH v3 0/2] main-loop: Use epoll on Linux

2014-10-27 Thread Fam Zheng
v3: Use separate structure for poll context instead of AioContext. (Stefan) Fam Zheng (2): main-loop: Introduce context parameter for qemu_poll_ns main-loop: Use epoll on Linux Makefile.objs| 1 + aio-posix.c | 2 +- include/block/aio.h | 2 +

[Qemu-devel] [PATCH v3 2/2] main-loop: Use epoll on Linux

2014-10-27 Thread Fam Zheng
A new implementation for qemu_poll_ns based on epoll is introduced here to address the slowness of g_poll and ppoll when the number of fds are high. On my laptop this would reduce the virtio-blk on top of null-aio device's response time from 32 us to 29 us with few fds (~10), and 48 us to 32 us

Re: [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty

2014-10-27 Thread Max Reitz
On 2014-10-24 at 18:31, Eric Blake wrote: On 10/24/2014 07:57 AM, Max Reitz wrote: Add a test for qcow2's fast bdrv_make_empty implementation on images without internal snapshots. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/098 | 82

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Gerd Hoffmann
On Fr, 2014-10-24 at 11:00 +0200, Marc-André Lureau wrote: The spice server is polling on write, unless SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must call spice_server_char_device_wakeup() when the frontend is writable. Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [question] How is the progress of optimizing qcow2_check_metadata_overlap() with reagard to cpu overhead?

2014-10-27 Thread Max Reitz
On 2014-10-25 at 09:00, Zhang Haoyu wrote: Hi, Max How is the progress of optimizing qcow2_check_metadata_overlap? http://thread.gmane.org/gmane.comp.emulators.kvm.devel/127037/focus=127364 Thanks, Zhang Haoyu Hi Zhang Haoyu, there are still a couple of upstream series I've worked on for

Re: [Qemu-devel] [PATCH] block: qemu-iotest 107 supports NFS

2014-10-27 Thread Max Reitz
On 2014-10-25 at 17:05, Peter Lieven wrote: As discussed during review a follow up for Max's fix. Signed-off-by: Peter Lieven p...@kamp.de --- tests/qemu-iotests/107 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCHv4 3/4] block/iscsi: set max_transfer_length

2014-10-27 Thread Max Reitz
On 2014-10-25 at 17:16, Peter Lieven wrote: Am 23.10.2014 um 13:18 schrieb Max Reitz: On 2014-10-16 at 09:54, Peter Lieven wrote: the limit of 0xff for 16 byte CDBs is intentional to avoid overflows on 32-bit architectures. How is it related to 32 bit? I somehow feel like it has to do

Re: [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-27 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 10/21/2014 12:10 AM, Gonglei wrote: There is a problem. 1. Qemu receive the eject command. 2. Runs eject_request_cb when an eject request is issued from the monitor, the tray is closed, and the medium is locked. But the drive is not closed. 3.

Re: [Qemu-devel] [PATCHv5 1/6] util: introduce MIN_NON_ZERO

2014-10-27 Thread Max Reitz
On 2014-10-25 at 18:18, Peter Lieven wrote: at least in block layer we have the case of limits being defined for a BlockDriverState. However, in this context often zero (0) has the special meanining of undefined which means no limit. If two of those limits are combined and the minimum is needed

Re: [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Max Reitz
On 2014-10-25 at 18:18, Peter Lieven wrote: Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCHv5 5/6] block/iscsi: limit to INT_MAX throughout iscsi_refresh_limits

2014-10-27 Thread Max Reitz
On 2014-10-25 at 18:18, Peter Lieven wrote: As Max pointed out there is a hidden cast from int64_t to int. So use the newly introduced nb_sectors_lun2qemu for all limits. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 20 ++-- 1 file changed, 10 insertions(+),

Re: [Qemu-devel] [PATCHv5 6/6] block/iscsi: check for oversized requests

2014-10-27 Thread Max Reitz
On 2014-10-25 at 18:18, Peter Lieven wrote: Cancel oversized requests early. They would generate an iSCSI protocol error anyway; after having transferred possibly a lot of data over the wire. Suggested-By: Max Reitz mre...@redhat.com Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c

Re: [Qemu-devel] [PATCHv5 5/6] block/iscsi: limit to INT_MAX throughout iscsi_refresh_limits

2014-10-27 Thread Peter Lieven
On 27.10.2014 09:32, Max Reitz wrote: On 2014-10-25 at 18:18, Peter Lieven wrote: As Max pointed out there is a hidden cast from int64_t to int. So use the newly introduced nb_sectors_lun2qemu for all limits. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 20

Re: [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Peter Lieven
On 27.10.2014 09:28, Max Reitz wrote: On 2014-10-25 at 18:18, Peter Lieven wrote: Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 17 +++-- 1 file changed, 15

Re: [Qemu-devel] [PATCHv5 5/6] block/iscsi: limit to INT_MAX throughout iscsi_refresh_limits

2014-10-27 Thread Max Reitz
On 2014-10-27 at 09:35, Peter Lieven wrote: On 27.10.2014 09:32, Max Reitz wrote: On 2014-10-25 at 18:18, Peter Lieven wrote: As Max pointed out there is a hidden cast from int64_t to int. So use the newly introduced nb_sectors_lun2qemu for all limits. Signed-off-by: Peter Lieven p...@kamp.de

Re: [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Max Reitz
On 2014-10-27 at 09:36, Peter Lieven wrote: On 27.10.2014 09:28, Max Reitz wrote: On 2014-10-25 at 18:18, Peter Lieven wrote: Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 17

Re: [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Peter Lieven
On 27.10.2014 09:44, Max Reitz wrote: On 2014-10-27 at 09:36, Peter Lieven wrote: On 27.10.2014 09:28, Max Reitz wrote: On 2014-10-25 at 18:18, Peter Lieven wrote: Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCHv3 1/6] block: add accounting for merged requests

2014-10-27 Thread Max Reitz
On 2014-10-25 at 18:55, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block.c|2 ++ block/accounting.c |7 +++ block/qapi.c |1 + hmp.c |4 +++- include/block/accounting.h |3 +++

[Qemu-devel] [PATCH] virtio-scsi: sense in virtio_scsi_command_complete

2014-10-27 Thread Ting Wang
If req-resp.cmd.status is not GOOD, the address of sense for qemu_iovec_from_buf should be modified from req-resp to sense. Signed-off-by: Ting Wang kathy.wangt...@huawei.com --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c

Re: [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Max Reitz
On 2014-10-27 at 09:47, Peter Lieven wrote: On 27.10.2014 09:44, Max Reitz wrote: On 2014-10-27 at 09:36, Peter Lieven wrote: On 27.10.2014 09:28, Max Reitz wrote: On 2014-10-25 at 18:18, Peter Lieven wrote: Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in

[Qemu-devel] [PATCH 7/9] block/parallels: support padded Parallels images

2014-10-27 Thread Denis V. Lunev
Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. For the time being Parallels was created an optimization for such OSes in its desktop product. Desktop users are not qualified enough to create properly aligned

[Qemu-devel] [PATCH 1/9] iotests: replace fake parallels image with authentic one

2014-10-27 Thread Denis V. Lunev
The image was generated using http://openvz.org/Ploop utility and properly filled with the same content as original one. Signed-off-by: Denis V. Lunev d...@openvz.org Reviewed-by: Paolo Bonzini pbonz...@redhat.com CC: Jeff Cody jc...@redhat.com CC: Kevin Wolf kw...@redhat.com CC: Stefan Hajnoczi

[Qemu-devel] [PATCH 4/9] configure: add dependency from libxml2

2014-10-27 Thread Denis V. Lunev
This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. The patch also adds clause to checkpatch.pl to

[Qemu-devel] [PATCH 6/9] iotests: simple parallels XML disk descriptor file test added

2014-10-27 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev d...@openvz.org Acked-by: Roman Kagan rka...@parallels.com CC: Jeff Cody jc...@redhat.com CC: Kevin Wolf kw...@redhat.com CC: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/076| 6 ++ tests/qemu-iotests/076.out

[Qemu-devel] [PATCH 2/9] iotests: add v2 parallels sample image and simple test for it

2014-10-27 Thread Denis V. Lunev
This is simple test image for the following commit made by me. commit d25d59802021a747812472780d80a0e792078f40 Author: Denis V. Lunev d...@openvz.org Date: Mon Jul 28 20:23:55 2014 +0400 parallels: 2TB+ parallels images support Signed-off-by: Denis V. Lunev d...@openvz.org

Re: [Qemu-devel] [PATCHv3 5/6] block: add qemu-iotest for write-merge parameter

2014-10-27 Thread Max Reitz
On 2014-10-25 at 18:55, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- tests/qemu-iotests/109 | 113 tests/qemu-iotests/109.out | 68 ++ tests/qemu-iotests/group |1 + 3 files changed, 182

[Qemu-devel] [PATCH 5/9] block/parallels: allow to specify DiskDescriptor.xml instead of image file

2014-10-27 Thread Denis V. Lunev
Typically Parallels disk bundle consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. This patch allows to specify this XML file as a filename for an image to open. It is allowed only to

[Qemu-devel] [PATCH 0/9] parallels format support improvements

2014-10-27 Thread Denis V. Lunev
This patchset contains my previous patchset sent originally 08.10.2014 with minor Valgrind fix and iotests update as a base. The patchset implements additional compatibility bits for Parallels format: - initial support of parsing of Parallels DiskDeskriptor.xml Typically Parallels disk bundle

Re: [Qemu-devel] [PATCH] Make qemu_shutdown_requested signal-safe

2014-10-27 Thread Paolo Bonzini
On 10/26/2014 10:32 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com qemu_shutdown_requested may be interrupted by qemu_system_killed. If the latter sets shutdown_requested after qemu_shutdown_requested has read it but before it was cleared, the shutdown event is lost. Fix

[Qemu-devel] [PATCH 3/9] block/parallels: fix access to not initialized memory in catalog_bitmap

2014-10-27 Thread Denis V. Lunev
found by valgrind. Command: ./qemu-img convert -f parallels -O qcow2 1.hds 1.img Invalid read of size 4 at 0x17D0EF: parallels_co_read (parallels.c:357) by 0x11FEE4: bdrv_aio_rw_vector (block.c:4640) by 0x11FFBF: bdrv_aio_readv_em (block.c:4652) by 0x11F55F: bdrv_co_readv_em

Re: [Qemu-devel] [PATCH v14 11/14] qemu-img: Specify backing file for commit

2014-10-27 Thread Max Reitz
On 2014-10-24 at 18:23, Eric Blake wrote: On 10/24/2014 07:57 AM, Max Reitz wrote: Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by:

Re: [Qemu-devel] [PATCHv3 5/6] block: add qemu-iotest for write-merge parameter

2014-10-27 Thread Peter Lieven
On 27.10.2014 10:08, Max Reitz wrote: On 2014-10-25 at 18:55, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- tests/qemu-iotests/109 | 113 tests/qemu-iotests/109.out | 68 ++

Re: [Qemu-devel] [PATCH] Make qemu_shutdown_requested signal-safe

2014-10-27 Thread Jan Kiszka
On 2014-10-27 10:09, Paolo Bonzini wrote: On 10/26/2014 10:32 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com qemu_shutdown_requested may be interrupted by qemu_system_killed. If the latter sets shutdown_requested after qemu_shutdown_requested has read it but before it was

[Qemu-devel] [PATCHv6 2/6] BlockLimits: introduce max_transfer_length

2014-10-27 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Max Reitz mre...@redhat.com --- block.c |4 include/block/block_int.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/block.c b/block.c index 88f6d9b..76fcc1d 100644 --- a/block.c +++ b/block.c @@ -519,6

[Qemu-devel] [PATCHv6 4/6] block: avoid creating oversized writes in multiwrite_merge

2014-10-27 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Ronnie Sahlberg ronniesahlb...@gmail.com Reviewed-by: Max Reitz mre...@redhat.com --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 76fcc1d..4179341 100644 --- a/block.c +++ b/block.c @@ -4446,6

[Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Peter Lieven
Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. The helper function sector_limits_lun2qemu is introduced to convert and cap the limits from the VPD to the maximum power of two fitting in an integer; integer is the range for nb_sectors throughout the

[Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests

2014-10-27 Thread Peter Lieven
Cancel oversized requests early. They would generate an iSCSI protocol error anyway; after having transferred possibly a lot of data over the wire. Suggested-By: Max Reitz mre...@redhat.com Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 12 1 file changed, 12

[Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length

2014-10-27 Thread Peter Lieven
This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix. Splitting up requests according to the max_transfer_length will

[Qemu-devel] [PATCHv6 1/6] util: introduce MIN_NON_ZERO

2014-10-27 Thread Peter Lieven
at least in block layer we have the case of limits being defined for a BlockDriverState. However, in this context often zero (0) has the special meanining of undefined which means no limit. If two of those limits are combined and the minimum is needed the minimum function should only return zero

Re: [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length

2014-10-27 Thread Max Reitz
On 2014-10-27 at 10:18, Peter Lieven wrote: Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. The helper function sector_limits_lun2qemu is introduced to convert and cap the limits from the VPD to the maximum power of two fitting in an integer; integer

[Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits

2014-10-27 Thread Peter Lieven
As Max pointed out there is a hidden cast from int64_t to int for all limits. So use the newly introduced sector_limits_lun2qemu for all limits received from the target. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 20 ++-- 1 file changed, 10 insertions(+), 10

Re: [Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits

2014-10-27 Thread Max Reitz
On 2014-10-27 at 10:18, Peter Lieven wrote: As Max pointed out there is a hidden cast from int64_t to int for all limits. So use the newly introduced sector_limits_lun2qemu for all limits received from the target. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 20

Re: [Qemu-devel] [PATCH 1/6] ahci: Correct PIO/D2H FIS responses

2014-10-27 Thread Markus Armbruster
John Snow js...@redhat.com writes: Currently, the D2H FIS packets AHCI generates simply parrot back the LBA that the guest sent to us in the cmd_fis. However, some commands (like READ NATIVE MAX) modify the LBA registers as a return value, through which the AHCI D2H FIS is the only response

Re: [Qemu-devel] [PATCH 00/17] RFC: userfault v2

2014-10-27 Thread zhanghailiang
Hi Andrea, Thanks for your hard work on userfault;) This is really a useful API. I want to confirm a question: Can we support distinguishing between writing and reading memory for userfault? That is, we can decide whether writing a page, reading a page or both trigger userfault. I think this

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Peter Maydell
On 25 October 2014 09:24, john.liuli john.li...@huawei.com wrote: To get the interrupt reason to support such VIRTIO_NET_F_STATUS features I add a new register offset VIRTIO_MMIO_ISRMEM which will help to establish a shared memory region between qemu and virtio-mmio device. Then the interrupt

[Qemu-devel] [PATCH 9/9] parallels: change copyright information in the image header

2014-10-27 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev d...@openvz.org Acked-by: Roman Kagan rka...@parallels.com CC: Jeff Cody jc...@redhat.com CC: Kevin Wolf kw...@redhat.com CC: Stefan Hajnoczi stefa...@redhat.com --- block/parallels.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 8/9] iotests: padded parallels image test

2014-10-27 Thread Denis V. Lunev
Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. Padding is a value which should be added to guest LBA to obtain sector number inside the image. This results in a shifted images. 0123offset inside image (in 512

[Qemu-devel] How to run qemu-system-aarch64 without -kernel parameter?

2014-10-27 Thread Sudheesh PM
I amusing qemu-system-aarch64 (version 2.1.0) to run aarch64 on ARM64 machine using openstack.I am facing difficulty in passing kernel parameter. How to boot a virtual machine without passing -kernel option? I want to use only - drive file=rootfs.img for booting. please help. Regards,Sudheesh

Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-10-27 Thread zhanghailiang
Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) Thanks, zhanghailiang On 2014/10/23 8:32, zhanghailiang wrote: Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: On 2014/10/17 16:50,

Re: [Qemu-devel] [PATCH 5/6] ide: Correct handling of malformed/short PRDTs

2014-10-27 Thread Paolo Bonzini
On 10/02/2014 12:55 AM, John Snow wrote: +/* If this is true, you're leaking memory. */ ... or qsg is uninitialized, which would work because qemu_sglist_init initializes all fields. This is the only comment I have on the series. :) Paolo +assert(qsg-sg == NULL); + qsg-sg =

Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes

2014-10-27 Thread Paolo Bonzini
On 10/02/2014 12:55 AM, John Snow wrote: Based off of feedback from the RFC of the same name, this series batches together a group of fixes that improve the AHCI device to fix a number of bugs. A number of fixes included in the RFC that provide more radical changes are omitted for now in

[Qemu-devel] [PATCH v4 2/7] qemu-img: Add progress output for amend

2014-10-27 Thread Max Reitz
Now that bdrv_amend_options() supports a status callback, use it to display a progress report. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Benoît Canet benoit.ca...@nodalink.com --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 25

[Qemu-devel] [PATCH v4 3/7] qemu-img: Fix insignificant memleak

2014-10-27 Thread Max Reitz
As soon as options is set in img_amend(), it needs to be freed before the function returns. This leak is rather insignificant, as qemu-img will exit subsequently anyway, but there's no point in not fixing it. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com

[Qemu-devel] [PATCH v4 5/7] block/qcow2: Make get_refcount() global

2014-10-27 Thread Max Reitz
Reading the refcount of a cluster is an operation which can be useful in all of the qcow2 code, so make that function globally available. While touching this function, amend the comment describing the addend parameter: It is (no longer, if it ever was) necessary to have it set to -1 or 1; any

[Qemu-devel] [PATCH v4 6/7] block/qcow2: Simplify shared L2 handling in amend

2014-10-27 Thread Max Reitz
Currently, we have a bitmap for keeping track of which clusters have been created during the zero cluster expansion process. This was necessary because we need to properly increase the refcount for shared L2 tables. However, now we can simply take the L2 refcount and use it for the cluster

[Qemu-devel] [PATCH v4 7/7] iotests: Expand test 061

2014-10-27 Thread Max Reitz
Add some tests for progress output to 061. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Benoît Canet benoit.ca...@nodalink.com --- tests/qemu-iotests/061 | 25 + tests/qemu-iotests/061.out | 30

[Qemu-devel] [PATCH v4 4/7] block/qcow2: Implement status CB for amend

2014-10-27 Thread Max Reitz
The only really time-consuming operation potentially performed by qcow2_amend_options() is zero cluster expansion when downgrading qcow2 images from compat=1.1 to compat=0.10, so report status of that operation and that operation only through the status CB. For this, approximate the progress as

[Qemu-devel] [PATCH] uhci: remove useless DEBUG

2014-10-27 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com commit 50dcc0f8 (uhci: tracing support) had removed DPRINTF, the DEBUG marco is useless now, remove it. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-uhci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/usb/hcd-uhci.c

[Qemu-devel] [PATCH] block/vdi: Limit maximum size even futher

2014-10-27 Thread Max Reitz
The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size is therefore limited accordingly. This reduces the maximum VDI image size supported by QEMU to half of what it currently is

Re: [Qemu-devel] [RFC PATCH 2/2] Assign a new irq handler while irqfd enabled

2014-10-27 Thread Li Liu
On 2014/10/26 19:56, Michael S. Tsirkin wrote: On Sat, Oct 25, 2014 at 04:24:54PM +0800, john.liuli wrote: From: Li Liu john.li...@huawei.com This irq handler will get the interrupt reason from a shared memory. And will be assigned only while irqfd enabled. Signed-off-by: Li Liu

Re: [Qemu-devel] [PATCH] block/vdi: Limit maximum size even futher

2014-10-27 Thread Peter Lieven
On 27.10.2014 11:56, Max Reitz wrote: The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size is therefore limited accordingly. This reduces the maximum VDI image size supported by

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Li Liu
On 2014/10/27 17:37, Peter Maydell wrote: On 25 October 2014 09:24, john.liuli john.li...@huawei.com wrote: To get the interrupt reason to support such VIRTIO_NET_F_STATUS features I add a new register offset VIRTIO_MMIO_ISRMEM which will help to establish a shared memory region between qemu

Re: [Qemu-devel] [PATCH] block/vdi: Limit maximum size even futher

2014-10-27 Thread Max Reitz
On 2014-10-27 at 12:10, Peter Lieven wrote: On 27.10.2014 11:56, Max Reitz wrote: The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size is therefore limited accordingly. This

Re: [Qemu-devel] [PATCH] block/vdi: Limit maximum size even futher

2014-10-27 Thread Max Reitz
On 2014-10-27 at 12:39, Max Reitz wrote: On 2014-10-27 at 12:10, Peter Lieven wrote: On 27.10.2014 11:56, Max Reitz wrote: The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size

[Qemu-devel] [PATCH] vnc: sanitize bits_per_pixel from the client

2014-10-27 Thread Petr Matousek
bits_per_pixel that are less than 8 could result in accessing non-initialized buffers later in the code due to the expectation that bytes_per_pixel value that is used to initialize these buffers is never zero. To fix this check that bits_per_pixel from the client is one of the values that the rfb

Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-27 Thread Peter Maydell
On 26 October 2014 22:30, Peter Maydell peter.mayd...@linaro.org wrote: In fact, since all of the exception is not taken cases are for we are in secure EL3 and the exception is not being routed to secure EL3 you could just make all those entries read 1 and rely on the target_el current_el

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Peter Maydell
On 27 October 2014 11:23, Li Liu john.li...@huawei.com wrote: So you mean virtio-mmio will be replaced by PCI/PCIe on ARM at last? That is the plan, yes. I can't make any promises on timescales at the moment, though... -- PMM

Re: [Qemu-devel] [PATCH] vnc: sanitize bits_per_pixel from the client

2014-10-27 Thread Gerd Hoffmann
On Mo, 2014-10-27 at 12:41 +0100, Petr Matousek wrote: bits_per_pixel that are less than 8 could result in accessing non-initialized buffers later in the code due to the expectation that bytes_per_pixel value that is used to initialize these buffers is never zero. To fix this check that

Re: [Qemu-devel] [RFC PATCH 2/2] Assign a new irq handler while irqfd enabled

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 07:04:11PM +0800, Li Liu wrote: On 2014/10/26 19:56, Michael S. Tsirkin wrote: On Sat, Oct 25, 2014 at 04:24:54PM +0800, john.liuli wrote: From: Li Liu john.li...@huawei.com This irq handler will get the interrupt reason from a shared memory. And will be

[Qemu-devel] How to add emulated hardware module to QEMU

2014-10-27 Thread 梁凯源
Hello all, I am a student of Tianjin University, researching emulation of hardware module in QEMU. Could you give me some suggestions? In my project, I need to add a virtual hardware to qemu. By code reviewing, I seemly get the point that devices and peripherals under dir hw/*/* register

[Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

2014-10-27 Thread Max Reitz
Currently, when trying to create a backed image without specifying its size, when the backing file does not exist or is not accessible, an appropriate error message will be generated which is then (in bdrv_img_create()) prefixed with the image file name and the strerror(). However, both are

[Qemu-devel] [PATCH 2/2] iotests: Add test for non-existing backing file

2014-10-27 Thread Max Reitz
Test the error message when a COW file is about to be created which is supposed to inherit the size of its backing file, while the backing file given does not actually exist. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/111 | 53

[Qemu-devel] [PATCH 1/2] block: Propagate error in bdrv_img_create()

2014-10-27 Thread Max Reitz
If the specified backing file could not be opened, do not generate a new error message which contains the message which has been generated by bdrv_open(), but just propagate the latter. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [Qemu-devel] Postcopy failures

2014-10-27 Thread Dr. David Alan Gilbert
* Gary Hook (gary.h...@nimboxx.com) wrote: I see this went by: Il 07/10/2014 12:29, Dr. David Alan Gilbert ha scritto: You mean something like this (untested) ? if (mis-postcopy_ram_state != POSTCOPY_RAM_INCOMING_NONE) { if (mis-postcopy_ram_state ==

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Amit Shah
Hi, On (Fri) 24 Oct 2014 [11:00:54], Marc-André Lureau wrote: The spice server is polling on write, unless SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must call spice_server_char_device_wakeup() when the frontend is writable. Great, so there's no other change required to

Re: [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

2014-10-27 Thread Peter Lieven
On 27.10.2014 13:30, Max Reitz wrote: Currently, when trying to create a backed image without specifying its size, when the backing file does not exist or is not accessible, an appropriate error message will be generated which is then (in bdrv_img_create()) prefixed with the image file name and

Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-10-27 Thread Luiz Capitulino
On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang zhang.zhanghaili...@huawei.com wrote: Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options,

Re: [Qemu-devel] A Patch to enable qemu-nbd run as an inetd service

2014-10-27 Thread Jun Sheng
Hi, Since errx is used everywhere in qemu-nbd.c, I suggest that I follow this convention in submitting my patch. On Thu, Oct 23, 2014 at 4:48 AM, Eric Blake ebl...@redhat.com wrote: On 10/22/2014 12:54 PM, Jun Sheng wrote: From: Chaos Eternal ch...@shlug.org run qemu-nbd as an inetd service

[Qemu-devel] [PATCH 1/2] target-arm: Separate out M profile cpu_exec_interrupt handling

2014-10-27 Thread Peter Maydell
The M profile cpu_exec_interrupt handling is fairly simple but does include an M profile specific oddity (disabling interrupts for certain PC values). A/R profile handling on the other hand is getting rapidly more complicated with the support for EL2 and EL3. Split the M profile code out into its

[Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
Combining rombar=0 with romfile=path is an user error, silently dropping the romfile is a reasonable thing to do. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- v1 - v2: After a discussion with Michael, Paolo and Alex, this patch silent drops the romfile instead of not allowing the

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 15:44 +0200, Marcel Apfelbaum wrote: Combining rombar=0 with romfile=path is an user error, silently dropping the romfile is a reasonable thing to do. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- v1 - v2: After a discussion with Michael, Paolo and Alex,

Re: [Qemu-devel] [PATCH] aio / timers: De-document -clock

2014-10-27 Thread Markus Armbruster
Ping? Markus Armbruster arm...@redhat.com writes: Commit 6d32717 aio / timers: Remove alarm timers has issues: 1. It silently ignores -clock for backward compatibility. Incompatible change: -clock help no longer terminates the program. Tolerable. 2. Failed to update option documentation.

Re: [Qemu-devel] [PATCH] Revert main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously

2014-10-27 Thread Peter Maydell
On 26 October 2014 09:32, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks debuggability of qemu. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Feel free to apply this before or after

Re: [Qemu-devel] [PATCH] Revert main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 03:18 PM, Peter Maydell wrote: On 26 October 2014 09:32, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks debuggability of qemu. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH] aio / timers: De-document -clock

2014-10-27 Thread Paolo Bonzini
On 10/06/2014 04:19 PM, Markus Armbruster wrote: Commit 6d32717 aio / timers: Remove alarm timers has issues: 1. It silently ignores -clock for backward compatibility. Incompatible change: -clock help no longer terminates the program. Tolerable. 2. Failed to update option documentation.

Re: [Qemu-devel] is it possible to use a disk with multiple iothreads ?

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 03:13 PM, Alexandre DERUMIER wrote: That's very interesting! Please keep Josh and me in CC when you want to discuss the results. Here the aggregate results (perf report details attached in this mail) + 33,02%3974368751 kvm [kernel.kallsyms]

[Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2014-10-27 Thread Iggy
You might try connecting the device to a ehci/xhci bus (instead of the default uhci bus... i.e. USB 1.1). See docs/usb2.txt in the qemu source for more info. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 03:44:04PM +0200, Marcel Apfelbaum wrote: Combining rombar=0 with romfile=path is an user error, silently dropping the romfile is a reasonable thing to do. Signed-off-by: Marcel Apfelbaum marce...@redhat.com How about failing adding the device instead? Return error

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 16:52 +0200, Michael S. Tsirkin wrote: On Mon, Oct 27, 2014 at 03:44:04PM +0200, Marcel Apfelbaum wrote: Combining rombar=0 with romfile=path is an user error, silently dropping the romfile is a reasonable thing to do. Signed-off-by: Marcel Apfelbaum

Re: [Qemu-devel] [PATCH] Revert main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously

2014-10-27 Thread Peter Maydell
On 27 October 2014 14:39, Paolo Bonzini pbonz...@redhat.com wrote: On 10/27/2014 03:18 PM, Peter Maydell wrote: On 26 October 2014 09:32, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks

[Qemu-devel] [PATCH] tcg/mips: fix store softmmu slow path

2014-10-27 Thread Aurelien Jarno
Commit 9d8bf2d1 moved the softmmu slow path out of line and introduce a regression at the same time by always calling tcg_out_tlb_load with is_load=1. This makes impossible to run any significant code under qemu-system-mips*. Cc: Paolo Bonzini pbonz...@redhat.com Cc: Richard Henderson

[Qemu-devel] [PULL 02/28] virtio-scsi: dataplane: print why starting failed

2014-10-27 Thread Paolo Bonzini
From: Cornelia Huck cornelia.h...@de.ibm.com Setting up guest or host notifiers may fail, but the user will have no idea why: Let's print the error returned by the callback. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PULL 06/28] qom: Demote already-has-a-parent to a regular error

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Rather than an abort(). This allows callers to decide whether parenting an already-parented object is a fatal error condition. Useful for providing a default value for an object's parent in the case where you want to set one iff it doesn't

[Qemu-devel] [PULL 00/28] Changes for 2014-10-27

2014-10-27 Thread Paolo Bonzini
The following changes since commit e40830afa1cff3ffdc37bdfdd40d80860074636c: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2014-10-22-tag' into staging (2014-10-22 21:42:33 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for

[Qemu-devel] [PULL 07/28] qdev: gpio: Re-implement qdev_connect_gpio QOM style

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Re-implement as a link setter. This should allow the QOM framework to keep track of ref counts properly etc. We need to add a default parent for the connecting input incase it's coming from a non-qdev source. We simply parent the IRQ to the

[Qemu-devel] [PULL 09/28] qtest/irq: Rework IRQ interception

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Change the qtest intercept handler to accept just the individual IRQ being intercepted as opaque. n is still expected to be correctly set as for the original intercepted irq. qemu_intercept_irq_in is updated accordingly. Then covert the

[Qemu-devel] [PULL 03/28] virtio-scsi: dataplane: fail setup gracefully

2014-10-27 Thread Paolo Bonzini
From: Cornelia Huck cornelia.h...@de.ibm.com The dataplane code is currently doing a hard exit on various setup failures. In practice, this may mean that a guest suddenly dies after a dataplane device failed to come up (e.g., when a file descriptor limit is hit for the nth device). Let's just

[Qemu-devel] [PULL 05/28] qom: Allow clearing of a Link property

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com By passing in to object_property_set_link. The lead user of this is the QDEV GPIO framework which will implement GPIO disconnects via an unlink. GPIO disconnection is used by qtest's irq_intercept_out command. Reviewed-by: Alexander Graf

[Qemu-devel] [PULL 04/28] virtio-scsi: dataplane: stop trying on notifier error

2014-10-27 Thread Paolo Bonzini
From: Cornelia Huck cornelia.h...@de.ibm.com There's no use to constantly trying to enable dataplane if we failed to set up guest or host notifiers, so fence it off in that case. We'll try again if the device is reinitialized. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by:

  1   2   >