Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace

2014-11-24 Thread Amos Kong
On Tue, Nov 25, 2014 at 08:18:54AM +0100, Gerd Hoffmann wrote: > Ongoing discussions on how we are going to specify the console, > so tag the command as experiemntal so we can refine things in > the 2.3 development cycle. %s/experiemntal/experimental/ Reviewed-by: Amos Kong > Signed-off-by: Ge

Re: [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check"

2014-11-24 Thread Markus Armbruster
Markus Armbruster writes: > Fam Zheng writes: > >> qemu-iotests contains useful tests that have a nice coverage of block layer >> code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make >> check" is good for developers' self-testing. >> >> With the first patch, this set takes

[Qemu-devel] [PATCH v6 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case

2014-11-24 Thread Ming Lei
Previously -EAGAIN is simply ignored for !s->io_q.plugged case, and sometimes it is easy to cause -EIO to VM, such as NVME device. This patch handles -EAGAIN by io queue for !s->io_q.plugged case, and it will be retried in following aio completion cb. Reviewed-by: Paolo Bonzini Suggested-by: Pao

[Qemu-devel] [PATCH v6 0/3] linux-aio: fix batch submission

2014-11-24 Thread Ming Lei
The 1st patch fixes batch submission. The 2nd one fixes -EAGAIN for non-batch case. The 3rd one is a cleanup. This patchset is splitted from previous patchset(dataplane: optimization and multi virtqueue support), as suggested by Stefan. V6: - don't pass ioq_submit() return value to ioq_

[Qemu-devel] [PATCH v6 1/3] linux-aio: fix submit aio as a batch

2014-11-24 Thread Ming Lei
In the submit path, we can't complete request directly, otherwise "Co-routine re-entered recursively" may be caused, so this patch fixes the issue with below ideas: - for -EAGAIN or partial completion, retry the submision in following completion cb which is run in BH context

[Qemu-devel] [PATCH v6 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb'

2014-11-24 Thread Ming Lei
No one uses the 'node' field any more, so remove it from 'struct qemu_laiocb', and this can save 16byte for the struct on 64bit arch. Reviewed-by: Paolo Bonzini Signed-off-by: Ming Lei --- block/linux-aio.c |1 - 1 file changed, 1 deletion(-) diff --git a/block/linux-aio.c b/block/linux-ai

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block

2014-11-24 Thread Markus Armbruster
Fam Zheng writes: > Using /tmp (usually mounted as tmpfs) and cache=writeback, the quick > group can be quicker. > > On my laptop (Lenovo T430s with Fedora 20), this reduces the time from > 50s to 30s. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests-quick.sh | 2 +- > 1 file changed, 1

[Qemu-devel] [PATCH] input: move input-send-event into experimental namespace

2014-11-24 Thread Gerd Hoffmann
Ongoing discussions on how we are going to specify the console, so tag the command as experiemntal so we can refine things in the 2.3 development cycle. Signed-off-by: Gerd Hoffmann --- qmp-commands.hx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qmp-commands.

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Jason Wang
On 11/25/2014 02:44 AM, Stefano Stabellini wrote: > On Mon, 24 Nov 2014, Stefano Stabellini wrote: >> On Mon, 24 Nov 2014, Stefano Stabellini wrote: >>> CC'ing Paolo. >>> >>> >>> Wen, >>> thanks for the logs. >>> >>> I investigated a little bit and it seems to me that the bug occurs when >>> QEMU t

[Qemu-devel] [PATCH for-2.2] fw_cfg: fix boot order bug when dynamically modified via QOM

2014-11-24 Thread arei.gonglei
From: Gonglei When we dynamically modify boot order, the length of boot order will be changed, but we don't update s->files->f[i].size with new length. This casuse seabios read a wrong vale of qemu cfg file about bootorder. Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Gonglei --- hw/nv

[Qemu-devel] [Bug 1395958] Re: boost managed_shared_memory segment on arm emulator crashes

2014-11-24 Thread Ratin
remote GDB (via local host ) QEMU: Terminated via GDBstub root@ratin-dev:/usr/local/bin# qemu-arm-static -g 1234 /usr/local/bin/test terminate called after throwing an instance of 'boost::interprocess::interprocess_exception' what(): Function not implemented (gdb) 14 bi::managed_sha

[Qemu-devel] [Bug 1395958] Re: boost managed_shared_memory segment on arm emulator crashes

2014-11-24 Thread Ratin
uname -a Linux ratin-dev 2.6.32 #25~precise1-Ubuntu SMP Thu Jan 30 17:39:31 UTC 2014 armv7l armv7l armv7l GNU/Linux -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1395958 Title: boost managed_share

[Qemu-devel] [Bug 1395958] [NEW] boost managed_shared_memory segment on arm emulator crashes

2014-11-24 Thread Ratin
Public bug reported: The following code segment crashes when run: #include #include #include #include #include using namespace boost::interprocess; int main(int argc, char** argv) { namespace bi = boost::interprocess; const char* name = "foobar"; bi::shared_memory_object::remov

Re: [Qemu-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Wen Congyang
On 11/25/2014 02:44 AM, Stefano Stabellini wrote: > On Mon, 24 Nov 2014, Stefano Stabellini wrote: >> On Mon, 24 Nov 2014, Stefano Stabellini wrote: >>> CC'ing Paolo. >>> >>> >>> Wen, >>> thanks for the logs. >>> >>> I investigated a little bit and it seems to me that the bug occurs when >>> QEMU t

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-24 Thread Don Slutz
On 11/21/14 05:49, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Don Slutz writes: On 11/19/14 07:29, Markus Armbruster wrote: Don Slutz writes: The other callers to blk_set_enable_write_cache() in this file already check for s->blk == NULL. Signed-off-by:

[Qemu-devel] KVM call for agenda for 2014-11-24

2014-11-24 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every two weeks By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY

[Qemu-devel] [PULL v2 07/15] pc: pc-dimm: use backend alignment during address auto allocation

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/mem/pc-dimm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 4944f0f..d431834 100644 --- a/hw/mem/pc-dim

[Qemu-devel] [PULL v2 10/15] hw/pci: fix crash on shpc error flow

2014-11-24 Thread Michael S. Tsirkin
From: Marcel Apfelbaum If the pci bridge enters in error flow as part of init process it will only delete the shpc mmio subregion but not remove it from the properties list, resulting in segmentation fault when the bridge runs the exit function. Example: add a pci bridge without specifing the ch

[Qemu-devel] [PULL v2 09/15] pc: count in 1Gb hugepage alignment when sizing hotplug-memory container

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov if DIMMs with different size/alignment are interleaved in creation order, it could lead to hotplug-memory container fragmentation and following inability to use all RAM upto maxmem. For example: -m 4G,slots=3,maxmem=7G -object memory-backend-file,id=mem-1,size=256M,mem

[Qemu-devel] [PULL v2 13/15] pcie: fix typo in pcie_cap_deverr_init()

2014-11-24 Thread Michael S. Tsirkin
From: Gonglei Reported-by: https://bugs.launchpad.net/qemu/+bug/1393440 Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd.

[Qemu-devel] [PULL v2 15/15] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov If QEMU is started with -numa ... Windows only notices that CPU has been hot-added but it will not online such CPUs. It's caused by the fact that possible CPUs are flagged as not enabled in SRAT and Windows honoring that information doesn't use corresponding CPU. ACPI 5.0 S

[Qemu-devel] [PULL v2 04/15] pc: limit DIMM address and size to page aligned values

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov When running in KVM mode, kvm_set_phys_mem() will silently fail if registered MemoryRegion address/size is not page aligned. Causing memory hotplug failure in guest. Mapping non aligned MemoryRegion in TCG mode 'works', but sane guest OS still expects page aligned memory modu

[Qemu-devel] [PULL v2 12/15] target-i386: move generic memory hotplug methods to DSDTs

2014-11-24 Thread Michael S. Tsirkin
From: Paolo Bonzini This makes it simpler to keep the SSDT byte-for-byte identical for a given machine type, which is a goal we want to have for 2.2 and newer types. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-dsdt-mem-hotpl

[Qemu-devel] [PULL v2 08/15] pc: explicitly check maxmem limit when adding DIMM

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov Currently maxmem limit is not checked and depends on hotplug region container not being able to fit more RAM than maxmem. Do check explicitly so that it would be possible to change hotplug container size later to deal with fragmentation. Signed-off-by: Igor Mammedov Reviewed

[Qemu-devel] [PULL v2 03/15] pc: make pc_dimm_plug() more readble

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov split addr initialization from declaration so that later when new local vars are added property getter wouldn't drift off of error check. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 5 +++-- 1 file chan

[Qemu-devel] [PULL v2 11/15] acpi-build: mark RAM dirty on table update

2014-11-24 Thread Michael S. Tsirkin
acpi build modifies internal FW CFG RAM on first access but we forgot to mark it dirty. If this RAM has been migrated already, it won't be migrated again, returning corrupted tables to guest. Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 2 +- hw/core/loader.c | 8 +---

[Qemu-devel] [PULL v2 06/15] pc: align DIMM's address/size by backend's alignment value

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov Performance wise it's better to align GVA by the backend's page size. Also do not allow to create DIMM device with suboptimal size (i.e. not aligned to backends page size) to aviod memory loss. Do above only for 2.2 and newer machine types to avoid breaking working configs w

[Qemu-devel] [PULL v2 14/15] pcie: fix improper use of negative value

2014-11-24 Thread Michael S. Tsirkin
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index fbba589..1a1 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -

[Qemu-devel] [PULL v2 05/15] memory: expose alignment used for allocating RAM as MemoryRegion API

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov introduce memory_region_get_alignment() that returns underlying memory block alignment or 0 if it's not relevant/implemented for backend. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/exec/exec-all.h | 2 +- inc

[Qemu-devel] [PULL v2 01/15] qemu-char: fix tcp_get_fds

2014-11-24 Thread Michael S. Tsirkin
tcp_get_fds API discards fds if there's more than 1 of these. It's tricky to fix this without API changes in the generic case. However, this API is only used by tests ATM, and tests know how many fds they expect. So let's not waste cycles trying to fix this properly: simply assume at most 16 fds

[Qemu-devel] [PULL v2 02/15] pc: kvm: check if KVM has free memory slots to avoid abort()

2014-11-24 Thread Michael S. Tsirkin
From: Igor Mammedov When more memory devices are used than available KVM memory slots, QEMU crashes with: kvm_alloc_slot: no free slot available Aborted (core dumped) Fix this by checking that KVM has a free slot before attempting to map memory in guest address space. Signed-off-by: Igor Mamme

[Qemu-devel] [PULL v2 00/15] pc, pci, misc bugfixes

2014-11-24 Thread Michael S. Tsirkin
The following changes since commit 0e88f478508b566152c6681f4889ed9830a2c0a5: Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging (2014-11-21 14:15:37 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_ups

[Qemu-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > CC'ing Paolo. > > > > > > Wen, > > thanks for the logs. > > > > I investigated a little bit and it seems to me that the bug occurs when > > QEMU tries to unmap only a portion of a memory region pr

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 24, 2014 at 06:44:45PM +, Stefano Stabellini wrote: > > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > > > CC'ing Paolo. > > > > > > > > > > > > Wen, > > > > thanks for the

Re: [Qemu-devel] [PATCH v5 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case

2014-11-24 Thread Stefan Hajnoczi
On Mon, Nov 24, 2014 at 10:29:38PM +0800, Ming Lei wrote: > Previously -EAGAIN is simply ignored for !s->io_q.plugged case, > and sometimes it is easy to cause -EIO to VM, such as NVME device. > > This patch handles -EAGAIN by io queue for !s->io_q.plugged case, > and it will be retried in followi

Re: [Qemu-devel] [PATCH v4 33/47] Postcopy: Postcopy startup in migration thread

2014-11-24 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > From: "Dr. David Alan Gilbert" > > > > Rework the migration thread to setup and start postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > include/migration/migration

Re: [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch

2014-11-24 Thread Stefan Hajnoczi
On Mon, Nov 24, 2014 at 10:29:37PM +0800, Ming Lei wrote: > +static void ioq_abort_bh(void *opaque) > +{ > +struct qemu_laio_state *s = opaque; > +int i; > + > +for (i = 0; i < s->io_q.idx; i++) { > +struct qemu_laiocb *laiocb = container_of(s->io_q.iocbs[i], > +

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Konrad Rzeszutek Wilk
On Mon, Nov 24, 2014 at 06:44:45PM +, Stefano Stabellini wrote: > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > > CC'ing Paolo. > > > > > > > > > Wen, > > > thanks for the logs. > > > > > > I investigated a little bit and it seems to me

Re: [Qemu-devel] [PATCH v5 2/3] qcow2: add update refcount table realization for update_refcount

2014-11-24 Thread Eric Blake
On 11/21/2014 05:41 AM, Max Reitz wrote: > On 2014-10-26 at 16:20, Jun Li wrote: >> When every item of refcount block is NULL, free refcount block and >> reset the >> corresponding item of refcount table with NULL. At the same time, put >> this >> cluster to s->free_cluster_index. >> >> Signed-off-

Re: [Qemu-devel] [PATCH v5 1/3] qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking

2014-11-24 Thread Eric Blake
On 11/21/2014 03:56 AM, Max Reitz wrote: > > Second, why are you truncating the file to offset if offset is smaller > than actual_size? That is always wrong. You are blindly assuming: > (1) that the image consists of only data and no metadata, because you're > using the guest disk size (offset) to

Re: [Qemu-devel] [PATCH v2 00/12] qcow2: Add new overlap check functions

2014-11-24 Thread Max Reitz
On 2014-11-24 at 16:56, Max Reitz wrote: tl;dr = * CPU usage at runtime decreased by 150 to 275 percent on overlap-check-heavy tasks Oops, that should read "15000 to 27500 percent" or "150 to 275 times". Max * No additional performance problems at loading time (in theory has the

Re: [Qemu-devel] [Xen-devel] qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: > CC'ing Paolo. > > > Wen, > thanks for the logs. > > I investigated a little bit and it seems to me that the bug occurs when > QEMU tries to unmap only a portion of a memory region previously mapped. > That doesn't work with xen-mapcache. > > See

Re: [Qemu-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2014-11-24 Thread Eric Blake
On 11/24/2014 10:19 AM, Eric Blake wrote: > On 11/23/2014 09:10 PM, Quan Xu wrote: >> Signed-off-by: Quan Xu >> --- >> configure| 14 ++ >> hmp.c| 7 +++ >> qapi-schema.json | 20 ++-- >> qemu-options.hx | 13 +++-- >> tpm.c

Re: [Qemu-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2014-11-24 Thread Eric Blake
On 11/23/2014 09:10 PM, Quan Xu wrote: > Signed-off-by: Quan Xu > --- > configure| 14 ++ > hmp.c| 7 +++ > qapi-schema.json | 20 ++-- > qemu-options.hx | 13 +++-- > tpm.c| 7 ++- > 5 files changed, 56 insertions(+),

Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads

2014-11-24 Thread Eric Blake
On 11/23/2014 07:25 PM, Li, Liang Z wrote: >>> # @auto-converge: If enabled, QEMU will automatically throttle down the >>> guest >>> # to speed up convergence of RAM migration. (since 1.6) >>> # >>> # Since: 1.2 >>> ## >>> { 'enum': 'MigrationCapability', >>> - 'data': ['xbzrle', '

Re: [Qemu-devel] [PULL] Block patches for 2.2.0-rc3

2014-11-24 Thread Peter Maydell
On 24 November 2014 at 14:01, Kevin Wolf wrote: > The following changes since commit 0e88f478508b566152c6681f4889ed9830a2c0a5: > > Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into > staging (2014-11-21 14:15:37 +) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH v2 00/12] qcow2: Add new overlap check functions

2014-11-24 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > As has been requested, this series adds new overlap check functions to > the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", > but I am not so sure whether it is actually an improvement; that is left > for you to decide, dear reviewers.

Re: [Qemu-devel] [PATCH] input: improve docs for input-send-event qmp command

2014-11-24 Thread Eric Blake
On 11/24/2014 08:51 AM, Markus Armbruster wrote: > Uh, you dropped cc: Eric somehow a couple of messages ago. At least I have my inbox set to flag messages where my name is mentioned, even when I'm not actually cc'd, so I did see the thread before this email :) >> Supporting device (additionally

Re: [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch

2014-11-24 Thread Stefan Hajnoczi
On Mon, Nov 24, 2014 at 10:29:37PM +0800, Ming Lei wrote: > +/* submit immediately if queue depth is above 2/3 */ > +if (idx > s->io_q.size * 2 / 3) { > +return ioq_submit(s); The return value of ioq_submit() is the number of requests submitted (0 or more). This has no meaning to

Re: [Qemu-devel] [v2 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: > On Sun, 23 Nov 2014, Quan Xu wrote: > > +static void vtpm_backend_changed(struct XenDevice *xendev, const char > > *node) > > +{ > > +struct XenVtpmDev *vtpmdev = container_of(xendev, struct XenVtpmDev, > > +

Re: [Qemu-devel] [v2 3/4] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms driver.

2014-11-24 Thread Stefano Stabellini
On Sun, 23 Nov 2014, Quan Xu wrote: > This driver provides vTPM initialization and sending data and TPM > commends to a Xen stubdom vTPM domain. > > Signed-off-by: Quan Xu We need a better, more detailed, patch description here. > hw/tpm/Makefile.objs | 1 + > hw/tpm/tpm_xenstubdoms.c |

Re: [Qemu-devel] [v2 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-24 Thread Stefano Stabellini
On Sun, 23 Nov 2014, Quan Xu wrote: > This drvier transfers any request/repond between TPM xenstubdoms > driver and Xen vTPM stubdom, and facilitates communications between > Xen vTPM stubdom domain and vTPM xenstubdoms driver > > Signed-off-by: Quan Xu This patch needs a better description, see

[Qemu-devel] Announcing QEMU Advent Calendar 2014

2014-11-24 Thread Stefan Hajnoczi
The QEMU Advent Calendar is launching on December 1st 2014: http://www.qemu-advent-calendar.org/ Each day until Christmas (or until we run out) a new QEMU disk image will be posted for you to enjoy. The disk images showcase interesting guest operating systems, demos, and software that runs under

Re: [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT

2014-11-24 Thread Max Reitz
On 2014-11-21 at 11:49, Stefan Hajnoczi wrote: The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never used! Let's fix that so external snapshot can be blocked. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 4 1 file changed, 4 insertions(+) With commit message and titl

[Qemu-devel] [PATCH v2 11/12] qcow2/overlaps: Protect inactive L2 tables

2014-11-24 Thread Max Reitz
Keep track of the inactive L2 tables in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 20 block/qcow2-snapshot.c | 41 +++-- 2 files changed, 59 insertions(+), 2 d

[Qemu-devel] [PATCH v2 06/12] qcow2/overlaps: Protect refcount blocks

2014-11-24 Thread Max Reitz
Keep track of the refcount blocks in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/qcow2-refcount.c b/block/q

[Qemu-devel] [PATCH v2 12/12] qcow2: Use new metadata overlap check function

2014-11-24 Thread Max Reitz
Make the static new overlap check function global and drop the old function. Signed-off-by: Max Reitz --- block/qcow2-overlap.c | 8 +--- block/qcow2-refcount.c | 120 - 2 files changed, 2 insertions(+), 126 deletions(-) diff --git a/block/qcow

[Qemu-devel] [PATCH v2 09/12] qcow2/overlaps: Protect snapshot table

2014-11-24 Thread Max Reitz
Keep track of the snapshot table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-snapshot.c | 10 ++ block/qcow2.c | 6 ++ 2 files changed, 16 insertions(+) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snap

[Qemu-devel] [PATCH v2 08/12] qcow2/overlaps: Protect active L2 tables

2014-11-24 Thread Max Reitz
Keep track of the active L2 tables in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 2 ++ block/qcow2-refcount.c | 6 ++ block/qcow2-snapshot.c | 21 + block/qcow2.c | 8 +++- 4 fi

[Qemu-devel] [PATCH v2 05/12] qcow2/overlaps: Protect refcount table

2014-11-24 Thread Max Reitz
Keep track of the refcount table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 18 ++ block/qcow2.c | 4 2 files changed, 22 insertions(+) diff --git a/block/qcow2-refcount.c b/block/qcow

[Qemu-devel] [PATCH v2 07/12] qcow2/overlaps: Protect active L1 table

2014-11-24 Thread Max Reitz
Keep track of the active L1 table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 11 +++ block/qcow2-snapshot.c | 10 ++ block/qcow2.c | 4 3 files changed, 25 insertions(+) diff --git a/b

[Qemu-devel] [PATCH v2 10/12] qcow2/overlaps: Protect inactive L1 tables

2014-11-24 Thread Max Reitz
Keep track of the inactive L1 tables in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-snapshot.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index c32

[Qemu-devel] [PATCH v2 04/12] qcow2/overlaps: Protect image header

2014-11-24 Thread Max Reitz
Enter the image header into the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index f80f9ed..19ac2df 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -7

[Qemu-devel] [PATCH v2 02/12] qcow2: Pull up overlap check option evaluation

2014-11-24 Thread Max Reitz
Pull up the absorption of the qcow2-relevant command line options and the evaluation of the overlap check options in qcow2_open(). Signed-off-by: Max Reitz --- block/qcow2.c | 96 +-- 1 file changed, 48 insertions(+), 48 deletions(-) diff

[Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2014-11-24 Thread Max Reitz
The existing qcow2 metadata overlap detection function used existing structures to determine the location of the image metadata, from plain fields such as l1_table_offset and l1_size in the BDRVQcowState, over image structures in memory such as the L1 table for the L2 tables' positions, or it even

[Qemu-devel] [PATCH v2 00/12] qcow2: Add new overlap check functions

2014-11-24 Thread Max Reitz
As has been requested, this series adds new overlap check functions to the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", but I am not so sure whether it is actually an improvement; that is left for you to decide, dear reviewers. See patch 1 for an explanation of why this serie

[Qemu-devel] [PATCH v2 03/12] qcow2: Create metadata list

2014-11-24 Thread Max Reitz
Create and destroy the metadata list on creation and destruction of a qcow2 BDS, respectively. Skip creation if no overlap checks should be performed. Signed-off-by: Max Reitz --- block/qcow2.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index ed

Re: [Qemu-devel] [PATCH] input: improve docs for input-send-event qmp command

2014-11-24 Thread Markus Armbruster
Uh, you dropped cc: Eric somehow a couple of messages ago. Gerd Hoffmann writes: > Hi, > >> >> > # @console: #optional console to send event(s) to. >> >> > +# This parameter can be used to send the input event to >> >> > +# specific input devices in case (a) multiple input

Re: [Qemu-devel] [RFC v2 0/4] Add Generic PCI host device update

2014-11-24 Thread Claudio Fontana
Another general question about this series use: why do all these other devices that are unrelated to the virt platform show up? Here I am running on the guest with just virtio-net, virtio-blk and virtio-rng: (qemu) info pci Bus 0, device 0, function 0: Class 2880: PCI device 1b36:1234

Re: [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Vasiliy Tolstov
2014-11-24 17:18 GMT+03:00 Andrey Korolyov : > I am not sure for friendliness of possible dd interpretations for new > leaky bucket mechanism, as its results can be a little confusing even > for fio (all operations which are above the limit for long-running > test will have 250ms latency, putting d

Re: [Qemu-devel] [PATCH for-2.2] qmp: document input-send-event detail

2014-11-24 Thread Markus Armbruster
Amos Kong writes: > This patch documents what exactly input-send-event is supposed to do. > > Signed-off-by: Amos Kong > --- > qapi-schema.json | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index d0926d9..9aa19bc 100644 > --- a/qapi-

Re: [Qemu-devel] qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
CC'ing Paolo. Wen, thanks for the logs. I investigated a little bit and it seems to me that the bug occurs when QEMU tries to unmap only a portion of a memory region previously mapped. That doesn't work with xen-mapcache. See these logs for example: DEBUG address_space_map phys_addr=78ed8b44 v

Re: [Qemu-devel] [PATCH v4 0/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-24 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 19:34 +0200, Marcel Apfelbaum wrote: > Hot-plugging a device that has a romfile (either supplied by user > or built-in) using rombar=0 option is a user error, > do not allow the device to be hot-plugged. Hi Michael, The series has been reviewed, can you please add it to your

Re: [Qemu-devel] [PULL for-2.2 0/3] APIC fixes for 2014-11-24

2014-11-24 Thread Peter Maydell
On 24 November 2014 at 13:40, Paolo Bonzini wrote: > The following changes since commit 0e88f478508b566152c6681f4889ed9830a2c0a5: > > Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into > staging (2014-11-21 14:15:37 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [RFC v2 3/4] hw/pci-host: Add a generic PCI host controller for virtual platforms

2014-11-24 Thread alvise rigo
Hi Claudio, Thank you for your review. Please see my in-line comments. On Mon, Nov 24, 2014 at 11:34 AM, Claudio Fontana wrote: > On 21.11.2014 19:07, Alvise Rigo wrote: >> Add a generic PCI host controller for virtual platforms, based on the >> previous work by Rob Herring: >> http://lists.gnu.

Re: [Qemu-devel] [PATCH v5 0/3] linux-aio: fix batch submission

2014-11-24 Thread Ming Lei
On Mon, Nov 24, 2014 at 10:31 PM, Paolo Bonzini wrote: > > > On 24/11/2014 15:29, Ming Lei wrote: >> The 1st patch fixes batch submission. >> >> The 2nd one fixes -EAGAIN for non-batch case. >> >> The 3rd one is a cleanup. >> >> This patchset is splitted from previous patchset(dataplane: optimizat

[Qemu-devel] [PATCH for-2.2] qmp: document input-send-event detail

2014-11-24 Thread Amos Kong
This patch documents what exactly input-send-event is supposed to do. Signed-off-by: Amos Kong --- qapi-schema.json | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index d0926d9..9aa19bc 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@

Re: [Qemu-devel] [PATCH] input: improve docs for input-send-event qmp command

2014-11-24 Thread Gerd Hoffmann
Hi, > >> > # @console: #optional console to send event(s) to. > >> > +# This parameter can be used to send the input event to > >> > +# specific input devices in case (a) multiple input devices > >> > +# of the same kind are added to the virtual machine and (b) > >

Re: [Qemu-devel] [PATCH v5 0/3] linux-aio: fix batch submission

2014-11-24 Thread Paolo Bonzini
On 24/11/2014 15:29, Ming Lei wrote: > The 1st patch fixes batch submission. > > The 2nd one fixes -EAGAIN for non-batch case. > > The 3rd one is a cleanup. > > This patchset is splitted from previous patchset(dataplane: optimization > and multi virtqueue support), as suggested by Stefan. > >

[Qemu-devel] [PATCH v5 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb'

2014-11-24 Thread Ming Lei
No one uses the 'node' field any more, so remove it from 'struct qemu_laiocb', and this can save 16byte for the struct on 64bit arch. Reviewed-by: Paolo Bonzini Signed-off-by: Ming Lei --- block/linux-aio.c |1 - 1 file changed, 1 deletion(-) diff --git a/block/linux-aio.c b/block/linux-ai

[Qemu-devel] [PATCH v5 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case

2014-11-24 Thread Ming Lei
Previously -EAGAIN is simply ignored for !s->io_q.plugged case, and sometimes it is easy to cause -EIO to VM, such as NVME device. This patch handles -EAGAIN by io queue for !s->io_q.plugged case, and it will be retried in following aio completion cb. Suggested-by: Paolo Bonzini Signed-off-by: M

[Qemu-devel] [PATCH v5 0/3] linux-aio: fix batch submission

2014-11-24 Thread Ming Lei
The 1st patch fixes batch submission. The 2nd one fixes -EAGAIN for non-batch case. The 3rd one is a cleanup. This patchset is splitted from previous patchset(dataplane: optimization and multi virtqueue support), as suggested by Stefan. V5: - in case of submission failure, return -EIO for n

[Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch

2014-11-24 Thread Ming Lei
In the submit path, we can't complete request directly, otherwise "Co-routine re-entered recursively" may be caused, so this patch fixes the issue with below ideas: - for -EAGAIN or partial completion, retry the submision in following completion cb which is run in BH context

Re: [Qemu-devel] [PATCH v2] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-11-24 Thread Marcel Apfelbaum
On Mon, 2014-11-24 at 14:37 +0100, Vasilis Liaskovitis wrote: > The test enables intel_iommu on q35, looks for and reads the DMAR table as > well > as its only DRHC structure (for now), checking the header and checksums. Hi Vaisilis, I had a deeper look to your patch and the code already checks h

Re: [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Andrey Korolyov
On Mon, Nov 24, 2014 at 5:09 PM, Vasiliy Tolstov wrote: > 2014-11-24 16:57 GMT+03:00 Andrey Korolyov : >> Hello Vasiliy, >> >> can you please check actual values via qemu-monitor-command domid '{ >> "execute": "query-block"}', just to be sure to pin the potential >> problem to the emulator itself?

[Qemu-devel] [PATCH 08/15] fixup! pc: explicitly check maxmem limit when adding DIMM

2014-11-24 Thread Igor Mammedov
Fix build breakage on 32 bit host: hw/i386/pc.c:1623:9: error: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'ram_addr_t' [-Werror=format] introduced by: pc: explicitly check maxmem limit when adding DIMM Signed-off-by: Igor Mammedov --- hw/i386/pc.

Re: [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Vasiliy Tolstov
2014-11-24 16:57 GMT+03:00 Andrey Korolyov : > Hello Vasiliy, > > can you please check actual values via qemu-monitor-command domid '{ > "execute": "query-block"}', just to be sure to pin the potential > problem to the emulator itself? virsh qemu-monitor-command 11151 '{ "execute": "query-block"}'

Re: [Qemu-devel] [PATCH] input: improve docs for input-send-event qmp command

2014-11-24 Thread Markus Armbruster
Gerd Hoffmann writes: > On Fr, 2014-11-21 at 12:59 +0100, Markus Armbruster wrote: >> [Copying Eric] >> >> Gerd Hoffmann writes: >> >> > Text partly suggested by Markus Armbruster >> > >> > Signed-off-by: Gerd Hoffmann >> > --- >> > qapi-schema.json | 12 >> > 1 file changed, 1

[Qemu-devel] [PULL] Revert "qemu-img info: show nocow info"

2014-11-24 Thread Kevin Wolf
This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622. The main reason for reverting this commit before the 2.2 release is that it adds a QAPI interface that we don't want to keep: The 'nocow' flag doesn't generally make sense for block nodes, but only for the raw-posix driver. It should th

[Qemu-devel] [PULL] Block patches for 2.2.0-rc3

2014-11-24 Thread Kevin Wolf
The following changes since commit 0e88f478508b566152c6681f4889ed9830a2c0a5: Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging (2014-11-21 14:15:37 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT

2014-11-24 Thread Stefan Hajnoczi
On Fri, Nov 21, 2014 at 12:58:56PM +0100, Paolo Bonzini wrote: > > > On 21/11/2014 11:49, Stefan Hajnoczi wrote: > > The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never > > used! Let's fix that so external snapshot can be blocked. > > The patch is about internal snapshots tho. :

Re: [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Andrey Korolyov
On Mon, Nov 24, 2014 at 3:02 PM, Vasiliy Tolstov wrote: > Hi. I'm try to shape disk via total_iops_sec in libvirt > libvirt 1.2.10 > qemu 2.0.0 > > Firstly when i'm run vm with predefined > 5000 i have around 11000 iops (dd > if=/dev/sda bs=512K of=/dev/null) > After that i'm try to set via virsh

Re: [Qemu-devel] [PATCH 3/4] blockdev: acquire AioContext in QMP 'transaction' actions

2014-11-24 Thread Stefan Hajnoczi
On Fri, Nov 21, 2014 at 02:51:30PM +0100, Max Reitz wrote: > On 2014-11-21 at 11:48, Stefan Hajnoczi wrote: > >The transaction QMP command performs operations atomically on a group of > >drives. This command needs to acquire AioContext in order to work > >safely when virtio-blk dataplane IOThreads

Re: [Qemu-devel] [PATCH 2/5] exec: qemu_ram_alloc_device, qemu_ram_resize

2014-11-24 Thread Paolo Bonzini
On 20/11/2014 15:04, Michael S. Tsirkin wrote: > On Thu, Nov 20, 2014 at 02:35:14PM +0100, Markus Armbruster wrote: >> What am I missing here that can justify the complexity of partially >> overriding target configuration in the migration stream plus >> infrastructure for resizing memory? > > Th

[Qemu-devel] [PULL 2/3] apic: fix loss of IPI due to masked ExtINT

2014-11-24 Thread Paolo Bonzini
This patch fixes an obscure failure of the QNX kernel on QEMU x86 SMP. In QNX, all hardware interrupts come via the PIC, and are delivered by the cpu 0 LAPIC in ExtINT mode, while IPIs are delivered by the LAPIC in fixed mode. This bug happens as follows: - cpu 0 masks a particular PIC interrupt -

[Qemu-devel] [PULL 3/3] apic: fix incorrect handling of ExtINT interrupts wrt processor priority

2014-11-24 Thread Paolo Bonzini
This fixes another failure with ExtINT, demonstrated by QNX. The failure mode is as follows: - IPI sent to cpu 0 (bit set in APIC irr) - IPI accepted by cpu 0 (bit cleared in irr, set in isr) - IPI sent to cpu 0 (bit set in both irr and isr) - PIC interrupt sent to cpu 0 The PIC interrupt causes

[Qemu-devel] [PULL 1/3] apic: avoid getting out of halted state on masked PIC interrupts

2014-11-24 Thread Paolo Bonzini
After the next patch, if a masked PIC interrupts causes CPU_INTERRUPT_POLL to be set, the CPU will spuriously get out of halted state. While this is technically valid, we should avoid that. Make CPU_INTERRUPT_POLL run apic_update_irq in the right thread and then look at CPU_INTERRUPT_HARD. If CP

[Qemu-devel] [PULL for-2.2 0/3] APIC fixes for 2014-11-24

2014-11-24 Thread Paolo Bonzini
The following changes since commit 0e88f478508b566152c6681f4889ed9830a2c0a5: Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging (2014-11-21 14:15:37 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you t

Re: [Qemu-devel] [PATCH] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-11-24 Thread Vasilis Liaskovitis
Hi, On Mon, Nov 24, 2014 at 11:37:05AM +0200, Marcel Apfelbaum wrote: > On Sat, 2014-11-22 at 20:05 +0100, Vasilis Liaskovitis wrote: > > The test enables intel_iommu on q35 and reads the DMAR table and its only > > DRHC structure (for now), checking only the header and checksums. > > > > Signed-

[Qemu-devel] [PATCH v2] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-11-24 Thread Vasilis Liaskovitis
The test enables intel_iommu on q35, looks for and reads the DMAR table as well as its only DRHC structure (for now), checking the header and checksums. Signed-off-by: Vasilis Liaskovitis --- tests/bios-tables-test.c | 46 +- 1 file changed, 45 inserti

  1   2   >