Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Wangting (Kathy)
On 2015-1-8 18:03, Vadim Rozenfeld wrote: On Thu, 2015-01-08 at 17:27 +0800, Wangting (Kathy) wrote: On 2015-1-8 17:01, Vadim Rozenfeld wrote: On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge

Re: [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API

2015-01-08 Thread Fam Zheng
On Thu, 01/08 11:03, Paolo Bonzini wrote: The current pointer free API for timers is very low level. Introduce a new API that matches timer_new_ns/us/ms and also a new API timer_deinit that can be used instead of timer_free. Finally, mechanically change timer macro names in vmstate, to make

[Qemu-devel] [PATCH v2] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-08 Thread 马文霜
Last month, we experienced several guests crash(6cores-8cores), qemu logs display the following messages: qemu-system-x86_64: /build/qemu-2.1.2/kvm-all.c:976: kvm_irqchip_commit_routes: Assertion `ret == 0' failed. After analysis and verification, we can confirm it's irq-balance daemon(in guest)

[Qemu-devel] [RFC PATCH] spapr_vio/spapr_iommu: Move VIO bypass where it belongs

2015-01-08 Thread Alexey Kardashevskiy
Instead of tweaking a TCE table device by adding there a bypass flag, let's add an alias to RAM and IOMMU memory region, and enable/disable those according to the selected bypass mode. This way IOMMU memory region can have size of the actual window rather than ram_size which is essential for

Re: [Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms

2015-01-08 Thread Fam Zheng
On Thu, 01/08 11:03, Paolo Bonzini wrote: These functions for the main loop TimerListGroup will replace timer_new and timer_new_ns/us/ms. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qemu/timer.h | 73 1 file changed,

Re: [Qemu-devel] [PATCH] qga: add guest-set-admin-password command

2015-01-08 Thread Michael Roth
Quoting Daniel P. Berrange (2014-12-15 06:47:46) Add a new 'guest-set-admin-password' command for changing the root/administrator password. This command is needed to allow OpenStack to support its API for changing the admin password on a running guest. Accepts either the raw password

[Qemu-devel] Press Inquiry: Qemu Advent Calendar (German Linux Magazin)

2015-01-08 Thread Tim Schürmann
Hi! I'm responsible for the content of the DVD that is shipped with each printed issue of the german Linux Magazin. I would like to ask, if we could use the Qemu images/virtual machines from your Qemu Advent Calendar 2014 (well at least the ones with Open-Source-Software :)). Best

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Gary R Hook
On 1/8/15 2:21 PM, Kashyap Chamarthy wrote: qemu-img create -f qcow2 /tmp/dsk.test.qcow2 A typo? You also need to provide a size here: $ qemu-img create -f qcow2 /tmp/dsk.test.qcow2 1G Yes, my mistake. The size is set to the potential size of the source disk, which in this case is

Re: [Qemu-devel] [PATCH 1/3] socket shutdown

2015-01-08 Thread Amit Shah
On (Thu) 08 Jan 2015 [11:11:30], Dr. David Alan Gilbert (git) wrote: static const QEMUFileOps socket_write_ops = { -.get_fd = socket_get_fd, +.get_fd= socket_get_fd, .writev_buffer = socket_writev_buffer, -.close = socket_close +.close =

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Amit Shah
On (Thu) 08 Jan 2015 [11:11:29], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com If the remote host, or networking dies during a migration, the socket can be waiting for a long timeout, and migration_cancel can't complete the cancel for a long time (and

[Qemu-devel] [Bug 1405385] Re: QEMU crashes when virtio network cards are used together with e1000 network cards

2015-01-08 Thread Bram Klein Gunnewiek
I'm not sure if there is more information required from my side? I can still reproduce this and have no clue where to look for more information. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1405385

Re: [Qemu-devel] [RFC PATCH] qga: implement guest-network-get-interfaces command for windows

2015-01-08 Thread Michael Roth
Quoting zhanghailiang (2014-12-24 04:21:20) Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- Hi, This patch implements guest-network-get-interfaces command for Windows. This patch is RFC because the value of network 'prefix' length may be wrong When there is an adapter

Re: [Qemu-devel] [RFC PATCH] qga: implement guest-network-get-interfaces command for windows

2015-01-08 Thread Michael Roth
Quoting Michael Roth (2015-01-08 17:29:43) Quoting zhanghailiang (2014-12-24 04:21:20) Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- Hi, This patch implements guest-network-get-interfaces command for Windows. This patch is RFC because the value of network

[Qemu-devel] [PATCH v3] spapr-pci: Enable huge BARs

2015-01-08 Thread Alexey Kardashevskiy
At the moment sPAPR only supports 512MB window for MMIO BARs. However modern devices might want bigger 64bit BARs. This extends MMIO window from 512MB to 62GB (aligned to SPAPR_PCI_WINDOW_SPACING) and advertises it in 2 records in the PHB ranges property. 32bit gets the space from

Re: [Qemu-devel] [PATCH 4/9] hbitmap: store / restore

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 22:21, John Snow wrote: Why are the conversions to little endian, though? Shouldn't we be serializing to a Big Endian format? Because reading two 32-bit little-endian longs or a 64-bit little-endian long gives the same value. This is not true for big-endian. Take the following

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread John Snow
CC'ing Eric Blake for monitor interface review. On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add dirty parameter to qmp-migrate command. If this parameter is true, block-migration.c will migrate dirty bitmaps. This parameter can be used without blk parameter to migrate only dirty

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread John Snow
CCing migration maintainers, feedback otherwise in-line. On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Just migrate parts of dirty bitmaps, corresponding to the block being migrated. Also, skip block migration if it is disabled (blk parameter of migrate command is false).

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Gary R Hook
On 1/8/15 3:04 PM, Eric Blake wrote: Where are you specifying the format? I have not personally played with NBD much. This appears to be the pervasive situation. There's not much out there in google-land about this. But here's my guess: Even though /tmp/dsk.test.qcow2 is a qcow2 file,

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(tp, NULL); forever

2015-01-08 Thread Gerhard Wiesinger
On 08.01.2015 19:22, Paolo Bonzini wrote: On 08/01/2015 19:12, Gerhard Wiesinger wrote: Since kernels were the same on FC20/F21 and qemu/kvm changed from 1.6.2 to 2.1.2 I guess the topic seems to be there. Also newer gcc might be a topic. Indeed. Can you try the 2.2.0 qemu-kvm release,

Re: [Qemu-devel] [PATCH 7/9] block-migration: remove not needed iothread lock

2015-01-08 Thread Paolo Bonzini
On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: -qemu_mutex_lock_iothread(); +bdrv_reset_dirty_bitmap(bs, bmds-dirty_bitmap, cur_sector, nr_sectors); + blk-aiocb = bdrv_aio_readv(bs, cur_sector, blk-qiov, nr_sectors, blk_mig_read_cb,

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread Eric Blake
On 01/08/2015 02:51 PM, John Snow wrote: CC'ing Eric Blake for monitor interface review. Indeed, I already saw and reviewed the monitor interface in a mail dated Dec 11. On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add dirty parameter to qmp-migrate command. If this parameter

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread John Snow
On 01/08/2015 05:29 PM, Eric Blake wrote: On 01/08/2015 02:51 PM, John Snow wrote: CC'ing Eric Blake for monitor interface review. Indeed, I already saw and reviewed the monitor interface in a mail dated Dec 11. Sorry, I missed that one. Thank you, though :) On 12/11/2014 09:17 AM,

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread Paolo Bonzini
On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: Just migrate parts of dirty bitmaps, corresponding to the block being migrated. Also, skip block migration if it is disabled (blk parameter of migrate command is false). Skipping shared sectors: bitmaps are migrated independently of

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 22:51, John Snow wrote: CC'ing Eric Blake for monitor interface review. See also my review of patch 9. Paolo

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(tp, NULL); forever

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 23:28, Gerhard Wiesinger wrote: Updated to 2.2.0 qemu-kvm release, worked seemless so far for all VMs. I'll keep you up to date in the next days whether it happens again or not. BTW: Has something changed in the time code area between 1.6.2 and 2.1.2? Most of this is

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread Eric Blake
On 01/08/2015 03:36 PM, Paolo Bonzini wrote: On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: Just migrate parts of dirty bitmaps, corresponding to the block being migrated. Also, skip block migration if it is disabled (blk parameter of migrate command is false). Skipping shared

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/01/2015 23:45, Eric Blake wrote: The bitmaps are transmitted many times in their entirety, but only the last copy actually means something. The others are lost. This means you should use the non-live interface (register_savevm). This

Re: [Qemu-devel] [Qemu-stable] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 11:31, Stefan Hajnoczi wrote: Excellent, please add the following commits to stable: f214928 nbd: Follow the BDS' AIO context 3338442 block: Add AIO context notifiers 958c717 nbd: Drop nbd_can_read() They prevent crashes when the run-time NBD server is used together with

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 12:11, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com If the remote host, or networking dies during a migration, the socket can be waiting for a long timeout, and migration_cancel can't complete the cancel for a long time (and you can't

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Daniel P. Berrange
On Thu, Jan 08, 2015 at 11:11:29AM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com If the remote host, or networking dies during a migration, the socket can be waiting for a long timeout, and migration_cancel can't complete the cancel for a long

Re: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Gerd Hoffmann
On Do, 2015-01-08 at 11:50 +0100, Javier Celaya wrote: Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: On Thu, Jan 08, 2015 at 11:11:29AM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com If the remote host, or networking dies during a migration, the socket can be waiting for a long timeout, and

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Daniel P. Berrange
On Thu, Jan 08, 2015 at 11:29:59AM +, Dr. David Alan Gilbert wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Thu, Jan 08, 2015 at 11:11:29AM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com If the remote host, or networking

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Fabio Fantoni
Il 08/01/2015 11:50, Javier Celaya ha scritto: Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be

Re: [Qemu-devel] [PATCH] vmstate: type-check sub-arrays

2015-01-08 Thread Amit Shah
On (Wed) 07 Jan 2015 [15:12:13], Paolo Bonzini wrote: While we cannot check against the type of the full array, we can check against the type of the fields. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Amit Shah amit.s...@redhat.com Amit

Re: [Qemu-devel] [RFC V9 4/4] domain snapshot design: libxl/libxlu

2015-01-08 Thread Ian Campbell
On Mon, 2014-12-22 at 02:36 -0700, Chun Yan Liu wrote: b). For internal snapshot, like qcow2, lvm too. For lvm, it doesn't support snapshot of snapshot, so out of scope. For qcow2, delete any disk snapshot won't affect others. For either internal or external if you are

[Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings

2015-01-08 Thread Peter Maydell
This patchset fixes warnings produced by clang in the linux-user code. Mostly this is deleting or marking unused functions/data, but it does include a genuine bugfix for Alpha. I think that this means I have patches out on the list now for all the clang warnings we currently generate; maybe some

[Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused

2015-01-08 Thread Peter Maydell
The function end_exclusive() isn't used on all targets; mark it as such to avoid a clang warning. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index

[Qemu-devel] [PATCH 3/6] linux-user/arm/nwfpe: Delete unused aCC array

2015-01-08 Thread Peter Maydell
The aCC array in fpopcode.c is completely unused in QEMU; delete it (silencing a clang warning). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/arm/nwfpe/fpopcode.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/linux-user/arm/nwfpe/fpopcode.c

[Qemu-devel] [PATCH 6/6] linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user

2015-01-08 Thread Peter Maydell
The function copy_siginfo_to_user() just calls tswap_siginfo(), so call the latter function directly and delete the wrapper function. The wrapper is actually misleading since it implies that the semantics are like the kernel function with the same name which copies the data to a guest user-space

[Qemu-devel] [PATCH 4/6] linux-user/main.c: Call cpu_exec_start/end on all target archs

2015-01-08 Thread Peter Maydell
The start_exclusive() infrastructure is used on all target architectures, even if only to do the stop all CPUs before dumping core in force_sig(), so be consistent and call cpu_exec_start/end in the main loop of every target. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 1/6] linux-user/signal.c: Remove current_exec_domain_sig()

2015-01-08 Thread Peter Maydell
Remove the function current_exec_domain_sig(), which always returns its argument. This was intended as a stub for supporting the kernel's exec_domain handling, but: * we don't have any of the other code for execution domains * in the kernel this handling is architecture-specific, not generic *

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Claudio Fontana
On 08.01.2015 11:31, Peter Maydell wrote: On 7 January 2015 at 15:52, Claudio Fontana claudio.font...@huawei.com wrote: Interrupt map does not seem to work for me; incidentally this ends up being the same kind of undocumented blob that Alvise posted in his series. Can you add a good comment

Re: [Qemu-devel] [PATCH v2] vfio-pci: Fix BAR size overflow

2015-01-08 Thread Alexey Kardashevskiy
On 01/08/2015 04:23 AM, Alex Williamson wrote: We use an unsigned int when working with the PCI BAR size, which can obviously overflow if the BAR is 4GB or larger. This needs to change to a fixed length uint64_t. A similar issue is possible, though even more unlikely, when mapping the region

[Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for NR_shmat to enable shmat syscall

2015-01-08 Thread Peter Maydell
For historical reasons, the define for the shmat() syscall on Alpha is NR_osf_shmat; however it has the same semantics as this syscall does on all other architectures, so define TARGET_NR_shmat as well so that QEMU's code for the syscall is enabled. This patch brings our behaviour on the LTP

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Claudio Fontana
(added cc: Alvise which I mistakenly assumed was in Cc: already) On 07.01.2015 22:47, Alexander Graf wrote: On 07.01.15 16:52, Claudio Fontana wrote: On 06.01.2015 17:03, Alexander Graf wrote: Now that we have a working generic PCIe host bridge driver, we can plug it into ARMs virt

Re: [Qemu-devel] [PATCH v2 0/6] aio: Support epoll by introducing qemu_poll abstraction

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 03:53, Fam Zheng wrote: 1) Remove 1ns PR_SET_TIMERSLACK in timerfd+epoll, this doesn't make qemu_poll faster than the old qemu_poll_ns, but may have other positive effects that compensate the cost. Sounds like a random hack. What is the reasoning for messing

[Qemu-devel] [PULL v2 0/7] pc: resizeable ROM blocks

2015-01-08 Thread Michael S. Tsirkin
Changes from v1: - squashed two patches, as suggested by Paolo - comment fixup suggested by Paolo - added acks by Paolo The following changes since commit d86fb03469e016af4e54f04efccbc20a8afa3e19: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20141216-1' into staging

[Qemu-devel] [PULL v2 1/7] memory: add memory_region_set_size

2015-01-08 Thread Michael S. Tsirkin
Add API to change MR size. Will be used internally for RAM resize. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 10 ++ memory.c | 16 2 files changed, 26 insertions(+) diff

[Qemu-devel] [PULL v2 2/7] exec: cpu_physical_memory_set/clear_dirty_range

2015-01-08 Thread Michael S. Tsirkin
Make cpu_physical_memory_set/clear_dirty_range behave symmetrically. To clear range for a given client type only, add cpu_physical_memory_clear_dirty_range_type. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/ram_addr.h | 15

[Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Wangting (Kathy)
Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge the patch about Bug 1077566 into it, but I find that MSI still doesn't work, because the value of IRQ is not negative in the device manager. I try to trace the I/O path with ENABLE_COM_DEBUG, and I find

Re: [Qemu-devel] Ping [PATCH] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 04:28, kevinnma(马文霜) wrote: Ping Patches here: http://patchwork.ozlabs.org/patch/424738/ Description: In multi-core guest, set irq affinity will eventually lead to guest crash, this is a severe BUG, I do not know why this patch was ignored? Because there is one

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-08 Thread Gerd Hoffmann
Hi, VGA: Using shared surface for depth=32 swap=1 Ok, 32bpp. byteswapping needed. I guess the host is a intel macintosh then? Having a quick look at the cocoa code it seems it doesn't look at the color masks and shifts, only the color depth. So having the UI handle the byteswapping that

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Vadim Rozenfeld
On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge the patch about Bug 1077566 into it, but I find that MSI still doesn't work, because the value of IRQ is not negative in the device manager.

Re: [Qemu-devel] [PATCH] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-08 Thread Paolo Bonzini
On 31/12/2014 04:45, kevinnma(马文霜) wrote: Last month, we experienced several guests crash(6cores-8cores),qemu logs display the following messages: qemu-system-x86_64: /build/qemu-2.1.2/kvm-all.c:976: kvm_irqchip_commit_routes: Assertion `ret == 0' failed. After analysis and

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Wangting (Kathy)
On 2015-1-8 17:01, Vadim Rozenfeld wrote: On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge the patch about Bug 1077566 into it, but I find that MSI still doesn't work, because the value of IRQ

Re: [Qemu-devel] [PATCH RFC v6 13/20] virtio: allow to fail setting status

2015-01-08 Thread Michael S. Tsirkin
On Thu, Jan 08, 2015 at 08:20:37AM +0100, Cornelia Huck wrote: On Wed, 7 Jan 2015 21:08:21 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jan 07, 2015 at 05:13:32PM +0100, Cornelia Huck wrote: On Tue, 30 Dec 2014 14:25:37 +0200 Michael S. Tsirkin m...@redhat.com wrote:

[Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API

2015-01-08 Thread Paolo Bonzini
The current pointer free API for timers is very low level. Introduce a new API that matches timer_new_ns/us/ms and also a new API timer_deinit that can be used instead of timer_free. Finally, mechanically change timer macro names in vmstate, to make it clear that they accept a pointer. This

Re: [Qemu-devel] [Makefile] Compiling Qemu to dynamic library

2015-01-08 Thread Peter Maydell
On 8 January 2015 at 04:02, Halsey Pian halsey.p...@gmail.com wrote: ./stubs/slirp.c:void slirp_pollfds_fill(GArray *pollfds, uint32_t *timeout) ./main-loop.c:slirp_pollfds_fill(gpollfds, timeout); Do you know when qemustub should be used? libqemustub.a is only used for qemu-img,

[Qemu-devel] [PATCH 3/4] qemu-timer: introduce timer_deinit

2015-01-08 Thread Paolo Bonzini
In some cases, a timer was set to NULL so that we could check if it is initialized. Use the timer_list field instead, and add a timer_deinit function that NULLs it. It then makes sense that timer_del be a no-op (instead of a crasher) on such a de-initialized timer. It avoids the need to poke at

[Qemu-devel] [PATCH 1/4] qemu-timer: rename timer_init to timer_init_tl

2015-01-08 Thread Paolo Bonzini
timer_init is not called that often. Free the name for an equivalent of timer_new. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/block/aio.h | 2 +- include/qemu/timer.h | 10 +- qemu-timer.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff

Re: [Qemu-devel] [Qemu-stable] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-08 Thread Stefan Hajnoczi
On Thu, Jan 8, 2015 at 1:17 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: Quoting Stefan Hajnoczi (2015-01-06 05:49:11) On Mon, Jan 05, 2015 at 05:12:10PM +0400, Andrey Korolyov wrote: On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Dec 18, 2014 at

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Peter Maydell
On 7 January 2015 at 15:52, Claudio Fontana claudio.font...@huawei.com wrote: Interrupt map does not seem to work for me; incidentally this ends up being the same kind of undocumented blob that Alvise posted in his series. Can you add a good comment about what the ranges property contains (the

[Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com If the remote host, or networking dies during a migration, the socket can be waiting for a long timeout, and migration_cancel can't complete the cancel for a long time (and you can't start a new one to somewhere else). (Where 'long' is the TCP

[Qemu-devel] [PATCH 2/3] Handle bi-directional communication for fd migration

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: Cristian Klein cristian.kl...@cs.umu.se libvirt prefers opening the TCP connection itself, for two reasons. First, connection failed errors can be detected easier, without having to parse qemu's error output. Second, libvirt might be asked to secure the transfer by tunnelling the

[Qemu-devel] [PATCH 1/3] socket shutdown

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Add QEMUFile interface to allow a socket to be 'shut down' - i.e. any reads/writes will fail (and any blocking read/write will be woken). Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- include/migration/qemu-file.h | 10 ++

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Vadim Rozenfeld
On Thu, 2015-01-08 at 17:27 +0800, Wangting (Kathy) wrote: On 2015-1-8 17:01, Vadim Rozenfeld wrote: On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge the patch about Bug 1077566 into it,

[Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*

2015-01-08 Thread Paolo Bonzini
Old users of VMSTATE_TIMER* are mechanically changed to VMSTATE_TIMER_PTR variants. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/acpi/ich9.c | 2 +- hw/acpi/piix4.c | 2 +- hw/arm/stellaris.c | 2 +- hw/block/fdc.c | 2 +-

[Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms

2015-01-08 Thread Paolo Bonzini
These functions for the main loop TimerListGroup will replace timer_new and timer_new_ns/us/ms. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qemu/timer.h | 73 1 file changed, 73 insertions(+) diff --git a/include/qemu/timer.h

Re: [Qemu-devel] [PATCH RESEND v2 0/3] vl: smp_parse sanity checks

2015-01-08 Thread Paolo Bonzini
On 19/12/2014 03:59, Eduardo Habkost wrote: From the original series sent by Andrew, only patch 1/3 was kept. Patch 2/3 from v1 was replaced by a safer fix. Patch 3/3 was removed because it generates a warning even on the most common use-case (-smp n without any extra options). Andrew

[Qemu-devel] [PATCH 3/3] migration_cancel: shutdown migration socket

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Force shutdown on migration socket on cancel to cause the cancel to complete even if the socket is blocked on a dead network. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- migration/migration.c | 12 1 file changed,

[Qemu-devel] [PULL v2 4/7] exec: qemu_ram_alloc_resizeable, qemu_ram_resize

2015-01-08 Thread Michael S. Tsirkin
Add API to allocate resizeable RAM. This looks just like regular RAM generally, but has a special property that only a portion of it (used_length) is actually used, and migrated. This used_length size can change across reboots. Follow up patches will change used_length for such blocks at

[Qemu-devel] [PULL v2 3/7] exec: split length - used_length/max_length

2015-01-08 Thread Michael S. Tsirkin
This patch allows us to distinguish between two length values for each block: max_length - length of memory block that was allocated used_length - length of block used by QEMU/guest Currently, we set used_length - max_length, unconditionally. Follow-up patches allow used_length =

[Qemu-devel] [PULL v2 6/7] memory: API to allocate resizeable RAM MR

2015-01-08 Thread Michael S. Tsirkin
Add API to allocate resizeable RAM MR. This looks just like regular RAM generally, but has a special property that only a portion of it (used_length) is actually used, and migrated. This used_length size can change across reboots. Follow up patches will change used_length for such blocks at

[Qemu-devel] [PULL v2 5/7] arch_init: support resizing on incoming migration

2015-01-08 Thread Michael S. Tsirkin
If block used_length does not match, try to resize it. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- arch_init.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c index

Re: [Qemu-devel] [PATCH RESEND v2 0/3] vl: smp_parse sanity checks

2015-01-08 Thread Eduardo Habkost
On Thu, Jan 08, 2015 at 11:48:30AM +0100, Paolo Bonzini wrote: On 19/12/2014 03:59, Eduardo Habkost wrote: From the original series sent by Andrew, only patch 1/3 was kept. Patch 2/3 from v1 was replaced by a safer fix. Patch 3/3 was removed because it generates a warning even on the

Re: [Qemu-devel] [Qemu-stable] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-08 Thread Stefan Hajnoczi
On Thu, Jan 8, 2015 at 12:11 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 08/01/2015 11:31, Stefan Hajnoczi wrote: Excellent, please add the following commits to stable: f214928 nbd: Follow the BDS' AIO context 3338442 block: Add AIO context notifiers 958c717 nbd: Drop nbd_can_read()

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-08 Thread Peter Maydell
On 6 January 2015 at 13:29, Marcel Apfelbaum mar...@redhat.com wrote: Patch e79d5a6 (machine: remove qemu_machine_opts global list) removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This resulted in a Qemu crash: $

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Alexander Graf
On 08.01.15 13:55, Claudio Fontana wrote: (added cc: Alvise which I mistakenly assumed was in Cc: already) He was in CC :). Now he's there twice. On 07.01.2015 22:47, Alexander Graf wrote: On 07.01.15 16:52, Claudio Fontana wrote: On 06.01.2015 17:03, Alexander Graf wrote: Now that we

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread alvise rigo
On Thu, Jan 8, 2015 at 1:55 PM, Claudio Fontana claudio.font...@huawei.com wrote: (added cc: Alvise which I mistakenly assumed was in Cc: already) On 07.01.2015 22:47, Alexander Graf wrote: On 07.01.15 16:52, Claudio Fontana wrote: On 06.01.2015 17:03, Alexander Graf wrote: Now that we

[Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(tp, NULL); forever

2015-01-08 Thread Gerhard Wiesinger
Hello, After upgrading my KVM environment from Fedora 20 to Fedora 21 up2date (hosts and guests, Intel CPU) I've the following problem: 1.) On the database VM PostgresSQL e.g. 2 processes hang with 100% cpu 2.) On the monitoring VM Munin/RRDtool also hangs with 100% cpu Killing of processes is

Re: [Qemu-devel] the need for if=none for -drive?

2015-01-08 Thread Stefan Hajnoczi
On Wed, Dec 17, 2014 at 11:52 AM, Markus Armbruster arm...@redhat.com wrote: Sorry for the slow reply, I missed this one until now. Adding block maintainers. John Snow js...@redhat.com writes: On 11/02/2014 02:21 AM, Michael Tokarev wrote: All modern 2-way drive/device specifications need

Re: [Qemu-devel] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 13:22, Thomas Huth wrote: On Mon, 15 Dec 2014 11:19:46 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: config.status and tests/qemu-iotests/common.env are generated files that should be deleted during 'make distclean'. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com

[Qemu-devel] Patch Round-up for stable 2.1.3, freeze on 2015-01-14

2015-01-08 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v2.1.3: https://github.com/mdroth/qemu/commits/stable-2.1-staging The release is planned for 2015-01-21: http://wiki.qemu.org/Planning/2.1 Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be

[Qemu-devel] [PATCH 04/88] xhci PCIe endpoint migration compatibility fix

2015-01-08 Thread Michael Roth
From: Dr. David Alan Gilbert dgilb...@redhat.com Add back the PCIe config capabilities on XHCI cards in non-PCIe slots, but only for machine types before 2.1. This fixes a migration incompatibility in the XHCI PCI devices caused by: 058fdcf52cdbf57b67e7 - xhci: add endpoint cap on express bus

[Qemu-devel] [PATCH 02/88] qdev: Add cleanup logic in device_set_realized() to avoid resource leak

2015-01-08 Thread Michael Roth
From: Gonglei arei.gong...@huawei.com At present, this function doesn't have partial cleanup implemented, which will cause resource leaks in some scenarios. Example: 1. Assume that dc-realize(dev, local_err) executes successful and local_err == NULL; 2. device hotplug in

[Qemu-devel] [PATCH 08/88] kvmclock: Add comment explaining why we need cpu_clean_all_dirty()

2015-01-08 Thread Michael Roth
From: Eduardo Habkost ehabk...@redhat.com Try to explain why commit 317b0a6d8ba44e9bf8f9c3dbd776c4536843d82c needed a cpu_clean_all_dirty() call just after calling cpu_synchronize_all_states(). Signed-off-by: Eduardo Habkost ehabk...@redhat.com Cc: Andrey Korolyov and...@xdel.ru Cc: Marcin

[Qemu-devel] [PATCH 01/88] qdev: Use NULL instead of local_err for qbus_child unrealize

2015-01-08 Thread Michael Roth
From: Gonglei arei.gong...@huawei.com Forcefully unrealize all children regardless of errors in earlier iterations (if any). We should keep going with cleanup operation rather than report an error immediately. Therefore store the first child unrealization failure and propagate it at the end. We

[Qemu-devel] [PATCH 03/88] exec: file_ram_alloc(): print error when prealloc fails

2015-01-08 Thread Michael Roth
From: Luiz Capitulino lcapitul...@redhat.com If memory allocation fails when using the -mem-prealloc command-line option, QEMU exits without printing any error information to the user: # qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages # echo $? 1 This commit adds an error message, so

[Qemu-devel] [PATCH 13/88] gdbstub: init mon_chr through qemu_chr_alloc

2015-01-08 Thread Michael Roth
From: Pavel Dovgalyuk pavel.dovga...@ispras.ru This patch initializes monitor for gdbstub with the qemu_chr_alloc function instead of just allocating the memory. Initialization function call is required, because it also creates chr_write_lock mutex, which is used when writing to this character

[Qemu-devel] [PATCH 15/88] qapi: dealloc visitor, implement visit_start_union

2015-01-08 Thread Michael Roth
If the .data field of a QAPI Union is NULL, we don't need to free any of the union fields. Make use of the new visit_start_union interface to access this information and instruct the generated code to not visit these fields when this occurs. Cc: qemu-sta...@nongnu.org Reported-by: Fam Zheng

[Qemu-devel] [PATCH 24/88] ivshmem: Fix fd leak on error

2015-01-08 Thread Michael Roth
From: Andreas Färber afaer...@suse.de Reported-by: Stefan Hajnoczi stefa...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com (cherry picked from commit

[Qemu-devel] [PATCH 11/88] spapr_pci: map the MSI window in each PHB

2015-01-08 Thread Michael Roth
From: Greg Kurz gk...@linux.vnet.ibm.com On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X so that writes are made using the bus master address space and follow the IOMMU path. Unfortunately, the IOMMU address

[Qemu-devel] [PATCH 33/88] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports

2015-01-08 Thread Michael Roth
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the

[Qemu-devel] [PATCH 16/88] tests: add QMP input visitor test for unions with no discriminator

2015-01-08 Thread Michael Roth
This is more of an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that discriminator field/type are present, which can lead to attempts to free random chunks of heap memory. Cc:

[Qemu-devel] [PATCH 38/88] virtio-balloon: fix virtio-balloon child refcount in transports

2015-01-08 Thread Michael Roth
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-balloon

[Qemu-devel] [PATCH 22/88] ivshmem: validate incoming_posn value from server

2015-01-08 Thread Michael Roth
From: Stefan Hajnoczi stefa...@redhat.com Check incoming_posn to avoid out-of-bounds array accesses if the ivshmem server on the host sends invalid values. Cc: Cam Macdonell c...@cs.ualberta.ca Reported-by: Sebastian Krahmer krah...@suse.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com [AF:

[Qemu-devel] [PATCH 48/88] libcacard: don't free sign buffer while sign op is pending

2015-01-08 Thread Michael Roth
From: Ray Strode rstr...@redhat.com commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up the cac_applet_pki_process_apdu function to have a single exit point. Unfortunately, that commit introduced a bug where the sign buffer can get free'd and nullified while it's still being used. This

[Qemu-devel] [PATCH 06/88] kvmclock: Ensure proper env-tsc value for kvmclock_current_nsec calculation

2015-01-08 Thread Michael Roth
From: Marcelo Tosatti mtosa...@redhat.com Ensure proper env-tsc value for kvmclock_current_nsec calculation. Reported-by: Marcin Gibuła m.gib...@beyond.pl Analyzed-by: Marcin Gibuła m.gib...@beyond.pl Cc: qemu-sta...@nongnu.org Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH 54/88] hw/xtensa/xtfpga: treat uImage load address as virtual

2015-01-08 Thread Michael Roth
From: Max Filippov jcmvb...@gmail.com U-boot for xtensa always treats uImage load address as virtual address. This is important when booting uImage on xtensa core with MMUv2, because MMUv2 has fixed non-identity virtual-to-physical mapping after reset. Always do virtual-to-physical translation

  1   2   3   >