Re: [Qemu-devel] [PATCH v10 06/13] block: Add bdrv_copy_dirty_bitmap and bdrv_clear_dirty_bitmap

2015-01-09 Thread John Snow
On 12/30/2014 08:47 AM, Vladimir Sementsov-Ogievskiy wrote: I'm sorry if it was already discussed, but I think it is inconsistent to have size in sectors and granularity in bytes in one structure. I've misused these fields because of this in my current work. At least, I think there should be

Re: [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API

2015-01-09 Thread Fam Zheng
On Fri, 01/09 10:07, Paolo Bonzini wrote: On 09/01/2015 03:10, Fam Zheng wrote: On Thu, 01/08 11:03, Paolo Bonzini wrote: The current pointer free API for timers is very low level. Introduce a new API that matches timer_new_ns/us/ms and also a new API timer_deinit that can be used

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 12:22 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: On 9 January 2015 at 11:25, Frediano Ziglio fredd...@gmail.com wrote: As this platform can do multiply/divide using 128 bit precision use these instructions to implement it. Signed-off-by: Frediano Ziglio

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-09 Thread Eric Blake
On 01/09/2015 08:28 AM, Don Slutz wrote: [an encrypted message] Oops, you probably want to fix your Thunderbird/Enigmail settings to sign but not encrypt when a list is involved. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Peter Maydell
On 9 January 2015 at 16:08, Frediano Ziglio fredd...@gmail.com wrote: I agree (after some digging) we are not sure we won't get that overflow. Agree to drop the second patch. However I would retain the first. Compiler can use it to optimize much easier. For instance if compiler understand that

[Qemu-devel] [PATCH v2] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-09 Thread Programmingkid
This patch fixes the Mac OS X guest color problem on Mac OS X hosts. Tested using Mac OS 10.2 and Debian Linux 5 operating systems for the guest on qemu-system-ppc. Also tested using Windows XP as a guest in qemu-system-i386. Signed-off-by: John Arbuckle programmingk...@gmail.com --- v2:

Re: [Qemu-devel] [PULL RESEND 0/2] lm32: milkymist fixes and MAINTAINERS update

2015-01-09 Thread Peter Maydell
On 30 December 2014 at 17:03, Michael Walle mich...@walle.cc wrote: Hi Peter, please pull these two commits which were posted to the ML some time ago. --- The following changes since commit ab0302ee764fd702465aef6d88612cdff4302809: Merge remote-tracking branch

[Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION

2015-01-09 Thread Don Slutz
This is the same way vl.c handles this. Signed-off-by: Don Slutz dsl...@verizon.com --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 7876258..b6e9220 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -35,7 +35,7 @@ #include block/qapi.h

Re: [Qemu-devel] Nested KVM L2 guest hangs

2015-01-09 Thread Ariel Zeitlin
Hi, Paolo We are using a pretty new kernel 3.13.0-43 as part of Ubuntu14.04. What version would you recommend? Do we need the upgrade on L0, L1 or both? Thanks, Ariel ‏בתאריך יום שישי, 9 בינואר 2015, Paolo Bonzini pbonz...@redhat.com כתב: On 09/01/2015 15:08, Ariel Zeitlin wrote: At the

Re: [Qemu-devel] Nested KVM L2 guest hangs

2015-01-09 Thread Paolo Bonzini
On 09/01/2015 16:30, Ariel Zeitlin wrote: Hi, Paolo We are using a pretty new kernel 3.13.0-43 as part of Ubuntu14.04. What version would you recommend? At least 3.16. 3.13 is about a year old, and nested virtualization is a very new feature. Do we need the upgrade on L0, L1 or both?

[Qemu-devel] [PATCH v2 0/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION (was qemu-img: Add --pkgversion common option)

2015-01-09 Thread Don Slutz
Changes v1 to v2: Added a cover letter because subject changed. Peter Maydell Eric Blake Switch to be consistent with both linux-user and the softmmu emulators --- Just a little backgound. --version was added to qemu-img: 5f6979cb (Jeff Cody 2014-04-28 14:37:18

Re: [Qemu-devel] Nested KVM L2 guest hangs

2015-01-09 Thread Ariel Zeitlin
Thanks, will try that ‏בתאריך יום שישי, 9 בינואר 2015, Paolo Bonzini pbonz...@redhat.com כתב: On 09/01/2015 16:30, Ariel Zeitlin wrote: Hi, Paolo We are using a pretty new kernel 3.13.0-43 as part of Ubuntu14.04. What version would you recommend? At least 3.16. 3.13 is about a

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Peter Maydell
On 9 January 2015 at 15:41, Frediano Ziglio fredd...@gmail.com wrote: 2015-01-09 12:22 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: +/* Optimised x64 version. This assume that a*b/c fits in 64 bit */ This assumption isn't necessarily true, and this implementation will dump core on

Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION

2015-01-09 Thread Eric Blake
On 01/09/2015 08:17 AM, Don Slutz wrote: This is the same way vl.c handles this. Signed-off-by: Don Slutz dsl...@verizon.com --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com diff --git a/qemu-img.c b/qemu-img.c index

[Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-09 Thread Frank Blaschka
From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of platform constrains devices using IO BARs are not supported. Also a device has to support MSI/MSI-X to run on

[Qemu-devel] [PATCH 3/3 V3] kvm: extend kvm_irqchip_add_msi_route to work on s390

2015-01-09 Thread Frank Blaschka
From: Frank Blaschka frank.blasc...@de.ibm.com on s390 MSI-X irqs are presented as thin or adapter interrupts for this we have to reorganize the routing entry to contain valid information for the adapter interrupt code on s390. To minimize impact on existing code we introduce an architecture

Re: [Qemu-devel] qemu sources and makefile system

2015-01-09 Thread Vasile Catalin-B50542
Thanks. It will be helpful in the future. I managed to make it work. The code was included, but I forgot to register the device type on the virtio-pci bus. static void virtio_pci_register_types(void) { /* ... */ type_register_static(virtio_src_pci_info); /* ... */ } On 07.01.2015

[Qemu-devel] [PATCH 1/3 V3] s390: Add PCI bus support

2015-01-09 Thread Frank Blaschka
From: Frank Blaschka frank.blasc...@de.ibm.com This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to configure/unconfigure via sclp instruction, to do iommu translations and provide s390 support for MSI/MSI-X notification processing.

[Qemu-devel] [PATCH 0/3 V3] add PCI support for the s390 platform

2015-01-09 Thread Frank Blaschka
This set of patches implemets PCI support for the s390 platform. Now it is possible to run virtio-net-pci and potentially all virtual pci devices conforming to s390 platform constrains. V1 added lot of feedback from Alex Graf fixed tons of endian issues V2 added couple of small improvments

[Qemu-devel] [PATCH 4/8] ui/vnc: Support shared surface for most pixman formats

2015-01-09 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt b...@kernel.crashing.org At least all the ones I've tested. We make the assumption that pixman is going to be better at conversion than we are. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org [ kraxel: just hook up qemu_pixman_check_format ]

[Qemu-devel] [PATCH 2/8] ui: Add dpy_gfx_check_format() to check backend shared surface support

2015-01-09 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt b...@kernel.crashing.org This allows VGA to decide whether to use a shared surface based on whether the UI backend supports the format or not. Backends that don't provide the new callback fallback to native 32 bpp which is equivalent to what was supported before.

[Qemu-devel] [PATCH 1/8] ui: Make qemu_default_pixman_format() return 0 on unsupported formats

2015-01-09 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt b...@kernel.crashing.org In order to remove the logic for detecting supported shared pixmap formats from device models, make qemu_default_pixman_format() capable for failing by returning 0 which is not a possible format value rather than asserting. Signed-off-by:

[Qemu-devel] [PATCH 7/8] ui/sdl: Support shared surface for more pixman formats

2015-01-09 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt b...@kernel.crashing.org At least all the ones I've tested. We make the assumption that SDL is going to be better at conversion than we are. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org [ kraxel: minor format tweaks ] Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH] blizzard: do not depend on VGA internals

2015-01-09 Thread Paolo Bonzini
There is nothing that is used by this ARM-specific device. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/display/blizzard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 92b1fac..5019bbb 100644 --- a/hw/display/blizzard.c +++

Re: [Qemu-devel] [PATCH] NVMe: Set correct VS Value for 1.1 Compliant Controllers

2015-01-09 Thread Stefan Hajnoczi
On Thu, Jan 08, 2015 at 03:10:35PM +0530, Anubhav Rakshit wrote: According to NVMe specifications Bits 15:08 represent Minor Version number. Signed-off-by: Anubhav Rakshit anubhav.raks...@gmail.com --- hw/block/nvme.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I

Re: [Qemu-devel] Press Inquiry: Qemu Advent Calendar (German Linux Magazin)

2015-01-09 Thread Stefan Hajnoczi
On Thu, Jan 08, 2015 at 11:20:14PM +0100, Tim Schürmann wrote: I'm responsible for the content of the DVD that is shipped with each printed issue of the german Linux Magazin. I would like to ask, if we could use the Qemu images/virtual machines from your Qemu Advent Calendar 2014 (well at

[Qemu-devel] [PULL 18/26] coroutine: drop qemu_coroutine_adjust_pool_size

2015-01-09 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com This is not needed anymore. The new TLS-based algorithm is adaptive. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com Message-id: 1417518350-6167-7-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 06/26] libqos: Add virtio MMIO support

2015-01-09 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/Makefile | 4 +- tests/libqos/virtio-mmio.c | 190

[Qemu-devel] [PULL 09/26] qemu-iotests: Replace /bin/true with true

2015-01-09 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com The former is not portable because on Mac OSX it is /usr/bin/true. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/common.config | 2 +- tests/qemu-iotests/common.filter | 2 +-

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-09 Thread Gerd Hoffmann
On Do, 2015-01-08 at 12:07 -0500, Programmingkid wrote: On Jan 8, 2015, at 4:02 AM, Gerd Hoffmann wrote: Hi, VGA: Using shared surface for depth=32 swap=1 Ok, 32bpp. byteswapping needed. I guess the host is a intel macintosh then? Yes. So we have be guest @ le host. I

Re: [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API

2015-01-09 Thread Paolo Bonzini
On 09/01/2015 03:10, Fam Zheng wrote: On Thu, 01/08 11:03, Paolo Bonzini wrote: The current pointer free API for timers is very low level. Introduce a new API that matches timer_new_ns/us/ms and also a new API timer_deinit that can be used instead of timer_free. Finally, mechanically

[Qemu-devel] [PATCH 5/8] ui/spice: Support shared surface for most pixman formats

2015-01-09 Thread Gerd Hoffmann
Just hook up qemu_pixman_check_format. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-display.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index d2e3793..8c87212 100644 --- a/ui/spice-display.c +++

[Qemu-devel] [PATCH 0/8] ui/console: add format negotiation for shared surfaces

2015-01-09 Thread Gerd Hoffmann
Hi, This patch series allows display device emulations to negotiate with the UI code which pixman formats it can handle for shared surfaces. please review, Gerd Benjamin Herrenschmidt (5): ui: Make qemu_default_pixman_format() return 0 on unsupported formats ui: Add

[Qemu-devel] [PATCH 6/8] ui/gtk: Support shared surface for most pixman formats

2015-01-09 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt b...@kernel.crashing.org At least all the ones I've tested. We make the assumption that pixman is going to be better at conversion than we are. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org [ kraxel: just hook up qemu_pixman_check_format ]

Re: [Qemu-devel] [RFC PATCH] spapr_vio/spapr_iommu: Move VIO bypass where it belongs

2015-01-09 Thread Paolo Bonzini
On 09/01/2015 02:02, Alexey Kardashevskiy wrote: @@ -100,7 +98,7 @@ static const VMStateDescription vmstate_spapr_tce_table = { VMSTATE_UINT32_EQUAL(nb_table, sPAPRTCETable), /* IOMMU state */ -VMSTATE_BOOL(bypass, sPAPRTCETable), +

[Qemu-devel] [PULL 12/26] qemu-iotests: Add supported os parameter for python tests

2015-01-09 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com If I understand correctly, qemu-iotests never meant to be portable. We only support Linux for all the shell cases, but didn't specify it for python tests. Now add this and default all the python tests as Linux only. If we cares enough later, we can override the

[Qemu-devel] [PULL 17/26] coroutine: rewrite pool to avoid mutex

2015-01-09 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com This patch removes the mutex by using fancy lock-free manipulation of the pool. Lock-free stacks and queues are not hard, but they can suffer from the ABA problem so they are better avoided unless you have some deferred reclamation scheme like RCU.

[Qemu-devel] [PATCH 3/8] ui/pixman: add qemu_pixman_check_format

2015-01-09 Thread Gerd Hoffmann
Convinience check_format function for UIs using pixman. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/qemu-pixman.h | 2 ++ ui/qemu-pixman.c | 27 +++ 2 files changed, 29 insertions(+) diff --git a/include/ui/qemu-pixman.h

[Qemu-devel] [PATCH 8/8] ui/sdl2: Support shared surface for more pixman formats

2015-01-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 2 ++ ui/sdl2-2d.c | 13 + ui/sdl2.c | 13 +++-- 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index f56c596..51fff2e 100644 ---

Re: [Qemu-devel] [RFC V9 4/4] domain snapshot design: libxl/libxlu

2015-01-09 Thread Chun Yan Liu
On 1/8/2015 at 08:11 PM, in message 1420719107.19787.53.ca...@citrix.com, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2014-12-22 at 02:36 -0700, Chun Yan Liu wrote: b). For internal snapshot, like qcow2, lvm too. For lvm, it doesn't support snapshot of snapshot, so out

[Qemu-devel] [PULL 10/26] qemu-iotests: Add _supported_os Linux to 058

2015-01-09 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com Other cases have this, and this test is not portable as well, as we want to add make check-block to make check, it shouldn't fail on Mac OS X. Reported-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan

[Qemu-devel] [PULL 11/26] tests/Makefile: Add check-block to make check on Linux

2015-01-09 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com make check-block does nothing on other platforms, but still takes some time to enumerate all the tests. So let's only add it for Linux for now. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/Makefile | 3 +++

[Qemu-devel] [PULL 08/26] .gitignore: Ignore generated common.env

2015-01-09 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e32a584..090f974 100644 --- a/.gitignore +++ b/.gitignore @@ -109,3 +109,4

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-09 Thread Kashyap Chamarthy
On Thu, Jan 08, 2015 at 06:04:20PM -0600, Gary R Hook wrote: On 1/8/15 2:21 PM, Kashyap Chamarthy wrote: qemu-img create -f qcow2 /tmp/dsk.test.qcow2 A typo? You also need to provide a size here: $ qemu-img create -f qcow2 /tmp/dsk.test.qcow2 1G Yes, my mistake. The size is set

[Qemu-devel] [PULL 14/26] qemu-thread: add per-thread atexit functions

2015-01-09 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com Destructors are the main additional feature of pthread TLS compared to __thread. If we were using C++ (hint, hint!) we could have used thread-local objects with a destructor. Since we are not, instead, we add a simple Notifier-based API. Note that the

[Qemu-devel] [PULL 26/26] NVMe: Set correct VS Value for 1.1 Compliant Controllers

2015-01-09 Thread Stefan Hajnoczi
From: Anubhav Rakshit anubhav.raks...@gmail.com According to NVMe specifications Bits 15:08 represent Minor Version number. Signed-off-by: Anubhav Rakshit anubhav.raks...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 15/26] test-coroutine: avoid overflow on 32-bit systems

2015-01-09 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com unsigned long is not large enough to represent 10 * duration there. Just use floating point. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com Message-id: 1417518350-6167-4-git-send-email-pbonz...@redhat.com

[Qemu-devel] [PULL 19/26] coroutine: try harder not to delete coroutines

2015-01-09 Thread Stefan Hajnoczi
From: Peter Lieven p...@kamp.de Placing coroutines on the global pool should be preferrable, because it can help all threads. But if the global pool is full, we can still try to save some allocations by stashing completed coroutines on the local pool. This is quite cheap too, because it does

[Qemu-devel] [PATCH] Allow the use of X11 from a non standard location.

2015-01-09 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- configure| 24 +++- hw/display/Makefile.objs |1 + 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/configure b/configure index cae588c..6c698ed 100755 --- a/configure +++ b/configure

Re: [Qemu-devel] [PULL] rng: fix parameter validation

2015-01-09 Thread Peter Maydell
On 5 January 2015 at 08:36, Amit Shah amit.s...@redhat.com wrote: The following changes since commit ab0302ee764fd702465aef6d88612cdff4302809: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20141223' into staging (2014-12-23 15:05:22 +) are available in the git

[Qemu-devel] [PULL 2/2] vfio-pci: Fix interrupt disabling

2015-01-09 Thread Alex Williamson
When disabling MSI/X interrupts the disable functions will leave the device in INTx mode (when available). This matches how hardware operates, INTx is enabled unless MSI/X is enabled (DisINTx is handled separately). Therefore when we really want to disable all interrupts, such as when removing

[Qemu-devel] [PULL 1/2] vfio-pci: Fix BAR size overflow

2015-01-09 Thread Alex Williamson
We use an unsigned int when working with the PCI BAR size, which can obviously overflow if the BAR is 4GB or larger. This needs to change to a fixed length uint64_t. A similar issue is possible, though even more unlikely, when mapping the region above an MSI-X table. The start of the MSI-X

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-09 Thread Don Slutz
Ping On 12/23/14 09:35, Don Slutz wrote: Ping. On 12/03/14 08:15, Don Slutz wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory. This way we can also avoid

[Qemu-devel] [Bug 1406016] Re: qemu-system-arm hangs at start on OS X

2015-01-09 Thread Joel Gallun
Peter, the bug occurs when mounting the rootfs. I can reproduce this bug too, with a kernel that works perfectly on QEMU on linux, windows and linux running on the same mac under vmware. In the case where I ran it under vmware on the mac the raspi kernel is the same file shared between the host

Re: [Qemu-devel] [PATCH] WIP: add GCoroutine support

2015-01-09 Thread Peter Maydell
On 9 January 2015 at 17:19, Marc-André Lureau marcandre.lur...@gmail.com wrote: Learn to use the GCoroutine library instead of qemu own coroutine implementation. GCoroutine is hosted on github: https://github.com/elmarco/gcoroutine This allows to share the same coroutine implementation

Re: [Qemu-devel] [PATCH 2/9] block-migration: fix pending() return value

2015-01-09 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Because of wrong return value of .save_live_pending() in block-migration, migration finishes before the whole disk is transferred. Such situation occures when the migration (occurs) process

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-01-09 Thread Denis V. Lunev
On 09/01/15 20:06, Michael Roth wrote: Quoting Denis V. Lunev (2014-12-31 07:06:46) hese patches for guest-agent add the functionality to execute commands on a guest UNIX machine. Hi Denis, Glad to see these getting picked up. I did at some point hack up a rewrite of the original code though

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-01-09 Thread Michael Roth
Quoting Denis V. Lunev (2014-12-31 07:06:46) hese patches for guest-agent add the functionality to execute commands on a guest UNIX machine. Hi Denis, Glad to see these getting picked up. I did at some point hack up a rewrite of the original code though which has some elements might be worth

[Qemu-devel] [PATCH] tcg-arm: more instruction execution control

2015-01-09 Thread Andrew Jones
Cleanup XN/PXN handling in get_phys_addr_lpae, and implement all but EL2 support of the following ARMv8 sections D4.5.1 Memory access control: Access permissions for instruction execution G4.7.2 Execute-never restrictions on instruction fetching G4.7.2 matches the ARMv7 section

Re: [Qemu-devel] Block filter status

2015-01-09 Thread Farr, Kaitlin M.
Hello, Is anyone working on block filters? If so, can you please tell me what the current progress is? I am referring to item BlockFilter and dynamic reconfiguration of the BDS graph on the to-do list [1]. Thanks for your time, Kaitlin Farr Software Engineer JHU/APL 1.

Re: [Qemu-devel] [PULL 0/9] Misc changes for 2015-01-03 (icount, migration, iscsi, sdhci-pci)

2015-01-09 Thread Peter Maydell
On 3 January 2015 at 08:45, Paolo Bonzini pbonz...@redhat.com wrote: The following changes since commit c95f3901b4ead79f3fe2c641fda7d2c70fc84c72: Merge remote-tracking branch 'remotes/kraxel/tags/pull-sdl-20141219-1' into staging (2014-12-21 23:17:00 +) are available in the git

[Qemu-devel] [PULL 0/2] vfio-pci fixes

2015-01-09 Thread Alex Williamson
The following changes since commit 59a0419856c9ed24e9ecd033db092b2e8f81a728: hw/ppc/mac_newworld: simplify usb controller creation logic (2015-01-08 17:32:27 +) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150109.0 for you to fetch

Re: [Qemu-devel] [PATCH v4] block: add event when disk usage exceeds threshold

2015-01-09 Thread Eric Blake
On 12/04/2014 01:59 AM, Francesco Romani wrote: Managing applications, like oVirt (http://www.ovirt.org), make extensive use of thin-provisioned disk images. To let the guest run smoothly and be not unnecessarily paused, oVirt sets a disk usage threshold (so called 'high water mark') based on

[Qemu-devel] [Bug 1406016] Re: qemu-system-arm hangs at start on OS X

2015-01-09 Thread Peter Maydell
brew install qemu --env=std --cc=gcc-4.2 Aha. Don't do that, that's an ancient gcc. Use the system 'clang' (which configure should pick by default). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH] WIP: add GCoroutine support

2015-01-09 Thread Marc-André Lureau
Learn to use the GCoroutine library instead of qemu own coroutine implementation. GCoroutine is hosted on github: https://github.com/elmarco/gcoroutine This allows to share the same coroutine implementation between various projects (gtk-vnc and spice-gtk). It is related to the effort to push

Re: [Qemu-devel] Patch Round-up for stable 2.1.3, freeze on 2015-01-14

2015-01-09 Thread Marcel Apfelbaum
On 01/08/2015 07:33 PM, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v2.1.3: https://github.com/mdroth/qemu/commits/stable-2.1-staging The release is planned for 2015-01-21: http://wiki.qemu.org/Planning/2.1 Please respond here or CC

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-01-09 Thread Eric Blake
On 01/09/2015 10:06 AM, Michael Roth wrote: The other one worth considering is allowing cmdline to simply be a string, to parse it into arguments using g_shell_parse_argv(), which should also be cross-platform. Please no. Passing an unparsed string and asking for platform-specific rules to

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-09 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sigh. Will look into this. -Don Slutz On 01/09/15 11:13, Eric Blake wrote: On 01/09/2015 08:28 AM, Don Slutz wrote: [an encrypted message] Oops, you probably want to fix your Thunderbird/Enigmail settings to sign but not encrypt when a

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2015-01-09 Thread Michael Roth
Quoting Claudio Fontana (2015-01-09 08:57:39) Hello, resurrecting an old thread.. I incurred in the same issue being discussed before, where QEMU silently ignores PCI BAR address programming attempts where the I/O space offset is 0 (zero). I think that from a QEMU user standpoint, beside

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-09 Thread Programmingkid
On Jan 9, 2015, at 3:58 AM, Gerd Hoffmann wrote: On Do, 2015-01-08 at 12:07 -0500, Programmingkid wrote: On Jan 8, 2015, at 4:02 AM, Gerd Hoffmann wrote: Hi, VGA: Using shared surface for depth=32 swap=1 Ok, 32bpp. byteswapping needed. I guess the host is a intel macintosh then?

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-09 Thread Don Slutz
binjhymGgf_MN.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 15:52 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: On 9 January 2015 at 15:41, Frediano Ziglio fredd...@gmail.com wrote: 2015-01-09 12:22 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: +/* Optimised x64 version. This assume that a*b/c fits in 64 bit */ This assumption isn't

Re: [Qemu-devel] [PATCH] x86_64: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Richard Henderson
On 01/09/2015 01:53 AM, Frediano Ziglio wrote: As this platform can do multiply/divide using 128 bit precision use these instruction to implement it. Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 13 + 1 file changed, 13 insertions(+)

Re: [Qemu-devel] [PULL] virtio-serial migration fix on bi-endian targets

2015-01-09 Thread Peter Maydell
On 5 January 2015 at 07:31, Amit Shah amit.s...@redhat.com wrote: The following changes since commit ab0302ee764fd702465aef6d88612cdff4302809: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20141223' into staging (2014-12-23 15:05:22 +) are available in the git

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-09 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/09/15 13:02, Don Slutz wrote: Sigh. Will look into this. -Don Slutz Here is what I said (un-encrypeted): On 01/08/15 11:41, Eric Blake wrote: On 01/08/2015 07:40 AM, Peter Maydell wrote: On 8 January 2015 at 14:30, Don Slutz

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-01-09 Thread Michael Roth
Quoting Denis V. Lunev (2015-01-09 12:09:10) On 09/01/15 20:06, Michael Roth wrote: Quoting Denis V. Lunev (2014-12-31 07:06:46) hese patches for guest-agent add the functionality to execute commands on a guest UNIX machine. Hi Denis, Glad to see these getting picked up. I did at some

[Qemu-devel] [Bug 1406016] Re: qemu-system-arm hangs at start on OS X

2015-01-09 Thread Joel Gallun
Thanks for the quick response. Being a total mac n00b I just followed the directions in the top google link for installing qemu on os x and I ended up where I did. I replaced the old version of the qemu formula in my brew library with the current one and re-installed and all is well, running qemu

Re: [Qemu-devel] Patch Round-up for stable 2.1.3, freeze on 2015-01-14

2015-01-09 Thread Paolo Bonzini
On 09/01/2015 18:27, Marcel Apfelbaum wrote: Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be included in the release. I think that also this patch should be added: [Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config

Re: [Qemu-devel] [PATCH] Allow the use of X11 from a non standard location.

2015-01-09 Thread Paolo Bonzini
On 09/01/2015 20:08, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com --- configure| 24 +++- hw/display/Makefile.objs |1 + 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PULL 00/10] Linked list for tcg ops

2015-01-09 Thread Richard Henderson
15:05:22 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/tcg-pull-20150109 for you to fetch changes up to 62c2b6e35e872c87a111856a2798c21c458a68ab: tcg: Further optimizations for add2 and sub2_i32 (2015-01-05 12:22:45 -0800

[Qemu-devel] [PULL 03/10] tcg: Move emit of INDEX_op_end into gen_tb_end

2015-01-09 Thread Richard Henderson
Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/gen-icount.h | 2 ++ target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 1 - target-arm/translate.c| 1 - target-cris/translate.c

[Qemu-devel] [PULL 02/10] tcg: Reduce ifdefs in tcg-op.c

2015-01-09 Thread Richard Henderson
Almost completely eliminates the ifdefs in this file, improving confidence in the lesser used 32-bit builds. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-op.c | 449

[Qemu-devel] [PULL 06/10] tcg: Remove opcodes instead of noping them out

2015-01-09 Thread Richard Henderson
With the linked list scheme we need not leave nops in the stream that we need to process later. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 14 +++--- tcg/tcg.c | 28

[Qemu-devel] [PULL 04/10] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full

2015-01-09 Thread Richard Henderson
The method by which we count the number of ops emitted is going to change. Abstract that away into some inlines. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 14 +++---

[Qemu-devel] [PULL 08/10] tcg: Remove unused opcodes

2015-01-09 Thread Richard Henderson
We no longer need INDEX_op_end to terminate the list, nor do we need 5 forms of nop, since we just remove the TCGOp instead. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-opc.h | 9 - tcg/tcg.c | 7

[Qemu-devel] [PULL 10/10] tcg: Further optimizations for add2 and sub2_i32

2015-01-09 Thread Richard Henderson
Notice when the low parts of the operation cannot cause overflow, and thus reduce the high part to a simple add/sub. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 83 +++--- 1 file changed, 62 insertions(+), 21

[Qemu-devel] [PULL 07/10] tcg: Implement insert_op_before

2015-01-09 Thread Richard Henderson
Rather reserving space in the op stream for optimization, let the optimizer add ops as necessary. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 57 +++-- tcg/tcg-op.c | 21 - tcg/tcg-op.h | 1 -

[Qemu-devel] [PULL 09/10] tcg: Optimize muls2_i32

2015-01-09 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 067917c..c674fe2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1160,15 +1160,22 @@ static void

[Qemu-devel] [PULL 05/10] tcg: Put opcodes in a linked list

2015-01-09 Thread Richard Henderson
The previous setup required ops and args to be completely sequential, and was error prone when it came to both iteration and optimization. Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/gen-icount.h | 22 ++- tcg/optimize.c| 286

Re: [Qemu-devel] [PATCH RESEND 0/2] PoC: Block replication for continuous checkpointing

2015-01-09 Thread Hongyang Yang
Hi Paolo, Seems there are no more comments for now. We are going to implement COLO Disk replication as you suggested. And I add your comments to the design doc, thank you! 在 12/27/2014 11:23 PM, Paolo Bonzini 写道: On 26/12/2014 04:31, Yang Hongyang wrote: Please feel free to comment. We

[Qemu-devel] [PULL 00/26] Block patches

2015-01-09 Thread Stefan Hajnoczi
This pull request depends on the previous block pull request which has not been merged yet. It was sent on Monday, 5th of January (Message-id: 1420458696-1885-1-git-send-email-stefa...@redhat.com). The following changes since commit 3bd54e576f40f1d5bf45b4828c7316efd76a4db6: migration/block:

[Qemu-devel] [PULL 03/26] tests: Prepare virtio-blk-test for multi-arch implementation

2015-01-09 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/virtio-blk-test.c | 146

[Qemu-devel] [PULL 02/26] libqos: Change use of pointers to uint64_t in virtio

2015-01-09 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com

[Qemu-devel] [PULL 13/26] coroutine-ucontext: use __thread

2015-01-09 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com ELF thread local storage is about 10% faster on tests/test-coroutine's perf/cost test. The timing on my machine is 190ns per iteration with pthread TLS, 170 with ELF TLS. Based on a patch by Kevin Wolf and Peter Lieven, but redone to follow the model of

[Qemu-devel] [PULL 01/26] libqos: Convert malloc-pc allocator to a generic allocator

2015-01-09 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com The allocator in malloc-pc has been extracted, so it can be used in every arch. This operation showed that both the alloc and free functions can be also generic. Because of this, the QGuestAllocator has been removed from is function to wrap the alloc

[Qemu-devel] [PULL 04/26] libqos: Remove PCI assumptions in constants of virtio driver

2015-01-09 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/libqos/virtio-pci.c | 30 +++---

[Qemu-devel] [PULL 05/26] libqos: Add malloc generic

2015-01-09 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan

[Qemu-devel] [PULL 07/26] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-09 Thread Stefan Hajnoczi
From: Programmingkid programmingk...@gmail.com Signed-off-by: John Arbuckle programmingk...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/raw-posix.c | 18 +- configure | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 21/26] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET}

2015-01-09 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com Like BLOCK_OP_TYPE_BACKUP_SOURCE and BLOCK_OP_TYPE_BACKUP_TARGET, block-commit involves two asymmetric devices. This change is not user-visible (yet), because commit only works with device names. But once we enable backing reference in blockdev-add, or specifying

[Qemu-devel] Question and probable bug in qemu spice's parameters

2015-01-09 Thread Fabio Fantoni
In qemu docs seems that spice streaming video is default to filter but after this patch seems default to off without updating qemu-options.hx file: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=f1d3e586f069e17f83b669842bc02d60d509daca What is the correct default actually? If I specify spice

  1   2   >