[Qemu-devel] [PATCH] vl.c: fix regression when reading memory size from config file

2015-01-11 Thread Marcel Apfelbaum
This is happening because an actual logic is performed on the memory arguments inside the main's switch, disregarding the config file content. Solved by extracting the logic on a separate function and calling it after the switch. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- vl.c | 176

Re: [Qemu-devel] [PATCH v2] vl.c: fix some alignment issues

2015-01-11 Thread Stefan Weil
Am 11.01.2015 um 11:56 schrieb Marcel Apfelbaum: The misalignment was caused by tabs which were used instead of spaces. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- v1 - v2: - Addressed Stefan Weil's comments: - Hunted all the tabs within the

[Qemu-devel] [PATCH] vl.c: fix some alignment issues

2015-01-11 Thread Marcel Apfelbaum
The main's switch had a few cases misaligned. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- vl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index 7786b2f..adfdbfd 100644 --- a/vl.c +++ b/vl.c @@ -3147,9 +3147,9 @@ int main(int argc, char

Re: [Qemu-devel] [PATCH] vl.c: fix some alignment issues

2015-01-11 Thread Stefan Weil
Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum: The main's switch had a few cases misaligned. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- vl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Stefan Weil s...@weilnetz.de The misalignment was

Re: [Qemu-devel] [PATCH] vl.c: fix some alignment issues

2015-01-11 Thread Marcel Apfelbaum
On 01/11/2015 12:06 PM, Stefan Weil wrote: Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum: The main's switch had a few cases misaligned. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- vl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Stefan Weil

[Qemu-devel] [PATCH v2] vl.c: fix some alignment issues

2015-01-11 Thread Marcel Apfelbaum
The misalignment was caused by tabs which were used instead of spaces. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- v1 - v2: - Addressed Stefan Weil's comments: - Hunted all the tabs within the switch/main vl.c | 38 +++--- 1 file changed, 19

Re: [Qemu-devel] Please update Pixman submodule

2015-01-11 Thread Programmingkid
On Jan 11, 2015, at 1:40 PM, Peter Maydell wrote: On 11 January 2015 at 18:23, Programmingkid programmingk...@gmail.com wrote: The Pixman version that installs with this command has issues: (2) Fetch the pixman submodule, using: git submodule update --init pixman It does not

Re: [Qemu-devel] [PULL 0/2] vfio-pci fixes

2015-01-11 Thread Peter Maydell
On 9 January 2015 at 16:30, Alex Williamson alex.william...@redhat.com wrote: The following changes since commit 59a0419856c9ed24e9ecd033db092b2e8f81a728: hw/ppc/mac_newworld: simplify usb controller creation logic (2015-01-08 17:32:27 +) are available in the git repository at:

[Qemu-devel] Please update Pixman submodule

2015-01-11 Thread Programmingkid
The Pixman version that installs with this command has issues: (2) Fetch the pixman submodule, using: git submodule update --init pixman It does not compile on Mac OS X. The newest version from here does compile: git://anongit.freedesktop.org/pixman It would help a lot if someone

Re: [Qemu-devel] Please update Pixman submodule

2015-01-11 Thread Peter Maydell
On 11 January 2015 at 18:23, Programmingkid programmingk...@gmail.com wrote: The Pixman version that installs with this command has issues: (2) Fetch the pixman submodule, using: git submodule update --init pixman It does not compile on Mac OS X. The newest version from here does

Re: [Qemu-devel] Please update Pixman submodule

2015-01-11 Thread Peter Maydell
On 11 January 2015 at 19:44, Programmingkid programmingk...@gmail.com wrote: On Jan 11, 2015, at 1:40 PM, Peter Maydell wrote: Personally I build with the OSX pixman, which I think is provided as part of XQuartz these days. I did a test build without the system pixman, though, and it does

[Qemu-devel] [Bug 1362755] Re: QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2015-01-11 Thread Thiago Martins
Hey guys! From what I'm seeing, this problem does not affect Ubuntu Vivid with Linux 3.18 (and with systemd = PID1). I'll do more tests tomorrow, but with Linux 3.18 on Trusty (upstart = PID1), just to make sure that this is a Linux problem (and not related to QEmu itself). Cheers! Thiago --

[Qemu-devel] [PATCH 1/3] rules.mak: Fix module build

2015-01-11 Thread Fam Zheng
Module build is broken since commit c261d774fb ( rules.mak: Fix DSO build by pulling in archive symbols). That commit added .mo placeholders of DSO to -y variables, in order to pull stub symbols to executable. But the placeholders are unintentionally expanded in -y, rather than filtered out while

[Qemu-devel] [PATCH 0/3] buildsys: Fix and enable module build

2015-01-11 Thread Fam Zheng
The first patch fixes the module build: it doesn't fail but it links all the module objects into executables. The second patch enables modules by default. The last patch adds a non-module build in travis config. Fam Zheng (3): rules.mak: Fix module build configure: Default to enable module

[Qemu-devel] [RFC PATCH 4/4] vfio-pci: pass the aer error to guest

2015-01-11 Thread Chen Fan
when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and have the guest driver recover from the error.

[Qemu-devel] [RFC PATCH 2/4] pcie-aer: Fix command pcie_aer_inject_error is invalid

2015-01-11 Thread Chen Fan
in spec PCI Express 3.0 section 6.2.6 Figure 6-3 virtual bridge part, the flowchart showing tell us SERR# enable at Bridge Control register associate with system error at Secondary Status register can send error message. but bridge_control from dev-config is NULL, and SERR# was set in dev-wmask in

Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2015-01-11 Thread AMULYA L
Please find comments inline -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Jeff Cody Sent: Wednesday, January 07, 2015 9:11 PM To: Lokesha, Amulya Subject: Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size On Wed, Jan 07, 2015 at

Re: [Qemu-devel] [Makefile] Compiling Qemu to dynamic library

2015-01-11 Thread Halsey Pian
Hi All, I have a workaround solution to achieve this. I could just get all the object files required by specific platform executable binary by adding some codes in Makefile, and then compile them to the dynamic library. Sorry for reading this mail thread. Please ignore it. Thanks!

Re: [Qemu-devel] [PATCH 0/2] pcie-aer: Fix command pcie_aer_inject_error invalid

2015-01-11 Thread Chen, Fan
Hi all, I have sent another patches to implement pass aer error to guest including this patches, so please ignore this. Thanks, Chen On Wed, 2014-11-19 at 12:10 +0800, Chen Fan wrote: set each patch details. Chen Fan (2): pcie_aer: fix typos in pcie_aer_inject_error comment

[Qemu-devel] [PATCH] Makes -full-screen option work on Mac OS X

2015-01-11 Thread Programmingkid
This patch makes the -full-screen option work under Mac OS X. Signed-off-by: John Arbuckle programmingk...@gmail.com --- ui/cocoa.m | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 685081e..3a70cfc 100644 ---

[Qemu-devel] [RFC PATCH 3/4] vfio-pci: add aer capability support

2015-01-11 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/vfio/pci.c | 40 1 file changed, 40 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index b4e73d1..0ee6326 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2667,6 +2667,41 @@ static

[Qemu-devel] [RFC PATCH 0/4] pass aer error to guest

2015-01-11 Thread Chen Fan
For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error occured but stop the guest, so this patch add aer capability support for vfio device, and pass the error to guest, and have guest

[Qemu-devel] [RFC PATCH 1/4] pcie_aer: fix typos in pcie_aer_inject_error comment

2015-01-11 Thread Chen Fan
Refer to PCI Express Base Spec3.0, this comments can't fit the description in spec, so we should fix them. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/pci/pcie_aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c

[Qemu-devel] [PATCH 3/3] .travis.yml: Add --disable-modules

2015-01-11 Thread Fam Zheng
Now we default to --enable-modules, let's cover the old way in travis. Signed-off-by: Fam Zheng f...@redhat.com --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index ad66e5b..12bf1db 100644 --- a/.travis.yml +++ b/.travis.yml @@ -98,3 +98,6 @@

[Qemu-devel] [PATCH 2/3] configure: Default to enable module build

2015-01-11 Thread Fam Zheng
We have module build support around for a while, but also had it bitrot several times. It probably makes sense to enable it by default so that people can notice and use it. Counterpart to --enable-modules, which is turned as default, --disable-modules is added to suppress it. If both are omitted,

[Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-01-11 Thread Yi Wang
From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001 From: Yi Wang up2w...@gmail.com Date: Mon, 12 Jan 2015 00:05:40 +0800 Subject: [PATCH] savevm: create snapshot failed when id_str already exits Create snapshot failed in this case: 1) vm has two or more qcow2 disks; 2) the

[Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-11 Thread Bharata B Rao
Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed by PowerPC memory hotplug code too. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- hw/i386/pc.c | 24 hw/mem/pc-dimm.c | 25 +

[Qemu-devel] [PATCH v0 0/2] Fix pc DIMMs capacity calculation

2015-01-11 Thread Bharata B Rao
1st patch fixes PC DIMMs capacity calculation and the 2nd patch does code movement so that pc_existing_dimms_capacity() can be used by other architectures. Bharata B Rao (2): pc: Fix DIMMs capacity calculation pc-dimm: Make pc_existing_dimms_capacity global hw/i386/pc.c | 36

[Qemu-devel] [PATCH v0 1/2] pc: Fix DIMMs capacity calculation

2015-01-11 Thread Bharata B Rao
pc_existing_dimms_capacity() is returning DIMMs count rather than capacity. Fix this to return the capacity. Also consider only realized devices for capacity calculation. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- hw/i386/pc.c | 26 ++ 1 file changed, 10

[Qemu-devel] [Bug 1406706] Re: guest will be destroyed when create guest with parameter -usbdevice tablet.

2015-01-11 Thread chao zhou
kvm.git+ qemu.git:bab5bb39_64ea8038 kernel:3.19.0-rc3 create guest with parameter -usbdevice tablet , the guest works fine. ** Changed in: qemu Status: New = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Does kvm friendly support GPT?

2015-01-11 Thread Zhang Haoyu
On 2014-12-22 09:28:52, Paolo Bonzini wrote: On 22/12/2014 07:39, Zhang Haoyu wrote: Hi, When I perform P2V from native servers with win2008 to kvm vm, some cases failed due to the physical disk was using GPT for partition, and QEMU doesn't support GPT by default. And, I see in below

[Qemu-devel] How to clone a running vm?

2015-01-11 Thread Zhang Haoyu
Hi, I want to clone a running vm without shutoff, can below method work? 1) create a snapshot for the vm 2) create a new qcow2 image from the snapshot, but how? 3) use the new qcow2 image as backing image to clone vms Any ideas? Thanks, Zhang Haoyu

Re: [Qemu-devel] [PATCH 0/3] buildsys: Fix and enable module build

2015-01-11 Thread Bharata B Rao
On Mon, Jan 12, 2015 at 10:13 AM, Fam Zheng f...@redhat.com wrote: The first patch fixes the module build: it doesn't fail but it links all the module objects into executables. The second patch enables modules by default. The last patch adds a non-module build in travis config. Tested and