Re: [Qemu-devel] [PATCH v9 0/7] Netduino 2 Machine Model

2015-01-23 Thread Alistair Francis
On Sat, Jan 24, 2015 at 4:25 AM, Peter Maydell wrote: > On 7 January 2015 at 21:21, Alistair Francis wrote: >> This patch series adds the Netduino 2 Machine to QEMU >> >> Information on the board is avalible at: >> http://www.netduino.com/netduino2/specs.htm >> >> The git tree can be found at: >>

[Qemu-devel] [Bug 1412098] Re: qemu crashes when ctrl-alt-u is pressed

2015-01-23 Thread Legorol
I did a git bisect, and the offending commit appears to be this one: author Gerd Hoffmann Wed, 18 Jun 2014 09:03:15 + (11:03 +0200) committer Gerd Hoffmann Fri, 5 Sep 2014 11:27:11 + (13:27 +0200) commit 30f1e661b640de58ba1e8178f7f2290179a7e01c treedc373a0d37438

[Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu

2015-01-23 Thread Programmingkid
This patch adds these consoles to the View menu: VGA QEMU Monitor Parallel Serial Signed-off-by: John Arbuckle --- ui/cocoa.m | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index d37c29b..c88c0d0 100644 --- a/ui

Re: [Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 21:44, Greg Bellows wrote: > On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell > wrote: >> +typedef enum ARMMMUIdx { >> +ARMMMUIdx_S12NSE0 = 0, >> +ARMMMUIdx_S12NSE1 = 1, >> +ARMMMUIdx_S1E2 = 2, >> +ARMMMUIdx_S1E3 = 3, >> +ARMMMUIdx_S1SE0 = 4, >> +ARMMM

Re: [Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 20:16, Greg Bellows wrote: > On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell > wrote: >> Support guest CPUs which need 7 MMU index values. >> Add a comment about what would be required to raise the limit >> further (trivial for 8, TCG backend rework for 9 or more). >> >> Sig

[Qemu-devel] [Bug 1414222] [NEW] qemu-system-i386: -vnc localhost:0, to=99, id=default: Invalid parameter 'to'

2015-01-23 Thread Don Slutz
Public bug reported: git bisect points to: 4db14629c38611061fc19ec6927405923de84f08 is the first bad commit commit 4db14629c38611061fc19ec6927405923de84f08 Author: Gerd Hoffmann Date: Tue Sep 16 12:33:03 2014 +0200 vnc: switch to QemuOpts, allow multiple servers This patch switches v

[Qemu-devel] [Bug 1414222] Re: qemu-system-i386: -vnc localhost:0, to=99, id=default: Invalid parameter 'to'

2015-01-23 Thread Don Slutz
-vnc 127.0.0.1:0,to=99 is used by Xen -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1414222 Title: qemu-system-i386: -vnc localhost:0,to=99,id=default: Invalid parameter 'to' Status in QEMU: N

Re: [Qemu-devel] [PATCH 2/2] hw/ppc/spapr Add qemu_register_boot_set for SPAPR

2015-01-23 Thread Alexander Graf
On 23.01.15 23:51, dval...@suse.de wrote: > From: Dinar Valeev > > In order to have -boot once=d functioning, it is required to have > qemu_register_boot_set > > qemu-system-ppc64 -enable-kvm -boot once=d > > Ready! > 0 > dev /chosen ok > 0 > .properties > ... > qemu,boot-device

Re: [Qemu-devel] [PATCH 1/2] hw/ppc/spapr.c Set default boot order

2015-01-23 Thread Alexander Graf
On 23.01.15 23:51, dval...@suse.de wrote: > From: Dinar Valeev > > In order to use -boot once=X option we need to have default list > where restore to on reset. > > Signed-off-by: Dinar Valeev Alexey, Nijunj, where is the default boot order stored usually? Is "cdn" an accurate equivalent?

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Programmingkid
On Jan 23, 2015, at 4:48 PM, Paolo Bonzini wrote: > > > On 23/01/2015 22:37, Paolo Bonzini wrote: >> >> >> On 23/01/2015 22:33, Programmingkid wrote: Use clang then. >>> >>> Could you provide directions on how you want me to do this? In the >>> configure options, this was all I found:

[Qemu-devel] [PATCH 2/2] hw/ppc/spapr Add qemu_register_boot_set for SPAPR

2015-01-23 Thread dvaleev
From: Dinar Valeev In order to have -boot once=d functioning, it is required to have qemu_register_boot_set qemu-system-ppc64 -enable-kvm -boot once=d Ready! 0 > dev /chosen ok 0 > .properties ... qemu,boot-device d ... 0 > reset-all Ready! 0 > dev /chosen ok 0 > .propertie

[Qemu-devel] [PATCH 1/2] hw/ppc/spapr.c Set default boot order

2015-01-23 Thread dvaleev
From: Dinar Valeev In order to use -boot once=X option we need to have default list where restore to on reset. Signed-off-by: Dinar Valeev --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index b560459..3d2cfa3 100644 --- a

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Paolo Bonzini
On 23/01/2015 22:37, Paolo Bonzini wrote: > > > On 23/01/2015 22:33, Programmingkid wrote: >>> Use clang then. >> >> Could you provide directions on how you want me to do this? In the configure >> options, this was all I found: >> --objcc=OBJCCuse Objective-C compiler OBJCC [cla

Re: [Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags

2015-01-23 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > We currently claim that for ARM the mmu_idx should simply be the current > exception level. However this isn't actually correct -- secure EL0 and EL1 > should have separate indexes from non-secure EL0 and EL1 since their > VA->PA mappings ma

Re: [Qemu-devel] [PATCH 02/11] target-arm: Make arm_current_el() return sensible values for M profile

2015-01-23 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > Although M profile doesn't have the same concept of exception level > as A profile, it does have a notion of privileged versus not, which > we currently track in the privmode TB flag. Support returning this > information if arm_current_el()

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Paolo Bonzini
On 23/01/2015 22:33, Programmingkid wrote: > > Use clang then. > > Could you provide directions on how you want me to do this? In the configure > options, this was all I found: > --objcc=OBJCCuse Objective-C compiler OBJCC [clang] ./configure --cc=clang --cxx=clang++ But QEMU u

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Programmingkid
On Jan 23, 2015, at 3:55 PM, Paolo Bonzini wrote: > > > On 23/01/2015 21:39, Programmingkid wrote: >> On 23/01/2015 20:27, Programmingkid wrote: >>> I used the newest version from QEMU's git with this id: >>> a46b3aaf6bb038d4f6f192a84df204f10929e75c. When I tried to compile >>> QEMU on Mac OS 1

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Chen Gang S
On 1/23/15 21:55, Peter Maydell wrote: > On 23 January 2015 at 14:01, Chen Gang S wrote: >> What I shall do for tile qemu should obey the related license of qemu >> (all the related code should belong to qemu upstream). If necessary to >> follow some copyright working flow, please let me know, I s

[Qemu-devel] [PATCH V3 2/4] kvm_stat: Print errno when syscall to perf_event_open() fails

2015-01-23 Thread Wei Huang
kvm_stat uses syscall() to call perf_event_open(). If this function call fails, the returned value is -1, which doesn't tell the details of the failure (i.e. ENOSYS or EINVAL). This patch retrieves errno and prints it when syscall() fails. The error message will look like "Exception: perf_event_ope

Re: [Qemu-devel] [PATCH V2 0/4] kvm_stat update

2015-01-23 Thread Wei Huang
Sorry, please ignore this version. -Wei On 01/23/2015 02:44 PM, Wei Huang wrote: > This is the second version of kvm_stat patches. Please review. > > NOTE: I have tested these patches on ARM64 and x86_64 machines. For PPC, > the only area been affected is ioctl RESET number (patch 4). Unfortuna

[Qemu-devel] [PATCH V3 1/4] kvm_stat: Update exit reasons to the latest defintion

2015-01-23 Thread Wei Huang
This patch updates the exit reasons for x86_vmx, x86_svm, and userspace to the latest definition. Signed-off-by: Wei Huang --- scripts/kvm/kvm_stat | 4 1 file changed, 4 insertions(+) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 7b1437c..7ec84c0 100755 --- a/scripts/kvm/

[Qemu-devel] [PATCH V3 3/4] kvm_stat: Add aarch64 support

2015-01-23 Thread Wei Huang
This patch enables aarch64 support for kvm_stat. The platform detection is based on OS uname. Signed-off-by: Wei Huang --- scripts/kvm/kvm_stat | 8 1 file changed, 8 insertions(+) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index cb23877..8f6f007 100755 --- a/scripts/kvm/

[Qemu-devel] [PATCH V3 4/4] kvm_stat: Add RESET support for perf event ioctl

2015-01-23 Thread Wei Huang
While running kvm_stat using tracepoint on ARM64 hardware (e.g. "kvm_stat -1 -t"), the initial values of some kvm_userspace_exit counters were found to be very suspecious. For instance the tracing tool showed that S390_TSCH was called many times on ARM64 machine, which apparently was wrong. This p

Re: [Qemu-devel] [PATCH 03/11] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT

2015-01-23 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > The LDT/STT (load/store unprivileged) instruction decode was using > the wrong MMU index value. This meant that instead of these insns > being "always access as if user-mode regardless of current privilege" > they were "always access as if k

[Qemu-devel] [PATCH V3 0/4] kvm_stat update

2015-01-23 Thread Wei Huang
This is the third version of kvm_stat patches. Please review. NOTE: I have tested these patches on ARM64 and x86_64 machines. For PPC, the only area been affected is ioctl RESET number (patch 4). Unfortunately I don't have PPC hardware to test them. Thanks, -Wei V3: - fix a comment in patch #4

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Paolo Bonzini
On 23/01/2015 21:39, Programmingkid wrote: > On 23/01/2015 20:27, Programmingkid wrote: >> I used the newest version from QEMU's git with this id: >> a46b3aaf6bb038d4f6f192a84df204f10929e75c. When I tried to compile >> QEMU on Mac OS 10.6.8, I saw this error: qemu-coroutine.c:29: error: >> thread

[Qemu-devel] makefile help: giving QEMU an icon

2015-01-23 Thread Programmingkid
I'm trying to make QEMU have an icon instead of the standard gray box icon it is given on Mac OS X. I figured out where to put the code in the makefile, but this location isn't useful. git is trained not to use it. The location is ./ppc-softmmu/makefile. My question is where do I put my icon set

Re: [Qemu-devel] [PATCH 2/3] kvm_stat: Update exit reasons to the latest defintion

2015-01-23 Thread Wei Huang
Hi Paolo, I just sent out the second revision. You can cherry-pick the patch 04 if you have already queued my previous 3 patches. Thanks for your review. -Wei On 01/22/2015 09:23 AM, Wei Huang wrote: > On 01/22/2015 06:56 AM, Paolo Bonzini wrote: >> >> >> On 21/01/2015 22:15, Wei Huang wrote: >>

[Qemu-devel] [PATCH V2 3/4] kvm_stat: Add aarch64 support

2015-01-23 Thread Wei Huang
This patch enables aarch64 support for kvm_stat. The platform detection is based on OS uname. Signed-off-by: Wei Huang --- scripts/kvm/kvm_stat | 8 1 file changed, 8 insertions(+) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index cb23877..8f6f007 100755 --- a/scripts/kvm/

[Qemu-devel] [PATCH V2 2/4] kvm_stat: Print errno when syscall to perf_event_open() fails

2015-01-23 Thread Wei Huang
kvm_stat uses syscall() to call perf_event_open(). If this function call fails, the returned value is -1, which doesn't tell the details of the failure (i.e. ENOSYS or EINVAL). This patch retrieves errno and prints it when syscall() fails. The error message will look like "Exception: perf_event_ope

[Qemu-devel] [PATCH V2 4/4] kvm_stat: Add RESET support for perf event ioctl

2015-01-23 Thread Wei Huang
While running kvm_stat using tracepoint on ARM64 hardware (e.g. "kvm_stat -1 -t"), the initial values of some kvm_userspace_exit counters were found to be very suspecious. For instance the tracing tool showed that S390_TSCH was called many times on ARM64 machine, which apparently was wrong. This p

[Qemu-devel] [PATCH V2 1/4] kvm_stat: Update exit reasons to the latest defintion

2015-01-23 Thread Wei Huang
This patch updates the exit reasons for x86_vmx, x86_svm, and userspace to the latest definition. Signed-off-by: Wei Huang --- scripts/kvm/kvm_stat | 4 1 file changed, 4 insertions(+) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 7b1437c..7ec84c0 100755 --- a/scripts/kvm/

[Qemu-devel] [PATCH V2 0/4] kvm_stat update

2015-01-23 Thread Wei Huang
This is the second version of kvm_stat patches. Please review. NOTE: I have tested these patches on ARM64 and x86_64 machines. For PPC, the only area been affected is ioctl RESET number (patch 4). Unfortunately I don't have PPC hardware to test them. Thanks, -Wei V2: - fix a typo in VMX exit

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Programmingkid
On Jan 23, 2015, at 3:33 PM, Paolo Bonzini wrote: > > > On 23/01/2015 20:27, Programmingkid wrote: >> I used the newest version from QEMU's git with this id: >> a46b3aaf6bb038d4f6f192a84df204f10929e75c. When I tried to compile >> QEMU on Mac OS 10.6.8, I saw this error: qemu-coroutine.c:29: err

Re: [Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Paolo Bonzini
On 23/01/2015 20:27, Programmingkid wrote: > I used the newest version from QEMU's git with this id: > a46b3aaf6bb038d4f6f192a84df204f10929e75c. When I tried to compile > QEMU on Mac OS 10.6.8, I saw this error: qemu-coroutine.c:29: error: > thread-local storage not supported for this target. GC

Re: [Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7

2015-01-23 Thread Paolo Bonzini
On 23/01/2015 19:20, Peter Maydell wrote: > Support guest CPUs which need 7 MMU index values. > Add a comment about what would be required to raise the limit > further (trivial for 8, TCG backend rework for 9 or more). > > Signed-off-by: Peter Maydell I'll send a patch for 16 next Monday. Pao

Re: [Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7

2015-01-23 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > Support guest CPUs which need 7 MMU index values. > Add a comment about what would be required to raise the limit > further (trivial for 8, TCG backend rework for 9 or more). > > Signed-off-by: Peter Maydell > --- > include/exec/cpu_ldst.h

[Qemu-devel] [PATCH] iotests: Specify format for qemu-nbd

2015-01-23 Thread Max Reitz
This patch is necessary to suppress the "probed raw" warning when running raw over nbd tests. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index aa093d9..2

[Qemu-devel] qemu-coroutine.c: error: thread-local storage not supported for this target

2015-01-23 Thread Programmingkid
I used the newest version from QEMU's git with this id: a46b3aaf6bb038d4f6f192a84df204f10929e75c. When I tried to compile QEMU on Mac OS 10.6.8, I saw this error: qemu-coroutine.c:29: error: thread-local storage not supported for this target.

Re: [Qemu-devel] [PATCH v2] fix QEMU build on Xen/ARM

2015-01-23 Thread Don Slutz
On 01/23/15 07:19, Stefano Stabellini wrote: > xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an > unsigned long argument (in fact xen_pfn_t is defined as uint64_t on > ARM). > > Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. > > Signed-off-by: Stefano Stab

[Qemu-devel] [PATCH 02/11] target-arm: Make arm_current_el() return sensible values for M profile

2015-01-23 Thread Peter Maydell
Although M profile doesn't have the same concept of exception level as A profile, it does have a notion of privileged versus not, which we currently track in the privmode TB flag. Support returning this information if arm_current_el() is called on an M profile core, so that we can identify the corr

Re: [Qemu-devel] [PATCH v9 0/7] Netduino 2 Machine Model

2015-01-23 Thread Peter Maydell
On 7 January 2015 at 21:21, Alistair Francis wrote: > This patch series adds the Netduino 2 Machine to QEMU > > Information on the board is avalible at: > http://www.netduino.com/netduino2/specs.htm > > The git tree can be found at: > https://github.com/alistair23/qemu/tree/netduino2.9 > > This pa

[Qemu-devel] [PATCH 11/11] target-arm: Fix brace style in reindented code

2015-01-23 Thread Peter Maydell
This patch fixes the brace style in the code reindented in the previous commit. Signed-off-by: Peter Maydell --- target-arm/helper.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 3a23af8.

[Qemu-devel] [PULL 07/12] block: qapi - move string allocation from stack to the heap

2015-01-23 Thread Kevin Wolf
From: Jeff Cody Rather than declaring 'backing_filename2' on the stack in bdrv_query_image_info(), dynamically allocate it on the heap. Reviewed-by: John Snow Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/qapi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PATCH 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores

2015-01-23 Thread Peter Maydell
The MMU index to use for unprivileged loads and stores is more complicated than we currently implement: * for A64, it should be "if at EL1, access as if EL0; otherwise access at current EL" * for A32/T32, it should be "if EL2, UNPREDICTABLE; otherwise access as if at EL0". In both cases, i

[Qemu-devel] [PATCH 06/11] target-arm: Don't define any MMU_MODE*_SUFFIXes

2015-01-23 Thread Peter Maydell
target-arm doesn't use any of the MMU-mode specific cpu ldst accessor functions. Suppress their generation by not defining any of the MMU_MODE*_SUFFIX macros. ("user" and "kernel" are too simplistic as descriptions of indexes 0 and 1 anyway.) Signed-off-by: Peter Maydell --- target-arm/cpu.h | 2

[Qemu-devel] [PULL 09/12] block: mirror - change string allocation to 2-bytes

2015-01-23 Thread Kevin Wolf
From: Jeff Cody The backing_filename string in mirror_run() is only used to check for a NULL string, so we don't need to allocate 1024 bytes (or, later, PATH_MAX bytes), when we only need to copy the first 2 characters. We technically only need 1 byte, as we are just checking for NULL, but since

[Qemu-devel] [PATCH 03/11] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT

2015-01-23 Thread Peter Maydell
The LDT/STT (load/store unprivileged) instruction decode was using the wrong MMU index value. This meant that instead of these insns being "always access as if user-mode regardless of current privilege" they were "always access as if kernel-mode regardless of current privilege". This went unnoticed

[Qemu-devel] [PATCH 07/11] target-arm: Split AArch64 cases out of ats_write()

2015-01-23 Thread Peter Maydell
Instead of simply reusing ats_write() as the handler for both AArch32 and AArch64 address translation operations, use a different function for each with the common code in a third function. This is necessary because the semantics for selecting the right translation regime are different; we are only

[Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags

2015-01-23 Thread Peter Maydell
We currently claim that for ARM the mmu_idx should simply be the current exception level. However this isn't actually correct -- secure EL0 and EL1 should have separate indexes from non-secure EL0 and EL1 since their VA->PA mappings may differ. We also will want an index for stage 2 translations wh

[Qemu-devel] [PATCH 00/11] target-arm: handle mmu_idx/translation regimes properly

2015-01-23 Thread Peter Maydell
This patchseries fixes up our somewhat broken handling of mmu_idx values: * implement the full set of 7 mmu_idxes we need for supporting EL2 and EL3 * pass the mmu_idx in the TB flags rather than EL or a priv flag, so we can generate code with the correct kind of access * identify the correct

[Qemu-devel] [PULL 11/12] block: vhdx - force FileOffsetMB field to '0' for certain block states

2015-01-23 Thread Kevin Wolf
From: Jeff Cody The v1.0.0 spec calls out PAYLOAD_BLOCK_ZERO FileOffsetMB field as being 'reserved'. In practice, this means that Hyper-V will fail to read a disk image with PAYLOAD_BLOCK_ZERO block states with a FileOffsetMB value other than 0. The other states that indicate a block that is no

[Qemu-devel] [PULL 10/12] block: update string sizes for filename, backing_file, exact_filename

2015-01-23 Thread Kevin Wolf
From: Jeff Cody The string field entries 'filename', 'backing_file', and 'exact_filename' in the BlockDriverState struct are defined as 1024 bytes. However, many places that use these values accept a maximum of PATH_MAX bytes, so we have a mixture of 1024 byte and PATH_MAX byte allocations. This

[Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr()

2015-01-23 Thread Peter Maydell
Make all the callers of get_phys_addr() pass it the correct mmu_idx rather than just a simple "is_user" flag. This includes properly decoding the AT/ATS system instructions; we include the logic for handling all the opc1/opc2 cases because we'll need them later for supporting EL2/EL3, even if we do

[Qemu-devel] [PULL 08/12] block: remove unused variable in bdrv_commit

2015-01-23 Thread Kevin Wolf
From: Jeff Cody As Stefan pointed out, the variable 'filename' in bdrv_commit is unused, despite being maintained in previous patches. With this patch, get rid of the variable for good. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c | 3 --- 1 file changed, 3 deletions(-) di

[Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in get_phys_addr()

2015-01-23 Thread Peter Maydell
Now we have the mmu_idx in get_phys_addr(), use it correctly to determine the behaviour of virtual to physical address translations, rather than using just an is_user flag and the current CPU state. Some TODO comments have been added to indicate where changes will need to be made to add EL2 and 64

[Qemu-devel] [PULL 12/12] iotests: Lower 064's memory usage

2015-01-23 Thread Kevin Wolf
From: Max Reitz Test 064 reads a lot of data at once which currently results in qemu-io having to allocate up to about 1 GB of memory (958 MB, to be exact). This patch lowers that amount to 128 MB by making the test read smaller chunks. Signed-off-by: Max Reitz Reviewed-by: Jeff Cody Message-i

[Qemu-devel] [PULL 02/12] virtio-blk: Use blk_aio_ioctl

2015-01-23 Thread Kevin Wolf
From: Fam Zheng Use the asynchronous interface of ioctl. This will not make the VM unresponsive if the ioctl takes a long time. Signed-off-by: Fam Zheng Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/block/virtio-blk.c | 125 +++--- 1

[Qemu-devel] [PATCH 10/11] target-arm: Reindent ancient page-table-walk code

2015-01-23 Thread Peter Maydell
A few of the oldest parts of the page-table-walk code have broken indent (either hardcoded tabs or two-spaces). Reindent these sections. For ease of review, this patch does not touch the brace style and so is a whitespace-only change. Signed-off-by: Peter Maydell --- target-arm/helper.c | 192 +

[Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7

2015-01-23 Thread Peter Maydell
Support guest CPUs which need 7 MMU index values. Add a comment about what would be required to raise the limit further (trivial for 8, TCG backend rework for 9 or more). Signed-off-by: Peter Maydell --- include/exec/cpu_ldst.h | 28 +--- 1 file changed, 25 insertions(+),

[Qemu-devel] [PULL 04/12] iotests: Add tests for more corruption cases

2015-01-23 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/060 | 15 +++ tests/qemu-iotests/060.out | 13 + 2 files changed, 28 insertions(+) diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index

[Qemu-devel] [PULL 05/12] block: vmdk - make ret variable usage clear

2015-01-23 Thread Kevin Wolf
From: Jeff Cody Keep the variable 'ret' something that is returned by the function it is defined in. For the return value of 'sscanf', use a more meaningful variable name. Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/vmdk.

[Qemu-devel] [PULL 03/12] qcow2: Add two more unalignment checks

2015-01-23 Thread Kevin Wolf
From: Max Reitz This adds checks for unaligned L2 table offsets and unaligned data cluster offsets (actually the preallocated offsets for zero clusters) to the zero cluster expansion function. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2-cluster.

[Qemu-devel] [PULL 06/12] block: vmdk - move string allocations from stack to the heap

2015-01-23 Thread Kevin Wolf
From: Jeff Cody Functions 'vmdk_parse_extents' and 'vmdk_create' allocate several PATH_MAX sized arrays on the stack. Make these dynamically allocated. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/vmdk.c | 39 +++ 1 file changed, 23 inserti

[Qemu-devel] [PULL 00/12] Block patches

2015-01-23 Thread Kevin Wolf
The following changes since commit c6441452b50c44fdbb362b239ce623f77cf3cd51: Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20150122-1' into staging (2015-01-22 18:57:36 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[Qemu-devel] [PULL 01/12] virtio-blk: Pass req to virtio_blk_handle_scsi_req

2015-01-23 Thread Kevin Wolf
From: Fam Zheng In preparation for calling blk_aio_ioctl. Also make the function static as no other files need it. Signed-off-by: Fam Zheng Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/block/virtio-blk.c | 9 + include/hw/virtio/virtio-blk.h | 3 --- 2 files c

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 15:55:11 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jan 23, 2015 at 02:40:30PM +0100, Igor Mammedov wrote: > > On Fri, 23 Jan 2015 15:24:24 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jan 23, 2015 at 11:35:29AM +0100, Igor Mammedov wrote: > > > > On Fri, 23 Jan

[Qemu-devel] Submit your Google Summer of Code project ideas and volunteer to mentor

2015-01-23 Thread Stefan Hajnoczi
Dear libvirt, KVM, and QEMU contributors, The Google Summer of Code season begins soon and it's time to collect our thoughts for mentoring students this summer working full-time on libvirt, KVM, and QEMU. What is GSoC? Google Summer of Code 2015 (GSoC) funds students to work on open source project

Re: [Qemu-devel] [PULL 01/01] seccomp: add mlockall to whitelist

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 13:39, Amit Shah wrote: > On (Fri) 23 Jan 2015 [14:21:46], Eduardo Otubo wrote: >> From: Paolo Bonzini >> >> This is used by "-realtime mlock=on". >> >> Signed-off-by: Eduardo Otubo > > Hm, that's not where a signed-off-by of the maintainer goes... > >> Signed-off-by: Paolo

Re: [Qemu-devel] [PULL 00/01] seccomp branch queue

2015-01-23 Thread Peter Maydell
ble in the git repository at: > > > https://github.com/otubo/qemu.git tags/pull-seccomp-20150123 > > for you to fetch changes up to 4b45b055491a319292beefb8080a81d96cf55cf6: > > seccomp: add mlockall to whitelist (2015-01-23 14:07:08 +0100) > > --

Re: [Qemu-devel] Nested KVM L2 guest hangs

2015-01-23 Thread Chris J Arges
Ariel, You can easily use a supported 3.16 kernel on Ubuntu 14.04: sudo apt-get install --install-recommends linux-generic-lts-utopic If you have further problems with 3.16 or 3.13 on the distro kernel please feel free to file a bug: https://bugs.launchpad.net/ubuntu/+filebug Hope that helps. Tha

[Qemu-devel] [PATCH v4 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

2015-01-23 Thread Marc Marí
Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 154 +++ 1 file changed, 89 insertions(+), 65 deletions(-) diff --git a/tests/virtio-blk-test.c b/tests/vir

[Qemu-devel] [PATCH v4 3/5] libqos: Remove PCI assumptions in constants of virtio driver

2015-01-23 Thread Marc Marí
Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11 ++- 3 files changed, 33 insertions(+),

[Qemu-devel] [PATCH v4 1/5] libqos: Change use of pointers to uint64_t in virtio

2015-01-23 Thread Marc Marí
Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 20 +++- tests/libqos/virtio

[Qemu-devel] [PATCH v4 4/5] libqos: Add malloc generic

2015-01-23 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí --- tests/libqos/malloc-generic.c | 50 + tests/libqos/m

[Qemu-devel] [PATCH v4 5/5] libqos: Add virtio MMIO support

2015-01-23 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 198 tests/libqos/virtio-mmio.h | 46 ++ tests/virtio-blk-test.c| 83

[Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-01-23 Thread Marc Marí
Add virtio-mmio support to libqos and test case for virtio-blk. Changes for version 3: - Fix leaks and minor bugs - Extract basic test case to a function Changes for version 4: - Add format=raw to images, to avoid warnings - Solve bug with timeout in interrupt checking in virtio MMIO due to a

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-23 Thread Eric Blake
On 01/23/2015 07:06 AM, Javier Celaya wrote: > Hello, this is the patch with the version check. Christophe, can you check > that the version is the correct one? > > > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. > --- > ui/spice-

Re: [Qemu-devel] [PATCH V2 1/4] target-arm: Fix RVBAR_EL1 register encoding

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 16:17, Greg Bellows wrote: > Fix the RVBAR_EL1 CP register opc2 encoding from 2 to 1 > > Signed-off-by: Greg Bellows > --- > target-arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 1a5e06

Re: [Qemu-devel] [PATCH V2 3/4] target-arm: Change reset to highest available EL

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 16:17, Greg Bellows wrote: > Update to arm_cpu_reset() to reset into the highest available exception level > based on the set ARM features. > > Signed-off-by: Greg Bellows > > --- > > v1 -> v2 > - Added Linux boot into secure EL1 > - Added reset to EL2 if enabled > - Removed

Re: [Qemu-devel] [v3 03/13] migration: Add the framework of muti-thread decompression

2015-01-23 Thread Eric Blake
On 12/11/2014 06:28 PM, Liang Li wrote: In addition to David's catches: s/muti/multi/ in the subject line. Commit message feels sparse - is the one subject line really all we need to know about this framework? > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c

[Qemu-devel] [PATCH V2 1/4] target-arm: Fix RVBAR_EL1 register encoding

2015-01-23 Thread Greg Bellows
Fix the RVBAR_EL1 CP register opc2 encoding from 2 to 1 Signed-off-by: Greg Bellows --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 1a5e067..c9b1c08 100644 --- a/target-arm/helper.c +++ b/target-arm/helpe

[Qemu-devel] [PATCH V2 3/4] target-arm: Change reset to highest available EL

2015-01-23 Thread Greg Bellows
Update to arm_cpu_reset() to reset into the highest available exception level based on the set ARM features. Signed-off-by: Greg Bellows --- v1 -> v2 - Added Linux boot into secure EL1 - Added reset to EL2 if enabled - Removed extraneous SCR.NS reset - Fixed incorrect feature check --- hw/arm/

[Qemu-devel] [PATCH V2 4/4] target-arm: Add missing SP_ELx register definition

2015-01-23 Thread Greg Bellows
Added CP register definitions for SP_EL1 and SP_EL2. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v1 -> v2 - Remove unnecessary accessfn for SP_EL1/2 - Revert SP_EL0 accessfn name to sp_el0_access --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git

[Qemu-devel] [PATCH V2 2/4] target-arm: Add extended RVBAR support

2015-01-23 Thread Greg Bellows
Added RVBAR_EL2 and RVBAR_EL3 CP register support. All RVBAR_EL# registers point to the same location and only the highest EL version exists at any one time. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- target-arm/helper.c | 31 +-- 1 file changed, 25

[Qemu-devel] [PATCH V2 0/4] target-arm: Initial ARMv8 extended EL support

2015-01-23 Thread Greg Bellows
These patches add extended EL support for ARMv8. Specifically the following changes were made: - Fix issue in RVBAR_EL1 CP register definition - Add missing RVBAR_ELx CP register definitions - Add missing SP_ELx CP register definitions - Add reset support to start in highest EL --- v1 -> v2 - Ad

Re: [Qemu-devel] [PATCH RFC v6 06/20] virtio: endianness checks for virtio 1.0 devices

2015-01-23 Thread Greg Kurz
On Thu, 22 Jan 2015 12:54:09 +1100 David Gibson wrote: > On Thu, Dec 11, 2014 at 02:25:08PM +0100, Cornelia Huck wrote: > > Add code that checks for the VERSION_1 feature bit in order to make > > decisions about the device's endianness. This allows us to support > > transitional devices. > > > >

Re: [Qemu-devel] [v3 02/13] migration: Add the framework of multi-thread compression

2015-01-23 Thread Eric Blake
On 12/11/2014 06:28 PM, Liang Li wrote: > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > +void migrate_compress_threads_create(MigrationState *s) > +{ > +int i, thread_count; > + > +if (!migrate_use_compression()) { > +return; > +} > +quit_thread = false; > +

Re: [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter

2015-01-23 Thread Eric Blake
On 01/23/2015 08:59 AM, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 01/23/2015 06:48 AM, Dr. David Alan Gilbert wrote: >>> * Liang Li (liang.z...@intel.com) wrote: Add the qmp and hmp commands to tune the parameters used in live migration. >>> >>> If I un

Re: [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter

2015-01-23 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 01/23/2015 06:48 AM, Dr. David Alan Gilbert wrote: > > * Liang Li (liang.z...@intel.com) wrote: > >> Add the qmp and hmp commands to tune the parameters used in live > >> migration. > > > > If I understand correctly on the destination side we need to se

Re: [Qemu-devel] [v3 13/13] migration: Add command to query migration parameter

2015-01-23 Thread Eric Blake
On 12/11/2014 06:29 PM, Liang Li wrote: > Add the qmp and hmp commands to query the parameters used in live > migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > hmp-commands.hx | 2 ++ > hmp.c| 19 +++ > hmp.h| 1 + > migration.

Re: [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter

2015-01-23 Thread Eric Blake
On 01/23/2015 06:48 AM, Dr. David Alan Gilbert wrote: > * Liang Li (liang.z...@intel.com) wrote: >> Add the qmp and hmp commands to tune the parameters used in live >> migration. > > If I understand correctly on the destination side we need to set the number of > decompression threads very early o

Re: [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter

2015-01-23 Thread Eric Blake
On 12/11/2014 06:29 PM, Liang Li wrote: > Add the qmp and hmp commands to tune the parameters used in live > migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > hmp-commands.hx | 15 ++ > hmp.c | 32 + > hm

Re: [Qemu-devel] [PATCH 3/4] target-arm: Change reset to highest available EL

2015-01-23 Thread Greg Bellows
On Fri, Jan 23, 2015 at 9:05 AM, Peter Maydell wrote: > On 23 January 2015 at 14:49, Greg Bellows wrote: >> Update to arm_cpu_reset() to reset into the highest available exception level >> based on the set ARM features. >> >> Signed-off-by: Greg Bellows >> --- >> hw/arm/boot.c| 10 +

Re: [Qemu-devel] [v3 11/13] migration: Add interface to control compression

2015-01-23 Thread Eric Blake
On 12/11/2014 06:29 PM, Liang Li wrote: > The multiple compression threads can be turned on/off through > qmp and hmp interface when doing live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > +++ b/qapi-schema.json > @@ -491,13 +491,17 @@ > # to enable the c

Re: [Qemu-devel] [v3 01/13] docs: Add a doc about multiple thread compression

2015-01-23 Thread Eric Blake
On 12/11/2014 06:28 PM, Liang Li wrote: > Give some details about the multiple compression threads and > how to use it in live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > docs/multi-thread-compression.txt | 141 > ++ > 1 file c

Re: [Qemu-devel] [RfC PATCH] virtio-pci: place msix regions in modern virtio bar

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 03:48:28PM +0100, Gerd Hoffmann wrote: > Hi, > > > > Also seabios wouldn't map the bar > > > above 4G. > > > We can teach it to do that, and even if not, OS can do it on hotplug. > > Just to clarify: seabios can do it in the general case, it just wouldn't > do it for x

Re: [Qemu-devel] [PATCH 2/2] qcow2-snapshot: Fixing bug of creating snapshots with the same name.

2015-01-23 Thread Max Reitz
On 2015-01-22 at 20:53, Julio Faracco wrote: This commit fixes the bug #1396497. You can create multiple snapshots with the same name using 'qemu-img'. When you want to delete someone passing the name, it will remove the first occurence of the snapshot with that name. This commit fixes it. I'm

Re: [Qemu-devel] [PATCH 4/4] target-arm: Add missing SP_ELx register definition

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 14:49, Greg Bellows wrote: > Added CP register definitions for SP_EL1 and SP_EL2. > > Signed-off-by: Greg Bellows > --- > target-arm/helper.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c >

Re: [Qemu-devel] [PATCH] iotests: Lower 064's memory usage

2015-01-23 Thread Max Reitz
On 2015-01-23 at 09:59, Max Reitz wrote: Test 064 reads a lot of data at once which currently results in qemu-io having to allocate up to about 1 GB of memory (958 MB, to be exact). This patch lowers that amount to 128 MB by making the test read smaller chunks. Signed-off-by: Max Reitz --- te

  1   2   >