Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 23:53, Konrad Rzeszutek Wilk wrote: On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that Could you also include in the cover letter an URL link to the lat

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 20:59, Wei Liu wrote: On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: On 2015/3/6 17:08, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_

[Qemu-devel] balloon stats not working if qemu is started with -machine option

2015-03-08 Thread Alexandre DERUMIER
Hi, I have noticed that balloon stats are not working if a qemu guest is started with -machine option. (-machine pc, or any version) . Tested of qemu 1.7,2.1 && 2.2 When the guest is starting (balloon driver not yet loaded) $VAR1 = { 'last-update' => 0, 'stats' => {

[Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type

2015-03-08 Thread zhanghailiang
Hi, This series converts open-coded 'str' type to enum type for 'status'. This conversion will be more convenient for future extensibility. Actually, I will add a MIG_STATE_COLO state for COLO, and i also saw Dave added MIG_STATE_POSTCOPY_ACTIVE for postcopy. Patch 1 and 2 are preparation for th

[Qemu-devel] [PATCH v4 2/4] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus'

2015-03-08 Thread zhanghailiang
We will use the typename 'MigrationStatus' for publicly exported typename, So here we rename the internal-only 'MigrationStatus' to 'HMPMigrationStatus'. Signed-off-by: zhanghailiang Reviewed-by: Eric Blake --- hmp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hm

[Qemu-devel] [PATCH v4 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_*

2015-03-08 Thread zhanghailiang
Rename all macros MIG_STATE_* to MIGRATION_STATUS_* except "MIG_STATE_ERROR", we rename it to "MIGRATION_STATUS_FAILED" which will match the migration status string 'failed'. Signed-off-by: zhanghailiang --- migration/migration.c | 93 +++ 1 file c

[Qemu-devel] [PATCH v4 3/4] migration: Convert 'status' of MigrationInfo to use an enum type

2015-03-08 Thread zhanghailiang
The original 'status' is an open-coded 'str' type, convert it to use an enum type. This conversion is backwards compatible, better documented and more convenient for future extensibility. In addition, Fix a typo for qapi-schema.json (just remove the typo) : s/'completed'. 'comppleted' (since 1.2)/

[Qemu-devel] [PATCH v4 4/4] migration: Expose 'cancelling' status to user

2015-03-08 Thread zhanghailiang
'cancelling' status was introduced by commit 51cf4c1a, mainly to avoid a possible start of a new migration process while the previous one still exists. But we didn't expose this status to user, instead we returned the 'active' state. Here, we expose it to the user (such as libvirt), 'cancelling'

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 20:55, Wei Liu wrote: On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass I

Re: [Qemu-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 20:40, Wei Liu wrote: On Fri, Mar 06, 2015 at 05:08:22PM +0800, Tiejun Chen wrote: While working with qemu, IGD is a specific device in the case of pass through so we need to identify that to handle more later. Here we define a table to record all IGD types currently we can support.

[Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-03-08 Thread Pankaj Gupta
vhostforce was added to enable vhost when guest don't have MSI-X support. Now, we have scenarios like DPDK in Guest which dont use interrupts and still use vhost. Also, performance of guests without MSI-X support is getting less popular. Its OK to remove this extra option and enable vhost

Re: [Qemu-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 20:28, Wei Liu wrote: On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,igd-passthru=on". This need to bring a change on

Re: [Qemu-devel] [RFC 0/1] Rolling stats on colo

2015-03-08 Thread Wen Congyang
On 03/07/2015 02:30 AM, Dr. David Alan Gilbert wrote: > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: >> On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >> >> Hi Dave, >> >>> >>> Hi, >>> I'm getting COLO running on a couple of our machines here

Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value

2015-03-08 Thread Yik Fang
Thanks to Markus for your help! On 2015/3/2 9:25, Fangyi (C) wrote: PING The value of reply.error should be the type unsigned int. Signed-off-by: Yik Fang --- nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.c b/nbd.c index e56afbc1..30e2f3b 100644 --- a/nbd.c

Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-03-08 Thread Li, Liang Z
> Current migration code returns number of bytes transferred and from there > we decide if we.have sent something or not. Problem, we need two results: > number of pages written, and number of bytes written (depending on > compression, zero pages, etc, it is not possible to derive one value from t

Re: [Qemu-devel] [RFC v4 0/9] pass aer error to guest for vfio device

2015-03-08 Thread Chen Fan
ping... On 03/02/2015 03:16 PM, Chen Fan wrote: For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error occurred but stop the guest, so this patches add aer capability support for vfio dev

Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user

2015-03-08 Thread zhanghailiang
On 2015/3/7 0:24, Eric Blake wrote: On 03/04/2015 07:09 AM, zhanghailiang wrote: 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid s/is introduced/was introduced/ s/which is mainly avoid/mainly to avoid a/ possible starting a new migration process while the previous

Re: [Qemu-devel] [PATCH v3 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_*

2015-03-08 Thread zhanghailiang
On 2015/3/7 0:14, Eric Blake wrote: On 03/04/2015 07:09 AM, zhanghailiang wrote: Signed-off-by: zhanghailiang --- migration/migration.c | 93 +++ 1 file changed, 50 insertions(+), 43 deletions(-) diff --git a/migration/migration.c b/migration/

Re: [Qemu-devel] [PATCH RFC v3 14/27] COLO failover: Introduce a new command to trigger a failover

2015-03-08 Thread zhanghailiang
On 2015/3/7 0:10, Eric Blake wrote: On 02/25/2015 12:04 AM, zhanghailiang wrote: +++ b/qmp-commands.hx @@ -753,6 +753,25 @@ Example: EQMP { +.name = "colo_lost_heartbeat", ...but documented incorrectly (this should use '-' to match the command name in the .json file,

Re: [Qemu-devel] ACPI 5.1: 7.3.2 System \_Sx states

2015-03-08 Thread Doran, Mark
Thanks for the report. You might want to bring this to the attention of Dean Nelson and/or Al Stone -- as regular attendees of the ACPI Work Group they can file an ECR or show you how to do that if that's appropriate. -- Cheers,   Mark.   > -Original Message- > From: Michael S. Tsirkin [

Re: [Qemu-devel] [PULL] qemu-sparc update

2015-03-08 Thread Alexander Graf
> Am 08.03.2015 um 17:03 schrieb Mark Cave-Ayland > : > >> On 08/03/15 20:48, Alexander Graf wrote: >> >>> On 08.03.15 06:57, Mark Cave-Ayland wrote: On 08/03/15 10:31, Peter Maydell wrote: On 8 March 2015 at 19:04, Mark Cave-Ayland wrote: > On 08/03/15 09:47, Peter

Re: [Qemu-devel] [PULL] qemu-sparc update

2015-03-08 Thread Mark Cave-Ayland
On 08/03/15 20:48, Alexander Graf wrote: > On 08.03.15 06:57, Mark Cave-Ayland wrote: >> On 08/03/15 10:31, Peter Maydell wrote: >> >>> On 8 March 2015 at 19:04, Mark Cave-Ayland >>> wrote: On 08/03/15 09:47, Peter Maydell wrote: > On 4 March 2015 at 15:20, Mark Cave-Ayland > w

Re: [Qemu-devel] [PULL] qemu-sparc update

2015-03-08 Thread Alexander Graf
On 08.03.15 06:57, Mark Cave-Ayland wrote: > On 08/03/15 10:31, Peter Maydell wrote: > >> On 8 March 2015 at 19:04, Mark Cave-Ayland >> wrote: >>> On 08/03/15 09:47, Peter Maydell wrote: >>> On 4 March 2015 at 15:20, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the up

[Qemu-devel] [Bug 1428657] Re: qemu-system-arm does not ignore the lowest bit of pc when returning from interrrupt

2015-03-08 Thread Anders Esbensen
Yes the situation I'm describing is the bx 0xfffx case. I see that the article I'm referring to, actually only describes the behaviour of branches and in ISR vector. Searching a bit more I see this: Cortex™-M3 Technical Reference Manual Revision: r1p1 Home > Programmer’s Model > Registers

[Qemu-devel] [PATCH] target-moxie: Fix warnings from Sparse (one-bit signed bitfield)

2015-03-08 Thread Stefan Weil
Report from Sparse: target-moxie/mmu.h:9:12: error: dubious one-bit signed bitfield target-moxie/mmu.h:10:12: error: dubious one-bit signed bitfield target-moxie/mmu.h:11:12: error: dubious one-bit signed bitfield target-moxie/mmu.h:12:12: error: dubious one-bit signed bitfield target-moxie/mmu.h:

Re: [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Kevin O'Connor
On Sun, Mar 08, 2015 at 07:34:34PM +0100, Michael S. Tsirkin wrote: > On Sun, Mar 08, 2015 at 12:13:40PM -0400, Kevin O'Connor wrote: > > If I read this correctly, it looks like a machine with two root buses > > and 20 devices, each with one memory range and one io range, would end > > up with 40 C

Re: [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 12:13:40PM -0400, Kevin O'Connor wrote: > On Sun, Mar 08, 2015 at 01:16:15PM +0200, Marcel Apfelbaum wrote: > > If multiple root busses are used, root bus 0 cannot use all the > > pci holes ranges. Remove the IO/mem ranges used by the other > > primary busses. > [...] > > -

Re: [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 08:26 PM, Kevin O'Connor wrote: On Sun, Mar 08, 2015 at 07:51:42PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 06:13 PM, Kevin O'Connor wrote: If I read this correctly, it looks like a machine with two root buses and 20 devices, each with one memory range and one io range, would

[Qemu-devel] [PATCH 7/7] Fix remaining warnings from Sparse (void return)

2015-03-08 Thread Stefan Weil
Sparse report: hw/display/vga.c:2000:5: warning: returning void-valued expression hw/intc/arm_gic.c:707:9: warning: returning void-valued expression hw/intc/etraxfs_pic.c:138:9: warning: returning void-valued expression hw/nvram/fw_cfg.c:475:5: warning: returning void-valued expression hw/timer/a9

Re: [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Kevin O'Connor
On Sun, Mar 08, 2015 at 07:51:42PM +0200, Marcel Apfelbaum wrote: > On 03/08/2015 06:13 PM, Kevin O'Connor wrote: > >If I read this correctly, it looks like a machine with two root buses > >and 20 devices, each with one memory range and one io range, would end > >up with 40 CRS ranges (ie, a CRS ra

[Qemu-devel] [PATCH 6/7] qom: Fix warning from Sparse

2015-03-08 Thread Stefan Weil
Sparse report: qom/cpu.c:99:5: warning: returning void-valued expression Cc: Andreas Färber Signed-off-by: Stefan Weil --- qom/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index 970377e..108bfa2 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -96,7

[Qemu-devel] [PATCH 5/7] target-mips: Fix warning from Sparse

2015-03-08 Thread Stefan Weil
Sparse report: target-mips/dsp_helper.c:3681:5: warning: returning void-valued expression Cc: Aurelien Jarno Cc: Leon Alrae Signed-off-by: Stefan Weil --- target-mips/dsp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_he

[Qemu-devel] [PATCH 4/7] arm/nseries: Fix warnings from Sparse

2015-03-08 Thread Stefan Weil
Sparse report: arm/nseries.c:1406:5: warning: returning void-valued expression arm/nseries.c:1411:5: warning: returning void-valued expression Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Stefan Weil --- hw/arm/nseries.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 3/7] omap: Fix warnings from Sparse

2015-03-08 Thread Stefan Weil
Sparse report: arm/omap1.c:1015:9: warning: returning void-valued expression arm/omap1.c:1084:9: warning: returning void-valued expression arm/omap1.c:1178:9: warning: returning void-valued expression arm/omap1.c:1287:9: warning: returning void-valued expression arm/omap1.c:1382:9: warning: return

[Qemu-devel] [PATCH 2/7] 9pfs: Fix warnings from Sparse

2015-03-08 Thread Stefan Weil
Sparse report: 9pfs/virtio-9p.c:1953:9: warning: returning void-valued expression 9pfs/virtio-9p-handle.c:143:5: warning: returning void-valued expression 9pfs/virtio-9p-handle.c:160:5: warning: returning void-valued expression 9pfs/virtio-9p-local.c:384:5: warning: returning void-valued expressio

[Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse

2015-03-08 Thread Stefan Weil
Sparse report: backends/tpm.c:39:5: warning: returning void-valued expression Signed-off-by: Stefan Weil --- backends/tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/tpm.c b/backends/tpm.c index 01860c4..4efe367 100644 --- a/backends/tpm.c +++ b/backends/tpm.c

Re: [Qemu-devel] [PATCH v4 for-2.3 12/25] hw/acpi: add _CRS method for extra root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 06:27 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:16:14PM +0200, Marcel Apfelbaum wrote: Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 149 +++

Re: [Qemu-devel] [PATCH v4 for-2.3 10/25] hw/acpi: add support for multiple root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 06:10 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:16:12PM +0200, Marcel Apfelbaum wrote: If the machine has several root busses, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 32 ++

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 06:03 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 05:37:25PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 05:27 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 05:22:43PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: On Sun, Mar

Re: [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 06:13 PM, Kevin O'Connor wrote: On Sun, Mar 08, 2015 at 01:16:15PM +0200, Marcel Apfelbaum wrote: If multiple root busses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary busses. [...] -aml_append(crs, -aml_w

Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1

2015-03-08 Thread Aneesh Kumar K.V
Michael Tokarev writes: > This simplifies code in v9fs_request() a bit by replacing several > ifs with a common variable check and rearranging error/cleanup > code a bit. Is this -V2 of http://mid.gmane.org/b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git@msgid.tls.msk.ru I am slight

Re: [Qemu-devel] [PATCH v4 for-2.3 12/25] hw/acpi: add _CRS method for extra root busses

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 01:16:14PM +0200, Marcel Apfelbaum wrote: > Save the IO/mem/bus numbers ranges assigned to the extra root busses > to be removed from the root bus 0 range. > > Signed-off-by: Marcel Apfelbaum > --- > hw/i386/acpi-build.c | 149 > ++

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-08 Thread Aneesh Kumar K.V
Michael Tokarev writes: > 07.03.2015 23:37, Eric Blake wrote: >> On 03/06/2015 02:43 PM, Michael Tokarev wrote: >>> All filesystem methods that call common v9fs_request() function >>> also convert return value to errno. Move this conversion to the >>> common function and remove redundand error h

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-08 Thread Aneesh Kumar K.V
Michael Tokarev writes: > All filesystem methods that call common v9fs_request() function > also convert return value to errno. Move this conversion to the > common function and remove redundand error handling in methods. > > I didn't remove local `retval' variable in simple functions to > keep

Re: [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Kevin O'Connor
On Sun, Mar 08, 2015 at 01:16:15PM +0200, Marcel Apfelbaum wrote: > If multiple root busses are used, root bus 0 cannot use all the > pci holes ranges. Remove the IO/mem ranges used by the other > primary busses. [...] > -aml_append(crs, > -aml_word_io(aml_min_fixed, aml_max_fixed, > -

Re: [Qemu-devel] [PATCH v4 for-2.3 10/25] hw/acpi: add support for multiple root busses

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 01:16:12PM +0200, Marcel Apfelbaum wrote: > If the machine has several root busses, we need to add them to > acpi in order to be properly detected by guests. > > Signed-off-by: Marcel Apfelbaum > --- > hw/i386/acpi-build.c | 32 > 1 file c

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 05:37:25PM +0200, Marcel Apfelbaum wrote: > On 03/08/2015 05:27 PM, Michael S. Tsirkin wrote: > >On Sun, Mar 08, 2015 at 05:22:43PM +0200, Marcel Apfelbaum wrote: > >>On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: > >>>On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfe

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 05:27 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 05:22:43PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: On Thu, Mar

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 05:22:43PM +0200, Marcel Apfelbaum wrote: > On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: > >On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfelbaum wrote: > >>On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: > >>>On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfe

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum some ideas for cleaning thi

[Qemu-devel] [PATCH] aml-build: append opcodes using build_append_byte

2015-03-08 Thread Michael S. Tsirkin
Opcodes are raw bytes, they shouldn't be added using build_append_int. This only happens to work with 0 and 1 opcodes. Signed-off-by: Michael S. Tsirkin --- hw/acpi/aml-build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c ind

Re: [Qemu-devel] [PATCH] user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm

2015-03-08 Thread Peter Maydell
On 8 March 2015 at 23:59, Tobias Nygren wrote: > Standalone static binaries and basic syscall emulation seem to work OK. > There is a problem with ps_strings / argv[0] being NULL in crt0.o. > (looks like it would not be hard to fix) Yeah, ps_strings rings a bell, I think that was what I was seein

Re: [Qemu-devel] [PATCH] user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm

2015-03-08 Thread Tobias Nygren
On Sun, 8 Mar 2015 21:53:30 +0900 Peter Maydell wrote: > On 8 March 2015 at 21:37, Tobias Nygren wrote: > > On Sun, 8 Mar 2015 19:27:27 +0900 > > Peter Maydell wrote: > >> Does NetBSD have a big stack of out-of-tree patches for QEMU, > >> or do you run basically stock upstream QEMU? > > > > Hi,

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfelbaum wrote: > On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: > >On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: > >>Signed-off-by: Marcel Apfelbaum > > > >some ideas for cleaning this up. > >there's more here btw. > > > >>-

Re: [Qemu-devel] [PULL 0/5] QMP queue

2015-03-08 Thread Peter Maydell
On 5 March 2015 at 04:13, Luiz Capitulino wrote: > Hi, > > This pull request contains two series. A balloon series and memory hotplug > doc series. The balloon series is not totally QMP related, but it has > implications to libvirt when using memory hotplug. So, I'm picking it up. > The second ser

Re: [Qemu-devel] [PATCH] user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm

2015-03-08 Thread Peter Maydell
On 8 March 2015 at 21:37, Tobias Nygren wrote: > On Sun, 8 Mar 2015 19:27:27 +0900 > Peter Maydell wrote: >> Does NetBSD have a big stack of out-of-tree patches for QEMU, >> or do you run basically stock upstream QEMU? > > Hi, it is more or less stock except for this patch. Cool. (I know the Fre

Re: [Qemu-devel] [PULL v2 00/46] Trivial patches for 2015-03-04

2015-03-08 Thread Peter Maydell
On 5 March 2015 at 02:16, Michael Tokarev wrote: > This is a resend of my previous pull request, but without > patch 6 "migration/rdma: clean up qemu_rdma_dest_init a bit". > I won't include all the other patches since they're the same, > there's no need to bomb people again. > > Thanks, > > /mjt

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 09:26:17PM +0900, Peter Maydell wrote: > On 8 March 2015 at 19:45, Michael S. Tsirkin wrote: > > On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote: > > I can drop this one as a work around but I wonder why is clang warning > > about unused static inlines. > > >

Re: [Qemu-devel] [PATCH] user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm

2015-03-08 Thread Tobias Nygren
Hello, On Sun, 8 Mar 2015 19:27:27 +0900 Peter Maydell wrote: > On 6 March 2015 at 06:37, Tobias Nygren wrote: > > A couple of #ifdef changes necessary to use NetBSD's ucontext > > structs on sparc64 and arm. > > > > Signed-off-by: Tobias Nygren > > Reviewed-by: Peter Maydell > > Does NetBS

Re: [Qemu-devel] [PULL 0/7] spice patch queue

2015-03-08 Thread Peter Maydell
On 4 March 2015 at 23:30, Gerd Hoffmann wrote: > Hi, > > Here comes the spice patch queue with a bunch of misc, small spice fixes > which arrived revently. Nothing outstanding. > > please pull, > Gerd > > The following changes since commit 0856579cac2f1dacecd847cfcd89680d26ff78f5: > > Rever

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-08 Thread Peter Maydell
On 8 March 2015 at 19:45, Michael S. Tsirkin wrote: > On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote: > I can drop this one as a work around but I wonder why is clang warning > about unused static inlines. > > We have a ton of these in each header and it doesn't warn, > in theory st

[Qemu-devel] ACPI 5.1: 7.3.2 System \_Sx states

2015-03-08 Thread Michael S. Tsirkin
Hello! I have noticed the following inconsistency in ACPI spec 5.1. 7.3.2 System \_Sx states States: Return Value: A Package containing an Integer containing register values for sleeping It goes on to specify Table 7-221 System State Package which describes a byte array in terms of byte length/b

[Qemu-devel] [PATCH v4 for-2.3 24/25] hw/pci_bus: add support for NUMA nodes

2015-03-08 Thread Marcel Apfelbaum
PCI root buses can be attached to a specific NUMA node. PCI buses are not attached be default to a NUMA node. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci_bus.c | 7 +++ include/hw/pci/pci_bus.h | 6 ++ include/sysemu/sysemu.h | 1 + 3 files changed, 14 insertions(+) diff --g

[Qemu-devel] [PATCH v4 for-2.3 22/25] hw/pci: piix - suport multiple host bridges

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Instead of assuming it has only one bus, it enumerates all the host bridges until it finds the one with bus number corresponding with the config register. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/piix.c | 57 +-

[Qemu-devel] [PATCH v4 for-2.3 25/25] hw/pxb: add numa_node parameter

2015-03-08 Thread Marcel Apfelbaum
The pxb can be attach to and existing numa node by specifying numa_node option that equals the desired numa nodeid. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c| 12 hw/pci-bridge/pci_expander_bridge.c | 17 + 2 files changed, 29 insertion

[Qemu-devel] [PATCH v4 for-2.3 18/25] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index e386f2c..53598bd 100644 --- a/hw/pci/pci.c +++ b/hw/pc

[Qemu-devel] [PATCH v4 for-2.3 23/25] hw/pxb: add map_irq func

2015-03-08 Thread Marcel Apfelbaum
The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation. Synchronize between bios and Qemu by canceling pxb's effect. Signed-off-by: Marcel A

[Qemu-devel] [PATCH v4 for-2.3 14/25] hw/pci: move pci bus related code to separate files

2015-03-08 Thread Marcel Apfelbaum
This refactoring moves all the code needed (recursively) to register TYPE_PCI_BUS type to a new file hw/pci/pci_bus.c . This allows to properly add new functionality to the pci bus class. Signed-off-by: Marcel Apfelbaum --- arch_init.c | 1 + hw/alpha/typhoon.c | 1 + hw/m

[Qemu-devel] [PATCH v4 for-2.3 21/25] hw/pci: inform bios if the system has more than one pci bridge

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum The bios looks for 'etc/extra-pci-roots' to decide if is going to scan further buses after bus 0 tree. Signed-off-by: Marcel Apfelbaum --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index ae3ef0a..71d2f5b 1

[Qemu-devel] [PATCH v4 for-2.3 16/25] hw/pci: made pci_bus_num a PCIBusClass method

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Signed-off-by: Marcel Apfelbaum --- hw/i386/kvm/pci-assign.c | 1 + hw/pci/pci.c | 7 --- hw/pci/pci_bus.c | 10 ++ hw/scsi/megasas.c|

[Qemu-devel] [PATCH v4 for-2.3 20/25] hw/pci: introduce PCI Expander Bridge (PXB)

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum PXB is a "light-weight" host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses. As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus is a primary bus and can be associated with a NUMA node (different from the main host bridge) al

[Qemu-devel] [PATCH v4 for-2.3 17/25] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum This is a marker interface used to differentiate the "default" host bridge on a system with multiple host bridges. This differentiation is required only for pc machines for now by the ACPI subsystem. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 9 +

[Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Marcel Apfelbaum
If multiple root busses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary busses. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 84 1 file changed, 72 insertions(+), 12 de

[Qemu-devel] [PATCH v4 for-2.3 12/25] hw/acpi: add _CRS method for extra root busses

2015-03-08 Thread Marcel Apfelbaum
Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/hw/i386/acpi-build.c b

[Qemu-devel] [PATCH v4 for-2.3 09/25] acpi: add aml_while() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefWhile Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6315ea0..f85a0fb 1006

[Qemu-devel] [PATCH v4 for-2.3 15/25] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel Apfelbaum --- hw/pci

[Qemu-devel] [PATCH v4 for-2.3 11/25] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 65 1 file changed, 65 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index e5709e8..e7a1a36 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -66

[Qemu-devel] [PATCH v4 for-2.3 07/25] acpi: add aml_shiftright() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftRight Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 497713e..09

[Qemu-devel] [PATCH v4 for-2.3 10/25] hw/acpi: add support for multiple root busses

2015-03-08 Thread Marcel Apfelbaum
If the machine has several root busses, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build

[Qemu-devel] [PATCH v4 for-2.3 19/25] hw/pci: implement iteration over multiple host bridges

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 8 include/hw/pci/pci_host.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 53598bd..f0cf752 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @

[Qemu-devel] [PATCH v4 for-2.3 05/25] acpi: add aml_index() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 49ba8c1..b3372df 100644 --- a/hw/acpi/aml

[Qemu-devel] [PATCH v4 for-2.3 08/25] acpi: add aml_increment() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefIncrement Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 09a543c..6315ea0

[Qemu-devel] [PATCH v4 for-2.3 06/25] acpi: add aml_shiftleft() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftLeft Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index b3372df..497

[Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefOr Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 0d14561..603c0c4 10

[Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-08 Thread Marcel Apfelbaum
Notes: - Sorry for the late submission, I was waiting for dynamic ACPI series to get merged in order to submit - my bad. - The prev version (v2) was wrongfully tagged by me as RFC, it was actually ready but not rebased. V3 only rebases with no actual functionality changed. - This series

[Qemu-devel] [PATCH v4 for-2.3 04/25] acpi: add aml_lless() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefLLess Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index be60f4e..49ba8c1 10

[Qemu-devel] [PATCH v4 for-2.3 03/25] acpi: add aml_add() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefAdd Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 603c0c4..be60f4e 1

[Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation

2015-03-08 Thread Marcel Apfelbaum
The DefLEqual op does not have a target operand. Remove it. Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 876cada..0d14561 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -5

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum some ideas for cleaning this up. there's more here btw. --- hw/i386/acpi-build.c | 78

[Qemu-devel] [PULL v6 3/3] acpi: drop unused code

2015-03-08 Thread Michael S. Tsirkin
Recent changes left acpi_get_hex unused, and clag is unhappy about it: error: unused function 'acpi_get_hex' Drop it, as well as some unused macros. Signer-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/i386/acpi-build

[Qemu-devel] [PULL v6 2/3] aml-build: comment fix

2015-03-08 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index f6735ea..17d3beb 100644 --- a/include/hw/acpi/aml-build.h +++ b/include/hw/acpi/aml-build.h @@ -9,7

[Qemu-devel] [PULL v6 1/3] acpi-build: fix typo in comment

2015-03-08 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b94e47e..d5e1016 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -889,7 +889,7 @@ build_ssdt(GArray *tab

[Qemu-devel] [PULL v6 0/3] pci, pc, virtio fixes and cleanups

2015-03-08 Thread Michael S. Tsirkin
An incremental pull update, sent to fix clang warning in v5. The following 3 patches added on top: acpi: drop unused code aml-build: comment fix acpi-build: fix typo in comment Only tested this lightly, but I checked that gcc generated identical stripped object files with and without th

Re: [Qemu-devel] [PULL] qemu-sparc update

2015-03-08 Thread Mark Cave-Ayland
On 08/03/15 10:31, Peter Maydell wrote: > On 8 March 2015 at 19:04, Mark Cave-Ayland > wrote: >> On 08/03/15 09:47, Peter Maydell wrote: >> >>> On 4 March 2015 at 15:20, Mark Cave-Ayland >>> wrote: Hi Peter, Here are the updates from my qemu-sparc tree. Please pull. >>> MAIN

Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-03-08 Thread Philipp Hahn
Hello, On 08.03.2015 02:53, Xiaodong Gong wrote: > the encoding type of parent location is must be utf 8,utf16e,according > to the draft Yes, the SPEC for VPC/VHD specifies the character encoding to use, which is good for being portable. > ascii is the encoding type to store the string of parent

Re: [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Michael S. Tsirkin
On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: > Signed-off-by: Marcel Apfelbaum some ideas for cleaning this up. there's more here btw. > --- > hw/i386/acpi-build.c | 78 > > 1 file changed, 78 insertions(+) > > diff --g

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote: > On 8 March 2015 at 03:17, Michael S. Tsirkin wrote: > > OK Markus now confirmed this wasn't (necessarily) triggered > > by these patches. So nothing should block this pull request now? > > Fails to build with clang: > > /home/petma

Re: [Qemu-devel] [Bug 1428657] [NEW] qemu-system-arm does not ignore the lowest bit of pc when returning from interrrupt

2015-03-08 Thread Peter Maydell
On 5 March 2015 at 23:15, Anders Esbensen wrote: > Public bug reported: > > This was observed in qemu v2.1.3, running a sample app from > > FreeRTOS(FreeRTOSV7.5.2/FreeRTOS/Demo/CORTEX_LM3S_Eclipse/RTOSDemo) > > In the sample code compiled with arm-none-eabi-gcc , version 4.8.2 > (4.8.2-14ubun

Re: [Qemu-devel] [PULL] qemu-sparc update

2015-03-08 Thread Peter Maydell
On 8 March 2015 at 19:04, Mark Cave-Ayland wrote: > On 08/03/15 09:47, Peter Maydell wrote: > >> On 4 March 2015 at 15:20, Mark Cave-Ayland >> wrote: >>> Hi Peter, >>> >>> Here are the updates from my qemu-sparc tree. Please pull. >> >>> MAINTAINERS |3 + >>> hw/ppc/ppc.c

Re: [Qemu-devel] [PATCH] user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm

2015-03-08 Thread Peter Maydell
On 6 March 2015 at 06:37, Tobias Nygren wrote: > A couple of #ifdef changes necessary to use NetBSD's ucontext > structs on sparc64 and arm. > > Signed-off-by: Tobias Nygren Reviewed-by: Peter Maydell Does NetBSD have a big stack of out-of-tree patches for QEMU, or do you run basically stock u

  1   2   >