Re: [Qemu-devel] [PATCH v2 4/6] target-arm: kvm64 sync FP register state

2015-03-11 Thread Greg Bellows
On Wed, Mar 4, 2015 at 8:35 AM, Alex Bennée alex.ben...@linaro.org wrote: For migration to work we need to sync all of the register state. This is especially noticeable when GCC starts using FP registers as spill registers even with integer programs. Signed-off-by: Alex Bennée

[Qemu-devel] Patch for 64 bit mingw compilation

2015-03-11 Thread Joseph Hindin
Hi When compiling the QEMU Guest Agent with 64-bit MinGW toolchain version 4.9.2, I run into the following problem: qga-vss.dll linking failed as linker reported a lot of unresolved symbol __stack_chk_fail errors stemming from the stack protection. The attached patch solves the problem by

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Bandan Das
Kevin O'Connor ke...@koconnor.net writes: ... Something is very odd here. When I run the above command (on an older AMD machine) I get: Found 128 cpu(s) max supported 128 cpu(s) That first value (1 vs 128) comes from QEMU (via cmos index 0x5f). That is, during smp init, SeaBIOS expects

Re: [Qemu-devel] [PATCH 6/6] target-arm/cpu.h: document why env-spsr exists

2015-03-11 Thread Peter Maydell
On 25 February 2015 at 16:02, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? I've already disagreed with this. I would suggest putting tentative

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Dr. David Alan Gilbert
* Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 01:45:57PM +, Dr. David Alan Gilbert wrote: * Bandan Das (b...@redhat.com) wrote: Dr. David Alan Gilbert dgilb...@redhat.com writes: while true; do (sleep 5; echo -e

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-11 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: Add the qmp and hmp commands to tune and query the parameters used in live migration. Signed-off-by: Liang Li liang.z...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Hi, You might like to split this patch into two; one with no actual

Re: [Qemu-devel] [PATCH v2 2/3] target-arm: fix get_phys_addr_v6/SCTLR_AFE access check

2015-03-11 Thread Peter Maydell
On 10 March 2015 at 21:06, Andrew Jones drjo...@redhat.com wrote: Introduce simple_ap_to_rw_prot(), which has the same behavior as ap_to_rw_prot(), but takes the 2-bit simple AP[2:1] instead of the 3-bit AP[2:0]. Use this in get_phys_addr_v6 when SCTLR_AFE is set, as that bit indicates we

[Qemu-devel] [PATCH] windows build: -lssp added to qga-vss.dll libraries list

2015-03-11 Thread Joseph Hindin
When building qga-bss.dll with 64-bit mingw toolchain v. 4.9.2, the qga-vss.dll linking fails with unresolved symbols from libssp, stack protection support, like the following message: .../qga/vss-win32/install.cpp:52: undefined reference to `__stack_chk_fail' The patch fixes the problem by

[Qemu-devel] [PATCH v5] hw/intc/arm_gic: Initialize the vgic in the realize function

2015-03-11 Thread Eric Auger
This patch forces vgic initialization in the vgic realize function. It uses a new group/attribute that allows such operation: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT This earlier initialization allows, for example, to setup VFIO signaling and irqfd after vgic initialization, on a

[Qemu-devel] [PATCH 3/9] mips/kvm: Implement PRid CP0 register

2015-03-11 Thread James Hogan
Implement saving and restoring to KVM state of the Processor ID (PRid) CP0 register. This allows QEMU to control the PRid exposed to the guest instead of using the default set by KVM. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Leon Alrae

[Qemu-devel] [PATCH 6/9] mips/kvm: Support signed 64-bit KVM registers

2015-03-11 Thread James Hogan
Rename kvm_mips_{get,put}_one_reg64() to kvm_mips_{get,put}_one_ureg64() since they take an int64_t pointer, and add separate signed 64-bit accessors. These will be used for double precision floating point registers. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Paolo Bonzini

[Qemu-devel] [PATCH 5/9] mips/kvm: Support unsigned KVM registers

2015-03-11 Thread James Hogan
Add KVM register access functions for the uint32_t type. This is required for FP and MSA control registers, which are represented as unsigned 32-bit integers. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Leon Alrae leon.al...@imgtec.com Cc: Aurelien

[Qemu-devel] fw_cfg specification ?

2015-03-11 Thread Gabriel L. Somlo
Hi, I'm looking for the closest thing to an official spec for qemu's fw_cfg device, and so far I have found this: http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00238.html but it apparently never got committed to qemu (any idea why not?). Googling around didn't get me much further

Re: [Qemu-devel] [RFC v4 6/9] vfio: add 'x-aer' option to disable aer capability

2015-03-11 Thread Alex Williamson
On Wed, 2015-03-11 at 11:42 +0800, Chen Fan wrote: On 03/10/2015 04:29 AM, Alex Williamson wrote: On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: add 'x-aer' option to disable aer capability if user want. I'm generally one to favor using the x- flag, but we need to figure out if we

Re: [Qemu-devel] [Qemu-Dev] Related to Live Migration source Code or API for NUMA Node specific

2015-03-11 Thread Arkajit Ghosh
Hi, Can anyone please provide their point of views related to my below query. Thanks Regards Arkajit Ghosh -Arkajit Ghosh/DEL/TCS wrote: - To: qemu-devel@nongnu.org From: Arkajit Ghosh/DEL/TCS Date: 03/11/2015 05:03PM Cc: Arkajit

Re: [Qemu-devel] [PATCH 02/11] iotests: add transactional incremental backup test

2015-03-11 Thread Kashyap Chamarthy
On Wed, Mar 11, 2015 at 10:25:13AM -0400, John Snow wrote: On 03/11/2015 08:11 AM, Kashyap Chamarthy wrote: [. . .] To test, I applied these two series to yesterday's QEMU git master: [PATCH 00/11] block: incremental backup transactions [PATCH v2 00/17] block: transactionless

Re: [Qemu-devel] [PATCH v4 3/3] hw/intc/arm_gic: Initialize the vgic in the realize function

2015-03-11 Thread Peter Maydell
On 4 March 2015 at 14:16, Eric Auger eric.au...@linaro.org wrote: This patch forces vgic initialization in the vgic realize function. It uses a new group/attribute that allows such operation: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT This earlier initialization allows, for example,

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] qapi: Add optional field name to block dirty bitmap

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:48PM -0500, John Snow wrote: From: Fam Zheng f...@redhat.com This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not

[Qemu-devel] [PULL 2/2] target-mips: add missing MSACSR and restore fp_status and hflags

2015-03-11 Thread Leon Alrae
Save MSACSR state. Also remove fp_status, msa_fp_status, hflags and restore them in post_load() from the architectural registers. Float exception flags are not present in vmstate. Information they carry is used only by softfloat caller who translates them into MIPS FCSR.Cause, FCSR.Flags and then

[Qemu-devel] [PULL 0/2] target-mips queue

2015-03-11 Thread Leon Alrae
remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-03-11 11:12:35 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150311 for you to fetch changes up to 64457e7ca9f26d633a59c202a297113a796c: target-mips: add missing

Re: [Qemu-devel] [PATCH v2 11/17] qmp: Add dirty bitmap status fields in query-block

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:57PM -0500, John Snow wrote: Adds the disabled and frozen status booleans. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com --- block.c | 2 ++ qapi/block-core.json | 7

Re: [Qemu-devel] [PULL] virtio-serial: fix segfault on NULL port names

2015-03-11 Thread Peter Maydell
On 11 March 2015 at 11:34, Amit Shah amit.s...@redhat.com wrote: The following changes since commit 4ba4df405c766b7f9e46ef145e140961155348e6: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2015-03-11 08:44:59 +) are available in the git repository

[Qemu-devel] [PATCH 1/9] mips/kvm: Drop KVM_REG_MIPS_COUNT_* definitions

2015-03-11 Thread James Hogan
The KVM_REG_MIPS_COUNT_* definitions are now included in linux-headers/asm-mips/kvm.h since commit b061808d39fa (linux-headers: update linux headers to kvm/next), therefore the duplicate definitions in target-mips/kvm.c can now be dropped. Signed-off-by: James Hogan james.ho...@imgtec.com Cc:

[Qemu-devel] [PULL 1/2] target-mips: replace cpu_save/cpu_load with VMStateDescription

2015-03-11 Thread Leon Alrae
Create VMStateDescription for MIPS CPU. The new structure contains exactly the same fields as before, therefore leaving existing version_id. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/cpu-qom.h | 4 + target-mips/cpu.c | 1 + target-mips/cpu.h | 2 -

[Qemu-devel] [Bug 1429841] Re: error rom: requested regions overlap for NOLOAD sections

2015-03-11 Thread Roman
To make things more easy I added some debug output to function rom_load_all(). It prints infos for every rom section is processes: rom phdr #1: 0MFWSL_EmoDatauP1_CUNIT.elf. free=0x, size=0x003c, addr=0x) rom phdr #2: 0MFWSL_EmoDatauP1_CUNIT.elf.

Re: [Qemu-devel] [Bug 1428958] [NEW] random IO errors / data corruption in VMs (created and executed via virt-manager)

2015-03-11 Thread Stefan Hajnoczi
On Fri, Mar 06, 2015 at 06:50:30AM -, Dmitry Sutyagin wrote: I have recurring problems with VM installation and usage - data on VM disk gets corrupted at some point and it causes all sorts of problems - sometimes I cannot even install base system, other times some .so files are corrupt

[Qemu-devel] [PATCH 0/9] mips/kvm: Support FPU SIMD (MSA) in MIPS KVM guests

2015-03-11 Thread James Hogan
This patchset primarily adds support for FPU and MIPS SIMD Architecture (MSA) in MIPS KVM guests to QEMU. It depends on the KVM patchset which I recently submitted to add the corresponding hypervisor support to KVM ([PATCH 00/20] MIPS: KVM: Guest FPU SIMD (MSA) support). All comments welcome.

[Qemu-devel] [PATCH 7/9] mips/kvm: Add FP MSA register definitions

2015-03-11 Thread James Hogan
Add the new floating point and MIPS SIMD Architecture (MSA) KVM register definitions to kvm.c. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Leon Alrae leon.al...@imgtec.com Cc: Aurelien Jarno aurel...@aurel32.net --- target-mips/kvm.c | 27

Re: [Qemu-devel] [PATCH 6/6] target-arm/cpu.h: document why env-spsr exists

2015-03-11 Thread Greg Bellows
On Wed, Feb 25, 2015 at 10:02 AM, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/17] block: Introduce bdrv_dirty_bitmap_granularity()

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:51PM -0500, John Snow wrote: This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/17] block: transactionless incremental backup series

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:46PM -0500, John Snow wrote: New topic, new version, same great incremental backup taste. This series relies on [Qemu-devel] [PULL 30/69] blkdebug: fix once rule, part of Stefan's 69 patch pull request submitted 2015-02-27. This patchset enables the in-memory

[Qemu-devel] [Bug 1428958] Re: random IO errors / data corruption in VMs (created and executed via virt-manager)

2015-03-11 Thread Dmitry Sutyagin
I have tried using qcow2 and the problem does not appear anymore. I guess it was a bug with VDI implementation indeed. Please close the ticket. Thank you very much for your help! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote: I like Alex's idea because: 1) It reflects pretty well the actual nature of the pci system in real s390 hw why do you say this? does real hw has this one device per bridge limit?

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-11 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote: Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: Hi, Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: Fixes a

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:20:00PM -0500, John Snow wrote: +static void dirty_bitmap_truncate(BdrvDirtyBitmap *bitmap, uint64_t size) +{ +/* Should only be frozen during a block backup job, which should have + * blocked any resize actions. */ +

Re: [Qemu-devel] [Qemu-block] [PATCH v2 07/17] block: Add bitmap disabled status

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:53PM -0500, John Snow wrote: Add a status indicating the enabled/disabled state of the bitmap. A bitmap is by default enabled, but you can lock the bitmap into a read-only state by setting disabled = true. A previous version of this patch added a QMP interface

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Kevin O'Connor
On Wed, Mar 11, 2015 at 01:45:57PM +, Dr. David Alan Gilbert wrote: * Bandan Das (b...@redhat.com) wrote: Dr. David Alan Gilbert dgilb...@redhat.com writes: while true; do (sleep 5; echo -e '\001cq\n')|/opt/qemu-try-world3/bin/qemu-system-x86_64 -machine pc-i440fx-2.0,accel=kvm

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-03-11 Thread Alberto Garcia
On Thu, Mar 05, 2015 at 03:09:58PM +0100, Kevin Wolf wrote: { 'command': 'block-stream', - 'data': { 'device': 'str', '*base': 'str', '*backing-file': 'str', -'*speed': 'int', '*on-error': 'BlockdevOnError' } } + 'data': { 'device': 'str', '*base': 'str', '*top': 'str', +

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Dr. David Alan Gilbert
* Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 03:53:07PM +, Dr. David Alan Gilbert wrote: * Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 01:45:57PM +, Dr. David Alan Gilbert wrote: * Bandan Das (b...@redhat.com) wrote: Dr. David

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Kevin O'Connor
On Wed, Mar 11, 2015 at 03:53:07PM +, Dr. David Alan Gilbert wrote: * Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 01:45:57PM +, Dr. David Alan Gilbert wrote: * Bandan Das (b...@redhat.com) wrote: Dr. David Alan Gilbert dgilb...@redhat.com writes: while

Re: [Qemu-devel] [PATCH] acpi: specify format for build_append_namestring

2015-03-11 Thread Igor Mammedov
On Wed, 11 Mar 2015 07:55:20 +0100 Michael S. Tsirkin m...@redhat.com wrote: Will catch users if we misused it. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/aml-build.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH 2/9] mips/kvm: Remove a couple of noisy DPRINTFs

2015-03-11 Thread James Hogan
The DPRINTFs in cpu_mips_io_interrupts_pending() and kvm_arch_pre_run() are particularly noisy during normal execution, and also not particularly helpful. Remove them so that more important debug messages can be more easily seen. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Paolo Bonzini

[Qemu-devel] [PATCH 8/9] mips/kvm: Support FPU in MIPS KVM guests

2015-03-11 Thread James Hogan
Support the new KVM_CAP_MIPS_FPU capability, which allows the host's FPU to be exposed to the KVM guest. The capability is enabled if the guest core has an FPU according to its Config1 register. Various config bits are now writeable so that KVM is aware of the configuration (Config1.FP) and so

[Qemu-devel] [PATCH 9/9] mips/kvm: Support MSA in MIPS KVM guests

2015-03-11 Thread James Hogan
Support the new KVM_CAP_MIPS_MSA capability, which allows MIPS SIMD Architecture (MSA) to be exposed to the KVM guest. The capability is enabled if the guest core has MSA according to its Config3 register. Various config bits are now writeable so that KVM is aware of the configuration

[Qemu-devel] [PATCH 4/9] mips/kvm: Implement Config CP0 registers

2015-03-11 Thread James Hogan
Implement saving and restoring to KVM state of the Config CP0 registers (namely Config, Config1, Config2, Config3, Config4, and Config5). These control the features available to a guest, and a few of the fields will soon be writeable by a guest so QEMU needs to know about them so as not to clobber

Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/17] qmp: Ensure consistent granularity type

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:49PM -0500, John Snow wrote: We treat this field with a variety of different types everywhere in the code. Now it's just uint32_t. Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: John Snow js...@redhat.com ---

[Qemu-devel] [PULL 14/25] machine: query mem-merge machine property

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Running qemu-bin ... -machine pc,mem-merge=on leads to crash: x86_64-softmmu/qemu-system-x86_64 -machine pc,dump-guest-core=on qemu-system-x86_64: qemu/util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `opt-desc opt-desc-type ==

Re: [Qemu-devel] fw_cfg specification ?

2015-03-11 Thread Gabriel L. Somlo
On Wed, Mar 11, 2015 at 07:50:40PM +0100, Laszlo Ersek wrote: On 03/11/15 16:27, Gabriel L. Somlo wrote: Hi, I'm looking for the closest thing to an official spec for qemu's fw_cfg device, and so far I have found this:

Re: [Qemu-devel] [PATCH v4 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-03-11 Thread Eric Blake
On 03/10/2015 06:14 AM, Quan Xu wrote: --Changes in v4: -qapi schema enhancement. -remove no need code. Patch history belongs... Signed-off-by: Quan Xu quan...@intel.com --- ...here. It is useful to reviewers to know what changed since your last submission, but not useful for the

Re: [Qemu-devel] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Greg Kurz
On Wed, 11 Mar 2015 21:06:05 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 11, 2015 at 07:04:38PM +0100, Greg Kurz wrote: vhost is seriously broken with ppc64le guests, even in the supposedly supported case where the host is ppc64le and we don't need cross-endian support.

[Qemu-devel] [PULL 13/25] machine: query dump-guest-core machine property

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Running qemu-bin ... -machine pc,dump-guest-core=on leads to crash: x86_64-softmmu/qemu-system-x86_64 -machine pc,dump-guest-core=on qemu-system-x86_64: qemu/util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `opt-desc

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-11 Thread Andrew Jones
On Wed, Mar 11, 2015 at 05:02:00PM +, Peter Maydell wrote: On 10 March 2015 at 21:06, Andrew Jones drjo...@redhat.com wrote: This patch makes the following changes to the determination of whether an address is executable, when translating addresses using LPAE. 1. No longer assumes

[Qemu-devel] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Greg Kurz
vhost is seriously broken with ppc64le guests, even in the supposedly supported case where the host is ppc64le and we don't need cross-endian support. The TX virtqueue fails to be handled by vhost and falls back to QEMU. Despite this unexpected scenario where RX is vhost and TX is QEMU, the guest

Re: [Qemu-devel] [PATCH v3 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-11 Thread Peter Maydell
On 11 March 2015 at 18:06, Andrew Jones drjo...@redhat.com wrote: +if (is_aa64) { +switch (regime_el(env, mmu_idx)) { +case 1: +if (is_user !(user_rw PAGE_READ)) { +wxn = 0; I still can't figure out the point of this. This conditional will

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Bandan Das
Dr. David Alan Gilbert dgilb...@redhat.com writes: * Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 04:52:03PM +, Dr. David Alan Gilbert wrote: * Kevin O'Connor (ke...@koconnor.net) wrote: So, I couldn't get this to fail on my older AMD machine at all with the

[Qemu-devel] [PATCH v4 1/3] target-arm: convert check_ap to ap_to_rw_prot

2015-03-11 Thread Andrew Jones
Instead of mixing access permission checking with access permissions to page protection flags translation, just do the translation, and leave it to the caller to check the protection flags against the access type. Also rename to ap_to_rw_prot to better describe the new behavior. Signed-off-by:

[Qemu-devel] [PATCH v4 0/3] tcg-arm: LPAE: fix and extend xn control

2015-03-11 Thread Andrew Jones
This series fixes and extends the determination of whether or not an address is executable for LPAE translations. The main patch is 3/3, and describes the details in its commit message. Patch 1/3 prepares for patch 2/3, which is prep for 3/3, and also fixes a potential problem with checking access

[Qemu-devel] [PATCH v4 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-11 Thread Andrew Jones
This patch makes the following changes to the determination of whether an address is executable, when translating addresses using LPAE. 1. No longer assumes that PL0 can't execute when it can't read. It can in AArch64, a difference from AArch32. 2. Use va_size == 64 to determine we're in

Re: [Qemu-devel] [PATCH 0/2] virtio-s390: Convert to realize()

2015-03-11 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Christian Borntraeger borntrae...@de.ibm.com writes: Am 27.02.2015 um 14:55 schrieb Markus Armbruster: Markus Armbruster (2): virtio-s390: s390_virtio_device_init() can't fail, simplify virtio-s390: Convert to realize()

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Dr. David Alan Gilbert
* Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 02:45:31PM -0400, Kevin O'Connor wrote: On Wed, Mar 11, 2015 at 02:40:39PM -0400, Kevin O'Connor wrote: For what it's worth, I can't seem to trigger the problem if I move the cmos read above the SIPI/LAPIC code (see

[Qemu-devel] [PULL 12/25] hw/boards: make it safe to include for linux-user

2015-03-11 Thread Michael S. Tsirkin
Make it safe to include hw/boards.h in exec.c for linux-user configurations. We don't need any of its contents though. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/boards.h | 4 1 file changed, 4 insertions(+) diff --git a/include/hw/boards.h b/include/hw/boards.h index

[Qemu-devel] [PULL 10/25] machine: query kvm-shadow-mem machine property

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Commit e79d5a6 (machine: remove qemu_machine_opts global list) removed the global option descriptions and moved them to MachineState's QOM properties. Query kvm-shadow-mem by accessing machine properties through designated wrappers. Signed-off-by: Marcel

[Qemu-devel] [PULL 02/25] aml-build: append opcodes using build_append_byte

2015-03-11 Thread Michael S. Tsirkin
Opcodes are raw bytes, they shouldn't be added using build_append_int. This only happens to work with 0 and 1 opcodes. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/aml-build.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PULL 03/25] acpi: fix aml_equal term implementation

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com The DefLEqual op does not have a target operand. Remove it. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com

[Qemu-devel] [PULL 24/25] virtio-scsi: clean out duplicate cdb field

2015-03-11 Thread Michael S. Tsirkin
cdb is now part of cmd, drop it from req. There's also nothing to check using build assert now. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com --- include/hw/virtio/virtio-scsi.h | 7 +-- hw/scsi/virtio-scsi.c | 2 +- 2 files changed,

[Qemu-devel] [PULL 25/25] virtio-scsi: remove empty wrapper for cmd

2015-03-11 Thread Michael S. Tsirkin
The anonymous struct only has a single field now, drop the wrapper structure. Suggested-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com --- include/hw/virtio/virtio-scsi.h | 4 +--- 1 file changed, 1

[Qemu-devel] [PULL 19/25] acpi: specify format for build_append_namestring

2015-03-11 Thread Michael S. Tsirkin
Will catch users if we misused it. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/aml-build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index ace180b..6242908 100644 ---

Re: [Qemu-devel] [PATCH v3] block/null: Latency simulation by adding new option latency-ns

2015-03-11 Thread Eric Blake
On 03/10/2015 11:42 PM, Fam Zheng wrote: Aio context switch should just work because the requests will be drained, so the scheduled timer(s) on the old context will be freed. Signed-off-by: Fam Zheng f...@redhat.com --- v3: latency_ns - latency-ns; Add documentation in qapi json. [Eric]

Re: [Qemu-devel] fw_cfg specification ?

2015-03-11 Thread Laszlo Ersek
On 03/11/15 21:45, Gabriel L. Somlo wrote: On Wed, Mar 11, 2015 at 07:50:40PM +0100, Laszlo Ersek wrote: On 03/11/15 16:27, Gabriel L. Somlo wrote: Hi, I'm looking for the closest thing to an official spec for qemu's fw_cfg device, and so far I have found this:

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Kevin O'Connor
On Wed, Mar 11, 2015 at 04:52:03PM +, Dr. David Alan Gilbert wrote: * Kevin O'Connor (ke...@koconnor.net) wrote: So, I couldn't get this to fail on my older AMD machine at all with the default SeaBIOS code. But, when I change the code with the patch below, it failed right away. [...]

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-11 Thread Peter Maydell
On 11 March 2015 at 18:30, Andrew Jones drjo...@redhat.com wrote: My interpretation of SCTLR_EL1.WXN was just wrong. There is talks about EL10 That's just the name of the translation regime (ie there's a shared set of page tables that handle translation for both EL1 and EL0). and I assumed it

Re: [Qemu-devel] fw_cfg specification ?

2015-03-11 Thread Laszlo Ersek
On 03/11/15 16:27, Gabriel L. Somlo wrote: Hi, I'm looking for the closest thing to an official spec for qemu's fw_cfg device, and so far I have found this: http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00238.html but it apparently never got committed to qemu (any idea why

[Qemu-devel] [PULL 18/25] MAINTAINERS: drop aligu...@amazon.com

2015-03-11 Thread Michael S. Tsirkin
It's sad when a friend leaves, but we have to move on. Drop Anthony's email from MAINTAINERS so he stops getting irrelevant email. Got Anthony's ack off-list. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Anthony Liguori aligu...@amazon.com --- MAINTAINERS | 9 - 1 file

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote: On Tue, Mar 10, 2015 at 03:26:23PM +0100, Michael S. Tsirkin wrote: On Tue, Mar 10, 2015 at 02:03:34PM +0100, Frank Blaschka wrote: This patch changes the modeling of the s390 qemu pci infrastructure to better match the

Re: [Qemu-devel] [RFC/WIP PATCH 6/6] memory: add clear_cache_to_poc

2015-03-11 Thread Andrew Jones
On Fri, Mar 06, 2015 at 01:53:38PM -0500, Andrew Jones wrote: Add a function that flushes the cache to PoC. We need a new function because __builtin___clear_cache only flushes to PoU. Call this function each time an address in a memory region that has been flagged as having an incoherent cache

Re: [Qemu-devel] [PATCH v2 5/6] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-11 Thread Greg Bellows
On Mon, Mar 9, 2015 at 8:26 AM, Christoffer Dall christoffer.d...@linaro.org wrote: On Wed, Mar 04, 2015 at 02:35:52PM +, Alex Bennée wrote: From: Christoffer Dall christoffer.d...@linaro.org The current code was negatively indexing the cpu state array and not synchronizing banked spsr

[Qemu-devel] [PULL 05/25] pci/shpc: fix signed integer overflow

2015-03-11 Thread Michael S. Tsirkin
clang undefined behaviour sanitizer reports: hw/pci/shpc.c:162:27: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Caused by the usual lack of a 'U' qualifier on a constant 1 being shifted left. Fix it up. Reported-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PULL 06/25] machine: replace qemu opts with iommu property

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Fixes a QEMU crash when passing iommu parameter in command line. Running x86_64-softmmu/qemu-system-x86_64 -machine pc,iommu=on -enable-kvm leads to crash: qemu-system-x86_64: qemu/util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion

[Qemu-devel] [PULL 01/25] aml-build: don't modify child

2015-03-11 Thread Michael S. Tsirkin
this code: aml_append(foo, bar); might, non-intuitively, modify bar, which means that e.g. the following might not DTRT: c = ; aml_append(a, c); aml_append(b, c); to fix, simply allocate an intermediate array, and always modify that. Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-11 Thread Michael Tokarev
11.03.2015 23:05, Michael Tokarev wrote: I sent a v3 (last) with correct version number, it has just 3 (rather big) patches: http://thread.gmane.org/gmane.comp.emulators.qemu/324157 . And this is what I think should be done (part of that thread), at least for the proxy code:

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Paolo Bonzini
On 11/03/2015 18:37, Kevin O'Connor wrote: I'm going to check the assembly for a compiler error, but is it possible QEMU is returning incorrect data in cmos index 0x5f? I checked the SeaBIOS assembler and it looks sane. So, I think the question is, why is QEMU sometimes returning a 0

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-11 Thread Peter Maydell
On 11 March 2015 at 17:42, Andrew Jones drjo...@redhat.com wrote: On Wed, Mar 11, 2015 at 05:02:00PM +, Peter Maydell wrote: +if (is_aa64) { +switch (regime_el(env, mmu_idx)) { +case 1: +if (is_user !user_rw) { +wxn = 0; I don't

Re: [Qemu-devel] [PULL 00/10] target-arm queue

2015-03-11 Thread Peter Maydell
On 11 March 2015 at 14:18, Peter Maydell peter.mayd...@linaro.org wrote: target-arm queue: mostly bug fixes, but also the Netduino 2 machine model. I'm letting that in (even though it's nearly hardfreeze) since a new board model isn't going to impact other existing uses, and the patches were

Re: [Qemu-devel] seabios stable release

2015-03-11 Thread Kevin O'Connor
On Wed, Mar 11, 2015 at 02:48:18PM +0100, Gerd Hoffmann wrote: Hi, Looks like we need a stable release branch for 1.8 and roll out a 1.8.1 release with some fixes for qemu. Issue #1: support for multiple pci roots. Issue #2: There is a (not-yet fixed) emulation failure with newer

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-11 Thread Andrew Jones
On Wed, Mar 11, 2015 at 06:15:47PM +, Peter Maydell wrote: On 11 March 2015 at 18:10, Andrew Jones drjo...@redhat.com wrote: On Wed, Mar 11, 2015 at 05:49:39PM +, Peter Maydell wrote: Still confused. If the page isn't readable or writable then WXN isn't going to kick in anyway

[Qemu-devel] [PATCH v4 2/3] target-arm: fix get_phys_addr_v6/SCTLR_AFE access check

2015-03-11 Thread Andrew Jones
Introduce simple_ap_to_rw_prot(), which has the same behavior as ap_to_rw_prot(), but takes the 2-bit simple AP[2:1] instead of the 3-bit AP[2:0]. Use this in get_phys_addr_v6 when SCTLR_AFE is set, as that bit indicates we should be using the simple AP format. It's unlikely this path is getting

[Qemu-devel] [PULL 21/25] virtio-scsi: drop duplicate CDB/SENSE SIZE

2015-03-11 Thread Michael S. Tsirkin
This is duplicated from the kernel header, drop our copy. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio-scsi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index de2c739..e4b531e 100644 ---

[Qemu-devel] [PULL 15/25] pci: Convert pci_nic_init() to Error to avoid qdev_init()

2015-03-11 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com qdev_init() is deprecated, and will be removed when its callers have been weaned off it. Signed-off-by: Markus Armbruster arm...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/pci.c |

Re: [Qemu-devel] [PATCH RFC v3 13/27] COLO RAM: Flush cached RAM into SVM's memory

2015-03-11 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We only need to flush RAM that is both dirty on PVM and SVM since last checkpoint. Besides, we must ensure flush RAM cache before load device state. Actually with a follow up to my previous question, can you explain the 'both' in that

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Bandan Das
Kevin O'Connor ke...@koconnor.net writes: On Wed, Mar 11, 2015 at 01:09:42PM -0400, Bandan Das wrote: Kevin O'Connor ke...@koconnor.net writes: ... Something is very odd here. When I run the above command (on an older AMD machine) I get: Found 128 cpu(s) max supported 128 cpu(s)

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Kevin O'Connor
On Wed, Mar 11, 2015 at 02:45:31PM -0400, Kevin O'Connor wrote: On Wed, Mar 11, 2015 at 02:40:39PM -0400, Kevin O'Connor wrote: For what it's worth, I can't seem to trigger the problem if I move the cmos read above the SIPI/LAPIC code (see patch below). Ugh! That's a seabios bug. Main

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Bandan Das
Dr. David Alan Gilbert dgilb...@redhat.com writes: * Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 02:45:31PM -0400, Kevin O'Connor wrote: On Wed, Mar 11, 2015 at 02:40:39PM -0400, Kevin O'Connor wrote: For what it's worth, I can't seem to trigger the problem if I move

Re: [Qemu-devel] Migration auto-converge problem

2015-03-11 Thread Jason J. Herne
On 03/02/2015 04:04 PM, Jason J. Herne wrote: We have a test case that dirties memory very very quickly. When we run this test case in a guest and attempt a migration, that migration never converges even when done with auto-converge on. The auto converge behavior of Qemu functions differently

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-11 Thread Andrey Korolyov
On Wed, Mar 11, 2015 at 10:33 PM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Kevin O'Connor (ke...@koconnor.net) wrote: On Wed, Mar 11, 2015 at 02:45:31PM -0400, Kevin O'Connor wrote: On Wed, Mar 11, 2015 at 02:40:39PM -0400, Kevin O'Connor wrote: For what it's worth, I can't seem

[Qemu-devel] [PULL 04/25] acpi-test: update expected files

2015-03-11 Thread Michael S. Tsirkin
commit ecdc7bab095a2cf29d9e9d4a7e1494f586a8b270 acpi: fix aml_equal term implementation dropped a useless Zero in generated code, update expected files appropriately. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- tests/acpi-test-data/pc/SSDT | Bin 2476 - 2475 bytes

[Qemu-devel] [PULL 07/25] machine: allowed/required kernel-irqchip support

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com The code using kernel-irqchip property requires 'allowed/required' functionality. Replace machine's kernel_irqchip field with two fields representing the new functionality and expose them through wrappers. Signed-off-by: Marcel Apfelbaum mar...@redhat.com

[Qemu-devel] [PULL 09/25] kvm: add machine state to kvm_arch_init

2015-03-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum mar...@redhat.com Needed to query machine's properties. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- include/sysemu/kvm.h

[Qemu-devel] [PULL 20/25] exec: don't include hw/boards for linux-user

2015-03-11 Thread Michael S. Tsirkin
As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code. Include it conditionally, and drop the (now unnecessary) ifdef guards in hw/boards.h Reported-by: Andreas Färber afaer...@suse.de Cc: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL 17/25] tpm: Move memory subregion function into realize function

2015-03-11 Thread Michael S. Tsirkin
From: Stefan Berger stef...@us.ibm.com Move the memory subregion function into the DeviceClass realize function due to isa_address_space (now) crashing if called in the instance init function. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Acked-by: Michael S. Tsirkin m...@redhat.com

Re: [Qemu-devel] [PATCH] windows build: -lssp added to qga-vss.dll libraries list

2015-03-11 Thread Stefan Weil
Am 11.03.2015 um 18:10 schrieb Joseph Hindin: When building qga-bss.dll with 64-bit mingw toolchain v. 4.9.2, the Typo: qga-vss.dll qga-vss.dll linking fails with unresolved symbols from libssp, stack protection support, like the following message: .../qga/vss-win32/install.cpp:52:

  1   2   3   4   >