Re: [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a

2015-03-15 Thread Mark Cave-Ayland
On 13/03/15 19:26, Richard Henderson wrote: As seen with ubuntu-5.10-live-powerpc.iso. Reported-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity

2015-03-15 Thread Paolo Bonzini
On 14/03/2015 11:07, Stefan Weil wrote: This fixes the memory leak, but I still don't understand what is done here. data is allocated, then filled with values, now it is also deallocated. But I'm missing the part where all those data is used. data escapes in

[Qemu-devel] Another solution for qga-vss stack protection issue

2015-03-15 Thread Joseph Hindin
qga/vss-win32/Makefile.objsi filters out -fstack-protector-all option from C++ flags, but with commit 63678e17c configure script may add option -fstack-protector-strong, depending on availability. The suggested change filters out both option for qga-vss.dll linking. Regards,

[Qemu-devel] [PATCH] gemu-ga-win: configure script may add -fstack-protector-strong option instead of -fstack-protector-all, depending on availability ( see commit 63678e17c ). Both options have to by

2015-03-15 Thread Joseph Hindin
Signed-off-by: Joseph Hindin jhin...@daynix.com --- qga/vss-win32/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/Makefile.objs b/qga/vss-win32/Makefile.objs index 6a69d50..7c96c6b 100644 --- a/qga/vss-win32/Makefile.objs +++

[Qemu-devel] IO port 0x61 is multiple used

2015-03-15 Thread Weidong Huang
Hi ALL: IO port 0x61 is used by pc speaker and NMI reason port. This is ambiguous. How to distinguish in QEMU? I see that NMI reason port is not realized in QEMU. But linux guest will access this port to determine what the NMI reason code means. It will access pc speaker's io port. Is this a

Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity

2015-03-15 Thread Paolo Bonzini
On 15/03/2015 11:23, Michael Tokarev wrote: Or, alternatively, to keep this `data' pointer in sdp to use it in bt_l2cap_sdp_close_ch(). Yes. In any case, it seems simpler to just leave this code aside. How many times this code is called? We have many many places in qemu where resources

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Chen Gang
At present, I finished the first system call successfully (it is uname called by glibc). If no additional reply of this thread within 3 days, I shall send a new patch which will include system call implementation. Thanks. On 3/14/15 14:03, Chen Gang wrote: QEMU TILE-Gx can decode bundle,

[Qemu-devel] live migration fails after host kernel upgrade (3.12 = 3.18)

2015-03-15 Thread Stefan Priebe
Hi, after upgrading the host kernel from 3.12 to 3.18 live migration fails with the following qemu output (guest running on a host with 3.12 = host with 3.18): kvm: Features 0x30afffe3 unsupported. Allowed features: 0x79bfbbe7 qemu: warning: error while loading state for instance 0x0 of

Re: [Qemu-devel] Get the memory trace

2015-03-15 Thread Peter Maydell
On 14 March 2015 at 13:54, Wenjie Liu lwj0...@gmail.com wrote: Hi all, Recently, I am trying to get the memory trace from qemu. Since I am using qemu by Marss, so the version of qemu is 0.14. For upstream QEMU, 0.14 is extremely ancient history by now, I'm afraid (it's four years old, and the

[Qemu-devel] [PATCH v3] vl: fix resource leak with monitor_fdset_add_fd

2015-03-15 Thread Paolo Bonzini
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP command add_fd). Free it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: line length [Fam], pass error_abort [Shannon] v2-v3: use !! instead of ? true : false [Markus] --- vl.c | 6 -- 1 file

Re: [Qemu-devel] [PATCH] kvm: fix ioeventfd endianness on bi-endian architectures

2015-03-15 Thread Paolo Bonzini
On 13/03/2015 22:30, Patchew Tool wrote: This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/20150313212337.31142.3991.stgit@bahia.local I'll fix this

Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity

2015-03-15 Thread Michael Tokarev
15.03.2015 12:21, Paolo Bonzini wrote: On 14/03/2015 11:07, Stefan Weil wrote: This fixes the memory leak, but I still don't understand what is done here. data is allocated, then filled with values, now it is also deallocated. But I'm missing the part where all those data is used. data

Re: [Qemu-devel] [PATCH] linux-user: Add missing check for return value of lock_user

2015-03-15 Thread Peter Maydell
On 14 March 2015 at 15:12, Stefan Weil s...@weilnetz.de wrote: This fixes a warning from Coverity: Dereference null return value (NULL_RETURNS) Signed-off-by: Stefan Weil s...@weilnetz.de --- linux-user/flatload.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Andreas Färber
Am 15.03.2015 um 15:19 schrieb Chen Gang: If no additional reply of this thread within 3 days, I shall send a new patch which will include system call implementation. Please use a proper subject then, saying what it does (rather what works afterwards). In particular don't forget target-tilegx:.

Re: [Qemu-devel] [PATCH 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-15 Thread Gavin Shan
On Fri, Mar 13, 2015 at 03:33:50PM -0600, Alex Williamson wrote: On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote: The PCI device MSIx table is cleaned out in hardware after EEH PE reset. However, we still hold the stale MSIx entries in QEMU, which should be cleared accordingly. Otherwise,

Re: [Qemu-devel] [qemu] How to reliably obtain physaddr from vaddr

2015-03-15 Thread Richard Henderson
On 03/15/2015 03:00 AM, Emilio G. Cota wrote: On a TLB hit this is trivial (just do nothing), but on a TLB miss I'm lost on what to do--I cannot even follow where helper_ld/st go (grep doesn't help), although I suspect it's TCG backend ops and I don't see an obvious way of adding a new

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Peter Maydell
On 14 March 2015 at 06:03, Chen Gang xili_gchen_5...@hotmail.com wrote: QEMU TILE-Gx can decode bundle, disassemble code, and generate tcg code for 1st TB block (__start). Then directly jump to __libc_start_main (2nd TB block). In __libc_start_main, it can continue executing to the first

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Chen Gang
On 3/16/15 00:50, Andreas Färber wrote: Am 15.03.2015 um 15:19 schrieb Chen Gang: If no additional reply of this thread within 3 days, I shall send a new patch which will include system call implementation. Please use a proper subject then, saying what it does (rather what works

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Peter Maydell
On 15 March 2015 at 23:08, Chen Gang xili_gchen_5...@hotmail.com wrote: On 3/16/15 00:50, Andreas Färber wrote: Am 15.03.2015 um 15:19 schrieb Chen Gang: If no additional reply of this thread within 3 days, I shall send a new patch which will include system call implementation. Please use a

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Chen Gang
On 3/16/15 07:44, Peter Maydell wrote: On 15 March 2015 at 23:08, Chen Gang xili_gchen_5...@hotmail.com wrote: On 3/16/15 00:50, Andreas Färber wrote: Am 15.03.2015 um 15:19 schrieb Chen Gang: If no additional reply of this thread within 3 days, I shall send a new patch which will include

Re: [Qemu-devel] [PATCH v4 0/7] QEMU memory hot unplug support

2015-03-15 Thread Zhu Guihua
On 03/13/2015 07:07 PM, Igor Mammedov wrote: On Fri, 13 Mar 2015 14:05:08 +0800 Zhu Guihua zhugh.f...@cn.fujitsu.com wrote: ping... I can't find v4 series in my mailbox nor on list archives, perhaps it got lost somewhere, could you resend rebased version on top of current master, pls? OK,

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Chen Gang
On 3/16/15 07:45, Peter Maydell wrote: On 14 March 2015 at 06:03, Chen Gang xili_gchen_5...@hotmail.com wrote: QEMU TILE-Gx can decode bundle, disassemble code, and generate tcg code for 1st TB block (__start). Then directly jump to __libc_start_main (2nd TB block). In __libc_start_main, it

Re: [Qemu-devel] [qemu] How to reliably obtain physaddr from vaddr

2015-03-15 Thread Emilio G. Cota
On Sun, Mar 15, 2015 at 16:10:21 -0700, Richard Henderson wrote: On 03/15/2015 03:00 AM, Emilio G. Cota wrote: On a TLB hit this is trivial (just do nothing), but on a TLB miss I'm lost on what to do--I cannot even follow where helper_ld/st go (grep doesn't help), although I suspect it's

Re: [Qemu-devel] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-15 Thread Gavin Shan
On Fri, Mar 13, 2015 at 03:51:27PM -0600, Alex Williamson wrote: On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote: When Linux guest recovers from EEH error on the following Emulex adapter, the MSIx interrupts are disabled and the INTx emulation is enabled. One INTx interrupt is injected to

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-15 Thread Chen, Tiejun
On 2015/3/13 18:11, Ian Campbell wrote: On Fri, 2015-03-13 at 09:39 +0800, Chen, Tiejun wrote: I don't think you can abort here, since a user can set b_info-u.hvm.gfx_passthru_kind to default. You would need to return an error. Then, looks I should do this, LOG(ERROR, No supported IGD to

Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak

2015-03-15 Thread zhanghailiang
On 2015/3/14 17:52, Shannon Zhao wrote: It's detected by coverity. Close the dirfd. Reviewed-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- v1-v2: close after use [Stefan

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-15 Thread Michael S. Tsirkin
On Fri, Mar 13, 2015 at 02:28:20PM +0800, Fam Zheng wrote: On Fri, 03/13 14:07, Fam Zheng wrote: On Thu, 03/12 12:15, Michael S. Tsirkin wrote: On Thu, Mar 12, 2015 at 11:04:33AM +, Peter Maydell wrote: On 12 March 2015 at 10:57, Michael S. Tsirkin m...@redhat.com wrote: This

[Qemu-devel] [PATCH] fsdev/virtfs-proxy-helper: Fix improper use of negative value

2015-03-15 Thread Shannon Zhao
It's detected by coverity. Check the return value of proxy_marshal. Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- fsdev/virtfs-proxy-helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fsdev/virtfs-proxy-helper.c

Re: [Qemu-devel] [PATCH v5 2/7] aer: impove pcie_aer_init to support vfio device

2015-03-15 Thread Chen Fan
On 03/14/2015 06:25 AM, Alex Williamson wrote: On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: pcie_aer_init was used to emulate an aer capability for pcie device, but for vfio device, the aer config space size is mutable and is not always equal to PCI_ERR_SIZEOF(0x48). it depends on where

Re: [Qemu-devel] [PATCH v5 0/7] pass aer error to guest for vfio device

2015-03-15 Thread Chen Fan
Cc: Michael S. Tsirkin On 03/12/2015 06:23 PM, Chen Fan wrote: For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error occurred but stop the guest, so this patches add aer capability

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-15 Thread Chen Fan
On 03/14/2015 06:34 AM, Alex Williamson wrote: On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked.

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-15 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Fri, Mar 13, 2015 at 11:47:18AM +1030, Rusty Russell wrote: Here's my proposed spec patch, which spells this out: diff --git a/content.tex b/content.tex index 6ba079d..b6345a8 100644 --- a/content.tex +++ b/content.tex @@ -600,10 +600,19 @@

Re: [Qemu-devel] [PATCH v5 0/7] pass aer error to guest for vfio device

2015-03-15 Thread Michael S. Tsirkin
On Mon, Mar 16, 2015 at 10:52:52AM +0800, Chen Fan wrote: Cc: Michael S. Tsirkin On 03/12/2015 06:23 PM, Chen Fan wrote: For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-15 Thread Michael S. Tsirkin
On Mon, Mar 16, 2015 at 01:44:22PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Mar 13, 2015 at 11:47:18AM +1030, Rusty Russell wrote: Here's my proposed spec patch, which spells this out: diff --git a/content.tex b/content.tex index 6ba079d..b6345a8

Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type

2015-03-15 Thread Fam Zheng
On Fri, 03/13 13:28, Paolo Bonzini wrote: On 13/03/2015 13:23, Alberto Garcia wrote: On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote: Throttle timers won't make any progress when VCPU is not running, which is prone to stall the request queue in cases like utils, qtest,

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-15 Thread Chen Fan
On 03/14/2015 06:38 AM, Alex Williamson wrote: On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: for piix4 chipset, we don't need to expose aer, so introduce PC_I440FX_COMPAT for all piix4 machines to disable aercap, and add HW_COMPAT_2_2 to disable aercap for all lower than 2.3. 440FX is

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-15 Thread Alex Williamson
On Mon, 2015-03-16 at 11:05 +0800, Chen Fan wrote: On 03/14/2015 06:34 AM, Alex Williamson wrote: On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device,

Re: [Qemu-devel] [PATCH qemu] pseries: Update SLOF firmware image to qemu-slof-20150313

2015-03-15 Thread Alexey Kardashevskiy
On 03/13/2015 10:45 PM, Alexey Kardashevskiy wrote: The changelog is: virtio: Fix vring allocation helpers: Fix SLOF_alloc_mem_aligned to meet callers expectation Set default palette according to 16-color Text Extension document Fix rectangle drawing functions to work also with

[Qemu-devel] [PATCH qemu] profiler: Reenable built-in profiler

2015-03-15 Thread Alexey Kardashevskiy
2ed1ebcf6 timer: replace time() with QEMU_CLOCK_HOST broke compile when configured with --enable-profiler. Turned out the profiler has been broken for a while. This does s/qemu_time/tcg_time/ as the profiler only works in a TCG mode. This also fixes the compile error. This changes

Re: [Qemu-devel] [Qemu-Dev-QUERY] Related to Live Migration source Code or API for NUMA Node specific

2015-03-15 Thread Arkajit Ghosh
Hi Team, Can anyone please provide their point of views related to my below query. Thanks Regards Arkajit Ghosh -Arkajit Ghosh/DEL/TCS wrote: - To: qemu-devel@nongnu.org From: Arkajit Ghosh/DEL/TCS Date: 03/12/2015 02:28PM Subject: Re:

Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak

2015-03-15 Thread Shannon Zhao
On 2015/3/14 17:56, Stefan Weil wrote: Am 14.03.2015 um 10:52 schrieb Shannon Zhao: It's detected by coverity. Close the dirfd. Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- v1-v2: close after use [Stefan Weil] ---

Re: [Qemu-devel] virtio fixes pull for 4.0?

2015-03-15 Thread Michael S. Tsirkin
On Mon, Mar 09, 2015 at 05:43:19PM +1030, Rusty Russell wrote: I think it's a good idea to merge these patches (maybe except the !TASK_RUNNING thing) sooner rather than later, to make sure people have the time to test the fixes properly. Would you like me to pack up (some of them) them up

[Qemu-devel] [PATCH v3 3/4] exec: Notify cpu_register_map_client caller if the bounce buffer is available

2015-03-15 Thread Fam Zheng
The caller's workflow is like if (!address_space_map()) { ... cpu_register_map_client(); } If bounce buffer became available after address_space_map() but before cpu_register_map_client(), the caller could miss it and has to wait for the next bounce buffer notify, which

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-15 Thread Chen Fan
On 03/14/2015 06:38 AM, Alex Williamson wrote: On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: for piix4 chipset, we don't need to expose aer, so introduce PC_I440FX_COMPAT for all piix4 machines to disable aercap, and add HW_COMPAT_2_2 to disable aercap for all lower than 2.3. 440FX is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-15 Thread Benjamin Herrenschmidt
On Mon, 2015-03-16 at 12:04 +1100, Gavin Shan wrote: (2) QEMU sends IOCTL commands to host to disable MSIx and enable INTx. At this stage the INTx is still masked. At later point, the guest is requesting unmasking INTx, which is captured by host. Host checks and founds pending INTx, which

Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak

2015-03-15 Thread Shannon Zhao
On 2015/3/16 9:27, zhanghailiang wrote: On 2015/3/14 17:52, Shannon Zhao wrote: It's detected by coverity. Close the dirfd. Reviewed-by: zhanghailiang zhang.zhanghaili...@huawei.com Hi zhanghailiang, Thanks for your review. Shannon Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com

Re: [Qemu-devel] [RFC PATCH] target-ppc: Register CPU class per family only when needed

2015-03-15 Thread Alexey Kardashevskiy
On 03/06/2015 12:17 AM, Alexander Graf wrote: On 05.03.15 02:56, Alexey Kardashevskiy wrote: At the moment when running in KVM mode, QEMU registers host class to match the current CPU PVR value. It also registers another CPU class with a CPU family name os if we run QEMU on POWER7 machine,

[Qemu-devel] [PATCH v3 2/4] exec: Protect map_client_list with mutex

2015-03-15 Thread Fam Zheng
So that accesses from multiple threads are safe. Signed-off-by: Fam Zheng f...@redhat.com --- exec.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/exec.c b/exec.c index 4080044..3e54580 100644 --- a/exec.c +++ b/exec.c @@ -429,15 +429,6 @@

[Qemu-devel] [PATCH v3 0/4] exec: Make bounce buffer thread safe

2015-03-15 Thread Fam Zheng
v3: Address Paolo's comments: Use atomic_xchg for bounce buffer. Use mutex and BH for map_client_list. The global bounce buffer used for non-direct memory access is not thread-safe: 1) Access to bounce is not atomic. 2) Access to map_client_list is not atomic. 3) In dma_blk_cb,

[Qemu-devel] [PATCH v3 1/4] exec: Atomic access to bounce buffer

2015-03-15 Thread Fam Zheng
There could be a race condition when two processes call address_space_map concurrently and both want to use the bounce buffer. Add an in_use flag in BounceBuffer to sync it. Signed-off-by: Fam Zheng f...@redhat.com --- exec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 4/4] dma-helpers: Fix race condition of continue_after_map_failure and dma_aio_cancel

2015-03-15 Thread Fam Zheng
If DMA's owning thread cancels the IO while the bounce buffer's owning thread is notifying the cpu client list, a use-after-free happens: continue_after_map_failure dma_aio_cancel -- aio_bh_new