On Fri, May 15, 2015 at 3:26 PM, Peter Crosthwaite
wrote:
> On Wed, May 13, 2015 at 11:08 PM, Alistair Francis
> wrote:
>> Microblaze stack protection is configurable and isn't always enabled.
>> This patch allows the stack protection to be disabled from the CPU
>> properties.
>>
>> Signed-off-by
On 15/05/2015 08:34, Gerhard Wiesinger wrote:
> Helllo,
>
> I'm using latest qemu-kvm-2.3.0-3.fc21.x86_64 from libvirt repository
> (updated afterwards). Running yum regularly crashes the VM like below.
> VM is stripped down to minimum memory requirements (256MB) for owncloud.
> See below.
>
>
On 05/15/2015 02:45 PM, Paolo Bonzini wrote:
>
>
> On 15/05/2015 03:37, Wen Congyang wrote:
>> If bus_size is less than 0, the command fails.
>> If buf_size % granularity is not 0, mirror_free_init() will
>> do dangerous things.
>>
>> Signed-off-by: Wen Congyang
>> ---
>> block/mirror.c | 6 +++
On 15/05/2015 08:04, Fam Zheng wrote:
> @@ -111,6 +111,10 @@ static void
> virtio_scsi_iothread_handle_ctrl(EventNotifier *notifier)
> VirtIOSCSI *s = VIRTIO_SCSI(vring->parent);
> VirtIOSCSIReq *req;
>
> +if (s->pause_counter) {
> +virtio_scsi_stop_ioeventfd(s);
> +
On Mon, May 11, 2015 at 3:27 AM, Andreas Färber wrote:
> Hi,
>
> Am 11.05.2015 um 08:29 schrieb Peter Crosthwaite:
>> Microblaze translation needs a change pattern to allow conversion to 64-bit
>> TARGET_LONG. Uses of TCGv need to be removed and explicited to 32-bit.
>
> I did have a patchset doin
On 15/05/2015 03:37, Wen Congyang wrote:
> If bus_size is less than 0, the command fails.
> If buf_size % granularity is not 0, mirror_free_init() will
> do dangerous things.
>
> Signed-off-by: Wen Congyang
> ---
> block/mirror.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Hello!
> Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
> GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
> them.
>
> Signed-off-by: Ashok Kumar
I also work on this, just not published yet. Some notes about your version:
1. May be there should be hw
On Thu, May 14, 2015 at 11:36 PM, Alistair Francis
wrote:
> On Fri, May 15, 2015 at 4:32 PM, Peter Crosthwaite
> wrote:
>> On Thu, May 14, 2015 at 10:56 PM, Alistair Francis
>> wrote:
>>> On Fri, May 15, 2015 at 3:52 PM, Peter Crosthwaite
>>> wrote:
On Thu, May 14, 2015 at 10:48 PM, Alista
On Fri, May 15, 2015 at 4:32 PM, Peter Crosthwaite
wrote:
> On Thu, May 14, 2015 at 10:56 PM, Alistair Francis
> wrote:
>> On Fri, May 15, 2015 at 3:52 PM, Peter Crosthwaite
>> wrote:
>>> On Thu, May 14, 2015 at 10:48 PM, Alistair Francis
>>> wrote:
On Fri, May 15, 2015 at 3:22 PM, Peter C
Helllo,
I'm using latest qemu-kvm-2.3.0-3.fc21.x86_64 from libvirt repository
(updated afterwards). Running yum regularly crashes the VM like below.
VM is stripped down to minimum memory requirements (256MB) for owncloud.
See below.
Looks like a problem in virtio-net or a kernel bug with low
On Thu, May 14, 2015 at 10:56 PM, Alistair Francis
wrote:
> On Fri, May 15, 2015 at 3:52 PM, Peter Crosthwaite
> wrote:
>> On Thu, May 14, 2015 at 10:48 PM, Alistair Francis
>> wrote:
>>> On Fri, May 15, 2015 at 3:22 PM, Peter Crosthwaite
>>> wrote:
On Wed, May 13, 2015 at 11:08 PM, Alista
On 05/15/2015 02:04 PM, Fam Zheng wrote:
> It blocks device IO.
I am reading mirror codes recently, and have a question:
When block job mirror is finished, the source and target is synced. But we
call bdrv_swap() later(in bh context). Can the guest write something to
the source before the bh is sc
Should more ops be added to differentiate code between dataplane and
non-dataplane, the new saved_ops approach will be cleaner than messing
with N pointers.
Signed-off-by: Fam Zheng
---
hw/block/dataplane/virtio-blk.c | 13 -
hw/block/virtio-blk.c | 8 ++--
include/hw/
We don't want new requests from guest, so block the operation around the
nested poll.
It also avoids looping forever when iothread is submitting a lot of requests.
Signed-off-by: Fam Zheng
---
block/io.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a
When a disk is attached to scsi-bus, virtio_scsi_hotplug will take care
of protecting the block device with op blockers. Currently we haven't
enabled block jobs (like what's done in virtio_blk_data_plane_create),
but it is necessary to honor "device IO" op blocker first before we do.
This is useful
Signed-off-by: Fam Zheng
---
blockdev.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 7f763d9..923fc90 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1404,6 +1404,7 @@ typedef struct ExternalSnapshotState {
BlockDriverStat
Signed-off-by: Fam Zheng
---
blockdev.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index ae52d27..bd28183 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1649,6 +1649,7 @@ typedef struct BlockdevBackupState {
BlockDriverState *bs;
virtio-blk now listens to op blocker change of the associated block
backend.
Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO:
non-dataplane:
1) Set VirtIOBlock.paused
2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused
dataplane:
1) Clear the host event notifier
Signed-off-by: Fam Zheng
---
blockdev.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 923fc90..ae52d27 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1575,6 +1575,7 @@ typedef struct DriveBackupState {
BlockDriverState *bs;
AioCo
So that NBD export cannot submit IO during bdrv_drain_all().
Signed-off-by: Fam Zheng
---
nbd.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/nbd.c b/nbd.c
index 06b501b..7d9d3e4 100644
--- a/nbd.c
+++ b/nbd.c
@@ -160,6 +160,8 @@ struct NBDExport {
uint32_t nbdflag
Changes from v2, which covers virtio-scsi as well:
- Patch 1: Review all bdrv_op_block_all callers.
Document bdrv_op_blocker_add_notifier.
Fix blocking in bdrv_op_blocker_notify.
- Patch 11: Commit message and function comment update.
- Patch 12: New.
Reported by P
Signed-off-by: Fam Zheng
---
blockdev.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 5eaf77e..7f763d9 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1262,6 +1262,7 @@ typedef struct InternalSnapshotState {
BlockDriverState *bs;
Forward the call to bdrv_op_blocker_add_notifier.
Signed-off-by: Fam Zheng
---
block/block-backend.c | 6 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index 93e46f3..16efe60 100644
--- a/block/
BDS users can register a notifier and get notified about op blocker
changes.
Signed-off-by: Fam Zheng
---
block.c | 35 +++
include/block/block.h | 8
include/block/block_int.h | 3 +++
3 files changed, 46 insertions(+)
diff --git
It blocks device IO.
All bdrv_op_block_all/blk_op_block_all callers are taken care of:
- virtio_blk_data_plane_create
- virtio_scsi_hotplug
Device creation, unblock it.
- bdrv_set_backing_hd
Backing hd is not used by device, so blocking is OK.
- backup_start
Blocking target when backup
On Thu, May 14, 2015 at 09:49:51PM -0700, Peter Crosthwaite wrote:
> To prepare support for conversion of Microblaze TARGET_LONG to 64 bits.
> This in turn will then allow support for multi-arch QEMU including both
> Microblaze and 64-bit CPU targets (notably AArch64).
>
> Signed-off-by: Peter Cro
On Fri, May 15, 2015 at 3:52 PM, Peter Crosthwaite
wrote:
> On Thu, May 14, 2015 at 10:48 PM, Alistair Francis
> wrote:
>> On Fri, May 15, 2015 at 3:22 PM, Peter Crosthwaite
>> wrote:
>>> On Wed, May 13, 2015 at 11:08 PM, Alistair Francis
>>> wrote:
Originally the use-fpu PVR bits were man
On Thu, May 14, 2015 at 10:48 PM, Alistair Francis
wrote:
> On Fri, May 15, 2015 at 3:22 PM, Peter Crosthwaite
> wrote:
>> On Wed, May 13, 2015 at 11:08 PM, Alistair Francis
>> wrote:
>>> Originally the use-fpu PVR bits were manually set for each machine. This
>>> is a hassle and difficult to re
On Fri, May 15, 2015 at 3:22 PM, Peter Crosthwaite
wrote:
> On Wed, May 13, 2015 at 11:08 PM, Alistair Francis
> wrote:
>> Originally the use-fpu PVR bits were manually set for each machine. This
>> is a hassle and difficult to read, instead set them based on the CPU
>> properties.
>>
>> Signed-o
On Sun, May 10, 2015 at 11:29 PM, Peter Crosthwaite
wrote:
> These are architecture specific, and via cpu.h visibile in common
> and global namespaces. Preface them with "ARMAR_" to avoid namespace
> collisions. Prepares support for multi-arch where multiple cpu.h's
> can be included by device lan
On Sun, May 10, 2015 at 11:29 PM, Peter Crosthwaite
wrote:
> To be consistent with aarch64. Microblaze is still ulitmately only
> 32b. So all uses of the _tl tcg APIs and unqualified TCGv variables
> need to specified to their 32b variants.
I have split off the big bulk coversions into a single p
On Wed, May 13, 2015 at 11:08 PM, Alistair Francis
wrote:
> Microblaze stack protection is configurable and isn't always enabled.
> This patch allows the stack protection to be disabled from the CPU
> properties.
>
> Signed-off-by: Alistair Francis
> ---
>
> target-microblaze/cpu-qom.h |5
Adding "-d" option. The output goes to "tee" so it appears in your
console. Also, raise the verbosity of unnitest runner.
When testing a topic branch, it's possible that a bug introduced by a
code change makes the python test case hang, with debug output, it is
much easier to locate the problem.
On Wed, May 13, 2015 at 11:08 PM, Alistair Francis
wrote:
> Originally the use-fpu PVR bits were manually set for each machine. This
> is a hassle and difficult to read, instead set them based on the CPU
> properties.
>
> Signed-off-by: Alistair Francis
> ---
>
> hw/microblaze/petalogix_ml605_mm
Ping!
Richard has RB'd the core stuff but do we need CPU arch maintainer
acks on the latter patches?
What queue should this go via? TCG?
Regards,
Peter
On Sat, May 9, 2015 at 1:11 PM, Peter Crosthwaite
wrote:
> These two functions are mostly trying to do the same thing, which is
> disassemble
To prepare support for conversion of Microblaze TARGET_LONG to 64 bits.
This in turn will then allow support for multi-arch QEMU including both
Microblaze and 64-bit CPU targets (notably AArch64).
Signed-off-by: Peter Crosthwaite
---
target-microblaze/helper.c| 4 +-
target-microblaze/tran
Markus Armbruster writes:
> Bandan Das writes:
>
...
>> -static void user_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd,
>> +static int user_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd,
>> const QDict *params)
>> {
>> int ret;
>> @@ -954,
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This test case checks that it's not possible to perform two
> block-stream operations if there are nodes involved in both.
>
> Signed-off-by: Alberto Garcia
> Reviewed-by: Max Reitz
> ---
> tests/qemu-iotests/030 | 27 +++
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This test case checks that it's possible to launch several stream
> operations in parallel in the same snapshot chain, each one involving
> a different set of nodes.
>
> Signed-off-by: Alberto Garcia
> Reviewed-by: Max Reitz
Reviewed-by: Fam Zheng
If bus_size is less than 0, the command fails.
If buf_size % granularity is not 0, mirror_free_init() will
do dangerous things.
Signed-off-by: Wen Congyang
Reviewed-by: Fam Zheng
---
block/mirror.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/m
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This adds test_stream_intermediate(), similar to test_stream() but
> streams to the intermediate image instead.
>
> Signed-off-by: Alberto Garcia
> Reviewed-by: Max Reitz
Reviewed-by: Fam Zheng
> ---
> tests/qemu-iotests/030 | 18 +
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This patch tests that in a partial block-stream operation, no data is
> ever copied from the base image.
>
> Signed-off-by: Alberto Garcia
> Reviewed-by: Max Reitz
Reviewed-by: Fam Zheng
> ---
> tests/qemu-iotests/030 | 18 ++
>
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This test is streaming to the top layer using the intermediate image
> as the base. This is a mistake since block-stream never copies data
> from the base image and its backing chain, so this is effectively a
> no-op.
>
> In addition to fixing the base
On Wed, 05/13 16:27, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia
> Reviewed-by: Max Reitz
> Reviewed-by: Eric Blake
Reviewed-by: Fam Zheng
> ---
> docs/live-block-ops.txt | 31 ---
> 1 file changed, 20 insertions(+), 11 deletions(-)
>
> diff --git a/doc
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This patch makes the 'device' parameter of the 'block-stream' command
> accept a node name as well as a device name.
>
> In addition to that, operation blockers will be checked in all
> intermediate nodes between the top and the base node.
>
> Since qm
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This makes sure that the image we are steaming into is open in
> read-write mode during the operation.
>
> Operation blockers are also set in all intermediate nodes, since they
> will be removed from the chain afterwards.
>
> Finally, this also unblock
On 5/12/15 00:55, Richard Henderson wrote:
> On 05/10/2015 03:45 PM, Chen Gang wrote:
>>> +static void gen_cmpltsi(struct DisasContext *dc,
>>> +uint8_t rdst, uint8_t rsrc, int8_t imm8)
>>> +{
>>> +qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpltsi r%d, r%d, %d\n",
>>> +
Add bootloader support using standard ARM bootloader.
Reviewed-by: Alistair Francis
Tested-by: Alistair Francis
Signed-off-by: Peter Crosthwaite
---
changed since v4:
Add loader_start field
Make commit message body standalone.
hw/arm/xlnx-ep108.c | 9 +
1 file changed, 9 insertions(+)
Zynq MPSoC supports external DDR RAM. Add a RAM at 0 to the model.
Reviewed-by: Alistair Francis
Tested-by: Alistair Francis
Signed-off-by: Peter Crosthwaite
---
changed since v4:
Use memory_region_allocate_system_memory
Change too-small warning to be qemu_log
changed since v1:
Add ram size cla
On Thu, May 14, 2015 at 6:08 PM, Edgar E. Iglesias
wrote:
> On Mon, May 11, 2015 at 03:45:47PM -0700, Peter Crosthwaite wrote:
>> Hi Peter and all,
>>
>> Xilinx's next gen SoC has been announced. This series adds a SoC and
>> board.
>
>
> Hi Peter,
>
> Did you by accident send out v8 twice instead
Create a new header for Cadence GEM to allow using the device with
modern SoC programming conventions. The state struct needs to be
visible to embed the device in SoC containers.
Reviewed-by: Alistair Francis
Reviewed-by: Peter Maydell
Reviewed-by: Edgar E. Iglesias
Tested-by: Alistair Francis
Clean up some variable names in preparation for migrating the state struct
and type cast macro to a public header. The acronym "UART" on it's own is
not specific enough to be used in a more global namespace so preface with
"cadence". Fix the capitalisation of "uart" in the state type while touching
On Wed, 05/13 16:27, Alberto Garcia wrote:
> We need to call stream_complete() in order to do all the necessary
> clean-ups, even if there's an early failure. At the moment it's only
> useful to make sure that s->backing_file_str is not leaked, but it
> will become more important as we introduce su
There are 4x Cadence GEMs in ZynqMP. Add them.
Reviewed-by: Peter Maydell
Tested-by: Alistair Francis
Signed-off-by: Peter Crosthwaite
---
changed since v4:
Remove use of ERR_PROP_CHECK_RETURN
hw/arm/xlnx-zynqmp.c | 35 +++
include/hw/arm/xlnx-zynqmp.h
Create a new header for Cadence UART to allow using the device with
modern SoC programming conventions. The state struct needs to be
visible to embed the device in SoC containers.
Reviewed-by: Alistair Francis
Reviewed-by: Peter Maydell
Reviewed-by: Edgar E. Iglesias
Tested-by: Alistair Francis
Cleanup some variable names in preparation for migrating the state
struct and type cast macro to a public header. The acronym "GEM" on
its own is not specific enough to be used in a more global namespace
so preface with "cadence". Fix the capitalisation of "gem" in the
state type while touching the
Connect the GPIO outputs from the individual CPUs for the timers to the
GIC.
Tested-by: Alistair Francis
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Peter Crosthwaite
---
changed since v4:
Use macro for GIC_INTERNAL
hw/arm/xlnx-zynqmp.c | 17 +
1 file changed, 17 insertions(
Add a machine model for the Xilinx ZynqMP SoC EP108 board.
Reviewed-by: Alistair Francis
Reviewed-by: Peter Maydell
Reviewed-by: Edgar E. Iglesias
Tested-by: Alistair Francis
Signed-off-by: Peter Crosthwaite
---
Chaned since v1:
Change board name to ep108
hw/arm/Makefile.objs | 2 +-
hw/ar
With quad Cortex-A53 CPUs.
Use SMC PSCI, with the standard policy of secondaries starting in
power-off.
Tested-by: Alistair Francis
Reviewed-by: Alistair Francis
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Peter Crosthwaite
---
changed since v4 (PMM review):
Squashed in PSCI stuffs.
Add (c)
Add the ARM Cortex-A53 processor definition. Similar to A57, but with
different L1 I cache policy, phys addr size and different cache
geometries. The cache sizes is implementation configurable, but use
these values (from Xilinx Zynq MPSoC) as a default until cache size
configurability is added.
Ac
There are 2x Cadence UARTs in Zynq MP. Add them.
Reviewed-by: Alistair Francis
Reviewed-by: Peter Maydell
Tested-by: Alistair Francis
Signed-off-by: Peter Crosthwaite
---
Changed since v4:
Remove ERR_PROP_CHECK_RETURN usage.
Changed since v1:
Fixed "UARTSs" typo
hw/arm/xlnx-zynqmp.c
Rename some A57 CP register variables in preparation for support for
Cortex A53. Use "a57_a53" to describe the shareable features. Some of
the CP15 registers (such as ACTLR) are specific to implementation, but
we currently just RAZ them so continue with that as the policy for both
A57 and A53 proce
Add the GIC and connect IRQ outputs to the CPUs. The GIC regions are
under-decoded through a 64k address region so implement aliases
accordingly.
Signed-off-by: Peter Crosthwaite
---
changed since v8 (Edgar review):
Correct number of interrupts to 160
changed since v7:
Made GIC region size defini
Hi Peter and all,
Xilinx's next gen SoC has been announced. This series adds a SoC and
board.
Series start with addition of ARM cortex A53 support (P1 and P2). The
Soc skeleton is then added with GIC, EMACs and UARTs added. The
pre-existing models for GEM and UART are not SoC friendly (no visible
On Wed, 05/13 16:27, Alberto Garcia wrote:
> Currently, block jobs can only be owned by root nodes. This patch
> allows block jobs to be in any arbitrary node, by making the following
> changes:
>
> - Block jobs can now be identified by the node name of their
> BlockDriverState in addition to th
On Wed, 05/13 16:27, Alberto Garcia wrote:
> The current way to obtain the list of existing block jobs is to
> iterate over all root nodes and check which ones own a job.
>
> Since we want to be able to support block jobs in other nodes as well,
> this patch keeps a list of jobs that is updated ev
On Thu, 05/14 19:03, Alexander Yarygin wrote:
> After the commit 9b536adc ("block: acquire AioContext in
> bdrv_drain_all()") the aio_poll() function got called for every
> BlockDriverState, in assumption that every device may have its own
> AioContext. The bdrv_drain_all() function is called in ea
On Fri, 05/15 09:37, Wen Congyang wrote:
> If bus_size is less than 0, the command fails.
> If buf_size % granularity is not 0, mirror_free_init() will
> do dangerous things.
>
> Signed-off-by: Wen Congyang
> ---
> block/mirror.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>
The image is contributed by Richard W.M. Jones.
Cc: Richard W.M. Jones
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/059 | 5 +
tests/qemu-iotests/059.out | 3 +++
tests/qemu-iotests/sample_images/afl9.vmdk.bz2 | Bin 0 -> 178 bytes
3 files
Bogus image may have a large total_sectors that will overflow the
multiplication. For cleanness, fix the return code so the error message
will be meaningful.
Reported-by: Richard W.M. Jones
Signed-off-by: Fam Zheng
---
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.
If the image has a huge enough virtual size,
$ qemu-img info afl9.img
qemu-img: Can't get size of device 'image': Unknown error -512
It's because of the multiplication overflow in the return statement in
bdrv_getlength (the big nagetive value is later truncated to 0x200). Fix it to
return -EF
If bus_size is less than 0, the command fails.
If buf_size % granularity is not 0, mirror_free_init() will
do dangerous things.
Signed-off-by: Wen Congyang
---
block/mirror.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 58f391a..7
On Mon, May 11, 2015 at 03:45:47PM -0700, Peter Crosthwaite wrote:
> Hi Peter and all,
>
> Xilinx's next gen SoC has been announced. This series adds a SoC and
> board.
Hi Peter,
Did you by accident send out v8 twice instead of a v9?
Cheers,
Edgar
>
> Series start with addition of ARM cort
On Fri, May 15, 2015 at 4:36 AM, Richard Henderson wrote:
> On 05/13/2015 11:08 PM, Alistair Francis wrote:
>> void helper_stackprot(CPUMBState *env, uint32_t addr)
>> {
>> -if (addr < env->slr || addr > env->shr) {
>> +MicroBlazeCPU *cpu = mb_env_get_cpu(env);
>> +
>> +if (cpu->cfg.
Public bug reported:
compiled qemu at commit 1eeace9c237a729d11c7acd7c0338ab4562af637
with ./configure --enable-debug --enable-vnc --target-
list=x86_64-softmmu
gdb --args ./qemu-system-x86_64 -nographic -parallel none -serial none
-nodefconfig -nodefaults -machine accel=kvm -enable-kvm -m 102
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> When -netdev tap fails, it first reports a specific error, then a
> generic one, like this:
>
> $ qemu-system-x86_64 -netdev tap,id=foo
> qemu-system-x86_64: -netdev tap,id=foo: could not configure /dev/net/tun:
> Operation not permitted
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> net/tap.c | 4
> 1 file changed, 4 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Desc
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> Fixes inappropriate use of syslog().
>
> Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs
> added instead.
At least you're admitting where the code is still bad.
>
> Signed-off-by: Markus Armbruster
> ---
> net/tap-solari
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> Fixes inappropriate use of stderr in monitor command handler.
>
> While there, improve some of the messages a bit.
>
> Signed-off-by: Markus Armbruster
> ---
> net/tap-bsd.c | 33 ++---
> 1 file changed, 14 insertion
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> net/tap-linux.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> @@ -47,7 +46,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
>
> TFR(fd = open(PATH_NE
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> Convert the trivial ones immediately: tap-aix and tap-haiku.
>
> Signed-off-by: Markus Armbruster
> ---
> net/tap-aix.c | 4 ++--
> net/tap-bsd.c | 6 --
> net/tap-haiku.c | 4 ++--
> net/tap-linux.c | 3 ++-
> net/tap-solari
On 05/14/2015 03:16 PM, Eric Blake wrote:
> On 05/14/2015 03:06 PM, Eric Blake wrote:
>> On 05/14/2015 02:38 PM, Stefan Weil wrote:
>>> i686-w64-mingw32-gcc 4.9.1 from Debian Jessie complains:
>>>
>>> hw/pci/pci.c:938:29: warning:
>>> array subscript is above array bounds [-Warray-bounds]
>>>
>>>
On 05/14/2015 03:16 PM, Eric Blake wrote:
>> Meanwhile, you may want to file a bug to the mingw maintainers that
>> their header is puny when compared to glibc assert() or to glib's
>> g_assert, when it comes to giving gcc decent hints.
>
> Oh, I was right!
>
> so it is indeed a bug in the mingw
On 05/14/2015 03:06 PM, Eric Blake wrote:
> On 05/14/2015 02:38 PM, Stefan Weil wrote:
>> i686-w64-mingw32-gcc 4.9.1 from Debian Jessie complains:
>>
>> hw/pci/pci.c:938:29: warning:
>> array subscript is above array bounds [-Warray-bounds]
>>
>> Using g_assert instead of assert fixes this warning
Hi Leon,
Le 29/04/2015 16:56, Leon Alrae a écrit :
Hi Hervé,
On 25/03/2015 14:13, Leon Alrae wrote:
On 05/03/2015 22:13, Hervé Poussineau wrote:
Hi,
This patchset improves dp8393x network card emulation to current QEMU standards,
mostly decouples it from MIPS rc4030 chipset emulation, and ad
On 05/14/2015 02:38 PM, Stefan Weil wrote:
> i686-w64-mingw32-gcc 4.9.1 from Debian Jessie complains:
>
> hw/pci/pci.c:938:29: warning:
> array subscript is above array bounds [-Warray-bounds]
>
> Using g_assert instead of assert fixes this warning.
Is that because the mingw headers don't prope
Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
GICv3 save/restore is not supported as linux kernel's vgic-v3-emul.c
is yet to support them.
Signed-off-by: Ashok Kumar
---
Tested KVM/GICv3 in ARM fastmodel.
Tested TCG/GICv2.
Not tested KVM/GICv2.
hw/arm/virt.c
Hi,
I am new to qemu development, and would appreciate it very much if
someone please creates an account for me on the developer wiki.
Thanks in advance for taking the time to address this request.
Cheers,
Eyal
Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
them.
Signed-off-by: Ashok Kumar
---
Tested KVM/GICv3 in ARM fastmodel.
Tested TCG/GICv2.
Not tested KVM/GICv2.
hw/arm/virt.c| 56 ++
i686-w64-mingw32-gcc 4.9.1 from Debian Jessie complains:
hw/pci/pci.c:938:29: warning:
array subscript is above array bounds [-Warray-bounds]
Using g_assert instead of assert fixes this warning.
Signed-off-by: Stefan Weil
---
hw/pci/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
The uninstall keys include an option key "DisplayVersion" which we set
now. By default the version value is read from file VERSION, but it is
also possible to pass VERSION=#.#.# to make.
Signed-off-by: Stefan Weil
---
Makefile | 1 +
qemu.nsi | 3 +++
2 files changed, 4 insertions(+)
diff --git
On 05/12/2015 06:03 AM, Markus Armbruster wrote:
> Fixes inappropriate use of stderr in monitor command handler.
>
> While there, improve the messages some.
>
> Signed-off-by: Markus Armbruster
> ---
> net/tap.c | 40
> 1 file changed, 28 insertions(+),
in the git repository at:
git://github.com/rth7680/qemu.git tags/pull-tcg-20150514
for you to fetch changes up to dfb36305626636e2e07e0c5acd3a002a5419399e:
tcg: Add MO_ALIGN, MO_UNALN (2015-05-14 12:15:18 -0700)
Per-memop
On 05/14/2015 08:27 AM, Richard Henderson wrote:
> Perhaps
>
> void probe_read(CPUArchState *env, target_ulong addr, int mmu_idx,
> uintptr_t retaddr);
>
> void probe_write(CPUArchState *env, target_ulong addr, int mmu_idx,
> uintptr_t r
On Thu, Apr 23, 2015 at 02:21:48PM +0800, Jason Wang wrote:
> This patch increases the maximum number of virtqueues for pci from 64
> to 513. This will allow booting a virtio-net-pci device with 256 queue
> pairs on recent Linux host (which supports up to 256 tuntap queue pairs).
>
> To keep migra
The compat property was added by commit
9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older
machine-types were not changed because virtio-9p-pci was introduced on QEMU
0.13 (commit 9f10751365b26b13b8a9b67e0e90536ae3d282df). The only problem is
that this breaks the PC_COMPAT_* nestin
The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11
breaks the PC_COMPAT_* nesting pattern we currently use.
As those variables are overwritten in pc-0.10 too, they can be inherited
by pc-0.10 with no side-effects at all.
Cc: Gerd Hoffmann
Signed-off-by: Eduardo Habkost
---
hw/
SPAPR_COMPAT_2_1 will need to include both HW_COMPAT_2_2 and
HW_COMPAT_2_1, so include HW_COMPAT_2_1 inside SPAPR_COMPAT_2_1 and
HW_COMPAT_2_2 inside SPAPR_COMPAT_2_2.
Signed-off-by: Eduardo Habkost
---
hw/ppc/spapr.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/pp
Changing the convention to include commas inside the macros will allow
macros containing empty lists to be defined and used without compilation
errors.
Signed-off-by: Eduardo Habkost
---
hw/i386/pc_piix.c| 62 ++--
hw/i386/pc_q35.c | 10 +++
Those properties were introduced by commit
3827cdb1c3aa17a792d1658161195b9d7173c26b. They were not duplicated into
pc-0.13 and older because 0.14 was the first QEMU version supporting
qxl. The only problem is that this breaks the PC_COMPAT_* nesting
pattern we currently use.
So, move the propertie
1 - 100 of 354 matches
Mail list logo
