Re: [Qemu-devel] [RFC v6 1/2] util: add memmem replacement function

2015-05-18 Thread Eric Blake
On 05/18/2015 05:22 AM, hw.clau...@gmail.com wrote: From: Claudio Fontana claudio.font...@huawei.com if the memmem function is missing, provide a trivial replacement. Signed-off-by: Claudio Fontana claudio.font...@huawei.com --- configure| 15 +

Re: [Qemu-devel] [PATCH 00/23] userfaultfd v4

2015-05-18 Thread Pavel Emelyanov
On 05/14/2015 08:30 PM, Andrea Arcangeli wrote: Hello everyone, This is the latest userfaultfd patchset against mm-v4.1-rc3 2015-05-14-10:04. The postcopy live migration feature on the qemu side is mostly ready to be merged and it entirely depends on the userfaultfd syscall to be merged

[Qemu-devel] [PATCH 4/7] kvm-all: make KVM's memory listener more generic

2015-05-18 Thread Paolo Bonzini
No semantic change, but s-slots and s-migration_log move into a new struct KVMMemoryListener. KVM's memory listener becomes a member of struct KVMState, and becomes of type KVMMemoryListener. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/sysemu/kvm_int.h | 6 ++ kvm-all.c

Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option inheritance

2015-05-18 Thread Kevin Wolf
Am 15.05.2015 um 21:16 hat Max Reitz geschrieben: On 08.05.2015 19:22, Kevin Wolf wrote: This is doing a more complete test on setting cache modes both while opening an image (i.e. in a -drive command line) and in reopen situations. It checks that reopen can specify options for child nodes

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-05-18 Thread Kevin Wolf
Am 11.05.2015 um 15:10 hat Stefan Hajnoczi geschrieben: On Fri, May 08, 2015 at 08:29:09AM -0600, Eric Blake wrote: On 05/08/2015 07:14 AM, Stefan Hajnoczi wrote: No it doesn't. Actions have to appear atomic to the qmp_transaction caller. Both approaches achieve that so they are both

[Qemu-devel] [PATCH 1/7] kvm-all: put kvm_mem_flags to more work

2015-05-18 Thread Paolo Bonzini
From: Andrew Jones drjo...@redhat.com Currently kvm_mem_flags just translates bools to bits, let's make it also determine the bools first. This avoids its parameter list growing each time we add a flag. Signed-off-by: Andrew Jones drjo...@redhat.com Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-18 Thread Cornelia Huck
On Mon, 18 May 2015 13:26:35 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: Would the subsection approach be more acceptable if I default needed to false and have only virtio-ccw override it in a callback? Smth like the following: From 773a753475d9c89fb8dc789005a694d07b0cfac2 Mon Sep 17

[Qemu-devel] [PATCH 2/7] kvm-all: remove useless typedef

2015-05-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- kvm-all.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index b459855..bb9477c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -69,8 +69,6 @@ typedef struct KVMSlot int flags; } KVMSlot; -typedef

[Qemu-devel] [PATCH v3] bios-tables-test: handle false-positive smbios signature matches

2015-05-18 Thread Gabriel L. Somlo
It has been reported that sometimes the .rodata section of SeaBIOS, containing the constant string against which the SMBIOS signature ends up being compared, also falls within the guest f-segment. In that case, the test obviously fails, unless we continue searching for the *real* SMBIOS entry

Re: [Qemu-devel] New account on developer wiki

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 02:07:44PM -0400, Eyal de Lara wrote: I am new to qemu development, and would appreciate it very much if someone please creates an account for me on the developer wiki. Thanks in advance for taking the time to address this request. Done. Please see private message.

[Qemu-devel] [PATCH 3/3] target-s390x: remove unused helpers

2015-05-18 Thread Aurelien Jarno
Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-s390x/helper.h | 2 -- target-s390x/int_helper.c | 20 2 files changed, 22 deletions(-) diff --git a/target-s390x/helper.h

Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store

2015-05-18 Thread Eric Blake
On 05/18/2015 04:38 AM, Denis V. Lunev wrote: On 14/05/15 19:28, Juan Quintela wrote: This allows us to store the current state to send it through migration. Signed-off-by: Juan Quintela quint...@redhat.com --- +if (strlen(state)+1 size) { +return -1; +} +

[Qemu-devel] [PATCH 0/7] kvm-i386: QEMU support for SMRAM

2015-05-18 Thread Paolo Bonzini
These are the new patches for SMRAM support, using multiple address spaces and, thus, multiple KVMMemoryListeners. No more layering violations, yay! The meat is in patches 4 and 5, which parameterize KVM's memory listener so that: 1) each memory listener handles its own array of memory slots; 2)

Re: [Qemu-devel] [Qemu-block] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:23PM -0400, John Snow wrote: @@ -2900,9 +2917,16 @@ void qmp_drive_backup(const char *device, const char *target, } } +/* If we are not supplied with callback override info, use our defaults */ +if (cb == NULL) { +cb =

Re: [Qemu-devel] [PATCH] qemu-iotests: Make debugging python tests easier

2015-05-18 Thread John Snow
On 05/17/2015 09:32 PM, Fam Zheng wrote: On Fri, 05/15 13:48, John Snow wrote: On 05/15/2015 01:26 AM, Fam Zheng wrote: Adding -d option. The output goes to tee so it appears in your console. Also, raise the verbosity of unnitest runner. When testing a topic branch, it's possible that a

Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function

2015-05-18 Thread Eric Blake
On 05/18/2015 03:58 AM, Dr. David Alan Gilbert wrote: * Juan Quintela (quint...@redhat.com) wrote: Given a string state, we need a way to get the RunState for that string. Signed-off-by: Juan Quintela quint...@redhat.com --- include/sysemu/sysemu.h | 1 + vl.c| 13

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Make debugging python tests easier

2015-05-18 Thread Kevin Wolf
Am 18.05.2015 um 03:39 hat Fam Zheng geschrieben: Adding -d option. The output goes to tee so it appears in your console. Also, raise the verbosity of unnitest runner. When testing a topic branch, it's possible that a bug introduced by a code change makes the python test case hang, with

[Qemu-devel] [PATCH 6/7] kvm-all: kvm_irqchip_create is not expected to fail

2015-05-18 Thread Paolo Bonzini
KVM_CREATE_IRQCHIP should never fail, and so should its userspace wrapper kvm_irqchip_create. The function does not do anything if the irqchip capability is not available, as is the case for PPC. With this patch, kvm_arch_init can allocate memory and it will not be leaked. Signed-off-by: Paolo

[Qemu-devel] [PATCH 3/7] kvm-all: move internal types to kvm_int.h

2015-05-18 Thread Paolo Bonzini
i386 code will have to define a different KVMMemoryListener. Create an internal header so that KVMSlot is not exposed outside. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/sysemu/kvm_int.h | 30 ++ kvm-all.c| 18 +- 2

Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:24PM -0400, John Snow wrote: +static void drive_backup_cb(BlkActionState *common) +{ +BlkActionCallbackData *cb_data = common-cb_data; +BlockDriverState *bs = cb_data-opaque; +DriveBackupState *state = DO_UPCAST(DriveBackupState, common, common); +

Re: [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big

2015-05-18 Thread Kevin Wolf
Am 15.05.2015 um 10:36 hat Fam Zheng geschrieben: v2: Correct detection of overflow. [Markus, Berto] If the image has a huge enough virtual size, $ qemu-img info afl9.img qemu-img: Can't get size of device 'image': Unknown error -512 It's because of the multiplication overflow in

Re: [Qemu-devel] [Qemu-block] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-05-18 Thread John Snow
On 05/18/2015 10:42 AM, Stefan Hajnoczi wrote: On Mon, May 11, 2015 at 07:04:23PM -0400, John Snow wrote: @@ -2900,9 +2917,16 @@ void qmp_drive_backup(const char *device, const char *target, } } +/* If we are not supplied with callback override info, use our defaults */ +if (cb ==

[Qemu-devel] [PATCH 5/7] kvm-all: add support for multiple address spaces

2015-05-18 Thread Paolo Bonzini
Make kvm_memory_listener_register public, and assign a kernel address space id to each KVMMemoryListener. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/sysemu/kvm_int.h | 4 kvm-all.c| 13 ++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option inheritance

2015-05-18 Thread Max Reitz
On 18.05.2015 16:39, Kevin Wolf wrote: Am 15.05.2015 um 21:16 hat Max Reitz geschrieben: On 08.05.2015 19:22, Kevin Wolf wrote: This is doing a more complete test on setting cache modes both while opening an image (i.e. in a -drive command line) and in reopen situations. It checks that reopen

Re: [Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-18 Thread Richard Henderson
On 05/16/2015 04:28 PM, Aurelien Jarno wrote: Commit 7a6c7067f optimized CC computation by only saving cc_op before calling helpers as they either don't touch the CC or generate a new static value. This however doesn't work for the EX instruction as the helper changes or not the CC value

[Qemu-devel] [PATCH 7/7] target-i386: register a separate KVM address space including SMRAM regions

2015-05-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/kvm.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 09b4fc7..19ccc08 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c

Re: [Qemu-devel] [RFC PATCH v4 09/28] COLO: Save VM state to slave when do checkpoint

2015-05-18 Thread zhanghailiang
On 2015/5/18 20:10, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/5/15 20:09, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should save PVM's RAM/device to slave when needed. For VM state, we will

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 05:43:52PM +0100, Peter Maydell wrote: This patchset adds support for two new commands to our gdb scripts, which allow dynamically enabling and disabling tracing of events, like this: (gdb) source scripts/qemu-gdb.py (gdb) qemu trace-enable translate_block Enabled

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Frederic Konrad
On 18/05/2015 13:17, Gerd Hoffmann wrote: On Mo, 2015-05-18 at 09:51 +0200, Frederic Konrad wrote: On 18/05/2015 09:34, Gerd Hoffmann wrote: On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This allows to create a surface with

Re: [Qemu-devel] [RFC PATCH v4 09/28] COLO: Save VM state to slave when do checkpoint

2015-05-18 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/5/15 20:09, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should save PVM's RAM/device to slave when needed. For VM state, we will cache them in slave, we use QEMUSizedBuffer to store

Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/10] block: rename BlkTransactionState and BdrvActionOps

2015-05-18 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 08:04:46PM -0400, John Snow wrote: These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it BlkActionState to be more accurate. (2) The BdrvActionOps

Re: [Qemu-devel] [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:18PM -0400, John Snow wrote: These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it BlkActionState to be more accurate. (2) The BdrvActionOps

Re: [Qemu-devel] [Qemu-block] [PATCH v4 04/11] block: re-add BlkTransactionState

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:19PM -0400, John Snow wrote: + * @jobs: A reference count that tracks how many jobs still need to complete. + * @actions: A list of all Actions in the Transaction. + */ +typedef struct BlkTransactionState { +int jobs; ... +static BlkTransactionState

Re: [Qemu-devel] [PATCH V4 0/4] fw-cfg: cleanup and user-provided command line blobs

2015-05-18 Thread Gabriel L. Somlo
Ping? On Wed, Apr 29, 2015 at 11:21:49AM -0400, Gabriel L. Somlo wrote: These patches are what's left over from before the pre-2.3 code freeze, after the documentation patch was applied independently: 1/4: (clean-up) disallow guest-side data writes to fw_cfg 2/4 3/4:

Re: [Qemu-devel] [PATCH 2/3] ui/cocoa.m: Adds device menu items to Machine menu

2015-05-18 Thread Kevin Wolf
Am 17.05.2015 um 00:21 hat Peter Maydell geschrieben: On 11 May 2015 at 23:16, Programmingkid programmingk...@gmail.com wrote: Adds all removable devices to the Machine menu as a Change and Eject menu item pair. ide-cd0 would have a Change ide-cd0... and Eject ide-cd0 menu items.

Re: [Qemu-devel] [PATCH] ui: use libexpoxy

2015-05-18 Thread Alexander Graf
On 05/12/2015 03:48 PM, Gerd Hoffmann wrote: On Di, 2015-05-12 at 14:10 +0100, Peter Maydell wrote: On 12 May 2015 at 14:04, Gerd Hoffmann kra...@redhat.com wrote: libepoxy does the opengl extension handling for us. It also is helpful for trouble-shooting as it prints nice error messages

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-iotests: Make debugging python tests easier

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 18, 2015 at 09:39:12AM +0800, Fam Zheng wrote: Adding -d option. The output goes to tee so it appears in your console. Also, raise the verbosity of unnitest runner. When testing a topic branch, it's possible that a bug introduced by a code change makes the python test case hang,

Re: [Qemu-devel] [Bug 1455254] [NEW] Segmentation fault. __memcmp_sse4_1 () at ../sysdeps/x86_64/multiarch/memcmp-sse4.S:69

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 10:18:33PM -, Manuel Baesler wrote: Public bug reported: compiled qemu at commit 1eeace9c237a729d11c7acd7c0338ab4562af637 with ./configure --enable-debug --enable-vnc --target- list=x86_64-softmmu gdb --args ./qemu-system-x86_64 -nographic -parallel none

[Qemu-devel] [PATCH 2/3] target-s390x: optimize (negative-) abs computation

2015-05-18 Thread Aurelien Jarno
Now that movcond exists, it's easy to write (negative-) absolute value using TCG code instead of an helper. Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-s390x/helper.h | 2 -- target-s390x/int_helper.c

[Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions

2015-05-18 Thread Aurelien Jarno
LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following condition code: 0: Result zero; no overflow 1: -- 2: Result greater than zero; no overflow 3: Overflow The current code wrongly returns 1 instead of 2 in case of a result greater than 0. This patches fixes that. This fixes

Re: [Qemu-devel] virtio: Question on VRING_DESC_F_WRITE flag

2015-05-18 Thread Stefan Hajnoczi
On Wed, May 13, 2015 at 07:16:13PM +, Subhashini Venkataraman wrote: I have a question on VRING_DESC_F_WRITE flag. As per the specifications, if this flag is set, then the corresponding buffer pointed by the descriptor is Write only, otherwise Read Only. I am trying to understand why

Re: [Qemu-devel] [PULL v2 00/26] qapi: Fix qapi mangling of downstream names, and more

2015-05-18 Thread Peter Maydell
On 15 May 2015 at 17:49, Markus Armbruster arm...@redhat.com wrote: The following changes since commit 1eeace9c237a729d11c7acd7c0338ab4562af637: Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' into staging (2015-05-13 16:06:07 +0100) are available in the git

Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-05-18 Thread Eric Blake
On 05/17/2015 10:00 AM, penghao...@sina.com wrote: Subject: [PATCH] keyboard: handle ps2 typing buffer overrun This line is redundant. Also, you have tried to send this patch more than once. Please be sure to include a proper 'v3' or 'v4' in the subject line, as appropriate. Starting a linux

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 05:43:52PM +0100, Peter Maydell wrote: This patchset adds support for two new commands to our gdb scripts, which allow dynamically enabling and disabling tracing of events, like this: (gdb) source scripts/qemu-gdb.py (gdb) qemu trace-enable translate_block Enabled

Re: [Qemu-devel] [PATCH 4/8] introduce dpcd module.

2015-05-18 Thread Frederic Konrad
On 14/05/2015 06:10, Peter Crosthwaite wrote: On Wed, May 13, 2015 at 12:12 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This introduces a DPCD modules. It wires on a aux-bus and can be accessed by driver to get lane-speed, etc. Signed-off-by: KONRAD

Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-05-18 Thread Eric Blake
On 05/18/2015 06:54 AM, Eric Blake wrote: On 05/17/2015 10:00 AM, penghao...@sina.com wrote: Subject: [PATCH] keyboard: handle ps2 typing buffer overrun This line is redundant. Also, you have tried to send this patch more than once. Please be sure to include a proper 'v3' or 'v4' in the

Re: [Qemu-devel] [PATCH v2 0/2] ppc: Require libfdt 1.4.0 as minimum version

2015-05-18 Thread Alexander Graf
On 05/18/2015 12:59 PM, Thomas Huth wrote: The patch spapr_drc: initial implementation of sPAPRDRConnector device requires the function fdt_get_property_by_offset() from libfdt, which is only properly exported there since version 1.4.0. So let's make sure that we require at least version 1.4.0

Re: [Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-18 Thread Alexander Graf
On 05/17/2015 01:28 AM, Aurelien Jarno wrote: Commit 7a6c7067f optimized CC computation by only saving cc_op before calling helpers as they either don't touch the CC or generate a new static value. This however doesn't work for the EX instruction as the helper changes or not the CC value

Re: [Qemu-devel] [PATCH v2 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: The compat property was added by commit 9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older machine-types were not changed because virtio-9p-pci was introduced on QEMU 0.13 (commit

Re: [Qemu-devel] [PATCH v6 06/22] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-05-18 Thread Alex Bennée
Shannon Zhao zhaoshengl...@huawei.com writes: From: Shannon Zhao shannon.z...@linaro.org DSDT consists of the usual common table header plus a definition block in AML encoding which describes all devices in the platform. After initializing DSDT with header information the namespace is

Re: [Qemu-devel] VCPU Hot-Unplug Feature

2015-05-18 Thread Eduardo Otubo
On Mon, May 04, 2015 at 09=34=21PM +0300, Fahri Cihan Demirci wrote: Hello Alexandre, Thank you for your response. I came upon that patch on the Libvirt mailing list, too. However, the following comment makes me think that it's not likely to be merged:

Re: [Qemu-devel] [PATCH 6/8] Introduce xilinx dpdma.

2015-05-18 Thread Peter Crosthwaite
On Wed, May 13, 2015 at 12:12 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- hw/dma/Makefile.objs |1 + hw/dma/xilinx_dpdma.c | 1149

Re: [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance

2015-05-18 Thread Denis V. Lunev
On 28/04/15 10:46, Denis V. Lunev wrote: This patchset provides an ability to create of/write to Parallels images and some testing of the new code. Readings and writings are optimized out and I expect the same or slightly better performance as qcow2. Changes from v4: - parallels format driver

Re: [Qemu-devel] [PATCH 6/8] Introduce xilinx dpdma.

2015-05-18 Thread Frederic Konrad
On 18/05/2015 10:17, Peter Crosthwaite wrote: On Wed, May 13, 2015 at 12:12 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- hw/dma/Makefile.objs |

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-18 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 05/16/2015 07:30 AM, Andreas Färber wrote: Am 16.05.2015 um 00:24 schrieb Eric Blake: We require a C99 compiler, so let's use 'bool' instead of 'int' when dealing with boolean values. There are few enough clients to fix them all in one pass.

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Gerd Hoffmann
On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This allows to create a surface with a different format than xrgb. What is the use case for this? cheers, Gerd

Re: [Qemu-devel] [PATCH v6 09/47] Add wrapper for setting blocking status on a QEMUFile

2015-05-18 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:35], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Add a wrapper to change the blocking status on a QEMUFile rather than having to use qemu_set_block(qemu_get_fd(f)); it seems best to avoid exposing the fd since not all

Re: [Qemu-devel] [PATCH v6 10/47] Rename save_live_complete to save_live_complete_precopy

2015-05-18 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:36], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com In postcopy we're going to need to perform the complete phase for postcopiable devices at a different point, start out by renaming all of the 'complete's to make the

Re: [Qemu-devel] [PATCH v2 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11 breaks the PC_COMPAT_* nesting pattern we currently use. As those variables are overwritten in pc-0.10 too, they can be inherited by pc-0.10 with no side-effects at

Re: [Qemu-devel] [PATCH v2 09/13] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: So, move the properties to PC_COMPAT_0_14. This makes pc-0.13 and older inherit them, but that shouldn't be an issue as QEMU 0.13 didn't support qxl. Reviewed-by: Gerd Hoffmann kra...@redhat.com

Re: [Qemu-devel] [PATCH v2 12/13] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: The VGA and vmware-svga rombar compat properties were added by commit 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently follow. The new variables will

[Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0

2015-05-18 Thread Thomas Huth
Some recent patches require functions from libfdt version 1.4.0, so we should check for this version during the configure step already. Unfortunately, there does not seem to be a proper #define for the version number in the libfdt headers. So alternatively, we check for the availability of the

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Frederic Konrad
On 18/05/2015 09:34, Gerd Hoffmann wrote: On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This allows to create a surface with a different format than xrgb. What is the use case for this? cheers, Gerd Hi, The

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-18 Thread Claudio Fontana
Hello Eric, On 15 May 2015 at 18:01, Eric Blake ebl...@redhat.com wrote: On 05/15/2015 09:13 AM, Claudio Fontana wrote: Or back to the original question - why are we worrying about the O(n) memmem implementation when the naive O(n^2) is MUCH shorter and easier to understand, and where the

Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support

2015-05-18 Thread John Snow
On 05/18/2015 11:35 AM, Stefan Hajnoczi wrote: On Mon, May 11, 2015 at 07:04:24PM -0400, John Snow wrote: +static void drive_backup_cb(BlkActionState *common) +{ + BlkActionCallbackData *cb_data = common-cb_data; + BlockDriverState *bs = cb_data-opaque; +DriveBackupState *state =

Re: [Qemu-devel] [PATCH v7 05/23] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-18 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 05:19:24PM +0800, Shannon Zhao wrote: From: Shannon Zhao shannon.z...@linaro.org Add aml_interrupt() for describing device interrupt in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao

Re: [Qemu-devel] [PATCH 08/27] block/parallels: mark parallels format driver as zero inited

2015-05-18 Thread Stefan Hajnoczi
On Tue, Apr 28, 2015 at 10:46:41AM +0300, Denis V. Lunev wrote: From the guest point of view unallocated blocks are zeroed. Signed-off-by: Denis V. Lunev d...@openvz.org CC: Roman Kagan rka...@parallels.com CC: Kevin Wolf kw...@redhat.com CC: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-18 Thread Richard Henderson
On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) static void memory_dump(Monitor *mon, int count, int format, int wsize, hwaddr addr, int is_physical) { -CPUArchState *env; int l,

Re: [Qemu-devel] [PATCH v4 01/11] qapi: Add transaction support to block-dirty-bitmap operations

2015-05-18 Thread Max Reitz
On 12.05.2015 01:04, John Snow wrote: This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-18 Thread Peter Maydell
On 8 May 2015 at 12:41, Leon Alrae leon.al...@imgtec.com wrote: Add new arg sub-argument to the --semihosting-config allowing to pass multiple input argument separately. It is required for example by UHI semihosting to construct argc and argv. Signed-off-by: Leon Alrae leon.al...@imgtec.com

Re: [Qemu-devel] [PATCH 1/1] docs: document how to configure the qcow2 L2/refcount caches

2015-05-18 Thread Max Reitz
On 12.05.2015 14:10, Alberto Garcia wrote: QEMU has options to configure the size of the L2 and refcount caches for the qcow2 format. However, choosing the right sizes for a particular disk image is not a straightforward operation since the ratio between the cache size and the allocated disk

Re: [Qemu-devel] [PATCH 27/27] block/parallels: improve image writing performance further

2015-05-18 Thread Stefan Hajnoczi
On Tue, Apr 28, 2015 at 10:47:00AM +0300, Denis V. Lunev wrote: Try to perform IO for the biggest continuous block possible. All blocks abscent in the image are accounted in the same type and preallocation is made for all of them at once. The performance for sequential write is increased

Re: [Qemu-devel] [PATCH] linux-user: fix support for timerfd_create on arm

2015-05-18 Thread Peter Maydell
On 12 May 2015 at 13:27, Andreas Schwab sch...@suse.de wrote: On arm the original timerfd syscall was reused for the new timerfd_create syscall. Signed-off-by: Andreas Schwab sch...@suse.de --- linux-user/arm/syscall_nr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions

2015-05-18 Thread Alexander Graf
On 05/18/2015 03:39 PM, Aurelien Jarno wrote: LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following condition code: 0: Result zero; no overflow 1: -- 2: Result greater than zero; no overflow 3: Overflow The current code wrongly returns 1 instead of 2 in case of a result

Re: [Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-18 Thread Alexander Graf
On 05/18/2015 05:35 PM, Richard Henderson wrote: On 05/16/2015 04:28 PM, Aurelien Jarno wrote: Commit 7a6c7067f optimized CC computation by only saving cc_op before calling helpers as they either don't touch the CC or generate a new static value. This however doesn't work for the EX instruction

Re: [Qemu-devel] [PATCH 2/2] disas: Remove uses of CPU env

2015-05-18 Thread Eduardo Habkost
On Sun, May 17, 2015 at 12:51:52PM -0700, Peter Crosthwaite wrote: disas does not need to access the CPU env for any reason. Change the APIs to accept CPU pointers instead. Small change pattern needs to be applied to all target translate.c. This brings us closer to making disas.o a common-obj

Re: [Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-18 Thread Aurelien Jarno
On 2015-05-18 19:07, Alexander Graf wrote: On 05/18/2015 05:35 PM, Richard Henderson wrote: On 05/16/2015 04:28 PM, Aurelien Jarno wrote: Commit 7a6c7067f optimized CC computation by only saving cc_op before calling helpers as they either don't touch the CC or generate a new static value.

Re: [Qemu-devel] [PATCH v2 4/9] target-arm: Add AArch64 CPTR registers

2015-05-18 Thread Peter Maydell
On 22 April 2015 at 18:09, Greg Bellows greg.bell...@linaro.org wrote: Adds CPTR_EL2/3 system registers definitions and access function. Signed-off-by: Greg Bellows greg.bell...@linaro.org --- v2 - v3 - Broke out cptr and cpacr access functions - Added HCPTR register entry as alias of

Re: [Qemu-devel] [PATCH v3 02/12] block: Add op blocker notifier list

2015-05-18 Thread Max Reitz
On 15.05.2015 08:04, Fam Zheng wrote: BDS users can register a notifier and get notified about op blocker changes. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 35 +++ include/block/block.h | 8

Re: [Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-05-18 Thread Peter Maydell
On 22 April 2015 at 18:09, Greg Bellows greg.bell...@linaro.org wrote: Initial patchset adding support for trapping to an EL other than EL1. Support includes changes to interfaces to allow specification of the target EL. Also includes the addition of the ARMv8 CPTR system registers used for

Re: [Qemu-devel] [PATCH v3 03/12] block-backend: Add blk_op_blocker_add_notifier

2015-05-18 Thread Max Reitz
On 15.05.2015 08:04, Fam Zheng wrote: Forward the call to bdrv_op_blocker_add_notifier. Signed-off-by: Fam Zheng f...@redhat.com --- block/block-backend.c | 6 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 8 insertions(+) Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH v3 04/12] virtio-blk: Move complete_request to 'ops' structure

2015-05-18 Thread Max Reitz
On 15.05.2015 08:04, Fam Zheng wrote: Should more ops be added to differentiate code between dataplane and non-dataplane, the new saved_ops approach will be cleaner than messing with N pointers. Signed-off-by: Fam Zheng f...@redhat.com --- hw/block/dataplane/virtio-blk.c | 13 -

Re: [Qemu-devel] [PATCH v2 5/9] target-arm: Extend FP checks to use an EL

2015-05-18 Thread Peter Maydell
On 22 April 2015 at 18:09, Greg Bellows greg.bell...@linaro.org wrote: Extend the ARM disassemble context to take a target exception EL instead of a boolean enable. This change reverses the polarity of the check making a value of 0 indicate floating point enabled (no exception).

Re: [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias()

2015-05-18 Thread Eduardo Habkost
On Tue, Apr 28, 2015 at 05:16:35AM +0200, Andreas Färber wrote: Am 10.04.2015 um 00:48 schrieb Andreas Färber: Am 09.04.2015 um 22:22 schrieb Paolo Bonzini: On 09/04/2015 21:57, Eduardo Habkost wrote: This helps us avoid memory leaks when using object_property_add_alias(), as it is not

Re: [Qemu-devel] [PATCH 3/3] target-s390x: remove unused helpers

2015-05-18 Thread Richard Henderson
On 05/18/2015 06:40 AM, Aurelien Jarno wrote: Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-s390x/helper.h | 2 -- target-s390x/int_helper.c | 20 2 files changed, 22

Re: [Qemu-devel] [PATCH 2/3] target-s390x: optimize (negative-) abs computation

2015-05-18 Thread Richard Henderson
On 05/18/2015 06:39 AM, Aurelien Jarno wrote: Now that movcond exists, it's easy to write (negative-) absolute value using TCG code instead of an helper. Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

Re: [Qemu-devel] [PATCH][RFC] libxl: use new qemu parameters for emulated qemuu disks

2015-05-18 Thread Wei Liu
On Fri, May 15, 2015 at 01:54:32PM +0200, Fabio Fantoni wrote: NOTES: This patch is a only a fast draft for testing. Some tests result: At xl create cdrom empty or not are both working, xl cd-insert is working, xl cd-eject seems working but on xl command in linux hvm domU return qmp error

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode

2015-05-18 Thread Eric Auger
Hi Ashok, On 05/14/2015 07:27 PM, Ashok Kumar wrote: Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3. GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support them. Signed-off-by: Ashok Kumar ash...@broadcom.com --- Tested KVM/GICv3 in ARM fastmodel.

Re: [Qemu-devel] [PATCH v7 13/23] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec

2015-05-18 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 05:19:32PM +0800, Shannon Zhao wrote: From: Shannon Zhao shannon.z...@linaro.org According to ACPI spec, DefBuffer can take two parameters: BufferSize and ByteList. Make it consistent with the spec. If we want to request uninitialized buffer, pass ByteList as NULL to

Re: [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status

2015-05-18 Thread Stefan Hajnoczi
On Tue, Apr 28, 2015 at 10:46:38AM +0300, Denis V. Lunev wrote: From: Roman Kagan rka...@parallels.com Implement VFS method for get_block_status to Parallels format driver. qemu_co_mutex_lock is not necessary yet (the driver is read-only) but will be necessary very soon when write will be

Re: [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion

2015-05-18 Thread Stefan Hajnoczi
On Tue, Apr 28, 2015 at 10:46:59AM +0300, Denis V. Lunev wrote: Plain image expansion spends a lot of time to update image file size. This seriously affects the performance. The following simple test qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G qemu_io -n -c write -P 0x11 0

Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-18 Thread Peter Crosthwaite
On Mon, May 18, 2015 at 9:13 AM, Richard Henderson r...@twiddle.net wrote: On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) static void memory_dump(Monitor *mon, int count, int format, int wsize,

Re: [Qemu-devel] [PATCH 0/5] Misc fixes and testing of qcow[2] encryption

2015-05-18 Thread Kevin Wolf
Am 12.05.2015 um 18:09 hat Daniel P. Berrange geschrieben: I realize that qcow[2] encryption is a feature we have deprecated and will remove support for running it with the QEMU system emulators in this cycle. We do still need to make sure it continues to work for the sake of letting people

Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:24PM -0400, John Snow wrote: @@ -1825,6 +1827,19 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp) } bs = blk_bs(blk); +/* BackupBlockJob is opaque to us, so look up the bitmap ourselves */ +if (backup-has_bitmap) {

Re: [Qemu-devel] [PATCH v7 14/23] hw/acpi/aml-build: Add ToUUID macro

2015-05-18 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 05:19:33PM +0800, Shannon Zhao wrote: From: Shannon Zhao shannon.z...@linaro.org Add ToUUID macro, this is useful for generating PCIe ACPI table. Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org ---

Re: [Qemu-devel] [PATCH v7 20/23] hw/acpi/aml-build: Add Unicode macro

2015-05-18 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 05:19:39PM +0800, Shannon Zhao wrote: From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- hw/acpi/aml-build.c | 18 ++

[Qemu-devel] [PATCH v2] ui/cocoa.m: Adds device menu items to Machine menu

2015-05-18 Thread Programmingkid
Adds all removable devices to the Machine menu as a Change and Eject menu item pair. ide-cd0 would have a Change ide-cd0... and Eject ide-cd0 menu items. Signed-off-by: John Arbuckle programmingk...@gmail.com --- Replace NSRunAlertPanel() with QEMU_Alert(). Free currentDevice variable after

Re: [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup

2015-05-18 Thread Peter Maydell
On 9 May 2015 at 21:11, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: Move the target_disas() ARM specifics to the QOM disas_set_info hook and delete the ARM specific code in disas.c. This has the extra advantage of the more fully featured target_disas() implementation now applying to

[Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time

2015-05-18 Thread Alberto Garcia
This adds a new 'cache-clean-interval' option that cleans all qcow2 cache entries that haven't been used in a certain interval, given in seconds. This allows setting a large L2 cache size so it can handle scenarios with lots of I/O and at the same time use little memory during periods of

[Qemu-devel] [PATCH 0/3] Clean unused entries in the qcow2 L2/refcount cache

2015-05-18 Thread Alberto Garcia
These patches use MADV_DONTNEED to clean unused cache entries. Under Linux it frees the memory used by those pages. Berto Alberto Garcia (3): qcow2: mark the memory as no longer needed after qcow2_cache_empty() qcow2: add option to clean unused cache entries after some time qcow2: reorder

  1   2   3   >