[Qemu-devel] [PATCH] more check for replaced node

2015-06-25 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block.c | 5 +++-- block/mirror.c| 3 ++- blockdev.c| 2 +- include/block/block.h | 3 ++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 7168575..70ee0f6 100644 ---

Re: [Qemu-devel] [PATCH v2] ossaudio: fix memory leak

2015-06-25 Thread Markus Armbruster
arei.gong...@huawei.com writes: From: Gonglei arei.gong...@huawei.com Variable conf going out of scope leaks the storage it points to in line 856. Signed-off-by: Gonglei arei.gong...@huawei.com --- v2: using an better way to avoid memory leak. (Markus) --- audio/ossaudio.c | 9

Re: [Qemu-devel] [PATCH 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-06-25 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: -device isa-fdc,driveA=drive-fdc0-0-0 \ -drive file=...,if=none,id=drive-fdc0-0-0,format=raw then the board-default FDC will be skipped, and only the explicitly requested

Re: [Qemu-devel] [PATCH v2] ossaudio: fix memory leak

2015-06-25 Thread Gerd Hoffmann
On Mi, 2015-06-24 at 17:18 +0800, arei.gong...@huawei.com wrote: Variable conf going out of scope leaks the storage it points to in line 856. Added to audio queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 for-2.4 3/3] hw/arm/virt: Make block devices default to virtio

2015-06-25 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Now we have virtio-pci, we can make the virt board's default block device type be IF_VIRTIO. This allows users to use simplified command lines that don't have to explicitly create virtio-pci-blk devices; the -hda c very short options now also

Re: [Qemu-devel] [PATCH 3/9] memory: Add global-locking property to memory regions

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 05:44, Fam Zheng wrote: + * memory_region_clear_global_locking: Declares that access processing does + * not depend on the QEMU global lock. + * + * By clearing this property, accesses to the memory region will be processed

Re: [Qemu-devel] [PATCH] m68k: is_mem is useless

2015-06-25 Thread Laurent Vivier
Le 24/06/2015 21:19, Peter Maydell a écrit : On 24 June 2015 at 00:00, Laurent Vivier laur...@vivier.eu wrote: Remove is_mem as it is never tested anymore since: commit bfa50bc2638d877cf2900712b7503be22e8811cb Author: aliguori aliguori@c046a42c-6fe2-441c-8c8c-71466251a162 Date:

Re: [Qemu-devel] [PATCH 0/5] qapi flattening + some miscellaneous patches

2015-06-25 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On Di, 2015-06-23 at 15:32 +0200, Kővágó, Zoltán wrote: I've cherry-picked the qapi related parts from my previous -audiodev patch series, we can hopefully concentrate on one thing at a time. The most important changes in this patch series are the

Re: [Qemu-devel] [libvirt] Bug: vnc + websocket = websocket autoport not working right at live migration

2015-06-25 Thread Martin Kletzander
On Tue, Jun 23, 2015 at 02:13:21PM +0200, Piotr Rybicki wrote: Hello. Problem description: When i start qemu via libvirt with vnc websocket defined, it is not possible to live migrate to host where other qemu process is running with the same display id. migration error is: error: internal

Re: [Qemu-devel] [PATCH] dataplane: endian fix in host notification

2015-06-25 Thread Greg Kurz
On Thu, 25 Jun 2015 18:41:31 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 25 Jun 2015 18:34:47 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 25 Jun 2015 17:26:21 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: This field comes either LE with virtio 1.0,

Re: [Qemu-devel] [PATCH qemu v8 00/14] spapr: vfio: Enable Dynamic DMA windows (DDW)

2015-06-25 Thread Alex Williamson
On Wed, 2015-06-24 at 20:52 +1000, Alexey Kardashevskiy wrote: On 06/23/2015 04:44 PM, David Gibson wrote: On Thu, Jun 18, 2015 at 09:37:22PM +1000, Alexey Kardashevskiy wrote: (cut-n-paste from kernel patchset) Each Partitionable Endpoint (IOMMU group) has an address range on a PCI bus

Re: [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 20:07, Programmingkid wrote: I honestly think it is in the right place. The function find_image_format() is doing just that - trying to find the format. The image part of the function's name does bother me. But we could ignore it. Since we know it is a real cdrom drive, it

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Alex Williamson
On Thu, 2015-06-25 at 20:22 +, Casey Leedom wrote: Oh, and by the way, I've already asked Gabriel to respin the patch because the quirk incorrectly trips for all T5 Functions instead of only for T5 Virtual Functions. So you should reject the first patch regardless. Thanks! Casey

[Qemu-devel] [PATCH 3/4] hw/net: add simple phy support to mcf_fec driver

2015-06-25 Thread gerg
From: Greg Ungerer g...@uclinux.org The Linux fec driver needs at least basic phy support to probe and work. The current qemu mcf_fec emulation has no support for the reading or writing of the MDIO lines to access an attached phy. This code adds a very simple set of register results for a fixed

[Qemu-devel] [PATCH 2/4] hw/net: add ANLPAR bit definitions to generic mii

2015-06-25 Thread gerg
From: Greg Ungerer g...@uclinux.org Add a base set of bit definitions for the standard MII phy Auto-Negotiation Link Partner Ability Register (ANLPAR). The original definitions moved into mii.h from the allwinner_emac driver did not define these. Signed-off-by: Greg Ungerer g...@uclinux.org ---

[Qemu-devel] [PATCH 0/4] hw/net: fix m68/ColdFire ethernet fec support

2015-06-25 Thread gerg
The following set of patches fixes the emulated ColdFire ethernet fec driver. There is primarily two problems that need to be fixed. 1. The emulated driver needs to support probing of an attached phy. It is strait forward to emulate an attached phy, but to avoid using magic numbers I have

[Qemu-devel] [PATCH 4/4] hw/net: fix mcf_fec driver receiver

2015-06-25 Thread gerg
From: Greg Ungerer g...@uclinux.org The network mcf_fec driver emulated receive side method is returning a result of 0 causing the network layer to disable receive for this emulated device. This results in the guest only ever receiving one packet. Fix the recieve side processing to return the

Re: [Qemu-devel] [PATCH v3 2/5] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-25 Thread David Gibson
On Fri, Jun 26, 2015 at 09:36:01AM +0530, Bharata B Rao wrote: pc_dimm_plug() has code that will be needed for memory plug handlers in other archs too. Extract code from pc_dimm_plug() into a generic routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also correspondingly refactor

Re: [Qemu-devel] [PATCH v5 3/6] spapr: Support ibm, dynamic-reconfiguration-memory

2015-06-25 Thread David Gibson
On Thu, Jun 25, 2015 at 11:44:12AM +0530, Bharata B Rao wrote: Parse ibm,architecture.vec table obtained from the guest and enable memory node configuration via ibm,dynamic-reconfiguration-memory if guest supports it. This is in preparation to support memory hotplug for sPAPR guests. This

Re: [Qemu-devel] [PATCH v3 4/5] numa: Store boot memory address range in node_info

2015-06-25 Thread David Gibson
On Fri, Jun 26, 2015 at 09:36:03AM +0530, Bharata B Rao wrote: Store memory address range information of boot memory in address range list of numa_info. This helps to have a common NUMA node lookup by address function that works for both boot time memory and hotplugged memory.

Re: [Qemu-devel] [PATCH v3 1/5] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure

2015-06-25 Thread David Gibson
On Fri, Jun 26, 2015 at 09:36:00AM +0530, Bharata B Rao wrote: Move hotplug_memory_base and hotplug_memory fields of PCMachineState into a separate structure so that the same can be made use of from other architectures supporing memory hotplug. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [RFC PATCH v5 6/6] spapr: Don't allow memory hotplug to memory less nodes

2015-06-25 Thread Bharata B Rao
On Fri, Jun 26, 2015 at 03:33:29PM +1000, David Gibson wrote: On Thu, Jun 25, 2015 at 11:44:15AM +0530, Bharata B Rao wrote: Currently PowerPC kernel doesn't allow hot-adding memory to memory-less node, but instead will silently add the memory to the first node that has some memory. This

[Qemu-devel] [PATCH 1/4] hw/net: create common collection of MII definitions

2015-06-25 Thread gerg
From: Greg Ungerer g...@uclinux.org Create a common set of definitions of address and register values for ethernet MII phys. A few of the current ethernet drivers have at least a partial set of these definitions. Others just use hard coded raw constant numbers. This initial set is copied

Re: [Qemu-devel] [PATCH v3 0/5] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-25 Thread David Gibson
On Fri, Jun 26, 2015 at 09:35:59AM +0530, Bharata B Rao wrote: Hi, Here is the v3 of the patchset that refactors pc_dimm_plug and adds an API to lookup NUMA node by address. - Refactoring pc_dimm_plug() helps other architectures like PowerPC to make use of common code. - API to lookup

Re: [Qemu-devel] [PATCH v5 2/6] spapr: Add LMB DR connectors

2015-06-25 Thread David Gibson
On Thu, Jun 25, 2015 at 11:44:11AM +0530, Bharata B Rao wrote: Enable memory hotplug for pseries 2.4 and add LMB DR connectors. With memory hotplug, enforce RAM size, NUMA node memory size and maxmem to be a multiple of SPAPR_MEMORY_BLOCK_SIZE (256M) since that's the granularity in which LMBs

Re: [Qemu-devel] [PATCH v5 5/6] spapr: Memory hotplug support

2015-06-25 Thread David Gibson
On Thu, Jun 25, 2015 at 11:44:14AM +0530, Bharata B Rao wrote: Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Reviewed-by: David Gibson da...@gibson.dropbear.id.au -- David Gibson| I'll

Re: [Qemu-devel] [RFC PATCH v5 6/6] spapr: Don't allow memory hotplug to memory less nodes

2015-06-25 Thread David Gibson
On Thu, Jun 25, 2015 at 11:44:15AM +0530, Bharata B Rao wrote: Currently PowerPC kernel doesn't allow hot-adding memory to memory-less node, but instead will silently add the memory to the first node that has some memory. This causes two unexpected behaviours for the user. Memory gets

Re: [Qemu-devel] [PATCH v5 1/6] spapr: Initialize hotplug memory address space

2015-06-25 Thread David Gibson
On Thu, Jun 25, 2015 at 11:44:10AM +0530, Bharata B Rao wrote: Initialize a hotplug memory region under which all the hotplugged memory is accommodated. Also enable memory hotplug by setting CONFIG_MEM_HOTPLUG. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [PATCH 0/3] update CMOS for ISA-FDC with iobase=0x3f0

2015-06-25 Thread Laszlo Ersek
On 06/25/15 09:55, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: This is (again) for the other pc-q35-2.4 ISA-FDC problem reported by Jan. Addressing comments from Markus. Jan, can you give it another try please? I realize this is getting old pretty quick, so don't bother

Re: [Qemu-devel] [PATCH 01/11] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 12:25, Denis V. Lunev wrote: Paolo, Gleb, we are very sensitive on the first patch. Could you suggest which tree we should be based on? For now I think that we should use https://git.kernel.org/cgit/virt/kvm/kvm.git/ but the branch here could also matters. You can

Re: [Qemu-devel] [PATCH for-2.4] e1000: flush packets when link comes up

2015-06-25 Thread Fam Zheng
On Thu, 06/25 10:18, Stefan Hajnoczi wrote: e1000_can_receive() checks the link up status register bit. If the bit is clear, packets will be queued and the peer may disable receive to avoid wasting CPU reading packets that cannot be delivered. The queue must be flushed once the link comes

Re: [Qemu-devel] [PATCH 3/9] memory: Add global-locking property to memory regions

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 12:59, Fam Zheng wrote: I meant the above When this is invoked, access to this memory regions will be processed... compared to this accesses to the memory region. Ah, I see what you mean now. Fixed. Paolo

[Qemu-devel] [PATCH 04/10] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread Stefan Hajnoczi
Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret 0. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/backup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 05/10] block: add block job transactions

2015-06-25 Thread Stefan Hajnoczi
Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- blockjob.c| 160

Re: [Qemu-devel] [PATCH v3 0/4] iotests: skip tests with unchanged dependencies

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 12:17:40PM -0400, John Snow wrote: Hi Kevin, ping? Will probably need to respin to update the deps (for new tests) by now, but are you willing to take this series? Kevin is on vacation, this series is unlikely to make QEMU 2.4. I suggest rebasing around hard freeze

Re: [Qemu-devel] [PATCH 0/4] virtio-ccw: virtio-1 enablement

2015-06-25 Thread Michael S. Tsirkin
On Thu, Jun 25, 2015 at 12:24:40PM +0200, Cornelia Huck wrote: On Tue, 23 Jun 2015 19:19:39 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 23 Jun 2015 18:36:34 +0200 Thomas Huth th...@redhat.com wrote: On Tue, 23 Jun 2015 13:17:32 +0200 Cornelia Huck

[Qemu-devel] [PATCH for-2.4] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread Stefan Hajnoczi
Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret 0. Reviewed-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-25 Thread Michael S. Tsirkin
On Thu, Jun 25, 2015 at 01:01:29PM +0200, Thibaut Collet wrote: On Thu, Jun 25, 2015 at 11:59 AM, Jason Wang jasow...@redhat.com wrote: On 06/24/2015 07:05 PM, Michael S. Tsirkin wrote: On Wed, Jun 24, 2015 at 04:31:15PM +0800, Jason Wang wrote: On 06/23/2015 01:49 PM, Michael S.

Re: [Qemu-devel] [Qemu-block] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

2015-06-25 Thread Stefan Hajnoczi
On Thu, Jun 25, 2015 at 12:49:31PM +0200, Markus Armbruster wrote: Peter Maydell peter.mayd...@linaro.org writes: On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: This patchset attempts to improve the warning and error

Re: [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors

2015-06-25 Thread Fam Zheng
On Thu, 06/25 09:02, Fam Zheng wrote: On Wed, 06/24 19:01, Paolo Bonzini wrote: On 24/06/2015 11:08, Fam Zheng wrote: Stefan, The only controversial patches are the qmp/drive-mirror ones (1-3), while patches 4-8 are still useful on their own: they fix the mentioned crash

Re: [Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?

2015-06-25 Thread Christoffer Dall
On Thu, Jun 25, 2015 at 10:06:20AM +0100, Peter Maydell wrote: On 25 June 2015 at 09:00, Christoffer Dall christoffer.d...@linaro.org wrote: Of course, KVM can deny an unsupported configuration, but I am wondering if we really think anybody will care about the 'model such specific

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 16, 2015 at 01:45:07PM +0200, Peter Lieven wrote: libiscsi starting with 1.15 will properly support timeout of iscsi commands. The default will remain no timeout, but this can be changed via cmdline parameters, e.g.: qemu -iscsi timeout=30 -drive file=iscsi://... If a timeout

Re: [Qemu-devel] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 03:01:44PM +0100, Peter Maydell wrote: This patchset attempts to improve the warning and error messages for bad user command lines that attempt to connect a drive up to two devices. The motivation here is patch #4, which changes the default interface for the virt board

Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del

2015-06-25 Thread Paolo Bonzini
Ping? Paolo On 28/05/2015 16:17, Paolo Bonzini wrote: bdrv_close already does that, and in fact hmp_drive_del would need another drain after the flush (which bdrv_close does). So remove the duplication. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- blockdev.c | 3 --- 1 file

Re: [Qemu-devel] [PATCH 0/2] Remove CP15 timer from the device tree if KVM is used without in-kernel irqchip

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 13:14, Pavel Fedin p.fe...@samsung.com wrote: If we want to support KVM but without in-kernel irqchip I would really prefer that we did it this way, by implementing an ABI for letting the kernel tell us about the generic timer interrupts Yes, but: 1. This would work only

Re: [Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 13:41, Christoffer Dall christoffer.d...@linaro.org wrote: On Thu, Jun 25, 2015 at 10:06:20AM +0100, Peter Maydell wrote: I agree it's not very likely anybody cares about the specific cluster topology. However if we don't want to support arbitrary topologies then QEMU is

Re: [Qemu-devel] [PATCH v2 1/4] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-25 Thread Igor Mammedov
On Fri, 19 Jun 2015 10:40:21 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: pc_dimm_plug() has code that will be needed for memory plug handlers in other archs too. Extract code from pc_dimm_plug() into a generic routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also

[Qemu-devel] [PATCH v2 1/3] hw/i386/pc: factor out pc_cmos_init_floppy()

2015-06-25 Thread Laszlo Ersek
Extract the pc_cmos_init_floppy() function from pc_cmos_init(). The function sets two RTC registers: floppy drive types (0x10), overwriting the earlier value in there), and REG_EQUIPMENT_BYTE (0x14), setting bits in the prior value. Cc: Jan Tomko jto...@redhat.com Cc: John Snow js...@redhat.com

Re: [Qemu-devel] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

2015-06-25 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: This patchset attempts to improve the warning and error messages for bad user command lines that attempt to connect a drive up to

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-25 Thread Thibaut Collet
On Thu, Jun 25, 2015 at 11:59 AM, Jason Wang jasow...@redhat.com wrote: On 06/24/2015 07:05 PM, Michael S. Tsirkin wrote: On Wed, Jun 24, 2015 at 04:31:15PM +0800, Jason Wang wrote: On 06/23/2015 01:49 PM, Michael S. Tsirkin wrote: On Tue, Jun 23, 2015 at 10:12:17AM +0800, Jason Wang

Re: [Qemu-devel] [PATCH 3/9] memory: Add global-locking property to memory regions

2015-06-25 Thread Fam Zheng
On Thu, 06/25 09:46, Paolo Bonzini wrote: On 25/06/2015 05:44, Fam Zheng wrote: + * memory_region_clear_global_locking: Declares that access processing does + * not depend on the QEMU global lock. + * + * By clearing this property,

Re: [Qemu-devel] [PATCH for-2.4 01/12] block: Use bdrv_drain to replace uncessary bdrv_drain_all

2015-06-25 Thread Paolo Bonzini
Kevin, can you queue this patch for 2.4? Paolo On 29/05/2015 12:53, Fam Zheng wrote: There callers work on a single BlockDriverState subtree, where using bdrv_drain() is more accurate. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 6 +++--- block/snapshot.c | 2 +-

Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] Clean unused entries in the qcow2 L2/refcount cache

2015-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2015 at 07:14:34PM +0200, Alberto Garcia wrote: Ping... https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01929.html Kevin is on vacation, I am merging QEMU 2.4 bug fixes for the areas he maintains. This series is not a bug fix. Kevin will review it when he's back.

[Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups

2015-06-25 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- backends/hostmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index 4b5c53d..403be07 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -15,6 +15,7 @@ #include

Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 12:12, Andreas Färber afaer...@suse.de wrote: Am 24.06.2015 um 21:11 schrieb Peter Maydell: On 24 June 2015 at 19:09, Andreas Färber afaer...@suse.de wrote: +g_assert(cc-set_pc != NULL); +cc-set_pc(cpu, addr); } Do we need this assert? If it would have fired

[Qemu-devel] [PATCH 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-06-25 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were

Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)

2015-06-25 Thread Frederic Konrad
On 25/06/2015 01:55, Alexander Spyridakis wrote: On 24 June 2015 at 17:34, Alex Bennée alex.ben...@linaro.org wrote: Testing with Alexander's bare metal syncronisation tests fails in MTTCG leaving one CPU spinning forever waiting for the second CPU to wake up. We simply need to poke the

[Qemu-devel] [PATCH 03/10] block: rename BlkTransactionState and BdrvActionOps

2015-06-25 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it BlkActionState to be more accurate. (2) The BdrvActionOps describes operations for the

[Qemu-devel] [PATCH 02/10] iotests: add transactional incremental backup test

2015-06-25 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 06/10] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-06-25 Thread Stefan Hajnoczi
Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- blockdev.c | 9 + 1 file

[Qemu-devel] [PATCH 00/10] block: incremental backup transactions using BlockJobTxn

2015-06-25 Thread Stefan Hajnoczi
This series is based on my block branch (https://github.com/stefanha/qemu/commits/block). It uses patches from John Snow's [PATCH v6 00/10] block: incremental backup transactions series but implements the feature with a new transaction mechanism for blockjobs called BlockJobTxn. Recap:

Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2015 at 07:35:05PM +0200, Max Reitz wrote: On 12.06.2015 12:09, Stefan Hajnoczi wrote: Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret 0. Signed-off-by: Stefan

Re: [Qemu-devel] [PULL 00/15] Block patches

2015-06-25 Thread Peter Maydell
On 24 June 2015 at 16:27, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit a3206972a9eab65ec8e8f9ae320ad628ba4b58f1: Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-06-22' into staging (2015-06-23 10:38:00 +0100) are available in the git

Re: [Qemu-devel] [Qemu-block] [PATCH] block/nfs: add support for setting debug level

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support for it in qemu through an URL parameter. Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH] block/nfs: add support for setting debug level

2015-06-25 Thread Peter Lieven
Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi: On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support for it in qemu through an URL parameter. Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c | 4

[Qemu-devel] [PATCH v2 0/3] update CMOS for ISA-FDC with iobase=0x3f0

2015-06-25 Thread Laszlo Ersek
In v2 I address coding style comments I got from Markus for v1. No functional changes (Jan tested v1, many thanks for that). Updates are marked per patch. Markus, can you please give your R-b for patch #2? I picked up all other tags I received from John and you. Cc: Jan Tomko jto...@redhat.com

[Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-06-25 Thread Laszlo Ersek
With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: -device isa-fdc,driveA=drive-fdc0-0-0 \ -drive file=...,if=none,id=drive-fdc0-0-0,format=raw then the board-default FDC will be skipped, and only the explicitly requested FDC will exist. qtree-wise, this is correct;

Re: [Qemu-devel] [PATCH] gdb command: qemu iohandlers

2015-06-25 Thread Fam Zheng
On Thu, 06/25 10:08, Dr. David Alan Gilbert wrote: * Fam Zheng (f...@redhat.com) wrote: On Wed, 06/24 16:19, Stefan Hajnoczi wrote: On Tue, Jun 23, 2015 at 03:43:53PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Add a gdb

Re: [Qemu-devel] [PULL 06/11] icount: Add QemuOpts for icount

2015-06-25 Thread Peter Maydell
On 6 August 2014 at 17:12, Paolo Bonzini pbonz...@redhat.com wrote: From: Sebastian Tanase sebastian.tan...@openwide.fr Make icount parameter use QemuOpts style options in order to easily add other suboptions. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille

Re: [Qemu-devel] [PATCH 0/2] Remove CP15 timer from the device tree if KVM is used without in-kernel irqchip

2015-06-25 Thread Pavel Fedin
Hello! Curious, what is the kernels algorithm for choosing a timer when multiple are in the device-tree? To tell the truth, i don't know. Actually, during my first tests i just disabled architected timer in guest kernel config, and it started working. So, i decided to teach qemu to do the

Re: [Qemu-devel] [PATCH v3 1/3] softmmu: add helper function to pass through retaddr

2015-06-25 Thread Pavel Dovgaluk
From: Aurelien Jarno [mailto:aurel...@aurel32.net] On 2015-06-18 16:28, Pavel Dovgalyuk wrote: This patch introduces several helpers to pass return address which points to the TB. Correct return address allows correct restoring of the guest PC and icount. These functions should be used

Re: [Qemu-devel] [PATCH 0/2] Remove CP15 timer from the device tree if KVM is used without in-kernel irqchip

2015-06-25 Thread Pavel Fedin
Hi! If we want to support KVM but without in-kernel irqchip I would really prefer that we did it this way, by implementing an ABI for letting the kernel tell us about the generic timer interrupts Yes, but: 1. This would work only for newer kernels. 2. This little patch allows to work on

[Qemu-devel] [PATCH 08/10] iotests: 124 - transactional failure test

2015-06-25 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. Signed-off-by: John Snow js...@redhat.com

[Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-25 Thread Stefan Hajnoczi
Join the transaction when the backup block job is in incremental backup mode. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks can be retried in case of

[Qemu-devel] [PATCH 10/10] tests: add BlockJobTxn unit test

2015-06-25 Thread Stefan Hajnoczi
The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/Makefile| 3 + tests/test-blockjob-txn.c | 191

Re: [Qemu-devel] [Qemu-block] [PATCH] migration: flush the bdrv before stopping VM

2015-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2015 at 11:08:43AM +, Li, Liang Z wrote: Right now, we don't have an interface to detect that cases and got back to the iterative stage. How about go back to the iterative stage when detect that the pending_size is larger Than max_size, like this:

Re: [Qemu-devel] [RFC 5/9] block: add block job transactions

2015-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2015 at 08:37:43PM +0200, Max Reitz wrote: On 12.06.2015 12:09, Stefan Hajnoczi wrote: +void block_job_txn_add_job(BlockJobTxn *txn, BlockJob *job) +{ +if (!txn) { +return; +} Do you plan on making use of this case? I'm asking because while I'm usually in

Re: [Qemu-devel] [PATCH 0/4] virtio-ccw: virtio-1 enablement

2015-06-25 Thread Cornelia Huck
On Tue, 23 Jun 2015 19:19:39 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 23 Jun 2015 18:36:34 +0200 Thomas Huth th...@redhat.com wrote: On Tue, 23 Jun 2015 13:17:32 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: Michael, here's the virtio-ccw patches that

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

2015-06-25 Thread Zavadovsky Yan
On Thu, Jun 25, 2015 at 12:11 PM, Olga Krishtal okrish...@parallels.com wrote: On 24/06/15 15:25, Zavadovsky Yan wrote: Calling SuspendThread() is not enough to suspend Win32 thread. We need to call GetThreadContext() after SuspendThread() to make sure that OS have really suspended target

Re: [Qemu-devel] [RFC PATCH v4 2/5] spapr: Add LMB DR connectors

2015-06-25 Thread Michael Roth
Quoting David Gibson (2015-06-22 20:32:34) On Fri, Jun 19, 2015 at 03:47:54PM +0530, Bharata B Rao wrote: Enable memory hotplug for pseries 2.4 and add LMB DR connectors. With memory hotplug, enforce NUMA node memory size and maxmem to be a multiple of SPAPR_MEMORY_BLOCK_SIZE (256M) since

Re: [Qemu-devel] [PATCH 0/2] Remove CP15 timer from the device tree if KVM is used without in-kernel irqchip

2015-06-25 Thread Pavel Fedin
Hello! Also some boards have no fallback timer device at all (notably virt, so generic-timer *has* to work. Yes, some boards indeed don't have it. And virt, indeed, doesn't work. But, at least i can run vexpress guest. I'm out of further arguments. :) Kind regards, Pavel Fedin Expert

Re: [Qemu-devel] [PATCH] Revert dataplane: allow virtio-1 devices

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 03:52:56PM +0200, Cornelia Huck wrote: This reverts commit f5a5628cf0b65b223fa0c9031714578dfac4cf04. This was an old patch that had been already superseded by b0e5d90eb (dataplane: endianness-aware accesses). Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [Qemu-devel] [Qemu-block] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 02:26:51PM -0400, Programmingkid wrote: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM, Programmingkid wrote: Fix real cdrom detection so that a real cdrom can actually be used. signed-off-by: John Arbuckle programmingk...@gmail.com

Re: [Qemu-devel] [PATCH 01/11] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file

2015-06-25 Thread Denis V. Lunev
On 22/06/15 19:04, Denis V. Lunev wrote: From: Andrey Smetanin asmeta...@virtuozzo.com This patch introduces Hyper-V related source code file - hyperv.c and per vm and per vcpu hyperv context structures. All Hyper-V MSR's and hypercall code moved into hyperv.c. All hyper-v kvm/vcpu fields moved

Re: [Qemu-devel] [PATCH 0/2] Remove CP15 timer from the device tree if KVM is used without in-kernel irqchip

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 11:50, Pavel Fedin p.fe...@samsung.com wrote: The problem here is not unresponsive CP15, it's the other way round. It is responsive, but cannot be handled correctly. Actually, even this can be fixed; in order to do this we need to implement a VMEXIT in KVM upon IRQ arrival

Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-25 Thread Andreas Färber
Am 24.06.2015 um 21:11 schrieb Peter Maydell: On 24 June 2015 at 19:09, Andreas Färber afaer...@suse.de wrote: s/set-pc/set_pc/ Am 24.06.2015 um 05:19 schrieb Peter Crosthwaite: Add a wrapper around the CPUClass::set_pc() hook. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com

Re: [Qemu-devel] [PATCH v2 0/4] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-25 Thread Igor Mammedov
On Wed, 24 Jun 2015 09:04:46 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: On Fri, Jun 19, 2015 at 10:40:20AM +0530, Bharata B Rao wrote: Hi, Here is the v2 of the patchset that refactors pc_dimm_plug and adds an API to lookup NUMA node by address. - Refactoring

[Qemu-devel] [PATCH 09/10] qmp-commands.hx: Update the supported 'transaction' operations

2015-06-25 Thread Stefan Hajnoczi
From: Kashyap Chamarthy kcham...@redhat.com Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup

[Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Gabriel Laupre
Fix pba_offset initialization value for Chelsio T5 devices. The hardware doesn't return the correct pba_offset value, so add a quirk to instead return a hardcoded value of 0x1000 when a Chelsio T5 device is detected. Signed-off-by: Gabriel Laupre glau...@chelsio.com --- hw/vfio/pci.c

Re: [Qemu-devel] [PATCH 0/4] virtio-ccw: virtio-1 enablement

2015-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2015 14:49:00 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jun 25, 2015 at 12:24:40PM +0200, Cornelia Huck wrote: On a second thought, I can simply include dev-revision, as we have the incompatible -config_vector change for this release already. I'll include a

Re: [Qemu-devel] vmxnet3, vnet_hdr, and minimum length padding

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 11:49:25AM -0400, Brian Kress wrote: Thanks for sending a patch! I have CCed the vmxnet3 maintainer and Jason Wang, who looks at net subsystem patches: $ scripts/get_maintainer.pl -f hw/net/vmxnet3.c Dmitry Fleytman dmi...@daynix.com (maintainer:Vmware) When

[Qemu-devel] [PATCH v2 3/3] hw/i386/pc: don't carry FDC from pc_basic_device_init() to pc_cmos_init()

2015-06-25 Thread Laszlo Ersek
Thanks to the last patch, pc_cmos_init() doesn't need the (optional) board-default FDC any longer as an input parameter. Update pc_basic_device_init() not to hand it back to pc_init1() / pc_q35_init(), and update the latter not to carry the FDC to pc_cmos_init(). This simplifies the code.

Re: [Qemu-devel] vmxnet3, vnet_hdr, and minimum length padding

2015-06-25 Thread Brian Kress
Resending by request with Signed-off-by: When running ESXi under qemu there is an issue with the ESXi guest discarding packets that are too short. The guest discards any packets under the normal minimum length for an ethernet packet (60). This results in odd behaviour where other hosts

[Qemu-devel] [PATCH] block/curl: Don't lose original error when a connection fails.

2015-06-25 Thread Richard W.M. Jones
Currently if qemu is connected to a curl source (eg. web server), and the web server fails / times out / dies, you always see a bogus EIO Input/output error. For example, choose a large file located on any local webserver which you control: $ qemu-img convert -p http://example.com/large.iso

Re: [Qemu-devel] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: This patchset attempts to improve the warning and error messages for bad user command lines that attempt to connect a drive up to two devices. The motivation here is patch #4,

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-25 Thread Jason Wang
On 06/24/2015 07:05 PM, Michael S. Tsirkin wrote: On Wed, Jun 24, 2015 at 04:31:15PM +0800, Jason Wang wrote: On 06/23/2015 01:49 PM, Michael S. Tsirkin wrote: On Tue, Jun 23, 2015 at 10:12:17AM +0800, Jason Wang wrote: On 06/18/2015 11:16 PM, Thibaut Collet wrote: On Tue, Jun 16, 2015 at

Re: [Qemu-devel] [PATCH qemu v8 03/14] spapr_pci_vfio: Enable multiple groups per container

2015-06-25 Thread Alex Williamson
On Thu, 2015-06-18 at 21:37 +1000, Alexey Kardashevskiy wrote: This enables multiple IOMMU groups in one VFIO container which means that multiple devices from different groups can share the same IOMMU table (or tables if DDW). This removes a group id from vfio_container_ioctl(). The kernel

Re: [Qemu-devel] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Paolo Bonzini
On 16/06/2015 13:45, Peter Lieven wrote: libiscsi starting with 1.15 will properly support timeout of iscsi commands. The default will remain no timeout, but this can be changed via cmdline parameters, e.g.: qemu -iscsi timeout=30 -drive file=iscsi://... If a timeout occurs a reconnect

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Casey Leedom
Oh, and by the way, I've already asked Gabriel to respin the patch because the quirk incorrectly trips for all T5 Functions instead of only for T5 Virtual Functions. So you should reject the first patch regardless. Thanks! Casey From: Casey Leedom

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Casey Leedom
Hi Alex, the issue is that the T5 hardware has a bug in it where it reports a Pending Interrupt Bit Array Offset of 0x8000 for its SR-IOV Virtual Functions instead of the 0x1000 that the hardware actually uses internally. (There was a mistaken 3 used in the IP Glue Logic for the PCI

  1   2   3   >