[Qemu-devel] [PATCH] virtio-blk: use blk_io_plug/unplug for Linux AIO batching

2015-07-20 Thread Stefan Hajnoczi
The raw-posix block driver implements Linux AIO batching so multiple requests can be submitted with a single io_submit(2) system call. Batching is currently only used by virtio-scsi and virtio-blk-data-plane. Enable batching for regular virtio-blk so the number of io_submit(2) system calls is

[Qemu-devel] [PATCH] vfio/pci: Cleanup vfio_early_setup_msix() error path

2015-07-20 Thread Alex Williamson
With the addition of the Chelsio quirk we have an error path out of vfio_early_setup_msix() that doesn't free the allocated VFIOMSIXInfo struct. This doesn't introduce a leak as it still gets freed in the vfio_put_device() path, but it's complicated and sloppy to rely on that. Restructure to

Re: [Qemu-devel] [PATCH for-2.4] timer: rename NSEC_PER_SEC due to Mac OS X header clash

2015-07-20 Thread Stefan Hajnoczi
On Mon, Jul 20, 2015 at 2:02 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 8 July 2015 at 15:10, Stefan Hajnoczi stefa...@redhat.com wrote: Commit e0cf11f31c24cfb17f44ed46c254d84c78e7f6e9 (timer: Use a single definition of NSEC_PER_SEC for the whole codebase) renamed

Re: [Qemu-devel] [PATCH v2] net-hub: Drop can_receive

2015-07-20 Thread Fam Zheng
On Mon, 07/20 18:07, Stefan Hajnoczi wrote: On Tue, Jul 07, 2015 at 05:41:56PM +0800, Fam Zheng wrote: On Tue, 07/07 09:37, Stefan Hajnoczi wrote: On Tue, Jul 07, 2015 at 02:30:30PM +0800, Fam Zheng wrote: This moves the semantics from net_hub_port_can_receive to receive functions,

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-20 Thread zhanghailiang
On 2015/7/20 23:01, Stefan Hajnoczi wrote: On Mon, Jul 20, 2015 at 2:12 PM, Vasiliy Tolstov v.tols...@selfip.ru wrote: 2015-07-20 14:55 GMT+03:00 zhanghailiang zhang.zhanghaili...@huawei.com: Agreed, besides, it is seemed that slirp is not supporting ipv6, we also have to supplement it.

Re: [Qemu-devel] [PATCH RFC v2 10/47] qapi-visit: Fix two name arguments passed to visitors

2015-07-20 Thread Eric Blake
On 07/01/2015 02:21 PM, Markus Armbruster wrote: The generated code passes mangled schema names to visit_type_enum() and union's visit_start_struct(). Fix it to pass the names unadulterated, like we do everywhere else. Only qapi-schema-test.json actually has names where this makes a

Re: [Qemu-devel] [PATCH v2] AioContext: fix broken placement of event_notifier_test_and_clear

2015-07-20 Thread Fam Zheng
On Mon, 07/20 08:42, Paolo Bonzini wrote: I'm looking at optimizing it but I don't fully understand the relationship between aio_prepare and WaitForMultipleObjects. Do they get the same set of events? After some reading I think WaitForMultipleObjects is for event notifiers and

Re: [Qemu-devel] [PATCH RFC v2 07/47] qapi: Generate a nicer struct for flat unions

2015-07-20 Thread Eric Blake
On 07/01/2015 02:21 PM, Markus Armbruster wrote: The struct generated for a flat union is weird: the members of its base are at the end, except for the union tag, which is renamed to 'kind' and put at the beginning. Change to put all base members at the beginning, unadulterated. Not only

Re: [Qemu-devel] [PATCH RFC v2 09/47] qapi-visit: Replace list implicit_structs by set

2015-07-20 Thread Eric Blake
On 07/01/2015 02:21 PM, Markus Armbruster wrote: Use set because that's what it is. While there, rename to implicit_structs_seen. Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi-visit.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH RFC v2 08/47] qapi-visit: Fix generated code when schema has forward refs

2015-07-20 Thread Eric Blake
On 07/01/2015 02:21 PM, Markus Armbruster wrote: The visit_type_implicit_FOO() are generated on demand, right before their first use. Used by visit_type_STRUCT_fields() when STRUCT has base FOO, and by visit_type_UNION() when flat UNION has member a FOO. If the schema defines FOO after its

Re: [Qemu-devel] [PATCH RFC v2 11/47] tests/qapi-schema: Document alternate's enum lacks visit function

2015-07-20 Thread Eric Blake
On 07/01/2015 02:21 PM, Markus Armbruster wrote: We generate a declaration, but no definition. The QMP schema has two: Qcow2OverlapChecks and BlockdevRef. Neither visit_type_Qcow2OverlapChecksKind() nor visit_type_BlockdevRefKind() is actually used. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH RFC v2 12/47] tests/qapi-schema: Document events with with base don't work

2015-07-20 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: When event FOO's 'data' is a struct with a base, we consider only the struct's direct members, and ignore its base. The generated qapi_event_send_foo() doesn't take arguments for base members. No such events currently exist in the QMP schema.

Re: [Qemu-devel] [PATCH RFC v2 13/47] tests/qapi-schema: Restore test case for flat union base bug

2015-07-20 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: Test case added in commit 2fc0043, and messed up in commit 5223070. Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/qapi-schema/qapi-schema-test.json | 5 +++-- tests/qapi-schema/qapi-schema-test.out | 8 2 files

[Qemu-devel] [PATCH v3] tcg/ppc: Improve unaligned load/store handling on 64-bit backend

2015-07-20 Thread Benjamin Herrenschmidt
Currently, we get to the slow path for any unaligned access in the backend, because we effectively preserve the bottom address bits below the alignment requirement when comparing with the TLB entry, so any non-0 bit there will cause the compare to fail. For the same number of instructions, we can

Re: [Qemu-devel] [RFC PATCH] Fix hotplug/hotunplug issue about virtio 1.0 devices

2015-07-20 Thread Lin Ma
在 2015年07月20日 23:36, Michael S. Tsirkin 写道: On Mon, Jul 20, 2015 at 11:14:58PM +0800, Lin Ma wrote: Hi Michael and Gerd, I found an hotplug/hotunplug issue about virtio 1.0 devices and trying to fix it. The bug description is: (qemu) device_add virtio-gpu-pci,id=gpu0 (qemu) device_del gpu0

Re: [Qemu-devel] [PATCH] spapr: add dumpdtb support

2015-07-20 Thread David Gibson
On Mon, Jul 20, 2015 at 03:19:24PM +0200, Andrew Jones wrote: dumpdtb (-machine dumpdtb=file) allows one to inspect the generated device tree of machine types that generate device trees. This is useful for a) seeing what's there b) debugging/testing device tree generator patches. It can be

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] ignore bdrv_flush operation when no qcow2 cache item is dirty

2015-07-20 Thread Qingshu Chen
I've made a mistake on the series. Following is the new patch: From ef1079b422eef40a802ca13e249795005efa441d Mon Sep 17 00:00:00 2001 From: Qingshu Chen 1150163...@qq.com Date: Tue, 21 Jul 2015 09:46:08 +0800 Subject: [PATCH] ignore bdrv_flush operation when no qcow2 cache item is dirty

Re: [Qemu-devel] [PATCH] No change in userland tools after resizing qcow2 image

2015-07-20 Thread 김태하
On 07/19/2015 05:24 AM, Taeha Kim wrote: Hello, There is no change in userland tools after resizing qcow2 image except file utility. For example when resize qcow2 image, the file utility is detectable increased size. However, the ls, “stat”, and “du” utility still don't know how

<    1   2   3