2015-08-26 15:15 keltezéssel, Markus Armbruster írta:
Stefan Hajnoczi stefa...@gmail.com writes:
On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán dirty.ice...@gmail.com wrote:
This will let us print options in a format that the user would actually
write it on the command line
On 26 August 2015 at 23:15, Peter Crosthwaite
crosthwaitepe...@gmail.com wrote:
On Wed, Aug 26, 2015 at 2:46 PM, John Snow js...@redhat.com wrote:
For the uninitiated, how does MSI work with Sysbus?
No such thing :) Interrupts in Sysbus shouldn't really exist and those
that do are just a thin
On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote:
On 14 August 2015 at 07:16, Soren Brinkmann soren.brinkm...@xilinx.com
wrote:
The macro is defined twice in identical ways.
Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com
---
I have the feeling I'm missing a tiny
On Wed, Aug 26, 2015 at 1:36 PM, Alistair Francis
alistair.fran...@xilinx.com wrote:
On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite
crosthwaitepe...@gmail.com wrote:
On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis
alistair.fran...@xilinx.com wrote:
On Mon, Aug 17, 2015 at 4:37 PM,
Now, test the DMA functionality of the ATAPI drive.
Signed-off-by: John Snow js...@redhat.com
---
tests/ide-test.c | 90
1 file changed, 72 insertions(+), 18 deletions(-)
diff --git a/tests/ide-test.c b/tests/ide-test.c
index
'msi' target reports error if we attempt to use it when QEMU hasn't
been ./configure'd to enable it. The parenthesis cause an interpreter
error if we don't enclose the error in quotes.
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1
Currently, if we don't explicitly disable support for MSI installer
via --disable-guest-agent-msi, the configure variable that tracks
the flag, 'guest_agent_msi', never gets set unless one of the probes
fails. Subsequent code then treats this unset value the same as if it
were a yes value (via !=
These patches are based on the qga-dev tree:
https://github.com/mdroth/qemu/commits/qga-dev
and are also available from:
https://github.com/mdroth/qemu/commits/qga-dev-build-fixes
These are minor fixes/refactorings to improve the build process for
qemu-ga.
Makefile | 10 ++
configure
** Changed in: qemu (Ubuntu Trusty)
Assignee: Serge Hallyn (serge-hallyn) = (unassigned)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1422307
Title:
qemu-nbd corrupts files
Status in QEMU:
Currently VSS dll/tlb files for use in w32 builds are only built as a
result of having been added to the general 'tools' target alongside
qemu-ga. This is fine for default make target, but if we build
qemu-ga directly via `make qemu-ga.exe`, the VSS files are not
created.
Fix this by moving the
On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote:
On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote:
On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote:
On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote:
On Wed, Aug 26, 2015 at 06:31:57PM +0200, Markus Armbruster
On 08/26/2015 05:48 PM, Programmingkid wrote:
On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote:
On 26 August 2015 at 18:16, Programmingkid programmingk...@gmail.com wrote:
That is assuming they have the time and/or the interest in solving this
problem. I
suppose giving them some time
On Wed, Aug 26, 2015 at 2:46 PM, John Snow js...@redhat.com wrote:
On 08/26/2015 05:02 PM, Peter Crosthwaite wrote:
On Wed, Aug 26, 2015 at 1:36 PM, Alistair Francis
alistair.fran...@xilinx.com wrote:
On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite
crosthwaitepe...@gmail.com wrote:
On
MSI probe assumes that qemu-ga support has been probed already, but in
cases where --enable-guest-agent/--disable-guest-agent have not been
passed to configure, qemu-ga support may end up getting enabled later,
as is the case with w32 builds. This leads to MSI probe prematurely
reporting error due
On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite
crosthwaitepe...@gmail.com wrote:
On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis
alistair.fran...@xilinx.com wrote:
On Mon, Aug 17, 2015 at 4:37 PM, Peter Crosthwaite
crosthwaitepe...@gmail.com wrote:
On Mon, Aug 17, 2015 at 3:33 PM,
Add a simple read test for ATAPI devices,
using the PIO mechanism.
Signed-off-by: John Snow js...@redhat.com
---
tests/ide-test.c | 144 +++
1 file changed, 144 insertions(+)
diff --git a/tests/ide-test.c b/tests/ide-test.c
index
Share the pattern function for ide and ahci test.
Signed-off-by: John Snow js...@redhat.com
---
tests/ahci-test.c | 26 --
tests/libqos/libqos.c | 26 ++
tests/libqos/libqos.h | 1 +
3 files changed, 27 insertions(+), 26 deletions(-)
diff
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
Introduce a QCryptoTLSCredsAnon class which is used to
manage anonymous TLS credentials. Use of this class is
generally discouraged since it does not offer strong
security, but it is required for backwards compatibility
with the current VNC
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
Introduce a QCryptoTLSCredsX509 class which is used to
manage x509 certificate TLS credentials. This will be
the preferred credential type offering strong security
characteristics
Example CLI configuration:
$QEMU -object
Quoting Leonid Bloch (2015-08-26 07:07:16)
Previously, if building out-of-tree, the MSI build would fail since it wasn't
able to find the needed files.
Signed-off-by: Leonid Bloch leo...@daynix.com
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
---
Makefile
On Tue, Jun 30, 2015 at 04:37:13PM +0200, Marc-André Lureau wrote:
Use NetUserSetInfo() to set the user password.
This function is notoriously known to be problematic for users with EFS
encrypted files. But the alternative, NetUserChangePassword() requires
the old password. Nevertheless, The
Daniel P. Berrange berra...@redhat.com writes:
On Wed, Aug 26, 2015 at 11:13:00AM +0200, Alberto Garcia wrote:
On Tue 25 Aug 2015 09:54:42 AM CEST, Markus Armbruster wrote:
(D) Run in a controlled mixed locale
GTK runs completely in the locale determined by setlocale() (since it
On Wed, Aug 26, 2015 at 08:46:35AM +0200, Gerd Hoffmann wrote:
Hi,
It seems the only thing that we really care about being localized is
the messages catalogue, so the GTK UI gets internationalization in
its menus / dialogs / etc. As such I think that we should do the
opposite of
Wildcard mmio eventfd use zero size, but it will lead abort() since it
was illegal in adjust_endianness(). Fix this by allowing zero size.
Cc: Greg Kurz gk...@linux.vnet.ibm.com
Cc: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Jason Wang jasow...@redhat.com
---
memory.c | 1 +
1 file
Test fast mmio by using zero size eventfd.
Signed-off-by: Jason Wang jasow...@redhat.com
---
hw/misc/pci-testdev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c
index 26b9b86..7bf67ed 100644
--- a/hw/misc/pci-testdev.c
+++
From: Marc-André Lureau marcandre.lur...@redhat.com
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Reviewed-by: Denis V. Lunev den@openvz
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/qapi-schema.json | 2 +-
1 file changed, 1
marcandre.lur...@redhat.com writes:
From: Marc-André Lureau marcandre.lur...@redhat.com
Learn to configure the agent with a system configuration.
This may simplify command-line handling, especially when the blacklist
is long.
Among the other benefits, this may standardize the
Eric Blake ebl...@redhat.com writes:
On 08/25/2015 11:39 AM, Markus Armbruster wrote:
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler
On Mon, Aug 24, 2015 at 09:39:31PM -0500, Michael Roth wrote:
Quoting Bharata B Rao (2015-08-19 01:56:11)
Add support to hot remove pc-dimm memory devices.
Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com
---
hw/ppc/spapr.c | 114
From: Marc-André Lureau marcandre.lur...@redhat.com
The option parsing is going to be moved to a separate function,
use exit() consistently.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Denis V. Lunev d...@openvz.org
Reviewed-by: Eric Blake ebl...@redhat.com
From: Marc-André Lureau marcandre.lur...@redhat.com
A following patch will return allocated string.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/main.c | 57 +++--
1
From: Marc-André Lureau marcandre.lur...@redhat.com
'path' is already a global function, rename the variable since it's
going to be in global scope in a later patch.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/main.c |
On Wed, Aug 26, 2015 at 11:13:00AM +0200, Alberto Garcia wrote:
On Tue 25 Aug 2015 09:54:42 AM CEST, Markus Armbruster wrote:
(D) Run in a controlled mixed locale
GTK runs completely in the locale determined by setlocale() (since it
never has to display raw JSON)
We fix our JSON
From: Marc-André Lureau marcandre.lur...@redhat.com
Hi,
The following patches for the qemu agent add support for an optionnal
configuration file, and a man page.
Since v1:
- spelling fixes
- change device_path to channel_path
- moving config to GAConfig struct
- do check_is_frozen() during main
add an API qemu_netfilter_pass_to_next() to pass the packet
to next filter.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
---
v5: fold params to NetPacket struct
---
include/net/filter.h | 3 +++
net/filter.c | 33 +
2 files changed, 36
now that we have a buffer netfilter, update the command
description and help.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
CC: Luiz Capitulino lcapitul...@redhat.com
CC: Markus Armbruster arm...@redhat.com
---
v8: add more description for the filter to the TEXI section
---
hmp-commands.hx
From: Marc-André Lureau marcandre.lur...@redhat.com
Move option parsing out of giant main().
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/main.c | 165 +++--
1
From: Marc-André Lureau marcandre.lur...@redhat.com
Now that main() has a single exit point, we can free a few
more allocations.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
---
qga/main.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qga/main.c
Am 25.08.2015 um 08:02 schrieb Christian Rößner c...@roessner.co:
Hello,
I wrote this mail to the qemu-discuss mailing list, but today I am unsure, if
I chose the right list. So I copy and paste this mail here in hope someone
can respond :-)
I have reproducable problems with some
On Fri, Aug 14, 2015 at 08:14:46PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 10.06.2015 17:30, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
+ret = bdrv_pread(bs-file, bm-l1_table_offset, l1_table,
+ bm-l1_size
On 20.08.15 19:16, Thomas Huth wrote:
On 18/08/15 04:50, Philipp Kern wrote:
According to CPU Signaling and Response, Signal-Processor Orders,
the order field is bit position 56-63. Without this, the Linux
guest kernel is sometimes unable to stop emulation and enters
an infinite loop of XXX
On 08/25/2015 10:57 PM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:51:59PM +0800, Xiao Guangrong wrote:
+static void set_file(Object *obj, const char *str, Error **errp)
+{
+PCNVDIMMDevice *nvdimm = PC_NVDIMM(obj);
+
+if (nvdimm-file) {
+g_free(nvdimm-file);
+}
QTAILQ_ENTRY global_list but used by filter layer, so that we can
manage all filters together.
QTAILQ_ENTRY next used by netdev, filter belongs to the specific netdev is
in this queue.
This is mostly the same with init/cleanup of netdev object.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
This patch add a new object netfilter, capture all network packets.
Also implement a netbuffer based on this object.
the buffer netfilter could be used by VM FT solutions like
MicroCheckpointing, to buffer/release packets. Or to simulate
packet delay.
You can also get the series from:
From: Yang Hongyang bur...@gmail.com
When execute info network, print filter info also.
current info printed is simple, can add more info later.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
---
v7: initial patch
---
include/net/filter.h | 1 +
net/filter.c | 22
From: Marc-André Lureau marcandre.lur...@redhat.com
Add a simple man page for the qemu agent.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
Makefile | 14 +-
qemu-doc.texi | 6 +++
qemu-ga.texi | 136
From: Marc-André Lureau marcandre.lur...@redhat.com
This new option allows to review the agent configuration,
and ease the task of writing a configuration file.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/main.c | 62
This is the initial version of KVM-accelerated GICv3 support.
State load and save are not yet supported, live migration is
not possible.
In order to get correct class name in a simpler way, gicv3_class_name()
function is implemented, similar to gic_class_name().
Signed-off-by: Pavel Fedin
Add gic_version to VirtMachineState, set it to value of the option
and pass it around where necessary. Instantiate devices and fdt
nodes according to the choice.
max_cpus for virt machine increased to 126 (calculated from redistributor
space available in the memory map). GICv2 compatibility check
Some functions previously used only by vGICv2 are useful also for vGICv3
implementation. Untie them from GICState and make accessible from within
other modules:
- kvm_arm_gic_set_irq()
- kvm_gic_supports_attr() - moved to common code and renamed to
kvm_device_check_attr()
- kvm_gic_access() -
John Snow js...@redhat.com writes:
On 08/25/2015 02:20 PM, Markus Armbruster wrote:
Paolo Bonzini pbonz...@redhat.com writes:
On 19/06/2015 10:09, Andreas Färber wrote:
-Lines are 80 characters; not longer.
+Lines should be 80 characters; try not to make them longer.
+
+Sometimes it is
On 08/25/2015 11:12 PM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c
index a53d235..7a270a8 100644
--- a/hw/mem/nvdimm/pc-nvdimm.c
+++ b/hw/mem/nvdimm/pc-nvdimm.c
@@ -24,6 +24,19 @@
On 08/25/2015 11:12 PM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c
index a53d235..7a270a8 100644
--- a/hw/mem/nvdimm/pc-nvdimm.c
+++ b/hw/mem/nvdimm/pc-nvdimm.c
@@ -24,6 +24,19 @@
On 02.07.15 06:44, Anton Blanchard wrote:
We are setting SRR0 to the instruction before the one causing the
unaligned exception. A quick testcase:
. = 0x100
.globl _start
_start:
/* Cause a 0x600 */
li 3,0x1
stwcx. 3,0,3
1:b 1b
. = 0x600
1:b
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
---
include/net/queue.h | 7 +++
net/queue.c | 12 ++--
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/include/net/queue.h b/include/net/queue.h
index 1d65e47..e139cc7 100644
--- a/include/net/queue.h
+++
From: Shlomo Pongratz shlomo.pongr...@huawei.com
This class is to be used by both software and KVM implementations of GICv3
Currently it is mostly a placeholder, but in future it is supposed to hold
qemu's representation of GICv3 state, which is necessary for migration.
The interface of this
This series introduces support for GICv3 by KVM. Software emulation is
currently not supported.
V11 = V12
- Do not set timer PPI CPU mask in device tree for GICv3
- Fixed small styling issues in hw/arm/virt.c
- Completely untied kvm_gic_access() from GIC and turned into
kvm_device_access().
This allows to use different GIC types from v2. There are no kernels which
could advertise KVM_CAP_DEVICE_CTRL without the actual ability to create
GIC with it.
Signed-off-by: Pavel Fedin p.fe...@samsung.com
Reviewed-by: Eric Auger eric.au...@linaro.org
Tested-by: Ashok kumar ash...@broadcom.com
On 21.08.15 14:33, Rudolf Marek wrote:
Hi all,
Ping?
Thanks
Rudolf
Dne 14.8.2015 v 13:49 Rudolf Marek napsal(a):
Hi all,
I noticed that ATMU register reads on E500 are broken. Due to the
wrong mask,
some registers cannot be read and instead some other registers are
read. Please
Capture packets that will be sent.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
---
v5: do not check ret against iov_size
pass sent_cb to filters
---
net/net.c | 66 +++
1 file changed, 66 insertions(+)
diff --git a/net/net.c
add netfilter_{add|del} commands
This is mostly the same with netdev_{add|del} commands.
When we delete the netdev, we also delete the netfilter object
attached to it, because if the netdev is removed, the filters
which attached to it is useless.
Signed-off-by: Yang Hongyang
Add the framework for a new netfilter object and a new
-netfilter CLI option as a basis for the following patches.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
CC: Paolo Bonzini pbonz...@redhat.com
CC: Eric Blake ebl...@redhat.com
Reviewed-by: Thomas Huth th...@redhat.com
---
From: Marc-André Lureau marcandre.lur...@redhat.com
Once the options are populated, move the running state to
a run_agent() function.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/main.c | 164
From: Marc-André Lureau marcandre.lur...@redhat.com
The function is going to be reused in a later patch.
Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qga/main.c | 33 ++---
1 file changed, 22
On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote:
Changlog:
- Use litten endian for DSM method, thanks for Stefan's suggestion
- introduce a new parameter, @configdata, if it's false, Qemu will
build a static and readonly
On Tue, 25 Aug 2015 12:33:30 +0200
Pierre Morel pmo...@linux.vnet.ibm.com wrote:
Let dataplane allocate different region for the desc/avail/used
ring regions.
Signed-off-by: Pierre Morel pmo...@linux.vnet.ibm.com
---
Great ! It works !
Since we end up with 3 blocks of code that are
Am 25.08.2015 um 15:25 schrieb Thomas Huth:
On 19/08/15 17:58, Eduardo Habkost wrote:
On Wed, Jul 22, 2015 at 03:59:50PM +0200, Thomas Huth wrote:
The code in smp_parse already checks the topology information for
sockets * cores * threads cpus and bails out with an error in
that case.
Hi everybody,
I'm trying to do the next version of the MTTCG work:
I would like to rebase on Alvise atomic instruction branch:
- Alvise can you rebase it on the 2.4.0 version without MTTCG support
and then
point me to the MTTCG specific changes so I can include them in my
tree?
I will
On Fri, Aug 21, 2015 at 02:59:24PM -0700, Vladislav Yasevich wrote:
When operation in standard mode, we currently return the size
of packet during buffer overflow. This consumes the overflow
packet. Return 0 instead so we can re-process the overflow packet
when we have room.
This fixes
On Mon, Aug 24, 2015 at 02:25:24PM -0600, Eric Blake wrote:
+/* #define QCRYPTO_DEBUG */
+
+#ifdef QCRYPTO_DEBUG
+#define DPRINTF(fmt, ...) do { fprintf(stderr, fmt, ## __VA_ARGS__); }
while (0)
+#else
+#define DPRINTF(fmt, ...) do { } while (0)
+#endif
Please rework this to:
On 08/26/2015 04:05 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau marcandre.lur...@redhat.com
s/optionnal/optional/ in the subject line
Learn to configure the agent with a system configuration.
This may simplify command-line handling, especially when the blacklist
is
On 08/26/2015 12:03 AM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:01PM +0800, Xiao Guangrong wrote:
The parameter @file is used as backed memory for NVDIMM which is
divided into two parts if @dataconfig is true:
s/dataconfig/configdata/
Stupid typo, sorry.
@@ -76,13 +109,87
A number of files were including assert.h but not using any
of the functions it provides
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
disas/ia64.c | 1 -
hw/i386/xen/xen_platform.c| 2 --
linux-user/signal.c | 1 -
target-microblaze/op_helper.c | 1 -
A number of source files have statements accidentally
terminated by a double semicolon - eg 'foo = bar;;'.
This is harmless but a mistake none the less.
The tcg/ia64/tcg-target.c file is whitelisted because
it has valid use of ';;' in a comment containing assembly
code.
Signed-off-by: Daniel P.
A number of files were including dirent.h but not using any
of the functions it provides
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
fsdev/virtio-9p-marshal.c | 1 -
hw/tpm/tpm_passthrough.c | 2 --
hw/usb/redirect.c | 1 -
hw/vfio/pci.c | 1 -
qemu-char.c
Many source files have doubled words (eg the the, to to,
and so on). Most of these can simply be removed, but a couple
were actual mis-spellings (eg to to instead of to do).
There was even one triple word score to to to :-)
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Hi
On Tue, Jul 28, 2015 at 2:32 AM, Marc-André Lureau
marcandre.lur...@redhat.com wrote:
Hi,
This series is mostly about adding the client/server code from David
Marchand, code cleanups, and little improvements for ivshmem. Finally
there is some ivshmem tests (they work fine without kvm).
On Tue, 25 Aug 2015 15:25:00 +0200
Thomas Huth th...@redhat.com wrote:
On 19/08/15 17:58, Eduardo Habkost wrote:
On Wed, Jul 22, 2015 at 03:59:50PM +0200, Thomas Huth wrote:
The code in smp_parse already checks the topology information for
sockets * cores * threads cpus and bails out with
There are many problems in QEMU related to introspection
of features, which Markus has been attacking/slaying for
a while. One of the remaining elephants in the corner of
the room which I've not seen work on is QOM.
QOM has a nice class/object framework, kind of like GLib's
GObject, but with the
This converts the hostmem and hostmem-file objects to register
their properties against the class rather than object.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
backends/hostmem-file.c | 26 +++---
backends/hostmem.c | 41
Previously, if building out-of-tree, the MSI build would fail since it wasn't
able to find the needed files.
Signed-off-by: Leonid Bloch leo...@daynix.com
---
Makefile | 4 ++--
qga/installer/qemu-ga.wxs | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
On 08/26/2015 12:16 AM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:06PM +0800, Xiao Guangrong wrote:
+#ifdef NVDIMM_DEBUG
+#define nvdebug(fmt, ...) fprintf(stderr, nvdimm: fmt, ## __VA_ARGS__)
+#else
+#define nvdebug(...)
+#endif
The following allows the compiler to check format
This is a series of misc trivial code cleanups that I
originally used to illustrate the use of GNULIB's
syntax-check facility:
http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg06268.html
Since it appears the license of the GNULIB syntax-check
is problematic, this series has separated
The free() and g_free() functions both happily accept
NULL on any platform QEMU builds on. As such putting a
conditional 'if (foo)' check before calls to 'free(foo)'
merely serves to bloat the lines of code.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
backends/hostmem-file.c |
Reviewed-by: Marc-André Lureau marcandre.lur...@redhat.com
--
Marc-André Lureau
Hi
On Wed, Aug 26, 2015 at 1:17 PM, Daniel P. Berrange berra...@redhat.com wrote:
The free() and g_free() functions both happily accept
NULL on any platform QEMU builds on. As such putting a
conditional 'if (foo)' check before calls to 'free(foo)'
merely serves to bloat the lines of code.
When there are many instances of a given class, registering
properties against the instance is wasteful of resources. The
majority of objects have a statically defined list of possible
properties, so most of the properties are easily registerable
against the class. Only those properties which are
This converts the machine base object to register its properties
against the class rather than object.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
hw/core/machine.c | 193 +++---
1 file changed, 97 insertions(+), 96 deletions(-)
diff
This converts the tpm object to register its properties against
the class rather than object.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
backends/tpm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/backends/tpm.c b/backends/tpm.c
index
This converts the x86 CPU object to register its properties against
the class rather than object.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
target-i386/cpu.c | 55 ---
1 file changed, 28 insertions(+), 27 deletions(-)
diff
When registering the properties 'feature-words' and 'filtered-features'
object instance data is being passed in. This can easily be accessed
directly via the 'Object *obj' parameter passed to the getter, so
the object instance data does not need to be supplied at property
registration time.
Daniel P. Berrange berra...@redhat.com writes:
On Wed, Aug 26, 2015 at 08:46:35AM +0200, Gerd Hoffmann wrote:
Hi,
It seems the only thing that we really care about being localized is
the messages catalogue, so the GTK UI gets internationalization in
its menus / dialogs / etc. As
This converts the rng, rng-egd rng-random objects to register
their properties against the class rather than object.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
backends/rng-egd.c| 12
backends/rng-random.c | 10 +-
backends/rng.c| 14
Just to remind everybody as well - we’ll have a call next Monday to co-ordinate.
It would be good to make sure everybody knows which bit of this everybody else
is committing to do, so we avoid replication and treading on each others patch
sets.
Cheers
Mark.
On 26 Aug 2015, at 14:18, Frederic
On Fri, Aug 21, 2015 at 02:59:25PM -0700, Vladislav Yasevich wrote:
In standard operation mode, when the receive ring buffer
is full, the buffer actually appears empty to the driver since
the RxBufAddr (the location we wirte new data to) and RxBufPtr
(the location guest would stat reading
On 08/26/2015 12:11 AM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:03PM +0800, Xiao Guangrong wrote:
@@ -257,14 +258,91 @@ static void build_nfit_table(GSList *device_list, char
*buf)
}
}
+struct dsm_buffer {
+/* RAM page. */
+uint32_t handle;
+uint8_t
On 08/26/2015 12:23 AM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:07PM +0800, Xiao Guangrong wrote:
@@ -306,6 +354,18 @@ struct dsm_buffer {
static ram_addr_t dsm_addr;
static size_t dsm_size;
+struct cmd_out_implemented {
QEMU coding style uses typedef struct {} CamelCase.
On 08/26/2015 12:24 AM, Stefan Hajnoczi wrote:
On Fri, Aug 14, 2015 at 10:52:08PM +0800, Xiao Guangrong wrote:
Function 4 is used to get Namespace lable size
s/lable/label/
Stupid me, will fix the change log.
A number of files were including signal.h but not using any
of the functions it provides
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
bsd-user/signal.c | 1 -
hw/block/xen_disk.c | 1 -
hw/net/xen_nic.c| 1 -
hw/usb/redirect.c | 1 -
os-win32.c |
A number of files were including strings.h but not using any
of the functions it provides
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
disas/microblaze.c | 1 -
hw/pci/shpc.c | 1 -
page_cache.c| 1 -
tests/test-xbzrle.c | 1 -
4 files changed, 4 deletions(-)
diff
101 - 200 of 324 matches
Mail list logo
