[Qemu-devel] [PATCH v2 4/5] monitor: throttle QAPI_EVENT_VSERPORT_CHANGE by "id"

2015-09-17 Thread marcandre . lureau
From: Marc-André Lureau Use a hash table to lookup the pending event corresponding to the "id" field. The hash table may grow without limit here, the following patch will add some cleaning. Signed-off-by: Marc-André Lureau Reviewed-by:

Re: [Qemu-devel] [PATCH v8 00/26] qapi: QMP introspection

2015-09-17 Thread Markus Armbruster
I squashed in the assertion missing in PATCH 02 [Eric], and changed how test-qapi.py prints an enum type's prefix [Eric]. The latter led to the obvious expected test output changes in later patches. Result is now at git://repo.or.cz/qemu/armbru.git branch qapi-introspect. Still depends on

[Qemu-devel] [PATCH 2/2] tcg/mips: pass oi to tcg_out_tlb_load

2015-09-17 Thread Aurelien Jarno
Instead of computing mem_index and s_bits in both tcg_out_qemu_ld and tcg_out_qemu_st function and passing them to tcg_out_tlb_load, directly pass oi to the tcg_out_tlb_load function and compute mem_index and s_bits there. Signed-off-by: Aurelien Jarno ---

[Qemu-devel] [PATCH v18 08/21] i386: interrupt poll processing

2015-09-17 Thread Pavel Dovgalyuk
This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v18 15/21] bottom halves: introduce bh call function

2015-09-17 Thread Pavel Dovgalyuk
This patch introduces aio_bh_call function. It is used to execute bottom halves as callbacks without adding them to the queue. Signed-off-by: Pavel Dovgalyuk --- async.c |7 ++- include/block/aio.h |5 + 2 files changed, 11 insertions(+), 1

[Qemu-devel] [PATCH v18 19/21] replay: replay blockers for devices

2015-09-17 Thread Pavel Dovgalyuk
Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk --- hw/bt/hci.c |7 +++

[Qemu-devel] [RFC PATCH 06/10] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

2015-09-17 Thread David Gibson
At present the memory listener used by vfio to keep host IOMMU mappings in sync with the guest memory image assumes that if a guest IOMMU appears, then it has no existing mappings. This may not be true if a VFIO device is hotplugged onto a guest bus which didn't previously include a VFIO device,

[Qemu-devel] [PATCH v3 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-17 Thread Gabriel L. Somlo
Add a fw_cfg device node to the ACPI SSDT, on machine types pc-*-2.5 and up. While the guest-side BIOS can't utilize this information (since it has to access the hard-coded fw_cfg device to extract ACPI tables to begin with), having fw_cfg listed in ACPI will help the guest kernel keep a more

[Qemu-devel] [PATCH 04/16] quorum: Convert to BdrvChild

2015-09-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/quorum.c | 63 ++ 1 file changed, 33 insertions(+), 30 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index 8fe53b4..8e6e2dc 100644 --- a/block/quorum.c +++ b/block/quorum.c

[Qemu-devel] [PATCH 03/16] blkverify: Convert s->test_file to BdrvChild

2015-09-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/blkverify.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index d277e63..6b71622 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@

[Qemu-devel] [PATCH 13/16] block: Implement bdrv_append() without bdrv_swap()

2015-09-17 Thread Kevin Wolf
Remember all parent nodes and just change the pointers there instead of swapping the contents of the BlockDriverState. Handling of snapshot=on must be moved further down in bdrv_open() because *pbs (which is the bs pointer in the BlockBackend) must already be set before bdrv_append() is called.

Re: [Qemu-devel] help with understanding qcow2 file format

2015-09-17 Thread Eric Blake
On 09/17/2015 01:07 AM, Vasiliy Tolstov wrote: > 2015-09-16 16:46 GMT+03:00 Eric Blake : > >> qemu-img map file.qcow2 >> >> > Offset Length Mapped to File > qemu-img: File contains external, encrypted or compressed clusters. qemu-img map --output=json

[Qemu-devel] [RFC PATCH 08/10] spapr_iommu: Rename vfio_accel parameter

2015-09-17 Thread David Gibson
The vfio_accel parameter used when creating a new TCE table (guest IOMMU context) has a confusing name. What it really means is whether we need the TCE table created to be able to support VFIO devices. VFIO is relevant, because when available we use in-kernel acceleration of the TCE table, but

[Qemu-devel] [PATCH 12/16] block: Introduce parents list

2015-09-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 3 +++ include/block/block_int.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block.c b/block.c index 7930f3c..c196f83 100644 --- a/block.c +++ b/block.c @@ -1090,6 +1090,7 @@ static BdrvChild

[Qemu-devel] [PATCH 06/16] block: Remove bdrv_open_image()

2015-09-17 Thread Kevin Wolf
It is unused now. Signed-off-by: Kevin Wolf --- block.c | 34 -- include/block/block.h | 4 2 files changed, 38 deletions(-) diff --git a/block.c b/block.c index 93d713b..3992241 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [RFC PATCH 00/10] pseries: Allow VFIO devices on spapr-pci-host-bridge

2015-09-17 Thread David Gibson
Currently the pseries machine type uses two types of PCI Host Bridge (PHB) devices: "spapr-pci-host-bridge" the 'normal' variant intended for emulated PCI devices, and "spapr-pci-vfio-host-bridge" intended for VFIO devices. When using VFIO with pseries, a separate spapr-pci-vfio-host-bridge

[Qemu-devel] [RFC PATCH 05/10] memory: Allow replay of IOMMU mapping notifications

2015-09-17 Thread David Gibson
When we have guest visible IOMMUs, we allow notifiers to be registered which will be informed of all changes to IOMMU mappings. This is used by vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. However, unlike with a memory region listener, an iommu notifier won't be told

[Qemu-devel] [PATCH 02/16] vmdk: Use BdrvChild instead of BDS for references to extents

2015-09-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/vmdk.c | 99 +++- 1 file changed, 51 insertions(+), 48 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index be0d640..9702132 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -87,7

[Qemu-devel] [PATCH 01/16] block: Introduce BDS.file_child

2015-09-17 Thread Kevin Wolf
Store the BdrvChild for bs->file. At this point, bs->file_child->bs just duplicates the bs->file pointer. Later, it will completely replace it. Signed-off-by: Kevin Wolf --- block.c | 12 +--- include/block/block_int.h | 1 + 2 files changed, 10

Re: [Qemu-devel] [PATCH v4 3/3] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2015-09-17 Thread Knut Omang
On Thu, 2015-09-17 at 14:49 +0300, Marcel Apfelbaum wrote: > On 09/12/2015 03:36 PM, Knut Omang wrote: > > This patch provides the building blocks for creating an SR/IOV > > PCIe Extended Capability header and register/unregister > > SR/IOV Virtual Functions. > > > > Signed-off-by: Knut Omang

[Qemu-devel] [PATCH 07/16] block: Convert bs->backing_hd to BdrvChild

2015-09-17 Thread Kevin Wolf
This is the final step in converting all of the BlockDriverState pointers that block drivers use to BdrvChild. After this patch, bs->children contains the full list of child nodes that are referenced by a given BDS, and these children are only referenced through BdrvChild, so that updating the

[Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain()

2015-09-17 Thread Kevin Wolf
This cleans up the mess we left behind in the mirror code after the previous patch. Instead of using bdrv_swap(), just change pointers. The interface change of the mirror job that callers must consider is that after job completion, their local BDS pointers still point to the same node now.

[Qemu-devel] [PATCH v3 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-17 Thread Gabriel L. Somlo
Add a fw_cfg device node to the ACPI DSDT. This is mostly informational, as the authoritative fw_cfg MMIO region(s) are listed in the Device Tree. However, since we are building ACPI tables, we might as well be thorough while at it... Signed-off-by: Gabriel Somlo ---

[Qemu-devel] [PATCH v3 2/5] pc: fw_cfg: move ioport base constant to pc.h

2015-09-17 Thread Gabriel L. Somlo
Move BIOS_CFG_IOPORT define from pc.c to pc.h, and rename it to FW_CFG_IO_BASE. Signed-off-by: Gabriel Somlo --- hw/i386/pc.c | 5 ++--- include/hw/i386/pc.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH v3 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-17 Thread Gabriel L. Somlo
New since v2: - pc/i386 node in ssdt only on machine types *newer* than 2.4 (as suggested by Eduardo) I appreciate any further comments and reviews. Hopefully we can make this palatable for upstream, modulo the lingering concerns about whether "QEMU0002" is ok to use as the

[Qemu-devel] [PATCH v3 1/5] fw_cfg: expose control register size in fw_cfg.h

2015-09-17 Thread Gabriel L. Somlo
Expose the size of the control register (FW_CFG_SIZE, renamed to FW_CFG_CTL_SIZE) in fw_cfg.h. Add comment to fw_cfg_io_realize() pointing out that since the 8-bit data register is always subsumed by the 16-bit control register in the port I/O case, we use the control register width as the *total*

[Qemu-devel] [PATCH v3 5/5] fw_cfg: document ACPI device node information

2015-09-17 Thread Gabriel L. Somlo
Signed-off-by: Gabriel Somlo --- docs/specs/fw_cfg.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt index 5bc7b96..b5f4b5d 100644 --- a/docs/specs/fw_cfg.txt +++ b/docs/specs/fw_cfg.txt @@ -77,6 +77,15 @@ increasing

Re: [Qemu-devel] [PATCH v2] target-cris: update CPU state save/load to use VMStateDescription

2015-09-17 Thread Edgar E. Iglesias
On Thu, Sep 17, 2015 at 01:39:17PM +0100, Peter Maydell wrote: > On 12 August 2015 at 15:15, Edgar E. Iglesias > wrote: > > On Fri, Aug 07, 2015 at 05:02:14PM +0100, Peter Maydell wrote: > >> From: Juan Quintela > >> > >> Update the CRIS CPU state

Re: [Qemu-devel] [PULL 0/4] Net patches

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 12:43, Stefan Hajnoczi wrote: > The following changes since commit 619622424dba749feef752d76d79ef2569f7f250: > > Merge remote-tracking branch > 'remotes/berrange/tags/vnc-crypto-v9-for-upstream' into staging (2015-09-15 > 15:42:58 +0100) > > are

Re: [Qemu-devel] [RFC 17/38] aie: add target helpers

2015-09-17 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > aie-helper.c | 112 > ++ > include/exec/cpu-defs.h | 5 +++ > include/qemu/aie-helper.h | 6 +++ > 3 files changed, 123 insertions(+)

[Qemu-devel] [RFC PATCH 04/10] vfio: Record host IOMMU's available IO page sizes

2015-09-17 Thread David Gibson
Depending on the host IOMMU type we determine and record the available page sizes for IOMMU translation. We'll need this for other validation in future patches. Signed-off-by: David Gibson --- hw/vfio/common.c | 13 +

[Qemu-devel] [RFC PATCH 02/10] vfio: Generalize vfio_listener_region_add failure path

2015-09-17 Thread David Gibson
If a DMA mapping operation fails in vfio_listener_region_add() it checks to see if we've already completed initial setup of the container. If so it reports an error so the setup code can fail gracefully, otherwise throws a hw_error(). There are other potential failure cases in

[Qemu-devel] [PATCH 14/16] blockjob: Store device name at job creation

2015-09-17 Thread Kevin Wolf
Some block jobs change the block device graph on completion. This means that the device that owns the job and originally was addressed with its device name may no longer be what the corresponding BlockBackend points to. Previously, the effects of bdrv_swap() ensured that the job was (at least

[Qemu-devel] [PATCH 08/16] block: Manage backing file references in bdrv_set_backing_hd()

2015-09-17 Thread Kevin Wolf
This simplifies the code somewhat, especially when dropping whole backing file subchains. The exception is the mirroring code that does adventurous things with bdrv_swap() and in order to keep it working, I had to duplicate most of bdrv_set_backing_hd() locally. We'll get rid again of this

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-17 Thread Peter Maydell
On 7 September 2015 at 10:53, Paolo Bonzini wrote: > Mostly change severity levels, but some tests can also be adjusted to refer > to QEMU APIs or data structures. > > Signed-off-by: Paolo Bonzini > @@ -1956,9 +1941,14 @@ sub process { >

[Qemu-devel] [PATCH] throttle: test that snapshots move the throttling configuration

2015-09-17 Thread Alberto Garcia
If a snapshot is performed on a device that has I/O limits they should be moved to the target image (the new active layer). Signed-off-by: Alberto Garcia --- tests/qemu-iotests/096 | 69 ++ tests/qemu-iotests/096.out | 5

[Qemu-devel] [Bug 1496712] [NEW] no bootable device after qemu-img convert parallels windows 2012 r2 to raw/qcow2

2015-09-17 Thread Betschart
Public bug reported: Hello We have converted a parallels windows 2012 R2 image with the command qemu-img convert -p -f parallels -O raw ./TestLibvirt.pvm/TestLibvirtMig-0.hdd/TestLibvirtMig-0.hdd.0.hds /var/lib/libvirt/images/testlibvirtmig.raw Afterthat we have created a new entry with

[Qemu-devel] [PATCH 16/16] block: Remove bdrv_swap()

2015-09-17 Thread Kevin Wolf
bdrv_swap() is unused now. Remove it and all functions that have no other users than bdrv_swap(). In particular, this removes the .bdrv_rebind callbacks from block drivers. Signed-off-by: Kevin Wolf --- block.c | 155

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-17 Thread Eric Blake
On 09/17/2015 03:15 AM, Wen Congyang wrote: > On 09/10/2015 12:06 PM, Eric Blake wrote: >> From: Kővágó, Zoltán >> >> Except qapi-schema.json, this patch was generated by: >> >> find . -name .git -prune -o -type f \! -name '*~' -print0 | \ >> xargs -0 sed -i \ >> -e

Re: [Qemu-devel] [PATCH v2] target-cris: update CPU state save/load to use VMStateDescription

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 14:04, Edgar E. Iglesias wrote: > On Thu, Sep 17, 2015 at 01:39:17PM +0100, Peter Maydell wrote: >> On 12 August 2015 at 15:15, Edgar E. Iglesias >> wrote: >> > On Fri, Aug 07, 2015 at 05:02:14PM +0100, Peter Maydell

[Qemu-devel] [PATCH 09/16] block: Split bdrv_move_feature_fields()

2015-09-17 Thread Kevin Wolf
After bdrv_swap(), some fields must be moved back to their original BDS to compensate for the effects that a swap of the contents of the objects has while keeping the old addresses. Other fields must be moved back because they should logically be moved and must stay on top When replacing

Re: [Qemu-devel] [PATCH 1/3] monitor: split MonitorQAPIEventState

2015-09-17 Thread Marc-André Lureau
Hi On Wed, Sep 16, 2015 at 3:57 PM, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau >> >> Create a separate pending event structure MonitorQAPIEventPending. >> Use a MonitorQAPIEventDelay callback to

[Qemu-devel] [PATCH 10/16] block/io: Make bdrv_requests_pending() public

2015-09-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/io.c| 2 +- include/block/block_int.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index d7e742a..81371e6 100644 --- a/block/io.c +++ b/block/io.c @@ -213,7 +213,7 @@ void

[Qemu-devel] [PATCH 05/16] block: Convert bs->file to BdrvChild

2015-09-17 Thread Kevin Wolf
This patch removes the temporary duplication between bs->file and bs->file_child by converting everything to BdrvChild. Signed-off-by: Kevin Wolf --- block.c | 61 ++ block/blkdebug.c | 32

[Qemu-devel] [PATCH 00/16] block: Get rid of bdrv_swap()

2015-09-17 Thread Kevin Wolf
bdrv_swap() has always been an ugly hack that we would rather have avoided. When it was introduced, we simply didn't have the infrastructure to update pointers instead of transplanting the contents of BDS object, so we grudgingly added bdrv_swap() as a quick solution. Meanwhile, most of the

Re: [Qemu-devel] [PATCH 3/3] monitor: remove old entries from event hash table

2015-09-17 Thread Marc-André Lureau
On Wed, Sep 16, 2015 at 6:50 PM, Markus Armbruster wrote: > I doubt you're supposed to poke into p->timer like that. > I don't think that matters, much (it could have a helper perhaps), anyway: >> +timer_mod_ns(p->timer, then); >> +} >> + >> +static void

[Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured

2015-09-17 Thread David Gibson
At present the PCI host bridge (PHB) for the pseries machine type has a fixed DMA window from 0..1GB (in PCI address space) which is mapped to real memory via the PAPR paravirtualized IOMMU. For better support of VFIO devices, we're going to want to allow for different configurations of the DMA

[Qemu-devel] [RFC PATCH 10/10] spapr_pci: Allow VFIO devices to work on the normal PCI host bridge

2015-09-17 Thread David Gibson
The core VFIO infrastructure more or less allows VFIO devices to work on any normal guest PCI host bridge (PHB) without extra logic. However, the "spapr-pci-host-bridge" device (as opposed to the special "spapr-pci-vfio-host-bridge" device) breaks this by using a partially KVM accelerated

[Qemu-devel] [PATCH 11/16] block-backend: Add blk_set_bs()

2015-09-17 Thread Kevin Wolf
It allows changing the BlockDriverState that a BlockBackend points to. Signed-off-by: Kevin Wolf --- block/block-backend.c | 16 include/block/block_int.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/block/block-backend.c

Re: [Qemu-devel] [PATCH 2/3] monitor: throttle QAPI_EVENT_VSERPORT_CHANGE by "id"

2015-09-17 Thread Marc-André Lureau
Hi On Wed, Sep 16, 2015 at 6:40 PM, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau >> >> Use a hash table to lookup the pending event corresponding to the "id" >> field. The hash table may grow without

Re: [Qemu-devel] [PATCH v8 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-17 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Fixes flat unions to get the base's base members. Test case is from > commit 2fc0043, in qapi-schema-test.json: > > { 'union': 'UserDefFlatUnion', > 'base': 'UserDefUnionBase', > 'discriminator': 'enum1', > 'data': {

Re: [Qemu-devel] [PATCH v14 0/5] vGICv3 support

2015-09-17 Thread Peter Maydell
On 9 September 2015 at 08:49, Pavel Fedin wrote: > This series introduces support for GICv3 by KVM. Software emulation is > currently not supported. > > v13 => v14 > > - Rebased on the latest master, fixed conflicts in hw/arm/virt.c > You'll need to fix the acpi related bits

[Qemu-devel] [PATCH RFC V4 3/4] target-arm/cpu64 GICv3 system instructions support

2015-09-17 Thread Shlomo Pongratz
From: Shlomo Pongratz Add system instructions used by the Linux (kernel) GICv3 device driver Signed-off-by: Shlomo Pongratz --- target-arm/cpu-qom.h | 1 + target-arm/cpu.h | 12 ++ target-arm/cpu64.c | 118

Re: [Qemu-devel] [PATCH RFC V4 0/4] Implement GIC-500 from GICv3 family for arm64

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 19:18, Shlomo Pongratz wrote: > On Thursday, September 17, 2015, Peter Maydell >> This still seems to have the same issues as were noted in previous >> rounds: >> * you need to get rid of the limitation on number of

Re: [Qemu-devel] [PATCH RFC V4 0/4] Implement GIC-500 from GICv3 family for arm64

2015-09-17 Thread Shlomo Pongratz
See inline. On Thursday, September 17, 2015, Peter Maydell wrote: > On 17 September 2015 at 19:18, Shlomo Pongratz > wrote: > > On Thursday, September 17, 2015, Peter Maydell > > >>

Re: [Qemu-devel] [RFC PATCH 06/10] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

2015-09-17 Thread Alex Williamson
On Thu, 2015-09-17 at 23:09 +1000, David Gibson wrote: > At present the memory listener used by vfio to keep host IOMMU mappings > in sync with the guest memory image assumes that if a guest IOMMU > appears, then it has no existing mappings. > > This may not be true if a VFIO device is hotplugged

[Qemu-devel] [PATCH RFC V4 0/4] Implement GIC-500 from GICv3 family for arm64

2015-09-17 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported. This is because largest integer type has the size of 64 bits and modifying essential data structures in order to support 128 cores will require

[Qemu-devel] [PATCH RFC V4 4/4] Add virt-v3 machine that uses GIC-500

2015-09-17 Thread Shlomo Pongratz
From: Pavel Fedin I would like to offer this, slightly improved implementation. The key thing is a new kernel_irqchip_type member in Machine class. Currently it it used only by virt machine for its internal purposes, however in future it is to be passed to KVM in

[Qemu-devel] [PATCH RFC V4 1/4] hw/intc: Implement GIC-500 support files

2015-09-17 Thread Shlomo Pongratz
From: Shlomo Pongratz Add files need to maintain the GIC-500 state. Signed-off-by: Shlomo Pongratz --- hw/intc/arm_gicv3_common.c | 120 ++- hw/intc/gicv3_internal.h | 161

Re: [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation

2015-09-17 Thread John Snow
On 09/17/2015 04:40 AM, Stefan Hajnoczi wrote: > On Tue, Sep 01, 2015 at 04:50:37PM -0400, John Snow wrote: >> Ultimately, clean up the signature generation and as a result, tidy up >> the port_reset and init_d2h functions. >> >>

Re: [Qemu-devel] MIPS qemu build failure

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 19:21, Steve Ellcey wrote: > > Following up to my own email. Apparently the reason I get this error is > that I am building with "--disable-tools --disable-system". I don't need > the tools and I don't have pixman on my build system so if I don't use

Re: [Qemu-devel] [RFC PATCH 09/10] spapr_iommu: Provide a function to switch a TCE table to allowing VFIO

2015-09-17 Thread Alex Williamson
On Thu, 2015-09-17 at 23:09 +1000, David Gibson wrote: > Because of the way non-VFIO guest IOMMU operations are KVM accelerated, not > all TCE tables (guest IOMMU contexts) can support VFIO devices. Currently, > this is decided at creation time. > > To support hotplug of VFIO devices, we need to

[Qemu-devel] [PATCH RFC V4 2/4] hw/intc: Implment GIC-500

2015-09-17 Thread Shlomo Pongratz
From: Shlomo Pongratz Implement GIC-500 from GICv3 family for arm64 This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported. This is because the largest integer type has the size of 64 bits and modifying essential data

Re: [Qemu-devel] MIPS qemu build failure

2015-09-17 Thread Steve Ellcey
Following up to my own email. Apparently the reason I get this error is that I am building with "--disable-tools --disable-system". I don't need the tools and I don't have pixman on my build system so if I don't use "--disable-tools --disable-system" I get an error about not having pixman

Re: [Qemu-devel] [RFC PATCH 00/10] pseries: Allow VFIO devices on spapr-pci-host-bridge

2015-09-17 Thread Alex Williamson
On Thu, 2015-09-17 at 23:09 +1000, David Gibson wrote: > Currently the pseries machine type uses two types of PCI Host Bridge > (PHB) devices: "spapr-pci-host-bridge" the 'normal' variant intended > for emulated PCI devices, and "spapr-pci-vfio-host-bridge" intended > for VFIO devices. > > When

Re: [Qemu-devel] [PATCH 0/2] tcg/mips: small cleanups

2015-09-17 Thread Richard Henderson
On 09/17/2015 09:03 AM, Aurelien Jarno wrote: > I have these patches for quite some time in one of my local branch in > the hope I would have time to do further changes. Given that I am going > to send a pull request for the 64-bit qemu_ld issue, I think it's a good > opportunity to also include

Re: [Qemu-devel] [PATCH RFC V4 0/4] Implement GIC-500 from GICv3 family for arm64

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 19:54, Shlomo Pongratz wrote: > See inline. (You don't need to keep saying this, by the way -- inline quoting and response is the usual form of email on this list.) > On Thursday, September 17, 2015, Peter Maydell >

Re: [Qemu-devel] [PATCH 1/7] qapi: support implicit structs in OptsVisitor

2015-09-17 Thread Eric Blake
On 09/07/2015 06:08 AM, Kővágó, Zoltán wrote: > They are required for flat unions (you still have to allocate the > structs). > > Signed-off-by: Kővágó, Zoltán > --- > qapi/opts-visitor.c | 15 +++ > 1 file changed, 15 insertions(+) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 5/7] qapi: change Netdev into a flat union

2015-09-17 Thread Eric Blake
On 09/07/2015 06:14 AM, Kővágó, Zoltán wrote: > Except qapi-schema.json, this patch was generated by: > > find . -name .git -prune -o -type f \! -name '*~' -print0 | \ > xargs -0 sed -i \ > -e 's/NetClientOptionsKind/NetClientDriver/g' \ > -e

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-17 Thread Eric Blake
On 09/17/2015 08:34 AM, Eric Blake wrote: >> >> I apply Markus's v8 patch and this series, make check will fail: >> TEST: tests/virtio-net-test... (pid=23648) >> /x86_64/virtio/net/pci/basic: >> qemu-system-x86_64: -netdev socket,fd=6,id=hs0: Invalid

Re: [Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_to_opc

2015-09-17 Thread Richard Henderson
On 09/08/2015 11:46 AM, Peter Maydell wrote: > On 2 September 2015 at 06:52, Richard Henderson wrote: >> The gen_opc_* arrays are already redundant with the data stored in >> the insn_start arguments. Transition restore_state_to_opc to use >> data from the later. > > Typo:

Re: [Qemu-devel] [PATCH v3 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-17 Thread Michael S. Tsirkin
On Thu, Sep 17, 2015 at 10:56:29AM -0400, Gabriel L. Somlo wrote: > New since v2: > > - pc/i386 node in ssdt only on machine types *newer* than 2.4 > (as suggested by Eduardo) > > I appreciate any further comments and reviews. Hopefully we can make > this palatable for upstream,

Re: [Qemu-devel] [PATCH 6/7] qapi: reorder NetdevBase and Netdev

2015-09-17 Thread Eric Blake
On 09/07/2015 06:14 AM, Kővágó, Zoltán wrote: > Probably more logical if NetdevBase comes before Netdev. > No semantic changes. > > Signed-off-by: Kővágó, Zoltán > Reviewed-by: Eric Blake > --- > qapi-schema.json | 46

Re: [Qemu-devel] QEMU+Aarch64: in_asm log skips instructions of loop-programs

2015-09-17 Thread Christopher Covington
Hi Sergey, On 09/04/2015 12:38 PM, Sergey Smolov wrote: > >> >> 03.09.2015 19:35, Peter Maydell пишет: >>> On 3 September 2015 at 15:31, Sergey Smolov wrote: Do you think it is possible to implement another QEMU logger which will make a record for every executed

Re: [Qemu-devel] [PATCH 7/7] qapi: support nested structs in OptsVisitor

2015-09-17 Thread Eric Blake
On 09/07/2015 06:14 AM, Kővágó, Zoltán wrote: > The current OptsVisitor flattens the whole structure, if there are same > named fields under different paths (like `in' and `out' in `Audiodev'), > the current visitor can't cope with them (for example setting > `frequency=44100' will set the in's

Re: [Qemu-devel] [PATCH v3 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-17 Thread Gabriel L. Somlo
On Thu, Sep 17, 2015 at 11:30:59PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 17, 2015 at 10:56:29AM -0400, Gabriel L. Somlo wrote: > > New since v2: > > > > - pc/i386 node in ssdt only on machine types *newer* than 2.4 > > (as suggested by Eduardo) > > > > I appreciate any further

Re: [Qemu-devel] [PATCH 7/7] qapi: support nested structs in OptsVisitor

2015-09-17 Thread Kővágó Zoltán
2015-09-17 23:24 keltezéssel, Eric Blake írta: On 09/07/2015 06:14 AM, Kővágó, Zoltán wrote: The current OptsVisitor flattens the whole structure, if there are same named fields under different paths (like `in' and `out' in `Audiodev'), the current visitor can't cope with them (for example

Re: [Qemu-devel] [PATCH v2] virtio: add some migration doc

2015-09-17 Thread Dr. David Alan Gilbert
* Cornelia Huck (cornelia.h...@de.ibm.com) wrote: > Try to cover the basics of virtio migration. Thank you for doing this; I don't know the innards of virtio, but having to debug migration with it in the mix, it is nice to have something to look at. Dave > Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [RFC PATCH 08/10] spapr_iommu: Rename vfio_accel parameter

2015-09-17 Thread Alex Williamson
On Thu, 2015-09-17 at 23:09 +1000, David Gibson wrote: > The vfio_accel parameter used when creating a new TCE table (guest IOMMU > context) has a confusing name. What it really means is whether we need the > TCE table created to be able to support VFIO devices. > > VFIO is relevant, because

Re: [Qemu-devel] [PATCH RFC V4 0/4] Implement GIC-500 from GICv3 family for arm64

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 18:38, Shlomo Pongratz wrote: > From: Shlomo Pongratz > > This patch is a first step toward 128 cores support for arm64. > > At first only 64 cores are supported. > This is because largest integer type has the size of

Re: [Qemu-devel] [PATCH RFC V4 0/4] Implement GIC-500 from GICv3 family for arm64

2015-09-17 Thread Shlomo Pongratz
Thanks Please see inline Best regards, S.P. On Thursday, September 17, 2015, Peter Maydell wrote: > On 17 September 2015 at 18:38, Shlomo Pongratz > wrote: > > From: Shlomo Pongratz

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-17 Thread Wen Congyang
On 09/18/2015 04:11 AM, Eric Blake wrote: > On 09/17/2015 08:34 AM, Eric Blake wrote: > >>> >>> I apply Markus's v8 patch and this series, make check will fail: >>> TEST: tests/virtio-net-test... (pid=23648) >>> /x86_64/virtio/net/pci/basic: >>>

Re: [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support

2015-09-17 Thread Yuanhan Liu
On Thu, Sep 17, 2015 at 03:23:55PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 15, 2015 at 03:10:27PM +0800, Yuanhan Liu wrote: > > Hi, > > > > Here is the updated patch set for enabling vhost-user multiple queue. > > This patch set introduces 2 more vhost user messages: > >

[Qemu-devel] [PATCH] hw/pci-host/piix: fix one file descriptor leak

2015-09-17 Thread Tiejun Chen
Commit 595a4f07d6bd (piix: create host bridge to passthrough) introduced to leak of one file descriptor, "config_fd", now just fix that. CC: Michael S. Tsirkin CC: Stefano Stabellini CC: Paolo Bonzini Acked-by: Stefano

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-17 Thread Yang Hongyang
On 09/18/2015 12:09 AM, Eric Blake wrote: On 09/16/2015 07:23 PM, Yang Hongyang wrote: +{ 'enum': 'NetFilterChain', + 'data': [ 'all', 'in', 'out' ] } I don't see any other QMP usage of this enum anywhere in the series. Are you planning on supporting QMP? If so, let's get that design

[Qemu-devel] Determining if USB is available

2015-09-17 Thread Programmingkid
Would you know of a function that could indicate if USB is available on the current emulator?

Re: [Qemu-devel] [PATCH v2] virtio: add some migration doc

2015-09-17 Thread Jason Wang
On 09/18/2015 12:42 AM, Cornelia Huck wrote: > Try to cover the basics of virtio migration. > > Signed-off-by: Cornelia Huck > Reviewed-by: Greg Kurz > --- > v1->v2: make copyright explicit > --- Reviewed-by: Jason Wang

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-17 Thread Michael Roth
Quoting Paolo Bonzini (2015-09-17 10:53:40) > > > On 17/09/2015 17:50, Michael Roth wrote: > > We still need globals for RTAS lookups. I think QOM is our most > > mature/well-tested interface for managing inter-device > > relationships/lookups, but I can understand if using > >

Re: [Qemu-devel] [RFC PATCH 08/10] spapr_iommu: Rename vfio_accel parameter

2015-09-17 Thread David Gibson
On Thu, Sep 17, 2015 at 10:54:38AM -0600, Alex Williamson wrote: > On Thu, 2015-09-17 at 23:09 +1000, David Gibson wrote: > > The vfio_accel parameter used when creating a new TCE table (guest IOMMU > > context) has a confusing name. What it really means is whether we need the > > TCE table

Re: [Qemu-devel] [RFC PATCH 06/10] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

2015-09-17 Thread David Gibson
On Thu, Sep 17, 2015 at 10:54:24AM -0600, Alex Williamson wrote: > On Thu, 2015-09-17 at 23:09 +1000, David Gibson wrote: > > At present the memory listener used by vfio to keep host IOMMU mappings > > in sync with the guest memory image assumes that if a guest IOMMU > > appears, then it has no

[Qemu-devel] [PATCH v3] ui/cocoa.m: Add Mount image file menu item

2015-09-17 Thread Programmingkid
Add "Mount Image File..." and a "Eject Image File" menu items to cocoa interface. This patch makes sharing files between the host and the guest user-friendly. The "Mount Image File..." menu item displays a dialog box having the user pick an image file to use in QEMU. The image file is setup as a

[Qemu-devel] [PATCH v2 00/22] Do away with TB retranslation

2015-09-17 Thread Richard Henderson
Version 2, updated based on comments. Notable changes: (1) Move breakpoint recognition after insn_start. Now we really do never have zero insns per TB. Assertions added. (2) Comments added. (3) Minor tweeks to the encoding, reflected in the comments. I examined a handfull of test

[Qemu-devel] [PATCH v2 02/22] target-*: Unconditionally emit tcg_gen_insn_start

2015-09-17 Thread Richard Henderson
While we're at it, emit the opcode adjacent to where we currently record data for search_pc. This puts gen_io_start et al on the "correct" side of the marker. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c

[Qemu-devel] [PATCH v2 18/22] tcg: Add TCG_MAX_INSNS

2015-09-17 Thread Richard Henderson
Adjust all translators to respect it. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 3 +++ target-arm/translate-a64.c| 3 +++ target-arm/translate.c| 6 +- target-cris/translate.c

[Qemu-devel] [PATCH v2 10/22] target-sh4: Add flags state to insn_start

2015-09-17 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sh4/cpu.h | 1 + target-sh4/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-sh4/cpu.h b/target-sh4/cpu.h index 1f68b27..ea854cb

[Qemu-devel] [PATCH v2 09/22] target-s390x: Add cc_op state to insn_start

2015-09-17 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-s390x/cpu.h | 1 + target-s390x/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index

[Qemu-devel] [PATCH v2 13/22] target-sparc: Split out gen_branch_n

2015-09-17 Thread Richard Henderson
Unify three copies of this code from different branch types. Fix the case when npc == DYNAMIC_PC, i.e. a branch within a delay slot. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/translate.c | 55

[Qemu-devel] [PATCH v2 22/22] tcg: Remove tcg_gen_code_search_pc

2015-09-17 Thread Richard Henderson
It's no longer used, so tidy up everything reached by it. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg.c | 59 +++ tcg/tcg.h | 2 -- 2 files changed, 19

[Qemu-devel] [PATCH v2 14/22] target-sparc: Remove gen_opc_jump_pc

2015-09-17 Thread Richard Henderson
Since jump_pc[1] is always npc + 4, we can infer after incrementing that jump_pc[1] == pc + 4. Because of that, we can encode the branch destination into a single word, and store that in npc. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v2 16/22] tcg: Merge cpu_gen_code into tb_gen_code

2015-09-17 Thread Richard Henderson
As it's only caller, this tidies things a bit. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 - translate-all.c | 131 ++-- 2 files changed, 59

<    1   2   3   >