On 09/18/2015 06:08 AM, Peter Maydell wrote:
On 18 September 2015 at 05:55, Richard Henderson wrote:
We can now restore state without retranslation.
Signed-off-by: Richard Henderson
---
+/* Encode the data collected about the instructions while compiling
On Tue, Sep 15, 2015 at 7:36 AM, Daniel P. Berrange wrote:
> If the administrator incorrectly sets up their x509 certificates,
> the errors seen at runtime during connection attempts are very
> obscure and difficult to diagnose. This has been a particular
> problem for people
Am 19.09.2015 um 23:10 schrieb Richard Henderson:
> I started down the path toward using this guard page to trigger
> a restart of the translation for a given TB, but got hung up on
> the win32 implementation of the "signal handler".
>
> Nevertheless, just having the page without doing anything
On Sat, Sep 19, 2015 at 4:31 PM, skunk wrote:
> thank you peter, do you know if timothy has a github account?
> i'm too lazy to copy the 34 patches by hand from the mailing list...
The patches utility can do this for you off the list:
https://github.com/stefanha/qemu-patches
This will catch any overflow of the buffer.
Add a native win32 alternative for alloc_code_gen_buffer;
remove the malloc alternative.
Signed-off-by: Richard Henderson
---
translate-all.c | 207
1 file changed, 117
Recent patchseries which I think ought to be a proper fix for this bug:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01388.html
It does need some more work to address review comments but it's sound in
principle.
--
You received this bug notification because you are a member of qemu-
By putting the prologue at the end, we risk overwriting the
prologue should our estimate of maximum TB size. Given the
two different placements of the call to tcg_prologue_init,
move the high water mark computation into tcg_prologue_init.
Signed-off-by: Richard Henderson
---
I started down the path toward using this guard page to trigger
a restart of the translation for a given TB, but got hung up on
the win32 implementation of the "signal handler".
Nevertheless, just having the page without doing anything more
than crashing if it gets touched might still be useful.
the above patch still applies with qemu 2.4, but then it fails to build
with the following error:
x86_64-pc-linux-gnu-gcc
-I/var/tmp/portage/app-emulation/qemu-2.4.0-r1/work/qemu-2.4.0/tcg
-I/var/tmp/portage/app-emulation/qemu-2.4.0-r1/work/qemu-2.4.0/tcg/i386
On 19 September 2015 at 22:02, Richard Henderson wrote:
> I'll note that the current worst-case estimate is way too big: 122kB.
Well, it's way too big because we have a bad worst-case:
a TB with lots of insns that generate a lot of TCG ops.
That pretty much never happens but
thank you peter, do you know if timothy has a github account?
i'm too lazy to copy the 34 patches by hand from the mailing list...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/955379
Title:
cmake
On Fri, Sep 18, 2015 at 04:30:12PM +1000, Gavin Shan wrote:
> This patchset bases on David Gibson's git tree:
> git://github.com/dgibson/qemu.git
> (branch: vfio). And it requires host kernel changes which is being reviewed
> this moment.
>
> https://patchwork.ozlabs.org/patch/519135/
>
Am 19.09.2015 um 08:30 schrieb Andreas Färber:
> Am 20.08.2015 um 23:54 schrieb Eduardo Habkost:
>> Machine class names should use the "-machine" suffix to allow
>> class-name-based machine class lookup to work. Rename the vexpress
>> machine classes using the MACHINE_TYPE_NAME macro.
>>
>> Cc:
Am 19.09.2015 um 08:23 schrieb Andreas Färber:
> Am 20.08.2015 um 23:54 schrieb Eduardo Habkost:
>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> index 5ba4b80..af985f6 100644
>> --- a/hw/arm/virt.c
>> +++ b/hw/arm/virt.c
>> @@ -960,7 +960,6 @@ static void virt_class_init(ObjectClass *oc, void
Because spapr_phb_check_vfio_group() now safely returns an error on a non
VFIO papr host bridge, it becomes safe to call
spapr_phb_vfio_eeh_configure() on any host bridge, not just the special
VFIO host bridges.
So fold its code into rtas_ibm_configure_pe(), instead of only calling it
via a class
At the moment spapr_phb_check_vfio_group() assumes it is always passed an
instance of "spapr-pci-vfio-host-bridge", which it is. However we want to
unify more of the code with core PAPR PCI, so this changes it to be safe on
any "spapr-pci-host-bridge" instance. For now we just return an error if
I've already posted a patch series that allows VFIO devices on
spapr-pci-host-bridge instead of just on spapr-pci-vfio-host-bridge.
However. it still didn't allow EEH on VFIO devices on the "normal"
host bridge.
This series addresses that, making a number of cleanup along the way.
Because of
This switches all EEH on VFIO operations in spapr_pci_vfio() from the old
broken vfio_container_ioctl() interface to the new vfio_eeh_op() interface.
In order to obtain the VFIOGroup * handle that vfio_eeh_op() requires, we
add a helper function spapr_phb_check_vfio_group(). It gets the group
Am 04.09.2015 um 20:37 schrieb Eduardo Habkost:
> Convert all machines to use DEFINE_MACHINE instead of QEMUMachine
> automatically using a script.
>
> Cc: Richard Henderson
> Cc: Peter Maydell
> Cc: Li Guang
> Cc: Antony
PAPR has a concept of Partitionable Endpoints (PEs) on PCI, which are
groups of devices that can't be isolated from each other, which is used in
the Enhanced Error Handling (EEH) interface.
At the moment, we don't model PEs in our PAPR host bridge implementation.
We get away with it because
Because spapr_phb_check_vfio_group() now safely returns an error on a non
VFIO papr host bridge, it becomes safe to call
spapr_phb_vfio_eeh_get_state() on any host bridge, not just the special
VFIO host bridges.
So fold its code into rtas_ibm_read_slot_reset_state2(), instead of only
calling it
vfio_container_ioctl() was a bad interface that bypassed abstraction
boundaries, had semantics that sat uneasily with its name, and was unsafe
in many realistic circumstances. Now that spapr-pci-vfio-host-bridge has
been folded into spapr-pci-host-bridge, there are no more users, so remove
it.
The Enhanced Error Handling (EEH) interface in PAPR operates on units of a
Partitionable Endpoint (PE). For VFIO devices, the PE boundaries the guest
sees must match the PE (i.e. IOMMU group) boundaries on the host. To
implement this VFIO needs to expose to EEH the IOMMU group each VFIO device
Because spapr_phb_check_vfio_group() now safely returns an error on a non
VFIO papr host bridge, it becomes safe to call
spapr_phb_vfio_eeh_reset() on any host bridge, not just the special
VFIO host bridges.
So fold its code into rtas_ibm_set_slot_reset(), instead of only calling it
via a class
Because spapr_phb_check_vfio_group() now safely returns an error on a non
VFIO papr host bridge, it becomes safe to call
spapr_phb_vfio_eeh_reenable() on any host bridge, not just the special
VFIO host bridges. Thus the same is true of spapr_phb_vfio_reset() which
does nothing but call
Am 19.09.2015 um 10:13 schrieb Andreas Färber:
> Am 04.09.2015 um 20:37 schrieb Eduardo Habkost:
>> Convert all machines to use DEFINE_MACHINE instead of QEMUMachine
>> automatically using a script.
>>
>> Cc: Richard Henderson
>> Cc: Peter Maydell
>>
Am 20.08.2015 um 23:54 schrieb Eduardo Habkost:
> Machine class names should use the "-machine" suffix to allow
> class-name-based machine class lookup to work. Rename the vexpress
> machine classes using the MACHINE_TYPE_NAME macro.
>
> Cc: Peter Maydell
>
Am 19.09.2015 um 10:27 schrieb Andreas Färber:
> Am 19.09.2015 um 10:13 schrieb Andreas Färber:
>> Am 04.09.2015 um 20:37 schrieb Eduardo Habkost:
>>> Convert all machines to use DEFINE_MACHINE instead of QEMUMachine
>>> automatically using a script.
>>>
>>> Cc: Richard Henderson
Am 19.09.2015 um 04:49 schrieb Mike Ladouceur:
> I tried from Ubuntu in Virtualbox and this is the error I now get and it
> appears to be similar to the error from Cygwin. Configure seems to run
> fine. Make fails. I'm officially lost.
>
> ./configure --cross-prefix=x86_64-w64-mingw32
> (...)
>
The pseries machine type has two variants of the PCI Host Bridge device:
spapr-pci-host-bridge and spapr-pci-vfio-host-bridge. Originally, only the
latter could support VFIO devices, but we've now extended the VFIO code so
that they both can.
However, it's still only spapr-pci-vfio-host-bridge
Now that the regular spapr-pci-host-bridge can handle EEH, the only thing
that the spapr-pci-vfio-host-bridge variant does differently is to
automatically size its DMA window based on what the host IOMMU can do.
That's not actually that useful, since the default window used by the
regular host
Now that spapr-pci-vfio-host-bridge is reduced to just a stub, there is
only one implementation of the finish_realize hook in sPAPRPHBClass. So,
we can fold that implementation into its (single) caller, and remove the
hook. That's the last thing left in sPAPRPHBClass, so that can go away as
Am 20.08.2015 um 23:54 schrieb Eduardo Habkost:
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 5ba4b80..af985f6 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -960,7 +960,6 @@ static void virt_class_init(ObjectClass *oc, void *data)
> {
> MachineClass *mc = MACHINE_CLASS(oc);
Because spapr_phb_check_vfio_group() now safely returns an error on a non
VFIO papr host bridge, it becomes safe to call
spapr_phb_vfio_eeh_set_option() on any host bridge, not just the special
VFIO host bridges.
So fold its code into rtas_ibm_set_eeh_option(), instead of only calling it
via a
At present the code handling IBM's Enhanced Error Handling (EEH) interface
on VFIO devices operates by bypassing the usual VFIO logic with
vfio_container_ioctl(). That's a poorly designed interface with unclear
semantics about exactly what can be operated on.
As a first step to cleaning that up,
On Wed, Sep 16, 2015 at 4:01 PM, Michael S. Tsirkin wrote:
> Let's not do this.
> It's probably time to replace vhost_call with an ops struct of functions.
> This will solve this in a clean way.
done
--
Marc-André Lureau
On Wed, Sep 16, 2015 at 4:08 PM, Michael S. Tsirkin wrote:
> supports
>
ok
>> VHOST_USER_PROTOCOL_F_LOG_SHMFD.
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> hw/virtio/vhost-user.c | 16 ++--
>> hw/virtio/vhost.c | 5 +++--
>>
From: "Michael S. Tsirkin"
Support a separate bitmask for vhost-user protocol features,
and messages to get/set protocol features.
Invoke them at init.
No features are defined yet.
Signed-off-by: Michael S. Tsirkin
---
docs/specs/vhost-user.txt | 37
From: Marc-André Lureau
Implement memfd_create() fallback if not available in system libc.
memfd_create() is still not included in glibc today, atlhough it's been
available since Linux 3.17 in Oct 2014.
memfd has numerous advantages over traditional shm/mmap for ipc
From: "Michael S. Tsirkin"
Data is empty for now, but do make sure master
sets the new feature bit flag.
Signed-off-by: Michael S. Tsirkin
---
tests/vhost-user-test.c | 19 +++
1 file changed, 19 insertions(+)
diff --git
From: Marc-André Lureau
Hi,
The following series implement shareable log for vhost-user to support
memory tracking during live migration. On qemu-side, the solution is
fairly straightfoward since vhost already supports the dirty log, only
vhost-user couldn't access
From: Marc-André Lureau
This test checks that the log fd is given to the migration source, and
mark dirty pages during migration.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 162
From: Thibaut Collet
Some vhost user backends are able to support live migration.
To provide this service the following features must be added:
1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev
backend is vhost-user.
2. Provide a nop receive
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/specs/vhost-user.txt | 42 ++
1 file changed, 42 insertions(+)
diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
From: Marc-André Lureau
Add a new macro to make the qemu command line with other
values of memory size, and specific chardev id.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 14 +-
1 file changed, 9
From: Marc-André Lureau
Check that backend source and destination do not have simultaneous
ownership during migration.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 38 ++
1 file
Hi
On Wed, Sep 16, 2015 at 4:06 PM, Michael S. Tsirkin wrote:
> Shouldn't this be limited to when the appropriate feature flag
> is negotiated?
That's doable, I'll add it after the feature protocol is added (not in
this commit)
--
Marc-André Lureau
On 21 October 2014 at 13:14, Pavel Dovgalyuk wrote:
> Sometimes page faults happen during the translation of the target
> instructions.
> To avoid the faults in the middle of the TB we have to stop translation at
> the end of the page. Current implementation of ARM
From: Marc-André Lureau
Add qemu_memfd_alloc/free() helpers.
The function helps to allocate and seal a memfd, and implements an
open/unlink/mmap fallback for system that do not support memfd.
Signed-off-by: Marc-André Lureau
---
From: "Michael S. Tsirkin"
translate at the outset, have rest of code use vhost-user features
exclusively.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/vhost-user.c | 87 ++
1 file changed, 46 insertions(+),
From: Marc-André Lureau
If the backend is of type VHOST_BACKEND_TYPE_USER, allocate
shareable memory. Next patch will only allocate when the backend
has the required feature.
Note: vhost_log_get() can use a global "vhost_log" that can be shared by
several vhost
From: Marc-André Lureau
The translation is no longer needed.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-user.c | 36
1 file changed, 36 deletions(-)
diff --git a/hw/virtio/vhost-user.c
From: Marc-André Lureau
In the coming patches, a test will use several servers
simultaneously. Wrap the server in a struct, out of the global scope.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 146
Greg Kurz writes:
> In a cross-endian setup, the virtio-9p device has state in @device_endian. It
> must be migrated.
>
> Signed-off-by: Greg Kurz
With 9p mounted, we don't support qemu migration. We still have
migration blocker added in
Greg Kurz writes:
> In a cross-endian setup, the virtio-9p device has state in @device_endian. It
> must be migrated.
>
> Signed-off-by: Greg Kurz
With 9p mounted, we don't support qemu migration. We have
migration blocker added in
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 551a664..68badf9 100644
---
From: Marc-André Lureau
Replace the generic vhost_call() by specific functions for each
function call to help with type safety and changing arguments.
Signed-off-by: Marc-André Lureau
---
hw/net/vhost_net.c| 12 +-
From: Marc-André Lureau
This function is a precondition for most vhost-user tests.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git
From: Thibaut Collet
A new vhost user message is added to allow QEMU to ask to vhost user backend to
broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE
capability.
This new message is sent only if the backend supports the new
From: Marc-André Lureau
Do not allocate a shared log if the backend doesn't support it.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-user.c| 9 +
hw/virtio/vhost.c | 15 ++-
The script used for converting from QEMUMachine had used one
DEFINE_MACHINE() per machine registered. In cases where multiple
machines are registered from one source file, avoid the excessive
generation of module init functions by reverting this unrolling.
Signed-off-by: Andreas Färber
On 19 September 2015 at 00:43, Kevin O'Connor wrote:
> On x86 the firmware can't use acpi (nor device tree) to find fw_cfg
> because fw_cfg is what is used to transfer acpi to the firmware. So,
> the firmware just hard codes the address. As a "sanity check", the
> firmware
From: Marc-André Lureau
Check if memfd_create() is part of system libc.
Signed-off-by: Marc-André Lureau
---
configure | 19 +++
1 file changed, 19 insertions(+)
diff --git a/configure b/configure
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index cd3af16..81209ba 100644
--- a/hw/virtio/vhost.c
+++
From: Marc-André Lureau
Send the shm for the dirty pages logging if the backend supports
VHOST_USER_PROTOCOL_F_LOG_SHMFD.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-backend.c | 3 ++-
hw/virtio/vhost-user.c
From: Marc-André Lureau
Replace error_report() and use tracing instead. It's not an error to get
a connection or a disconnection, so silence this and trace it instead.
Signed-off-by: Marc-André Lureau
---
net/vhost-user.c | 5 +++--
When the memory we're trying to translate code from is not executable we have
to turn this into a guest fault. In order to report the correct PC for this
fault, and to make sure it is not reported until after any other possible
faults for instructions earlier in execution, we must terminate TBs at
Good question, any news please?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/902413
Title:
qemu-i386-user on ARM host: wine hangs/spins when trying to run
anything
Status in QEMU:
New
Bug
From: Eduardo Habkost
Machine class names should use the "-machine" suffix to allow
class-name-based machine class lookup to work. Rename the vexpress
machine classes using the MACHINE_TYPE_NAME macro.
Signed-off-by: Eduardo Habkost
Reviewed-by: David
From: Eduardo Habkost
Machine class names should use the "-machine" suffix to allow
class-name-based machine class lookup to work. Rename the s390-virtio
machine class using the MACHINE_TYPE_NAME macro.
Signed-off-by: Eduardo Habkost
Reviewed-by: David
From: Eduardo Habkost
Convert all machines to use DEFINE_MACHINE() instead of QEMUMachine
automatically using a script.
Signed-off-by: Eduardo Habkost
[AF: Style cleanups, convert imx25_pdk machine]
Signed-off-by: Andreas Färber
---
From: Eduardo Habkost
The code is checking smp_cpus against EXYNOS4210_NCPUS, not against
max_cpus, so use EXYNOS4210_NCPUS in the error message for consistency.
Signed-off-by: Eduardo Habkost
Signed-off-by: Andreas Färber
---
From: Eduardo Habkost
It will result in exactly the same class name, but it will make the code
consistent with the other classes.
Signed-off-by: Eduardo Habkost
Reviewed-by: David Gibson
Signed-off-by: Andreas Färber
From: Eduardo Habkost
We don't need a QEMUMachine array to query max_cpus, if we can get the
corresponding MachineClass.
Signed-off-by: Eduardo Habkost
Signed-off-by: Andreas Färber
---
hw/arm/exynos4_boards.c | 4 +++-
1 file
On 14 September 2015 at 17:12, Programmingkid wrote:
>
> On Sep 14, 2015, at 11:49 AM, Peter Maydell wrote:
>
>> Oops, I meant to cc Andreas on this but got the address wrong.
>>
>> -- PMM
>>
>> On 14 September 2015 at 16:43, Peter Maydell
>>
On Sat, Sep 19, 2015 at 10:48:37AM +0100, Peter Maydell wrote:
> On 19 September 2015 at 00:43, Kevin O'Connor wrote:
> > On x86 the firmware can't use acpi (nor device tree) to find fw_cfg
> > because fw_cfg is what is used to transfer acpi to the firmware. So,
> > the
This prepares for dropping machine_init(), now that QEMUMachine is gone.
Signed-off-by: Andreas Färber
---
hw/arm/exynos4_boards.c | 2 +-
hw/arm/gumstix.c| 2 +-
hw/arm/highbank.c | 2 +-
hw/arm/nseries.c| 2 +-
hw/arm/omap_sx1.c | 2 +-
This untangles QemuOpts from machine_init(), which is to be dropped.
Signed-off-by: Andreas Färber
---
fsdev/qemu-fsdev-opts.c | 2 +-
hw/acpi/core.c | 2 +-
hw/smbios/smbios.c | 2 +-
include/qemu/module.h | 2 ++
ui/spice-core.c | 2 +-
ui/vnc.c
MODULE_INIT_MACHINE was used to register QEMUMachines. Now that those
have been converted to QOM we no longer need this separate registration.
For registering QemuOpts config_init() has been introduced.
Signed-off-by: Andreas Färber
---
include/qemu/module.h | 2 --
vl.c
On Sat, 19 Sep 2015 01:10:46 +0200
Laszlo Ersek wrote:
> On 09/18/15 22:24, Marc Marí wrote:
> > On Fri, 18 Sep 2015 22:16:46 +0200
> > Laszlo Ersek wrote:
> >
> >> On 09/18/15 10:58, Marc Marí wrote:
> >>> Enable the fw_cfg DMA interface for the ARM virt
Hello,
I have two minor comments.
On Sat, Sep 19, 2015 at 3:06 PM, Peter Maydell wrote:
> When the memory we're trying to translate code from is not executable we have
> to turn this into a guest fault. In order to report the correct PC for this
> fault, and to make
Hello boyos,
I got myself an Rpi2 recently and have been reading up on qemu.
Does this mean there's a problem booting x86 images on Arm or just the
ones from that particular source?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
This option is useful for testing, nothing more.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1469342
Title:
qemu-i386 pentium3/athlon incorrect instruction set
Status in QEMU:
Won't Fix
Bug
From: "Edgar E. Iglesias"
Introduce ARMMMUFaultInfo to propagate MMU Fault information
across the MMU translation code path. This is in preparation for
adding State-2 translation.
No functional changes.
Signed-off-by: Edgar E. Iglesias
---
From: "Edgar E. Iglesias"
Add support for applying S2 translation to S1 page-table walks.
Signed-off-by: Edgar E. Iglesias
---
target-arm/helper.c| 50 --
target-arm/op_helper.c | 4 ++--
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
target-arm/helper.c | 48 +---
1 file changed, 45 insertions(+), 3 deletions(-)
diff --git a/target-arm/helper.c
From: "Edgar E. Iglesias"
Signed-off-by: Edgar E. Iglesias
---
target-arm/op_helper.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
index d4715f4..2ccd1c9
On Sat, Sep 19, 2015 at 07:15:19AM -0700, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Hi,
>
> Another round of patches towards EL2 support. This one adds partial
> support for 2-stage MMU for AArch64. I've marked it RFC because I
> expect a few
From: Pavel Fedin
Expansion of [*] suffix is very slow because index expansion is done using
trial and error strategy, starting every time from zero and retrying with
the next index until insertion succeeds. With large number of already added
properties this process takes
From: Eduardo Habkost
The MachineClass::name field won't be ever be used on TYPE_VEXPRESS, as
it is an abstract class and the machine class lookup code explicitly
skips abstract classes. We can remove it to make the code simpler.
Signed-off-by: Eduardo Habkost
From: Eduardo Habkost
The macro will be useful to ensure the machine class names follow the
right format to make machine class lookup by class name work correctly.
Signed-off-by: Eduardo Habkost
Reviewed-by: Marcel Apfelbaum
From: Markus Armbruster
When a function returns a null pointer on error and only on error, you
can do
if (!foo(foos, errp)) {
... handle error ...
}
instead of the more cumbersome
Error *err = NULL;
if (!foo(foos, )) {
error_propagate(errp,
From: Markus Armbruster
The argument for an Error **errp parameter must point to a null
pointer. If it doesn't, and an error happens, error_set() fails its
assertion.
Instead of
foo(foos, errp);
bar(bars, errp);
you need to do something like
Error *err = NULL;
From: Eduardo Habkost
Machine class names should use the "-machine" suffix to allow
class-name-based machine class lookup to work. Rename the arm virt
machine class using the MACHINE_TYPE_NAME macro.
Signed-off-by: Eduardo Habkost
Reviewed-by: David
From: Eduardo Habkost
Now all TYPE_MACHINE subclasses use MACHINE_TYPE_NAME to generate the
class name. So instead of requiring each subclass to set
MachineClass::name manually, we can now set it automatically at the
TYPE_MACHINE class_base_init() function.
Signed-off-by:
From: Eduardo Habkost
The macro will allow easy registration of a TYPE_MACHINE subclass, using
only the machine name and a MachineClass initialization function as
parameter.
Signed-off-by: Eduardo Habkost
Signed-off-by: Andreas Färber
From: Eduardo Habkost
This will make the code follow the same pattern used for other machines,
and will make it easier to automatically convert the code to be
QOM-based.
Signed-off-by: Eduardo Habkost
Signed-off-by: Andreas Färber
From: Eduardo Habkost
Coding style change only.
Signed-off-by: Eduardo Habkost
Signed-off-by: Andreas Färber
---
hw/ppc/mac_oldworld.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/mac_oldworld.c
Am 19.09.2015 um 16:43 schrieb Andreas Färber:
> From: Eduardo Habkost
>
> Coding style change only.
>
> Signed-off-by: Eduardo Habkost
> Signed-off-by: Andreas Färber
> ---
> hw/ppc/mac_oldworld.c | 3 ++-
> 1 file changed, 2
On Fri, Sep 18, 2015 at 05:35:07PM +0100, Peter Maydell wrote:
> On 18 September 2015 at 17:15, Sergey Fedorov wrote:
> > On 18.09.2015 18:57, Sergey Fedorov wrote:
> >> On 18.09.2015 17:11, Peter Maydell wrote:
> >>> On 18 September 2015 at 15:08, Peter Maydell
1 - 100 of 122 matches
Mail list logo