Re: [Qemu-devel] [PATCH 3/7] device-introspect-test: New, covering device introspection

2015-09-21 Thread Markus Armbruster
Eric Blake writes: > On 09/18/2015 06:00 AM, Markus Armbruster wrote: >> The test doesn't check the output makes any sense, only that QEMU > > Reads slightly better as: > s/check/check that/ Okay. >> survives. Useful since we've had an astounding number of crash bugs >>

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-21 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Sep 18, 2015 at 02:00:38PM +0200, Markus Armbruster wrote: >> Several devices don't survive object_unref(object_new(T)): they crash >> or hang during cleanup, or they leave dangling pointers behind. >> >> This breaks at least

Re: [Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends

2015-09-21 Thread Markus Armbruster
Eric Blake writes: > On 09/18/2015 06:00 AM, Markus Armbruster wrote: >> New convenience function hmp() to facilitate use of >> human-monitor-command in tests. Use it to simplify its existing uses. >> >> To blend into existing libqtest code, also add qtest_hmpv() and >>

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-21 Thread Thomas Huth
On 21/09/15 04:10, David Gibson wrote: > On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrote: >> On Thu, 17 Sep 2015 10:49:41 +0200 >> Thomas Huth wrote: >> >>> The PAPR interface defines a hypercall to pass high-quality >>> hardware generated random numbers to guests.

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-21 Thread Markus Armbruster
Eric Blake writes: > On 09/18/2015 06:00 AM, Markus Armbruster wrote: >> Several devices don't survive object_unref(object_new(T)): they crash >> or hang during cleanup, or they leave dangling pointers behind. >> > >> Unfortunately, I can't fix the problems in these devices

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-21 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote: >> On 18/09/15 14:00, Markus Armbruster wrote: >> > Several devices don't survive object_unref(object_new(T)): they crash >> > or hang during cleanup, or they leave dangling pointers

Re: [Qemu-devel] [PATCH 7/7] tests: Simplify how qom-test is run

2015-09-21 Thread Markus Armbruster
Andreas Färber writes: > Am 18.09.2015 um 16:24 schrieb Markus Armbruster: >> Andreas Färber writes: >>> Am 18.09.2015 um 14:00 schrieb Markus Armbruster: Add it to check-qtest-generic-y instead of check-qtest-$(target)-y for every target.

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: test that snapshots move the throttling configuration

2015-09-21 Thread Alberto Garcia
On Fri 18 Sep 2015 05:54:36 PM CEST, Max Reitz wrote: >> create mode 100644 tests/qemu-iotests/096 >> create mode 100644 tests/qemu-iotests/096.out > > Looks good, I'd just like to throw in that 096 is in use by my > looks-dead-but-actually-is-not and >

Re: [Qemu-devel] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats

2015-09-21 Thread Kevin Wolf
Am 18.09.2015 um 18:59 hat Eric Blake geschrieben: > On 09/18/2015 09:22 AM, Max Reitz wrote: > > BlockAcctStats contains statistics about the data transferred from and > > to the device; wr_highest_sector does not fit in with the rest. > > > > Furthermore, those statistics are supposed to be

[Qemu-devel] [PULL 04/26] qapi: New QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
The visitor will help keeping the code generation code simple and reasonably separated from QAPISchema details. Signed-off-by: Markus Armbruster Message-Id: <1442401589-24189-5-git-send-email-arm...@redhat.com> Reviewed-by: Daniel P. Berrange Reviewed-by:

[Qemu-devel] [PULL 01/26] qapi: Rename class QAPISchema to QAPISchemaParser

2015-09-21 Thread Markus Armbruster
I want to name a new class QAPISchema. While there, make it a new-style class. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-2-git-send-email-arm...@redhat.com>

[Qemu-devel] [PULL 03/26] qapi: QAPISchema code generation helper methods

2015-09-21 Thread Markus Armbruster
New methods c_name(), c_type(), c_null(), json_type(), alternate_qtype(). Signed-off-by: Markus Armbruster Message-Id: <1442401589-24189-4-git-send-email-arm...@redhat.com> Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake ---

[Qemu-devel] [PULL 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
The old code prints the result of parsing (list of expression dictionaries), and partial results of semantic analysis (list of enum dictionaries, list of struct dictionaries). The new code prints a trace of a schema visit, i.e. what the back-ends are going to use. Built-in and array types are

[Qemu-devel] [PULL 09/26] qapi: De-duplicate enum code generation

2015-09-21 Thread Markus Armbruster
Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but that's no excuse. Move the helpers from qapi-types.py to qapi.py, and replace the duplicates in qapi-event.py. The generated event enumeration type's lookup table becomes const-correct (see commit 2e4450f), and uses explicit

[Qemu-devel] [PULL 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
Generate just 'FOO' instead of 'struct FOO' when possible. Drop helper functions that are now unused. Make pep8 and pylint reasonably happy. Rename generate_FOO() functions to gen_FOO() for consistency. Use more consistent and sensible variable names. Consistently use c_ for mapping keys when

[Qemu-devel] [PULL 18/26] qapi-commands: De-duplicate output marshaling functions

2015-09-21 Thread Markus Armbruster
gen_marshal_output() uses its parameter name only for name of the generated function. Name it after the type being marshaled instead of its caller, and drop duplicates. Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of qmp_marshal_output_str() in qemu-system-*.

[Qemu-devel] [PULL 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-21 Thread Markus Armbruster
Fixes flat unions to get the base's base members. Test case is from commit 2fc0043, in qapi-schema-test.json: { 'union': 'UserDefFlatUnion', 'base': 'UserDefUnionBase', 'discriminator': 'enum1', 'data': { 'value1' : 'UserDefA', 'value2' : 'UserDefB',

[Qemu-devel] [PULL 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-09-21 Thread Markus Armbruster
Fixes flat unions to visit the base's base members (the previous commit merely added them to the struct). Same test case. Patch's effect on visit_type_UserDefFlatUnion(): static void visit_type_UserDefFlatUnion_fields(Visitor *m, UserDefFlatUnion **obj, Error **errp) { Error

[Qemu-devel] [PULL 24/26] qapi: Pseudo-type '**' is now unused, drop it

2015-09-21 Thread Markus Armbruster
'gen': false needs to stay for now, because netdev_add is still using it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-25-git-send-email-arm...@redhat.com> ---

Re: [Qemu-devel] [PATCH v18 00/21] Deterministic replay core

2015-09-21 Thread Pavel Dovgaluk
Hi! Paolo, have you reviewed these patches? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Thursday, September 17, 2015 7:23 PM > To: qemu-devel@nongnu.org > Cc: edgar.igles...@xilinx.com; peter.mayd...@linaro.org; >

[Qemu-devel] [PULL 12/26] qapi: Replace dirty is_c_ptr() by method c_null()

2015-09-21 Thread Markus Armbruster
is_c_ptr() looks whether the end of the C text for the type looks like a pointer. Works, but is fragile. We now have a better tool: use QAPISchemaType method c_null(). The initializers for non-pointers become prettier: 0, false or the enumeration constant with the value 0 instead of {0}.

[Qemu-devel] [PULL 08/26] qapi-commands: Convert to QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
Output unchanged apart from reordering and white-space. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1442401589-24189-9-git-send-email-arm...@redhat.com> Reviewed-by: Daniel P. Berrange ---

[Qemu-devel] [PULL 00/26] qapi: QMP introspection

2015-09-21 Thread Markus Armbruster
The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' into staging (2015-09-19 15:59:52 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git

[Qemu-devel] [PULL 20/26] qapi: Make output visitor return qnull() instead of NULL

2015-09-21 Thread Markus Armbruster
Before commit 1d10b44, it crashed. Since then, it returns NULL, with a FIXME comment. The FIXME is valid: code that assumes QObject * can't be null exists. I'm not aware of a way to feed this problematic return value to code that actually chokes on null in the current code, but the next few

[Qemu-devel] [PULL 23/26] qapi-schema: Fix up misleading specification of netdev_add

2015-09-21 Thread Markus Armbruster
It doesn't take a 'props' argument, let alone one in the format "NAME=VALUE,..." The bogus arguments specification doesn't matter due to 'gen': false. Clean it up to be incomplete rather than wrong, and document the incompleteness. While there, improve netdev_add usage example in the manual: add

[Qemu-devel] [PULL 25/26] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-21 Thread Markus Armbruster
qapi/introspect.json defines the introspection schema. It's designed for QMP introspection, but should do for similar uses, such as QGA. The introspection schema does not reflect all the rules and restrictions that apply to QAPI schemata. A valid QAPI schema has an introspection value

[Qemu-devel] [PULL 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-21 Thread Markus Armbruster
The QAPI code generators work with a syntax tree (nested dictionaries) plus a few symbol tables (also dictionaries) on the side. They have clearly outgrown these simple data structures. There's lots of rummaging around in dictionaries, and information is recomputed on the fly. For the work I'm

[Qemu-devel] [PULL 15/26] qapi-commands: Rearrange code

2015-09-21 Thread Markus Armbruster
Rename gen_marshal_input() to gen_marshal(), because the generated function marshals both arguments and results. Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and move the other variable declarations there, too. Rename gen_visitor_input_block() to gen_marshal_input_visit(),

[Qemu-devel] [PULL 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO()

2015-09-21 Thread Markus Armbruster
These functions marshal both input and output. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-17-git-send-email-arm...@redhat.com> --- docs/qapi-code-gen.txt

[Qemu-devel] [PULL 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add

2015-09-21 Thread Markus Armbruster
With the previous commit, the generated marshalers just work, and save us a bit of handwritten code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id:

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Thibaut Collet
On Sat, Sep 19, 2015 at 12:12 PM, wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Peter Lieven
Am 07.09.2015 um 21:14 schrieb Paolo Bonzini: On 07/09/2015 21:11, Peter Lieven wrote: It helps, but I have a small issue when my backport of the patch is applied. I launch qemu witch a cmdline like this to probe for enforcable CPU types. echo quit | qemu -enable-kvm -monitor stdio

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-21 Thread Greg Kurz
On Mon, 21 Sep 2015 12:10:00 +1000 David Gibson wrote: > On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrote: > > On Thu, 17 Sep 2015 10:49:41 +0200 > > Thomas Huth wrote: > > > > > The PAPR interface defines a hypercall to pass high-quality

[Qemu-devel] [PULL 11/26] qapi-event: Convert to QAPISchemaVisitor, fixing data with base

2015-09-21 Thread Markus Armbruster
Fixes events whose data is struct with base to include the struct's base members. Test case is qapi-schema-test.json's event __org.qemu_x-command: { 'event': '__ORG.QEMU_X-EVENT', 'data': '__org.qemu_x-Struct' } { 'struct': '__org.qemu_x-Struct', 'base': '__org.qemu_x-Base',

[Qemu-devel] [PULL 26/26] qapi-introspect: Hide type names

2015-09-21 Thread Markus Armbruster
To eliminate the temptation for clients to look up types by name (which are not ABI), replace all type names by meaningless strings. Reduces output of query-schema by 13 out of 85KiB. As a debugging aid, provide option -u to suppress the hiding. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 14/26] qapi-visit: Rearrange code a bit

2015-09-21 Thread Markus Armbruster
Move gen_visit_decl() to a better place. Inline generate_visit_struct_body(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-15-git-send-email-arm...@redhat.com>

[Qemu-devel] [PULL 10/26] qapi-event: Eliminate global variable event_enum_value

2015-09-21 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-11-git-send-email-arm...@redhat.com> --- scripts/qapi-event.py | 3 +-- 1 file changed, 1 insertion(+), 2

[Qemu-devel] [PULL 17/26] qapi: De-duplicate parameter list generation

2015-09-21 Thread Markus Armbruster
Generated qapi-event.[ch] lose line breaks. No change otherwise. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-18-git-send-email-arm...@redhat.com> ---

[Qemu-devel] [PULL 19/26] qapi: Improve built-in type documentation

2015-09-21 Thread Markus Armbruster
Clarify how they map to JSON. Add how they map to C. Fix the reference to StringInputVisitor. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id:

[Qemu-devel] [PULL 21/26] qapi: Introduce a first class 'any' type

2015-09-21 Thread Markus Armbruster
It's first class, because unlike '**', it actually works, i.e. doesn't require 'gen': false. '**' will go away next. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- docs/qapi-code-gen.txt

Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init()

2015-09-21 Thread Christian Borntraeger
Am 19.09.2015 um 17:36 schrieb Andreas Färber: > Here, machine_init() is being misused to initialize global variables. > Being all local, it's safe to use the slightly earlier type_init(). > > This prepares for dropping machine_init(). > > Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v*add and v*sub instructions

2015-09-21 Thread Chen Gang
On 2015年09月19日 10:34, Richard Henderson wrote: > > There's a trick for this that's more efficient for 4 or more elements > per vector (i.e. good for v2 and v1, but not v4): > >a + b = (a & 0x7f7f7f7f) + (b & 0x7f7f7f7f)) ^ ((a ^ b) & 0x80808080) > >a - b = (a | 0x80808080) - (b &

Re: [Qemu-devel] [PATCH v6 06/14] blockjob: Add .commit and .abort block job actions

2015-09-21 Thread John Snow
On 09/15/2015 02:11 AM, Fam Zheng wrote: > Reviewed-by: Max Reitz > Signed-off-by: Fam Zheng > --- > include/block/blockjob.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/include/block/blockjob.h b/include/block/blockjob.h >

[Qemu-devel] [PATCH v2] target-tilegx: Implement v1multu instruction

2015-09-21 Thread gang . chen . 5i5j
From: Chen Gang Only according to v1shrs implementation. Signed-off-by: Chen Gang Reviewed-by: Richard Henderson --- target-tilegx/helper.h | 2 ++ target-tilegx/simd_helper.c | 13 +

Re: [Qemu-devel] [PATCH v2] target-tilegx: Implement v1multu instruction

2015-09-21 Thread Chen Gang
The related code are changed, so this patch has to be reconstructed. Thanks On 9/22/15 06:26, gang.chen.5...@gmail.com wrote: > From: Chen Gang > > Only according to v1shrs implementation. > > Signed-off-by: Chen Gang > Reviewed-by: Richard

Re: [Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2015-09-21 Thread Marina Kovalevna
Thanks for looking into it, Laszlo. I've already tried dosbox and had no idea qemu was impractical. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't boot i386

Re: [Qemu-devel] [PATCH v6 09/14] block: Add block job transactions

2015-09-21 Thread Fam Zheng
On Mon, 09/21 19:23, John Snow wrote: > > void block_job_completed(BlockJob *job, int ret) > > { > > BlockDriverState *bs = job->bs; > > @@ -98,8 +191,13 @@ void block_job_completed(BlockJob *job, int ret) > > assert(!job->completed); > > job->completed = true; > > job->ret =

[Qemu-devel] [PATCH v7 06/14] blockjob: Add .commit and .abort block job actions

2015-09-21 Thread Fam Zheng
Reviewed-by: Max Reitz Reviewed-by: John Snow Signed-off-by: Fam Zheng --- include/block/blockjob.h | 20 1 file changed, 20 insertions(+) diff --git a/include/block/blockjob.h b/include/block/blockjob.h index

[Qemu-devel] [RFC PATCH v0 1/2] spapr: Allocate HTAB from machine init

2015-09-21 Thread Bharata B Rao
Allocate HTAB from ppc_spapr_init() so that we can abort the guest if requested HTAB size is't allocated by the host. However retain the htab reset call in spapr_reset_htab() so that HTAB gets reset (and not allocated) during machine reset. Signed-off-by: Bharata B Rao

[Qemu-devel] [RFC PATCH v0 2/2] spapr: Abort when HTAB of requested size isn't allocated

2015-09-21 Thread Bharata B Rao
Terminate the guest when HTAB of requested size isn't allocated by the host. When memory hotplug is attempted on a guest that has booted with less than requested HTAB size, the guest kernel will not be able to gracefully fail the hotplug request. This patch will ensure that we never end up in a

Re: [Qemu-devel] [PATCH v2] target-tilegx: Implement v*add and v*sub instructions

2015-09-21 Thread Richard Henderson
On 09/21/2015 05:45 PM, Chen Gang wrote: Oh, v1sub and v2sub look incorrect, need use ^b instead of ^~b. They're incorrect, but it's not ~b. Look back and the equation I gave you. r~

[Qemu-devel] [PATCH v7 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-21 Thread Fam Zheng
This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/backup.c | 27 +-- 1 file changed, 17 insertions(+), 10

[Qemu-devel] [RFC PATCH v0 0/2] spapr: Abort when HTAB size requirement can't be met

2015-09-21 Thread Bharata B Rao
HTAB size is a factor of maximum memory size that is specified by maxmem= command line option. In cases where there is shortage of host memory, host will not be able to allocate contiguous memory for guest HTAB and will instead allocate a smaller HTAB. This usually is not a problem but when user

Re: [Qemu-devel] [PULL 00/26] qapi: QMP introspection

2015-09-21 Thread Peter Maydell
On 21 September 2015 at 01:03, Markus Armbruster wrote: > The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' > into staging (2015-09-19 15:59:52 +0100) > > are available

[Qemu-devel] [PATCH 3/5] ide: add support for cancelable read requests

2015-09-21 Thread Peter Lieven
this patch adds a new aio readv compatible function which copies all data through a bounce buffer. The benefit is that these requests can be flagged as canceled to avoid guest memory corruption when a canceled request is completed by the backend at a later stage. If an IDE protocol wants to use

[Qemu-devel] [PATCH 4/5] ide/atapi: enable cancelable requests

2015-09-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 4 ++-- hw/ide/core.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index b209ed9..ab45495 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -141,7 +141,7 @@ static int

[Qemu-devel] [PATCH 2/5] ide/atapi: blk_aio_readv may return NULL

2015-09-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 9257e1c..b209ed9 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -371,6 +371,10 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque,

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Jan Kiszka
On 2015-09-18 23:11, Paolo Bonzini wrote: > On 18/09/2015 18:29, Claudio Fontana wrote: >> >> this is a first RFC for virtio-peer 0.1, which is still very much a work in >> progress: >> >> https://github.com/hw-claudio/virtio-peer/wiki >> >> It is also available as PDF there, but the text is

[Qemu-devel] [PATCH 4/9] apic_internal.h: fix formatting and drop unused consts

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by:

[Qemu-devel] [PATCH 1/9] apic_internal.h: make some apic_get_* functions externally visible

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Move apic_get_bit(), apic_set_bit() to apic_internal.h, make the apic_get_ppr symbol external. It's necessary to work with isr, tmr, irr and ppr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V.

[Qemu-devel] [PATCH 2/9] apic_internal.h: rename ESR_ILLEGAL_ADDRESS to APIC_ESR_ILLEGAL_ADDRESS

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added prefix APIC_ for determining the constant of a particular subsystem, improve the overall readability and match other constant names. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC:

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-21 Thread Peter Maydell
On 20 September 2015 at 22:34, Jonathan Neuschäfer wrote: > On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote: >> On 3 September 2015 at 06:27, Jonathan Neuschäfer >> wrote: >> > Currently, __target_cmsg_nxthdr compares a pointer derived

[Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-21 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple backup volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currenly VM Image on gluster volume is specified like this: file=gluster[+tcp]://server1[:port]/testvol/a.img Assuming we have

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Michael S. Tsirkin
On Fri, Sep 18, 2015 at 06:29:27PM +0200, Claudio Fontana wrote: > Hello, > > this is a first RFC for virtio-peer 0.1, which is still very much a work in > progress: > > https://github.com/hw-claudio/virtio-peer/wiki > > It is also available as PDF there, but the text is reproduced here for >

Re: [Qemu-devel] [PATCH v3 0/9] hmp command IO- and Local APIC dump state

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 12:57, Denis V. Lunev wrote: > Added the hmp command to query IO- and Local APIC registers state, > it can be very useful to identify problems related to the emulation devices. > > (qemu) info lapic > dumping local APIC state for CPU 0 > > LVT0 0x00010700 active-hi edge

[Qemu-devel] [PATCH 3/9] apic_internal.h: added more constants

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin These constants are needed for optimal access to bit fields local apic registers without magic numbers. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini

[Qemu-devel] [PATCH v3 0/9] hmp command IO- and Local APIC dump state

2015-09-21 Thread Denis V. Lunev
Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. (qemu) info lapic dumping local APIC state for CPU 0 LVT0 0x00010700 active-hi edge masked ExtINT (vec 0) LVT1 0x0400

[Qemu-devel] [PATCH 9/9] hmp: implemented io apic dump state for TCG

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added support emulator for the hmp command "info ioapic" Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber ---

[Qemu-devel] [PATCH 5/9] monitor: make monitor_fprintf and mon_get_cpu externally visible

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin monitor_fprintf and mon_get_cpu will be used in the target-specific monitor, so it is advisable to make it external. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini

Re: [Qemu-devel] [FIRST-PATCH] updated the negation STREQ to STRNEQ

2015-09-21 Thread Michal Privoznik
[You've got the wrong list. This is a libvirt patch and as such it should have been sent to the libvir-l...@redhat.com] On 19.09.2015 16:59, Lasya wrote: > Hi, > This is my first patch in QEMU. I have solved a bite-sized bug. I have > updated the !STREQ with STRNEQ in the following files.

Re: [Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

2015-09-21 Thread Paolo Bonzini
On 15/09/2015 20:45, Richard Henderson wrote: > Best guess, since I can't find any code that actually uses them. > Linux actively turns them off at boot... I've sent a kvm-unit-tests patch to test debug extensions. It shows that debug extensions work, but the following needs to be squashed in

[Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-09-21 Thread Peter Lieven
PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely. Signed-off-by: Peter

[Qemu-devel] [PATCH 6/9] hmp: added local apic dump state

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. (qemu) info lapic dumping local APIC state for CPU 0 LVT0 0x00010700 active-hi edge masked

[Qemu-devel] [PATCH 8/9] hmp: added io apic dump state

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (qemu) info ioapic ioapic id=0x00 sel=0x2e (redir[15]) pin 0

[Qemu-devel] [PATCH 7/9] ioapic_internal.h: added more constants

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber

Re: [Qemu-devel] [FIRST-PATCH] updated the negation STREQ to STRNEQ

2015-09-21 Thread Michal Privoznik
On 21.09.2015 13:05, Michal Privoznik wrote: > [You've got the wrong list. This is a libvirt patch and as such it > should have been sent to the libvir-l...@redhat.com] > > On 19.09.2015 16:59, Lasya wrote: >> Hi, >> This is my first patch in QEMU. I have solved a bite-sized bug. I have >>

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 12:47, Jan Kiszka wrote: >> > Apart from the windows idea, how does virtio-peer compare to virtio-rpmsg? > rpmsg is a very specialized thing. It targets single AMP cores, assuming > that those have full access to the main memory. Yes, this is why I did say "apart from the windows

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2015 14:22:23 +0200 Paolo Bonzini wrote: > > > On 21/09/2015 13:50, Igor Mammedov wrote: > > it's attempt to workaround virtio bug reported earlier: > > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html > > where virtio can't handle

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 15:05, Igor Mammedov wrote: >> > To some extend, enforcing natural alignment would be okay as a >> > workaround for the virtio bug as well. It would also make it easier to >> > ensure that hotplugged hugetlbfs-backed memory can use hugepages in the >> > guest. Does it make sense

[Qemu-devel] [PATCH 5/5] block/nfs: cache allocated filesize for read-only files

2015-09-21 Thread Peter Lieven
If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Marc Marí
Ping! Anyone has more comments for the next version? Thanks Marc >On Tue, 8 Sep 2015 15:53:20 +0200 >Marc Marí wrote: > > The current module infrastructure has been improved to enable dynamic > module loading. > > This reduces the load time for very simple guests. For the

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2015 15:13:17 +0200 Paolo Bonzini wrote: > > > On 21/09/2015 15:05, Igor Mammedov wrote: > >> > To some extend, enforcing natural alignment would be okay as a > >> > workaround for the virtio bug as well. It would also make it easier to > >> > ensure that

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 15:32, Igor Mammedov wrote: > On Mon, 21 Sep 2015 15:13:17 +0200 > Paolo Bonzini wrote: > >> >> >> On 21/09/2015 15:05, Igor Mammedov wrote: > To some extend, enforcing natural alignment would be okay as a > workaround for the virtio bug as well. It

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Denis V. Lunev
On 09/08/2015 04:53 PM, Marc Marí wrote: The current module infrastructure has been improved to enable dynamic module loading. This reduces the load time for very simple guests. For the following configuration (very loaded) ./configure --enable-sdl --enable-gtk --enable-vte --enable-curses \

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 13:50, Igor Mammedov wrote: > it's attempt to workaround virtio bug reported earlier: > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html > where virtio can't handle buffer that crosses border > between 2 DIMM's (i.e. 2 MemoryRegions). > > Testing showed that

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Jan Kiszka
On 2015-09-21 14:13, Michael S. Tsirkin wrote: > On Fri, Sep 18, 2015 at 06:29:27PM +0200, Claudio Fontana wrote: >> Hello, >> >> this is a first RFC for virtio-peer 0.1, which is still very much a work in >> progress: >> >> https://github.com/hw-claudio/virtio-peer/wiki >> >> It is also

[Qemu-devel] [PATCH 0/5] ide: avoid main-loop hang on CDROM/NFS failure

2015-09-21 Thread Peter Lieven
This series aims at avoiding a hanging main-loop if a vserver has a CDROM image mounted from a NFS share and that NFS share goes down. Typical situation is that users mount an CDROM ISO to install something and then forget to eject that CDROM afterwards. As a consequence this mounted CD is able to

Re: [Qemu-devel] [PATCH v2 1/2] Add dynamic module loading for block drivers

2015-09-21 Thread Denis V. Lunev
On 09/08/2015 04:53 PM, Marc Marí wrote: Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. This is

Re: [Qemu-devel] [PATCH v6 06/14] blockjob: Add .commit and .abort block job actions

2015-09-21 Thread Fam Zheng
On Mon, 09/21 18:29, John Snow wrote: > > > On 09/15/2015 02:11 AM, Fam Zheng wrote: > > Reviewed-by: Max Reitz > > Signed-off-by: Fam Zheng > > --- > > include/block/blockjob.h | 18 ++ > > 1 file changed, 18 insertions(+) > > > > diff

[Qemu-devel] [PATCH v7 14/14] tests: add BlockJobTxn unit test

2015-09-21 Thread Fam Zheng
From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v7 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-09-21 Thread Fam Zheng
From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v5 46/46] qapi: Allow anonymous base for flat union

2015-09-21 Thread Eric Blake
Rather than requiring all flat unions to explicitly create a separate base struct, we want to allow the qapi schema to specify the common fields via an inline dictionary. This is similar to how commands can specify inline types for the arguments. Now that the feature is legal, we can drop the

[Qemu-devel] [PATCH v5 39/46] qapi: Plumb in 'box' to qapi generator lower levels

2015-09-21 Thread Eric Blake
A future patch will add support for passing a qapi union type as the 'data' of a command. But to do that, the user function for implementing the command, as called by the generated marshal command, must take the corresponding C struct as a single boxed pointer, rather than a breakdown into one

Re: [Qemu-devel] [PATCH v6 05/14] blockjob: Introduce reference count

2015-09-21 Thread John Snow
On 09/15/2015 02:11 AM, Fam Zheng wrote: > So that block_job_complete_sync can be simplified. > > Reviewed-by: Max Reitz > Signed-off-by: Fam Zheng > --- > block/mirror.c | 2 +- > blockjob.c | 22 ++ >

Re: [Qemu-devel] [PATCH v2 10/22] target-sh4: Add flags state to insn_start

2015-09-21 Thread Aurelien Jarno
On 2015-09-17 21:55, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-sh4/cpu.h | 1 + > target-sh4/translate.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by:

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-21 Thread Mike Ladouceur
Sorry, at this point, I've moved to compiling from Ubuntu as you suggested earlier. On Sun, Sep 20, 2015 at 9:19 PM, Mike Ladouceur wrote: > Okay, i followed the steps from the reply to my email I noticed on the > website, but never made its way to my inbox. Now, I'm

[Qemu-devel] [PATCH v7 12/14] iotests: 124 - transactional failure test

2015-09-21 Thread Fam Zheng
From: John Snow Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. To support the 'transactional-cancel' QMP

[Qemu-devel] [PATCH v7 13/14] qmp-commands.hx: Update the supported 'transaction' operations

2015-09-21 Thread Fam Zheng
From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup

Re: [Qemu-devel] [PATCH v6 09/14] block: Add block job transactions

2015-09-21 Thread John Snow
On 09/15/2015 02:11 AM, Fam Zheng wrote: > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v6 14/14] tests: add BlockJobTxn unit test

2015-09-21 Thread Fam Zheng
On Fri, 09/18 13:45, Max Reitz wrote: > On 15.09.2015 08:11, Fam Zheng wrote: > > From: Stefan Hajnoczi > > > > The BlockJobTxn unit test verifies that both single jobs and pairs of > > jobs behave as a transaction group. Either all jobs complete > > successfully or the

  1   2   3   >