Re: [Qemu-devel] [PULL 0/4] update to 35c53797 to 4e03af8

2015-09-22 Thread Peter Maydell
On 3 September 2015 at 06:02, Gerd Hoffmann wrote: > Hi, > > Here comes the ipxe update pull. Thanks to Stefan all bits are upstream > now. Also upstream has a named configuration for qemu. That simplifies > the whole process, I could drop some patches and so there are

Re: [Qemu-devel] [PATCH 01/16] block: Introduce BDS.file_child

2015-09-22 Thread Max Reitz
On 22.09.2015 19:14, Max Reitz wrote: > On 17.09.2015 15:48, Kevin Wolf wrote: >> Store the BdrvChild for bs->file. At this point, bs->file_child->bs just >> duplicates the bs->file pointer. Later, it will completely replace it. >> >> Signed-off-by: Kevin Wolf >> --- >> block.c

Re: [Qemu-devel] [PATCH 03/16] blkverify: Convert s->test_file to BdrvChild

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/blkverify.c | 41 + > 1 file changed, 21 insertions(+), 20 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Laszlo Ersek
meta review of your review: On 09/22/15 20:11, John Snow wrote: > Reviewed from an en_US perspective, though I left alone things that are > clearly regional (e.g. 'behaviour' vs 'behavior') > > On 09/22/2015 12:35 PM, Daniel P. Berrange wrote: >> + - Add information to the help output message

Re: [Qemu-devel] [PATCH v14 0/5] vGICv3 support

2015-09-22 Thread Peter Maydell
On 17 September 2015 at 10:27, Peter Maydell wrote: > On 9 September 2015 at 08:49, Pavel Fedin wrote: >> This series introduces support for GICv3 by KVM. Software emulation is >> currently not supported. >> >> v13 => v14 >> >> - Rebased on the

Re: [Qemu-devel] [PATCH 06/16] block: Remove bdrv_open_image()

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > It is unused now. > > Signed-off-by: Kevin Wolf > --- > block.c | 34 -- > include/block/block.h | 4 > 2 files changed, 38 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 07/16] block: Convert bs->backing_hd to BdrvChild

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > This is the final step in converting all of the BlockDriverState > pointers that block drivers use to BdrvChild. > > After this patch, bs->children contains the full list of child nodes > that are referenced by a given BDS, and these children are only >

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread John Snow
On 09/22/2015 05:13 AM, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: >> >> Full list of unmaintained files now: > [...] > Full list edited down to 'sections' with replies in-line... [ top level confetti/detritus ] [ backends/* ] [

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Eric Blake
On 09/22/2015 12:28 PM, Laszlo Ersek wrote: > meta review of your review: > > >>> +Each system/userspace emulation target needs to have a slightly >>> +different set of make rules / variables. Thus, make will be recursively >>> +invoked for each of the emulation targets. >>> + >>> +The

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Laszlo Ersek
On 09/22/15 20:51, Eric Blake wrote: > On 09/22/2015 12:28 PM, Laszlo Ersek wrote: >> meta review of your review: >> > >> +Each system/userspace emulation target needs to have a slightly +different set of make rules / variables. Thus, make will be recursively +invoked for each of

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 22/09/2015 20:07, Eric Blake wrote: > On 09/22/2015 03:13 AM, Markus Armbruster wrote: > >>> Full list of unmaintained files now: >> [...] >> > >> docs/bitmaps.md docs/blkdebug.txt docs/blkverify.txt > >> docs/live-block-ops.txt > >>

Re: [Qemu-devel] [PULL 0/2] Monitor patches

2015-09-22 Thread Peter Maydell
On 22 September 2015 at 05:01, Markus Armbruster wrote: > The following changes since commit 9e72681d16792d0ffc42bab634b1753ff299bdfd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-09-21' > into staging (2015-09-21 22:33:51 +0100) > > are available in

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Eric Blake
On 09/22/2015 10:35 AM, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head around the s/autotools/autotools,/ > home-grown QEMU build system. This document attempts to explain > the structure /

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Eduardo Habkost
On Fri, Sep 18, 2015 at 10:58:43PM +0800, Yuanhan Liu wrote: [...] > diff --git a/net/vhost-user.c b/net/vhost-user.c > index 93dcecd..4fa3d64 100644 > --- a/net/vhost-user.c > +++ b/net/vhost-user.c [...] > +if (i == 0) { > +max_queues = vhost_net_get_max_queues(s->vhost_net);

Re: [Qemu-devel] [PULL 00/48] Misc patches for 2015-09-22

2015-09-22 Thread Peter Maydell
On 22 September 2015 at 08:05, Paolo Bonzini wrote: > The following changes since commit 9e72681d16792d0ffc42bab634b1753ff299bdfd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-09-21' > into staging (2015-09-21 22:33:51 +0100) > > are available in

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 20:11, John Snow wrote: >> +such as error handling infrastructure, standard data structures, >> +platform portability wrapper functions, etc. This code can be compiled >> +once only and the .o files linked into all output binaries. >> + >> +In the target dependant set lives CPU

Re: [Qemu-devel] [PATCH v7 09/14] block: Add block job transactions

2015-09-22 Thread John Snow
On 09/21/2015 10:46 PM, Fam Zheng wrote: > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 05/16] block: Convert bs->file to BdrvChild

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > This patch removes the temporary duplication between bs->file and > bs->file_child by converting everything to BdrvChild. > > Signed-off-by: Kevin Wolf > --- > block.c | 61

Re: [Qemu-devel] [PATCH v7 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-09-22 Thread John Snow
On 09/21/2015 10:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Provide a BlockJobTxn to actions executed in a qmp 'transaction' > command. This allows actions to make their block jobs either complete > as a group or fail/cancel together. > > The next patch adds the

Re: [Qemu-devel] [Bug 1498144] [NEW] Failure booting hurd with qemu-system-i386 on ARM

2015-09-22 Thread Laszlo Ersek
On 09/21/15 21:04, PeteVine wrote: > Public bug reported: > > Trying to boot debian-hurd-20150320.img ends with: > > qemu-system-i386: qemu-coroutine-lock.c:91: qemu_co_queue_restart_all: > Assertion `qemu_in_coroutine()' failed. > > Program received signal SIGABRT, Aborted. > __libc_do_syscall

[Qemu-devel] [PATCH V5 0/2] Move sdhci.h to include/hw/sd

2015-09-22 Thread Sai Pavan Boddu
Move sdhci.h splitting it into common and internal. Create a new directory for sd in include/hw/. Correct paths of sd.h in at every instance of #include. Sai Pavan Boddu (2): sd.h: Move sd.h to include/hw/sd/ sdhci: Split sdhci.h for public and internal device usage

[Qemu-devel] [PATCH V5 1/2] sd.h: Move sd.h to include/hw/sd/

2015-09-22 Thread Sai Pavan Boddu
Create a sd director under include/hw/ and move sd.h to same. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis --- Changes for V5: None Changes for V4: Fix commit message. Changes for V3: None. ---

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-22 Thread Marcel Apfelbaum
On 09/22/2015 08:43 AM, Star Chang wrote: Thanks Marcel!!! After tailing the logs and basic troubleshooting, we finally can have 2 VMs to ping to each other. One dpdkvhostuser interface is for each VM and we have to new add flows based on dpdkvhostuser ofport numbers. Hi, Good to hear

[Qemu-devel] [PATCH V5 2/2] sdhci: Split sdhci.h for public and internal device usage

2015-09-22 Thread Sai Pavan Boddu
Split sdhci.h into pubilc Version (i.e include/hw/sd/sdhci.h) and internal version (i.e hw/sd/sdhci-interna.h) base on register declarations and object declaration. Signed-off-by: Sai Pavan Boddu --- Chagdes for V5: Rename pubilc header version as sdhci.h and internal

[Qemu-devel] [PATCH V6 1/2] sd.h: Move sd.h to include/hw/sd/

2015-09-22 Thread Sai Pavan Boddu
Create a sd directory under include/hw/ and move sd.h to same. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis --- Changes for V6: Fix commit message. Changes for V5: None Changes for V4: Fix commit message. Changes for

[Qemu-devel] [PATCH V6 2/2] sdhci: Split sdhci.h for public and internal device usage

2015-09-22 Thread Sai Pavan Boddu
Split sdhci.h into Pubilc version (i.e include/hw/sd/sdhci.h) and Internal version (i.e hw/sd/sdhci-interna.h) based on register declarations and object declaration. Signed-off-by: Sai Pavan Boddu --- Changes for V6: Fix commit message. Chages for V5: Rename pubilc

Re: [Qemu-devel] [Qemu-block] [PATCH] block/nfs: add support for setting debug level

2015-09-22 Thread Peter Lieven
Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi: On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support for it in qemu through an URL parameter. Signed-off-by: Peter Lieven --- block/nfs.c | 4

Re: [Qemu-devel] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Max Reitz
On 22.09.2015 15:28, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing options

Re: [Qemu-devel] [PATCH v2 11/22] target-cris: Mirror gen_opc_pc into insn_start

2015-09-22 Thread Aurelien Jarno
On 2015-09-17 21:55, Richard Henderson wrote: > This perhaps isn't ideal in terms of (ab)using the "pc" field > to encode both pc and ppc + delay branch state, as one has to > be aware of this when examining opcode dumps. > > But it preserves existing logic, which will be good for bisection, >

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread John Snow
Reviewed from an en_US perspective, though I left alone things that are clearly regional (e.g. 'behaviour' vs 'behavior') On 09/22/2015 12:35 PM, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head

Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Laszlo Ersek
On 09/22/15 18:35, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools can have trouble getting their head around the > home-grown QEMU build system. This document attempts to explain > the structure / design of the configure script and

Re: [Qemu-devel] [PATCH v2 REPOST] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-09-22 Thread Stefan Weil
Hi, I suggest cleaning some comments, mostly using the "official" spellings for MinGW and Mingw-w64. Am 22.09.2015 um 16:13 schrieb Daniel P. Berrange: > The oslib-win32 file currently provides a localtime_r and > gmtime_r replacement unconditionally. Some versions of > Mingw64 would provide

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Eric Blake
On 09/22/2015 03:13 AM, Markus Armbruster wrote: >> Full list of unmaintained files now: > [...] > > docs/bitmaps.md > docs/blkdebug.txt > docs/blkverify.txt > docs/live-block-ops.txt > docs/qcow2-cache.txt > docs/qdev-device-use.txt > docs/specs/qcow2.txt > docs/specs/qed_spec.txt Kevin,

Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP

2015-09-22 Thread Eric Blake
On 09/22/2015 09:23 AM, Kevin Wolf wrote: > Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben: >> From: Eric Blake >> >> Commits 7216ae3d and d2828429 disabled some error message hints, >> all because a change to use modern error reporting meant that the >> hint would be

[Qemu-devel] [PULL 45/48] mips: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The bootloaders can just pass EM_MIPS directly, as that is architecture specific code. This

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-22 Thread Eric Blake
On 09/21/2015 08:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This

Re: [Qemu-devel] [PATCH 02/16] vmdk: Use BdrvChild instead of BDS for references to extents

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/vmdk.c | 99 > +++- > 1 file changed, 51 insertions(+), 48 deletions(-) Reviewed-by: Max Reitz signature.asc

Re: [Qemu-devel] [PATCH v5 03/46] qapi: Test for C member name collisions

2015-09-22 Thread Eric Blake
On 09/22/2015 09:23 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Expose some weaknesses in the generator: we don't always forbid >> the generation of structs that contain multiple members that map > > Slightly misleading. args-name-clash is a clash between command

[Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design

2015-09-22 Thread Daniel P. Berrange
Developers who are new to QEMU, or have a background familiarity with GNU autotools can have trouble getting their head around the home-grown QEMU build system. This document attempts to explain the structure / design of the configure script and the various Makefile pieces that live across the

Re: [Qemu-devel] [PATCH v6 4/4] block: add tests for the 'blockdev-snapshot' command

2015-09-22 Thread Max Reitz
On 22.09.2015 15:28, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > Cc: Max Reitz > --- > tests/qemu-iotests/085 | 102 > ++--- > tests/qemu-iotests/085.out | 34 ++- > 2 files changed, 128

Re: [Qemu-devel] [PATCH 01/16] block: Introduce BDS.file_child

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Store the BdrvChild for bs->file. At this point, bs->file_child->bs just > duplicates the bs->file pointer. Later, it will completely replace it. > > Signed-off-by: Kevin Wolf > --- > block.c | 12 +--- >

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-22 Thread Alex Williamson
On Tue, 2015-09-22 at 18:08 +0800, Cao jin wrote: > Hi Alex > > On 09/22/2015 02:00 AM, Alex Williamson wrote: > > > > Please use different subjects that uniquely identify what each patch > > does, don't simply re-use the subject for the cover patch on each. > > OK, will change it in next

Re: [Qemu-devel] [PATCH 04/16] quorum: Convert to BdrvChild

2015-09-22 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 63 > ++ > 1 file changed, 33 insertions(+), 30 deletions(-) Reviewed-by: Max Reitz signature.asc

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 10:16, Markus Armbruster wrote: >> "To build QEMU, you'd generally [some basic steps that have generally >> worked for a long time], but for up-to-date authoritative information, >> please do: >> >> mkdir path_to/build_dir >> cd path_to/build_dir >> ../../configure >> make

[Qemu-devel] [Bug 1498144] Re: Failure booting hurd with qemu-system-i386 on ARM

2015-09-22 Thread PeteVine
All right, I'll rebuild and try qemu-gdb.py if still necessary. Do any fancy CFLAGS make a difference in performance or should they be avoided altogether on ARM? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH v3 03/25] target-*: Increment num_insns immediately after tcg_gen_insn_start

2015-09-22 Thread Richard Henderson
This does tidy the icount test common to all targets. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 4 ++-- target-arm/translate-a64.c| 6 +++---

[Qemu-devel] [PATCH v3 13/25] target-sparc: Split out gen_branch_n

2015-09-22 Thread Richard Henderson
Unify three copies of this code from different branch types. Fix the case when npc == DYNAMIC_PC, i.e. a branch within a delay slot. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/translate.c | 55

[Qemu-devel] [PATCH v3 05/25] tcg: Allow extra data to be attached to insn_start

2015-09-22 Thread Richard Henderson
With an eye toward having this data replace the gen_opc_* arrays that each target collects in order to enable restore_state_from_tb. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v3 07/25] target-i386: Add cc_op state to insn_start

2015-09-22 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/cpu.h | 1 + target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 18/25] tcg: Add TCG_MAX_INSNS

2015-09-22 Thread Richard Henderson
Adjust all translators to respect it. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 3 +++ target-arm/translate-a64.c| 3 +++ target-arm/translate.c| 6 +- target-cris/translate.c

[Qemu-devel] [PATCH v3 15/25] target-sparc: Add npc state to insn_start

2015-09-22 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/cpu.h | 1 + target-sparc/translate.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index

[Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-22 Thread Richard Henderson
We can now restore state without retranslation. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 1 + tcg/tcg.c | 40 - tcg/tcg.h | 4 +- translate-all.c | 149 +++-

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-22 Thread John Snow
Eric, Markus: I've CC'd you for some crazy what-if QAPI questions after my R-B on this patch. On 09/21/2015 10:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix xscmpodp and xscmpudp decoding

2015-09-22 Thread Aurelien Jarno
On 2015-09-22 12:26, Thomas Huth wrote: > On 13/09/15 23:03, Aurelien Jarno wrote: > > The xscmpodp and xscmpudp instructions only have the AX, BX bits in > > there encoding, the lowest bit (usually TX) is marked as an invalid > > bit. We therefore can't decode them with GEN_XX2FORM, which decodes

Re: [Qemu-devel] [PATCH v5 0/4] qapi: child add/delete support

2015-09-22 Thread Wen Congyang
On 09/22/2015 07:15 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> If quorum's child is broken, we can use mirror job to replace it. >> But sometimes, the user only need to remove the broken child, and >> add it later when the problem is fixed. >> > > Hi, >

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Yuanhan Liu
On Tue, Sep 22, 2015 at 03:52:49PM -0300, Eduardo Habkost wrote: > On Fri, Sep 18, 2015 at 10:58:43PM +0800, Yuanhan Liu wrote: > [...] > > diff --git a/net/vhost-user.c b/net/vhost-user.c > > index 93dcecd..4fa3d64 100644 > > --- a/net/vhost-user.c > > +++ b/net/vhost-user.c > [...] > > +

[Qemu-devel] [PULL 03/36] spapr: Add /ibm,partition-name

2015-09-22 Thread David Gibson
From: Sam Bobroff QEMU has a notion of the guest name, so if it's present we might as well put that into the device tree as /ibm,partition-name. This is specificed by PAPR. Signed-off-by: Sam Bobroff Reviewed-by: David Gibson

[Qemu-devel] [PULL 00/36] spapr-next queue 20150923

2015-09-22 Thread David Gibson
The following changes since commit 27c7275a56948f48f536e2d1599b22355f5714ac: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ipxe-20150903-1' into staging (2015-09-22 19:22:23 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/spapr-next-20150923

[Qemu-devel] [PULL 01/36] spapr: Provide an error message when migration fails due to htab_shift mismatch

2015-09-22 Thread David Gibson
From: Bharata B Rao Include an error message when migration fails due to mismatch in htab_shift values at source and target. This should provide a bit more verbose message in addition to the current migration failure message that reads like: qemu-system-ppc64: error

[Qemu-devel] [PULL 09/36] ppc/spapr: Use qemu_log_mask() for hcall_dprintf()

2015-09-22 Thread David Gibson
From: Thomas Huth To see the output of the hcall_dprintf statements, you currently have to enable the DEBUG_SPAPR_HCALLS macro in include/hw/ppc/spapr.h. This is ugly because a) not every user who wants to debug guest problems can or wants to recompile QEMU to be able to see

[Qemu-devel] [PULL 10/36] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add

2015-09-22 Thread David Gibson
From: Bharata B Rao If drmgr is used in the guest to hotplug a device before a device_add has been issued via the QEMU monitor, QEMU segfaults in configure_connector call. This occurs due to accessing of NULL FDT which otherwise would have been created and associated

[Qemu-devel] [PULL 02/36] spapr: Create pseries-2.5 machine

2015-09-22 Thread David Gibson
Add pseries-2.5 machine version. Signed-off-by: Bharata B Rao [Altered to merge before memory hotplug -- dwg] [Altered to work with b9f072d01 -- dwg] Signed-off-by: David Gibson --- hw/ppc/spapr.c | 19 ++- 1 file

[Qemu-devel] [PULL 07/36] spapr: add dumpdtb support

2015-09-22 Thread David Gibson
From: Andrew Jones dumpdtb (-machine dumpdtb=) allows one to inspect the generated device tree of machine types that generate device trees. This is useful for a) seeing what's there b) debugging/testing device tree generator patches. It can be used as follows $QEMU_CMDLINE

[Qemu-devel] [PULL 19/36] spapr_drc: use RTAS return codes for methods called by RTAS

2015-09-22 Thread David Gibson
From: Michael Roth Certain methods in sPAPRDRConnector objects are only ever called by RTAS and in many cases are responsible for the logic that determines the RTAS return codes. Rather than having a level of indirection requiring RTAS code to re-interpret return

[Qemu-devel] [PULL 18/36] spapr: Initialize hotplug memory address space

2015-09-22 Thread David Gibson
From: Bharata B Rao Initialize a hotplug memory region under which all the hotplugged memory is accommodated. Also enable memory hotplug by setting CONFIG_MEM_HOTPLUG. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao

[Qemu-devel] [PULL 23/36] spapr: Support ibm, dynamic-reconfiguration-memory

2015-09-22 Thread David Gibson
From: Bharata B Rao Parse ibm,architecture.vec table obtained from the guest and enable memory node configuration via ibm,dynamic-reconfiguration-memory if guest supports it. This is in preparation to support memory hotplug for sPAPR guests. This changes the way

[Qemu-devel] [PULL 26/36] spapr: Don't allow memory hotplug to memory less nodes

2015-09-22 Thread David Gibson
From: Bharata B Rao Currently PowerPC kernel doesn't allow hot-adding memory to memory-less node, but instead will silently add the memory to the first node that has some memory. This causes two unexpected behaviours for the user. - Memory gets hotplugged to a

[Qemu-devel] [PULL 24/36] spapr: Make hash table size a factor of maxram_size

2015-09-22 Thread David Gibson
From: Bharata B Rao The hash table size is dependent on ram_size, but since with hotplug the memory can grow till maxram_size. Hence make hash table size dependent on maxram_size. This allows to hotplug huge amounts of memory to the guest. Signed-off-by: Bharata B

Re: [Qemu-devel] [PATCH v10 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-09-22 Thread Yuanhan Liu
On Tue, Sep 22, 2015 at 05:56:16PM +0800, Jason Wang wrote: > > > On 09/18/2015 10:58 PM, Yuanhan Liu wrote: > > This is for querying how many queues the backend supports if it has mq > > support(when VHOST_USER_PROTOCOL_F_MQ flag is set from the quried > > protocol features). > > > >

[Qemu-devel] [PULL 28/36] spapr: Populate ibm, associativity-lookup-arrays correctly for non-NUMA

2015-09-22 Thread David Gibson
From: Bharata B Rao When NUMA isn't configured explicitly, assume node 0 is present for the purpose of creating ibm,associativity-lookup-arrays property under ibm,dynamic-reconfiguration-memory DT node. This ensures that the associativity index property is correctly

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Yuanhan Liu
On Wed, Sep 23, 2015 at 10:12:10AM +0800, Jason Wang wrote: > > > On 09/23/2015 09:57 AM, Yuanhan Liu wrote: > > On Tue, Sep 22, 2015 at 06:14:14PM +0800, Jason Wang wrote: > >> > > [...] > >>> -static void net_vhost_link_down(VhostUserState *s, bool link_down) > >>> +static void

Re: [Qemu-devel] [PULL 00/33] spapr-next queue 2015-09-16

2015-09-22 Thread David Gibson
On Mon, Sep 21, 2015 at 02:33:12PM -0700, Peter Maydell wrote: > On 20 September 2015 at 18:05, David Gibson > wrote: > > The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a: > > > > Merge remote-tracking branch > >

[Qemu-devel] [PULL 11/36] sPAPR: Introduce rtas_ldq()

2015-09-22 Thread David Gibson
From: Gavin Shan This introduces rtas_ldq() to load 64-bits parameter from continuous two 4-bytes memory chunk of RTAS parameter buffer, to simplify the code. Signed-off-by: Gavin Shan Reviewed-by: Thomas Huth

[Qemu-devel] [PULL 06/36] spapr: SPLPAR Characteristics

2015-09-22 Thread David Gibson
From: Sam Bobroff Improve the SPLPAR Characteristics information: Add MaxPlatProcs: set to max_cpus, the maximum CPUs that could be addded to the system. Add DesMem: set to the initial memory of the system. Add DesProcs: set to smp_cpus, the inital

[Qemu-devel] [PULL 20/36] spapr: Don't use QOM [*] syntax for DR connectors.

2015-09-22 Thread David Gibson
The dynamic reconfiguration (hotplug) code for the pseries machine type uses a "DR connector" QOM object for each resource it will be possible to hotplug. Each of these is added to its owner using object_property_add_child(owner, "dr-connector[*], ...); That works ok, mostly, but it means

[Qemu-devel] [PULL 12/36] pseries: define coldplugged devices as "configured"

2015-09-22 Thread David Gibson
From: Laurent Vivier When a device is hotplugged, attach() sets "configured" to false, waiting an action from the OS to configure it and then to call ibm,configure-connector. On ibm,configure-connector, the hypervisor sets "configured" to true. In case of coldplugged device,

[Qemu-devel] [PULL 22/36] spapr: Add LMB DR connectors

2015-09-22 Thread David Gibson
Enable memory hotplug for pseries 2.4 and add LMB DR connectors. With memory hotplug, enforce RAM size, NUMA node memory size and maxmem to be a multiple of SPAPR_MEMORY_BLOCK_SIZE (256M) since that's the granularity in which LMBs are represented and hot-added. LMB DR connectors will be used by

[Qemu-devel] [PULL 05/36] spapr: Make ibm, change-msi respect 3 return values

2015-09-22 Thread David Gibson
From: Sam Bobroff Currently, rtas_ibm_change_msi() always returns four values even if less are specified. Correct this by only returning the fourth parameter if it was requested. This is specified by PAPR. Signed-off-by: Sam Bobroff

[Qemu-devel] [PULL 08/36] spapr_drc: Fix potential undefined behaviour

2015-09-22 Thread David Gibson
The DRC_INDEX_ID_MASK macro does a left shift on ~0, which is a signed quantity, and therefore undefined behaviour according to the C spec. In particular this causes warnings from the clang sanitizer. This fixes it by calculating the same mask without using ~0 (I think the new method is a more

[Qemu-devel] [PULL 29/36] spapr: Revert to memory@XXXX representation for non-hotplugged memory

2015-09-22 Thread David Gibson
From: Bharata B Rao Don't represent non-hotluggable memory under drconf node. With this we don't have to create DRC objects for them. The effect of this patch is that we revert back to memory@ representation for all the memory specified with -m option and

[Qemu-devel] [PULL 16/36] spapr_pci: fix device tree props for MSI/MSI-X

2015-09-22 Thread David Gibson
From: Michael Roth PAPR requires ibm,req#msi and ibm,req#msi-x to be present in the device node to define the number of msi/msi-x interrupts the device supports, respectively. Currently we have ibm,req#msi-x hardcoded to a non-sensical constant that happens to be 2,

[Qemu-devel] [PULL 35/36] sPAPR: Revert don't enable EEH on emulated PCI devices

2015-09-22 Thread David Gibson
From: Gavin Shan This reverts commit 7cb18007 ("sPAPR: Don't enable EEH on emulated PCI devices") as rtas_ibm_set_eeh_option() isn't the right place to check if there has the corresponding PCI device for the input address, which can be PE address, not PCI device

Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-22 Thread Eric Blake
On 09/22/2015 08:05 PM, Yuanhan Liu wrote: >>> + * VHOST_USER_SET_VRING_ENABLE >>> + >>> + Id: 18 >>> + Equivalent ioctl: N/A >>> + Master payload: vring state description >>> + >>> + Signal slave to enable or disable corresponding vring. >> >> Does there need to be any QMP

Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-22 Thread Yuanhan Liu
On Tue, Sep 22, 2015 at 08:47:04AM -0600, Eric Blake wrote: > On 09/18/2015 08:58 AM, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > Add a new message, VHOST_USER_SET_VRING_ENABLE, to enable or disable > > a specific virt queue, which is similar to

[Qemu-devel] [PULL 30/36] spapr: Support hotplug by specifying DRC count

2015-09-22 Thread David Gibson
From: Bharata B Rao Support hotplug identifier type RTAS_LOG_V6_HP_ID_DRC_COUNT that allows hotplugging of DRCs by specifying the DRC count. While we are here, rename spapr_hotplug_req_add_event() to spapr_hotplug_req_add_by_index() spapr_hotplug_req_remove_event()

[Qemu-devel] [PULL 31/36] spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type

2015-09-22 Thread David Gibson
From: Bharata B Rao Till now memory hotplug used RTAS_LOG_V6_HP_ID_DRC_INDEX hotplug type which meant that we generated one hotplug type of EPOW event for every 256MB (SPAPR_MEMORY_BLOCK_SIZE). This quickly overruns the kernel rtas log buffer thus resulting in loss of

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Yuanhan Liu
On Tue, Sep 22, 2015 at 06:14:14PM +0800, Jason Wang wrote: > > [...] > > -static void net_vhost_link_down(VhostUserState *s, bool link_down) > > +static void net_vhost_link_down(int queues, NetClientState *ncs[], > > +bool link_down) > > { > > -

[Qemu-devel] [PULL 14/36] pseries: Fix incorrect calculation of threads per socket for chip-id

2015-09-22 Thread David Gibson
The device tree presented to pseries machine type guests includes an ibm,chip-id property which gives essentially the socket number of each vcpu core (individual vcpu threads don't get a node in the device tree). To calculate this, it uses a vcpus_per_socket variable computed as (smp_cpus /

[Qemu-devel] [PULL 04/36] spapr: Add /rtas/ibm, change-msix-capable

2015-09-22 Thread David Gibson
From: Sam Bobroff QEMU is MSI-X capable and makes it available via ibm,change-msi, so we should indicate this by adding /rtas/ibm,change-msix-capable to the device tree. This is specificed by PAPR. Signed-off-by: Sam Bobroff Reviewed-by: David

[Qemu-devel] [PULL 15/36] spapr: Enable in-kernel H_SET_MODE handling

2015-09-22 Thread David Gibson
From: Alexey Kardashevskiy For setting debug watchpoints, sPAPR guests use H_SET_MODE hypercall. The existing QEMU H_SET_MODE handler does not support this but the KVM handler in HV KVM does. However it is not enabled. This enables the in-kernel H_SET_MODE handler which handles:

[Qemu-devel] [PULL 25/36] spapr: Memory hotplug support

2015-09-22 Thread David Gibson
From: Bharata B Rao Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Signed-off-by: David Gibson

[Qemu-devel] [PULL 17/36] spapr_drc: don't allow 'empty' DRCs to be unisolated or allocated

2015-09-22 Thread David Gibson
From: Michael Roth Logical resources start with allocation-state:UNUSABLE / isolation-state:ISOLATED. During hotplug, guests will transition them to allocation-state:USABLE, and then to isolation-state:UNISOLATED. For cases where we cannot transition to

[Qemu-devel] [PULL 27/36] spapr: Provide better error message when slots exceed max allowed

2015-09-22 Thread David Gibson
From: Bharata B Rao Currently when user specifies more slots than allowed max of SPAPR_MAX_RAM_SLOTS (32), we error out like this: qemu-system-ppc64: unsupported amount of memory slots: 64 Let the user know about the max allowed slots like this: qemu-system-ppc64:

[Qemu-devel] [PULL 21/36] spapr: Use QEMU limit for maximum CPUs number

2015-09-22 Thread David Gibson
From: Alexey Kardashevskiy sPAPR uses hard coded limit of maximum 255 supported CPUs which is exactly the same as QEMU-wide limit which is MAX_CPUMASK_BITS and also defined as 255. This makes use of a global CPU number limit for the "pseries" machine. In order to anticipate

[Qemu-devel] [PULL 34/36] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-22 Thread David Gibson
From: Thomas Huth The PAPR interface defines a hypercall to pass high-quality hardware generated random numbers to guests. Recent kernels can already provide this hypercall to the guest if the right hardware random number generator is available. But in case the user wants to

[Qemu-devel] [PULL 36/36] sPAPR: Enable EEH on VFIO PCI device only

2015-09-22 Thread David Gibson
From: Gavin Shan This checks if the PCI device retrieved from the PCI device address is VFIO PCI device when enabling EEH functionality. If it's not VFIO PCI device, the EEH functonality isn't enabled. Signed-off-by: Gavin Shan

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Jason Wang
On 09/23/2015 09:57 AM, Yuanhan Liu wrote: > On Tue, Sep 22, 2015 at 06:14:14PM +0800, Jason Wang wrote: >> > [...] >>> -static void net_vhost_link_down(VhostUserState *s, bool link_down) >>> +static void net_vhost_link_down(int queues, NetClientState *ncs[], >>> +

[Qemu-devel] [PULL 32/36] spapr: Fix default NUMA node allocation for threads

2015-09-22 Thread David Gibson
At present, if guest numa nodes are requested, but the cpus in each node are not specified, spapr just uses the default behaviour or assigning each vcpu round-robin to nodes. If smp_threads != 1, that will assign adjacent threads in a core to different NUMA nodes. As well as being just weird,

[Qemu-devel] [PULL 33/36] ppc/spapr: Fix buffer overflow in spapr_populate_drconf_memory()

2015-09-22 Thread David Gibson
From: Thomas Huth The buffer that is allocated in spapr_populate_drconf_memory() is used for setting both, the "ibm,dynamic-memory" and the "ibm,associativity-lookup-arrays" property. However, only the size of the first one is taken into account when allocating the memory. So

Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-22 Thread Yuanhan Liu
On Tue, Sep 22, 2015 at 08:06:58PM -0600, Eric Blake wrote: > On 09/22/2015 08:05 PM, Yuanhan Liu wrote: > > >>> + * VHOST_USER_SET_VRING_ENABLE > >>> + > >>> + Id: 18 > >>> + Equivalent ioctl: N/A > >>> + Master payload: vring state description > >>> + > >>> + Signal slave to

  1   2   3   4   >