Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Eric Blake
On 10/16/2015 10:20 AM, Paul Durrant wrote: >> -Original Message- >>> On 10/13/2015 11:55 AM, Fabio Fantoni wrote: I added ahci disk support in libxl and using it for week seems Do we really need this many levels of quoting... that >> was ok,

Re: [Qemu-devel] [PULL 00/12] QAPI patches

2015-10-16 Thread Peter Maydell
On 15 October 2015 at 08:51, Markus Armbruster wrote: > The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' > into staging (2015-10-13 10:42:06 +0100) > > are available in

[Qemu-devel] [PATCH v3 2/2] kvm: Allow the Hyper-V vendor ID to be specified

2015-10-16 Thread Alex Williamson
According to Microsoft documentation, the signature in the standard hypervisor CPUID leaf at 0x4000 identifies the Vendor ID and is for reporting and diagnostic purposes only. We can therefore allow the user to change it to whatever they want, within the 12 character limit. Add a new

[Qemu-devel] [PATCH v3 0/2] Enable specifying a non-default Hyper-V vendor ID

2015-10-16 Thread Alex Williamson
v3: Incorporate suggestion from Igor to move the string length test out to the property parsing. A string that's too long will now get an error like: $ qemu-system-x86_64 -cpu qemu64,hv_vendor_id=123456789abcd qemu-system-x86_64: Property 'host-x86_64-cpu.hv-vendor-id' doesn't

[Qemu-devel] [Bug 1497711] Re: tests/libqos/ahci.c:745: redundant condition ?

2015-10-16 Thread Stefan Hajnoczi
Fixed in: commit 3d937150dce20cb95cbaae99b6fd48dca4261f32 Author: John Snow Date: Mon Oct 5 12:00:55 2015 -0400 qtest/ahci: fix redundant assertion Fixes https://bugs.launchpad.net/qemu/+bug/1497711 (!ncq || (ncq && lba48)) is the same as (!ncq ||

Re: [Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 18:21, Ilya Lipnitskiy wrote: > Hi All, > > I am running into a curious issue with QEMU ARM, maybe a Linux/QEMU > ARM expert could help before I filed a bug report. Is this a QEMU > problem or is there a fundamental problem with my kernel change?

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-16 Thread Sergey Fedorov
On 16.10.2015 19:36, Sergey Fedorov wrote: > On 16.10.2015 17:08, Sergey Fedorov wrote: >> On 16.10.2015 04:14, Richard Henderson wrote: >>> On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: > On 10/15/2015 06:34 AM,

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 16 October 2015 17:43 > To: Paul Durrant > Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu- > de...@nongnu.org; xen-de...@lists.xen.org; qemu-bl...@nongnu.org > Subject: Re: [Qemu-devel]

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Kevin Wolf
Am 16.10.2015 um 18:53 hat Paul Durrant geschrieben: > > > > > > Just tell your admin what virtual hardware you really need. (Or tell > > > > > > them to give you a proper interface to configure your VMs yourself.) > > > > > > > > > > > > > > > > My point is that the virtual hardware that the OS

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-10-16 Thread P J P
+-- On Fri, 16 Oct 2015, Paolo Bonzini wrote --+ | > +if (s->tx.link == s->cu_offset) | > +break; | | Please update the patch to conform to QEMU's coding standards; braces | are required even around single-statement blocks. Done. Please see an updated patch below. ===

Re: [Qemu-devel] [PULL 0/7] vhost, pc features, fixes

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 09:49, Michael S. Tsirkin wrote: > The following changes since commit b37686f7e84b22cfaf7fd01ac5133f2617cc3027: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2015-10-09 12:18:14 +0100) > > are available in

[Qemu-devel] [PATCH v9 05.5/17] fixup to qapi: Unbox base members

2015-10-16 Thread Eric Blake
valgrind reports that our testsuite is making a branch based on uninitialized memory; and depending on compile options, the state of the stack could result in the test segfaulting. I missed the fact that we were previously relying on 'u' being fully initialized. Signed-off-by: Eric Blake

Re: [Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 18:57, Ilya Lipnitskiy wrote: > On Fri, Oct 16, 2015 at 10:37 AM, Peter Maydell > wrote: >> It would be helpful if you said what the abort actually was >> (ie what instruction do we abort on, what are the fault status/ >>

Re: [Qemu-devel] Live migration sequence

2015-10-16 Thread Dr. David Alan Gilbert
* Pavel Fedin (p.fe...@samsung.com) wrote: > Hello! > > > Some thoughts: > > a) There is a migration state notifier list - see > > add_migration_state_change_notifier (spice > > calls it) > > - but I don't think it's called in the right places for your needs; we > > could add some

[Qemu-devel] [PATCH] hw/ide/ahci.c: Fix shift left into sign bit

2015-10-16 Thread Peter Maydell
Avoid undefined behaviour from shifting left into the sign bit: hw/ide/ahci.c:551:36: runtime error: left shift of 255 by 24 places cannot be represented in type 'int' (Unfortunately C's promotion rules mean that in the expression "some_uint8_t_variable << 24" the LHS gets promoted to signed

Re: [Qemu-devel] [RFC] Block device size rounding

2015-10-16 Thread Peter Crosthwaite
On Fri, Oct 16, 2015 at 10:04 AM, John Snow wrote: > > > On 10/14/2015 04:36 AM, Kevin Wolf wrote: >> Am 13.10.2015 um 17:51 hat John Snow geschrieben: >>> >>> >>> On 10/13/2015 11:30 AM, Peter Crosthwaite wrote: On Tue, Oct 13, 2015 at 2:14 AM, Kevin Wolf

Re: [Qemu-devel] [PULL v2 00/12] qemu-ga patch queue

2015-10-16 Thread Peter Maydell
On 15 October 2015 at 17:05, Michael Roth wrote: > Hi Peter, > > Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in > Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical, > but let me know if you'd prefer a re-send/re-base

Re: [Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Ilya Lipnitskiy
On Fri, Oct 16, 2015 at 11:09 AM, Peter Maydell wrote: > You might find it helpful to turn on QEMU's debug logging > (see the -d and -D options). Chances are that some insn > in your new code is faulting (probably UNDEFing). Thanks for the suggestion! Here is what I got:

Re: [Qemu-devel] [RFC] Block device size rounding

2015-10-16 Thread John Snow
On 10/14/2015 04:36 AM, Kevin Wolf wrote: > Am 13.10.2015 um 17:51 hat John Snow geschrieben: >> >> >> On 10/13/2015 11:30 AM, Peter Crosthwaite wrote: >>> On Tue, Oct 13, 2015 at 2:14 AM, Kevin Wolf wrote: Am 12.10.2015 um 20:26 hat John Snow geschrieben: > >

[Qemu-devel] [PATCH v3 1/2] qapi: Create DEFINE_PROP_STRING_LEN

2015-10-16 Thread Alex Williamson
A slight addition to set_string(), which optionally tests that the string length is within the bounds specified. Signed-off-by: Alex Williamson --- hw/core/qdev-properties.c|7 +++ include/hw/qdev-core.h |1 + include/hw/qdev-properties.h | 16

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Laszlo Ersek
On 10/16/15 13:34, Fabio Fantoni wrote: > Il 16/10/2015 12:47, Stefano Stabellini ha scritto: >> On Fri, 16 Oct 2015, Fabio Fantoni wrote: >>> Il 16/10/2015 12:13, Anthony PERARD ha scritto: On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote: > Il 15/10/2015 20:02, Anthony

Re: [Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure.

2015-10-16 Thread Eric Blake
On 10/16/2015 10:37 AM, Julio Faracco wrote: > When the user setup a vnc server to QEMU using the argument "-vnc > 0.0.0.0:0,websocket=5701" for example, he cannot get information about which > websocket port VNC is running. The command "info vnc" shows only details about > the main VNC server and

Re: [Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Ilya Lipnitskiy
On Fri, Oct 16, 2015 at 10:37 AM, Peter Maydell wrote: > It would be helpful if you said what the abort actually was > (ie what instruction do we abort on, what are the fault status/ > fault address registers if applicable, etc). I should have been more specific. Running

[Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Ilya Lipnitskiy
Hi All, I am running into a curious issue with QEMU ARM, maybe a Linux/QEMU ARM expert could help before I filed a bug report. Is this a QEMU problem or is there a fundamental problem with my kernel change? QEMU builds before SHA 6ec1588e handle this kernel change just fine... I'm seeing a very

Re: [Qemu-devel] [PATCH V5 0/8] Xilinx DisplayPort.

2015-10-16 Thread Alistair Francis
On Fri, Oct 16, 2015 at 6:41 AM, wrote: > From: KONRAD Frederic > > This is the fifth version of this patch-set of the implementation of the > Xilinx > DisplayPort and DPDMA. > > This fifth version moves some headers files to the right

Re: [Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 21:35, Ilya Lipnitskiy wrote: > On Fri, Oct 16, 2015 at 11:09 AM, Peter Maydell > wrote: > >> You might find it helpful to turn on QEMU's debug logging >> (see the -d and -D options). Chances are that some insn >> in your

Re: [Qemu-devel] vexpress-a9 aborts when booting decompress code from a modified Linux kernel

2015-10-16 Thread Ilya Lipnitskiy
On Fri, Oct 16, 2015 at 11:09 AM, Peter Maydell wrote: > You might find it helpful to turn on QEMU's debug logging > (see the -d and -D options). Chances are that some insn > in your new code is faulting (probably UNDEFing). I think have figured it out, looks like my

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-10-16 Thread Stefan Weil
Am 16.10.2015 um 19:19 schrieb P J P: > +-- On Fri, 16 Oct 2015, Paolo Bonzini wrote --+ > | > +if (s->tx.link == s->cu_offset) > | > +break; > | > | Please update the patch to conform to QEMU's coding standards; braces > | are required even around single-statement blocks. > >

Re: [Qemu-devel] [PATCH] hw/ide/ahci.c: Fix shift left into sign bit

2015-10-16 Thread John Snow
On 10/16/2015 01:48 PM, Peter Maydell wrote: > Avoid undefined behaviour from shifting left into the sign bit: > > hw/ide/ahci.c:551:36: runtime error: left shift of 255 by 24 places cannot be > represented in type 'int' > > (Unfortunately C's promotion rules mean that in the expression >

Re: [Qemu-devel] [PATCH v2] target-i386: Disable cache info passthrough by default

2015-10-16 Thread Eduardo Habkost
On Wed, Sep 02, 2015 at 11:19:11AM -0300, Eduardo Habkost wrote: > The host cache information may not make sense for the guest if the VM > CPU topology doesn't match the host CPU topology. To make sure we won't > expose broken cache information to the guest, disable cache info > passthrough by

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread John Snow
On 10/13/2015 01:10 PM, Stefano Stabellini wrote: > On Tue, 13 Oct 2015, John Snow wrote: >> On 10/13/2015 11:55 AM, Fabio Fantoni wrote: >>> I added ahci disk support in libxl and using it for week seems that was >>> ok, after a reply of Stefano Stabellini seems that xen disk unplug >>> support

[Qemu-devel] [PATCH 8/9] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin SynIC (synthetic interrupt controller) is a lapic extension, which is controlled via MSRs and maintains for each vCPU - 16 synthetic interrupt "lines" (SINT's); each can be configured to trigger a specific interrupt vector optionally with

[Qemu-devel] [PATCH 6/9] drivers/hv: share Hyper-V SynIC constants with userspace

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin Moved Hyper-V synic contants from guest Hyper-V drivers private header into x86 arch uapi Hyper-V header. Added Hyper-V synic msr's flags into x86 arch uapi Hyper-V header. Signed-off-by: Andrey Smetanin Reviewed-by:

[Qemu-devel] [PATCH 1/9] kvm/eventfd: avoid loop inside irqfd_update()

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin The loop(for) inside irqfd_update() is unnecessary because any other value for irq_entry.type will just trigger schedule_work(>inject). Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan

Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 03:18:59PM +0800, Yuanhan Liu wrote: > This reverts commit d1f8b30ec8dde0318fd1b98d24a64926feae9625. > > It turned out that it breaks stuff, so revert it: > > http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html > > CC: "Michael S. Tsirkin"

[Qemu-devel] Qemu: Guest Linux hangs on Mac OS X 10.11

2015-10-16 Thread Aaron Elkins
I built Qemu on Mac OS X 10.11 El Capitan with: ./configure make make install Successfully. And downloaded the official linux image, and ran it with the following: qemu-system-x86_64 -drive file=linux-0.2.img,index=0,media=disk,format=raw And

Re: [Qemu-devel] [PATCH 3/3] vhost-user-test: add multiple queue test

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 10:20:08AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 03:19:01PM +0800, Yuanhan Liu wrote: > > Setting VHOST_USER_PROTOCOL_F_MQ protocol feature bit to claim that we > > support MQ feature, and simply assume we support 2 queue pairs at most. > > Well -

Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported

2015-10-16 Thread Pavel Fedin
Hello! > But this is the GICv2 code. Unless there are kernels out in the wild > which support v2 but not migration, there's no need to check > for that situation here. Such kernels do exist for sure, otherwise why do we have kvm_gic_can_save_restore() at all? I remember even you pointed me at

Re: [Qemu-devel] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

2015-10-16 Thread Markus Armbruster
Jeff Cody writes: > This is a precursor to making bdrv_find_node() static, and internal > to block.c > > To find a BlockDriverState interface, it can be done via blk_by_name(), > bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place > of the other two, in the

Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 04:04:09PM +0800, Yuanhan Liu wrote: > On Fri, Oct 16, 2015 at 10:47:49AM +0300, Michael S. Tsirkin wrote: > > On Fri, Oct 16, 2015 at 03:32:56PM +0800, Yuanhan Liu wrote: > > > On Fri, Oct 16, 2015 at 10:21:40AM +0300, Michael S. Tsirkin wrote: > > > > On Fri, Oct 16, 2015

Re: [Qemu-devel] [PATCH 1/3] log: improve performance of qemu_log and qemu_log_mask if disabled

2015-10-16 Thread Markus Armbruster
"Denis V. Lunev" writes: > The patch is intended to avoid to perform any operation including > calculation of log function arguments when the log is not enabled due to > various reasons. > > Functions qemu_log and qemu_log_mask are replaced with variadic macros. > Unfortunately

Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 07:40, Pavel Fedin wrote: > Hello! > >> What kernel are you running that doesn't support state save/restore >> in the GICv2 implementation? > > I am not running such an old kernel. Just realized that GICv3 will need > something similar, and actually

Re: [Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete

2015-10-16 Thread Juan Quintela
Christian Borntraeger wrote: > Am 15.10.2015 um 08:27 schrieb Juan Quintela: >> From: "Dr. David Alan Gilbert" >> >> The current migration-completed event is generated a bit too early, >> which means that an eager libvirt that's ready to go as soon

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix memory leak in early exit

2015-10-16 Thread Alberto Garcia
On Thu 15 Oct 2015 05:54:27 PM CEST, Stefan Hajnoczi wrote: > The stream block job has two early exit code paths. They do not free > s->backing_file_str. > > Also, the early exits rely on the fact that the coroutine hasn't yielded > yet and was launched from the main

Re: [Qemu-devel] Live migration sequence

2015-10-16 Thread Pavel Fedin
Hello! > Some thoughts: > a) There is a migration state notifier list - see > add_migration_state_change_notifier (spice > calls it) > - but I don't think it's called in the right places for your needs; we > could add some more places that gets called. I am now trying to add one

Re: [Qemu-devel] [PATCH 2/3] log: report hmp/qmp command and qmp event

2015-10-16 Thread Markus Armbruster
"Denis V. Lunev" writes: > From: Pavel Butsykin > > This log would be very welcome for long-term diagnostics of the system > in the production. This log is at least necessary to understand what > has been happened on the system and to identify issues at

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 02:14, Richard Henderson wrote: > Heh. Fair enough. How about > > /* The address covered by the breakpoint must be included in > [tb->pc, tb->pc + tb->size) in order to for it to be > properly cleared -- thus we increment the PC here so that >

Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 03:32:56PM +0800, Yuanhan Liu wrote: > On Fri, Oct 16, 2015 at 10:21:40AM +0300, Michael S. Tsirkin wrote: > > On Fri, Oct 16, 2015 at 03:18:59PM +0800, Yuanhan Liu wrote: > > > This reverts commit d1f8b30ec8dde0318fd1b98d24a64926feae9625. > > > > > > It turned out that it

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Fabio Fantoni
Il 15/10/2015 20:02, Anthony PERARD ha scritto: On Thu, Oct 15, 2015 at 06:27:17PM +0200, Fabio Fantoni wrote: Il 14/10/2015 13:06, Stefano Stabellini ha scritto: I would suggest Fabio to avoid AHCI disks altogether and just use OVMF with PV disks only and Anthony's patch to libxl to avoid

[Qemu-devel] [PATCH v2 0/9] Hyper-V synthetic interrupt controller

2015-10-16 Thread Denis V. Lunev
This patchset implements the KVM part of the synthetic interrupt controller (SynIC) which is a building block of the Hyper-V paravirtualized device bus (vmbus). SynIC is a lapic extension, which is controlled via MSRs and maintains for each vCPU - 16 synthetic interrupt "lines" (SINT's); each

Re: [Qemu-devel] [RESEND PATCH] kvm: Allow the Hyper-V vendor ID to be specified

2015-10-16 Thread Paolo Bonzini
On 16/10/2015 00:16, Alex Williamson wrote: > According to Microsoft documentation, the signature in the standard > hypervisor CPUID leaf at 0x4000 identifies the Vendor ID and is > for reporting and diagnostic purposes only. We can therefore allow > the user to change it to whatever they

Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 10:21:40AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 03:18:59PM +0800, Yuanhan Liu wrote: > > This reverts commit d1f8b30ec8dde0318fd1b98d24a64926feae9625. > > > > It turned out that it breaks stuff, so revert it: > > > >

Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 10:47:49AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 03:32:56PM +0800, Yuanhan Liu wrote: > > On Fri, Oct 16, 2015 at 10:21:40AM +0300, Michael S. Tsirkin wrote: > > > On Fri, Oct 16, 2015 at 03:18:59PM +0800, Yuanhan Liu wrote: > > > > This reverts commit

Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported

2015-10-16 Thread Pavel Fedin
Hello! > What kernel are you running that doesn't support state save/restore > in the GICv2 implementation? I am not running such an old kernel. Just realized that GICv3 will need something similar, and actually GICv2 needs it too. Actually this idea came to me when i occasionally tried to

[Qemu-devel] [PATCH 2/3] doc: vhost-user: request naming fix

2015-10-16 Thread Yuanhan Liu
They are VHOST_USER_XXX instead of VHOST_XXX messages. Also, add VHOST_USER_GET_QUEUE_NUM to the section that requries replies. Cc: Michael S. Tsirkin Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 17 + 1 file changed,

[Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

2015-10-16 Thread Yuanhan Liu
This reverts commit d1f8b30ec8dde0318fd1b98d24a64926feae9625. It turned out that it breaks stuff, so revert it: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html CC: "Michael S. Tsirkin" Reported-by: Paolo Bonzini Signed-off-by:

Re: [Qemu-devel] Connecting netdev to emulated nics.

2015-10-16 Thread Jason Wang
On 10/16/2015 01:15 PM, sai pavan wrote: > +Peter > > Hi Jason, > > On Thu, Oct 15, 2015 at 2:44 PM, Jason Wang wrote: >> >> On 10/15/2015 02:36 PM, sai pavan wrote: >>> Hi, >>> >>> I am debugging an issue, where through one of the nics I am not able >>> to connect to dtcp.

Re: [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit

2015-10-16 Thread Paolo Bonzini
On 16/10/2015 09:07, Denis V. Lunev wrote: > > + /* KVM_EXIT_HYPERV */ > +struct kvm_hyperv_exit hyperv; > +Indicates that the VCPU exits into userspace to process some tasks > +related with Hyper-V emulation. Currently used to synchronize modified > +Hyper-V SynIC

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-16 Thread Markus Armbruster
vale...@aimale.com writes: > All- > > I've produced a patch for the current QEMU HEAD, for libvmi to > introspect QEMU/KVM VMs. > > Libvmi has patches for the old qeum-kvm fork, inside its source tree: > https://github.com/libvmi/libvmi/tree/master/tools/qemu-kvm-patch > > This patch adds a hmp

[Qemu-devel] [PATCH 4/9] kvm/irqchip: allow only multiple irqchip routes per GSI

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin Any other irq routing types (MSI, S390_ADAPTER, upcoming Hyper-V SynIC) map one-to-one to GSI. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH 5/9] kvm/irqchip: kvm_arch_irq_routing_update renaming split

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin Actually kvm_arch_irq_routing_update() should be kvm_arch_post_irq_routing_update() as it's called at the end of irq routing update. This renaming frees kvm_arch_irq_routing_update function name. kvm_arch_irq_routing_update() weak function which

[Qemu-devel] [PATCH 3/9] kvm/eventfd: add arch-specific set_irq

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin Allow for arch-specific interrupt types to be set. For that, add kvm_arch_set_irq() which takes interrupt type-specific action if it recognizes the interrupt type given, and -EWOULDBLOCK otherwise. The default implementation always returns

[Qemu-devel] [PATCH 2/9] kvm/eventfd: factor out kvm_notify_acked_gsi()

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin Factor out kvm_notify_acked_gsi() helper to iterate over EOI listeners and notify those matching the given gsi. It will be reused in the upcoming Hyper-V SynIC implementation. Signed-off-by: Andrey Smetanin Reviewed-by:

[Qemu-devel] [PATCH 3/3] vhost-user-test: add multiple queue test

2015-10-16 Thread Yuanhan Liu
Setting VHOST_USER_PROTOCOL_F_MQ protocol feature bit to claim that we support MQ feature, and simply assume we support 2 queue pairs at most. Cc: Michael S. Tsirkin Cc: Jason Wang Signed-off-by: Yuanhan Liu ---

Re: [Qemu-devel] [PATCH 1/3] log: improve performance of qemu_log and qemu_log_mask if disabled

2015-10-16 Thread Denis V. Lunev
On 10/16/2015 10:17 AM, Markus Armbruster wrote: "Denis V. Lunev" writes: The patch is intended to avoid to perform any operation including calculation of log function arguments when the log is not enabled due to various reasons. Functions qemu_log and qemu_log_mask are

[Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin A new vcpu exit is introduced to notify the userspace of the changes in Hyper-V SynIC configuration triggered by guest writing to the corresponding MSRs. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan

[Qemu-devel] [PATCH 7/9] kvm/x86: split ioapic-handled and EOI exit bitmaps

2015-10-16 Thread Denis V. Lunev
From: Andrey Smetanin The function to determine if the vector is handled by ioapic used to rely on the fact that only ioapic-handled vectors were set up to cause vmexits when virtual apic was in use. We're going to break this assumption when introducing Hyper-V

Re: [Qemu-devel] [PATCH] kvm: Move x86-specific functions into target-i386/kvm.c

2015-10-16 Thread Paolo Bonzini
On 15/10/2015 20:30, Thomas Huth wrote: > The functions for checking xcrs, xsave and pit_state2 are > only used on x86, so they should reside in target-i386/kvm.c. > > Signed-off-by: Thomas Huth > --- > include/sysemu/kvm.h | 2 -- > kvm-all.c| 29

Re: [Qemu-devel] [PATCH 3/3] vhost-user-test: add multiple queue test

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 03:19:01PM +0800, Yuanhan Liu wrote: > Setting VHOST_USER_PROTOCOL_F_MQ protocol feature bit to claim that we > support MQ feature, and simply assume we support 2 queue pairs at most. Well - let's add a macro, or something? > > Cc: Michael S. Tsirkin >

Re: [Qemu-devel] [PATCH 3/3] log: adds a timestamp to each log entry

2015-10-16 Thread Markus Armbruster
"Denis V. Lunev" writes: > From: Pavel Butsykin > > This patch is written as an addition to the previous one with logging of > QPM commands. This information (the moment of the event) is very useful > to match guest problems with actions performing by

Re: [Qemu-devel] [PATCH v8 03/11] block: never cancel a streaming job without running stream_complete()

2015-10-16 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 12:32:18AM +0300, Alberto Garcia wrote: > We need to call stream_complete() in order to do all the necessary > clean-ups, even if there's an early failure. At the moment it's only > useful to make sure that s->backing_file_str is not leaked, but it > will become more

Re: [Qemu-devel] [PATCH v5 3/4] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt

2015-10-16 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 05:51:17PM +0200, Knut Omang wrote: > Add a small intro + minimal documentation for how to > implement SR/IOV support for an emulated device. I worry that we won't keep this up to date as code changes. Could some or all of this go into comments in relevant headers? >

Re: [Qemu-devel] [PATCH] virtio-blk: switch off scsi-passthrough by default

2015-10-16 Thread Paolo Bonzini
On 16/10/2015 10:41, Paolo Bonzini wrote: > > > On 16/10/2015 10:40, Cornelia Huck wrote: >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -272,6 +272,10 @@ static const TypeInfo ccw_machine_info = { >> .driver = "vhost-scsi-ccw",\ >>

[Qemu-devel] [PULL 6/7] pc-dimm: add vhost slots limit check before commiting to hotplug

2015-10-16 Thread Michael S. Tsirkin
From: Igor Mammedov it allows safely cancel memory hotplug if vhost backend doesn't support necessary amount of memory slots and prevents QEMU crashing in vhost due to hitting vhost limit on amount of supported memory ranges. Signed-off-by: Igor Mammedov

[Qemu-devel] [PULL 2/7] exec: factor out duplicate mmap code

2015-10-16 Thread Michael S. Tsirkin
Anonymous and file-backed RAM allocation are now almost exactly the same. Reduce code duplication by moving RAM mmap code out of oslib-posix.c and exec.c. Reported-by: Marc-André Lureau Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini

[Qemu-devel] [PULL 4/7] tests: re-enable vhost-user-test

2015-10-16 Thread Michael S. Tsirkin
From: Marc-André Lureau Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, since CONFIG_VHOST_NET is a per-target config variable. tests/vhost-user-test is already x86/64 softmmu specific test, in order to enable it correctly, kvm & vhost-net are also

[Qemu-devel] [PULL 12/49] target-i386/kvm: Hyper-V HV_X64_MSR_VP_RUNTIME support

2015-10-16 Thread Paolo Bonzini
From: Andrey Smetanin HV_X64_MSR_VP_RUNTIME msr used by guest to get "the time the virtual processor consumes running guest code, and the time the associated logical processor spends running hypervisor code on behalf of that guest." Calculation of that time is performed

[Qemu-devel] [PULL 08/49] checkpatch: allow open braces on typedef lines

2015-10-16 Thread Paolo Bonzini
The style here seems to be split according to the maintainer, but traditionally open braces were placed on typedef lines. Suggested-by: Peter Maydell Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 5 - 1 file changed, 5 deletions(-)

[Qemu-devel] [PULL 32/49] qemu-char: convert pty backend to data-driven creation

2015-10-16 Thread Paolo Bonzini
Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- qemu-char.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4f9bd14..9adf2cc 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1390,7

[Qemu-devel] [PULL 24/49] qemu-char: cleanup HAVE_CHARDEV_*

2015-10-16 Thread Paolo Bonzini
Move the #ifdef up into qmp_chardev_add, and avoid duplicating the code that reports unavailable backends. Split HAVE_CHARDEV_TTY into HAVE_CHARDEV_SERIAL and HAVE_CHARDEV_PTY. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- qemu-char.c | 24

[Qemu-devel] [PULL 18/49] MAINTAINERS: Add more pxa2xx files and boards

2015-10-16 Thread Paolo Bonzini
Cc: Peter Maydell Cc: Andrzej Zaborowski Signed-off-by: Paolo Bonzini --- MAINTAINERS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5c52ae0..f22f88f 100644 ---

[Qemu-devel] [PULL 43/49] qemu-char: cleanup after completed conversion to cd->create

2015-10-16 Thread Paolo Bonzini
All backends now return errors through Error*, so the "Failed to create chardev" placeholder error can only be reached if the backend is not available (and only from the chardev-add QMP command; instead, the -chardev command line option fails earlier). Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v6 0/4] qapi: child add/delete support

2015-10-16 Thread Wen Congyang
If quorum's child is broken, we can use mirror job to replace it. But sometimes, the user only need to remove the broken child, and add it later when the problem is fixed. It is based on the Kevin's bdrv_swap() related patch: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02152.html

[Qemu-devel] [PATCH v6 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-16 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 6 +++--- block/quorum.c| 59 +--

Re: [Qemu-devel] [Xen-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
On Fri, 16 Oct 2015, Laszlo Ersek wrote: > On 10/16/15 11:06, Stefano Stabellini wrote: > > On Thu, 15 Oct 2015, Kevin O'Connor wrote: > >> On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: > >>> On 10/14/15 13:27, Ian Campbell wrote: > On Wed, 2015-10-14 at 12:06 +0100, Stefano

[Qemu-devel] [PULL 2/3] ui/cocoa.m: addRemovableDevicesMenuItems() warning fix

2015-10-16 Thread Peter Maydell
From: John Arbuckle Eliminate this warning associated with the addRemovableDevicesMenuItems() function: ui/cocoa.m:1344:13: warning: function declaration isn't a prototype [-Wstrict-prototypes] static void addRemovableDevicesMenuItems() ^ ui/cocoa.m: In

[Qemu-devel] [PATCH v3 10/12] block: Introduce BlockDriver.bdrv_drain callback

2015-10-16 Thread Fam Zheng
Drivers can have internal request sources that generate IO, like the need_check_timer in QED. Since we want quiesced periods that contain nested event loops in block layer, we need to have a way to disable such event sources. Block drivers must implement the "bdrv_drain" callback if it has any

[Qemu-devel] [PATCH v3 01/12] aio: Add "is_external" flag for event handlers

2015-10-16 Thread Fam Zheng
All callers pass in false, and the real external ones will switch to true in coming patches. Signed-off-by: Fam Zheng --- aio-posix.c | 6 - aio-win32.c | 5 async.c | 3 ++- block/curl.c

[Qemu-devel] [PATCH v3 09/12] block: Add "drained begin/end" for internal snapshot

2015-10-16 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. state->bs is assigned right after bdrv_drained_begin. Because it was used as the flag for deletion or not in abort, now we need a separate flag - InternalSnapshotState.created.

[Qemu-devel] [PULL 0/3] cocoa queue

2015-10-16 Thread Peter Maydell
at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20151016 for you to fetch changes up to 468a895bce1492cf83bb8be0d995ccdfcf4f2785: ui/cocoa.m: blinky mouse cursor fix (2015-10-16 11:06:19 +0100) cocoa

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix memory leak in early exit

2015-10-16 Thread Stefan Hajnoczi
On Fri, Oct 16, 2015 at 08:58:12AM +0200, Alberto Garcia wrote: > On Thu 15 Oct 2015 05:54:27 PM CEST, Stefan Hajnoczi > wrote: > > The stream block job has two early exit code paths. They do not free > > s->backing_file_str. > > > > Also, the early exits rely on the fact

[Qemu-devel] [PULL 02/49] scsi: switch from g_slice allocator to malloc

2015-10-16 Thread Paolo Bonzini
Simplify memory allocation by sticking with a single API. GSlice is not that fast anyway (tcmalloc/jemalloc are better). Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 4 ++-- hw/scsi/virtio-scsi-dataplane.c | 10 +- hw/scsi/virtio-scsi.c

[Qemu-devel] [PULL 19/49] MAINTAINERS: Add maintainer for ARM PrimeCell and integrated devices

2015-10-16 Thread Paolo Bonzini
Cc: Peter Maydell Signed-off-by: Paolo Bonzini --- MAINTAINERS | 30 ++ 1 file changed, 30 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f22f88f..cb4666a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -292,6

[Qemu-devel] [PULL 16/49] MAINTAINERS: add two devices to the e500 section

2015-10-16 Thread Paolo Bonzini
Cc: Alexander Graf Cc: Scott Wood Signed-off-by: Paolo Bonzini --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9bde832..08896b7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PULL 45/49] kvm: Make KVM_CAP_SIGNAL_MSI globally available

2015-10-16 Thread Paolo Bonzini
From: Pavel Fedin This capability is useful to determine whether we can use KVM ITS emulation on ARM Signed-off-by: Pavel Fedin Message-Id: Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 36/49] qemu-char: convert braille backend to data-driven creation

2015-10-16 Thread Paolo Bonzini
Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- backends/baum.c | 16 +++- include/sysemu/char.h | 3 --- qemu-char.c | 4 +--- stubs/Makefile.objs | 1 - stubs/chr-baum-init.c | 7 --- 5 files changed, 12

[Qemu-devel] [PULL 33/49] qemu-char: convert null backend to data-driven creation

2015-10-16 Thread Paolo Bonzini
Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- qemu-char.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 9adf2cc..a6e97ce 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -383,7 +383,10

[Qemu-devel] [PATCH v6 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-16 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake ---

[Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-10-16 Thread Wen Congyang
The new QMP command name is x-blockdev-change. It justs for adding/removing quorum's child now, and don't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v2] virtio: add some migration doc

2015-10-16 Thread Cornelia Huck
On Wed, 7 Oct 2015 12:39:17 +0200 Cornelia Huck wrote: > On Thu, 17 Sep 2015 18:42:57 +0200 > Cornelia Huck wrote: > > > Try to cover the basics of virtio migration. > > > > Signed-off-by: Cornelia Huck > >

  1   2   3   4   >