Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its

Hello! > I just wanted to understand. I don't have any preferences. In other words, in short: spec says that ITS is optional, so we can implement it as a separate component, which gets attached to the GIC using some specified interface. It's not a problem to design such an interface.

Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its

On 21 October 2015 at 15:41, Pavel Fedin wrote: > Hello! > >> I just wanted to understand. I don't have any preferences. > > In other words, in short: spec says that ITS is optional, so > we can implement it as a separate component, which gets attached > to the GIC using

Re: [Qemu-devel] [PATCH v2 5/5] vhost: send VHOST_USER_SET_VRING_ENABLE at start/stop

On Wed, Oct 21, 2015 at 01:39:11PM +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 05:07:18PM +0800, Yuanhan Liu wrote: > > Send VHOST_USER_SET_VRING_ENABLE at start/stop when multiple queue > > is negotiated, to inform the backend that we are ready or not. > > OK but that's only if MQ

Re: [Qemu-devel] [PATCH v5 09/12] block: Add "drained begin/end" for internal snapshot

Am 21.10.2015 um 04:06 hat Fam Zheng geschrieben: > This ensures the atomicity of the transaction by avoiding processing of > external requests such as those from ioeventfd. > > state->bs is assigned right after bdrv_drained_begin. Because it was > used as the flag for deletion or not in abort,

Re: [Qemu-devel] Coding style for errors

On 10/21/2015 09:03 AM, Lluís Vilanova wrote: > Hi, > > I was wondering what is the proper way (or ways, depending on the subsystem) > of > reporting and signalling errors in QEMU. The coding style file does not seem > to > mention it, and the code uses all kinds of forms for that: > > *

Re: [Qemu-devel] [PULL 00/38] vhost, pc, virtio features, fixes, cleanups

On 21 October 2015 at 11:26, Michael S. Tsirkin wrote: > The following changes since commit 6d57410a79d51d92673c54f26624b44f27fa6214: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20151016' into staging (2015-10-17 > 12:31:33 +0100) > > are

Re: [Qemu-devel] [PATCH] QEMU patch for libvmi to introspect QEMU/kvm virtual machines. Usually this patch is distributed with libvmi, but, it might be more useful to have it in the QEMU source perman

Eric, thanks for your comments. I'm going to take the liberty to top posts some notes. On grammar awkwardness, indentation, documentation, and coding style. I agree with you. Mea culpa. I take full responsibility. I was too eager to submit the patch. I'll be less eager in the future. If and

Re: [Qemu-devel] [PATCH v5 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end

Am 21.10.2015 um 04:06 hat Fam Zheng geschrieben: > v5: Rebase onto Kevin's block tree. > > v4: Rebase on to master so fix the "bdrv_move_feature_fields" issue. > > v3: Call bdrv_drain unconditionally in bdrv_drained_begin. > Document the internal I/O implications between bdrv_drain_begin

[Qemu-devel] [PULL v2 8/9] s390x: reset crypto only on clear reset and QEMU reset

From: David Hildenbrand Initializing VM crypto in initial cpu reset has multiple problems 1. We call the exact same function #VCPU times, although one time is enough 2. On SIGP initial cpu reset, we exchange the wrapping key while other VCPUs are running. Bad! 3. It

[Qemu-devel] [Bug 1508405] [NEW] qemu 2.4.0 with --enable-kvm hangs, takes 100% CPU

Public bug reported: When starting qemu-system-x86_64 from version 2.4.0 with --enable-kvm, it hangs and takes 100% CPU. The graphical display (SeaBIOS output) is not initialized. There have been multiple reports of this issue in the following thread:

Re: [Qemu-devel] [RFC PATCH V7 00/19] Multithread TCG.

On 07.10.2015 16:52, Frederic Konrad wrote: > Hi Claudio, > > I'll rebase soon tomorrow with a bit of luck ;). > > Thanks, > Fred a respectful ping on this one :-) I am looking at http://git.greensocs.com/fkonrad/mttcg.git branch multi_tcg_v7_bugfixed, is there something new? Ciao, Claudio

[Qemu-devel] [PATCH QEMU-XEN v4 6/9] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API.

In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenforeignmemory which provides access to privileged foreign mappings and which will provide an interface equivalent to

[Qemu-devel] [PATCH QEMU-XEN v4 7/9] xen: Use stable library interfaces when they are available.

In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. Specifically libxenevtchn, libxengnttab and libxenforeignmemory. Previous patches have already laid the groundwork for using these by switching the

Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium

On 21.10.2015 13:49, Alberto Garcia wrote: > On Mon 19 Oct 2015 05:53:37 PM CEST, Max Reitz wrote: >> And a helper function for that, which directly takes a pointer to the >> BDS to be inserted instead of its node-name (which will be used for >> implementing 'change' using blockdev-insert-medium).

Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its

Hello! >> Or do you have some explicit reasons to have everything as a monolith? > No I just didn't want to have 3 stub files spi, its and its_control. > Do you suggest that I'll split it to 3 files? You didn't understand my question. It's not about internal structure of ITS implementation.

Re: [Qemu-devel] [PATCH v2 1/5] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

On Wed, Oct 21, 2015 at 09:04:17PM +0800, Yuanhan Liu wrote: > On Wed, Oct 21, 2015 at 01:40:59PM +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 21, 2015 at 05:07:14PM +0800, Yuanhan Liu wrote: > > > This reverts commit d1f8b30ec8dde0318fd1b98d24a64926feae9625. > > > > > > It turned out that it

[Qemu-devel] [PULL 35/38] piix: fix resource leak reported by Coverity

From: zhanghailiang config_fd should be closed before return, or there will be a resource leak error. Signed-off-by: zhanghailiang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 4/9] s390x: flagify mcic values

Instead of using magic values when building the machine check interruption code, add some defines as by chapter 11-14 in the PoP. This should make it easier to catch problems like the missing vector register validity bit ("s390x/kvm: Fix vector validity bit in device machine checks"), and less

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

On Wednesday, October 21, 2015, Peter Maydell wrote: > On 21 October 2015 at 12:33, Shlomo Pongratz > wrote: > > I assume I can add the system registers to target-arm/cpu.c but I wonder > if > > someone really needs to simulate

[Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path]

it will be quite messy to have colliding names for variables, so to maintain better readability and make it consistent with other existing code as well as the input keys/options which will be introduced by next couple of patches, this patch renames the following variables 'server' -> 'host'

Re: [Qemu-devel] [PATCH v7 27/39] block: Add blk_remove_bs()

On 20.10.2015 10:33, Kevin Wolf wrote: > Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: >> This function removes the BlockDriverState associated with the given >> BlockBackend from that BB and sets the BDS pointer in the BB to NULL. >> >> Signed-off-by: Max Reitz >> --- >>

[Qemu-devel] [PATCH v2 2/3] block/gluster: code cleanup

unified coding styles of multiline function arguments and other error functions moved random declarations of structures and other list variables Signed-off-by: Prasanna Kumar Kalever --- block/gluster.c | 113 ++--

Re: [Qemu-devel] [PATCH v2 5/5] vhost: send VHOST_USER_SET_VRING_ENABLE at start/stop

On Wed, Oct 21, 2015 at 10:55:39PM +0800, Yuanhan Liu wrote: > On Wed, Oct 21, 2015 at 05:11:44PM +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 21, 2015 at 09:43:16PM +0800, Yuanhan Liu wrote: > > > On Wed, Oct 21, 2015 at 01:39:11PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Oct 21, 2015

[Qemu-devel] Coding style for errors

Hi, I was wondering what is the proper way (or ways, depending on the subsystem) of reporting and signalling errors in QEMU. The coding style file does not seem to mention it, and the code uses all kinds of forms for that: * printf + exit(1) * fprintf(stderr) + exit(1) * error_report + exit(1) *

Re: [Qemu-devel] [PATCH v2 2/3] block/gluster: code cleanup

On 10/21/2015 07:34 AM, Prasanna Kumar Kalever wrote: > unified coding styles of multiline function arguments and other error > functions > moved random declarations of structures and other list variables > > Signed-off-by: Prasanna Kumar Kalever > --- >

[Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims.

In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxengnttab which provides access to grant tables. In preparation for this switch the compatibility layer in xen_common.h

Re: [Qemu-devel] [PATCH 00/40] Patch Round-up for stable 2.4.1, freeze on 2015-10-29

On 10/21/2015 01:51 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.4.1: > > https://github.com/mdroth/qemu/commits/stable-2.4-staging > > The release is planned for 2015-11-03: > > http://wiki.qemu.org/Planning/2.4 > > Please respond

[Qemu-devel] [PULL 02/10] tcg/ppc: Revise goto_tb implementation

Restrict the size of code_gen_buffer to 2GB on ppc64, which lets us assert that everything is reachable with addis+addi from tb_ret_addr. This lets us use a max of 4 insns for goto_tb instead of 7. Emit the indirect branch portion of goto_tb up front, which means we only have to update two insns

[Qemu-devel] [PATCH 04/40] block/iscsi: validate block size returned from target

From: Peter Lieven It has been reported that at least tgtd returns a block size of 0 for LUN 0. To avoid running into divide by zero later on and protect against other problematic block sizes validate the block size right at connection time. Cc: qemu-sta...@nongnu.org Reported-by:

[Qemu-devel] [PATCH v2 2/2] xen-platform: Replace assert() with appropriate error reporting

Commit dbb7405d8caad0814ceddd568cb49f163a847561 made it possible to trigger an assert using "-device xen-platform". Replace it with appropriate error reporting. Before: $ qemu-system-x86_64 -device xen-platform qemu-system-x86_64: hw/i386/xen/xen_platform.c:391: xen_platform_initfn:

[Qemu-devel] [PULL 10/10] cpu-exec: Add "nochain" debug flag

Respect it to avoid linking TBs together. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- cpu-exec.c | 3 ++- include/qemu/log.h | 1 + qemu-log.c | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH] throttle: Remove throttle_group_lock/unlock()

The group throttling code was always meant to handle its locking internally. However, bdrv_swap() was touching the ThrottleGroup structure directly and therefore needed an API for that. Now that bdrv_swap() no longer exists there's no need for the throttle_group_lock() API anymore.

Re: [Qemu-devel] [PATCH v2 08/16] io: add abstract QIOChannel classes

On 10/21/2015 11:32 AM, Daniel P. Berrange wrote: > >>> +/** >>> + * qio_channel_seek: >>> + * @ioc: the channel object >>> + * @offset: the position to seek to, relative to @whence >>> + * @whence: one of the POSIX SEEK_* constants >> >> Including SEEK_HOLE/SEEK_DATA? > > Are those actually

[Qemu-devel] [PATCH 40/40] virtio-input: ignore events until the guest driver is ready

From: Gerd Hoffmann Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann (cherry picked from commit d9460a7557672af9c4d9d4f153200d1075ed5a78) Signed-off-by: Michael Roth --- hw/input/virtio-input.c | 4 1 file changed, 4

[Qemu-devel] [PATCH 07/40] qemu-img: Fix crash in amend invocation

From: Max Reitz Example: $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ /tmp/t.qcow2 This should not crash. This actually is tested by iotest 082, but not caught due to the segmentation fault being silent

[Qemu-devel] [PULL v2 6/9] s390x/ipl: we always have an ipl device

From: David Hildenbrand Both s390 machines unconditionally create an ipl device, so no need to handle the missing case. Now we can also change s390_ipl_update_diag308() to return void. Reviewed-by: Cornelia Huck Acked-by: Christian

[Qemu-devel] [PULL 07/10] tcg/mips: Support r6 JR encoding

From: James Hogan MIPSr6 encodes JR as JALR with zero as the link register, and the pre-r6 JR encoding is removed. Update TCG to use the new encoding when built for r6. We still use the old encoding for pre-r6, so as not to confuse return prediction stack hardware which

Re: [Qemu-devel] Coding style for errors

On 21 October 2015 at 17:48, Markus Armbruster wrote: > Lluís Vilanova writes: > >> Hi, >> >> I was wondering what is the proper way (or ways, depending on the subsystem) >> of >> reporting and signalling errors in QEMU. The coding style file does not

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

On Wed, Oct 21, 2015 at 11:49:13AM +0200, Paolo Bonzini wrote: > > > On 20/10/2015 20:14, Laszlo Ersek wrote: > > Commit 4d00636e97b7 ("ich9: Add the lpc chip", Nov 14 2012) added the > > ich9_apm_ctrl_changed() ioport write callback function such that it would > > inject the SMI, in response to

[Qemu-devel] [RFC Patch 06/12] IXGBEVF: Add self emulation layer

In order to restore VF function after migration, add self emulation layer to record regs' values during accessing regs. Signed-off-by: Lan Tianyu --- drivers/net/ethernet/intel/ixgbevf/Makefile| 3 ++- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-

[Qemu-devel] [PATCH 08/40] mac_dbdma: always clear FLUSH bit once DBDMA channel flush is complete

From: Mark Cave-Ayland The code to flush the DBDMA channel was effectively duplicated in dbdma_control_write(), except for the fact that the copy executed outside of a RUN bit transition was broken by not clearing the FLUSH bit once the flush was complete. Newer

Re: [Qemu-devel] [PATCH v2 4/5] Revert "vhost-user: Send VHOST_RESET_OWNER on vhost stop"

On Wed, Oct 21, 2015 at 05:07:17PM +0800, Yuanhan Liu wrote: > Don't send VHOST_RESET_OWNER, for as Michael stated: > > Because we need to get the state from remote after stop. > RESET_OWNER discards that, so we can't resume the VM. > > This reverts commit

Re: [Qemu-devel] [RFC Patch 09/12] IXGBEVF: Add live migration support for VF driver

On 10/21/2015 09:37 AM, Lan Tianyu wrote: To let VF driver in the guest to know migration status, Qemu will fake PCI configure reg 0xF0 and 0xF1 to show migrate status and get ack from VF driver. When migration starts, Qemu will set reg "0xF0" to 1, notify VF driver via triggering mail box msg

[Qemu-devel] [RFC Patch 12/12] IXGBEVF: Track dma dirty pages

Migration relies on tracking dirty page to migrate memory. Hardware can't automatically mark a page as dirty after DMA memory access. VF descriptor rings and data buffers are modified by hardware when receive and transmit data. To track such dirty memory manually, do dummy writes(read a byte and

Re: [Qemu-devel] [Qemu-block] [PATCH v5 11/12] qed: Implement .bdrv_drain

On Wed, 10/21 22:20, Jeff Cody wrote: > On Wed, Oct 21, 2015 at 10:06:48AM +0800, Fam Zheng wrote: > > The "need_check_timer" is used to clear the "NEED_CHECK" flag in the > > image header after a grace period once metadata update has finished. In > > compliance to the bdrv_drain semantics we

[Qemu-devel] [PATCH 31/40] virtio-net: unbreak self announcement and guest offloads after migration

From: Jason Wang After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make features 64bit wide"). Device's guest_features was actually set after vdc->load(). This breaks the assumption that device specific load() function can check guest_features. For virtio-net,

[Qemu-devel] [PATCH 39/40] Migration: Generate the completed event only when we complete

From: "Dr. David Alan Gilbert" The current migration-completed event is generated a bit too early, which means that an eager libvirt that's ready to go as soon as it sees the event ends up racing with the actual end of migration. This corresponds to RH bug:

Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external

On Wed, 10/21 11:56, Jeff Cody wrote: > > +static inline bool aio_node_check(AioContext *ctx, bool is_external) > > +{ > > +return !is_external || !atomic_read(>external_disable_cnt); > > +} > > + > > It seems a little odd to me to have this helper function take the > is_external bool field

[Qemu-devel] [PATCH 36/40] misc: zynq_slcr: Fix MMIO writes

From: Peter Crosthwaite The /4 for offset calculation in MMIO writes was happening twice giving wrong write offsets. Fix. While touching the code, change the if-else to be a short returning if and convert the debug message to a GUEST_ERROR, which is more accurate for

[Qemu-devel] [PATCH v1 1/5] sockets: remove use of QemuOpts from header file

There are no callers of the sockets methods which accept QemuOpts any more. Make all the QemuOpts related functions static to avoid new callers being added, in preparation for removal of all QemuOpts usage, in favour of QAPI SocketAddress. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external

On Thu, Oct 22, 2015 at 10:11:16AM +0800, Fam Zheng wrote: > On Wed, 10/21 11:56, Jeff Cody wrote: > > > +static inline bool aio_node_check(AioContext *ctx, bool is_external) > > > +{ > > > +return !is_external || !atomic_read(>external_disable_cnt); > > > +} > > > + > > > > It seems a little

Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

On Wed, Oct 21, 2015 at 05:21:40PM +0800, Yuanhan Liu wrote: > On Wed, Oct 21, 2015 at 12:15:52PM +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 21, 2015 at 04:55:16PM +0800, Yuanhan Liu wrote: > > > On Fri, Oct 16, 2015 at 10:47:49AM +0300, Michael S. Tsirkin wrote: > > > > On Fri, Oct 16, 2015

Re: [Qemu-devel] [PATCH v2 4/5] Revert "vhost-user: Send VHOST_RESET_OWNER on vhost stop"

On Wed, Oct 21, 2015 at 05:07:17PM +0800, Yuanhan Liu wrote: > Don't send VHOST_RESET_OWNER, for as Michael stated: > > Because we need to get the state from remote after stop. > RESET_OWNER discards that, so we can't resume the VM. > > This reverts commit

[Qemu-devel] [PULL v2 1/9] util/qemu-config: fix missing machine command line options

From: Tony Krowiak Commit 0a7cf217 ("util/qemu-config: fix regression of qmp_query_command_line_options") aimed to restore parsing of global machine options, but missed two: "aes-key-wrap" and "dea-key-wrap" (which were present in the initial version of that patch).

[Qemu-devel] [PATCH 18/40] qcow2: Make size_to_clusters() return uint64_t

From: Max Reitz Sadly, some images may have more clusters than what can be represented using a plain int. We should be prepared for that case (in qcow2_check_refcounts() we actually were trying to catch that case, but since size_to_clusters() truncated the returned value, that

[Qemu-devel] [PATCH v2 0/2] xen-platform: Replace assert() with appropriate error reporting

New version, now using PCIDeviceClass::realize. Eduardo Habkost (1): xen-platform: Replace assert() with appropriate error reporting Stefano Stabellini (1): xen_platform: switch to realize hw/i386/xen/xen_platform.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) --

Re: [Qemu-devel] [PATCH 4/4] mips: add gic support to malta

On 16/10/15 00:52, Yongbok Kim wrote: > /* > * We have a circular dependency problem: pci_bus depends on isa_irq, > * isa_irq is provided by i8259, i8259 depends on ISA, ISA depends > @@ -1155,7 +1218,11 @@ void mips_malta_init(MachineState *machine) > > /* Interrupt

Re: [Qemu-devel] [PATCH v1 2/5] sockets: remove use of QemuOpts from socket_listen

On 21/10/2015 17:43, Daniel P. Berrange wrote: > +} > +if (addr->has_ipv6 && addr->ipv6) { > +g_printerr("One\n"); > +return PF_INET6; > +} > +if (addr->has_ipv4 && addr->ipv4) { > +g_printerr("Two\n"); > +return PF_INET; > +} > +if

Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its

Hi, I just added a placeholder, I didn't add any functionality. On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > > This patch includes a placeholder code for future spi and its > > implementation. > > Forgot to comment on this. I see that here you are

[Qemu-devel] [PATCH QEMU-XEN v4 8/9] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher.

Using an existing libxenctrl handle after a fork was never particularly safe (especially if foreign mappings existed at the time of the fork) and the xc fd has been unavailable for many releases. Reopen the handle after fork and therefore do away with xc_fd(). Signed-off-by: Ian Campbell

Re: [Qemu-devel] [PATCH 0/4] mips: add Global Interrupt Controller

On 21/10/2015 17:01, Peter Maydell wrote: > On 16 October 2015 at 00:52, Yongbok Kim wrote: >> Add support of MIPS GIC. >> >> hw/mips/Makefile.objs|2 +- >> hw/mips/mips_gcr.c | 120 >> hw/mips/mips_gcr.h | 57 >>

Re: [Qemu-devel] [PATCH v1 2/5] sockets: remove use of QemuOpts from socket_listen

On Wed, Oct 21, 2015 at 05:54:11PM +0200, Paolo Bonzini wrote: > > > On 21/10/2015 17:43, Daniel P. Berrange wrote: > > +} > > +if (addr->has_ipv6 && addr->ipv6) { > > +g_printerr("One\n"); > > +return PF_INET6; > > +} > > +if (addr->has_ipv4 && addr->ipv4) { > >

[Qemu-devel] [PATCH v2 1/2] xen_platform: switch to realize

From: Stefano Stabellini Use realize to initialize the xen_platform device Signed-off-by: Stefano Stabellini Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Remove useless return * Suggested-by:

Re: [Qemu-devel] [PULL v2 0/9] Next set of s390x patches

/tags/pull-input-20151020-1' > into staging (2015-10-20 12:56:45 +0100) > > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20151021-v2 > > for you to fetch changes up to 1cd4e0f6f0a6b1978a5868b41d4faae2071dc4ee: > > s390

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

O.K. On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > >> The system register implementation belongs in the gic code, not > >> target-arm/. We already have support for devices that say > >> "I have some system registers, please add them to this CPU". > > > I

[Qemu-devel] [PATCH QEMU-XEN v4 1/9] xen_console: correctly cleanup primary console on teardown.

All of the work in con_disconnect applies to the primary console case (when xendev->dev is NULL). Therefore remove the early check and bail and allow it to fall through. All of the existing code is correctly conditional already. The ->dev and ->gnttabdev handles are either both set or neither.

Re: [Qemu-devel] Coding style for errors

Lluís Vilanova writes: > Hi, > > I was wondering what is the proper way (or ways, depending on the subsystem) > of > reporting and signalling errors in QEMU. The coding style file does not seem > to > mention it, and the code uses all kinds of forms for that: > > * printf

[Qemu-devel] [RFC Patch 03/12] IXGBE: Add sysfs interface for Qemu to migrate VF status in the PF driver

This patch is to add sysfs interface state_in_pf under sysfs directory of VF PCI device for Qemu to get and put VF status in the PF driver during migration. Signed-off-by: Lan Tianyu --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 156 - 1 file

[Qemu-devel] [PATCH v1 2/5] sockets: remove use of QemuOpts from socket_listen

The socket_listen method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_listen_opts/unix_listen_opts helper methods. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminated Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v1 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off

The VNC code for interpreting QemuOpts does not currently distinguish between ipv4/ipv6 being omitted, and being set to 'off', because historically the 'ipv4' and 'ipv6' options were just flags which did not accept a value. The upshot is that if someone runs $QEMU -vnc localhost:1,ipv6=off

Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external

On Wed, Oct 21, 2015 at 10:06:41AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > aio-posix.c | 3 ++- > aio-win32.c | 3 ++- > include/block/aio.h | 37 + > 3 files changed, 41 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [Qemu-block] [PATCH v5 05/12] block: Introduce "drained begin/end" API

On Wed, Oct 21, 2015 at 10:06:42AM +0800, Fam Zheng wrote: > The semantics is that after bdrv_drained_begin(bs), bs will not get new > external > requests until the matching bdrv_drained_end(bs). > > Signed-off-by: Fam Zheng > --- > block/io.c| 17

Re: [Qemu-devel] [PATCH v2 1/5] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE"

On Wed, Oct 21, 2015 at 05:13:49PM +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 09:04:17PM +0800, Yuanhan Liu wrote: > > On Wed, Oct 21, 2015 at 01:40:59PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Oct 21, 2015 at 05:07:14PM +0800, Yuanhan Liu wrote: > > > > This reverts commit

Re: [Qemu-devel] [Qemu-stable] [PATCH] util/qemu-config: fix missing machine command line options

Quoting Tony Krowiak (2015-10-12 10:34:00) > Commit 0a7cf217 ("util/qemu-config: fix regression of > qmp_query_command_line_options") aimed to restore parsing of global > machine options, but missed two: "aes-key-wrap" and > "dea-key-wrap" (which were present in the initial version of that >

Re: [Qemu-devel] [PATCH 0/4] mips: add Global Interrupt Controller

On Thu, Oct 15, 2015 at 4:52 PM, Yongbok Kim wrote: > Add support of MIPS GIC. > The patchset implements the Global Interrupt Controller. > > With the patchset Linux Kernel detects GIC and utilises it. > # cat /proc/interrupts >CPU0 > 0: 2XT-PIC

[Qemu-devel] [PATCH QEMU-XEN v4 2/9] xen: Switch to libxenevtchn interface for compat shims.

In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenevtchn which provides access to event channels. In preparation for this switch the compatibility layer in

Re: [Qemu-devel] [PATCH 3/4] mips: add Global Interrupt Controller

On 16/10/15 00:52, Yongbok Kim wrote: > The Global Interrupt Controller (GIC) is responsible for mapping each > internal and external interrupt to the correct location for servicing. > > Limitations: > Level triggering only > No User-Mode Visible Section > GIC CounterHi not implemented (Countbits

Re: [Qemu-devel] [PATCH 0/4] mips: add Global Interrupt Controller

On 16 October 2015 at 00:52, Yongbok Kim wrote: > Add support of MIPS GIC. > The patchset implements the Global Interrupt Controller. > > With the patchset Linux Kernel detects GIC and utilises it. > # cat /proc/interrupts >CPU0 > 0: 2XT-PIC 0

Re: [Qemu-devel] qemu-guest-agent question

Quoting Vasiliy Tolstov (2015-10-19 08:41:35) > I'm try to understand sources of qga and have a question- does agent > execute commands synchronous or if i'm send firstly long running > command and after that send short lived command, short lived command > response can be sended before first

[Qemu-devel] [Bug 1323758] Re: Mouse stops working when connected usb-storage-device

** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323758 Title: Mouse stops working when connected usb-storage-device Status in QEMU:

[Qemu-devel] [RFC PATCH 3/3] Qemu: Introduce pci-sriov device type to support VF live migration

This patch is to migrate VF status during migration between source and target machine. There are three kinds of VF status involved. 1) PCI configure space regs 2) MSIX configure 3) VF status in the PF driver The PCI configure space regs and MSIX configure are originally stored in Qemu. VF

[Qemu-devel] [RFC PATCH 2/3] Qemu: Add post_load_state() to run after restoring CPU state

After migration, Qemu needs to trigger mailbox irq to notify VF driver in the guest about status change. The irq delivery restarts to work after restoring CPU state. This patch is to add new callback to run after restoring CPU state and provide a way to trigger mailbox irq later. Signed-off-by:

[Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

Until the previous patch this relied on xc_fd(), which was only implemented for Xen 4.0 and earlier. Given this wasn't working since Xen 4.0 I have marked this as disabled by default. Removing this support drops the use of a bunch of symbols from libxenctrl, specifically: - xc_domain_create

Re: [Qemu-devel] qemu-guest-agent question

Quoting Michael Roth (2015-10-21 10:10:40) > Quoting Vasiliy Tolstov (2015-10-19 08:41:35) > > I'm try to understand sources of qga and have a question- does agent > > execute commands synchronous or if i'm send firstly long running > > command and after that send short lived command, short

[Qemu-devel] [PATCH QEMU-XEN v4 0/9] Begin to disentangle libxenctrl and provide some stable libraries

We intend to stabilise some parts of the libxenctrl interface by splitting out some functionality into separate stable libraries. This is the qemu-xen part of the first phase of that change. This mail is (or is intended to be) a reply to a "0/" super-intro mail covering all of the related patch

[Qemu-devel] [PULL v2 2/9] s390x/virtio-ccw: fix 2.4 virtio compat

Commit 542571d5 ("virtio-ccw: enable virtio-1") missed some virtio devices for the 2.4 compat handling. Add them. Fixes: 542571d5 ("virtio-ccw: enable virtio-1") Signed-off-by: Cornelia Huck Reviewed-by: Christian Borntraeger ---

[Qemu-devel] [PATCH QEMU-XEN v4 5/9] xen: Switch uses of xc_map_foreign_pages into xc_map_foreign_bulk

In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenforeignmemory which provides access to privileged foreign mappings and which will provide an interface equivalent to

[Qemu-devel] [RFC PATCH 0/3] Qemu/IXGBE: Add live migration support for SRIOV NIC

This patchset is Qemu part for live migration support for SRIOV NIC. kernel part patch information is in the following link. http://marc.info/?l=kvm=144544635330193=2 Lan Tianyu (3): Qemu: Add pci-assign.h to share functions and struct definition with new file Qemu: Add post_load_state()

Re: [Qemu-devel] [Qemu-stable] [PATCH] util/qemu-config: fix missing machine command line options

Quoting Tony Krowiak (2015-10-12 10:34:00) > Commit 0a7cf217 ("util/qemu-config: fix regression of > qmp_query_command_line_options") aimed to restore parsing of global > machine options, but missed two: "aes-key-wrap" and > "dea-key-wrap" (which were present in the initial version of that >

[Qemu-devel] [RFC PATCH 1/3] Qemu: Add pci-assign.h to share functions and struct definition with new file

Signed-off-by: Lan Tianyu --- hw/i386/kvm/pci-assign.c | 111 ++- hw/i386/kvm/pci-assign.h | 109 ++ 2 files changed, 112 insertions(+), 108 deletions(-) create mode 100644

Re: [Qemu-devel] [PATCH v2 5/5] vhost: send VHOST_USER_SET_VRING_ENABLE at start/stop

On Wed, Oct 21, 2015 at 09:43:16PM +0800, Yuanhan Liu wrote: > On Wed, Oct 21, 2015 at 01:39:11PM +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 21, 2015 at 05:07:18PM +0800, Yuanhan Liu wrote: > > > Send VHOST_USER_SET_VRING_ENABLE at start/stop when multiple queue > > > is negotiated, to

Re: [Qemu-devel] [PATCH COLO-Frame v9 00/32] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

Hi, Not something I found on this set; but on your older set, where you have the experimental 'live' ram transfer; we found a test that was slowed down (5x) by the calls to 'colo_need_live_migrate_ram'; even if it decides not to send any RAM in the live phase, the call to

[Qemu-devel] [PATCH v1 0/5] Convert qemu-socket to use QAPI exclusively

All the callers of the qemu-sockets module now use the APIs which take a QAPI SocketAddress. Thus we now have the fun situation with VNC & Chardevs that they use QemuOpts to parse the CLI args, then convert to a SocketAddress, pass it into qemu-sockets which converts it back into a QemuOpts

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

Hello! >> See this: >> http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02349.html. This >> is also a part of my live migration RFC. >> I remember that Peter told long time ago that "it should really be a >> property", when i integrated full affinity support. But, he currently >>

[Qemu-devel] [PATCH 17/40] target-arm: Share all common TCG temporaries

From: Richard Henderson This is a bug fix for aarch64. At present, we have branches using the 32-bit (translate.c) versions of cpu_[NZCV]F, but we set the flags using the 64-bit (translate-a64.c) versions of cpu_[NZCV]F. From the view of the TCG code generator, these are

[Qemu-devel] [PATCH 03/40] target-arm/arm-semi.c: Fix broken SYS_WRITE0 via gdb

From: Peter Maydell A spurious trailing "\n" in the gdb syscall format string used for SYS_WRITE0 meant that gdb would reject the remote syscall, with the effect that the output from the guest was silently dropped. Remove the newline so that gdb accepts the packet. Cc:

[Qemu-devel] Functions to intercept Disk IO information?

Hi, My friends and I were assigned a task to find out a point to insert a callback function to intercept Disk IO activities such as read/write a .txt file. Our final goal is to generate a report for target process/file 's Disk IO activities. We have QEMU 2.3 with KVM enabled. We have been looking

[Qemu-devel] [PATCH 01/40] scsi-disk: Fix assertion failure on WRITE SAME

From: Fam Zheng The last portion of an unaligned WRITE SAME command could fail the assertion in bdrv_aligned_pwritev: assert(!qiov || bytes == qiov->size); Because we updated data->iov.iov_len right above this if block, but data->qiov still has the old size. Reinitialize

[Qemu-devel] [PATCH 20/40] gtk: use setlocale() for LC_MESSAGES only

From: Alberto Garcia The QEMU code is not internationalized and assumes that it runs under the C locale, but if we use the GTK+ UI we'll end up importing the locale settings from the environment. This can break things, such as the JSON generator and iotest 120 in locales that

[Qemu-devel] [PATCH 25/40] qom: Do not reuse errp after a possible error

From: Markus Armbruster The argument for an Error **errp parameter must point to a null pointer. If it doesn't, and an error happens, error_set() fails its assertion. Instead of foo(foos, errp); bar(bars, errp); you need to do something like Error *err = NULL;

  1   2   3   4   >