Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

On 2015-10-23 05:53:17, Laszlo Ersek wrote: > On 10/23/15 09:26, Paolo Bonzini wrote: > > > > On 23/10/2015 06:41, Jordan Justen wrote: > >> On 2015-10-22 12:46:56, Paolo Bonzini wrote: > >>> > >>> On 22/10/2015 20:04, Kevin O'Connor wrote: > On Thu, Oct 22, 2015 at 10:40:08AM +0200, Paolo

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

On Fri, Oct 23, 2015 at 09:25:03AM +0100, Daniel P. Berrange wrote: > On Thu, Oct 22, 2015 at 03:51:28PM -0600, Valerio Aimale wrote: > > On 10/22/15 3:47 PM, Eduardo Habkost wrote: > > >On Thu, Oct 22, 2015 at 01:57:13PM -0600, Valerio Aimale wrote: > > >>On 10/22/15 1:12 PM, Eduardo Habkost

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

Eric Blake writes: > On 10/23/2015 07:46 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> We generate a static visit_type_FOO_fields() for every type >>> FOO. However, sometimes we need a forward declaration. Split >>> the code to generate the

Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE

On Fri, Oct 23, 2015 at 04:40:01PM +0200, Laszlo Ersek wrote: > Eduardo, > > On 10/13/15 21:45, Eduardo Habkost wrote: > > On Tue, Oct 13, 2015 at 09:42:50PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 13/10/2015 21:30, Eduardo Habkost wrote: > >>> Yeah, the shutdown behavior was never

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

On Thu, Oct 22, 2015 at 03:51:28PM -0600, Valerio Aimale wrote: > On 10/22/15 3:47 PM, Eduardo Habkost wrote: > >On Thu, Oct 22, 2015 at 01:57:13PM -0600, Valerio Aimale wrote: > >>On 10/22/15 1:12 PM, Eduardo Habkost wrote: > >>>On Wed, Oct 21, 2015 at 12:54:23PM +0200, Markus Armbruster wrote: >

[Qemu-devel] [PATCH v3 2/3] doc: vhost-user: request naming fix

They are VHOST_USER_XXX instead of VHOST_XXX messages. Also, add VHOST_USER_GET_QUEUE_NUM to the section that requries replies. Cc: Michael S. Tsirkin Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 21 +++-- 1 file

[Qemu-devel] [PATCH v3 0/3] vhost-user mq sequel works

Patch 1 is basically reverts the patch does the rename, as it may break build for VHOST_RESET_OWNER is no longer defined. As Michael stated, reverting it is not enough, we need send it from the right place, and send SET_VRING_ENABLE at start/stop, which is something I will do

[Qemu-devel] [PATCH v3 3/3] vhost-user-test: add multiple queue test

Setting VHOST_USER_PROTOCOL_F_MQ protocol feature bit to claim that we support MQ feature, and simply assume we support 2 queue pairs at most. Cc: Michael S. Tsirkin Cc: Jason Wang Signed-off-by: Yuanhan Liu ---

[Qemu-devel] [PATCH v3 1/3] vhost: rename VHOST_RESET_DEVICE back to VHOST_RESET_OWNER

It turned out that it breaks stuff (VHOST_RESET_OWNER is not defined), so revert it: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html CC: "Michael S. Tsirkin" Reported-by: Paolo Bonzini Signed-off-by: Yuanhan Liu

Re: [Qemu-devel] [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Fri, 2015-10-23 at 11:36 -0700, Alexander Duyck wrote: > On 10/21/2015 09:37 AM, Lan Tianyu wrote: > > This patchset is to propose a new solution to add live migration support > > for 82599 > > SRIOV network card. > > > > Im our solution, we prefer to put all device specific operation into VF

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] prep: do not use CPU_LOG_IOPORT, convert to tracepoints

Am 23.10.2015 um 03:38 schrieb David Gibson: > On Fri, Oct 16, 2015 at 03:16:11PM +0200, Paolo Bonzini wrote: >> These messages are disabled by default; a perfect usecase for tracepoints. >> Convert them over. >> >> Signed-off-by: Paolo Bonzini > > Looks good to me. Applied

[Qemu-devel] [PULL 19/21] macio-nvram: add to misc category

From: Laurent Vivier The macio nvram is a non volatile RAM, so add it the misc category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/nvram/mac_nvram.c | 1 + 1

[Qemu-devel] [PULL 21/21] prep: do not use CPU_LOG_IOPORT, convert to tracepoints

From: Paolo Bonzini These messages are disabled by default; a perfect usecase for tracepoints. Convert them over. Signed-off-by: Paolo Bonzini Signed-off-by: David Gibson --- hw/ppc/prep.c | 30

[Qemu-devel] [PULL 01/21] spapr: Allocate HTAB from machine init

From: Bharata B Rao Allocate HTAB from ppc_spapr_init() so that we can abort the guest if requested HTAB size is't allocated by the host. However retain the htab reset call in spapr_reset_htab() so that HTAB gets reset (and not allocated) during machine reset.

[Qemu-devel] [PULL 20/21] openpic: add to misc category

From: Laurent Vivier openpic is a programmable interrupt controller, so add it to the misc category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/intc/openpic.c

Re: [Qemu-devel] [PATCH v7 00/10] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end

Am 23.10.2015 um 05:08 hat Fam Zheng geschrieben: > v7: Exclude bdrv_drain and bdrv_qed_drain patches, they'll follow the > bdrv_drain fix for bdrv_aio_flush. > Fix internal snapshot clean. > > v6: Add Kevin's rev-by in patches 1-3, 6-8, 10, 12. > Add Jeff's rev-by in patches 1, 2,

[Qemu-devel] [PULL 08/21] hw/scsi/spapr_vscsi: Remove superfluous memset

From: Thomas Huth g_malloc0 already clears the memory, so no need for the additional memset here. Cc: Paolo Bonzini Cc: David Gibson Cc: Alexander Graf Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 18/21] macio: add to bridge category

From: Laurent Vivier macio is a bridge between the PCI bus and the Mac nvram, IDE controller and PIC, so add it to the bridge category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson

Re: [Qemu-devel] fw_cfg DMA security

On Fri, 23 Oct 2015 08:56:26 +0200 Gerd Hoffmann wrote: > Hi, > > > One complication I thought of was that it might be tricky to deal > > with the implications of allowing this DMA to specify any old > > address to fill with fw_cfg data. > > > > So, for example, since Red

Re: [Qemu-devel] [PULL] vhost: build fix

On 22 October 2015 at 20:37, Michael S. Tsirkin wrote: > The following changes since commit 3c23402d4032f69af44a87fdb8019ad3229a4f31: > > hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT > (2015-10-22 14:39:09 +0300) > > are available in the git

Re: [Qemu-devel] [PATCH] copy, dd: simplify and optimize NUL bytes detection

On 22/10/15 20:47, Paolo Bonzini wrote: > > > On 22/10/2015 19:39, Radim Krčmář wrote: >> 2015-10-22 18:14+0200, Paolo Bonzini: >>> On 22/10/2015 18:02, Eric Blake wrote: I see a bug in there: >>> >>> Of course. You shouldn't have told me what the bug was, I deserved >>> to look for it

[Qemu-devel] [PULL 0/1] qemu-ga patch queue (unbreak Travis-CI builds)

The following changes since commit 147482ae35b896808af68c0051ad86d3aae12979: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-20151023' into staging (2015-10-23 13:09:09 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2015-10-23-tag

[Qemu-devel] [PATCH 11/13] cuda.c: rename get_counter() state variable from s to ti for consistency

Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 7a1b10b..687cb54 100644 --- a/hw/misc/macio/cuda.c +++

Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium

On 23.10.2015 15:39, Kevin Wolf wrote: > Am 21.10.2015 um 15:47 hat Max Reitz geschrieben: >> On 21.10.2015 13:49, Alberto Garcia wrote: >>> On Mon 19 Oct 2015 05:53:37 PM CEST, Max Reitz wrote: And a helper function for that, which directly takes a pointer to the BDS to be inserted

Re: [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved names, empty struct

Eric Blake writes: > On 10/23/2015 06:33 AM, Markus Armbruster wrote: >> Eric Blake writes: [...] >>> +++ b/tests/qapi-schema/struct-name-list.json >>> @@ -0,0 +1,5 @@ >>> +# Potential C name collision >>> +# FIXME - This parses and compiles on its own, but

Re: [Qemu-devel] [PATCH v5 1/2] hw/ptimer: Set delta to the original limit on reload in ptimer_set_limit()

On 19 October 2015 at 21:01, Dmitry Osipenko wrote: > 19.10.2015 20:06, Peter Maydell пишет: >> >> Doesn't this defeat the rate limiting if the timer is enabled, >> though? ptimer_reload() sets the underlying timer based on >> s->delta, so if s->delta isn't the rate-limited

Re: [Qemu-devel] [PATCH v7 35/39] qmp: Introduce blockdev-change-medium

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Introduce a new QMP command 'blockdev-change-medium' which is intended > to replace the 'change' command for block devices. The existing function > qmp_change_blockdev() is accordingly renamed to > qmp_blockdev_change_medium(). > >

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

On 10/23/2015 07:46 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We generate a static visit_type_FOO_fields() for every type >> FOO. However, sometimes we need a forward declaration. Split >> the code to generate the forward declaration out of >>

Re: [Qemu-devel] [PATCH v7 32/39] blockdev: Implement eject with basic operations

On 23.10.2015 15:54, Kevin Wolf wrote: > Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: >> Implement 'eject' by calling blockdev-open-tray and >> blockdev-remove-medium. >> >> Signed-off-by: Max Reitz >> --- >> blockdev.c | 11 +-- >> 1 file changed, 5

[Qemu-devel] [PATCH 07/19] pc: acpi: memhp: move MHPD._STA method into MHPT table

Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug_acpi_table.c | 3 +++ hw/i386/acpi-dsdt-mem-hotplug.dsl | 8 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/acpi/memory_hotplug_acpi_table.c b/hw/acpi/memory_hotplug_acpi_table.c index

[Qemu-devel] [PATCH 00/19] pc: acpi: move memory hotplug out of DSDT/SSDT into custom table

As part of moving to dynamic DSDT and dropping ASL templates althogether this series moves out ASL part of memory hotplug from DSDT into a custom ACPI table. Beside of reducing ASL codebase (DSDT) series tries to generalize and consolidate ACPI part of memory hotplug code so it could be easier to

[Qemu-devel] [PATCH 04/19] acpi: aml: add aml_decrement() and aml_subtract()

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 18 ++ include/hw/acpi/aml-build.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6e147eb..dc6e18d 100644 --- a/hw/acpi/aml-build.c +++

[Qemu-devel] [PATCH 03/19] acpi: aml: add aml_create_qword_field()

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 21 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 43233e2..6e147eb 100644 ---

[Qemu-devel] [PATCH 10/19] pc: acpi: make memory device's _UID integer

It will allow us to drop ToInteger() operator from ASL/AML code. Change is transparent to legacy ASL that uses ToInteger() operator, since it can accept any ComputationalData which includes Integer type. Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug_acpi_table.c |

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

On 10/23/2015 08:44 AM, Valerio Aimale wrote: > > Libvmi dependence on virsh is so strict, that libvmi does not even know > if the QEMU VM has an open qmp unix socket or inet socket, to send > commands through. Thus, libvmi sends qmp commands (to query registers, > as an example) via > > virsh

[Qemu-devel] [PATCH 17/19] pc: acpi: memhp: move MHPD Device along with _UID/_HID into MHPT table

Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug_acpi_table.c | 6 +- hw/i386/acpi-dsdt-mem-hotplug.dsl | 7 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/acpi/memory_hotplug_acpi_table.c b/hw/acpi/memory_hotplug_acpi_table.c index

Re: [Qemu-devel] [PATCH v10 08/25] qapi-types: Refactor base fields output

On 10/23/2015 09:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Move code from gen_union() into gen_struct_fields() in order for >> a later patch to share code when enumerating inherited fields >> for struct types. >> >> No change to generated code. >> >>

Re: [Qemu-devel] [PATCH v7 00/10] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end

On Fri, Oct 23, 2015 at 11:08:04AM +0800, Fam Zheng wrote: > v7: Exclude bdrv_drain and bdrv_qed_drain patches, they'll follow the > bdrv_drain fix for bdrv_aio_flush. > Fix internal snapshot clean. > > v6: Add Kevin's rev-by in patches 1-3, 6-8, 10, 12. > Add Jeff's rev-by in patches

Re: [Qemu-devel] [PATCH v4 03/13] target-arm: Add support for AArch32 S2 negative t0sz

On 14 October 2015 at 23:55, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add support for AArch32 S2 negative t0sz. In preparation for > using 40bit IPAs on AArch32. > > Signed-off-by: Edgar E. Iglesias

[Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

--- As an aside this was reviewed on FreeBSD's Phabricator here: https://reviews.freebsd.org/D3969 net/tap-bsd.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 7028d9b..0103a97 100644 ---

Re: [Qemu-devel] [PATCH] vhdx: Return true for bdrv_has_zero_init

On Fri, Dec 05, 2014 at 11:26:49AM +0100, Kevin Wolf wrote: > Like for most other image formats, vhdx images read as all zero in qemu > after their creation (we're taking advantage from the fact that qemu has > just created the image, because PAYLOAD_BLOCK_NOT_PRESENT actually means > undefined

[Qemu-devel] [PULL 03/13] target-i386: Introduce cpu_x86_update_dr7

From: Richard Henderson This moves the last of the iteration over breakpoints into the bpt_helper.c file. This also allows us to make several breakpoint functions static. Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 08/13] target-i386: Handle I/O breakpoints

Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 99 +++- target-i386/cpu.h| 2 + target-i386/helper.h | 1 + target-i386/translate.c | 20 +-

[Qemu-devel] [PULL 10/13] target-i386: Ensure always-1 bits on DR6 can't be cleared

Bits 4-11 and 16-31 on DR6 are documented as always 1, so ensure they can't be cleared by software. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL 06/13] target-i386: Move hw_*breakpoint_* functions

From: Richard Henderson They're only used from bpt_helper.c now. Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 29 - target-i386/cpu.h| 27

[Qemu-devel] [PULL 12/13] target-i386: Use 1UL for bit shift

Fix undefined behavior detected by clang runtime check: qemu/target-i386/cpu.c:1494:15: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' While doing that, add extra parenthesis for clarity. Reported-by: Peter Maydell Signed-off-by:

Re: [Qemu-devel] [PATCH v7 28/39] blockdev: Add blockdev-open-tray

Am 23.10.2015 um 17:25 hat Max Reitz geschrieben: > On 23.10.2015 16:45, Kevin Wolf wrote: > > Am 23.10.2015 um 16:26 hat Max Reitz geschrieben: > >> On 23.10.2015 15:26, Kevin Wolf wrote: > >>> Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz >

Re: [Qemu-devel] [PATCH] target-arm: Extract some external ARM CPU API

Hello! > Please don't do two things in one patch. (I actually read this patch > code-first and thought you'd accidentally inserted this change due > to a rebasing mishap...) It's particularly bad in patches which are > otherwise almost entirely moving code from one file to another, > because

Re: [Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

El 23/10/15 a les 16.39, Ed Maste ha escrit: > --- > As an aside this was reviewed on FreeBSD's Phabricator here: > https://reviews.freebsd.org/D3969 This is missing the SoB, but provided that's added: Acked-by: Roger Pau Monné Thanks.

[Qemu-devel] [PULL 00/13] X86 queue, 2015-10-23

Sorry for not submitting this a few days earlier. The following changes since commit 147482ae35b896808af68c0051ad86d3aae12979: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-20151023' into staging (2015-10-23 13:09:09 +0100) are available in the git repository at: git

Re: [Qemu-devel] [PATCH v4 05/13] target-arm: lpae: Rename granule_sz to stride

On 14 October 2015 at 23:55, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Rename granule_sz to stride to better match the reference manuals. > > No functional change. > > Signed-off-by: Edgar E. Iglesias

[Qemu-devel] [PULL 04/13] target-i386: Re-introduce optimal breakpoint removal

From: Richard Henderson Before the last patch, we had an efficient loop that disabled local breakpoints on task switch. Re-add that, but in a more general way that handles changes to the global enable bits too. Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 05/13] target-i386: Ensure bit 10 on DR7 is never cleared

Bit 10 of DR7 is documented as always set to 1, so ensure that's always the case. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-i386/bpt_helper.c

[Qemu-devel] [PULL 07/13] target-i386: Optimize setting dr[0-3]

From: Richard Henderson If the debug register is not enabled, we need do nothing besides update the register. Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 11 --- 1 file

[Qemu-devel] [PULL 09/13] target-i386: Check CR4[DE] for processing DR4/DR5

From: Richard Henderson Introduce helper_get_dr so that we don't have to put CR4[DE] into the scarce HFLAGS resource. At the same time, rename helper_movl_drN_T0 to helper_set_dr and set the helper flags. Signed-off-by: Richard Henderson Signed-off-by:

[Qemu-devel] [PULL 11/13] target-i386: Add DE to TCG_FEATURES

Now DE is supported by TCG so it can be enabled in CPUID bits. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c

[Qemu-devel] [PULL 13/13] vl: trivial: minor tweaks to a max-cpu error msg

From: Andrew Jones Signed-off-by: Andrew Jones --- vl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 332d828..dffaf09 100644 --- a/vl.c +++ b/vl.c @@ -4101,8 +4101,8 @@ int main(int argc, char **argv, char

Re: [Qemu-devel] [PATCH v4 02/13] target-arm: lpae: Make t0sz and t1sz signed integers

On 14 October 2015 at 23:55, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Make t0sz and t1sz signed integers to match tsz and to make > it easier to implement support for AArch32 negative t0sz. > t1sz is changed for consistensy. >

Re: [Qemu-devel] [PATCH v4 04/13] target-arm: lpae: Replace tsz with computed inputsize

On 14 October 2015 at 23:55, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Remove the tsz variable and introduce inputsize. > This simplifies the code a little and makes it easier to > compare with the reference manuals. > > No

Re: [Qemu-devel] [PULL 0/1] qemu-ga patch queue (unbreak Travis-CI builds)

On 23 October 2015 at 15:07, Michael Roth <mdr...@linux.vnet.ibm.com> wrote: > The following changes since commit 147482ae35b896808af68c0051ad86d3aae12979: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-20151023' into > staging (2015-10-23 13:09:09 +0100)

Re: [Qemu-devel] Coding style for errors

On 10/23/15 18:01, Stefan Hajnoczi wrote: > On Thu, Oct 22, 2015 at 03:30:34PM +0200, Lluís Vilanova wrote: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: >> [...] So, is there any agreement on what should be used? If so, could that please be added

[Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

Acked-by: Roger Pau Monné Signed-off-by: Ed Maste --- As an aside this was reviewed on FreeBSD's Phabricator here: https://reviews.freebsd.org/D3969 Resend with Signed-off-by. net/tap-bsd.c | 38 +- 1 file changed,

Re: [Qemu-devel] [PATCH] vhdx: Return true for bdrv_has_zero_init

Am 23.10.2015 um 17:32 hat Stefan Hajnoczi geschrieben: > On Fri, Dec 05, 2014 at 11:26:49AM +0100, Kevin Wolf wrote: > > Like for most other image formats, vhdx images read as all zero in qemu > > after their creation (we're taking advantage from the fact that qemu has > > just created the image,

Re: [Qemu-devel] Coding style for errors

On Thu, Oct 22, 2015 at 03:30:34PM +0200, Lluís Vilanova wrote: > Markus Armbruster writes: > > > Lluís Vilanova writes: > [...] > >> So, is there any agreement on what should be used? If so, could that > >> please be > >> added to CODING_STYLE? > > > I think HACKING would

[Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in the following ways: (1) If Trigger() is executed by the BSP (which is guaranteed before

[Qemu-devel] [PULL 05/21] spapr_iommu: Rename vfio_accel parameter

The vfio_accel parameter used when creating a new TCE table (guest IOMMU context) has a confusing name. What it really means is whether we need the TCE table created to be able to support VFIO devices. VFIO is relevant, because when available we use in-kernel acceleration of the TCE table, but

Re: [Qemu-devel] [PULL v3 0/4] Misc fixes for crypto code module

On 22 October 2015 at 19:05, Daniel P. Berrange wrote: > The following changes since commit ca3e40e233e87f7b29442311736a82da01c0df7b: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-22 12:41:44 +0100) > > are available in the git

[Qemu-devel] [PATCH v3 3/4] block: Add 'x-blockdev-del' QMP command

This command is still experimental, hence the name. This is the companion to 'blockdev-add'. It allows deleting a BlockBackend with its associated BlockDriverState tree, or a BlockDriverState that is not attached to any backend. In either case, the command fails if the reference count is greater

[Qemu-devel] [PATCH v3 4/4] iotests: Add tests for the x-blockdev-del command

Signed-off-by: Alberto Garcia --- tests/qemu-iotests/139 | 408 + tests/qemu-iotests/139.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 414 insertions(+) create mode 100644 tests/qemu-iotests/139 create mode

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

On 10/23/15 09:26, Paolo Bonzini wrote: > > > On 23/10/2015 06:41, Jordan Justen wrote: >> On 2015-10-22 12:46:56, Paolo Bonzini wrote: >>> >>> On 22/10/2015 20:04, Kevin O'Connor wrote: On Thu, Oct 22, 2015 at 10:40:08AM +0200, Paolo Bonzini wrote: > On 21/10/2015 20:36, Jordan Justen

[Qemu-devel] [Bug 1509336] [NEW] USB passthru not work with Mac OS X El Capitan

Public bug reported: QEMU emulator version 2.4.50 with kernel kvm module from linux kernel 3.16.0 or 4.2.3 Since upgrading from Yosemite to El Capitan - USB passthru does not work. Note USB passthru worked perfectly with Maverick and Yosemite. I attempt to use different USB hosts. I found a

Re: [Qemu-devel] [PATCH] copy, dd: simplify and optimize NUL bytes detection

On 22/10/15 20:47, Paolo Bonzini wrote: > > > On 22/10/2015 19:39, Radim Krčmář wrote: >> 2015-10-22 18:14+0200, Paolo Bonzini: >>> On 22/10/2015 18:02, Eric Blake wrote: I see a bug in there: >>> >>> Of course. You shouldn't have told me what the bug was, I deserved >>> to look for it

Re: [Qemu-devel] [PATCH v7 28/39] blockdev: Add blockdev-open-tray

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > blockdev.c | 49 + > qapi/block-core.json | 23 +++ > qmp-commands.hx | 39

Re: [Qemu-devel] [PATCH v3 09/21] block: Add average I/O queue depth to BlockDeviceTimedStats

On Fri 23 Oct 2015 03:31:38 PM CEST, Stefan Hajnoczi wrote: >> +uint64_t timed_average_sum(TimedAverage *ta, uint64_t *elapsed) >> +{ >> +TimedAverageWindow *w; >> +check_expirations(ta); >> +w = current_window(ta); >> +if (elapsed != NULL) { >> +

Re: [Qemu-devel] [PATCH v7 29/39] blockdev: Add blockdev-close-tray

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH 01/13] PPC: Allow Rc bit to be set on mtspr

From: Alexander Graf According to the ISA setting the Rc bit on mtspr is undefined behavior. Real 750 hardware simply ignores the bit and doesn't touch cr0 though. Unfortunately, Mac OS 9 relies on this fact and executes a few mtspr instructions (to set XER for example) with Rc

[Qemu-devel] [PATCH 06/13] cuda.c: implement simple CUDA_GET_6805_ADDR command

This simply returns an empty response with no error status. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 88a0999..4fe901b 100644 ---

Re: [Qemu-devel] [PATCH v2 0/3] target-i386: save/restore vcpu's TSC rate during migration

On Fri, Oct 23, 2015 at 08:35:20AM -0200, Marcelo Tosatti wrote: > On Thu, Oct 22, 2015 at 04:45:21PM -0200, Eduardo Habkost wrote: > > On Tue, Oct 20, 2015 at 03:22:51PM +0800, Haozhong Zhang wrote: > > > This patchset enables QEMU to save/restore vcpu's TSC rate during the > > > migration. When

Re: [Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023

> > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-next-20151023 > > for you to fetch changes up to 659f7f65561e78d720986d61f3112c54a97b2b96: > > prep: do not use CPU_LOG_IOPORT, convert to

Re: [Qemu-devel] [PATCH v2] i386/acpi: add _HID to processor objects

On Thu, 22 Oct 2015 22:03:24 +0200 Matthias Lange wrote: > This patch appends "ACPI0007" as the HID to each processor object. > > Until commit 20843d processor objects used to have a _HID. According > to the ACPI spec this is not required but removing it breaks

Re: [Qemu-devel] [PATCH v7 28/39] blockdev: Add blockdev-open-tray

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > blockdev.c | 49 + > qapi/block-core.json | 23 +++ > qmp-commands.hx | 39

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

Eric Blake writes: > We generate a static visit_type_FOO_fields() for every type > FOO. However, sometimes we need a forward declaration. Split > the code to generate the forward declaration out of > gen_visit_implicit_struct() into a new gen_visit_fields_decl(), > and also

[Qemu-devel] [PATCH] correct comment of option parse in main()

Signed-off-by: Cao jin --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 332d828..aa95172 100644 --- a/vl.c +++ b/vl.c @@ -3031,7 +3031,7 @@ int main(int argc, char **argv, char **envp) optind = 1; while (optind <

Re: [Qemu-devel] [PATCH] target-arm: Extract some external ARM CPU API

On 22 October 2015 at 14:09, Pavel Fedin wrote: > Includes, which reside in target-arm, are very problematic to use from code > which is considered target-independent by the build system (for example, > hw/intc/something.c). It happens because they depend on config-target.h,

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

On 23 October 2015 at 13:39, Sergey Fedorov wrote: > On 23.10.2015 15:37, Peter Maydell wrote: >> On 23 October 2015 at 13:35, Sergey Fedorov wrote: >>> On 23.10.2015 14:10, Peter Maydell wrote: On 23 October 2015 at 11:14, Sergey Fedorov

Re: [Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims.

On Fri, 2015-10-23 at 12:06 +0100, Stefano Stabellini wrote: > On Wed, 21 Oct 2015, Ian Campbell wrote: > > In Xen 4.7 we are refactoring parts libxenctrl into a number of > > separate libraries which will provide backward and forward API and ABI > > compatiblity. > > > > One such library will be

Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > And a helper function for that, which directly takes a pointer to the > BDS to be inserted instead of its node-name (which will be used for > implementing 'change' using blockdev-insert-medium). > > Signed-off-by: Max Reitz >

Re: [Qemu-devel] [PATCH v7 32/39] blockdev: Implement eject with basic operations

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Implement 'eject' by calling blockdev-open-tray and > blockdev-remove-medium. > > Signed-off-by: Max Reitz > --- > blockdev.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/blockdev.c

[Qemu-devel] [PATCH 05/13] cuda.c: fix CUDA_PACKET response packet format

According to comments in MOL, the response to a CUDA_PACKET should be one of the following: Reply: CUDA_PACKET, status, cmd Error: ERROR_PACKET, status, CUDA_PACKET, cmd Update cuda_receive_packet() accordingly to reflect this. Signed-off-by: Mark Cave-Ayland ---

[Qemu-devel] [PATCH 07/13] cuda.c: implement dummy IIC access commands

These are used by MacOS 9 on boot. Here we return an error except for 4-byte commands which write to the IIC bus. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[Qemu-devel] [PATCH 08/13] cuda.c: fix CUDA SR interrupt clearing

Make sure that we also clear the data and clock interrupts at the same time. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index

Re: [Qemu-devel] [PATCH v10 05/25] qapi: Reserve 'q_*' and 'has_*' member names

Eric Blake writes: > c_name() produces names starting with 'q_' when protecting > a QMP member name that would fail to directly compile, but > in doing so can cause clashes with any QMP name already > beginning with 'q-' or 'q_'. Likewise, we create a C name > 'has_' for any

Re: [Qemu-devel] [PATCH v3 08/21] block: Compute minimum, maximum and average I/O latencies

On Thu, Oct 22, 2015 at 11:11:18AM +0300, Alberto Garcia wrote: > +struct BlockAcctTimedStats { > +TimedAverage latency[BLOCK_MAX_IOTYPE]; > +unsigned interval_length; /* in seconds */ would be nice here so the units are clear. Or even interval_length_secs.

Re: [Qemu-devel] [PATCH v3 09/21] block: Add average I/O queue depth to BlockDeviceTimedStats

On Thu, Oct 22, 2015 at 11:11:19AM +0300, Alberto Garcia wrote: > +/* Get the sum of all accounted values > + * @ta: the TimedAverage structure > + * @elapsed: if non-NULL, the elapsed time (in ns) will be stored here > + * @ret: the sum of all accounted values > + */ > +uint64_t

[Qemu-devel] [PATCH 00/13] Mac OS 9 compatibility improvements (upstream rework)

This is a rework of Cormac O'Brien's GSoC project to try and boot MacOS 9 under QEMU, the original version of which was posted to the qemu-devel list at the end of August (https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02521.html). The patchset consisted of some simple patches from

[Qemu-devel] [PATCH 09/13] cuda.c: add defines for CUDA registers

Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 87 ++ 1 file changed, 53 insertions(+), 34 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 4027713..d32afc6 100644 ---

[Qemu-devel] [PATCH 02/13] PPC: Fix lsxw bounds checks

From: Alexander Graf The lsxw instruction checks whether the desired string actually fits into all defined registers. Unfortunately it does the calculation wrong, resulting in illegal instruction traps for loads that really should fit. Fix it up, making Mac OS happier.

Re: [Qemu-devel] [RFC PATCH v3 1/4] hw/intc/arm_gicv3_common: Add state information

On 22 October 2015 at 15:02, Pavel Fedin wrote: > Add state information to GICv3 object structure and implement > arm_gicv3_common_reset(). Also, add some functions for registers which are > not stored directly but simulated. > > State information includes not only pure GICv3

Re: [Qemu-devel] [PATCH v10 03/25] qapi: More robust conditions for when labels are needed

Eric Blake writes: > We were using regular expressions to see if ret included > any earlier text that emitted a 'goto out;' line, to decide > whether we needed to output an 'out:' label. But this is > fragile, if the ret text can possibly combine more than one > generated

Re: [Qemu-devel] [PATCH v10 04/25] qapi: Reserve '*List' type names for list types

Eric Blake writes: > Type names ending in 'List' can clash with qapi list types in > generated C. We don't currently use such names. It is easier to > outlaw them now than to worry about how to resolve such a clash > in the future. For precedence, see commit 4dc2e69, which

  1   2   3   4   >