Re: [Qemu-devel] [RFC Patch 05/12] IXGBE: Add new sysfs interface of "notify_vf"

2015-10-24 Thread Lan, Tianyu
On 10/25/2015 2:03 PM, Alexander Duyck wrote: On 10/24/2015 08:43 AM, Lan, Tianyu wrote: On 10/22/2015 4:52 AM, Alexander Duyck wrote: Also have you even considered the MSI-X configuration on the VF? I haven't seen anything anywhere that would have migrated the VF's MSI-X configuration from

Re: [Qemu-devel] [RFC Patch 05/12] IXGBE: Add new sysfs interface of "notify_vf"

2015-10-24 Thread Alexander Duyck
On 10/24/2015 08:43 AM, Lan, Tianyu wrote: On 10/22/2015 4:52 AM, Alexander Duyck wrote: Also have you even considered the MSI-X configuration on the VF? I haven't seen anything anywhere that would have migrated the VF's MSI-X configuration from BAR 3 on one system to the new system. MSI-X m

Re: [Qemu-devel] [PATCH v3 8/8] i.MX: Standardize i.MX GPT debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qemu

Re: [Qemu-devel] [PATCH v3 7/8] i.MX: Standardize i.MX EPIT debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qemu

Re: [Qemu-devel] [PATCH v3 6/8] i.MX: Standardize i.MX FEC debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qemu

Re: [Qemu-devel] [PATCH v3 5/8] i.MX: Standardize i.MX CCM debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qemu

Re: [Qemu-devel] [PATCH v3 4/8] i.MX: Standardize i.MX AVIC debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qemu

Re: [Qemu-devel] [PATCH v3 3/8] i.MX: Standardize i.MX I2C debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qem

Re: [Qemu-devel] [PATCH v3 2/8] i.MX: Standardize i.MX GPIO debug

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 1:15 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > We standardize all debug output on the following format: > > [QOM_TYPE_NAME]reporting_function: debug message > > We also replace IPRINTF with qemu_log_mask(). The qemu

Re: [Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 3:22 PM, Dmitry Osipenko wrote: > 24.10.2015 22:45, Peter Crosthwaite пишет: >> >> >> This looks like a give-up without trying to get the correct value. If >> the calculated value (using the normal-path logic below) is sane, you >> should just use it. If it comes out bad th

Re: [Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

2015-10-24 Thread Dmitry Osipenko
24.10.2015 22:45, Peter Crosthwaite пишет: This looks like a give-up without trying to get the correct value. If the calculated value (using the normal-path logic below) is sane, you should just use it. If it comes out bad then you should clamp to 1. I am wondering whether this clamping policy

[Qemu-devel] [PATCH v3 8/8] i.MX: Standardize i.MX GPT debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

[Qemu-devel] [PATCH v3 7/8] i.MX: Standardize i.MX EPIT debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

[Qemu-devel] [PATCH v3 6/8] i.MX: Standardize i.MX FEC debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

[Qemu-devel] [PATCH v3 5/8] i.MX: Standardize i.MX CCM debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

[Qemu-devel] [PATCH v3 1/8] i.MX: Standardize i.MX serial debug.

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Review

[Qemu-devel] [PATCH v3 0/8] i.MX: Standardize debug code

2015-10-24 Thread Jean-Christophe Dubois
We fix all i.MX driver files to use the same type of debug code. The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask

[Qemu-devel] [PATCH v3 4/8] i.MX: Standardize i.MX AVIC debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

[Qemu-devel] [PATCH v3 3/8] i.MX: Standardize i.MX I2C debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

[Qemu-devel] [PATCH v3 2/8] i.MX: Standardize i.MX GPIO debug

2015-10-24 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. We standardize all debug output on the following format: [QOM_TYPE_NAME]reporting_function: debug message We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output is following the same format as the above debug. Signed

Re: [Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

2015-10-24 Thread Peter Crosthwaite
On Sat, Oct 24, 2015 at 5:21 AM, Dmitry Osipenko wrote: > Multiple issues here related to the timer with a corrected .limit value: > > 1) ptimer_get_count() returns incorrect value for the disabled timer after > loading the counter with a small value, because corrected limit value > is used instea

Re: [Qemu-devel] [PATCH] tests: re-enable vhost-user-test

2015-10-24 Thread Michael S. Tsirkin
On Thu, Oct 15, 2015 at 04:39:25PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, > since CONFIG_VHOST_NET is a per-target config variable. > > tests/vhost-user-test is already x86/64 softmmu specific test,

Re: [Qemu-devel] [PATCH 15/19] pc: acpi: bump DSDT revision compliance to v2

2015-10-24 Thread Michael S. Tsirkin
On Fri, Oct 23, 2015 at 04:57:18PM +0200, Igor Mammedov wrote: > it turns on 64-bit integer handling in OSPM, which we could use > for writing simpler/smaller AML code. > Tested with Windows XP and Windows Server 2008, Linux: > * XP doesn't care about revision and continues to use 32 integers >

Re: [Qemu-devel] [PATCH 06/19] pc: acpi: move SSDT part of memhp into a custom table

2015-10-24 Thread Michael S. Tsirkin
On Fri, Oct 23, 2015 at 04:57:09PM +0200, Igor Mammedov wrote: > moves SSDT part to custom MHPT table, which is loaded > at runtime by OSPM if it supports ACPIv2 revision and > only if memory hotplug is enabled. > That should reduce ACPI tables blob size if memory > hotplug is not enabled (default

Re: [Qemu-devel] [PATCH 06/19] pc: acpi: move SSDT part of memhp into a custom table

2015-10-24 Thread Michael S. Tsirkin
On Fri, Oct 23, 2015 at 04:57:09PM +0200, Igor Mammedov wrote: > moves SSDT part to custom MHPT table, which is loaded > at runtime by OSPM if it supports ACPIv2 revision and > only if memory hotplug is enabled. > That should reduce ACPI tables blob size if memory > hotplug is not enabled (default

Re: [Qemu-devel] [PATCH 06/19] pc: acpi: move SSDT part of memhp into a custom table

2015-10-24 Thread Michael S. Tsirkin
On Fri, Oct 23, 2015 at 04:57:09PM +0200, Igor Mammedov wrote: > +/* copy AML table into ACPI tables blob and patch header there */ > +g_array_append_vals(table_data, table->buf->data, table->buf->len); > +build_header(linker, table_data, > +(void *)(table_data->data + table_dat

Re: [Qemu-devel] [PATCH 00/19] pc: acpi: move memory hotplug out of DSDT/SSDT into custom table

2015-10-24 Thread Michael S. Tsirkin
On Fri, Oct 23, 2015 at 04:57:03PM +0200, Igor Mammedov wrote: > As part of moving to dynamic DSDT and dropping > ASL templates althogether If this is indeed what we are trying to do, I would rather have it factored differently: 1. rewrite ASL parts in C, no code changes (existing tests should

Re: [Qemu-devel] [RFC Patch 08/12] IXGBEVF: Rework code of finding the end transmit desc of package

2015-10-24 Thread Lan, Tianyu
On 10/22/2015 5:14 AM, Alexander Duyck wrote: Where is i being initialized? It was here but you removed it. Are you using i without initializing it? Sorry, the initialization was put into patch 10 by mistake. "i" is assigned with "tx_ring->next_to_clean".

Re: [Qemu-devel] [RFC Patch 08/12] IXGBEVF: Rework code of finding the end transmit desc of package

2015-10-24 Thread Lan, Tianyu
On 10/22/2015 8:58 PM, Michael S. Tsirkin wrote: Do you really need to play the shifting games? Can't you just reset everything and re-initialize the rings? It's slower but way less intrusive. Also removes the need to track writes into rings. Shift ring is to avoid losing those packets in the

Re: [Qemu-devel] [PATCH] vhost-user-test: fix up rhel6 build

2015-10-24 Thread Michael S. Tsirkin
On Sat, Oct 24, 2015 at 08:39:46AM +0800, Gonglei wrote: > On 2015/10/23 19:36, Michael S. Tsirkin wrote: > > Build on RHEL6 fails: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42875 > > > > Apparently unnamed unions couldn't use C99 named field initializers. > > Let's just name the payload u

Re: [Qemu-devel] [RFC Patch 05/12] IXGBE: Add new sysfs interface of "notify_vf"

2015-10-24 Thread Lan, Tianyu
On 10/22/2015 4:52 AM, Alexander Duyck wrote: Also have you even considered the MSI-X configuration on the VF? I haven't seen anything anywhere that would have migrated the VF's MSI-X configuration from BAR 3 on one system to the new system. MSI-X migration is done by Hypervisor(Qemu). Follow

Re: [Qemu-devel] [RFC Patch 01/12] PCI: Add virtfn_index for struct pci_device

2015-10-24 Thread Lan, Tianyu
On 10/22/2015 2:07 AM, Alexander Duyck wrote: On 10/21/2015 09:37 AM, Lan Tianyu wrote: Add "virtfn_index" member in the struct pci_device to record VF sequence of PF. This will be used in the VF sysfs node handle. Signed-off-by: Lan Tianyu --- drivers/pci/iov.c | 1 + include/linux/pci

Re: [Qemu-devel] [RFC PATCH v3 1/4] hw/intc/arm_gicv3_common: Add state information

2015-10-24 Thread Peter Maydell
On 24 October 2015 at 13:30, Shlomo Pongratz wrote: > Comment on the "workaround" see inline. > >> > +/* Workaround! >> > + * Linux (drivers/irqchip/irq-gic-v3.c) is enabling only group >> > one, >> > + * in gic_cpu_sys_reg_init it calls gic_write_grpen1(1); >> > +

Re: [Qemu-devel] [RFC PATCH v3 1/4] hw/intc/arm_gicv3_common: Add state information

2015-10-24 Thread Shlomo Pongratz
Comment on the "workaround" see inline. On Friday, October 23, 2015, Peter Maydell wrote: > On 22 October 2015 at 15:02, Pavel Fedin > wrote: > > Add state information to GICv3 object structure and implement > > arm_gicv3_common_reset(). Also, add some functions for registers which > are > > no

[Qemu-devel] [PATCH v7 2/2] arm_mptimer: Convert to use ptimer

2015-10-24 Thread Dmitry Osipenko
Current ARM MPTimer implementation uses QEMUTimer for the actual timer, this implementation isn't complete and mostly tries to duplicate of what generic ptimer is already doing fine. Conversion to ptimer brings the following benefits and fixes: - Simple timer pausing implementation

[Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

2015-10-24 Thread Dmitry Osipenko
Multiple issues here related to the timer with a corrected .limit value: 1) ptimer_get_count() returns incorrect value for the disabled timer after loading the counter with a small value, because corrected limit value is used instead of the original. For instance: 1) ptimer_stop(t) 2) pti

[Qemu-devel] [PATCH v7 0/2] PTimer fix and ARM MPTimer conversion

2015-10-24 Thread Dmitry Osipenko
Changelog for ARM MPTimer QEMUTimer to ptimer conversion: V2: Fixed changing periodic timer counter value "on the fly". I added a test to the gist to cover that issue. V3: Fixed starting the timer with load = 0 and counter != 0, added tests to the gist for this issue. Chan

[Qemu-devel] [PATCH] ui/egl: Reduce required libraries to build with EGL support

2015-10-24 Thread OGAWA Hirofumi
To support EGL (sdl2-gl, gtk-egl, egl-helpers, etc.), we don't need to install "gl" or "glesv" packages. (Those are used only for milkymist-tmu2). So, this move check from opengl to egl. Signed-off-by: OGAWA Hirofumi --- configure| 34 -- include/u

Re: [Qemu-devel] [PATCH] correct comment of option parse in main()

2015-10-24 Thread Cao jin
Sorry, silly mistake in a unclear mind state. On 10/23/2015 09:40 PM, Cao jin wrote: Signed-off-by: Cao jin --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 332d828..aa95172 100644 --- a/vl.c +++ b/vl.c @@ -3031,7 +3031,7 @@ int main(int argc, ch