To minimize code duplication, epoll is hooked into aio-posix's
aio_poll() instead of rolling its own. This approach also has both
compile-time and run-time switchability.
1) When QEMU starts with a small number of fds in the event loop, ppoll
is used.
2) When QEMU starts with a big number of fds,
v3: Remove the redundant check in aio_epoll_try_enable. [Stefan]
v2: Merge aio-epoll.c into aio-posix.c. [Paolo]
Capture some benchmark data in commit log.
This series adds the ability to use epoll in aio_poll() on Linux. It's switched
on in a dynamic way rather than static for two reasons: 1
This is the place to initialize platform specific bits of AioContext.
Signed-off-by: Fam Zheng
---
aio-posix.c | 4
aio-win32.c | 4
async.c | 13 +++--
include/block/aio.h | 8
4 files changed, 27 insertions(+), 2 deletions(-)
diff --gi
The "need_check_timer" is used to clear the "NEED_CHECK" flag in the
image header after a grace period once metadata update has finished. In
compliance to the bdrv_drain semantics we should make sure it remains
deleted once .bdrv_drain is called.
We cannot reuse qed_need_check_timer_cb because her
Drivers can have internal request sources that generate IO, like the
need_check_timer in QED. Since we want quiesced periods that contain
nested event loops in block layer, we need to have a way to disable such
event sources.
Block drivers must implement the "bdrv_drain" callback if it has any
int
Both bdrv_discard and bdrv_aio_discard will call into bdrv_co_discard,
so add tracked_request_begin/end calls around the loop.
Signed-off-by: Fam Zheng
---
block/io.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/block/io.c b/block/io.c
index 223c4e9..abb3aa
Now the callback is not used any more, drop the field along with all
implementations in block drivers, which are iscsi and raw.
Signed-off-by: Fam Zheng
---
block/iscsi.c | 33 -
block/raw-posix.c | 9 -
block/raw_bsd.c | 6
Currently all drivers that support .bdrv_aio_ioctl also implement
.bdrv_ioctl redundantly. To track ioctl requests in block layer it is
easier if we unify the two paths, because we'll need to run it in a
coroutine, as required by tracked_request_begin. While we're at it, use
.bdrv_aio_ioctl plus a
On Thu, Oct 22, 2015 at 3:30 AM, Peter Maydell wrote:
> [Apologies for the huge cc list, which is basically "everybody
> I have accepted a pullreq from this release cycle.]
>
> Just a reminder that we're now in softfreeze (ie "no new big
> features, start the process of cutting down towards only b
iscsi_ioctl emulates SG_GET_VERSION_NUM and SG_GET_SCSI_ID. Now that
bdrv_ioctl() will be emulated with .bdrv_aio_ioctl, replicate the logic
into iscsi_aio_ioctl to make them consistent.
Signed-off-by: Fam Zheng
---
block/iscsi.c | 39 +--
1 file changed, 37 i
The two fields that will be used by ioctl handling code later are added
as union, because it's used exclusively by ioctl code which dosn't need
the four fields in the other struct of the union.
Signed-off-by: Fam Zheng
---
include/block/block.h | 16
1 file changed, 12 insertion
Both bdrv_flush and bdrv_aio_flush eventually call bdrv_co_flush, add
tracked_request_begin and tracked_request_end pair in that function so
that all flush requests are now tracked.
Signed-off-by: Fam Zheng
---
block/io.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --
We'll track more request types besides read and write, change the
boolean field to an enum.
Signed-off-by: Fam Zheng
---
block/io.c| 9 +
include/block/block_int.h | 10 +-
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/block/io.c b/block/io.c
in
Previously bdrv_drain and bdrv_drain_all don't handle ioctl, flush and discard
requests (which are fundamentally the same as read and write requests that
change disk state). Forgetting such requests leaves us in risk of violating
the invariant that bdrv_drain() callers rely on - all asynchronous r
Hey Peter,
On (Thu) 22 Oct 2015 [11:30:57], Peter Maydell wrote:
> [Apologies for the huge cc list, which is basically "everybody
> I have accepted a pullreq from this release cycle.]
>
> Just a reminder that we're now in softfreeze (ie "no new big
> features, start the process of cutting down to
On (Wed) 21 Oct 2015 [09:00:31], Li, Liang Z wrote:
> > > Some cleanup operations take long time during the pause and copy
> > > stage, especially with the KVM patch 3ea3b7fa9af067, do these
> > > operations after the completion of live migration can help to reduce
> > > VM
> > downtime.
> > >
>
On 2015年10月24日 02:36, Alexander Duyck wrote:
> I was thinking about it and I am pretty sure the dummy write approach is
> problematic at best. Specifically the issue is that while you are
> performing a dummy write you risk pulling in descriptors for data that
> hasn't been dummy written to yet.
In case user regret when hot-add multi-function, we should roll back,
device_del the function added but still not worked.
Signed-off-by: Cao jin
---
hw/pci/pcie.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 6e28
Enable pcie device multifunction hot, just ensure the function 0
added last, then driver will got the notification to scan all the
function in the slot.
Signed-off-by: Cao jin
---
hw/pci/pci.c | 31 ++-
hw/pci/pci_host.c| 13 +++--
hw/pci/pcie.c
Support PCI-e device hot-add multi-function via device_add, just ensure
add the function 0 is added last. While allow user to roll back in the
middle via device_del, in case user cancle the operation.
changelog v5:
1. change pci_is_function_0() to pci_get_function_0(),
and use it according to v
On 20/10/2015 13:05, Dr. David Alan Gilbert (git) wrote:
> +entry = cur.dereference()
> +gdb.write('\n%s\n' % entry)
> +if cur['io_read'] == sym_fd_coroutine_enter:
> +coptr =
> (cur['opaque'].cast(gdb.lookup_type('FDYieldUntilData').pointer()))['co']
> +
On Fri, Oct 23, 2015 at 12:58:02PM -0200, Eduardo Habkost wrote:
> On Fri, Oct 23, 2015 at 11:14:48AM +0800, Haozhong Zhang wrote:
> > On Thu, Oct 22, 2015 at 04:11:37PM -0200, Eduardo Habkost wrote:
> > > On Tue, Oct 20, 2015 at 03:22:54PM +0800, Haozhong Zhang wrote:
> > > > Set vcpu's TSC rate t
On Fri, Oct 23, 2015 at 12:45:13PM -0200, Eduardo Habkost wrote:
> On Fri, Oct 23, 2015 at 10:27:27AM +0800, Haozhong Zhang wrote:
> > On Thu, Oct 22, 2015 at 04:45:21PM -0200, Eduardo Habkost wrote:
> > > On Tue, Oct 20, 2015 at 03:22:51PM +0800, Haozhong Zhang wrote:
> > > > This patchset enables
On 10/21/2015 04:27 PM, Markus Armbruster wrote:
> Sorry for my slow reply.
>
> Kevin Wolf writes:
>
>> Am 08.10.2015 um 13:02 hat Kevin Wolf geschrieben:
>>> Am 08.10.2015 um 08:15 hat Markus Armbruster geschrieben:
Max Reitz writes:
> E.g. you may have a block filter in the future wh
On Fri, 10/23 16:24, Stefan Hajnoczi wrote:
> On Fri, Oct 23, 2015 at 11:08:09AM +0800, Fam Zheng wrote:
> > +/**
> > + * bdrv_drained_begin:
> > + *
> > + * Begin a quiesced section for exclusive access to the BDS, by disabling
> > + * external request sources including NBD server and device model
On Fri, 10/23 16:13, Stefan Hajnoczi wrote:
> On Fri, Oct 23, 2015 at 11:08:09AM +0800, Fam Zheng wrote:
> > +void bdrv_drained_begin(BlockDriverState *bs)
> > +{
> > +if (!bs->quiesce_counter++) {
> > +aio_disable_external(bdrv_get_aio_context(bs));
> > +}
> > +bdrv_drain(bs);
Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> This series does three things:
>
> 1) add a "-trace [enable=]foo" option to enable one or more trace
> events, and a "-trace help" option to show the list of tracepoints
> (patches 4-5)
>
> 2) change the stderr tracing backend so that it prints to t
On Fri, 10/23 11:09, Stefan Hajnoczi wrote:
> On Fri, Oct 23, 2015 at 10:32 AM, Fam Zheng wrote:
> > On Tue, 10/20 12:05, Dr. David Alan Gilbert (git) wrote:
> >> From: "Dr. David Alan Gilbert"
> >>
> >> Two new gdb commands are added:
> >>
> >> qemu iohandlers
> >>
> >> that dumps the lis
Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> This series does three things:
>
> 1) add a "-trace [enable=]foo" option to enable one or more trace
> events, and a "-trace help" option to show the list of tracepoints
> (patches 4-5)
>
> 2) change the stderr tracing backend so that it prints to t
Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> diff --git a/trace/control.h b/trace/control.h
> index bfbe560..d2506d4 100644
> --- a/trace/control.h
> +++ b/trace/control.h
> @@ -157,7 +157,7 @@ static void trace_event_set_state_dynamic(TraceEvent *ev,
> bool state);
> *
> * Returns: Whether
On 20/10/15 09:16, Gerd Hoffmann wrote:
Hmm, EfiPxeBaseCode*Callback*Protocol?
Ping. Any progress here?
Meanwhile I've noticed efi grub2 fails to load grub.cfg on microsoft
hyper-v too, so possibly this is something in grub not ipxe ...
Haven't had time to look at it yet, sorry. It _is_ st
Add a Linux-specific pre-boot routine that matches the device
specific bootloaders behaviour. This is needed for modern Linux that
expects the ARM PLL in SLCR to be a more even value (not 26).
Cc: Alistair Francis
Signed-off-by: Peter Crosthwaite
---
Changed since RFC:
Use bootloader callback to
Hi,
This adds support for machine-specific primary boot blobs. This can be
used to install little bits of firmware or boot code without having
to throw the whole QEMU bootloader out and BYO (with device drivers
and all).
It is then used to fix two boards, Zynq and Highbank, both which have
small
These comment start immediately after the current longest name in the
list. Tab them out to the next tab stop to give a little breathing room
and prepare for FIXUP_BOARD_SETUP which will require more indent.
Signed-off-by: Peter Crosthwaite
---
hw/arm/boot.c | 16
1 file change
Firstly, enable monitor mode and PSCI, both are which are features of
this board.
In addition to PSCI, this board also uses SMC for cache maintainence
ops. This means we need a secure monitor to catch these and nop them.
Use the ARM boot board-setup feature to implement this.
Signed-off-by: Peter
Add an API for boards to inject their own preboot software (or
firmware) seqeuence.
The software then returns to bootloader via the link register. This
allows boards to do their own little bits of firmware setup without
needed to replace the bootloader completely (which is the requirement
for exis
On Thu, Oct 22, 2015 at 2:21 AM, Christian Pinto
wrote:
> Hello Peter,
>
>
> On 07/10/2015 17:48, Peter Crosthwaite wrote:
>>
>> On Mon, Oct 5, 2015 at 8:50 AM, Christian Pinto
>> wrote:
>>>
>>> Hello Peter,
>>>
>>> thanks for your comments
>>>
>>> On 01/10/2015 18:26, Peter Crosthwaite wrote:
>>
On Sun, Oct 25, 2015 at 07:42:00PM +0200, Victor Kaplansky wrote:
> QEMU is missing a good test for vhost-user feature,
The existing test is good actually.
It does not, however, allow actual traffic,
so at best it tests the management protocol.
> so I've created a sample vhost-user application, w
Dear Jason,
You were right both about the AIT and the FFMT! On a physical card,
the reserved bits in both of them read as zeros, even if they were set
to ones right before the reading.
V2 of the patches, with all the remarks addressed, is on the way.
Thanks again for your review.
Leonid.
___
On
On Sun, Oct 25, 2015 at 07:42:00PM +0200, Victor Kaplansky wrote:
> QEMU is missing a good test for vhost-user feature,
> so I've created a sample vhost-user application, which
> called Vubr (mst coined the name, but better
> suggestions will be appreciated).
Short for Vhost-User Bridge. Not very
QEMU is missing a good test for vhost-user feature,
so I've created a sample vhost-user application, which
called Vubr (mst coined the name, but better
suggestions will be appreciated). Vubr may later serve
the QEMU community as vhost-user QEMU internal test.
Essentially Vubr is a very basic vhost
On Sun, Oct 25, 2015 at 6:23 AM, Dmitry Osipenko wrote:
> 25.10.2015 02:55, Peter Crosthwaite пишет:
>
>> On Sat, Oct 24, 2015 at 3:22 PM, Dmitry Osipenko wrote:
>>>
>>> 24.10.2015 22:45, Peter Crosthwaite пишет:
This looks like a give-up without trying to get the correct valu
From: Dmitry Fleytman
This patch drops "vmx" prefix from packet abstrations names
to emphasize the fact they are generic and not tied to any
specific network device.
These abstrations will be reused by e1000e emulation implementation
introduced by following patches so their names need generaliza
From: Dmitry Fleytman
This patch extends TX/RX packet abstractions with features that will
be used by e1000e device implementation.
Changes are:
1. Support iovec lists for RX buffers
2. Deeper RX packets parsing
3. Loopback option for TX packets
4. Extended VLAN headers handling
Signed
From: Dmitry Fleytman
This patch introduces emulation for the Intel 82574 adapter, AKA e1000e.
This implementation is based on the e1000 emulation code, and
utilizes the TX/RX packet abstractions initially developed for the
vmxnet3 device. Although some parts of the introduced code are
common wi
From: Dmitry Fleytman
This patch introduces a handful macros
for tracing of Ethernet addresses.
There are 2 reasons for those macros to be added:
1. They will be used by future commits
introducing e1000e device emulation;
2. They fix vmxnet3 build with debug tracing enabled:
When
From: Dmitry Fleytman
Signed-off-by: Dmitry Fleytman
Signed-off-by: Leonid Bloch
---
hw/net/e1000_regs.h | 201 +++-
1 file changed, 199 insertions(+), 2 deletions(-)
diff --git a/hw/net/e1000_regs.h b/hw/net/e1000_regs.h
index 60b96aa..af154ad
Hello qemu-devel,
This patch series is an RFC for the new networking device emulation
we're developing for QEMU.
This new device emulates the Intel 82574 GbE Controller and works
with unmodified Intel e1000e drivers from the Linux/Windows kernels.
The status of the current series is "Functional
Existing callers are checking for MAP_FAILED,
so we should return that on error.
Reported-by: Paolo Bonzini
Signed-off-by: Michael S. Tsirkin
---
util/mmap-alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c
index 1394269..c37acb
On 8/18/15 01:31, Richard Henderson wrote:
>
> For single-precision it appears that the format is
>
> 63 31 24 10 9 0
> [ mantissa with implicit and guard bits | cmp flags | ?? | s | exp ]
>
> We are able to deduce the bias for the exponen
On 25/10/2015 15:54, Daniel P. Berrange wrote:
> On Sun, Oct 25, 2015 at 03:46:48PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 25/10/2015 14:20, Dennis Luehring wrote:
>>> qemu-system-alpha -m 1GB -nographic -monitor telnet::4440,server,nowait
>>> -serial telnet::3000,server -kernel clfskernel-4.2.3
On 16/10/2015 10:49, Michael S. Tsirkin wrote:
> Anonymous and file-backed RAM allocation are now almost exactly the same.
>
> Reduce code duplication by moving RAM mmap code out of oslib-posix.c and
> exec.c.
>
> Reported-by: Marc-André Lureau
> Signed-off-by: Michael S. Tsirkin
> Reviewed-b
On Sun, Oct 25, 2015 at 03:46:48PM +0100, Paolo Bonzini wrote:
>
>
> On 25/10/2015 14:20, Dennis Luehring wrote:
> > qemu-system-alpha -m 1GB -nographic -monitor telnet::4440,server,nowait
> > -serial telnet::3000,server -kernel clfskernel-4.2.3 -append
> > 'console=ttyS0' -initrd initramfs.cpio
On 25/10/2015 14:20, Dennis Luehring wrote:
> qemu-system-alpha -m 1GB -nographic -monitor telnet::4440,server,nowait
> -serial telnet::3000,server -kernel clfskernel-4.2.3 -append
> 'console=ttyS0' -initrd initramfs.cpio
>
> using: git clone -b "v2.4.0.1" git://git.qemu-project.org/qemu.git and
On 25/10/2015 14:57, Peter Maydell wrote:
> > Opinions? I would like to have this in 2.5 if there is agreement.
>
> Have you done any performance testing to check that we don't have
> previously-nopped-out tracepoints in hot paths that now result in
> real code being generated?
There definitely
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
The qemu_log_mask() output is following the same format as the
above debug.
Reviewed-by: Peter Crosthwaite
Signed-off-by: Jean-
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
The qemu_log_mask() output is following the same format as the
above debug.
Adding some missing qemu_log_mask call for bad regis
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
The qemu_log_mask() output is following the same format as
the above debug.
Reviewed-by: Peter Crosthwaite
Signed-off-by: Jean-
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output
is following the same format as the above debug.
Review
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
The qemu_log_mask() outputis following the same format as
the above debug.
Reviewed-by: Peter Crosthwaite
Signed-off-by: Jean-C
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output
is following the same format as the above debug.
Review
We fix all i.MX driver files to use the same type of debug code.
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output
is following the same format as the above debug.
Review
The goal is to have debug code always compiled during build.
We standardize all debug output on the following format:
[QOM_TYPE_NAME]reporting_function: debug message
We also replace IPRINTF with qemu_log_mask(). The qemu_log_mask() output
is following the same format as the above debug.
Review
On 25 October 2015 at 13:32, Paolo Bonzini wrote:
> This series does three things:
>
> 1) add a "-trace [enable=]foo" option to enable one or more trace
> events, and a "-trace help" option to show the list of tracepoints
> (patches 4-5)
>
> 2) change the stderr tracing backend so that it prints t
Split the bits that require it to exec/log.h.
Signed-off-by: Paolo Bonzini
---
bsd-user/main.c | 1 +
cpu-exec.c| 1 +
exec.c| 1 +
hw/acpi/cpu_hotplug.c | 1 +
hw/timer/a9gtimer.c | 1 +
include/exec/log.h
This is a bit easier to use than "-trace" if you are also enabling
other kinds of logging. It is also more discoverable for experienced
QEMU users, and accessible from user-mode emulators.
Signed-off-by: Paolo Bonzini
---
qemu-log.c | 16 +---
1 file changed, 13 insertions(+), 3 del
Signed-off-by: Paolo Bonzini
---
configure | 4 ++--
include/qemu/log.h | 1 +
qemu-log.c | 3 +++
scripts/tracetool/backend/{stderr.py => log.py} | 9 +
trace/control.c
Allow enabling events without going through a file, for example:
qemu-system-x86_64 -trace bdrv_aio_writev -trace bdrv_aio_readv
or with globbing too:
qemu-system-x86_64 -trace 'bdrv_aio_*'
if an appropriate backend is enabled (simple, stderr, ftrace).
Signed-off-by: Paolo Bonzini
---
This enables integration with other QEMU logging facilities.
Signed-off-by: Paolo Bonzini
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index d803e67..256d2c5 100755
--- a/configure
+++ b/configure
@@ -298,7 +298,7 @@ pkgversion=""
pie="
Print a list of trace points
Signed-off-by: Paolo Bonzini
---
qemu-options.hx | 2 ++
trace/control.c | 21 -
trace/control.h | 7 +++
3 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 6613911..6729a72 100644
--- a/qe
On 10/24/15 19:59, Michael S. Tsirkin wrote:
> On Fri, Oct 23, 2015 at 04:57:09PM +0200, Igor Mammedov wrote:
>> moves SSDT part to custom MHPT table, which is loaded
>> at runtime by OSPM if it supports ACPIv2 revision and
>> only if memory hotplug is enabled.
>> That should reduce ACPI tables blo
This is cleaner, and improves error reporting with -daemonize.
Signed-off-by: Paolo Bonzini
---
trace/control.c | 17 -
trace/control.h | 13 -
trace/simple.c | 6 ++
trace/simple.h | 4 ++--
vl.c| 13 +
5 files changed, 37 insertions(+
Mention the ftrace backend too.
Signed-off-by: Paolo Bonzini
---
qemu-options.hx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index edee5f4..71296da 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3484,13 +3484,13 @@ Spec
This is cleaner and has two advantages. First, it improves error
reporting with -daemonize. Second, multiple "-trace events" options
now cumulate.
Signed-off-by: Paolo Bonzini
---
trace/control.c | 5 ++---
trace/control.h | 15 ---
vl.c| 8
3 files changed,
This series does three things:
1) add a "-trace [enable=]foo" option to enable one or more trace
events, and a "-trace help" option to show the list of tracepoints
(patches 4-5)
2) change the stderr tracing backend so that it prints to the
-D log file, and enable it by default. "-trace file=..."
25.10.2015 02:55, Peter Crosthwaite пишет:
On Sat, Oct 24, 2015 at 3:22 PM, Dmitry Osipenko wrote:
24.10.2015 22:45, Peter Crosthwaite пишет:
This looks like a give-up without trying to get the correct value. If
the calculated value (using the normal-path logic below) is sane, you
should jus
qemu-system-alpha -m 1GB -nographic -monitor telnet::4440,server,nowait
-serial telnet::3000,server -kernel clfskernel-4.2.3 -append
'console=ttyS0' -initrd initramfs.cpio
using: git clone -b "v2.4.0.1" git://git.qemu-project.org/qemu.git and build
i see the normal
"QEMU waiting for connection
On Fri, Oct 23, 2015 at 04:48:45PM +0800, Yuanhan Liu wrote:
> It turned out that it breaks stuff (VHOST_RESET_OWNER is not defined),
> so revert it:
>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html
>
> CC: "Michael S. Tsirkin"
> Reported-by: Paolo Bonzini
> Signed-
On 24/10/15 03:24, Pádraig Brady wrote:
> On 23/10/15 12:15, Pádraig Brady wrote:
>> On 22/10/15 20:47, Paolo Bonzini wrote:
>>>
>>>
>>> On 22/10/2015 19:39, Radim Krčmář wrote:
2015-10-22 18:14+0200, Paolo Bonzini:
> On 22/10/2015 18:02, Eric Blake wrote:
>> I see a bug in there:
bad indentation conflicts with CODING_STYLE doc
Signed-off-by: Cao jin
---
hw/pci/pcie.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 6e28985..e4bfe91 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -413,13 +413,13 @@ void
On 10/22/2015 4:45 AM, Alexander Duyck wrote:
+/* Record states hold by PF */
+memcpy(&state->vf_data, &adapter->vfinfo[vfn], sizeof(struct
vf_data_storage));
+
+vf_shift = vfn % 32;
+reg_offset = vfn / 32;
+
+reg = IXGBE_READ_REG(hw, IXGBE_VFTE(reg_offset));
+reg &= ~(1
82 matches
Mail list logo
