[Qemu-devel] qcow2 snapshot + resize

2015-12-29 Thread lihuiba
Hi, In our production environment, we need to extend a qcow2 image with snapshots in it. This feature, however, is not implemented yet. So I want to ask, if this feature is under active development? How can I help with this feature? It seems that, this feature is not too difficult as long

Re: [Qemu-devel] [PATCH 10/12] Support for quad commands.

2015-12-29 Thread Lenkow, Pawel (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Wednesday, December 23, 2015 3:25 AM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw); Cédric Le Goater > Cc: qemu-devel@nongnu.org Developers; Lenkow, Pawel (Nokia - > PL/Wroclaw) > Subject: Re:

Re: [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

2015-12-29 Thread Michael S. Tsirkin
On Tue, Dec 29, 2015 at 07:17:46PM +0300, Roman Kagan wrote: > On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote: > > On Fri, 25 Dec 2015 18:04:08 +0300 > > Roman Kagan wrote: > > > > > Windows on UEFI systems is only capable of detecting the presence and > > >

Re: [Qemu-devel] [PATCH 00/25] target-sparc improvements

2015-12-29 Thread Mark Cave-Ayland
On 17/12/15 20:54, Richard Henderson wrote: > The primary focus of this patch set is to reduce the number of > helpers that modify TCG globals, and thus increase the lifetime > of those globals within each TB, and thus decrease the number > of times that tcg must spill and fill them from backing

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-29 Thread Michael S. Tsirkin
On Tue, Dec 29, 2015 at 09:04:51AM -0800, Alexander Duyck wrote: > On Tue, Dec 29, 2015 at 8:46 AM, Michael S. Tsirkin wrote: > > On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote: > >> > >> > >> On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote: > >> >As long as you keep

Re: [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

2015-12-29 Thread Igor Mammedov
On Tue, 29 Dec 2015 19:17:46 +0300 Roman Kagan wrote: > On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote: > > On Fri, 25 Dec 2015 18:04:08 +0300 > > Roman Kagan wrote: > > > > > Windows on UEFI systems is only capable of detecting the

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-29 Thread Michael S. Tsirkin
On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote: > > > On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote: > >As long as you keep up this vague talk about performance during > >migration, without even bothering with any measurements, this patchset > >will keep going nowhere. > > > > I

[Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2015-12-29 Thread Programmingkid
This patch solves the few problems that needed to be solved in order for a Mac OS 10.4 guest to use the rtl8139 nic. The pci_dma_read() function would only return zero when a MemoryRegion object was not enabled. Enabling the object makes the pci_dma_read() function work correctly. The Linux

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

2015-12-29 Thread Paolo Bonzini
>>> Separated from previous "igd-passthru convert to realize" patch. Since >>> these two don`t have dependency, can send it solely. >>> >>> Not test since it is easy to find out if reading carefully, just >>> compiled. This patch works but the added conversion to LE is conceptually wrong. The

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-29 Thread Alexander Duyck
On Tue, Dec 29, 2015 at 9:15 AM, Michael S. Tsirkin wrote: > On Tue, Dec 29, 2015 at 09:04:51AM -0800, Alexander Duyck wrote: >> On Tue, Dec 29, 2015 at 8:46 AM, Michael S. Tsirkin wrote: >> > On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote: >> >> >>

[Qemu-devel] [Bug 1529859] [NEW] qemu 2.5.0 ivshmem segfault with msi=off option

2015-12-29 Thread maquefel
Public bug reported: Launching qemu with "-device ivshmem,chardev=ivshmemid,msi=off -chardev socket,path=/tmp/ivshmem_socket,id=ivshmemid" Causes segfault because, s->msi_vectors is not initialized and s->msi_vectors == 0. Does ivshmem exactly need this line ? : s->msi_vectors[vector].pdev =

Re: [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

2015-12-29 Thread Roman Kagan
On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote: > On Fri, 25 Dec 2015 18:04:08 +0300 > Roman Kagan wrote: > > > Windows on UEFI systems is only capable of detecting the presence and > > the type of floppy drives via corresponding ACPI objects. > > > > Those

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-29 Thread Alexander Duyck
On Tue, Dec 29, 2015 at 8:46 AM, Michael S. Tsirkin wrote: > On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote: >> >> >> On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote: >> >As long as you keep up this vague talk about performance during >> >migration, without even

[Qemu-devel] [PATCH] acpi: allow NUMA memoryless node 0

2015-12-29 Thread Thadeu Lima de Souza Cascardo
Put the 0-640KiB range in the first node with memory. This also prevents mem_len to underflow when node 0 size is 0. Tested with Linux. Signed-off-by: Thadeu Lima de Souza Cascardo --- hw/i386/acpi-build.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2015-12-29 Thread Programmingkid
On Dec 29, 2015, at 7:05 PM, Programmingkid wrote: > > On Dec 29, 2015, at 4:04 PM, Mark Cave-Ayland wrote: > >> On 29/12/15 17:59, Programmingkid wrote: >> >>> This patch solves the few problems that needed to be solved in order for a >>> Mac OS 10.4 guest to use the rtl8139 nic. >>> >>>

[Qemu-devel] [PATCH] linux-user/mmap.c: Support shared memory mapping in mmap_frag()

2015-12-29 Thread chengang
From: Chen Gang It is a temporary fix for i386 target system running Windows. Also remove useless variable 'p'. Signed-off-by: Chen Gang --- linux-user/mmap.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()

2015-12-29 Thread chengang
From: Chen Gang When mapping MAP_ANONYMOUS memory fragments, still need notice about to set it zero, or it will cause issues. Signed-off-by: Chen Gang --- linux-user/mmap.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2015-12-29 Thread Programmingkid
On Dec 29, 2015, at 4:04 PM, Mark Cave-Ayland wrote: > On 29/12/15 17:59, Programmingkid wrote: > >> This patch solves the few problems that needed to be solved in order for a >> Mac OS 10.4 guest to use the rtl8139 nic. >> >> The pci_dma_read() function would only return zero when a

Re: [Qemu-devel] [PULL 49/57] Round up RAMBlock sizes to host page sizes

2015-12-29 Thread Peter Crosthwaite
On Tue, Nov 10, 2015 at 6:25 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > RAMBlocks that are not a multiple of host pages in length > cause problems for postcopy (I've seen an ACPI table on aarch64 > be 5k in length - i.e. 5x

Re: [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()

2015-12-29 Thread Laurent Vivier
Le 30/12/2015 02:10, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > When mapping MAP_ANONYMOUS memory fragments, still need notice about to > set it zero, or it will cause issues. > > Signed-off-by: Chen Gang > --- >

Re: [Qemu-devel] [PATCH] linux-user/mmap.c: Support shared memory mapping in mmap_frag()

2015-12-29 Thread Chen Gang
Hello all: This patch is only for a discussion, I guess this patch is valuable for i386 wine running Windows. Theoretically, this patch is incorrect, we have to implement softmmu to support different host and target pages (e.g. host 8KB, target 4KB): - If host 8KB is mapped as PRIVATE | FIXED,

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

2015-12-29 Thread Cao jin
Hi Paolo On 12/30/2015 12:25 AM, Paolo Bonzini wrote: Separated from previous "igd-passthru convert to realize" patch. Since these two don`t have dependency, can send it solely. Not test since it is easy to find out if reading carefully, just compiled. This patch works but the added

Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2015-12-29 Thread Mark Cave-Ayland
On 29/12/15 17:59, Programmingkid wrote: > This patch solves the few problems that needed to be solved in order for a > Mac OS 10.4 guest to use the rtl8139 nic. > > The pci_dma_read() function would only return zero when a MemoryRegion object > was not enabled. Enabling the object makes the

Re: [Qemu-devel] [PATCH v2 1/2] utils: Add warning messages

2015-12-29 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Adds a special error object that transforms error messages into >> immediately reported warnings. > Before I dive into details: my fundamental objection is that _warn > is new infrastructure without a use. The new "this

[Qemu-devel] [PATCH 1/2] nbd: Interface tweak of nbd_client_new

2015-12-29 Thread Fam Zheng
In preparation for an async implementation, introduce a callback and move the shutdown/close to the function. Signed-off-by: Fam Zheng --- blockdev-nbd.c | 5 ++--- include/block/nbd.h | 6 -- nbd.c | 20 +++- qemu-nbd.c | 16

[Qemu-devel] [PATCH 2/2] nbd: Coroutine based nbd_send_negotiate

2015-12-29 Thread Fam Zheng
Create a coroutine in nbd_client_new, so that nbd_send_negotiate doesn't need qemu_set_block(). A handler is needed for csock fd in case the coroutine yields during I/O. With this, if the other end disappears in the middle of the negotiation, we don't block the whole event loop. Signed-off-by:

[Qemu-devel] [PATCH 0/2] nbd: Async built-in server negotiation

2015-12-29 Thread Fam Zheng
During nbd_send_negotiate, if the client simply doesn't respond, the function will not return, and the whole event loop is blocked. Make the I/O effectively asynchronous by using coroutine read/write, so that a malicious or disappeared client cannot make a hang. Fam Fam Zheng (2): nbd:

[Qemu-devel] [PATCH] net: ne2000: fix bounds check in ioport operations

2015-12-29 Thread P J P
From: Prasad J Pandit While doing ioport r/w oprations, ne2000 device emulation suffers from OOB r/w error. Update respective array bounds check to avoid OOB access. Reported-by: Ling Liu Signed-off-by: Prasad J Pandit ---

[Qemu-devel] [PATCH] net: ne2000: fix bounds check in ioport operations

2015-12-29 Thread P J P
From: Prasad J Pandit Hello, An OOB r/w issue in ne2000 device emulation was reported by Mr Ling Liu, CC'd here. The issue occurs while doing ne2000 ioport r/w operations, due to incorrect array bounds checks. Below is a proposed (tested)patch to fix this issue. Does it

[Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2015-12-29 Thread Cao jin
Signed-off-by: Cao jin --- changelog v4: 1. strip the bugfix code, but I guess this patch should be applied after that bugfix patch. 2. Other little fix as per previous review Some explanation to previous review: 1. error_setg_errno() I use in this patch will print

[Qemu-devel] [PATCH trivial] unicore32: convert get_sp_from_cpustate from macro to inline

2015-12-29 Thread Michael Tokarev
All other architectures define get_sp_from_cpustate as an inline function, only unicore32 uses a #define. With this, some usages are impossible, for example, enabling sigaltstack in linux-user/syscall.c results in linux-user/syscall.c: In function ‘do_syscall’: linux-user/syscall.c:8299:39:

[Qemu-devel] [PATCH trivial] linux-user: enable sigaltstack for all architectures

2015-12-29 Thread Michael Tokarev
There is no reason to limit sigaltstack syscall to just a few architectures and pretend it is not implemented for others. If some architecture is not ready for this, that architecture should be fixed instead. This fixes LP#1516408. Signed-off-by: Michael Tokarev --- This patch

[Qemu-devel] [PATCH 06/17] i8257: add missing const

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index a3227a1..03d27de 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -86,7 +86,7 @@ enum { static void

[Qemu-devel] [PATCH 15/17] gus: use IsaDma interface instead of global DMA_* functions

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/audio/gus.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index e0c8a4e..b027eb5 100644 --- a/hw/audio/gus.c +++ b/hw/audio/gus.c @@ -57,6 +57,7 @@ typedef

[Qemu-devel] [PATCH 08/17] isa: add an ISA DMA interface, and store it within the ISA bus

2015-12-29 Thread Hervé Poussineau
This will permit to deprecate global DMA_*() functions. Signed-off-by: Hervé Poussineau --- hw/isa/isa-bus.c| 21 + include/hw/isa/isa.h| 38 ++ include/qemu/typedefs.h | 1 + 3 files changed, 60

[Qemu-devel] [PATCH 05/17] i8257: make the DMA running method per controller

2015-12-29 Thread Hervé Poussineau
This removes some static/global variables, and we're now running only the required controller (master or slave) Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 75 ++ 1 file changed, 34 insertions(+), 41

[Qemu-devel] [PATCH 09/17] i8257: implement the IsaDma interface

2015-12-29 Thread Hervé Poussineau
Rewrite the global DMA_*() functions to use the IsaDma interface. Note that these functions will be deleted in a few commits. Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 148 + 1 file changed, 117

[Qemu-devel] [PATCH 16/17] sb16: use IsaDma interface instead of global DMA_* functions

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/audio/sb16.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index 995435f..9973e77 100644 --- a/hw/audio/sb16.c +++ b/hw/audio/sb16.c @@ -55,6 +55,8 @@

[Qemu-devel] [PATCH 01/17] i82374: device only existed as ISA device, so simplify device

2015-12-29 Thread Hervé Poussineau
Merge ISAi82374State fields into parent structure I82374State. Signed-off-by: Hervé Poussineau --- hw/dma/i82374.c | 58 +++-- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/hw/dma/i82374.c

[Qemu-devel] [PATCH 17/17] dma: remove now useless DMA_* functions

2015-12-29 Thread Hervé Poussineau
Keep only DMA_init function as a wrapper around DMA controllers creation. Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 65 hw/sparc/sun4m.c | 22 -- hw/sparc64/sun4u.c | 22

[Qemu-devel] [PATCH 13/17] fdc: use IsaDma interface instead of global DMA_* functions

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 63 ++ 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 14891c1..3c3d046 100644 --- a/hw/block/fdc.c +++

[Qemu-devel] [PATCH 11/17] sparc: disable floppy DMA

2015-12-29 Thread Hervé Poussineau
All functions relative to DMA (DMA_*() functions) are stubs on sparc platform. Disable the DMA in the floppy controller, instead of calling these stubs. Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/fdc.c

[Qemu-devel] [PATCH 12/17] sparc64: disable floppy DMA

2015-12-29 Thread Hervé Poussineau
All functions relative to DMA (DMA_*() functions) are stubs on sparc64 platform. Disable the DMA of the floppy controller, instead of calling these stubs. Signed-off-by: Hervé Poussineau --- hw/sparc64/sun4u.c | 13 - 1 file changed, 12 insertions(+), 1

[Qemu-devel] [PATCH 04/17] i8257: rename functions to start with i8257_ prefix

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 91 +- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index f4fcf39..aba4295 100644 --- a/hw/dma/i8257.c +++

[Qemu-devel] [PATCH 10/17] magnum: disable floppy DMA for now

2015-12-29 Thread Hervé Poussineau
Floppy uses the DMA controller in rc4030 chipset, and not the i8259 from the ISA bus. It's better to disable DMA than to call the wrong DMA controller. Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 5 +++-- hw/mips/mips_jazz.c| 3 ++-

[Qemu-devel] [PATCH 09/17] i8257: register the IsaDma interface

2015-12-29 Thread Hervé Poussineau
Rewrite the global DMA_*() functions to use the IsaDma interface. Note that they will be deleted in a few commits. Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 148 + 1 file changed, 117 insertions(+), 31

[Qemu-devel] [PATCH 02/17] i8257: pass ISA bus to DMA_init() function

2015-12-29 Thread Hervé Poussineau
i8257 DMA controller exists on one ISA bus, so let's specify it at initialization. Signed-off-by: Hervé Poussineau --- hw/dma/i82374.c | 2 +- hw/dma/i8257.c | 2 +- hw/i386/pc.c| 2 +- hw/mips/mips_fulong2e.c | 2 +- hw/mips/mips_jazz.c |

[Qemu-devel] [PATCH 14/17] cs4231a: use IsaDma interface instead of global DMA_* functions

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/audio/cs4231a.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index f96f561..d84f83f 100644 --- a/hw/audio/cs4231a.c +++ b/hw/audio/cs4231a.c @@

[Qemu-devel] [PATCH 03/17] i8257: rename struct dma_cont to I8257State

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 4d0b49d..f4fcf39 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@

[Qemu-devel] [PATCH 00/17] ISA DMA controllers cleanup (i8257, i82374)

2015-12-29 Thread Hervé Poussineau
Hi, This patchset is a cleanup of the i8257/i82374 ISA DMA controllers. Global DMA_* functions will be obsoleted and then deleted, and ISA devices will not be tied anymore to i8257 DMA device implementation. This paves the way to fix support for floppy DMA operations on sparc/sparc64/MIPS

[Qemu-devel] [PATCH 07/17] i8257: QOM'ify

2015-12-29 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 160 ++--- 1 file changed, 107 insertions(+), 53 deletions(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 03d27de..20231d6 100644 --- a/hw/dma/i8257.c +++

Re: [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify

2015-12-29 Thread Cao jin
On 12/29/2015 06:28 PM, Stefan Weil wrote: Am 29.12.2015 um 11:13 schrieb Cao jin: merge three lines into one line Signed-off-by: Cao jin --- hw/xen/Makefile.objs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xen/Makefile.objs

Re: [Qemu-devel] [PATCH trivial v2] xen/Makefile.objs: simplify

2015-12-29 Thread Stefan Weil
Am 29.12.2015 um 13:39 schrieb Cao jin: > merge last two lines, keep alphabetic order. > > Signed-off-by: Cao jin > --- > hw/xen/Makefile.objs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs >

[Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify

2015-12-29 Thread Cao jin
merge three lines into one line Signed-off-by: Cao jin --- hw/xen/Makefile.objs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs index a9ad7e7..77806f0 100644 --- a/hw/xen/Makefile.objs +++

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

2015-12-29 Thread Cao jin
CC the code author: Tiejun Chen On 12/28/2015 12:42 PM, Cao jin wrote: Fix the bug introduced by 595a4f07: Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). And because value in PCI config space are

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2015-12-29 Thread Cao jin
Agree with your review point. Since can`t get contact with author tiejun.c...@intel.com, maybe only can ask for test help from Stefano, I will send next version when we get in touch with stefano. On 12/29/2015 07:25 PM, Michael S. Tsirkin wrote: On Tue, Dec 29, 2015 at 04:46:03PM +0800, Cao

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-29 Thread Igor Mammedov
On Thu, 24 Dec 2015 09:59:53 +0800 Zhu Guihua wrote: > > On 12/17/2015 05:58 AM, Igor Mammedov wrote: > > On Wed, 16 Dec 2015 16:46:37 +0100 > > Andreas Färber wrote: > > > >> Am 10.12.2015 um 13:35 schrieb Igor Mammedov: > >>> wrt CLI can't we do

Re: [Qemu-devel] [PATCH trivial] unicore32: convert get_sp_from_cpustate from macro to inline

2015-12-29 Thread Peter Maydell
On 29 December 2015 at 09:43, Michael Tokarev wrote: > All other architectures define get_sp_from_cpustate as an inline function, > only unicore32 uses a #define. With this, some usages are impossible, for > example, enabling sigaltstack in linux-user/syscall.c results in > >

[Qemu-devel] [PATCH trivial v2] xen/Makefile.objs: simplify

2015-12-29 Thread Cao jin
merge last two lines, keep alphabetic order. Signed-off-by: Cao jin --- hw/xen/Makefile.objs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs index a9ad7e7..d367094 100644 --- a/hw/xen/Makefile.objs +++

Re: [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

2015-12-29 Thread Igor Mammedov
On Fri, 25 Dec 2015 18:04:08 +0300 Roman Kagan wrote: > Windows on UEFI systems is only capable of detecting the presence and > the type of floppy drives via corresponding ACPI objects. > > Those objects are added in the last patch of the series; the three > preceding ones

Re: [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify

2015-12-29 Thread Stefan Weil
Am 29.12.2015 um 11:13 schrieb Cao jin: > merge three lines into one line > > Signed-off-by: Cao jin > --- > hw/xen/Makefile.objs | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs > index

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2015-12-29 Thread Michael S. Tsirkin
On Tue, Dec 29, 2015 at 04:46:03PM +0800, Cao jin wrote: > Signed-off-by: Cao jin > --- > changelog v4: > 1. strip the bugfix code, but I guess this patch should be applied after >that bugfix patch. > 2. Other little fix as per previous review > > Some explanation

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

2015-12-29 Thread Cao jin
Oops, got following feedback 2nd time: The following message to was undeliverable. The reason for the problem: 5.1.0 - Unknown address error 550-'#5.1.0 Address rejected.' I guess the author address is not available anymore On 12/29/2015 07:54 PM, Cao jin wrote: CC the

[Qemu-devel] [PATCH] Fix wrong format specifiers in trace events

2015-12-29 Thread Stefan Weil
* Add missing % before PRIx64 * Remove unneeded "" at end of format string in modified lines This fixes a regression introduced in commit c8ee0a445a6a85635e962c0346bc7b1259c1a3f5. Signed-off-by: Stefan Weil --- The patch should also be used for v2.5.1. Happy New Year! Stefan