Re: [Qemu-devel] Status of my hacks on the MTTCG WIP branch

2016-01-19 Thread alvise rigo
On Mon, Jan 18, 2016 at 8:09 PM, Alex Bennée wrote: > > > Alex Bennée writes: > > > alvise rigo writes: > > > >> On Fri, Jan 15, 2016 at 4:25 PM, Alex Bennée > >> wrote: > >>> > >>> alvise

Re: [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev

2016-01-19 Thread Hailiang Zhang
Hi Jason, Thanks for your review. On 2016/1/19 11:19, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: We add each netdev (except vhost-net) a default filter-buffer, which will be used for COLO or Micro-checkpoint to buffer VM's packets. The name of default filter-buffer is

Re: [Qemu-devel] [PATCH COLO-Frame v13 35/39] filter-buffer: Accept zero interval

2016-01-19 Thread Hailiang Zhang
On 2016/1/19 11:21, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: For default buffer filter, its 'interval' value is zero, so here we should accept zero interval. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang

Re: [Qemu-devel] [PATCH COLO-Frame v13 36/39] filter-buffer: Introduce a helper function to enable/disable default filter

2016-01-19 Thread Hailiang Zhang
On 2016/1/19 11:35, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: The default buffer filter doesn't buffer packets in default, but we need to buffer packets for COLO or Micro-checkpoint, Here we add a helper function to enable/disable filter's buffer capability.

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-19 Thread Peter Maydell
On 19 January 2016 at 07:27, Markus Armbruster wrote: > Peter Maydell writes: > >> On 11 January 2016 at 15:19, Daniel P. Berrange wrote: >>> I think even guest-agent code & tests could include it in order to >>> get clean

Re: [Qemu-devel] [RE-RESEND PATCH] pci: Adjust PCI config limit based on bus topology

2016-01-19 Thread Marcel Apfelbaum
On 01/19/2016 01:06 AM, Alex Williamson wrote: A conventional PCI bus does not support config space accesses above the standard 256 byte configuration space. PCIe-to-PCI bridges are not permitted to forward transactions if the extended register address field is non-zero and must handle it as an

Re: [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification

2016-01-19 Thread Vladimir Sementsov-Ogievskiy
On 19.01.2016 00:16, Eric Blake wrote: preserving semantics of those extra_data bytes). We have enough room for future extension, and that's good e Ok, so, what should go to the spec? Current wording is ok? Just delete "Type-specific": + +20 - 23:extra_data_size +

Re: [Qemu-devel] [RFC PATCH v2 00/10] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-01-19 Thread Dmitry Fleytman
> On 19 Jan 2016, at 05:48 AM, Jason Wang wrote: > > > > On 01/19/2016 01:35 AM, Leonid Bloch wrote: >> Hello All, >> >> This series is the latest code of the e1000e device emulation being >> developed. >> >> Changes since v1: >> >> 1. Added support for all the device

Re: [Qemu-devel] [PATCH v1 1/1] arm_gic: Update ID registers based on revision

2016-01-19 Thread Peter Maydell
On 19 January 2016 at 01:33, Alistair Francis wrote: > Update the GIC ID registers (registers above 0xfe0) based on the GIC > revision instead of using the sames values for all GIC implementations. > > Signed-off-by: Alistair Francis >

Re: [Qemu-devel] [PATCH 1/1] nvdimm: disable balloon

2016-01-19 Thread Xiao Guangrong
On 01/18/2016 07:42 PM, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy NVDIMM for now is planned to use as a backing store for DAX filesystem in the guest and thus this memory is excluded from guest memory management and LRUs. In this case libvirt running

Re: [Qemu-devel] [PATCH v8 00/35] qapi visitor cleanups (post-introspection cleanups subset E)

2016-01-19 Thread Markus Armbruster
Eric Blake writes: > Based on qemu.git master. Pending prerequisites: > + Not a strong dependency, but for qapi-tests to consistently pass, > I needed a race fixed: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01827.html > > Also available as a tag at this

Re: [Qemu-devel] [PATCH v16 00/14] vfio-pci: pass the aer error to guest

2016-01-19 Thread Chen Fan
On 01/17/2016 02:34 AM, Michael S. Tsirkin wrote: On Tue, Jan 12, 2016 at 10:43:01AM +0800, Cao jin wrote: From: Chen Fan For now, for vfio pci passthough devices when qemu receives an error from host aer report, currentlly just terminate the guest, but usually

Re: [Qemu-devel] [PATCH v16 13/14] vfio-pci: pass the aer error to guest

2016-01-19 Thread Chen Fan
On 01/18/2016 06:45 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the

Re: [Qemu-devel] [PATCH v16 10/14] pci: introduce pci bus pre reset

2016-01-19 Thread Chen Fan
On 01/15/2016 04:36 AM, Alex Williamson wrote: On Tue, 2016-01-12 at 10:43 +0800, Cao jin wrote: From: Chen Fan avoid repeat bus reset, here introduce a sequence ID for each time bus hot reset, so each vfio device could know whether they've already been reset

Re: [Qemu-devel] [PATCH] hw/misc: slavepci_passthru driver

2016-01-19 Thread Francesco Zuliani
Hi Alex, On 01/18/2016 05:41 PM, Alex Williamson wrote: On Mon, 2016-01-18 at 10:16 -0500, Marc-André Lureau wrote: Hi - Original Message - Hi there, I'd like to submit this new pci driver ( hw/misc )for inclusion, if you think it could be useful to other as well as ourself. The

Re: [Qemu-devel] [PATCH 2/2] migration/virtio: Remove simple .get/.put use

2016-01-19 Thread Dr. David Alan Gilbert
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote: > Dear David, > > "Dr. David Alan Gilbert" writes: > > > +/* a variable length array (i.e. _type *_field) but we know the > > + * length > > + */ > > +#define VMSTATE_STRUCT_VARRAY_POINTER_KNOWN(_field, _state, _num, > >

[Qemu-devel] [PATCH v3 01/10] qom: add helpers for UserCreatable object types

2016-01-19 Thread Daniel P. Berrange
The QMP monitor code has two helper methods object_add and qmp_object_del that are called from several places in the code (QMP, HMP and main emulator startup). The HMP and main emulator startup code also share further logic that extracts the qom-type & id values from a qdict. We soon need to use

[Qemu-devel] [PATCH v3 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible

2016-01-19 Thread Daniel P. Berrange
This series of patches expands the syntax of the qemu-img, qemu-nbd and qemu-io commands to make them more flexible. v0: http://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html v2:

[Qemu-devel] [PATCH v3 02/10] qemu-img: add support for --object command line arg

2016-01-19 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-img via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-img info

Re: [Qemu-devel] [RFC PATCH v2 02/10] pci: Introduce function for PCI PM capability creation

2016-01-19 Thread Marcel Apfelbaum
On 01/18/2016 07:35 PM, Leonid Bloch wrote: From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pci.c | 21 +

[Qemu-devel] [PATCH v3 04/10] qemu-io: add support for --object command line arg

2016-01-19 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-io via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-io --object

[Qemu-devel] [PATCH v3 07/10] qemu-img: allow specifying image as a set of options args

2016-01-19 Thread Daniel P. Berrange
Currently qemu-img allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-img info https://127.0.0.1/images/centos7.iso This adds a --image-opts arg that indicates that the positional

[Qemu-devel] [PATCH v3 06/10] qemu-nbd: allow specifying image as a set of options args

2016-01-19 Thread Daniel P. Berrange
Currently qemu-nbd allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-nbd https://127.0.0.1/images/centos7.iso qemu-nbd /home/berrange/demo.qcow2 This adds a --image-opts arg that

[Qemu-devel] [PATCH v3 03/10] qemu-nbd: add support for --object command line arg

2016-01-19 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-nbd via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-nbd --object

[Qemu-devel] [PATCH v3 05/10] qemu-io: allow specifying image as a set of options args

2016-01-19 Thread Daniel P. Berrange
Currently qemu-io allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-io https://127.0.0.1/images/centos7.iso qemu-io /home/berrange/demo.qcow2 This adds a --image-opts arg that

[Qemu-devel] [PATCH v3 10/10] qemu-io: use no_argument/required_argument constants

2016-01-19 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-io.c | 30 +++--- 1 file

[Qemu-devel] [PATCH v3 08/10] qemu-nbd: don't overlap long option values with short options

2016-01-19 Thread Daniel P. Berrange
When defining values for long options, the normal practice is to start numbering from 256, to avoid overlap with the range of valid values for short options. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 12 ++-- 1

Re: [Qemu-devel] usb-storage assertions

2016-01-19 Thread Andrey Korolyov
On Tue, Jan 19, 2016 at 10:13 AM, Gerd Hoffmann wrote: > On Di, 2016-01-19 at 02:49 +0300, Andrey Korolyov wrote: >> On Mon, Jan 18, 2016 at 4:55 PM, Gerd Hoffmann wrote: >> > Hi, >> > >> >> > ok. Had no trouble with freebsd, will go fetch netbsd images.

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > The functions for migrating the hash page table on pseries machine type > > (htab_save_setup() and htab_load()) can report some errors with an > > explicit fprintf()

[Qemu-devel] [PATCH 1/1] vl: change QEMU state machine for system reset

2016-01-19 Thread Denis V. Lunev
This patch implements proposal from Paolo to handle system reset when the guest is not running. "After a reset, main_loop_should_exit should actually transition to VM_STATE_PRELAUNCH (*not* RUN_STATE_PAUSED) for *all* states except RUN_STATE_INMIGRATE, RUN_STATE_SAVE_VM (which I think cannot

Re: [Qemu-devel] [PATCH] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices

2016-01-19 Thread Marcel Apfelbaum
On 01/18/2016 08:16 PM, Laszlo Ersek wrote: On 01/18/16 19:08, Peter Maydell wrote: On 18 January 2016 at 15:27, Marcel Apfelbaum wrote: PCI devices can't be plugged directly into PCI extra root bridges because their resources can't be computed by firmware before the ACPI

Re: [Qemu-devel] [PATCH v3 ] doc: Introduce coding style for errors

2016-01-19 Thread Thomas Huth
On 18.01.2016 21:26, Eric Blake wrote: > On 01/15/2016 06:54 AM, Lluís Vilanova wrote: >> Gives some general guidelines for reporting errors in QEMU. >> >> Signed-off-by: Lluís Vilanova >> --- >> HACKING | 36 >> 1 file changed, 36

Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-19 Thread Daniel P. Berrange
On Mon, Jan 18, 2016 at 12:48:56PM -0700, Eric Blake wrote: > On 01/14/2016 05:16 AM, Daniel P. Berrange wrote: > > >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use > >>> +# > >> > >> Well, the only reason to use it would be to read data off an old > >> insecurely-encrypted

Re: [Qemu-devel] [PATCH v16 05/14] vfio: add pcie extanded capability support

2016-01-19 Thread Chen Fan
On 01/17/2016 09:22 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Hi, I noticed a type in the subject, extanded -> extended For vfio pcie device, we could expose the extended capability on PCIE bus. in order to avoid

Re: [Qemu-devel] [PATCH v4 0/2] block: Reject negative values for throttling options

2016-01-19 Thread Markus Armbruster
Fam Zheng writes: > v4: Add Max's rev-by in both patches, while fixing the "maxs" typo. > > v3: Address comments: > - Add test for large value; [Berto] > - Fix typos "negative" & "caught"; [Eric, Berto] > - Use "LL" suffix to the upper limit constant. [Berto] > > v2:

Re: [Qemu-devel] [PATCH v16 07/14] vfio: add aer support for vfio device

2016-01-19 Thread Chen Fan
On 01/18/2016 05:12 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by:

[Qemu-devel] cgroup blkio weight has no effect for qemu

2016-01-19 Thread 陈博
Hi folks, Could you please enlighten me about how to achieve proportional IO sharing by using cgroup, instead of qemu? My qemu config is like: -drive file=$DISKFILe,if=none,format=qcow2,cache=none,aio=native Test command inside vm is like: dd if=/dev/vdc of=/dev/null iflag=direct Cgroup

Re: [Qemu-devel] [PATCHv2 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

2016-01-19 Thread Alexey Kardashevskiy
On 01/19/2016 03:30 PM, David Gibson wrote: rtas_st_buffer() appears in spapr.h as though it were a widely used helper, but in fact it is only used for saving data in a format used by rtas_ibm_get_system_parameter(). This changes it to a local helper more specifically for that function. While

[Qemu-devel] cgroup blkio weight has no effect on qemu

2016-01-19 Thread 陈博
Hi folks, Could you enlighten me about how to achieve proportional IO sharing by using cgroup, instead of qemu? My qemu config is like: -drive file=$DISKFILe,if=none,format=qcow2,cache=none,aio=native Test command inside vm is like: dd if=/dev/vdc of=/dev/null iflag=direct Cgroup blkio

Re: [Qemu-devel] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

2016-01-19 Thread Greg Kurz
On Mon, 18 Jan 2016 13:25:19 +1100 David Gibson wrote: > On Fri, Jan 15, 2016 at 04:00:38PM +0100, Greg Kurz wrote: > > Altivec registers are 128-bit wide. They are stored in memory as two > > 64-bit values that must be byteswapped when the guest is little-endian. >

Re: [Qemu-devel] [PATCH v16 08/14] vfio: add check host bus reset is support or not

2016-01-19 Thread Chen Fan
On 01/18/2016 06:32 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Hi, I think the subject should be rephrased. when init vfio devices done, we should test all the devices supported aer whether conflict with others. For

Re: [Qemu-devel] [RFC 0/3] Draft implementation of HPT resizing (qemu side)

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 01:18:17PM +0530, Bharata B Rao wrote: > On Mon, Jan 18, 2016 at 04:44:38PM +1100, David Gibson wrote: > > Here is a draft qemu implementation of my proposed PAPR extension for > > allowing runtime resizing of a KVM/ppc64 guest's hash page table. > > That in turn will allow

[Qemu-devel] [PATCH v3 09/10] qemu-nbd: use no_argument/required_argument constants

2016-01-19 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 47

[Qemu-devel] [PATCH v4 3/4] char: don't assume telnet initialization will not block

2016-01-19 Thread Daniel P. Berrange
The current code for doing telnet initialization is writing to a socket without checking the return status. While it is highly unlikely to be a problem when writing to a bare socket, as the buffers are large enough to prevent blocking, this cannot be assumed safe with TLS sockets. So write the

[Qemu-devel] [PATCH v4 4/4] char: introduce support for TLS encrypted TCP chardev backend

2016-01-19 Thread Daniel P. Berrange
This integrates support for QIOChannelTLS object in the TCP chardev backend. If the 'tls-creds=NAME' option is passed with the '-chardev tcp' argument, then it will setup the chardev such that the client is required to establish a TLS handshake when connecting. There is no support for checking the

[Qemu-devel] [PATCH v4 0/4] Convert chardevs to QIOChannel & add TLS support

2016-01-19 Thread Daniel P. Berrange
This is an update of patches previously shown in an RFC posting RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04222.html v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03823.html v3:

[Qemu-devel] [PATCH v4 1/4] char: remove fixed length filename allocation

2016-01-19 Thread Daniel P. Berrange
A variety of places were snprintf()ing into a fixed length filename buffer. Some of the buffers were stack allocated, while another was heap allocated with g_malloc(). Switch them all to heap allocated using g_strdup_printf() avoiding arbitrary length restrictions. This also facilitates later

[Qemu-devel] [PATCH v4 2/4] char: convert from GIOChannel to QIOChannel

2016-01-19 Thread Daniel P. Berrange
In preparation for introducing TLS support to the TCP chardev backend, convert existing chardev code from using GIOChannel to QIOChannel. This simplifies the chardev code by removing most of the OS platform conditional code for dealing with file descriptor passing. Signed-off-by: Daniel P.

Re: [Qemu-devel] [PATCH 1/2] 9pfs: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
On Mon, 18 Jan 2016 17:35:25 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Signed-off-by: Greg Kurz > > --- I agree to all your suggestions. Thanks ! > > hw/9pfs/9p-handle.c |5 +++-- > >

Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
On Mon, 18 Jan 2016 17:39:28 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Hi, > > > > This series moves all the 9pfs/fsdev code to use error_report(), with the > > notable exception of virtfs-proxy-helper, which doesn't need it. > > > >

[Qemu-devel] [PATCH] ehci: update irq on reset

2016-01-19 Thread Gerd Hoffmann
After clearing the status register we also have to update the irq line status. Otherwise a irq which happends to be pending at reset time causes a interrupt storm. And the guest can't stop as the status register doesn't indicate any pending interrupt. Both NetBSD and FreeBSD hang on shutdown

Re: [Qemu-devel] usb-storage assertions

2016-01-19 Thread Gerd Hoffmann
Hi, > Probably not enough with driver subsystem to point even at the obvious > issue in the EHCI driver. I`d start with slowing down an emulated CPU > 10...100 times via its thread cg, leaving emulator code hanging with > enough CPU cycles and check if the issue is still here. If roots of > the

[Qemu-devel] [PATCH] hw/arm/virt: Add always-on property to the virt board timer

2016-01-19 Thread Christoffer Dall
The virt board has an arch timer, which is always on. Emit the "always-on" property to indicate to Linux that it can switch off the periodic timer and reduces the amount of interrupts injected into a guest. Signed-off-by: Christoffer Dall --- hw/arm/virt.c | 1 + 1

Re: [Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 05:51, John Snow wrote: > +/* Only RESET is allowed to an ATAPI device while BSY and/or DRQ are > set. */ > +if (s->status & (BUSY_STAT|DRQ_STAT)) { > +if (!(val == WIN_DEVICE_RESET) && (s->drive_kind == IDE_CD)) { I was going to complain about Pascal-ish

[Qemu-devel] [PATCH] nbd: use client_close() when negotiate phase fails

2016-01-19 Thread Daniel P. Berrange
When nbd_negotiate() fails, nbd_co_client_start() is directly calling client->close(). This eventually ends up calling nbd_client_put(), which does an assert(client->closing). Unfortunately we have not set the 'closing' flag, so the code now aborts. This bug was accidentally introduced in

Re: [Qemu-devel] [PATCH 3/5] ide: move buffered DMA cancel to core

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 05:51, John Snow wrote: > Buffered DMA cancellation was added to ATAPI devices and implemented > for the BMDMA HBA. Move the code over to common IDE code and allow > it to be used for any HBA. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 45

Re: [Qemu-devel] [PATCH 2/2] migration/virtio: Remove simple .get/.put use

2016-01-19 Thread Dr. David Alan Gilbert
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote: > Dear David, > > "Dr. David Alan Gilbert" writes: > > > Can you try this and let me know if it fixes it for you; I've > > still not managed to persuade x86-64 to fail. > > With Conny's hint re. virtio-1 (thanks!) I

[Qemu-devel] [PATCH] cpu: cpu_save/cpu_load is no more

2016-01-19 Thread Paolo Bonzini
Everything has been converted to vmstate. Signed-off-by: Paolo Bonzini --- exec.c| 6 -- include/qemu-common.h | 6 -- 2 files changed, 12 deletions(-) diff --git a/exec.c b/exec.c index 0d8ca3f..35705a1 100644 --- a/exec.c +++ b/exec.c @@ -628,12

Re: [Qemu-devel] [PATCH] nbd: use client_close() when negotiate phase fails

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 12:50, Daniel P. Berrange wrote: > When nbd_negotiate() fails, nbd_co_client_start() is > directly calling client->close(). This eventually > ends up calling nbd_client_put(), which does an > assert(client->closing). Unfortunately we have not > set the 'closing' flag, so the code

Re: [Qemu-devel] [PATCH 1/7] target-ppc: kvm: fix floating point registers sync on little-endian hosts

2016-01-19 Thread Greg Kurz
On Tue, 19 Jan 2016 11:55:10 +1100 David Gibson wrote: > On Mon, Jan 18, 2016 at 09:51:56AM +0100, Greg Kurz wrote: > > On Mon, 18 Jan 2016 13:16:44 +1100 > > David Gibson wrote: > > > > > On Fri, Jan 15, 2016 at 04:00:12PM +0100,

Re: [Qemu-devel] [PATCH 01/10] virtio: move VirtQueueElement at the beginning of the structs

2016-01-19 Thread Cornelia Huck
On Fri, 15 Jan 2016 13:41:49 +0100 Paolo Bonzini wrote: > The next patch will make virtqueue_pop/vring_pop allocate memory for a s/will make/will make it possible for/ ? I had to spend some time grepping through the code to find that blk and scsi (and gpu, which already

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-19 Thread Gerd Hoffmann
Hi, > > > +if (fw_cfg_dma_enabled(fw_cfg)) { > > > +option_rom[nb_option_roms].name = "linuxboot_dma.bin"; > > > +option_rom[nb_option_roms].bootindex = 0; > > > +} else { > > > +option_rom[nb_option_roms].name = "linuxboot.bin"; > > > +

[Qemu-devel] [PATCH v2 11/16] qdev: Define qdev_get_gpio_out

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite An API similar to the existing qdev_get_gpio_in() except gets outputs. Useful for: 1: Implementing lightweight devices that don't want to keep pointers to their own GPIOs. They can get their GPIO pointers at runtime from QOM using this API.

[Qemu-devel] [PATCH v2 09/16] dma: Add Xilinx Zynq devcfg device model

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Minimal device model for devcfg module of Zynq. DMA capabilities and interrupt generation supported. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- Changed

[Qemu-devel] [PATCH v2 13/16] irq: Add opaque setter routine

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add a routine to set or override the opaque data of an IRQ. Qdev currently always initialises IRQ opaque as the device itself. This allows you to override to a custom opaque in the case where there is extra or different data needed.

[Qemu-devel] [PATCH v2 10/16] xilinx_zynq: add devcfg to machine model

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- Changed since v3: Author reset. Changed since v1: Added manual parenting of devcfg node (evil but needed for

[Qemu-devel] [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-19 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John

Re: [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register()

2016-01-19 Thread Eric Blake
On 01/15/2016 05:00 AM, David Gibson wrote: > The errors detected in this function necessarily indicate bugs in the rest > of the qemu code, rather than an external or configuration problem. > > So, a simple assert() is more appropriate than any more complex error > reporting. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 0/3] Use QCryptoSecret for block device passwords

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 17:46, Daniel P. Berrange wrote: > On Tue, Jan 19, 2016 at 05:32:35PM +0100, Paolo Bonzini wrote: >> >> >> On 19/01/2016 14:51, Daniel P. Berrange wrote: >>> This series was previously posted: >>> >>> v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html >>>

Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises

2016-01-19 Thread Lluís Vilanova
Edgar E Iglesias writes: > On Sat, Jan 16, 2016 at 09:57:36PM +0100, Lluís Vilanova wrote: >> Richard Henderson writes: >> >> > On 01/15/2016 12:12 PM, Lluís Vilanova wrote: >> >> Richard Henderson writes: >> >> >> >>> On 01/15/2016 07:35 AM, Lluís Vilanova wrote: >> +TCGv_i64

Re: [Qemu-devel] [PATCH v3] s390: use FILE instead of QEMUFile for creating text file

2016-01-19 Thread Eric Blake
On 01/18/2016 04:05 AM, Daniel P. Berrange wrote: > The s390 skeys monitor command needs to write out a plain text > file. Currently it is using the QEMUFile class for this, but > work is ongoing to refactor QEMUFile and eliminate much code > related to it. The only feature qemu_fopen() gives over

[Qemu-devel] [PATCH v2 15/16] misc: Introduce ZynqMP IOU SLCR

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite IOU = I/O Unit SLCR = System Level Control Registers This IP is a misc collections of control registers that switch various properties of system IPs. Currently the only thing implemented is the SD_SLOTTYPE control (implemented as a GPIO

[Qemu-devel] [PATCH v2 08/16] bitops: Add ONES macro

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Little macro that just gives you N ones (justified to LSB). Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- include/qemu/bitops.h | 2 ++ 1 file changed, 2

[Qemu-devel] [PATCH v2 06/16] register: QOMify

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite QOMify registers as a child of TYPE_DEVICE. This allows registers to define GPIOs. Define an init helper that will do QOM initialisation as well as setup the r/w fast paths. Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PATCH v2 12/16] qdev: Add qdev_pass_all_gpios API

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite For passing all GPIOs of all names from a contained device to a container. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- hw/core/qdev.c | 9

Re: [Qemu-devel] [PATCH v4 8/9] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

2016-01-19 Thread Eric Blake
On 01/15/2016 09:38 AM, Lluís Vilanova wrote: > Each event with the 'vcpu' property gets a per-vCPU dynamic tracing state. > > The set of enabled events with the 'vcpu' and 'tcg' properties is used > to select a per-vCPU physical TB cache. The number of events with both > properties is used to

[Qemu-devel] [PATCH v2 05/16] register: Define REG and FIELD macros

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Define some macros that can be used for defining registers and fields. The REG32 macro will define A_FOO, for the byte address of a register as well as R_FOO for the uint32_t[] register number (A_FOO / 4). The FIELD macro will define

[Qemu-devel] [PATCH v2 07/16] register: Add block initialise helper

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add a helper that will scan a static RegisterAccessInfo Array and populate a container MemoryRegion with registers as defined. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis

[Qemu-devel] [PATCH v2 04/16] register: Add support for decoding information

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Allow defining of optional address decoding information in register definitions. This is useful for clients that want to associate registers with specific addresses. Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PATCH v2 03/16] register: Add Memory API glue

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add memory io handlers that glue the register API to the memory API. Just translation functions at this stage. Although it does allow for devices to be created without all-in-one mmio r/w handlers. Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PATCH v2 14/16] register: Add GPIO API

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add GPIO functionality to the register API. This allows association and automatic connection of GPIOs to bits in registers. GPIO inputs will attach to handlers that automatically set read-only bits in registers. GPIO outputs will be updated

[Qemu-devel] [PATCH v2 16/16] xlnx-zynqmp: Connect the ZynqMP IOU SLCR

2016-01-19 Thread Alistair Francis
Connect the I/O Unit System Level Control Registers device to the ZynqMP model. Unfortunatly the GPIO links can not be connected yet as the SD device is not yet attached to the ZynqMP machine. Signed-off-by: Alistair Francis --- V2: - Fix up device connection

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2016-01-19 Thread Edgar E. Iglesias
On 19 Jan 2016 20:52, "Alistair Francis" wrote: > > On Fri, Jan 8, 2016 at 3:05 AM, Edgar E. Iglesias > wrote: > > On Fri, Jan 08, 2016 at 10:40:28AM +, Peter Maydell wrote: > >> On 8 January 2016 at 00:39, Alistair Francis > >>

[Qemu-devel] [PATCH v2 00/16] data-driven device registers

2016-01-19 Thread Alistair Francis
This patch series is based on Peter C's original register API. His original cover letter is below. I have added a new function memory_region_add_subregion_no_print() which stops memory regions from being printed by 'info mtree'. This is used to avoid evey register being printed when running 'info

[Qemu-devel] [PATCH v2 02/16] register: Add Register API

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite This API provides some encapsulation of registers and factors our some common functionality to common code. Bits of device state (usually MMIO registers), often have all sorts of access restrictions and semantics associated with them. This

[Qemu-devel] [PATCH v2 01/16] memory: Allow subregions to not be printed by info mtree

2016-01-19 Thread Alistair Francis
Add a function called memory_region_add_subregion_no_print() that creates memory subregions that won't be printed when running the 'info mtree' command. Signed-off-by: Alistair Francis --- include/exec/memory.h | 17 + memory.c | 10

[Qemu-devel] [PATCH v2 6/6] ide: fix device_reset to not ignore pending AIO

2016-01-19 Thread John Snow
Signed-off-by: John Snow --- hw/ide/core.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 9bc8e58..c68d1d4 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -502,7 +502,6 @@ void

[Qemu-devel] [PATCH] usb: check page select value while processing iTD

2016-01-19 Thread P J P
From: Prasad J Pandit While processing isochronous transfer descriptors(iTD), the page select(PG) field value could lead to an OOB read access. Add check to avoid it. Reported-by: Qinghao Tang Signed-off-by: Prasad J Pandit

[Qemu-devel] [PATCH] target-arm: Make various system registers visible to EL3

2016-01-19 Thread Peter Maydell
The AArch64 system registers DACR32_EL2, IFSR32_EL2, SPSR_IRQ, SPSR_ABT, SPSR_UND and SPSR_FIQ are visible and fully functional from EL3 even if the CPU has no EL2 (unlike some others which are RES0 from EL3 in that configuration). Move them from el2_cp_reginfo[] to v8_cp_reginfo[] so they are

Re: [Qemu-devel] [PATCH] sheepdog: allow to delete snapshot

2016-01-19 Thread Jeff Cody
On Wed, Dec 23, 2015 at 09:22:26PM +0900, Hitoshi Mitake wrote: > From: Vasiliy Tolstov > > This patch implements a blockdriver function bdrv_snapshot_delete() in > the sheepdog driver. With the new function, snapshots of sheepdog can > be deleted from libvirt. > > Cc: Jeff

Re: [Qemu-devel] [PATCH v1 17/17] arm: boot: Support big-endian elfs

2016-01-19 Thread Peter Maydell
On 18 January 2016 at 07:12, Peter Crosthwaite wrote: > Support ARM big-endian ELF files in system-mode emulation. When loading > an elf, determine the endianness mode expected by the elf, and set the > relevant CPU state accordingly. > > With this, big-endian modes

Re: [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support

2016-01-19 Thread Peter Maydell
On 18 January 2016 at 07:12, Peter Crosthwaite wrote: > Hi All, > > This patch series adds system-mode big-endian support for ARM. It also > implements the setend instruction, and loading of BE binaries even in > LE emulation mode. > > Based on Paolo's original work. I

Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

2016-01-19 Thread Peter Maydell
On 15 January 2016 at 18:15, Richard Henderson wrote: > On 01/15/2016 09:53 AM, Peter Maydell wrote: >>> @@ -58,7 +58,7 @@ static struct pathelem *new_entry(const char *root, >>> #if defined(DT_DIR) && defined(DT_UNKNOWN) && defined(DT_LNK) >>> # define dirent_type(dirent)

Re: [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification

2016-01-19 Thread Kevin Wolf
Am 11.01.2016 um 14:05 hat Vladimir Sementsov-Ogievskiy geschrieben: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add always-on property to the virt board timer

2016-01-19 Thread Andrew Jones
On Tue, Jan 19, 2016 at 01:43:07PM +, Marc Zyngier wrote: > On 19/01/16 13:32, Andrew Jones wrote: > > On Tue, Jan 19, 2016 at 01:43:41PM +0100, Christoffer Dall wrote: > >> On Tue, Jan 19, 2016 at 01:37:16PM +0100, Andrew Jones wrote: > >>> On Tue, Jan 19, 2016 at 12:49:18PM +0100,

Re: [Qemu-devel] [PATCH 09/10] virtio: read avail_idx from VQ only when necessary

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 17:54, Michael S. Tsirkin wrote: > On Fri, Jan 15, 2016 at 01:41:57PM +0100, Paolo Bonzini wrote: >> From: Vincenzo Maffione >> >> The virtqueue_pop() implementation needs to check if the avail ring >> contains some pending buffers. To perform this check, it

Re: [Qemu-devel] [PATCH v1 15/17] loader: add API to load elf header

2016-01-19 Thread Peter Maydell
On 18 January 2016 at 07:12, Peter Crosthwaite wrote: > Add an API to load an elf header header from a file. Populates a > buffer with the header contents, as well as a boolean for whether the > elf is 64b or not. Both arguments are optional. > > Signed-off-by: Peter

[Qemu-devel] [PULL 1/2] vfio/pci-quirks: Only quirk to size of PCI config space

2016-01-19 Thread Alex Williamson
For quirks that support the full PCIe extended config space, limit the quirk to only the size of config space available through vfio. This allows host systems with broken MMCONFIG regions to still make use of these quirks without generating bad address faults trying to access beyond the end of

[Qemu-devel] [PULL 2/2] vfio/pci: Lazy PBA emulation

2016-01-19 Thread Alex Williamson
The PCI spec recommends devices use additional alignment for MSI-X data structures to allow software to map them to separate processor pages. One advantage of doing this is that we can emulate those data structures without a significant performance impact to the operation of the device. Some

[Qemu-devel] [PULL 0/2] VFIO updates 2016-01-19

2016-01-19 Thread Alex Williamson
The following changes since commit 3db34bf64ab4f8797565dd8750003156c32b301d: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' into staging (2016-01-18 17:40:50 +) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git

  1   2   3   4   >