Re: [Qemu-devel] [PATCH] cpu: cpu_save/cpu_load is no more

19.01.2016 15:08, Paolo Bonzini wrote: > Everything has been converted to vmstate. Applied to -trivial, thanks! /mjt\

Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description

18.01.2016 21:42, Alistair Francis wrote: > The description of object_property_get_int() stated that on an error > it returns NULL. This is not the case and the function will return -1 > if an error occurs. Update the commented documentation accordingly. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] virtio-scsi/blk dataplane and guest memory allocation

You were right, I worked with old libvirt, Thanks! I have another question about QEMU memory allocation, There is a possibility to put in libvirt : On Thu, Jan 28, 2016 at 10:53 AM, Daniel P. Berrange wrote: > On Thu, Jan 28, 2016 at 09:46:26AM +0100, Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

On 2016/1/29 22:35, Wei Huang wrote: > > On 01/29/2016 04:10 AM, Shannon Zhao wrote: >> > Hi， >> > >> > This makes ACPI work well but makes DT not work. The reason is systemd or >> > acpid open /dev/input/event0 failed. To correct, systemd or acpid open /dev/input/event0 successfully but it

Re: [Qemu-devel] virtio-scsi/blk dataplane and guest memory allocation

Sorry about the spam... You were right, I worked with old libvirt, Thanks! I have another question about QEMU memory allocation, There is a possibility to put in libvirt : This is suppose to lock all the memory that has been allocated for the guest into host's ram, Is there any way to

Re: [Qemu-devel] [PATCH COLO-Frame v13 10/39] COLO: Implement colo checkpoint protocol

On 2016/1/29 21:08, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint

Re: [Qemu-devel] [PATCH v2] man: virtfs-proxy-helper: Rework awkward sentence

18.01.2016 12:51, Christophe Fergeau wrote: > There was a 'capbilities' typo in this man page. This commit > reformulates the sentence the typo was in to make it easier to grasp. > This is based on a suggestion from Eric Blake. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] qemu-sockets: simplify error handling

22.01.2016 14:28, Paolo Bonzini wrote: > Just go always through the err label. (Noticed because Coverity > complains that peer is always non-NULL in the error cleanup code, > but removing the "if" is arguably more prone to introducing the > opposite bug in the future). Applied to -trivial,

[Qemu-devel] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer

Due to rounding down performed by ptimer_get_count, it returns counter - 1 for the active timer. That's incorrect because counter should decrement only after period been expired, not before. I.e. if running timer has been loaded with value X, then timer counter should stay with X until period

[Qemu-devel] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0

It might be necessary by some emulated HW to perform the tick after one period if delta = 0. Given that it is much less churny to implement immediate tick by the ptimer user itself, let's make ptimer do the delayed tick. Signed-off-by: Dmitry Osipenko --- hw/core/ptimer.c | 34

[Qemu-devel] [PATCH v12 6/9] hw/ptimer: Legalize running with delta = load = 0 and abort on period = 0

Currently ptimer would print error message and clear enable flag for an arming timer that has delta = load = 0. That actually could be a valid case for some hardware, like instant IRQ trigger for oneshot timer or continuous in periodic mode. Support those cases by removing the error message and

[Qemu-devel] [PATCH v12 3/9] hw/ptimer: Update .delta on period/freq change

Delta value must be updated on period/freq change, otherwise running timer would be restarted (counter reloaded with old delta). Only m68k/mcf520x and arm/arm_timer devices are currently doing freq change correctly, i.e. stopping the timer. Perform delta update to fix affected devices and

[Qemu-devel] [PATCH v12 1/9] hw/ptimer: Fix issues caused by the adjusted timer limit value

Multiple issues here related to the timer with a adjusted .limit value: 1) ptimer_get_count() returns incorrect counter value for the disabled timer after loading the counter with a small value, because adjusted limit value is used instead of the original. For instance: 1) ptimer_stop(t)

[Qemu-devel] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion

Changelog for ARM MPTimer QEMUTimer to ptimer conversion: V2: Fixed changing periodic timer counter value "on the fly". I added a test to the gist to cover that issue. V3: Fixed starting the timer with load = 0 and counter != 0, added tests to the gist for this issue.

[Qemu-devel] [PATCH v12 4/9] hw/ptimer: Support "on the fly" timer mode switch

Allow switching between periodic <-> oneshot modes while timer is running. Signed-off-by: Dmitry Osipenko Reviewed-by: Peter Crosthwaite --- hw/core/ptimer.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] how to setup a watchdog?

On Mon, Jan 18, 2016 at 11:43:02AM +, lejeczek wrote: > apologies I bother devel, but.. > I tried to get help on libvirt mailing list but not luck, then qemu, > still nothing > I hope maybe somebody here? > > I'm trying Qemu's watchdog. > My understanding was that hardware (here qemu's

[Qemu-devel] [PATCH v12 9/9] arm_mptimer: Convert to use ptimer

Current ARM MPTimer implementation uses QEMUTimer for the actual timer, this implementation isn't complete and mostly tries to duplicate of what generic ptimer is already doing fine. Conversion to ptimer brings the following benefits and fixes: - Simple timer pausing implementation

[Qemu-devel] [PATCH v12 2/9] hw/ptimer: Perform counter wrap around if timer already expired

ptimer_get_count() might be called while QEMU timer already been expired. In that case ptimer would return counter = 0, which might be undesirable in case of polled timer. Do counter wrap around for periodic timer to keep it distributed. In order to achieve more accurate emulation behaviour of

[Qemu-devel] [PATCH v12 5/9] hw/ptimer: Introduce ptimer_get_limit

Currently ptimer users are used to store copy of the limit value, because ptimer doesn't provide facility to retrieve the limit. Let's provide it. Signed-off-by: Dmitry Osipenko Reviewed-by: Peter Crosthwaite --- hw/core/ptimer.c| 5 +

Re: [Qemu-devel] [PATCH v3 0/3] Travis updates

28.01.2016 17:23, Alex Bennée wrote: > Hi, > > The first patch has been reviewed and signed off. Long term I think > it is worth applying but it look like the performance increase it > negligible compared to the old style VM builds at the moment. I > suspect this may be because the new

Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath

22.01.2016 20:35, Daniel P. Berrange wrote: > The BSD impl of qemu_chr_open_pp_fd had mis-declared > its parameter type as ChardevBackend instead of > ChardevCommon. It had also mistakenly used the variable > name 'common' instead of 'backend'. Applied to -trivial, fixed qemu-devel@ addres.

Re: [Qemu-devel] [PATCH COLO-Frame v13 32/39] COLO: Separate the process of saving/loading ram and device state

On 2016/1/27 22:14, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We separate the process of saving/loading ram and device state when do checkpoint, we add new helpers for save/load ram/device. With this change, we can directly transfer ram from master

[Qemu-devel] [PATCH 6/6] iotests: test external backup api

Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/151 | 77 ++ tests/qemu-iotests/151.out | 7 + tests/qemu-iotests/group | 1 + 3 files changed, 85 insertions(+) create mode 100755

[Qemu-devel] [PATCH 4/6] qapi: add qmp commands for some dirty bitmap functions

Add access to bdrv_dirty_bitmap_create_successor, bdrv_dirty_bitmap_abdicate, bdrv_reclaim_dirty_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 51 +++ qapi/block-core.json | 36 ++

[Qemu-devel] [PATCH v2 0/6] external backup api

Hi all. These series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. There are three things are done: - add query-block-dirty-bitmap-ranges qmp command - add qmp commands for dirty-bitmap

[Qemu-devel] [PATCH 1/6] block dirty bitmap: add next_zero function

The function searches for next zero bit (corresponding to next not-dirty bit). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 util/hbitmap.c

[Qemu-devel] [PATCH 5/6] qapi: make block-dirty-bitmap-create-successor transaction-able

Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi-schema.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index b3038b2..a7e97c7 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1650,6 +1650,7 @@

[Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

Add qmp command to query dirty bitmap contents. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 55 +++ blockdev.c | 62

[Qemu-devel] [PATCH 3/6] iotests: test query-block-dirty-bitmap-ranges

Add test for QMP command query-block-dirty-bitmap-ranges. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/150 | 88 ++ tests/qemu-iotests/150.out | 21 +++ tests/qemu-iotests/group | 1 + 3

Re: [Qemu-devel] [PATCH 2/2] qmp-spec: fix index in doc

24.01.2016 17:09, Wei Yang wrote: > The index is duplicated. Just change it. It is indeed, with previous being 2.5 as well and the next being 3. Applying to -trivial. Please the next time send to qemu-devel@ and Cc to -trivial. Thanks! /mjt > Signed-off-by: Wei Yang

Re: [Qemu-devel] [PATCH 0/6] Some improvements and small fixes for migration

Hi Juan & Amit, This series is prerequisite of COLO, and all of them have been reviewed by Dave, Could you please review and merge them ? Thanks, Hailiang On 2016/1/15 11:37, zhanghailiang wrote: Patch 1 ~ patch 4 are picked from COLO and live memory snapshot series, They are just small

Re: [Qemu-devel] [RFC 0/3] Draft implementation of HPT resizing (qemu side)

On Fri, Jan 29, 2016 at 08:18:39AM +0200, Alexander Graf wrote: > > > > Am 29.01.2016 um 04:47 schrieb David Gibson : > > > >> On Thu, Jan 28, 2016 at 10:04:58PM +0100, Alexander Graf wrote: > >> > >> > >>> On 01/19/2016 12:02 PM, David Gibson wrote: > On

Re: [Qemu-devel] [PATCH v3 07/10] s390x/cpu: Move some CPU initialization into realize

> In preparation for hotplug, defer some CPU initialization > until the device is actually being realized. > > Signed-off-by: Matthew Rosato > --- Reviewed-by: David Hildenbrand David

Re: [Qemu-devel] [PATCH 1/2] rdma: remove check on time_spent when calculating mbs

24.01.2016 17:09, Wei Yang wrote: > Within the if statement, time_spent is assured to be non-zero. > > This patch just removes the check on time_spent when calculating mbs. The if statement is this one: if (current_time >= initial_time + BUFFER_DELAY) { Note that we use time_spent as a

Re: [Qemu-devel] [PATCH] cpu: cpu_save/cpu_load is no more

On 30 January 2016 at 09:36, Michael Tokarev wrote: > 19.01.2016 15:08, Paolo Bonzini wrote: >> Everything has been converted to vmstate. > > Applied to -trivial, thanks! Ah, I missed that Paolo had sent out this patch before me (my version is

[Qemu-devel] [Bug 1481272] Re: main-loop: WARNING: I/O thread spun for 1000 iterations

I see the same with a Windows 10 guest on a Gentoo host. I tried setting nonblocking = 0; in vl.c as https://rafalcieslak.wordpress.com/2015/11/20/qemu-main-loop-warning-io- thread-spun-for-1000-iterations/ suggests, but that didn't solve the problem for me: the message is still there. -- You

[Qemu-devel] [Bug 1539940] [NEW] Qemu 2.5 Solaris 8 and 9 sparc hang after terminal type menu

Public bug reported: Qemu command: qemu-system-sparc -nographic -monitor null -serial mon:telnet:localhost:3000,server -bios ../../Downloads/ss20_v2.25_rom -M SS-20 -hda ./solsparc -m 512 -cdrom ./sol-9-905hw-ga-sparc-dvd.iso -boot d -cpu "TI SuperSparc 60" -net

[Qemu-devel] [PATCH RFC 1/3] linux-user: add rtnetlink(7) support

rtnetlink is needed to use iproute package (ip addr, ip route) and dhcp client. Examples: Without this patch: # ip link Cannot open netlink socket: Address family not supported by protocol # ip addr Cannot open netlink socket: Address family not supported by protocol # ip

[Qemu-devel] [PATCH RFC 0/3] linux-user: netlink support

Since commit: e36800c linux-user: add signalfd/signalfd4 syscalls It is now possible to register handlers to a file descriptor to translate a data stream transiting by this file descriptor. We can now decode netlink information coming from the guest and inject a translated one into the host, and

[Qemu-devel] [PATCH RFC 2/3] linux-user: support netlink protocol NETLINK_KOBJECT_UEVENT

This is the protocol used by udevd to manage kernel events. Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a1ed2f5..790ae49 100644 --- a/linux-user/syscall.c +++

[Qemu-devel] [PATCH RFC 3/3] linux-user: add netlink audit

This is, for instance, needed to log in a container. Without this, the user cannot be identified and the console login fails with "Login incorrect". Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 57 1 file

Re: [Qemu-devel] [PATCH v5 2/5] util: Use new error_report_fatal/abort instead of error_setg(_fatal/abort)

On Fri, Jan 29, 2016 at 02:33:08PM +0100, Lluís Vilanova wrote: > David Gibson writes: > > > On Thu, Jan 28, 2016 at 10:53:43PM +0100, Lluís Vilanova wrote: > >> Replaces all direct uses of 'error_setg(_fatal/abort)' with > >> 'error_report_fatal/abort'. Also reimplements the former on top of the

Re: [Qemu-devel] [Qemu-ppc] [PULL 03/39] macio: use the existing IDEDMA aiocb to hold the active DMA aiocb

On Fri, Jan 29, 2016 at 09:02:47AM +0100, Aurelien Jarno wrote: > On 2016-01-29 16:06, David Gibson wrote: > > From: Mark Cave-Ayland > > > > Currently the aiocb is held within MACIOIDEState, however the IDE core code > > assumes that the current actvie DMA aiocb

Re: [Qemu-devel] [PATCH v3 2/3] .travis.yml: run make check for all matrix targets

On Thu, Jan 28, 2016 at 02:23:28PM +, Alex Bennée wrote: > We only ran make check once before it used to be an unreliable target. > It was only a stop gap measure and we should be able to revert it now. > This also stops us needing a large all-MMU build. > > We disable "make check" for a

Re: [Qemu-devel] [PULL 00/39] ppc-for-2.6 queue 20160129

On Fri, Jan 29, 2016 at 02:48:23PM +, Peter Maydell wrote: > On 29 January 2016 at 05:06, David Gibson wrote: > > The following changes since commit 357e81c7e880f868833edf9f53cce1f3b09ea8ec: > > > > Merge remote-tracking branch