[Qemu-devel] [PATCH V2 2/2] hw/virtio: group virtio flags into an enum

Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h index

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

On 10 February 2016 at 12:48, Paolo Bonzini wrote: > > > On 09/02/2016 17:13, Paolo Bonzini wrote: >> The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' >> into staging

Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

On 10/02/2016 12:02, Asia Slowinska wrote: > Stick to the expected order of the FPU registers in xsave (as specified > in the > Intel manual.) Otherwise, instructions loading the FPU state don't set > it up > correctly. > > To set up FPU, software needs to provide a buffer of 80 bytes > storing

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

On 02/10/2016 06:26 PM, John Snow wrote: On 02/10/2016 08:57 AM, Denis V. Lunev wrote: On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap contents. This is needed for external

[Qemu-devel] [PATCH V2 0/2] hw/virtio: fix double use of a virtio flag

To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio feature in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used

[Qemu-devel] [PATCH V2 1/2] hw/virtio: fix double use of a virtio flag

Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. Reported-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h

Re: [Qemu-devel] [PATCH v2 1/5] target-arm: Add the pmceid0 and pmceid1 registers

On Feb 09 15:11, Alistair Francis wrote: > On Tue, Feb 9, 2016 at 9:19 AM, Peter Maydell > wrote: > > On 6 February 2016 at 00:55, Alistair Francis > > wrote: > >> Signed-off-by: Aaron Lindsay > >> Signed-off-by:

[Qemu-devel] [PATCH] Rename cpu_get_icount_{locked,biased}

The function does not provide locking but rather adds a bias value. Signed-off-by: Christopher Covington --- cpus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 898426c..50403c4 100644 --- a/cpus.c +++ b/cpus.c @@ -164,7

Re: [Qemu-devel] [PATCH] Rename cpu_get_icount_{locked,biased}

On 10/02/2016 15:06, Christopher Covington wrote: > The function does not provide locking but rather adds a bias value. "Locked" means that you need to take a look outside its call; see how cpu_get_icount() uses it. Basically the idea is that a "_locked" in the name warns you to pay attention.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

Cc'ing Dave and Juan since this is migration stuff. On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > Fixes:

Re: [Qemu-devel] lock-free monitor?

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > Hi, >> > I wondered what it would take to be able to do a lock-free monitor; >> > i.e. one that could respond to (some)

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

On 02/10/2016 06:37 PM, John Snow wrote: On 02/10/2016 10:36 AM, Denis V. Lunev wrote: On 02/10/2016 06:26 PM, John Snow wrote: On 02/10/2016 08:57 AM, Denis V. Lunev wrote: On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] KVH call for agenda for 2016-02-16

On 02/10/2016 04:42 PM, Juan Quintela wrote: > > > Hi > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Summit, we are going to have

Re: [Qemu-devel] [PATCH V2 2/2] hw/virtio: group virtio flags into an enum

On 10/02/2016 14:31, Marcel Apfelbaum wrote: > Minimizes the possibility to assign > the same bit to different features. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

On 10/02/2016 14:49, Peter Maydell wrote: >> > Self-NACK, this breaks (at least) FreeDOS. > Oops, I read this email five seconds after pushing the merge to master. > Can you send out reverts for the appropriate patches and I'll apply > them direct to master? I can send the fix. Paolo

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

On 02/10/2016 08:57 AM, Denis V. Lunev wrote: > On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: >> On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy >> wrote: >>> Add qmp command to query dirty bitmap contents. This is needed for >>> external backup. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

On 02/10/16 16:29, Paolo Bonzini wrote: > > > On 10/02/2016 15:55, Laszlo Ersek wrote: Hmm, not sure why. We're comparing against the inclusive-exclusive range [0,s->vga.vram_size). The right way to check if something is within the range is >= min && < max; the right way to

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > >

Re: [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding

Am 09.02.2016 um 21:57 schrieb Dirk Müller: > See C5.1.5 of the ARMv8 Reference Manual > > Signed-off-by: Dirk Mueller Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

On 02/10/2016 10:36 AM, Denis V. Lunev wrote: > On 02/10/2016 06:26 PM, John Snow wrote: >> >> On 02/10/2016 08:57 AM, Denis V. Lunev wrote: >>> On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add qmp

[Qemu-devel] [PATCH v2 2/4] rng: move request queue from RngEgd to RngBackend

The 'requests' field now lives in the RngBackend parent class. There are no functional changes in this commit. Signed-off-by: Ladi Prosek --- backends/rng-egd.c | 28 +--- include/sysemu/rng.h | 11 +++ 2 files changed, 20 insertions(+), 19

[Qemu-devel] [PATCH v2 1/4] rng: remove the unused request cancellation code

rng_backend_cancel_requests has no callers and none of the code deleted in this commit ever runs. Signed-off-by: Ladi Prosek --- backends/rng-egd.c | 12 backends/rng.c | 9 - include/sysemu/rng.h | 11 --- 3 files changed, 32

[Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue

As suggested by Paolo, I have moved the RngRequest implementation up to the RngBackend parent class and made both child classes use it. Apart from the refactoring, the only functional change compared to v1 is the use of heap instead of stack allocation for the read buffer in rng-random. The

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > But

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

Am 10.02.2016 um 14:33 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > > Am

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

Hello Corey, On 02/09/2016 07:25 PM, Corey Minyard wrote: > On 02/09/2016 06:13 AM, Cédric Le Goater wrote: >> The first patches are cleanups and prepare ground for an extension of >> the BMC simulator providing a SDR loader using a file. A simple FRU >> support comes next. >> >> The last patches

[Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

The last two arguments to these functions are the last and first bit to check relative to the base. The code was using incorrectly the first bit and the number of bits. Fix this in cpu_physical_memory_get_dirty and cpu_physical_memory_all_dirty. This requires a few changes in the iteration;

Re: [Qemu-devel] [PATCH] target-arm: Implement DBGDTRRX_EL0/DBGDTRTX_EL0 MSR

Hi Andreas, Am 09.02.2016 um 21:59 schrieb Dirk Müller: > This is used by the ARM JTAG DCC console in the Linux kernel, > but can be ignored in order to continue booting. > > Co-Authored-By: Andreas Schwab If this was co-authored by you, we need a proper Signed-off-by please.

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

On Wed, Feb 10, 2016 at 03:11:45PM +0100, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and

Re: [Qemu-devel] [PATCH v5 1/9] tcg: pass down TranslationBlock to tcg_code_gen

Richard Henderson writes: > On 02/05/2016 01:56 AM, Alex Bennée wrote: >> diff --git a/translate-all.c b/translate-all.c >> index ab61fac..dce00d5 100644 >> --- a/translate-all.c >> +++ b/translate-all.c >> @@ -1055,7 +1055,6 @@ TranslationBlock *tb_gen_code(CPUState *cpu, >>

Re: [Qemu-devel] lock-free monitor?

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > Hi, > >> > I wondered what it would take to be able to do a

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

On 10/02/2016 15:55, Laszlo Ersek wrote: >> > Hmm, not sure why. We're comparing against the inclusive-exclusive >> > range [0,s->vga.vram_size). The right way to check if something is >> > within the range is >= min && < max; the right way to check if something >> > is outside the range is <

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

> Changes from v2->v3: > > * Call cpu_remove_sync rather than cpu_remove(). > * Pull latest version of patches from pseries set (v6). Trivial change to > "Reclaim VCPU objects" to fix checkpatch error. > * Add object_unparent during s390_cpu_release to accomodate changes in > Patch 4

Re: [Qemu-devel] [PATCH v6 3/4] tcg: Add type for vCPU pointers

Lluís Vilanova writes: > Richard Henderson writes: >> On 02/10/2016 08:14 AM, Lluís Vilanova wrote: >>> Adds the 'TCGv_env' type for pointers to 'CPUArchState' objects. The >>> tracing infrastructure later needs to differentiate between regular >>> pointers and pointers to vCPUs. >>> >>> Also

Re: [Qemu-devel] [Qemu-stable] [PATCH] spapr: skip configuration section during migration of older machines

On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33 > Cc:

[Qemu-devel] KVH call for agenda for 2016-02-16

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details:

Re: [Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

On 02/10/2016 03:07 PM, Laurent Vivier wrote: On 10/02/2016 13:22, Marcel Apfelbaum wrote: Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 16 ++-- 1 file changed, 10

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap contents. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

Many thanks for the reply. I'm sorry for the typo in the previous patch. Below comes a new one. Best regards, asia Stick to the right order of the FPU registers in xsave (as specified in the Intel manual.) Otherwise, instructions loading the FPU state don't set it up correctly. To set up FPU,

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

On 02/10/16 13:32, Paolo Bonzini wrote: > > > On 09/02/2016 20:08, Laszlo Ersek wrote: >> On 02/09/16 11:59, Paolo Bonzini wrote: >>> The "max" value is being compared with >=, but addr + width points to >>> the first byte that will _not_ be copied. Subtract one like it is >>> already done

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

On 02/10/2016 05:06 PM, Corey Minyard wrote: > On 02/10/2016 08:05 AM, Cédric Le Goater wrote: >> Hello Corey, >> >> On 02/09/2016 07:25 PM, Corey Minyard wrote: >>> On 02/09/2016 06:13 AM, Cédric Le Goater wrote: The first patches are cleanups and prepare ground for an extension of the

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On 02/09/2016 01:48 PM, Michael S. Tsirkin wrote: > On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote: >> On 02/09/16 17:22, John Snow wrote: >>> >>> >>> On 02/09/2016 10:52 AM, Roman Kagan wrote: On Mon, Feb 08, 2016 at 03:20:47PM -0500, John Snow wrote: > On 02/08/2016

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

Am 10.02.2016 um 16:28 schrieb David Hildenbrand: > For x86, cpu models are realized by making x86_64-cpu an abstract class and > creating loads of new classes, e.g. host-x86_64-cpu or haswell-x86_64-cpu. > > How does 'device_add ' play together with the x86 cpu model > approach? And with cpu

Re: [Qemu-devel] [PULL 02/32] memory: RCU ram_list.dirty_memory[] for safe RAM hotplug

Hi, I just noticed significant performance hit with this change. Booting small system (I tried on system mips only) was usually taking around 20 seconds, now reaches 3 minutes with this change. Leon On 09/02/16 12:13, Paolo Bonzini wrote: > From: Stefan Hajnoczi > >

Re: [Qemu-devel] [PATCH 07/15] tcg-mips: Adjust qemu_ld/st for mips64

On 02/11/2016 03:34 AM, James Hogan wrote: Hi Richard, On Tue, Feb 09, 2016 at 09:39:55PM +1100, Richard Henderson wrote: @@ -1212,11 +1237,24 @@ static void tcg_out_tlb_load(TCGContext *s, TCGReg base, TCGReg addrl, : offsetof(CPUArchState, tlb_table[mem_index][0].addr_write));

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On Wed, Feb 10, 2016 at 11:14:30AM -0500, John Snow wrote: > > > On 02/09/2016 01:48 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote: > >> On 02/09/16 17:22, John Snow wrote: > >>> > >>> > >>> On 02/09/2016 10:52 AM, Roman Kagan wrote: > On

Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue

Quoting Leonid Bloch (2016-01-11 03:12:41) > With automatically generated GUID, on minor version changes, an error > occurred, stating that there is a problem with the installer. > Now, a notification is shown, warning the user that another version of > this product is already installed, and that

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: 140: use virtio-scsi instead of IDE

On 09.02.2016 14:15, Sascha Silbe wrote: > IDE is only implemented by very few architectures (mostly PC). Use > virtio-scsi instead so the test works on all architectures that > support virtio. In particular, this fixes qemu-iotests on s390x. > > Fixes: 16dee418 ("iotests: Add test for eject

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

On 10/02/2016 16:54, Laszlo Ersek wrote: > On 02/10/16 16:29, Paolo Bonzini wrote: >> >> >> On 10/02/2016 15:55, Laszlo Ersek wrote: > Hmm, not sure why. We're comparing against the inclusive-exclusive > range [0,s->vga.vram_size). The right way to check if something is > within

[Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

Requests are now created in the RngBackend parent class and the code path is shared by both rng-egd and rng-random. This commit fixes the rng-random implementation which currently processes only one request at a time and simply discards all but the most recent one. In the guest this manifests as

[Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

RngBackend is now in charge of cleaning up the linked list on instance finalization. It also exposes a function to finalize individual RngRequest instances, called by its child classes. Signed-off-by: Ladi Prosek --- backends/rng-egd.c | 25 +

[Qemu-devel] [PATCH v2] cirrus_vga: fix off-by-one in blit_region_is_unsafe

The "max" value is being compared with >=, but addr + width points to the first byte that will _not_ be copied. Laszlo suggested using a "greater than" comparison, instead of subtracting one like it is already done above for the height, so that max remains always positive. The mistake is

Re: [Qemu-devel] [PATCH v2] cirrus_vga: fix off-by-one in blit_region_is_unsafe

On 02/10/16 17:17, Paolo Bonzini wrote: > The "max" value is being compared with >=, but addr + width points to > the first byte that will _not_ be copied. Laszlo suggested using a > "greater than" comparison, instead of subtracting one like it is > already done above for the height, so that max

Re: [Qemu-devel] [PULL 02/32] memory: RCU ram_list.dirty_memory[] for safe RAM hotplug

On 10/02/2016 17:56, Leon Alrae wrote: > Hi, > > I just noticed significant performance hit with this change. Booting > small system (I tried on system mips only) was usually taking around 20 > seconds, now reaches 3 minutes with this change. You're lucky that it booted at all. :)

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On 02/10/2016 12:10 PM, Roman Kagan wrote: > On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote: >> In my opinion, the real mess in this case is in the ACPI spec itself. If >> you re-read the _FDI control method's description, the Package that it >> returns contains *dynamic* geometry

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On Wed, Feb 10, 2016 at 12:16:32PM -0500, John Snow wrote: > On 02/10/2016 12:10 PM, Roman Kagan wrote: > > Well, as I wrote in another mail, SeaBIOS, which is supposed to provide > > the same information to int 0x13/0x08, populates it with static data > > based only on the drive type as encoded

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

On 09.02.2016 14:23, Sascha Silbe wrote: > The order of some QMP events may depend on the architecture being > tested. Add support for filtering out QMP events so we can use a > single reference output for all architecture when the test doesn't > care about the events. > > Signed-off-by: Sascha

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On Tue, Feb 09, 2016 at 11:22:01AM -0500, John Snow wrote: > > I don't. At the time the patch was developed there basically were no > > mechanisms to update the geometry at all (and this was what you patchset > > addressed, in particular, wasn't it?) so I didn't care. > > That's not true. > >

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

On 10.02.2016 15:11, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and cpu_physical_memory_all_dirty.

Re: [Qemu-devel] [PATCH v2 5/5] kvm/x86: Hyper-V VMBus hypercall userspace exit

On 21/01/2016 15:01, Andrey Smetanin wrote: > The patch implements KVM_EXIT_HYPERV userspace exit > functionality for Hyper-V VMBus hypercalls: > HV_X64_HCALL_POST_MESSAGE, HV_X64_HCALL_SIGNAL_EVENT. > > Changes v2: > * use KVM_EXIT_HYPERV for hypercalls > > Signed-off-by: Andrey Smetanin

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote: > In my opinion, the real mess in this case is in the ACPI spec itself. If > you re-read the _FDI control method's description, the Package that it > returns contains *dynamic* geometry data, about the *disk* (not *drive*): > > -

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

On 10/02/16 14:11, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and cpu_physical_memory_all_dirty.

Re: [Qemu-devel] [PATCH v6 0/5] add ACPI node for fw_cfg on pc and arm

Ping. Now that the kernel side seems to have been accepted (Thanks again Laszlo and Matt for all the help and advice!!!), is there anything left to clean up before this series could be applied to QEMU ? gmane.org quick links: 1/5: http://article.gmane.org/gmane.comp.emulators.qemu/389896/raw

Re: [Qemu-devel] [PATCH 07/15] tcg-mips: Adjust qemu_ld/st for mips64

Hi Richard, On Tue, Feb 09, 2016 at 09:39:55PM +1100, Richard Henderson wrote: > @@ -1212,11 +1237,24 @@ static void tcg_out_tlb_load(TCGContext *s, TCGReg > base, TCGReg addrl, > : offsetof(CPUArchState, tlb_table[mem_index][0].addr_write)); > int add_off =

Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

> > > On 10/02/2016 16:53, Ladi Prosek wrote: > > +req->size = size; > > +req->receive_entropy = receive_entropy; > > +req->opaque = opaque; > > +req->data = g_malloc(req->size); > > + > > +k->request_entropy(s, req); > > + > > +s->requests =

Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

On 10/02/2016 17:40, Ladi Prosek wrote: >> >> >> On 10/02/2016 16:53, Ladi Prosek wrote: >>> +req->size = size; >>> +req->receive_entropy = receive_entropy; >>> +req->opaque = opaque; >>> +req->data = g_malloc(req->size); >>> + >>> +k->request_entropy(s,

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

On Wed, Feb 10, 2016 at 11:14:30AM -0500, John Snow wrote: > On 02/09/2016 01:48 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote: > >> Implementing this in QEMU would require: > >> - inventing virt-only registers for the FDC that provide the current >

Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

Richard Henderson writes: > On 02/05/2016 01:56 AM, Alex Bennée wrote: >> +gchar *range_op = g_strstr_len(r, -1, "-"); > > This is strchr. > >> +range_op = g_strstr_len(r, -1, "."); > > Or at least if you're going to make use of strstr, search for

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

On 02/10/2016 08:05 AM, Cédric Le Goater wrote: Hello Corey, On 02/09/2016 07:25 PM, Corey Minyard wrote: On 02/09/2016 06:13 AM, Cédric Le Goater wrote: The first patches are cleanups and prepare ground for an extension of the BMC simulator providing a SDR loader using a file. A simple FRU

Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

On 10/02/2016 16:53, Ladi Prosek wrote: > +req->size = size; > +req->receive_entropy = receive_entropy; > +req->opaque = opaque; > +req->data = g_malloc(req->size); > + > +k->request_entropy(s, req); > + > +s->requests = g_slist_append(s->requests,

[Qemu-devel] [PATCH 0/4] hw/ppc/spapr: Add "Processor Register Hypervisor Resource Access" H-calls

While we were recently debugging a problem with the H_SET_DABR call [1], I noticed that some hypercalls from the chapter 14.5.4.3 ("Processor Register Hypervisor Resource Access") from the LoPAPR spec [2] are still missing in QEMU. So here's are some patches that implement these hypercalls. Linux

Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

Richard Henderson writes: > On 02/11/2016 04:40 AM, Alex Bennée wrote: >> OK I think this version is a lot cleaner: >> >>void qemu_set_dfilter_ranges(const char *filter_spec) >>{ >>gchar **ranges = g_strsplit(filter_spec, ",", 0); >>if (ranges) { >>

[Qemu-devel] [PATCH v6 14/16] nbd: enable use of TLS with NBD block driver

This modifies the NBD driver so that it is possible to request use of TLS. This is done by providing the 'tls-creds' parameter with the ID of a previously created QCryptoTLSCreds object. For example $QEMU -object tls-creds-x509,id=tls0,endpoint=client,\

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: 140: use virtio-scsi instead of IDE

Dear Max, Max Reitz writes: [tests/qemu-iotests/140] >> -_launch_qemu -drive >> if=ide,media=cdrom,id=drv,file="$TEST_IMG",format=$IMGFMT \ >> -2> >(_filter_nbd) >> +_launch_qemu -drive >> if=none,media=cdrom,id=drv,file="$TEST_IMG",format=$IMGFMT \ >> +-device

[Qemu-devel] commit 5b82b70 boot problems

Hi Stefan, After pulling from upstream this morning, my guest VMs were no longer able to boot. For instance, running something like bin/qemu-system-x86_64 -machine q35,accel=kvm -m 2048 -monitor stdio \ -device ide-drive,bus=ide.2,drive=CD \ -drive

[Qemu-devel] [PULL 00/11] Ide patches

The following changes since commit c9f19dff101e2c2cf3fa3967eceec2833e845e40: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-02-09 19:34:46 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you

[Qemu-devel] [PULL 09/11] ahci: handle LIST_ON and FIS_ON in map helpers

Instead of relying on ahci_cond_start_engines to maintain the engine status indicators itself, have the lower-layer CLB and FIS mapper helpers do it themselves. This makes the cond_start routine slightly nicer to read, and makes sure that the status indicators will always be correct.

[Qemu-devel] [PATCH v6 01/16] qom: add helpers for UserCreatable object types

The QMP monitor code has two helper methods object_add and qmp_object_del that are called from several places in the code (QMP, HMP and main emulator startup). The HMP and main emulator startup code also share further logic that extracts the qom-type & id values from a qdict. We soon need to use

[Qemu-devel] [PATCH v6 04/16] nbd: convert qemu-nbd server to use I/O channels for connection setup

This converts the qemu-nbd server to use the QIOChannelSocket class for initial listener socket setup and accepting of client connections. Actual I/O is still being performed against the socket file descriptor using the POSIX socket APIs. In this initial conversion though, all I/O is still

[Qemu-devel] [PATCH v6 10/16] nbd: allow setting of an export name for qemu-nbd server

The qemu-nbd server currently always uses the old style protocol since it never sets any export name. This is a problem because future TLS support will require use of the new style protocol negotiation. This adds "--exportname NAME" / "-x NAME" arguments to qemu-nbd which allow the user to set an

[Qemu-devel] [PATCH v6 09/16] nbd: make client request fixed new style if advertized

If the server advertizes support for the fixed new style negotiation, the client should in turn enable new style. This will allow the client to negotiate further NBD options besides the export name. Signed-off-by: Daniel P. Berrange --- nbd/client.c | 27

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: add _filter_qmp_events() for filtering out QMP events

Dear Max, Max Reitz writes: >> +# remove QMP events from output >> +_filter_qmp_events() >> +{ >> +sed -e '/^{\(.*, \)"event": ".*}$/ d' >> +} > > There is a pretty good reason test 067 uses -qmp-pretty (as you yourself > say, the lines get pretty long otherwise, and if

Re: [Qemu-devel] [PATCH v2] linux-user: add option to intercept execve() syscalls

Le 27/01/2016 09:49, Petros Angelatos a écrit : > From: Petros Angelatos > > In order for one to use QEMU user mode emulation under a chroot, it is > required to use binfmt_misc. This can be avoided by QEMU never doing a > raw execve() to the host system. > > Introduce a

[Qemu-devel] [PULL 04/11] ide: replace blk_drain_all by blk_drain

Target the drain for just one device. Signed-off-by: John Snow Reported-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Message-id: 1453225191-11871-5-git-send-email-js...@redhat.com --- hw/ide/core.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PULL 03/11] ide: move buffered DMA cancel to core

Buffered DMA cancellation was added to ATAPI devices and implemented for the BMDMA HBA. Move the code over to common IDE code and allow it to be used for any HBA. Signed-off-by: John Snow Reported-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 02/11] ide: code motion

Shuffle the reset function upwards. Signed-off-by: John Snow Reported-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Message-id: 1453225191-11871-3-git-send-email-js...@redhat.com --- hw/ide/core.c | 116

[Qemu-devel] [PULL 01/11] ide: Prohibit RESET on IDE drives

This command is meant for ATAPI devices only, prohibit acknowledging it with a command aborted response when an IDE device is busy. Signed-off-by: John Snow Reported-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Message-id:

[Qemu-devel] [PATCH 3/4] hw/ppc/spapr: Implement the h_set_xdabr hypercall

The H_SET_XDABR hypercall is similar to H_SET_DABR, but also sets the extended DABR (DABRX) register. Signed-off-by: Thomas Huth --- hw/ppc/spapr_hcall.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c

[Qemu-devel] [PATCH 2/4] hw/ppc/spapr: Implement h_set_dabr

According to LoPAPR, h_set_dabr should simply set DABRX to 3 (if the register is available), and load the parameter into DABR. If DABRX is not available, the hypervisor has to check the "Breakpoint Translation" bit of the DABR register first. Signed-off-by: Thomas Huth ---

Re: [Qemu-devel] [PATCH] linux-user: Don't assert if guest tries shmdt(0)

Le 09/02/2016 16:57, Peter Maydell a écrit : > Our implementation of shmat() and shmdt() for linux-user was > using "zero guest address" as its marker for "entry in the > shm_regions[] array is not in use". This meant that if the > guest did a shmdt(0) we would match on an unused array entry Is

[Qemu-devel] [PATCH v6 06/16] nbd: convert to using I/O channels for actual socket I/O

Now that all callers are converted to use I/O channels for initial connection setup, it is possible to switch the core NBD protocol handling core over to use QIOChannel APIs for actual sockets I/O. Signed-off-by: Daniel P. Berrange --- block/nbd-client.c | 19 +++

[Qemu-devel] [PATCH v6 15/16] nbd: enable use of TLS with qemu-nbd server

This modifies the qemu-nbd program so that it is possible to request the use of TLS with the server. It simply adds a new command line option --tls-creds which is used to provide the ID of a QCryptoTLSCreds object previously created via the --object command line option. For example qemu-nbd

[Qemu-devel] make distclean can fail do to a configuration check

Stuff like this: > ~/s/q/b/git> make distclean > config-host.mak is out-of-date, running configure > > ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T. >You probably need to set PKG_CONFIG_LIBDIR >to point to the right pkg-config files for your >build target > >

[Qemu-devel] [PATCH v6 13/16] nbd: implement TLS support in the protocol negotiation

This extends the NBD protocol handling code so that it is capable of negotiating TLS support during the connection setup. This involves requesting the STARTTLS protocol option before any other NBD options. Signed-off-by: Daniel P. Berrange --- block/nbd-client.c | 12

[Qemu-devel] [PATCH v6 08/16] nbd: make server compliant with fixed newstyle spec

If the client does not request the fixed new style protocol, then we should only accept NBD_OPT_EXPORT_NAME. All other options are only valid when fixed new style has been activated. The qemu-nbd client doesn't currently request fixed new style protocol, but this change won't break qemu-nbd,

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

On 02/10/2016 07:48 AM, Paolo Bonzini wrote: > > > On 09/02/2016 17:13, Paolo Bonzini wrote: >> The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' >> into staging (2016-02-09 11:42:43

[Qemu-devel] [PULL 07/11] fdc: always compile-check debug prints

Coverity noticed that some variables are only used by debug prints, and called them unused. Always compile the print statements. While we're here, print to stderr as well. Bonus: Fix a debug printf I broke in f31937aa8 Signed-off-by: John Snow Reviewed-by: Eric Blake

[Qemu-devel] [PULL 08/11] ahci: Do not unmap NULL addresses

Definitely don't try to unmap a garbage address. Reported-by: Zuozhi fzz Signed-off-by: John Snow Message-id: 1454103689-13042-2-git-send-email-js...@redhat.com --- hw/ide/ahci.c | 8 1 file changed, 8 insertions(+) diff --git

[Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client

This is an update of the series previously posted: v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg06126.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01580.html v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03440.html v4:

[Qemu-devel] [PATCH v6 02/16] qemu-nbd: add support for --object command line arg

Allow creation of user creatable object types with qemu-nbd via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-nbd --object

  1   2   3   >