Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

2016-02-10 Thread John Snow
On 02/09/2016 01:48 PM, Michael S. Tsirkin wrote: > On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote: >> On 02/09/16 17:22, John Snow wrote: >>> >>> >>> On 02/09/2016 10:52 AM, Roman Kagan wrote: On Mon, Feb 08, 2016 at 03:20:47PM -0500, John Snow wrote: > On 02/08/2016 08:14

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

2016-02-10 Thread Cédric Le Goater
On 02/10/2016 05:06 PM, Corey Minyard wrote: > On 02/10/2016 08:05 AM, Cédric Le Goater wrote: >> Hello Corey, >> >> On 02/09/2016 07:25 PM, Corey Minyard wrote: >>> On 02/09/2016 06:13 AM, Cédric Le Goater wrote: The first patches are cleanups and prepare ground for an extension of the B

[Qemu-devel] [PATCH v2] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Paolo Bonzini
The "max" value is being compared with >=, but addr + width points to the first byte that will _not_ be copied. Laszlo suggested using a "greater than" comparison, instead of subtracting one like it is already done above for the height, so that max remains always positive. The mistake is "safe"--

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: 140: use virtio-scsi instead of IDE

2016-02-10 Thread Max Reitz
On 09.02.2016 14:15, Sascha Silbe wrote: > IDE is only implemented by very few architectures (mostly PC). Use > virtio-scsi instead so the test works on all architectures that > support virtio. In particular, this fixes qemu-iotests on s390x. > > Fixes: 16dee418 ("iotests: Add test for eject under

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 16:54, Laszlo Ersek wrote: > On 02/10/16 16:29, Paolo Bonzini wrote: >> >> >> On 10/02/2016 15:55, Laszlo Ersek wrote: > Hmm, not sure why. We're comparing against the inclusive-exclusive > range [0,s->vga.vram_size). The right way to check if something is > within the

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

2016-02-10 Thread Corey Minyard
On 02/10/2016 08:05 AM, Cédric Le Goater wrote: Hello Corey, On 02/09/2016 07:25 PM, Corey Minyard wrote: On 02/09/2016 06:13 AM, Cédric Le Goater wrote: The first patches are cleanups and prepare ground for an extension of the BMC simulator providing a SDR loader using a file. A simple FRU su

[Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

2016-02-10 Thread Ladi Prosek
RngBackend is now in charge of cleaning up the linked list on instance finalization. It also exposes a function to finalize individual RngRequest instances, called by its child classes. Signed-off-by: Ladi Prosek --- backends/rng-egd.c | 25 + backends/rng.c | 32

[Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

2016-02-10 Thread Ladi Prosek
Requests are now created in the RngBackend parent class and the code path is shared by both rng-egd and rng-random. This commit fixes the rng-random implementation which currently processes only one request at a time and simply discards all but the most recent one. In the guest this manifests as d

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Laszlo Ersek
On 02/10/16 16:29, Paolo Bonzini wrote: > > > On 10/02/2016 15:55, Laszlo Ersek wrote: Hmm, not sure why. We're comparing against the inclusive-exclusive range [0,s->vga.vram_size). The right way to check if something is within the range is >= min && < max; the right way to check

[Qemu-devel] [PATCH v2 2/4] rng: move request queue from RngEgd to RngBackend

2016-02-10 Thread Ladi Prosek
The 'requests' field now lives in the RngBackend parent class. There are no functional changes in this commit. Signed-off-by: Ladi Prosek --- backends/rng-egd.c | 28 +--- include/sysemu/rng.h | 11 +++ 2 files changed, 20 insertions(+), 19 deletions(-) diff --

[Qemu-devel] [PATCH v2 1/4] rng: remove the unused request cancellation code

2016-02-10 Thread Ladi Prosek
rng_backend_cancel_requests has no callers and none of the code deleted in this commit ever runs. Signed-off-by: Ladi Prosek --- backends/rng-egd.c | 12 backends/rng.c | 9 - include/sysemu/rng.h | 11 --- 3 files changed, 32 deletions(-) diff --git a/back

[Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue

2016-02-10 Thread Ladi Prosek
As suggested by Paolo, I have moved the RngRequest implementation up to the RngBackend parent class and made both child classes use it. Apart from the refactoring, the only functional change compared to v1 is the use of heap instead of stack allocation for the read buffer in rng-random. The parent

Re: [Qemu-devel] KVH call for agenda for 2016-02-16

2016-02-10 Thread Christian Borntraeger
On 02/10/2016 04:42 PM, Juan Quintela wrote: > > > Hi > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Summit, we are going to have alw

[Qemu-devel] KVH call for agenda for 2016-02-16

2016-02-10 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread Denis V. Lunev
On 02/10/2016 06:37 PM, John Snow wrote: On 02/10/2016 10:36 AM, Denis V. Lunev wrote: On 02/10/2016 06:26 PM, John Snow wrote: On 02/10/2016 08:57 AM, Denis V. Lunev wrote: On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread John Snow
On 02/10/2016 10:36 AM, Denis V. Lunev wrote: > On 02/10/2016 06:26 PM, John Snow wrote: >> >> On 02/10/2016 08:57 AM, Denis V. Lunev wrote: >>> On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add qmp com

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread Denis V. Lunev
On 02/10/2016 06:26 PM, John Snow wrote: On 02/10/2016 08:57 AM, Denis V. Lunev wrote: On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap contents. This is needed for external backu

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 15:55, Laszlo Ersek wrote: >> > Hmm, not sure why. We're comparing against the inclusive-exclusive >> > range [0,s->vga.vram_size). The right way to check if something is >> > within the range is >= min && < max; the right way to check if something >> > is outside the range is < m

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

2016-02-10 Thread David Hildenbrand
> Changes from v2->v3: > > * Call cpu_remove_sync rather than cpu_remove(). > * Pull latest version of patches from pseries set (v6). Trivial change to > "Reclaim VCPU objects" to fix checkpatch error. > * Add object_unparent during s390_cpu_release to accomodate changes in > Patch 4 "Recla

Re: [Qemu-devel] lock-free monitor?

2016-02-10 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > Hi, > >> > I wondered what it would take to be able to do a lock-free monitor; > >> > i.e. one that could re

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread John Snow
On 02/10/2016 08:57 AM, Denis V. Lunev wrote: > On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: >> On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy >> wrote: >>> Add qmp command to query dirty bitmap contents. This is needed for >>> external backup. >>> >>> Signed-off-by: Vla

Re: [Qemu-devel] [PATCH v5 1/9] tcg: pass down TranslationBlock to tcg_code_gen

2016-02-10 Thread Alex Bennée
Richard Henderson writes: > On 02/05/2016 01:56 AM, Alex Bennée wrote: >> diff --git a/translate-all.c b/translate-all.c >> index ab61fac..dce00d5 100644 >> --- a/translate-all.c >> +++ b/translate-all.c >> @@ -1055,7 +1055,6 @@ TranslationBlock *tb_gen_code(CPUState *cpu, >> TranslationBl

Re: [Qemu-devel] lock-free monitor?

2016-02-10 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > Hi, >> > I wondered what it would take to be able to do a lock-free monitor; >> > i.e. one that could respond to (some) commands while the qemu big lock is >> > held.

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Laszlo Ersek
On 02/10/16 13:32, Paolo Bonzini wrote: > > > On 09/02/2016 20:08, Laszlo Ersek wrote: >> On 02/09/16 11:59, Paolo Bonzini wrote: >>> The "max" value is being compared with >=, but addr + width points to >>> the first byte that will _not_ be copied. Subtract one like it is >>> already done above

Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Asia Slowinska
Many thanks for the reply. I'm sorry for the typo in the previous patch. Below comes a new one. Best regards, asia Stick to the right order of the FPU registers in xsave (as specified in the Intel manual.) Otherwise, instructions loading the FPU state don't set it up correctly. To set up FPU, s

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Stefan Hajnoczi
On Wed, Feb 10, 2016 at 03:11:45PM +0100, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and cpu_physica

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

2016-02-10 Thread Greg Kurz
Cc'ing Dave and Juan since this is migration stuff. On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > Fixes: 61964c23e5ddd5a33f15699e45ce1

Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 12:02, Asia Slowinska wrote: > Stick to the expected order of the FPU registers in xsave (as specified > in the > Intel manual.) Otherwise, instructions loading the FPU state don't set > it up > correctly. > > To set up FPU, software needs to provide a buffer of 80 bytes > storing

Re: [Qemu-devel] [PATCH] Rename cpu_get_icount_{locked,biased}

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 15:06, Christopher Covington wrote: > The function does not provide locking but rather adds a bias value. "Locked" means that you need to take a look outside its call; see how cpu_get_icount() uses it. Basically the idea is that a "_locked" in the name warns you to pay attention.

[Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Paolo Bonzini
The last two arguments to these functions are the last and first bit to check relative to the base. The code was using incorrectly the first bit and the number of bits. Fix this in cpu_physical_memory_get_dirty and cpu_physical_memory_all_dirty. This requires a few changes in the iteration; chan

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 14:49, Peter Maydell wrote: >> > Self-NACK, this breaks (at least) FreeDOS. > Oops, I read this email five seconds after pushing the merge to master. > Can you send out reverts for the appropriate patches and I'll apply > them direct to master? I can send the fix. Paolo

[Qemu-devel] [PATCH] Rename cpu_get_icount_{locked,biased}

2016-02-10 Thread Christopher Covington
The function does not provide locking but rather adds a bias value. Signed-off-by: Christopher Covington --- cpus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 898426c..50403c4 100644 --- a/cpus.c +++ b/cpus.c @@ -164,7 +164,7 @@ int64_t cpu_

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

2016-02-10 Thread Cédric Le Goater
Hello Corey, On 02/09/2016 07:25 PM, Corey Minyard wrote: > On 02/09/2016 06:13 AM, Cédric Le Goater wrote: >> The first patches are cleanups and prepare ground for an extension of >> the BMC simulator providing a SDR loader using a file. A simple FRU >> support comes next. >> >> The last patches

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread Denis V. Lunev
On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap contents. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 55 +

Re: [Qemu-devel] [Qemu-stable] [PATCH] spapr: skip configuration section during migration of older machines

2016-02-10 Thread Greg Kurz
On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33 > Cc: qemu-sta...@nongnu.org > Signed-off

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 10.02.2016 um 14:33 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > > Am 09.02.

Re: [Qemu-devel] [PATCH v2 1/5] target-arm: Add the pmceid0 and pmceid1 registers

2016-02-10 Thread Aaron Lindsay
On Feb 09 15:11, Alistair Francis wrote: > On Tue, Feb 9, 2016 at 9:19 AM, Peter Maydell > wrote: > > On 6 February 2016 at 00:55, Alistair Francis > > wrote: > >> Signed-off-by: Aaron Lindsay > >> Signed-off-by: Alistair Francis > >> Tested-by: Nathan Rossi > >> --- > >> > >> target-arm/cpu

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

2016-02-10 Thread Peter Maydell
On 10 February 2016 at 12:48, Paolo Bonzini wrote: > > > On 09/02/2016 17:13, Paolo Bonzini wrote: >> The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' >> into staging (2016-02-09 11:42:43 +

Re: [Qemu-devel] [PATCH] target-arm: Implement DBGDTRRX_EL0/DBGDTRTX_EL0 MSR

2016-02-10 Thread Andreas Färber
Hi Andreas, Am 09.02.2016 um 21:59 schrieb Dirk Müller: > This is used by the ARM JTAG DCC console in the Linux kernel, > but can be ignored in order to continue booting. > > Co-Authored-By: Andreas Schwab If this was co-authored by you, we need a proper Signed-off-by please. > Signed-off-by:

Re: [Qemu-devel] [PATCH v6 3/4] tcg: Add type for vCPU pointers

2016-02-10 Thread Lluís Vilanova
Lluís Vilanova writes: > Richard Henderson writes: >> On 02/10/2016 08:14 AM, Lluís Vilanova wrote: >>> Adds the 'TCGv_env' type for pointers to 'CPUArchState' objects. The >>> tracing infrastructure later needs to differentiate between regular >>> pointers and pointers to vCPUs. >>> >>> Also cha

Re: [Qemu-devel] [PATCH V2 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Laurent Vivier
On 10/02/2016 14:31, Marcel Apfelbaum wrote: > Minimizes the possibility to assign > the same bit to different features. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding

2016-02-10 Thread Andreas Färber
Am 09.02.2016 um 21:57 schrieb Dirk Müller: > See C5.1.5 of the ARMv8 Reference Manual > > Signed-off-by: Dirk Mueller Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nür

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > > From:

[Qemu-devel] [PATCH V2 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Marcel Apfelbaum
Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h index 6686b10..e4548c2 100644

[Qemu-devel] [PATCH V2 0/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio feature in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used https://lists.gnu.org/archive/html/qemu-devel

[Qemu-devel] [PATCH V2 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. Reported-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > But e

Re: [Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Marcel Apfelbaum
On 02/10/2016 03:07 PM, Laurent Vivier wrote: On 10/02/2016 13:22, Marcel Apfelbaum wrote: Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletion

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

2016-02-10 Thread Halil Pasic
On 02/09/2016 02:15 PM, Sascha Silbe wrote: > Sort the alias table by typename so it's easier to see which aliases > exist. > > Signed-off-by: Sascha Silbe > --- > qdev-monitor.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/qdev-monitor.c b/qdev-moni

[Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Asia Slowinska
Stick to the expected order of the FPU registers in xsave (as specified in the Intel manual.) Otherwise, instructions loading the FPU state don't set it up correctly. To set up FPU, software needs to provide a buffer of 80 bytes storing 8 FPU registers. They are organized in a stack. FPU assumes t

Re: [Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Laurent Vivier
On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Commits 1811e64c and a6df8adf use the same virtio feature bit 4 > for different features. > > Fix it by using different bits. > > Reported-by: Laurent Vivier > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 2 +- > 1 file chang

Re: [Qemu-devel] [PATCH v6 3/4] tcg: Add type for vCPU pointers

2016-02-10 Thread Lluís Vilanova
Richard Henderson writes: > On 02/10/2016 08:14 AM, Lluís Vilanova wrote: >> Adds the 'TCGv_env' type for pointers to 'CPUArchState' objects. The >> tracing infrastructure later needs to differentiate between regular >> pointers and pointers to vCPUs. >> >> Also changes all targets to use the new

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-10 Thread Daniel P. Berrange
On Wed, Feb 10, 2016 at 01:45:22PM +0100, Samuel Thibault wrote: > Thomas Huth, on Wed 10 Feb 2016 12:39:10 +0100, wrote: > > > +if (!vprefix6) { > > > +vprefix6 = "fec0::"; > > > > Site-local prefixes have already been deprecated (see rfc3879) ... would > > it be feasible to use a ULA

Re: [Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Laurent Vivier
On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Minimizes the possibility to assign > the same bit to different features. > > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/hw/virtio/virt

Re: [Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Laurent Vivier
On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Commits 1811e64c and a6df8adf use the same virtio feature bit 4 > for different features. > > Fix it by using different bits. > > Reported-by: Laurent Vivier > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 2 +- > 1 file chang

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > But even this doesn't feel completely right, because block drivers are

Re: [Qemu-devel] [PATCH 15/15] tcg-mips: Use mipsr6 instructions in calls

2016-02-10 Thread James Hogan
Hi Richard, On Tue, Feb 09, 2016 at 09:40:03PM +1100, Richard Henderson wrote: > @@ -1313,28 +1315,30 @@ static void tcg_out_movcond(TCGContext *s, TCGCond > cond, TCGReg ret, > } > } > > -static void tcg_out_call_int(TCGContext *s, tcg_insn_unit *arg, bool tail) > +static void tcg_out_ca

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

2016-02-10 Thread Paolo Bonzini
On 09/02/2016 17:13, Paolo Bonzini wrote: > The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' > into staging (2016-02-09 11:42:43 +) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 12:39:10 +0100, wrote: > > +if (!vprefix6) { > > +vprefix6 = "fec0::"; > > Site-local prefixes have already been deprecated (see rfc3879) ... would > it be feasible to use a ULA prefix instead (fd00::/8, > see rfc4193) ? The question is which ULA. Ideal

Re: [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-10 Thread Thomas Huth
On 10.02.2016 13:30, Samuel Thibault wrote: > Thomas Huth, on Wed 10 Feb 2016 11:47:05 +0100, wrote: >>> + ip = mtod(m, struct ip *); >>> + ip6 = mtod(m, struct ip6 *); >>> + save_ip = *ip; >>> + save_ip6 = *ip6; >> >> Could you do the "save_ip = *ip" within the "case AF_INET" below, and >>

Re: [Qemu-devel] Tracking the VM making an IO request

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 11:23, Stefan Hajnoczi wrote: > On Wed, Feb 10, 2016 at 12:35:54PM +0330, Aarian P. Aleahmad > wrote: >> I'm a student, engaged in a project in which QEMU is a candidate >> to be used to make some studies about IO usage etc. I need to >> track the IO requests made to the block devic

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Paolo Bonzini
On 09/02/2016 20:08, Laszlo Ersek wrote: > On 02/09/16 11:59, Paolo Bonzini wrote: >> The "max" value is being compared with >=, but addr + width points to >> the first byte that will _not_ be copied. Subtract one like it is >> already done above for the height. >> >> Cc: Gerd Hoffmann >> Signe

Re: [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 11:47:05 +0100, wrote: > > + ip = mtod(m, struct ip *); > > + ip6 = mtod(m, struct ip6 *); > > + save_ip = *ip; > > + save_ip6 = *ip6; > > Could you do the "save_ip = *ip" within the "case AF_INET" below, and > the "save_ip6 = *ip6" within the case AF_INET6

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > -Original Message- > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > But even this doesn't feel completely right, because block drivers are > > > > already layere

[Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. Reported-by: Laurent Vivier Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pc

[Qemu-devel] [PATCH 0/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio features in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used https://lists.gnu.org/archive/html/qemu-deve

[Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Marcel Apfelbaum
Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h index 6686b10..817bcde 100644 -

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 11:08:55 +0100, wrote: > On 10.02.2016 10:28, Samuel Thibault wrote: > > Thomas Huth, on Wed 10 Feb 2016 09:05:32 +0100, wrote: > >>> -#define SLIRP_MSIZE (IF_MTU + IF_MAXLINKHDR + offsetof(struct mbuf, > >>> m_dat) + 6) > >>> +#define SLIRP_MSIZE\ > >>> +(offse

Re: [Qemu-devel] [PATCH v2] s390x: remove s390-zipl.rom

2016-02-10 Thread Cornelia Huck
On Wed, 10 Feb 2016 14:09:46 +0300 Michael Tokarev wrote: > This is an s390 boot rom which was used in s390-virtio machine. > but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 > "s390x: remove s390-virtio machine", this file isn't used. > The only place it is referenced in the code is an

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Daniel P. Berrange
On Wed, Feb 10, 2016 at 01:53:49PM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: > > On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: > > >On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > > >>On 02/09/2016 01:21 PM, Michael S. T

Re: [Qemu-devel] [PATCH v2 0/5] Drop support for Xen 4.1 and older from qemu-xen

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > This is most easily explained by the commit log of the first patch: > >     Xen 4.2 become unsupported upstream in 09/2015 (see > http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the > interfaces provided by the toolstack librarie

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
> -Original Message- > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > But even this doesn't feel completely right, because block drivers are > > > already layered and there is no need to hardcode something optional (and > > > r

Re: [Qemu-devel] [PATCH v2 5/5] xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > We assume (and check for in configure) 4.2 or later now. In reality > all of the removed checks are for far older versions. > > FMT_ioreq_size is no longer needed. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini > v2: Drop FMT_ioreq_

Re: [Qemu-devel] [PATCH v2 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > Xen 4.2 become unsupported upstream in 09/2015 (see > http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the > interfaces provided by the toolstack libraries go 4.2 and 4.3 are > indistinguishable. > > Therefore drop support for Xen 4.1 and

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: > On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: > >On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > >>On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: > >>>On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berra

Re: [Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-10 Thread Michael Tokarev
10.02.2016 14:35, Christian Borntraeger wrote: > On 02/10/2016 12:06 PM, Michael Tokarev wrote: >> This is an s390 boot rom which was used in s390-virtio machine. >> but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 >> "s390x: remove s390-virtio machine", this file isn't used. >> The only p

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > But even this doesn't feel completely right, because block drivers are > > already layered and there is no need to hardcode something optional (and > > rarely used) in the hot code path that c

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Yann Bordenave > > This patch adds parameters to manage some new options in the qemu -net > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults parameters are respectivel

Re: [Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-10 Thread Christian Borntraeger
On 02/10/2016 12:06 PM, Michael Tokarev wrote: > This is an s390 boot rom which was used in s390-virtio machine. > but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 > "s390x: remove s390-virtio machine", this file isn't used. > The only place it is referenced in the code is an unused > whic

[Qemu-devel] [Bug 1533848] Re: A workaround for Windows 7 ACPI SLIC table behavior when used with OVMF

2016-02-10 Thread Laszlo Ersek (Red Hat)
Fixed in 37ad223^..ae12374. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1533848 Title: A workaround for Windows 7 ACPI SLIC table behavior

Re: [Qemu-devel] [PATCH 00/12] tests: Introducing docker tests

2016-02-10 Thread Alex Bennée
Fam Zheng writes: > v1: Since RFC, addressed comments from reviewers, and improved a lot of > things. > Thanks to Daniel, Eric, Paolo, Stefan, for the feedback. > > This series adds a new "docker" make target family to run tests in created > docker containers. > > To begin with, this can be

[Qemu-devel] [PATCH v2] s390x: remove s390-zipl.rom

2016-02-10 Thread Michael Tokarev
This is an s390 boot rom which was used in s390-virtio machine. but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 "s390x: remove s390-virtio machine", this file isn't used. The only place it is referenced in the code is an unused define ZIPL_FIRMWARE. There's also comment in hw/s390/ipl.c

[Qemu-devel] [PATCH v2 2/5] xen: drop xen_xc_hvm_inject_msi wrapper

2016-02-10 Thread Ian Campbell
The xc version is now always present. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- include/hw/xen/xen_common.h | 6 -- xen-hvm.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common

[Qemu-devel] [PATCH v2 3/5] xen: drop XenXC and associated interface wrappers

2016-02-10 Thread Ian Campbell
Now that 4.2 and earlier are no longer supported "xc_interface *" is always the right type for the xc interface handle. With this we can also simplify the handling of the xenforeignmemory compatibility wrapper by making xenforeignmemory_handle == xc_interface, instead of an xc_interface* and remov

[Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-10 Thread Michael Tokarev
This is an s390 boot rom which was used in s390-virtio machine. but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 "s390x: remove s390-virtio machine", this file isn't used. The only place it is referenced in the code is an unused which I'm modifying too, to refer to s390-ccw.rom instead. C

[Qemu-devel] [PATCH v2 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Ian Campbell
Xen 4.2 become unsupported upstream in 09/2015 (see http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the interfaces provided by the toolstack libraries go 4.2 and 4.3 are indistinguishable. Therefore drop support for Xen 4.1 and earlier which removes a whole pile of compatibility

[Qemu-devel] [PATCH v2 4/5] xen: move xenforeignmemory compat layer into common place

2016-02-10 Thread Ian Campbell
Now that we no longer support Xen 4.2 and earlier only the <470 case needs this so it can live with all the others. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- include/hw/xen/xen_common.h | 34 ++ 1 file changed, 14 insertions(+), 20 deletions

[Qemu-devel] [PATCH v2 5/5] xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2

2016-02-10 Thread Ian Campbell
We assume (and check for in configure) 4.2 or later now. In reality all of the removed checks are for far older versions. FMT_ioreq_size is no longer needed. Signed-off-by: Ian Campbell --- v2: Drop FMT_ioreq_size too --- hw/display/xenfb.c | 7 --- xen-hvm.c | 19 ++--

[Qemu-devel] [PATCH v2 0/5] Drop support for Xen 4.1 and older from qemu-xen

2016-02-10 Thread Ian Campbell
This is most easily explained by the commit log of the first patch:     Xen 4.2 become unsupported upstream in 09/2015 (see http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the interfaces provided by the toolstack libraries go 4.2 and 4.3 are indistinguishable.   

Re: [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch adds IPv6 case in TCP functions refactored by the last > patches. > This also adds IPv6 pseudo-header in tcpiphdr structure. > Finally, tcp_input() is called by ip6_input(). > > Signed-off-by: Guillaume Subiron

Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > On Tue, 2016-02-09 at 16:50 +, Stefano Stabellini wrote: > > > @@ -2218,15 +2127,10 @@ EOF > > >  fi > > >  > > >  if test "$xen_pci_passthrough" != "no"; then > > > -  if test "$xen" = "yes" && test "$linux" = "yes" && > > > -    test "$xen_ctrl_vers

Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Ian Campbell
On Tue, 2016-02-09 at 16:50 +, Stefano Stabellini wrote: > > @@ -2218,15 +2127,10 @@ EOF > >  fi > >  > >  if test "$xen_pci_passthrough" != "no"; then > > -  if test "$xen" = "yes" && test "$linux" = "yes" && > > -    test "$xen_ctrl_version" -ge 340; then > > +  if test "$xen" = "yes" && tes

Re: [Qemu-devel] Tracking the VM making an IO request

2016-02-10 Thread Stefan Hajnoczi
On Wed, Feb 10, 2016 at 12:35:54PM +0330, Aarian P. Aleahmad wrote: > I'm a student, engaged in a project in which QEMU is a candidate to be used > to make some studies about IO usage etc. > I need to track the IO requests made to the block devices (e.g. HDD, SSD, > etc.). I check the source code b

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-10 Thread Laurent Vivier
On 05/02/2016 11:39, Greg Kurz wrote: > This series brings some improvements to the cross-endian support in the > virtio and vhost code: > - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net, > so that backend cross-endian capabilities benefit to both emulated and > vhost

Re: [Qemu-devel] [PATCH 1/3] trace: docs: "simple" backend does support strings

2016-02-10 Thread Stefan Hajnoczi
On Mon, Feb 08, 2016 at 04:03:03PM -0800, Hollis Blanchard wrote: > The simple tracing backend has supported strings for more than three years > (62bab73213ba885426a781eb2741670b9f3cae36). > > Signed-off-by: Hollis Blanchard > --- > docs/tracing.txt | 3 --- > 1 file changed, 3 deletions(-) Tha

Re: [Qemu-devel] Regarding Cortex-A7 CPU definition

2016-02-10 Thread Peter Maydell
On 10 February 2016 at 05:25, Deepak kumar Raju wrote: > Regarding the questions, we have hw board which has Cortex-A7, so we thought > we have to go with A7 emulation. we were not very sure A15 emulation will be > almost equivalent to A7 emulation. > All we want to do is A7 emulation but now I am

Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints

2016-02-10 Thread Stefan Hajnoczi
On Tue, Feb 09, 2016 at 09:31:23AM -0800, Hollis Blanchard wrote: > On 02/09/2016 07:53 AM, Stefan Hajnoczi wrote: > >On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote: > >>-memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsigned > >>size) "mr %p offset %#"PRIx64"

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-10 Thread Stefan Hajnoczi
On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: > On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: > >On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > >>On 02/03/2016 11:14 AM, Fam Zheng wrote: > >>>On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > Hi all

Re: [Qemu-devel] "x-disable-pcie" virtio-pci property in compat_props (HW_COMPAT_2_4)

2016-02-10 Thread Laurent Vivier
On 10/02/2016 10:52, Marcel Apfelbaum wrote: > On 02/09/2016 07:38 PM, Laurent Vivier wrote: >> Hi, >> >> I'm playing with a qemu-2.5.0 and pc-i440fx-2.4 machine type, and >> perhaps I don't understand correctly the compat_props machinery but >> there is something strange for me: >> >> in qemu-2.

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-10 Thread Thomas Huth
On 10.02.2016 10:28, Samuel Thibault wrote: > That one is tricky, yes :) > > Thomas Huth, on Wed 10 Feb 2016 09:05:32 +0100, wrote: >>> -#define SLIRP_MSIZE (IF_MTU + IF_MAXLINKHDR + offsetof(struct mbuf, m_dat) >>> + 6) >>> +#define SLIRP_MSIZE\ >>> +(offsetof(struct mbuf, m_dat) + IF_MAXLIN

<    1   2   3   >