[Qemu-devel] memory stats collect on Windows virtio-driver

2016-02-11 Thread Jean-Pierre Ribeauville
Hi, By validating memory stats collect via this libvirt call : virsh dommemstat win2k8r2-2 --period 20 I'm not able to get others tags than theses ones : #virsh dommemstat win2k8r2-2 actual 2097152 rss 4729140 For a Linux Guest , it works: # virsh dommemstat rhel6.1 actual 8192000 swap_in

Re: [Qemu-devel] lock-free monitor?

2016-02-11 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert" writes: >> >> >> >> > Hi,

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

2016-02-11 Thread Markus Armbruster
Sascha Silbe writes: > Sort the alias table by typename so it's easier to see which aliases > exist. > > Signed-off-by: Sascha Silbe > --- > qdev-monitor.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi}

2016-02-11 Thread Markus Armbruster
Sascha Silbe writes: > virtio-{blk,balloon,net,serial} are aliases for their actual, > architecture-dependent implementations (*-ccw on s390x, *-pci on other > architectures supporting virtio). This makes it a lot easier to craft > qemu invocations that work on all

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

2016-02-11 Thread Paolo Bonzini
On 11/02/2016 10:43, Leonid Bloch wrote: > ping > > http://patchwork.ozlabs.org/patch/537763 > http://patchwork.ozlabs.org/patch/537762 > > On Sun, Jan 31, 2016 at 4:13 PM, Leonid Bloch wrote: >> ping >> >> http://patchwork.ozlabs.org/patch/537763 >>

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-11 Thread Paolo Bonzini
On 10/02/2016 23:40, Peter Maydell wrote: > On 10 February 2016 at 14:11, Paolo Bonzini wrote: >> The last two arguments to these functions are the last and first bit to >> check relative to the base. The code was using incorrectly the first >> bit and the number of bits.

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

2016-02-11 Thread David Hildenbrand
> Am 10.02.2016 um 16:28 schrieb David Hildenbrand: > > For x86, cpu models are realized by making x86_64-cpu an abstract class and > > creating loads of new classes, e.g. host-x86_64-cpu or haswell-x86_64-cpu. > > > > How does 'device_add ' play together with the x86 cpu model > > approach? And

Re: [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi}

2016-02-11 Thread Cornelia Huck
On Thu, 11 Feb 2016 10:01:35 +0100 Markus Armbruster wrote: > Sascha Silbe writes: > > This leaves out > > virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because > > they're currently only implemented using PCI, so there's no

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-11 Thread Kevin Wolf
Am 11.02.2016 um 07:05 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > However, I don't understand yet which layer do you offer as the candidate > > > for record/replay? What functions should be

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

2016-02-11 Thread Leonid Bloch
ping http://patchwork.ozlabs.org/patch/537763 http://patchwork.ozlabs.org/patch/537762 On Sun, Jan 31, 2016 at 4:13 PM, Leonid Bloch wrote: > ping > > http://patchwork.ozlabs.org/patch/537763 > http://patchwork.ozlabs.org/patch/537762 > > On Mon, Jan 11, 2016 at 2:12 PM,

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-11 Thread Michael S. Tsirkin
On Thu, Feb 11, 2016 at 07:34:52PM +0200, Marcel Apfelbaum wrote: > On 02/11/2016 06:30 PM, Michael S. Tsirkin wrote: > >On Thu, Feb 11, 2016 at 04:16:05PM +0100, Igor Mammedov wrote: > >>On Tue, 9 Feb 2016 14:17:44 +0200 > >>"Michael S. Tsirkin" wrote: > >> > >>>On Tue, Feb 09,

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

2016-02-11 Thread David Gibson
On Thu, Feb 11, 2016 at 04:53:40PM +, Dr. David Alan Gilbert wrote: > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > > On Mon, 08 Feb 2016 16:59:47 +0100 > > Greg Kurz wrote: > > > Since QEMU 2.4, we have a configuration section in the migration stream. > > > This

Re: [Qemu-devel] [PATCH 1/9] dma-helpers: Expose the sg mapping logic

2016-02-11 Thread Paolo Bonzini
On 16/12/2015 17:55, Alex Pyrgiotis wrote: > +/* > + * Create a QEMUIOVector from a scatter-gather list. > + * > + * This function does not copy the data of the scatter-gather list. Instead, > it > + * uses the dma_memory_map() function to map physical memory regions of the > + * virtual device

Re: [Qemu-devel] [PULL 00/15] target-arm queue

2016-02-11 Thread Peter Maydell
On 9 February 2016 at 18:42, Peter Maydell wrote: > Various things in this pull, but the one I care most about is that > it includes the "enable EL3 for 64-bit CPUs" patches. > > thanks > -- PMM > > > The following changes since commit

Re: [Qemu-devel] [PATCH v6 5/9] qemu-log: support simple pid substitution in logfile

2016-02-11 Thread Alex Bennée
Alex Bennée writes: > When debugging stuff that occurs over several forks it would be useful > not to keep overwriting the one logfile you've set-up. This allows a > simple %d to be included once in the logfile parameter which is > substituted with getpid(). > >

[Qemu-devel] [PULL 04/14] cpu: cpu_save/cpu_load is no more

2016-02-11 Thread Michael Tokarev
From: Paolo Bonzini Everything has been converted to vmstate. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- exec.c| 6 -- include/qemu-common.h | 6 -- 2 files changed, 12 deletions(-) diff

[Qemu-devel] [PULL 09/14] ES1370: QOMify

2016-02-11 Thread Michael Tokarev
From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/audio/es1370.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c index

[Qemu-devel] [PULL 01/14] remove libtool support

2016-02-11 Thread Michael Tokarev
Libtool support was needed to build shared library for libcacard. Now there's no need to use libtool, and since the build system is already complicated enough, we have a way to slightly de-complicate it. Signed-off-by: Michael Tokarev Reviewed-by: Greg Kurz

[Qemu-devel] [PATCH RESEND v5] i2c-tiny-usb is a small usb to i2c bridge

2016-02-11 Thread Tim Sander
Hi Probably due to my less then stellar patch to mail handling i think this patch got forgotten. I think its ok to resend. The patch itself is unchanged. It should incorperate all sugestions but the one of Peter due not beeing mainlined:

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-11 Thread Igor Mammedov
On Tue, 9 Feb 2016 14:17:44 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 09, 2016 at 11:46:08AM +0100, Igor Mammedov wrote: > > > So the linker interface solves this rather neatly: > > > bios allocates memory, bios passes memory map to guest. > > > Served us well for several

Re: [Qemu-devel] [PATCH v7 3/5] acpi: pc: add fw_cfg device node to ssdt

2016-02-11 Thread Igor Mammedov
On Wed, 10 Feb 2016 15:41:38 -0500 "Gabriel L. Somlo" wrote: > Add a fw_cfg device node to the ACPI SSDT. While the guest-side > firmware can't utilize this information (since it has to access > the hard-coded fw_cfg device to extract ACPI tables to begin with), > having fw_cfg

Re: [Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay

2016-02-11 Thread Stefan Hajnoczi
On Thu, Feb 11, 2016 at 04:52:42PM +0300, Pavel Dovgalyuk wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > On Wed, Feb 10, 2016 at 12:13:23PM +0300, Pavel Dovgalyuk wrote: > > > @@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk, > > > return

Re: [Qemu-devel] [PULL 00/11] Ide patches

2016-02-11 Thread Peter Maydell
On 10 February 2016 at 19:37, John Snow wrote: > The following changes since commit c9f19dff101e2c2cf3fa3967eceec2833e845e40: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-02-09 19:34:46 +) > > are available in the git

Re: [Qemu-devel] [BUG] trace: QEMU hangs on initialization with the "simple" backend

2016-02-11 Thread Stefan Hajnoczi
On Tue, Feb 09, 2016 at 09:24:04PM +0100, Lluís Vilanova wrote: > While starting the softmmu version of QEMU, the simple backend waits for the > writeout thread to signal a condition variable when initializing the output > file > path. But since the writeout thread has not been created, it just

[Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-11 Thread Denis V. Lunev
There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in starting from suspended state, i.e. it processes incoming migration, and in the same time 'info block' is called. The problem is that qcow2_invalidate_cache() closes the

[Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-02-11 Thread Denis V. Lunev
There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in starting from suspended state, i.e. it processes incoming migration, and in the same time 'info block' is called. The problem is that qcow2_invalidate_cache() closes the

[Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-02-11 Thread Denis V. Lunev
There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in starting from suspended state, i.e. it processes incoming migration, and in the same time 'info block' is called. The problem is that qcow2_invalidate_cache() closes the

Re: [Qemu-devel] [PATCH v10] spec: add qcow2 bitmaps extension specification

2016-02-11 Thread Denis V. Lunev
On 02/05/2016 11:58 AM, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now there is only one type of such

[Qemu-devel] [PATCH 2/4] target-arm: Move get/set_r13_banked() to op_helper.c

2016-02-11 Thread Peter Maydell
Move get/set_r13_banked() from helper.c to op_helper.c. This will let us add exception-raising code to them, and also puts them in the same file as get/set_user_reg(), which makes some conceptual sense. (The original reason for the helper.c/op_helper.c split was that only op_helper.c had access

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-11 Thread Thomas Huth
On 10.02.2016 14:08, Daniel P. Berrange wrote: > On Wed, Feb 10, 2016 at 01:45:22PM +0100, Samuel Thibault wrote: >> Thomas Huth, on Wed 10 Feb 2016 12:39:10 +0100, wrote: +if (!vprefix6) { +vprefix6 = "fec0::"; >>> >>> Site-local prefixes have already been deprecated (see

[Qemu-devel] [PATCH 1/4] target-arm: Clean up trap/undef handling of SRS

2016-02-11 Thread Peter Maydell
The SRS instruction is: * UNDEFINED in Hyp mode * UNPREDICTABLE in User or System mode * UNPREDICTABLE if the specified mode isn't accessible * trapped to EL3 if EL3 is AArch64 and we are at Secure EL1 Clean up the code to handle all these cases cleanly, including picking UNDEF as our choice

[Qemu-devel] [PATCH 0/4] target-arm: Clean up trap/undef handling of SRS

2016-02-11 Thread Peter Maydell
The SRS instruction is a bit of an oddity because it isn't used by Linux these days. Nonetheless it has a bunch of UNPREDICTABLE, UNDEF and trapping behaviour that we weren't correctly implementing: - trap to EL3 if EL3 is AArch64 and we are at Secure EL1 - UNDEFINED in Hyp mode -

Re: [Qemu-devel] [PATCH V4] vl.c: fixed regression in machine error message

2016-02-11 Thread Eduardo Habkost
On Thu, Feb 11, 2016 at 08:49:25PM +0200, Marcel Apfelbaum wrote: > On 02/11/2016 08:31 PM, Eduardo Habkost wrote: > >On Mon, Feb 08, 2016 at 01:54:29PM +0200, Marcel Apfelbaum wrote: > >>Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config > >>file) > >>fixed the error

[Qemu-devel] [Bug 1098729] Re: qemu-user-static for armhf: segfault in threaded code

2016-02-11 Thread Andrea Mazzoleni
I can confirm that building QEMU 2.5.0 from source, all the multi-thread issues seem to be fixed. Specifically, the mentioned dotprod_mutex.c example, even when modified to use 100 threads, is always running in the qemu-arm User mode emulator. Tested in Ubuntu 14.04 x86_64, with all the updates

[Qemu-devel] [PATCH 4/4] target-arm: UNDEF in the UNPREDICTABLE SRS-from-System case

2016-02-11 Thread Peter Maydell
Make get_r13_banked() raise an exception at runtime for the corner case of SRS from System mode, so that we can UNDEF it; this brings us in to line with the ARM ARM's set of permitted CONSTRAINED UNPREDICTABLE choices. Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-11 Thread Peter Maydell
The user-mode versions of get/set_r13_banked() exist just to assert if they're ever called -- the translate time code should never emit calls to them because SRS from user mode always UNDEF. There's no code in the softmmu versions that can't compile in CONFIG_USER_ONLY, so combine the two

[Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-11 Thread Denis V. Lunev
From: "Alexey V. Kostyushko" With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the problem is the following. Windows checks

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-11 Thread Eduardo Habkost
On Fri, Feb 05, 2016 at 09:51:07AM +0200, Marcel Apfelbaum wrote: > On 02/05/2016 09:49 AM, Markus Armbruster wrote: > >"Michael S. Tsirkin" writes: > > > >>On Thu, Feb 04, 2016 at 12:55:22PM +0100, Paolo Bonzini wrote: > >>> > >>> > >>>On 04/02/2016 12:41, Andreas Färber wrote:

[Qemu-devel] [PATCH v6 2/9] qemu-log: correct help text for -d cpu

2016-02-11 Thread Alex Bennée
This doesn't just dump CPU state on translation but on every block entrance. Signed-off-by: Alex Bennée Reviewed-by: Andreas Färber Reviewed-by: Richard Henderson --- v4 - add r-b tag v5 - slightly tweak the wording now nochain

[Qemu-devel] [PATCH v6 0/9] qemu-log, -dfilter and other logging tweaks

2016-02-11 Thread Alex Bennée
Mostly this is version has been collection r-b tags but the re-factoring patch is now even simpler. The most attention has been on the -dfilter option patch because handling user-input is hard. I've removed the funky corner cases from trying to be clever and added some unit tests to defend it.

[Qemu-devel] [PATCH v6 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging

2016-02-11 Thread Alex Bennée
From: Peter Maydell Make qemu_log_mask() a macro which only calls the function to do the actual work if the logging is enabled. This avoids making a function call in possible fast paths where logging is disabled. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-11 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 11.02.2016 um 12:00 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 11.02.2016 um 07:05 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 10.02.2016 um

[Qemu-devel] [PULL 06/14] rdma: remove check on time_spent when calculating mbs

2016-02-11 Thread Michael Tokarev
From: Wei Yang Within the if statement, time_spent is assured to be non-zero. This patch just removes the check on time_spent when calculating mbs. Signed-off-by: Wei Yang Signed-off-by: Michael Tokarev ---

Re: [Qemu-devel] [PATCH] os-posix: Log to logfile in case of daemonize

2016-02-11 Thread Paolo Bonzini
On 11/02/2016 13:12, Dimitris Aragiorgis wrote: > Besides that, when one executes a daemon, shell redirection is > hardly, if ever, used. More so if the daemon already has a logfile > option. > > So, we decided to give it a go and find the least painful way to > log the stderr of a QEMU process

[Qemu-devel] [PATCH v2 1/4] hw/ppc/spapr: Add h_set_sprg0 hypercall

2016-02-11 Thread Thomas Huth
This is a very simple hypercall that only sets up the SPRG0 register for the guest (since writing to SPRG0 was only permitted to the hypervisor in older versions of the PowerISA). Signed-off-by: Thomas Huth --- hw/ppc/spapr_hcall.c | 15 +-- 1 file changed, 13

[Qemu-devel] [PATCH v2 2/4] hw/ppc/spapr: Implement h_set_dabr

2016-02-11 Thread Thomas Huth
According to LoPAPR, h_set_dabr should simply set DABRX to 3 (if the register is available), and load the parameter into DABR. If DABRX is not available, the hypervisor has to check the "Breakpoint Translation" bit of the DABR register first. Signed-off-by: Thomas Huth ---

[Qemu-devel] [PATCH v2 0/4] hw/ppc/spapr: Add "Processor Register Hypervisor Resource Access" H-calls

2016-02-11 Thread Thomas Huth
While we were recently debugging a problem with the H_SET_DABR call [1], I noticed that some hypercalls from the chapter 14.5.4.3 ("Processor Register Hypervisor Resource Access") from the LoPAPR spec [2] are still missing in QEMU. So here's are some patches that implement these hypercalls. Linux

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-11 Thread Peter Maydell
On 10 February 2016 at 22:40, Peter Maydell wrote: > On 10 February 2016 at 14:11, Paolo Bonzini wrote: >> The last two arguments to these functions are the last and first bit to >> check relative to the base. The code was using incorrectly the

[Qemu-devel] [PATCH v6 6/9] qemu-log: new option -dfilter to limit output

2016-02-11 Thread Alex Bennée
When debugging big programs or system emulation sometimes you want both the verbosity of cpu,exec et all but don't want to generate lots of logs for unneeded stuff. This patch adds a new option -dfilter which allows you to specify interesting address ranges in the form: -dfilter

Re: [Qemu-devel] [PATCH 3/9] dma-helpers: Do not truncate small qiovs

2016-02-11 Thread Paolo Bonzini
On 16/12/2015 17:55, Alex Pyrgiotis wrote: > If the size of the qiov is smaller than the sector size, do not truncate > the qiov, which would effectively make it empty. Instead, allow it to > pass as is. > > This is necessary for SCSI requests like READ CAPACITY which have small > buffers, e.g.

[Qemu-devel] [PULL v2 00/15] target-arm queue

2016-02-11 Thread Peter Maydell
/pmaydell/qemu-arm.git tags/pull-target-arm-20160211 for you to fetch changes up to f0afa73164778570083504a185d7498884c68d65: bcm2835_property: implement "get board revision" query (2016-02-11 11:17:32 +) target-arm que

[Qemu-devel] [PULL 13/14] Adds keycode 86 to the hid_usage_keys translation table.

2016-02-11 Thread Michael Tokarev
From: Daniel Serpell This key is present in international keyboards, between left shift and the 'Z' key, ant is described in the HID usage tables as "Keyboard Non-US \ and |": http://www.usb.org/developers/hidpage/Hut1_12v2.pdf This patch fixes the usb-kbd devices.

[Qemu-devel] [PULL 08/14] char: fix parameter name / type in BSD codepath

2016-02-11 Thread Michael Tokarev
From: "Daniel P. Berrange" The BSD impl of qemu_chr_open_pp_fd had mis-declared its parameter type as ChardevBackend instead of ChardevCommon. It had also mistakenly used the variable name 'common' instead of 'backend'. Tested-by: Sean Bruno

[Qemu-devel] [PATCH v6 7/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op

2016-02-11 Thread Alex Bennée
This ensures the code generation debug code will honour -dfilter if set. For the "exec" tracing I've added a new inline macro for efficiency's sake. Signed-off-by: Alex Bennée Reviewed-by: Aurelien Jarno Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v6 8/9] target-arm: dfilter support for in_asm

2016-02-11 Thread Alex Bennée
Each individual architecture needs to use the qemu_log_in_addr_range() feature for enabling in_asm output as it is part of the frontend. Signed-off-by: Alex Bennée Reviewed-by: Aurelien Jarno --- v5 - no longer wrapping tcg_gen_insn_start (was

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-11 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 11.02.2016 um 07:05 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > > However, I don't understand yet which layer do you offer as the > > > >

[Qemu-devel] [PATCH] usb: check USB configuration descriptor object

2016-02-11 Thread P J P
From: Prasad J Pandit When processing remote NDIS control message packets, the USB Net device emulator checks to see if the USB configuration descriptor object is of RNDIS type(2). But it does not check if it is null, which leads to a null dereference error. Add check to

[Qemu-devel] [PULL 05/14] qemu-sockets: simplify error handling

2016-02-11 Thread Michael Tokarev
From: Paolo Bonzini Just go always through the err label. (Noticed because Coverity complains that peer is always non-NULL in the error cleanup code, but removing the "if" is arguably more prone to introducing the opposite bug in the future). Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 02/14] man: virtfs-proxy-helper: Rework awkward sentence

2016-02-11 Thread Michael Tokarev
From: Christophe Fergeau There was a 'capbilities' typo in this man page. This commit reformulates the sentence the typo was in to make it easier to grasp. This is based on a suggestion from Eric Blake. Signed-off-by: Christophe Fergeau Reviewed-by:

[Qemu-devel] [PULL 03/14] qom: Correct object_property_get_int() description

2016-02-11 Thread Michael Tokarev
From: Alistair Francis The description of object_property_get_int() stated that on an error it returns NULL. This is not the case and the function will return -1 if an error occurs. Update the commented documentation accordingly. Reported-By: Christian Liebhardt

Re: [Qemu-devel] [RFC v7 01/16] exec.c: Add new exclusive bitmap to ram_list

2016-02-11 Thread Alex Bennée
Alvise Rigo writes: > The purpose of this new bitmap is to flag the memory pages that are in > the middle of LL/SC operations (after a LL, before a SC). For all these > pages, the corresponding TLB entries will be generated in such a way to > force the slow-path

Re: [Qemu-devel] Memory on stellaris board

2016-02-11 Thread Aurelio Remonda
On Fri, Feb 5, 2016 at 2:00 PM, Peter Maydell wrote: > On 5 February 2016 at 16:55, Aurelio Remonda > wrote: >> Im making something like this: >> >> if (ram_size == 0x800) /* default value, means whitout -m flag */ >>

Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000

2016-02-11 Thread Paolo Bonzini
On 05/02/2016 14:56, Amit Shah wrote: > Commit 8304402033e8dbe8e379017d51ed1dd8344f1dce changed the name of the > e1000-82540em device to e1000. This was flagged: > >Section "e1000-82540em" does not exist in dest > > Add the mapping to the changed section names dictionary so the checker >

Re: [Qemu-devel] [PULL v2 00/15] target-arm queue

2016-02-11 Thread Peter Maydell
nd find_next_zero_bit (2016-02-10 > 22:38:24 +) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20160211 > > for you to fetch changes up to f0afa73164778570083504a185d7498884c68d65: > > bcm

Re: [Qemu-devel] [RFC v7 02/16] softmmu: Simplify helper_*_st_name, wrap unaligned code

2016-02-11 Thread Alex Bennée
Alvise Rigo writes: > Attempting to simplify the helper_*_st_name, wrap the > do_unaligned_access code into an inline function. > Remove also the goto statement. How are you generating your CC list? get_maintainer.pl shows Peter Croshwaite (CC'ed) should also be

Re: [Qemu-devel] [PATCH] linux-user: Don't assert if guest tries shmdt(0)

2016-02-11 Thread Laurent Vivier
Le 09/02/2016 16:57, Peter Maydell a écrit : > Our implementation of shmat() and shmdt() for linux-user was > using "zero guest address" as its marker for "entry in the > shm_regions[] array is not in use". This meant that if the > guest did a shmdt(0) we would match on an unused array entry >

[Qemu-devel] [Bug 1544524] [NEW] "info chardev" not showing the real port in use

2016-02-11 Thread Prem Anand
Public bug reported: With Qemu 2.1.2 === pharidos@uks2:~$ qemu-system-x86_64 -hda Disk.qcow2 -serial telnet::0,server,nowait -nographic QEMU 2.1.2 monitor - type 'help' for more information (qemu) info chardev parallel0: filename=null serial0: filename=telnet:0.0.0.0:44189,server

[Qemu-devel] [PULL 00/14] Trivial patches for 2016-02-11

2016-02-11 Thread Michael Tokarev
Here's yet another trivial-patches pull request. There aren't many patches in there this time, even if the previous pull request was quite some time ago. Speaking of the pull requests. Maybe it is better to use the same tag all the time, instead of separate tags for every pull? Thanks, /mjt

[Qemu-devel] [PULL 12/14] s390x: remove s390-zipl.rom

2016-02-11 Thread Michael Tokarev
This is an s390 boot rom which was used in s390-virtio machine. but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 "s390x: remove s390-virtio machine", this file isn't used. The only place it is referenced in the code is an unused define ZIPL_FILENAME. There's also comment in hw/s390/ipl.c

[Qemu-devel] [PULL 14/14] w32: include winsock2.h before windows.h

2016-02-11 Thread Michael Tokarev
From: Paolo Bonzini Recent Fedora complains while compiling ui/sdl.c: /usr/x86_64-w64-mingw32/sys-root/mingw/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp] And with this patch we dutifully obey. Stefan Weil: Without

[Qemu-devel] [PATCH v2 4/4] hw/ppc/spapr: Implement the h_page_init hypercall

2016-02-11 Thread Thomas Huth
This hypercall either initializes a page with zeros, or copies another page. According to LoPAPR, the i-cache of the page should also be flushed if using H_ICACHE_INVALIDATE or H_ICACHE_SYNCHRONIZE, and the d-cache should be synchronized to the RAM if the H_ICACHE_SYNCHRONIZE flag is used. For

Re: [Qemu-devel] Memory on stellaris board

2016-02-11 Thread Peter Maydell
On 11 February 2016 at 12:46, Aurelio Remonda wrote: > On Fri, Feb 5, 2016 at 2:00 PM, Peter Maydell > wrote: >> The right way to do this is to set the MachineClass default_ram_size >> to what you want your default value to be.

Re: [Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay

2016-02-11 Thread Stefan Hajnoczi
On Wed, Feb 10, 2016 at 12:13:23PM +0300, Pavel Dovgalyuk wrote: > @@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk, > return blk_abort_aio_request(blk, cb, opaque, -ENOMEDIUM); > } > > -return bdrv_aio_flush(blk->bs, cb, opaque); > +if (replay_mode ==

Re: [Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay

2016-02-11 Thread Pavel Dovgalyuk
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > On Wed, Feb 10, 2016 at 12:13:23PM +0300, Pavel Dovgalyuk wrote: > > @@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk, > > return blk_abort_aio_request(blk, cb, opaque, -ENOMEDIUM); > > } > > > > -return

Re: [Qemu-devel] [RFC v7 04/16] softmmu: Simplify helper_*_st_name, wrap RAM code

2016-02-11 Thread Alex Bennée
Alvise Rigo writes: > Attempting to simplify the helper_*_st_name, wrap the code relative to a > RAM access into an inline function. > > Based on this work, Alex proposed the following patch series >

Re: [Qemu-devel] [RFC v7 01/16] exec.c: Add new exclusive bitmap to ram_list

2016-02-11 Thread alvise rigo
You are right, the for loop with i < DIRTY_MEMORY_NUM works just fine. Thank you, alvise On Thu, Feb 11, 2016 at 2:00 PM, Alex Bennée wrote: > > Alvise Rigo writes: > >> The purpose of this new bitmap is to flag the memory pages that are

[Qemu-devel] [PATCH v3 2/5] drivers/hv: Move VMBus hypercall codes into Hyper-V UAPI header

2016-02-11 Thread Andrey Smetanin
VMBus hypercall codes inside Hyper-V UAPI header will be used by QEMU to implement VMBus host devices support. Signed-off-by: Andrey Smetanin Acked-by: K. Y. Srinivasan Reviewed-by: Roman Kagan CC: Gleb Natapov

Re: [Qemu-devel] [PATCH v6 2/4] trace: Remove unnecessary intermediate event copies

2016-02-11 Thread Lluís Vilanova
Lluís Vilanova writes: > The current code forces the use of a chain of ".original" dereferences, > which looks odd. > Signed-off-by: Lluís Vilanova > --- > scripts/tracetool/__init__.py|4 +--- > scripts/tracetool/format/events_h.py |4 ++-- >

Re: [Qemu-devel] [RFC v7 03/16] softmmu: Simplify helper_*_st_name, wrap MMIO code

2016-02-11 Thread Alex Bennée
Alvise Rigo writes: > Attempting to simplify the helper_*_st_name, wrap the MMIO code into an > inline function. > > Based on this work, Alex proposed the following patch series > https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01136.html > that reduces

Re: [Qemu-devel] [RFC v7 06/16] qom: cpu: Add CPUClass hooks for exclusive range

2016-02-11 Thread Alex Bennée
Alvise Rigo writes: > The excl_protected_range is a hwaddr range set by the VCPU at the > execution of a LoadLink instruction. If a normal access writes to this > range, the corresponding StoreCond will fail. > > Each architecture can set the exclusive range when

[Qemu-devel] [PATCH v3 4/5] kvm/x86: Reject Hyper-V hypercall continuation

2016-02-11 Thread Andrey Smetanin
Currently we do not support Hyper-V hypercall continuation so reject it. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini CC: Joerg Roedel CC: "K.

[Qemu-devel] [PATCH v3 0/5] KVM: Hyper-V VMBus hypercalls

2016-02-11 Thread Andrey Smetanin
The patch implements userspace exit 'KVM_EXIT_HYPERV' for Hyper-V VMBus hypercalls(postmsg, signalevent) to handle these hypercalls by QEMU. Changes v3: * use vcpu->arch.complete_userspace_io to setup hypercall result * rebase for 'next-20160211' Changes v2: * use KVM_EXIT_HYPERV for hyperca

Re: [Qemu-devel] [RFC v7 05/16] softmmu: Add new TLB_EXCL flag

2016-02-11 Thread Alex Bennée
Alvise Rigo writes: > Add a new TLB flag to force all the accesses made to a page to follow > the slow-path. > > The TLB entries referring guest pages with the DIRTY_MEMORY_EXCLUSIVE > bit clean will have this flag set. > > Suggested-by: Jani Kokkonen

[Qemu-devel] [PATCH v3 1/5] kvm/x86: Rename Hyper-V long spin wait hypercall

2016-02-11 Thread Andrey Smetanin
Rename HV_X64_HV_NOTIFY_LONG_SPIN_WAIT by HV_X64_HCALL_NOTIFY_LONG_SPIN_WAIT. So the name better reflects hypercall codes accessory. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini

[Qemu-devel] [PATCH v3 5/5] kvm/x86: Hyper-V VMBus hypercall userspace exit

2016-02-11 Thread Andrey Smetanin
The patch implements KVM_EXIT_HYPERV userspace exit functionality for Hyper-V VMBus hypercalls: HV_X64_HCALL_POST_MESSAGE, HV_X64_HCALL_SIGNAL_EVENT. Changes v3: * use vcpu->arch.complete_userspace_io to setup hypercall result Changes v2: * use KVM_EXIT_HYPERV for hypercalls Signed-off-by:

[Qemu-devel] [PATCH v3 3/5] kvm/x86: Pass return code of kvm_emulate_hypercall

2016-02-11 Thread Andrey Smetanin
Pass the return code from kvm_emulate_hypercall on to the caller, in order to allow it to indicate to the userspace that the hypercall has to be handled there. Also adjust all the existing code paths to return 1 to make sure the hypercall isn't passed to the userspace without setting kvm_run

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-11 Thread Eduardo Habkost
On Sat, Feb 06, 2016 at 08:34:07PM +0200, Michael S. Tsirkin wrote: > On Fri, Feb 05, 2016 at 12:46:11PM -0200, Eduardo Habkost wrote: > > On Fri, Feb 05, 2016 at 12:14:16AM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 04, 2016 at 05:09:44PM -0200, Eduardo Habkost wrote: > > > > On Thu, Feb

[Qemu-devel] [PATCH 5/5] target-tricore: add opd trap generation

2016-02-11 Thread Bastian Koppelmann
If an instruction uses a 64 bit register which consists of an even-odd pair of 32 bit registers and if the register specifier in the instruction is odd an opd trap is raised. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 285

[Qemu-devel] [PATCH 2/5] target-tricore: Save the pc before CSA operations for exceptions

2016-02-11 Thread Bastian Koppelmann
Exceptions that can occur during CSA operations need the PC as the return address of the exception. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target-tricore/translate.c

[Qemu-devel] [PATCH 4/5] target-tricore: add illegal opcode trap generation

2016-02-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 175 - 1 file changed, 156 insertions(+), 19 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 775d4c6..83e0927

[Qemu-devel] [PATCH v2 5/6] target-arm: Implement MDCR_EL3.TDA and MDCR_EL2.TDA traps

2016-02-11 Thread Peter Maydell
Implement the debug register traps controlled by MDCR_EL2.TDA and MDCR_EL3.TDA. Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov --- target-arm/helper.c | 39 ++- 1 file changed, 30 insertions(+), 9

Re: [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi}

2016-02-11 Thread Sascha Silbe
Dear Conny, Cornelia Huck writes: > On Thu, 11 Feb 2016 10:01:35 +0100 > Markus Armbruster wrote: > >> Sascha Silbe writes: > >> > This leaves out >> > virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because

[Qemu-devel] [PATCH v2 1/6] target-arm: correct CNTFRQ access rights

2016-02-11 Thread Peter Maydell
Correct some corner cases we were getting wrong for CNTFRQ access rights: * should UNDEF from 32-bit Secure EL1 * only writable from the highest implemented exception level, which might not be EL1 now To clarify the code, provide a new utility function arm_highest_el() which returns the

[Qemu-devel] broken HMP command: info mtree

2016-02-11 Thread Igor Mammedov
executing 'info mtree' from monitor prompt causes infinite loop printing it over and over. to reproduce build current master adn run: qemu-system-x86_64 -monitor stdio and then execute 'info mtree' in monitor prompt

[Qemu-devel] [PATCH 3/5] target-tricore: add context managment trap generation

2016-02-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c index fbe2be0..d7aafd1 100644 ---

Re: [Qemu-devel] [PATCH 6/9] pc: acpi: create MADT.lapic entries only for valid lapics

2016-02-11 Thread Eduardo Habkost
On Fri, Feb 05, 2016 at 05:14:41PM +0100, Igor Mammedov wrote: > On Fri, 5 Feb 2016 13:28:31 -0200 > Eduardo Habkost wrote: > > > On Thu, Feb 04, 2016 at 12:47:32PM +0100, Igor Mammedov wrote: > > > do not assume that all lapics in range 0..apic_id_limit > > > are valid and

[Qemu-devel] cache.direct

2016-02-11 Thread Jignasha Vithalani
How to set cache.direct = on if using aio=native with qemu 2.3 while mounting with nbd

Re: [Qemu-devel] [PATCH 7/9] pc: acpi: drop not needed intermediate bitmap cpu->found_cpus

2016-02-11 Thread Eduardo Habkost
On Fri, Feb 05, 2016 at 05:44:49PM +0100, Igor Mammedov wrote: > On Fri, 5 Feb 2016 17:19:50 +0100 > Igor Mammedov wrote: > > > On Fri, 5 Feb 2016 13:39:07 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Feb 04, 2016 at 12:47:33PM +0100, Igor

Re: [Qemu-devel] [PATCH v2 1/6] target-arm: correct CNTFRQ access rights

2016-02-11 Thread Sergey Fedorov
On 11.02.2016 19:03, Peter Maydell wrote: > Correct some corner cases we were getting wrong for > CNTFRQ access rights: > * should UNDEF from 32-bit Secure EL1 > * only writable from the highest implemented exception level, >which might not be EL1 now > > To clarify the code, provide a new

Re: [Qemu-devel] [PATCH v7 3/5] acpi: pc: add fw_cfg device node to ssdt

2016-02-11 Thread Gabriel L. Somlo
On Thu, Feb 11, 2016 at 04:19:59PM +0100, Igor Mammedov wrote: > On Wed, 10 Feb 2016 15:41:38 -0500 > "Gabriel L. Somlo" wrote: > > > Add a fw_cfg device node to the ACPI SSDT. While the guest-side > > firmware can't utilize this information (since it has to access > > the

  1   2   >