Re: [Qemu-devel] [PATCH V3 2/3] net/filter-mirror:Add filter-redirector func

2016-03-06 Thread Jason Wang
On 03/04/2016 08:01 PM, Zhang Chen wrote: > Filter-redirector is a netfilter plugin. > It gives qemu the ability to redirect net packet. > redirector can redirect filter's net packet to outdev. > and redirect indev's packet to filter. > > filter > +

Re: [Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-06 Thread Alex Bennée
Nikos Filippakis writes: > Thank you for your comments! > > On Sun, Mar 6, 2016 at 9:47 AM, Alex Bennée wrote: >> >> >> Nikos Filippakis writes: >> >> > Hello everyone! I am interested in getting to know the codebase a little >> >

Re: [Qemu-devel] [PATCH v3 3/3] arm: implement query-gic-capability

2016-03-06 Thread Andrew Jones
On Mon, Mar 07, 2016 at 01:38:24PM +0800, Peter Xu wrote: > On Mon, Mar 07, 2016 at 06:12:38AM +0100, Andrew Jones wrote: > > On Mon, Mar 07, 2016 at 12:23:28PM +0800, Peter Xu wrote: > > > +#ifdef CONFIG_KVM > > > +/* > > > + * This is merely the same as kvm_create_device(). The only > > > + *

Re: [Qemu-devel] [PATCH v9 4/7] s390x/cpu: Tolerate max_cpus

2016-03-06 Thread David Hildenbrand
> Once hotplug is enabled, interrupts may come in for CPUs > with an address > smp_cpus. Allocate for this and allow > search routines to look beyond smp_cpus. > > Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand > --- >

Re: [Qemu-devel] [PATCH V3 1/3] net/filter-mirror: Change filter_mirror_send interface

2016-03-06 Thread Jason Wang
On 03/04/2016 08:01 PM, Zhang Chen wrote: > Change filter_mirror_send interface to make it easier > to used by other filter > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > net/filter-mirror.c | 10 +- > 1 file

Re: [Qemu-devel] [RFC PATCH v2 3/3] VFIO: Type1 IOMMU mapping support for vGPU

2016-03-06 Thread Jike Song
Hi Neo, On Fri, Mar 4, 2016 at 3:00 PM, Neo Jia wrote: > On Wed, Mar 02, 2016 at 04:38:34PM +0800, Jike Song wrote: >> On 02/24/2016 12:24 AM, Kirti Wankhede wrote: >> > + vgpu_dma->size = map->size; >> > + >> > + vgpu_link_dma(vgpu_iommu, vgpu_dma); >> >> Hi Kirti & Neo, >>

[Qemu-devel] broken socket events on win32 qemu

2016-03-06 Thread Andrew Baumann
Hi Daniel, This commit ("char: convert from GIOChannel to QIOChannel"): https://github.com/qemu/qemu/commit/9894dc0cdcc397ee5b26370bc53da6d360a363c2 ... appears to have broken socket events for character devices on Win32. For example, I can no longer connect to a GDB stub (started with: "-gdb

Re: [Qemu-devel] [Xen-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-03-06 Thread Juergen Gross
Hi Wei, On 15/02/16 14:44, Wei Liu wrote: > On Mon, Feb 15, 2016 at 02:33:05PM +0100, Juergen Gross wrote: >> On 15/02/16 14:16, Wei Liu wrote: >>> On Mon, Feb 15, 2016 at 09:07:13AM +, Paul Durrant wrote: > >>> [...] > # Option 2: Invent a xen-9p device > > Another way of

Re: [Qemu-devel] [PATCH v3 0/5] Deterministic replay extensions

2016-03-06 Thread dovgaluk
Ping? Pavel Dovgalyuk Pavel Dovgalyuk писал 2016-03-01 14:07: This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and

[Qemu-devel] [PATCH 8/9] hw/arm: QOM'ify strongarm.c

2016-03-06 Thread xiaoqiang zhao
Drop the use of old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/arm/strongarm.c | 66 +++--- 1 file changed, 28 insertions(+), 38 deletions(-) diff --git a/hw/arm/strongarm.c

[Qemu-devel] [PATCH 7/9] hw/arm: QOM'ify stellaris.c

2016-03-06 Thread xiaoqiang zhao
* Drop the use of old SysBus init function and use instance_init * Use DeviceClass::vmsd instead of 'vmstate_register' function Signed-off-by: xiaoqiang zhao --- hw/arm/stellaris.c | 48 1 file changed, 24 insertions(+), 24

[Qemu-devel] [PATCH 3/9] hw/arm: QOM'ify integratorcp.c

2016-03-06 Thread xiaoqiang zhao
* Drop the use of old SysBus init function and use instance_init * Remove the empty 'icp_pic_class_init' from Typeinfo Signed-off-by: xiaoqiang zhao --- hw/arm/integratorcp.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git

[Qemu-devel] [PATCH 4/9] hw/arm: QOM'ify pxa2xx.c

2016-03-06 Thread xiaoqiang zhao
Drop the use of old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/arm/pxa2xx.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index ff6ac7a..8bdffca 100644

[Qemu-devel] [PATCH 5/9] hw/arm: QOM'ify pxa2xx_pic.c

2016-03-06 Thread xiaoqiang zhao
Remove the empty 'pxa2xx_pic_initfn' and it's setup code in the 'pxa2xx_pic_class_init' Signed-off-by: xiaoqiang zhao --- hw/arm/pxa2xx_pic.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/arm/pxa2xx_pic.c b/hw/arm/pxa2xx_pic.c index 8a39b1c..9e08c55 100644 ---

[Qemu-devel] [PATCH 9/9] hw/arm: QOM'ify versatilepb.c

2016-03-06 Thread xiaoqiang zhao
Drop the use of old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/arm/versatilepb.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c index d061f0f..a2411e3 100644

[Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-03-06 Thread xiaoqiang zhao
This patch set trying to QOM'ify code under hw/arm directory. As previous patches to hw/timer/*, we use instance_init instead of the SysBus's init function. xiaoqiang zhao (9): hw/arm: QOM'ify armv7m.c hw/arm: QOM'ify highbank.c hw/arm: QOM'ify integratorcp.c hw/arm: QOM'ify pxa2xx.c

[Qemu-devel] [PATCH 2/9] hw/arm: QOM'ify highbank.c

2016-03-06 Thread xiaoqiang zhao
Drop the use of old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/arm/highbank.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index e25cf5e..8f38dff 100644 ---

[Qemu-devel] [PATCH 1/9] hw/arm: QOM'ify armv7m.c

2016-03-06 Thread xiaoqiang zhao
Drop the use of old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/arm/armv7m.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index ed7d97f..139247e 100644 ---

Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > From: Yann Bordenave > > This patch adds parameters to manage some new options in the qemu -net > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults

Re: [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > From: Guillaume Subiron > > No code change. > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel Thibault > Reviewed-by: Thomas Huth > --- >

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > From: Guillaume Subiron > > This adds the sin6 case in the fhost and lhost unions and related macros. > It adds udp6_input() and udp6_output(). > It adds the IPv6 case in sorecvfrom(). > Finally, udp_input() is called by

Re: [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > From: Yann Bordenave > > Disambiguation : icmp_error is renamed into icmp_send_error, since it > doesn't manage errors, but only sends ICMP Error messages. > > Adding icmp6_send_error to send ICMPv6 Error messages. This

Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch adds the functions needed to handle IPv6 packets. ICMPv6 and > NDP headers are implemented. > > Slirp is now able to send NDP Router or Neighbor Advertisement when it > receives Router

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-06 Thread Li, Liang Z
> > No. And it's exactly what I mean. The ballooned memory is still > > processed during live migration without skipping. The live migration code is > in migration/ram.c. > > So if guest acknowledged VIRTIO_BALLOON_F_MUST_TELL_HOST, we can > teach qemu to skip these pages. > Want to write a patch

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > Hello, > > This is another respin of IPv6 in Qemu -net user mode. > > > These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add > TFTP over IPv6. > Thanks a lot for the patches. Looks good overall, but see some issues: -

Re: [Qemu-devel] [RFC PATCH v1 08/10] spapr: CPU hotplug support

2016-03-06 Thread Bharata B Rao
On Mon, Mar 07, 2016 at 02:49:06PM +1100, David Gibson wrote: > On Fri, Mar 04, 2016 at 12:24:19PM +0530, Bharata B Rao wrote: > > Set up device tree entries for the hotplugged CPU core and use the > > exising EPOW event infrastructure to send CPU hotplug notification to > > the guest. > > > >

Re: [Qemu-devel] [PATCH v4 07/26] crypto: add support for the serpent cipher algorithm

2016-03-06 Thread Fam Zheng
On Mon, 02/29 12:00, Daniel P. Berrange wrote: > New cipher algorithms 'serpent-128', 'serpent-192' and > 'serpent-256' are defined for the Serpent algorithm. > > The nettle and gcrypt cipher backends are updated to > support the new cipher and a test vector added to the > cipher test suite. The

Re: [Qemu-devel] [PATCH v4 06/26] crypto: add support for the cast5-128 cipher algorithm

2016-03-06 Thread Fam Zheng
On Mon, 02/29 12:00, Daniel P. Berrange wrote: > A new cipher algorithm 'cast-5-128' is defined for the > Cast-5 algorithm with 128 bit key size. Smaller key sizes > are supported by Cast-5, but nothing in QEMU should use > them, so only 128 bit keys are permitted. > > The nettle and gcrypt

Re: [Qemu-devel] [PATCH v4 05/26] crypto: skip testing of unsupported cipher algorithms

2016-03-06 Thread Fam Zheng
On Mon, 02/29 12:00, Daniel P. Berrange wrote: > We don't guarantee that all crypto backends will support > all cipher algorithms, so we should skip tests unless > the crypto backend indicates support. > > Signed-off-by: Daniel P. Berrange > --- > tests/test-crypto-cipher.c

Re: [Qemu-devel] [PATCH v4 04/26] crypto: add support for anti-forensic split algorithm

2016-03-06 Thread Fam Zheng
On Mon, 02/29 12:00, Daniel P. Berrange wrote: > The LUKS format specifies an anti-forensic split algorithm which > is used to artificially expand the size of the key material on > disk. This is an implementation of that algorithm. > > Signed-off-by: Daniel P. Berrange > ---

Re: [Qemu-devel] [PATCH v4 03/26] crypto: add support for generating initialization vectors

2016-03-06 Thread Fam Zheng
On Mon, 02/29 12:00, Daniel P. Berrange wrote: > There are a number of different algorithms that can be used > to generate initialization vectors for disk encryption. This > introduces a simple internal QCryptoBlockIV object to provide > a consistent internal API to the different algorithms. The >

Re: [Qemu-devel] [PATCH v3 3/3] arm: implement query-gic-capability

2016-03-06 Thread Peter Xu
On Mon, Mar 07, 2016 at 06:12:38AM +0100, Andrew Jones wrote: > On Mon, Mar 07, 2016 at 12:23:28PM +0800, Peter Xu wrote: > > +#ifdef CONFIG_KVM > > +/* > > + * This is merely the same as kvm_create_device(). The only > > + * difference is we are using raw fds rather than KVMState, so that > > + *

Re: [Qemu-devel] [PATCH v2][Outreachy Round 12]

2016-03-06 Thread Sarah Khan
Thank you for your feedback. Will do the required. Sorry for the delay as I was out of station. Thanks, Sarah On Sat, Mar 5, 2016 at 4:12 PM, Markus Armbruster wrote: > Your commit message isn't quite right, yet. The first line is empty, > which leads to > > Subject:

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-06 Thread Li, Liang Z
> > On 04/03/2016 15:26, Li, Liang Z wrote: > > >> > > > >> > The memory usage will keep increasing due to ever growing caches, > > >> > etc, so you'll be left with very little free memory fairly soon. > > >> > > > > I don't think so. > > > > > > > Roman is right. For example, here I am looking

Re: [Qemu-devel] [PATCH v4 02/26] crypto: add support for PBKDF2 algorithm

2016-03-06 Thread Fam Zheng
On Mon, 02/29 12:00, Daniel P. Berrange wrote: > The LUKS data format includes use of PBKDF2 (Password-Based > Key Derivation Function). The Nettle library can provide > an implementation of this, but we don't want code directly > depending on a specific crypto library backend. Introduce > a new

Re: [Qemu-devel] [PATCH v3 3/3] arm: implement query-gic-capability

2016-03-06 Thread Andrew Jones
On Mon, Mar 07, 2016 at 12:23:28PM +0800, Peter Xu wrote: > For emulated GIC capabilities, currently only gicv2 is supported. We > need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM > VM, we detect the capability bits using ioctls. > > When probing the KVM capabilities, we

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-06 Thread Jason Wang
On 03/07/2016 12:59 AM, Samuel Thibault wrote: > Hello, > > Jan Kiszka, on Fri 04 Mar 2016 16:50:32 +0100, wrote: >> On 2016-03-04 09:41, Thomas Huth wrote: >>> On 22.02.2016 20:28, Samuel Thibault wrote: Hello, This is another respin of IPv6 in Qemu -net user mode.

Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability

2016-03-06 Thread Peter Xu
On Fri, Mar 04, 2016 at 09:43:24AM +0100, Andrea Bolognani wrote: > On Fri, 2016-03-04 at 10:52 +0800, Peter Xu wrote: > > Andrea, do you know how much effort we need to add this support for > > libvirt, say, we can specify "accel=" or "-enable-kvm" as extra > > parameter when probing? > > I'm

[Qemu-devel] [PATCH v3 3/3] arm: implement query-gic-capability

2016-03-06 Thread Peter Xu
For emulated GIC capabilities, currently only gicv2 is supported. We need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the capability bits using ioctls. When probing the KVM capabilities, we cannot leverage existing helper functions like kvm_create_device()

[Qemu-devel] [PATCH v3 1/3] arm: qmp: add GICCapability struct

2016-03-06 Thread Peter Xu
Define new struct to describe whether we support specific GIC version. Signed-off-by: Peter Xu --- qapi-schema.json | 22 ++ 1 file changed, 22 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 7b8f2a1..0b2de6c 100644 ---

[Qemu-devel] [PATCH v3 2/3] arm: qmp: add query-gic-capability interface

2016-03-06 Thread Peter Xu
This patch adds the command "query-gic-capability" but not implemnet it. The command is ARM-only. Return of the command is a list of GICCapability struct that describes all GIC versions that current QEMU and system support. Signed-off-by: Peter Xu --- monitor.c|

[Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP command

2016-03-06 Thread Peter Xu
v3 changes: - patch 2: remove func declaration, add qmp header [Drew] - patch 3: being able to detect KVM GIC capabilities even without kvm enabled [Andrea]: this is a little bit hacky, need some more review on this. v2 changes: - result layout change: use array and dict for the capability

Re: [Qemu-devel] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-06 Thread Changlong Xie
On 03/06/2016 01:27 AM, Max Reitz wrote: Sorry that I wasn't so pedantic last time; or maybe I should rather be sorry that I'm so pedantic this time. Hi Max Welcome all your comments : ) On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang In some

Re: [Qemu-devel] [RFC PATCH v1 07/10] spapr: Represent boot CPUs as spapr-cpu-core devices

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 12:24:18PM +0530, Bharata B Rao wrote: > Initialize boot CPUs as spapr-cpu-core devices and create links from > machine object to these core devices. These links can be considered > as CPU slots in which core devices will get hot-plugged. spapr-cpu-core > device's slot

Re: [Qemu-devel] [RFC PATCH v1 00/10] Core based CPU hotplug for PowerPC sPAPR

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 11:57:18AM +0100, Igor Mammedov wrote: > On Fri, 4 Mar 2016 12:24:11 +0530 > Bharata B Rao wrote: > > > Hi, > > > > This is the next version of "Core based CPU hotplug for PowerPC sPAPR" that > > was posted at > >

Re: [Qemu-devel] [RFC PATCH v1 05/10] cpu: Abstract CPU core type

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 07:07:20PM +0100, Igor Mammedov wrote: > On Fri, 4 Mar 2016 16:32:53 +0530 > Bharata B Rao wrote: > > > On Fri, Mar 04, 2016 at 11:38:45AM +0100, Igor Mammedov wrote: > > > On Fri, 4 Mar 2016 12:24:16 +0530 > > > Bharata B Rao

Re: [Qemu-devel] [RFC PATCH v1 08/10] spapr: CPU hotplug support

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 12:24:19PM +0530, Bharata B Rao wrote: > Set up device tree entries for the hotplugged CPU core and use the > exising EPOW event infrastructure to send CPU hotplug notification to > the guest. > > Signed-off-by: Bharata B Rao > --- >

Re: [Qemu-devel] [RFC PATCH v1 02/10] exec: Do vmstate unregistration from cpu_exec_exit()

2016-03-06 Thread Bharata B Rao
On Mon, Mar 07, 2016 at 01:51:43PM +1100, David Gibson wrote: > On Fri, Mar 04, 2016 at 12:24:13PM +0530, Bharata B Rao wrote: > > cpu_exec_init() does vmstate_register and register_savevm for the CPU > > device. > > These need to be undone from cpu_exec_exit(). These changes are needed to > >

[Qemu-devel] [PATCH v2 11/11] vfio: add 'aer' property to expose aercap

2016-03-06 Thread Cao jin
From: Chen Fan add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++

[Qemu-devel] [PATCH v2 02/11] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

2016-03-06 Thread Cao jin
From: Chen Fan squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31

[Qemu-devel] [PATCH v2 09/11] vfio: vote a device to do host bus reset

2016-03-06 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/vfio/pci.c | 57 + hw/vfio/pci.h | 1 + 2 files changed, 58 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index

[Qemu-devel] [PATCH v2 08/11] pci: introduce pci bus pre reset

2016-03-06 Thread Cao jin
From: Chen Fan in order to distinguish a hot reset with a normal reset. we add this pre reset call back to notice that we should do a hot reset for all devices. Signed-off-by: Chen Fan --- hw/core/qdev.c | 4 ++--

[Qemu-devel] [PATCH v2 03/11] vfio: add pcie extended capability support

2016-03-06 Thread Cao jin
From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. due to add a new pcie capability at the tail of the chain, in order to avoid config space overwritten, we introduce a copy config for parsing extended caps. and rebuild the

[Qemu-devel] [PATCH v2 06/11] pci: add a is_valid_func callback to check device if complete

2016-03-06 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/pci/pci.c | 39 +++ include/hw/pci/pci.h | 1 + 2 files changed, 40 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index

[Qemu-devel] [PATCH v2 01/11] vfio: extract vfio_get_hot_reset_info as a single function

2016-03-06 Thread Cao jin
From: Chen Fan the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1

[Qemu-devel] [PATCH v2 07/11] vfio: add check aer functionality for hotplug device

2016-03-06 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/vfio/pci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 0898e34..24848c9 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@

[Qemu-devel] [PATCH v2 05/11] vfio: add check host bus reset is support or not

2016-03-06 Thread Cao jin
From: Chen Fan when boot up a VM that assigning vfio devices with aer enabled, we must check the vfio device whether support host bus reset. because when one error occur. OS driver always recover the device by do a bus reset, in order to recover the vfio device,

[Qemu-devel] [PATCH v2 10/11] vfio-pci: pass the aer error to guest

2016-03-06 Thread Cao jin
From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, resulting in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and let the

[Qemu-devel] [PATCH v2 04/11] vfio: add aer support for vfio device

2016-03-06 Thread Cao jin
From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 81

[Qemu-devel] [PATCH v2 Resend 00/11] vfio-pci: pass the aer error to guest, part2

2016-03-06 Thread Cao jin
From: Chen Fan v1-v2: 1. limit all devices on same bus in guest are on same bus in host in patch 5/11. 2. patch 05/11 ~ 09/11 has been changed. Chen Fan (11): vfio: extract vfio_get_hot_reset_info as a single function vfio: squeeze out

[Qemu-devel] [PULL 08/14] rocker: forbid to change world type

2016-03-06 Thread Jason Wang
From: Jiri Pirko Port to world assignment should be permitted only by qemu user. Driver should not be able to do it, so forbid that possibility. Signed-off-by: Jiri Pirko Signed-off-by: Jason Wang --- hw/net/rocker/rocker.c| 8

[Qemu-devel] [PULL 09/14] rocker: return -ENOMEM in case of some world alloc fails

2016-03-06 Thread Jason Wang
From: Jiri Pirko Until now, 0 is returned in this error case. Fix it ro return -ENOMEM. Signed-off-by: Jiri Pirko Signed-off-by: Jason Wang --- hw/net/rocker/rocker.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL 10/14] rocker: add name field into WorldOps ale let world specify its name

2016-03-06 Thread Jason Wang
From: Jiri Pirko Also use this in world_name getter function. Signed-off-by: Jiri Pirko Signed-off-by: Jason Wang --- hw/net/rocker/rocker_of_dpa.c | 1 + hw/net/rocker/rocker_world.c | 7 +-- hw/net/rocker/rocker_world.h | 1 +

[Qemu-devel] [PULL 06/14] tests/test-filter-mirror:add filter-mirror unit test

2016-03-06 Thread Jason Wang
From: Zhang Chen In this unit test we will test the mirror function. start qemu with: -netdev socket,id=qtest-bn0,fd=sockfd -device e1000,netdev=qtest-bn0,id=qtest-e0 -chardev socket,id=mirror0,path=/tmp/filter-mirror-test.sock,server,nowait

[Qemu-devel] [PULL 07/14] net: netmap: probe netmap interface for virtio-net header

2016-03-06 Thread Jason Wang
From: Vincenzo Maffione Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. did not really probe for virtio-net header support for the netmap interface attached to the backend. These callbacks were correct for VALE ports, but incorrect for hardware

[Qemu-devel] [PULL 05/14] net/filter-mirror:Add filter-mirror

2016-03-06 Thread Jason Wang
From: Zhang Chen Filter-mirror is a netfilter plugin. It gives qemu the ability to mirror packets to a chardev. usage: -netdev tap,id=hn0 -chardev socket,id=mirror0,host=ip_primary,port=X,server,nowait

[Qemu-devel] [PULL 13/14] filter-buffer: Add status_changed callback processing

2016-03-06 Thread Jason Wang
From: zhanghailiang While the status of filter-buffer changing from 'on' to 'off', it need to release all the buffered packets, and delete the related timer, while switch from 'off' to 'on', it need to resume the release packets timer. Here, we extract the

[Qemu-devel] [PULL 14/14] net: check packet payload length

2016-03-06 Thread Jason Wang
From: Prasad J Pandit While computing IP checksum, 'net_checksum_calculate' reads payload length from the packet. It could exceed the given 'data' buffer size. Add a check to avoid it. Reported-by: Liu Ling Signed-off-by: Prasad J Pandit

[Qemu-devel] [PULL 02/14] net: filter: correctly remove filter from the list during finalization

2016-03-06 Thread Jason Wang
Qemu may crash when we want to add two filters on the same netdev but the initialization of second fails (e.g missing parameters): ./qemu-system-x86_64 -netdev user,id=un0 \ -object filter-buffer,id=f0,netdev=un0,interval=10 \ -object filter-buffer,id=f1,netdev=un0 Segmentation fault (core

[Qemu-devel] [PULL 11/14] rocker: allow user to specify rocker world by property

2016-03-06 Thread Jason Wang
From: Jiri Pirko Add property to specify rocker world. All ports will be assigned to this world. Signed-off-by: Jiri Pirko Signed-off-by: Jason Wang --- hw/net/rocker/rocker.c | 29 - 1 file changed, 28

[Qemu-devel] [PULL 12/14] filter: Add 'status' property for filter object

2016-03-06 Thread Jason Wang
From: zhanghailiang With this property, users can control if this filter is 'on' or 'off'. The default behavior for filter is 'on'. For some types of filters, they may need to react to status changing, So here, we introduced status changing callback/notifier for

[Qemu-devel] [PULL 01/14] net: ne2000: check ring buffer control registers

2016-03-06 Thread Jason Wang
From: Prasad J Pandit Ne2000 NIC uses ring buffer of NE2000_MEM_SIZE(49152) bytes to process network packets. Registers PSTART & PSTOP define ring buffer size & location. Setting these registers to invalid values could lead to infinite loop or OOB r/w access issues. Add

[Qemu-devel] [PULL 04/14] net: simplify net_init_tap_one logic

2016-03-06 Thread Jason Wang
From: Paolo Bonzini net_init_tap_one receives in vhostfdname a fd name from vhostfd= or vhostfds=, or NULL if there is no vhostfd=/vhostfds=. It is simpler to just check vhostfdname, than it is to check for vhostfd= or vhostfds=. This also calms down Coverity, which

[Qemu-devel] [PULL 00/14] Net patches

2016-03-06 Thread Jason Wang
The following changes since commit 1464ad45cd6cdeb0b5c1a54d3d3791396e47e52f: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-04' into staging (2016-03-06 11:53:27 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

[Qemu-devel] [PULL 03/14] MAINTAINERS: Add entries for include/net/ files

2016-03-06 Thread Jason Wang
From: Thomas Huth The include/net/ files correspond to the files in the net/ directory, thus there should be corresponding entries in the MAINTAINERS file. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- MAINTAINERS | 2 ++ 1

Re: [Qemu-devel] [RFC PATCH v1 02/10] exec: Do vmstate unregistration from cpu_exec_exit()

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 12:24:13PM +0530, Bharata B Rao wrote: > cpu_exec_init() does vmstate_register and register_savevm for the CPU device. > These need to be undone from cpu_exec_exit(). These changes are needed to > support CPU hot removal. > > Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [RFC PATCH v1 01/10] exec: Remove cpu from cpus list during cpu_exec_exit()

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 12:24:12PM +0530, Bharata B Rao wrote: > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > should be removed from cpu_exec_exit(). > > cpu_exec_init() is called from generic CPU::instance_finalize and some > archs like PowerPC call it from CPU

Re: [Qemu-devel] [PATCH 1/2] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-06 Thread David Gibson
On Fri, Mar 04, 2016 at 10:59:17AM +0100, Thomas Huth wrote: > On 04.03.2016 06:35, David Gibson wrote: > > When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) > > pointer updated by a write to the SDR1 register we need to update some > > derived variables. Likewise, when the cpu

[Qemu-devel] [PATCHv2 1/3] target-ppc: Split out SREGS get/put functions

2016-03-06 Thread David Gibson
Currently the getting and setting of Power MMU registers (sregs) take up large inline chunks of the kvm_arch_get_registers() and kvm_arch_put_registers() functions. Especially since there are two variants (for Book-E and Book-S CPUs), only one of which will be used in practice, this is pretty

[Qemu-devel] [PATCHv2 3/3] target-ppc: Eliminate kvmppc_kern_htab global

2016-03-06 Thread David Gibson
fa48b43 "target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM" purports to remove a hack in the handling of hash page tables (HPTs) managed by KVM instead of qemu. However, it actually went in the wrong direction. That patch requires anything looking for an external HPT (that is one

[Qemu-devel] [PATCHv2 2/3] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-06 Thread David Gibson
When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) pointer updated by a write to the SDR1 register we need to update some derived variables. Likewise, when the cpu is configured for an external HPT (one not in the guest memory space) some derived variables need to be updated.

[Qemu-devel] [PATCHv2 0/3] target-ppc: Clean up handling of SDR1 and external HPTs

2016-03-06 Thread David Gibson
These patches cleans up handling of SDR1 (master page table pointer register for Power) and related cases with an external (i.e. managed by qemu or KVM, rather than the guest) hash page table (HPT). I wouldn't push 1/3 or 2/3 on their own after the soft freeze, except that they simplify 3/3,

Re: [Qemu-devel] [Qemu-arm] [PATCH] Fix bug: SRS instructions would trap to EL3 in Secure EL1 even if specified mode was not monitor mode.

2016-03-06 Thread Peter Maydell
On 7 March 2016 at 02:04, Sergey Fedorov wrote: > On 23.02.2016 01:25, Ralf-Philipp Weinmann wrote: >> >> According to the ARMv8 Architecture reference manual [F6.1.203], ALL >> of the following conditions need to be met for SRS to trap to EL3: >> * It is executed at Secure

Re: [Qemu-devel] [PATCH v3 1/4] adb-keys.h: initial commit

2016-03-06 Thread Programmingkid
On Mar 5, 2016, at 7:02 PM, Eric Blake wrote: > On 03/04/2016 10:15 PM, Programmingkid wrote: >> > >> + * >> + * Permission is hereby granted, free of charge, to any person obtaining a >> copy >> + * of this software and associated documentation files (the "Software"), to >> deal >> + * in

[Qemu-devel] Google Summer of Code 2016: Make Mac OS 9 boot successfully with all Apple extensions

2016-03-06 Thread Programmingkid
=== TITLE === Make all versions of Mac OS 9 boot successfully in QEMU with all Apple extensions '''Summary:''' Short description of the project Mac OS 9.2 does boot in QEMU without extensions, but certain extensions that ship with Mac OS 9.2 need to be disabled or else they will cause

Re: [Qemu-devel] [Qemu-arm] [PATCH] Fix bug: SRS instructions would trap to EL3 in Secure EL1 even if specified mode was not monitor mode.

2016-03-06 Thread Sergey Fedorov
On 23.02.2016 01:25, Ralf-Philipp Weinmann wrote: According to the ARMv8 Architecture reference manual [F6.1.203], ALL of the following conditions need to be met for SRS to trap to EL3: * It is executed at Secure PL1. * The specified mode is monitor mode. * EL3 is using AArch64. The code

Re: [Qemu-devel] [Nbd] [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-03-06 Thread Denis V. Lunev
On 03/06/2016 01:28 PM, Wouter Verhelst wrote: Hi all, On Fri, Mar 04, 2016 at 03:03:26PM +0100, Paolo Bonzini wrote: NBD-wise, I think the TRIM command is good as it is, and NBD_CMD_WRITE_ZEROES should be added like Den is doing. It also makes sense to use trimming to implement

[Qemu-devel] [PATCH v2] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-06 Thread Nikos Filippakis
Allocate large array in nc_sendv_compat on the heap to reduce stack frame size, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- net/net.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/net/net.c

Re: [Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-06 Thread Nikos Filippakis
Thank you for your comments! On Sun, Mar 6, 2016 at 9:47 AM, Alex Bennée wrote: > > > Nikos Filippakis writes: > > > Hello everyone! I am interested in getting to know the codebase a little > > better > > so that I can eventually apply for a GSOC

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-06 Thread Samuel Thibault
Hello, Jan Kiszka, on Fri 04 Mar 2016 16:50:32 +0100, wrote: > On 2016-03-04 09:41, Thomas Huth wrote: > > On 22.02.2016 20:28, Samuel Thibault wrote: > >> Hello, > >> > >> This is another respin of IPv6 in Qemu -net user mode. > >> > >> These patches add ICMPv6, NDP, make UDP and TCP compatible

Re: [Qemu-devel] [PATCH] linux-user: Check array bounds in errno conversion

2016-03-06 Thread Laurent Vivier
Le 03/03/2016 19:35, Peter Maydell a écrit : > From: Timothy E Baldwin > > Check array bounds in host_to_target_errno() and target_to_host_errno(). > > Signed-off-by: Timothy Edward Baldwin > Message-id: >

Re: [Qemu-devel] [PULL v2 00/12] QAPI patches for 2016-03-04

2016-03-06 Thread Peter Maydell
On 5 March 2016 at 16:50, Markus Armbruster wrote: > v2: Missing S-o-b supplied > > The following changes since commit 3c0f12df65da872d5fbccae469f2cb21ed1c03b7: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160304' into staging (2016-03-04 >

[Qemu-devel] [PATCH] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-06 Thread Marcel Apfelbaum
Legacy Windows operating systems like Windows XP and Windows 2003 require _DIS method to be present for all interrupt links. PC machines already have a no-op implemented for GSI links, add it also in Q35. Signed-off-by: Marcel Apfelbaum --- Hi, I tested this patch with

[Qemu-devel] [PATCH v2] ui/console: add escape sequence \e[5,6n

2016-03-06 Thread Ren Kimura
Add support of escape sequence "\e[5n" and "\e[6n" to console. "\e[5n" reports status of console and it always succeed in virtual console. "\e[6n" reports now cursor position in console. Signed-off-by: Ren Kimura --- ui/console.c | 35 +-- 1

Re: [Qemu-devel] [Nbd] [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-03-06 Thread Wouter Verhelst
Hi all, On Fri, Mar 04, 2016 at 03:03:26PM +0100, Paolo Bonzini wrote: > NBD-wise, I think the TRIM command is good as it is, and > NBD_CMD_WRITE_ZEROES should be added like Den is doing. > > It also makes sense to use trimming to implement NBD_CMD_WRITE_ZEROES, > but it should be explicitly

Re: [Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

2016-03-06 Thread Ren Kimura
Oh OK. I'll send version2 of this patch that contains comment about these. 2016-03-06 18:49 GMT+09:00 Peter Maydell : > On 5 March 2016 at 23:50, Ren Kimura wrote: > > This patch add support of escape sequence "\e[5,6n". > > This implementation

Re: [Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

2016-03-06 Thread Peter Maydell
On 5 March 2016 at 23:50, Ren Kimura wrote: > This patch add support of escape sequence "\e[5,6n". > This implementation similar to that of linux tty driver. Could you describe what the escape sequences do, please? (both in the commit message and in a comment in the code).

Re: [Qemu-devel] [PATCH][Outreachy]

2016-03-06 Thread Alex Bennée
Sarah Khan writes: > util/envlist.c:This patch replaces malloc with g_malloc > > This replacement was suggested as part of the bite-sized tasks. > > Signed-off-by: Sarah Khan Thanks for your contribution. A few notes for the next revision. It's