Re: [Qemu-devel] [Qemu-ppc] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah...@gmail.com>

2016-03-12 Thread Programmingkid
I do like the idea of your patch. Every millisecond we save is a millisecond earned. Because of formatting issues I had to fix your patch. Here is it with all the formatting problems fixed. I did see one problem while patching: patching file hw/input/tsc2005.c Hunk #1 FAILED at 291. 1 out of 1

[Qemu-devel] [PULL 6/7] target-i386: Fix inhibit irq mask handling

2016-03-12 Thread Richard Henderson
The patch in 7f0b714 was too simplistic, in that we wound up setting the flag and then resetting it immediately in gen_eob. Fixes the reported boot problem with Windows XP. Reported-by: Hervé Poussineau Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL 5/7] target-i386: Use gen_nop_modrm for prefetch instructions

2016-03-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 0b67165..2631c77 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@

[Qemu-devel] [PULL 7/7] target-i386: Dump unknown opcodes with -d unimp

2016-03-12 Thread Richard Henderson
We discriminate here between opcodes that are illegal in the current cpu mode or with illegal arguments (such as modrm.mod == 3) and encodings that are unknown (such as an unimplemented isa extension). Signed-off-by: Richard Henderson --- target-i386/translate.c | 127

[Qemu-devel] [PULL 2/7] target-i386: Fix SMSW and LMSW from/to register

2016-03-12 Thread Richard Henderson
From: Paolo Bonzini SMSW and LMSW accept register operands, but commit 1906b2a ("target-i386: Rearrange processing of 0F 01", 2016-02-13) did not account for that. Fixes: 1906b2af7c2345037d9b2fdf484b457b5acd09d1 Reported-by: Hervé Poussineau

[Qemu-devel] [PULL 3/7] target-i386: Fix SMSW for 64-bit mode

2016-03-12 Thread Richard Henderson
In non-64-bit modes, the instruction always stores 16 bits. But in 64-bit mode, when the destination is a register, the instruction can write 32 or 64 bits. Signed-off-by: Richard Henderson --- target-i386/translate.c | 14 -- 1 file changed, 8 insertions(+), 6

[Qemu-devel] [PULL 4/7] target-i386: Fix addr16 prefix

2016-03-12 Thread Richard Henderson
From: Paolo Bonzini While ADDSEG will only be false in 16-bit mode for LEA, it can be false even in other cases when 16-bit addresses are obtained via the 67h prefix in 32-bit mode. In this case, gen_lea_v_seg forgets to add a nonzero FS or GS base if CS/DS/ES/SS are all

[Qemu-devel] [PULL 1/7] target-i386: Avoid repeated calls to the bnd_jmp helper

2016-03-12 Thread Richard Henderson
From: Paolo Bonzini Two flags were tested the wrong way. Signed-off-by: Paolo Bonzini Message-Id: <1456845145-18891-1-git-send-email-pbonz...@redhat.com> Signed-off-by: Richard Henderson [rth: Fixed enable test as well.] ---

[Qemu-devel] [PULL 0/7] target-i386 fixes

2016-03-12 Thread Richard Henderson
/pull-target-arm-20160304' into staging (2016-03-04 11:46:32 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-i386-20160312 for you to fetch changes up to 2354c42e1c365ceb2acf5e6163c004c7d17b6be4: target-i386: Dump unknown opcodes with -d unimp (2016

Re: [Qemu-devel] [V6 4/4] hw/pci-host: Emulate AMD IOMMU

2016-03-12 Thread David Kiarie
On Fri, Mar 11, 2016 at 4:22 PM, Michael S. Tsirkin wrote: > On Sun, Feb 21, 2016 at 09:11:00PM +0300, David Kiarie wrote: >> Add AMD IOMMU emulation support to q35 chipset >> >> Signed-off-by: David Kiarie >> --- >> hw/pci-host/piix.c| 1 +

Re: [Qemu-devel] [PATCH v4 1/7] target-tricore: Add FPU infrastructure

2016-03-12 Thread Richard Henderson
On 03/11/2016 07:03 AM, Bastian Koppelmann wrote: This patch adds a file for all the FPU related helpers with all the includes, useful defines, and a function to update the status bits. Additionally it adds a mask for the rounding mode bits of PSW as well as all the opcodes for the FPU

Re: [Qemu-devel] [PATCH] target-xtensa: use global registers for the register window

2016-03-12 Thread Richard Henderson
On 03/11/2016 07:22 PM, Max Filippov wrote: Signed-off-by: Max Filippov --- target-xtensa/cpu.c | 1 + target-xtensa/cpu.h | 5 +++-- target-xtensa/op_helper.c | 48 --- target-xtensa/translate.c | 7 +-- 4

Re: [Qemu-devel] [PATCH] Include setjmp.h in qemu/osdep.h (bug fix for w64)

2016-03-12 Thread Richard Henderson
On 03/11/2016 10:31 PM, Stefan Weil wrote: setjmp must be declared before sysemu/os-win32.h because it is redefined there for 64 bit Windows. Signed-off-by: Stefan Weil Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

2016-03-12 Thread Stefan Weil
Am 12.03.2016 um 18:53 schrieb Mriyam Tamuli: > Thanks a lot for the feedback. I will do as you suggested. I have two > more questions, though - > > 1. So after a patch is submitted, there will be a review in sometime by > someone? Is that how I will come to know if my changes are correct? Yes,

[Qemu-devel] [PATCH] Added NULL check for qemu_find_file()

2016-03-12 Thread rutu . shah . 26
From: Rutuja Shah This patch adds NULL check for return value from qemu_find_file(), where it is missing. It avoids unnecessary function calls with NULL parameter which in turn return -1. Especially, incase of load_uimage(), two functions are called which return -1 on

Re: [Qemu-devel] [PATCH] adb: change handler only when recognized

2016-03-12 Thread Hervé Poussineau
Le 12/03/2016 19:13, Programmingkid a écrit : On Mar 12, 2016, at 12:44 PM, Hervé Poussineau wrote: Le 12/03/2016 16:24, Mark Cave-Ayland a écrit : On 12/03/16 13:38, Hervé Poussineau wrote: ADB devices must take new handler into account only when they recognize it. This lets operating

Re: [Qemu-devel] [Bug 1556306] Re: vhost-user: qemu stops processing packets under high load of traffic

2016-03-12 Thread Michael S. Tsirkin
On Fri, Mar 11, 2016 at 10:51:33PM -, Vincent JARDIN wrote: > for tracking, > > http://git.qemu.org/?p=qemu.git;a=patch;h=5669655aafdb88a8797c74a989dd0c0ebb1349fa > > -- > You received this bug notification because you are a member of qemu- > devel-ml, which is subscribed to QEMU. >

[Qemu-devel] Regarding TB retranslation code.

2016-03-12 Thread Venkatesh N
This is regarding TB retranslation code. [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Richard Henderson <= Though i understood the code to avoid the retranslation, i could not get picture on how "host" or backend registers are ensured to have the older contents when the guest PC is

Re: [Qemu-devel] [PATCH] adb: change handler only when recognized

2016-03-12 Thread Programmingkid
On Mar 12, 2016, at 12:44 PM, Hervé Poussineau wrote: > Le 12/03/2016 16:24, Mark Cave-Ayland a écrit : >> On 12/03/16 13:38, Hervé Poussineau wrote: >> >>> ADB devices must take new handler into account only when they recognize it. >>> This lets operating systems probe for valid/invalid

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

2016-03-12 Thread Mriyam Tamuli
Thanks a lot for the feedback. I will do as you suggested. I have two more questions, though - 1. So after a patch is submitted, there will be a review in sometime by someone? Is that how I will come to know if my changes are correct? 2. If I split the patch into smaller parts and send to

Re: [Qemu-devel] [PATCH] adb: change handler only when recognized

2016-03-12 Thread Hervé Poussineau
Le 12/03/2016 16:24, Mark Cave-Ayland a écrit : On 12/03/16 13:38, Hervé Poussineau wrote: ADB devices must take new handler into account only when they recognize it. This lets operating systems probe for valid/invalid handles, to know device capabilities. Add a FIXME in keyboard handler,

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

2016-03-12 Thread Stefan Weil
Am 12.03.2016 um 12:51 schrieb Mriyam Tamuli: > Signed-off-by: Mriyam Tamuli > --- > block/iscsi.c | 2 +- > bsd-user/elfload.c | 12 ++-- > bsd-user/qemu.h| 2 +- > configure | 4 ++-- > disas/ia64.c | 2 +- > 5 files changed, 11

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

2016-03-12 Thread Mriyam Tamuli
Can anyone please comment on this? Am I doing anything wrong here? On Sat, Mar 12, 2016 at 5:22 PM Mriyam Tamuli wrote: > > Signed-off-by: Mriyam Tamuli > --- > block/iscsi.c | 2 +- > bsd-user/elfload.c | 12 ++-- > bsd-user/qemu.h| 2

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah...@gmail.com>

2016-03-12 Thread rutuja shah
Hi, Sorry for the inconvenience caused due to the format of my patch. Due to a typo mail id was wrong, adding blauwir...@gmail.com On Mar 11, 2016 1:00 AM, wrote: > From: Rutuja Shah > > --- > audio/audio.c | 2 +- > audio/noaudio.c

[Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-03-12 Thread Aviv B.D.
From: "Aviv B.D." * Fix bug that prevent qemu from starting up when vIOMMU and VFIO device are present. * Advertise Cache Mode capability in iommu cap register. * Register every VFIO device with IOMMU state. * On page cache invalidation in vIOMMU, check if the domain

Re: [Qemu-devel] [PATCH] adb: change handler only when recognized

2016-03-12 Thread Mark Cave-Ayland
On 12/03/16 13:38, Hervé Poussineau wrote: > ADB devices must take new handler into account only when they recognize it. > This lets operating systems probe for valid/invalid handles, to know device > capabilities. > > Add a FIXME in keyboard handler, which should use a different translation >

[Qemu-devel] [Bug 1556372] [NEW] Superfluous popup on Cocoa to verify quit, cannot be disabled.

2016-03-12 Thread Ng Zhia Yang
Public bug reported: This patch severely reduces the quality of life for developers using QEMU in a rapid Edit-Compile-Test cycle. Any method of quitting QEMU via the UI triggers this dialogue, whose default option is "cancel" -- necessitating the use of the mouse to click "Confirm". This

Re: [Qemu-devel] [PATCH] adb: change handler only when recognized

2016-03-12 Thread Programmingkid
On Mar 12, 2016, at 8:38 AM, Hervé Poussineau wrote: > ADB devices must take new handler into account only when they recognize it. > This lets operating systems probe for valid/invalid handles, to know device > capabilities. > > Add a FIXME in keyboard handler, which should use a different

[Qemu-devel] [PATCH] adb: change handler only when recognized

2016-03-12 Thread Hervé Poussineau
ADB devices must take new handler into account only when they recognize it. This lets operating systems probe for valid/invalid handles, to know device capabilities. Add a FIXME in keyboard handler, which should use a different translation table depending of the selected handler. Signed-off-by:

Re: [Qemu-devel] Tracking the VM making an IO request

2016-03-12 Thread Aarian P. Aleahmad
Thanks for helping me. what should I do in case of using KVM? On Wed, Feb 10, 2016 at 4:10 PM, Paolo Bonzini wrote: > > > On 10/02/2016 11:23, Stefan Hajnoczi wrote: > > On Wed, Feb 10, 2016 at 12:35:54PM +0330, Aarian P. Aleahmad > > wrote: > >> I'm a student, engaged in a

[Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

2016-03-12 Thread Mriyam Tamuli
Signed-off-by: Mriyam Tamuli --- block/iscsi.c | 2 +- bsd-user/elfload.c | 12 ++-- bsd-user/qemu.h| 2 +- configure | 4 ++-- disas/ia64.c | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/iscsi.c

[Qemu-devel] [Patch 1/1] omap_lcdc: Remove support for DEPTH != 32

2016-03-12 Thread Pooja Dhannawat
As only DEPTH ==32 case is used, removing other dead code which is based on DEPTH !== 32 Signed-off-by: Pooja Dhannawat --- hw/display/omap_lcd_template.h | 10 ++ hw/display/omap_lcdc.c | 21 - 2 files changed, 2 insertions(+), 29

[Qemu-devel] [Patch 1/1] net/net: Allocating Large sized arrays to heap

2016-03-12 Thread Pooja Dhannawat
Signed-off-by: Pooja Dhannawat --- net/net.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/net.c index b0c832e..5399758 100644 --- a/net/net.c +++ b/net/net.c @@ -709,16 +709,18 @@ ssize_t