Re: [Qemu-devel] [PATCH v2 03/16] block: introduce bdrv_no_throttling_begin/end

2016-03-18 Thread Fam Zheng
On Wed, 03/16 15:16, Paolo Bonzini wrote: > Extract the handling of throttling from bdrv_flush_io_queue. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-18 Thread Paolo Bonzini
On 16/03/2016 12:56, Cornelia Huck wrote: > On Wed, 16 Mar 2016 12:48:22 +0100 > Paolo Bonzini wrote: > >> >> >> On 16/03/2016 12:32, Cornelia Huck wrote: >>> On Wed, 16 Mar 2016 12:09:02 +0100 >>> Paolo Bonzini wrote: >>> On 16/03/2016 11:49,

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-18 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 05:10 PM, Alberto Garcia wrote: > > On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang > > wrote: > >> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { > >> bool rewrite_corrupted;/* true if the

[Qemu-devel] [PULL v1 06/13] crypto: add support for the cast5-128 cipher algorithm

2016-03-18 Thread Daniel P. Berrange
A new cipher algorithm 'cast-5-128' is defined for the Cast-5 algorithm with 128 bit key size. Smaller key sizes are supported by Cast-5, but nothing in QEMU should use them, so only 128 bit keys are permitted. The nettle and gcrypt cipher backends are updated to support the new cipher and a test

Re: [Qemu-devel] [PATCH 1/2] quorum: Emit QUORUM_REPORT_BAD for reads in fifo mode

2016-03-18 Thread Max Reitz
On 15.03.2016 10:41, Alberto Garcia wrote: > If there's an I/O error in one of Quorum children then QEMU > should emit QUORUM_REPORT_BAD. However this is not working with > read-pattern=fifo. This patch fixes this problem. > > Signed-off-by: Alberto Garcia > --- >

[Qemu-devel] [PATCH v4 03/17] block: Add blk_commit_all()

2016-03-18 Thread Max Reitz
Later, we will remove bdrv_commit_all() and move its contents here, and in order to replace bdrv_commit_all() calls by calls to blk_commit_all() before doing so, we need to add it as an alias now. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf ---

Re: [Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-18 Thread Thomas Huth
On 17.03.2016 07:23, David Gibson wrote: > On Wed, Mar 16, 2016 at 01:16:50PM +0100, Thomas Huth wrote: >> >> This patch introduces an alternate way of handling the receive >> buffers of the spapr-vlan device, resulting in much better >> receive performance for the guest. [...] >> Though it seems

[Qemu-devel] [PULL 34/40] qdev: New DEFINE_PROP_ON_OFF_AUTO

2016-03-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-35-git-send-email-arm...@redhat.com> --- hw/core/qdev-properties.c| 10 ++ include/hw/qdev-properties.h | 3 +++ 2 files changed, 13

[Qemu-devel] [PATCH for-2.6 06/14] pc-bios/s390-ccw: add vdev object to store all device details

2016-03-18 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add VDev "object" as a container for all device-related items. The default object is static. Leverage dependency on many different device-related globals. Make them syntactically visible. Signed-off-by: Eugene (jno) Dvurechenski

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-18 Thread Pooja Dhannawat
On Friday, March 18, 2016, Paolo Bonzini wrote: > > > On 18/03/2016 14:49, Pooja Dhannawat wrote: >> >> >> If it is greater than the accepted level, the on-stack >> buffer is not >> used and you allocate one that has the right size on the

Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation

2016-03-18 Thread Peter Maydell
On 17 March 2016 at 13:46, wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Sergey Fedorov > --- > translate-all.c | 9 +++-- > 1 file changed, 7 insertions(+), 2

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-18 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Mar 15, 2016 at 01:56:47PM +, Dr. David Alan Gilbert wrote: > > > This would put trace_foo() in generated-tracers-virtio-blk.h and > > > trace_bar() in generated-tracers-memory.h. Source files using tracing > > > would need to include

Re: [Qemu-devel] [Qemu-block] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

2016-03-18 Thread Changlong Xie
On 03/17/2016 02:48 AM, Jeff Cody wrote: On Fri, Mar 11, 2016 at 06:34:09PM +0800, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei

[Qemu-devel] [PATCH v2 05/10] ppc: Add dummy SPR_IC for POWER8

2016-03-18 Thread Cédric Le Goater
From: Benjamin Herrenschmidt It's supposed to be an instruction counter. For now make us not crash when accessing it. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Thomas Huth Reviewed-by: David Gibson

[Qemu-devel] [PULL 10/21] i.MX: Add i.MX6 CCM and ANALOG device.

2016-03-18 Thread Peter Maydell
From: Jean-Christophe Dubois Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Message-id: 9fa80b4d8c5d0f50c94e77d74f952a7a665e168f.1456868959.git@tribudubois.net Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v3 26/40] ivshmem: Propagate errors through ivshmem_recv_setup()

2016-03-18 Thread Marc-André Lureau
On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: > This kills off the funny state described in the previous commit. > > Simplify ivshmem_io_read() accordingly, and update documentation. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André

Re: [Qemu-devel] Hi good afternoon, some small support

2016-03-18 Thread Stefan Hajnoczi
On Fri, Mar 04, 2016 at 08:52:37PM +, Sanchez, Juan Carlos (GE Aviation) wrote: > I am trying to execute an image created by ARM in QEMU using windows > OS, could you give me guide to example the command line? > > The command line in Unix work well, but I don't understood all the

[Qemu-devel] [PATCH v5 15/28] migration: convert fd socket protocol to use QIOChannel

2016-03-18 Thread Daniel P. Berrange
Convert the fd socket migration protocol driver to use QIOChannel and QEMUFileChannel, instead of plain sockets APIs. It can be unconditionally built because the QIOChannel APIs it uses will take care to report suitable error messages if needed. Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/bcm2836: Wire up CPU timer interrupts correctly

2016-03-18 Thread Thomas Hanson
On Mar 17, 2016 4:33 AM, "Peter Maydell" wrote: > > Wire up the CPU timer interrupts in the right order, with the > nonsecure physical timer on cntpnsirq, the hyp timer on cnthpirq, > and the secure physical timer on cntpsirq. (We did get the > virt timer right, at

[Qemu-devel] [RESEND PATCH v2 4/4] hw/audio: QOM'ify milkymist-ac97.c

2016-03-18 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move AUD_open_in / AUD_open_out function into realize stage Signed-off-by: xiaoqiang zhao --- hw/audio/milkymist-ac97.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 08/10] ppc: Add POWER8 IAMR register

2016-03-18 Thread Cédric Le Goater
On 03/16/2016 06:46 PM, Thomas Huth wrote: > That should be now a "if (has_iamr)" instead of "if (!has_iamr)", > shouldn't it? yes I will send an update for this patch only. Sorry for the noise. C.

[Qemu-devel] [RFC v2 5/6] hw/arm: boot

2016-03-18 Thread Baptiste Reynal
From: Christian Pinto This patch modifies the boot process of an ARM machine in otrder to check whether if it is a slave, by checking the slave machine flag. When the slave flag is on, no kernel, dtb or initrd are loaded into memory. The boot address of each core

[Qemu-devel] [PATCH] quorum: add child name into filename

2016-03-18 Thread Wen Congyang
The monitor command 'query-block' or 'info block' will output the filename. So we can get each children's child-name after this patch. This useful for dynamic reconfiguration. Signed-off-by: Wen Congyang --- block/quorum.c | 10 +++--- 1 file changed, 7 insertions(+),

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-18 Thread tu bo
On 03/16/2016 09:38 PM, Christian Borntraeger wrote: On 03/16/2016 01:55 PM, Paolo Bonzini wrote: On 16/03/2016 12:24, Christian Borntraeger wrote: On 03/16/2016 12:09 PM, Paolo Bonzini wrote: On 16/03/2016 11:49, Christian Borntraeger wrote: #3 0x800b713e in

[Qemu-devel] [PULL 12/21] hw/timer: Add ASPEED timer device model

2016-03-18 Thread Peter Maydell
From: Andrew Jeffery Implement basic ASPEED timer functionality for the AST2400 SoC[1]: Up to 8 timers can independently be configured, enabled, reset and disabled. Some hardware features are not implemented, namely clock value matching and pulse generation, but the

[Qemu-devel] [PATCH] arm: fix machine description

2016-03-18 Thread Michael S. Tsirkin
Fix what is clearly a copy-and-paste bug. Fixes: c29196904b ("target-arm: Add virt class and machine types"). Cc: Greg Bellows Signed-off-by: Michael S. Tsirkin --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 09/16] block: wait for all pending I/O when doing synchronous requests

2016-03-18 Thread Stefan Hajnoczi
On Tue, Feb 16, 2016 at 06:56:21PM +0100, Paolo Bonzini wrote: > Synchronous I/O should in general happen either in the main thread (e.g. > for bdrv_open and bdrv_create) or between bdrv_drained_begin and > bdrv_drained_end. Therefore, the simplest way to wait for it to finish > is to wait for

[Qemu-devel] [PULL v1 02/13] crypto: add support for PBKDF2 algorithm

2016-03-18 Thread Daniel P. Berrange
The LUKS data format includes use of PBKDF2 (Password-Based Key Derivation Function). The Nettle library can provide an implementation of this, but we don't want code directly depending on a specific crypto library backend. Introduce a new include/crypto/pbkdf.h header which defines a QEMU API for

[Qemu-devel] [PULL 11/40] ivshmem: Add missing newlines to debug printfs

2016-03-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-12-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c

[Qemu-devel] [PULL 35/40] ivshmem: Replace int role_val by OnOffAuto master

2016-03-18 Thread Markus Armbruster
In preparation of making it a qdev property. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-36-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 31 +++ 1 file

[Qemu-devel] [PULL 26/40] ivshmem: Propagate errors through ivshmem_recv_setup()

2016-03-18 Thread Markus Armbruster
This kills off the funny state described in the previous commit. Simplify ivshmem_io_read() accordingly, and update documentation. Signed-off-by: Markus Armbruster Message-Id: <1458066895-20632-27-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH v5 28/28] migration: remove qemu_get_fd method from QEMUFile

2016-03-18 Thread Daniel P. Berrange
Now that there is a set_blocking callback in QEMUFileOps, and all users needing non-blocking support have been converted to QIOChannel, there is no longer any codepath requiring the qemu_get_fd() method for QEMUFile. Remove it to avoid further code being introduced with an expectation of direct

[Qemu-devel] kvm ept fault BUG_ON()

2016-03-18 Thread Stefanos Gerangelos
Hi, apologies if I am not posting to the appropriate list(s). I am using QEMU-KVM and try to implement a simple character device which offers mmap() functionality of host device memory to guest userspace. For this purpose, I have written a dummy guest driver which communicates with a qemu

[Qemu-devel] [RFC v2 4/6] hw/misc: sdm virtio device

2016-03-18 Thread Baptiste Reynal
This is the virtio implementation for an SDM device. Parameters are: comm=[sdm_communication_id] specifies the communication channel master=[true/false] - configure the SDM device as master or slave num_slaves=[slave_number] - if master is true, specifies the number of slaves

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-18 Thread Jaya Tiwari
On Fri, Mar 18, 2016 at 6:57 PM, Jaya Tiwari wrote: > > > On Fri, Mar 18, 2016 at 5:21 PM, Paolo Bonzini > wrote: > >> >> >> On 18/03/2016 12:24, Pooja Dhannawat wrote: >> > >> > >> > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini

[Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32

2016-03-18 Thread Pooja Dhannawat
On Friday, March 18, 2016, Gerd Hoffmann wrote: > > On Mo, 2016-03-14 at 15:22 +, Peter Maydell wrote: > > On 14 March 2016 at 15:04, Pooja Dhannawat wrote: > > > Removing support for DEPTH != 32 from blizzard template header > > > and file that

[Qemu-devel] [PATCH v1 1/2] crypto: add compat cast5_set_key with nettle < 3.0.0

2016-03-18 Thread Daniel P. Berrange
Prior to the nettle 3.0.0 release, the cast5_set_key function was actually named cast128_set_key, so we must add a compatibility definition. Signed-off-by: Daniel P. Berrange --- crypto/cipher-nettle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-18 Thread Corey Bryant
** Changed in: qemu (Ubuntu Vivid) Status: In Progress => Invalid ** Changed in: qemu (Ubuntu Vivid) Assignee: Liang Chen (cbjchen) => (unassigned) ** No longer affects: qemu (Ubuntu Vivid) -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

2016-03-18 Thread Paolo Bonzini
On 18/03/2016 17:18, Alex Bennée wrote: > From: KONRAD Frederic > > This finally allows TCG to benefit from the iothread introduction: Drop > the global mutex while running pure TCG CPU code. Reacquire the lock > when entering MMIO or PIO emulation, or when leaving

[Qemu-devel] [PATCH for-2.6 14/14] s390-ccw.img: rebuild image

2016-03-18 Thread Cornelia Huck
Contains the following changes: pc-bios/s390-ccw: add more disk layout checks pc-bios/s390-ccw: virtio_panic -> panic pc-bios/s390-ccw: add utility functions and "export" some others pc-bios/s390-ccw: qemuize types pc-bios/s390-ccw: update virtio implementation to allow up to 3 vrings

[Qemu-devel] [PATCH for-2.6 13/14] pc-bios/s390-ccw: disambiguation of "No zIPL magic" message

2016-03-18 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Don't indicate the same error message for different conditions. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c | 6 +++--- 1

[Qemu-devel] [PULL 01/40] target-ppc: Document TOCTTOU in hugepage support

2016-03-18 Thread Markus Armbruster
The code to find the minimum page size is is vulnerable to TOCTTOU. Added in commit 2d103aa "target-ppc: fix hugepage support when using memory-backend-file" (v2.4.0). Since I can't fix it myself right now, add a FIXME comment. Cc: Paolo Bonzini Cc: Michael Roth

Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

2016-03-18 Thread Marc-André Lureau
Hi On Fri, Mar 18, 2016 at 2:17 PM, Gerd Hoffmann wrote: > Ping Marc? Any comment on this? Could you send a rebased series, for the patches that lead to the issue? I assume "render DisplaySurface via opengl" patch? -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

2016-03-18 Thread Gerd Hoffmann
On Fr, 2016-02-19 at 10:14 +0100, Gerd Hoffmann wrote: > Current spice client expects we create a primary surface, > even if we do display updates using dma-bufs exclusively. > > So just do that to get things going. > > Not fully clear whenever that is intentional or a bug on > the spice side,

<    1   2