Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/05/2016 02:03 AM, Eric Blake wrote: On 04/04/2016 04:40 PM, Wouter Verhelst wrote: Hi, Need to look into this in some detail, for which I don't have the time (or the non-tiredness ;-) right now, but these two caught my eye: +The payload is structured as a list of one or more

[Qemu-devel] [PATCH 2/2] qga: Workaround for console redirection from non-interactive qemu-ga service

From: Yuri Pudgorodskiy mingw-glib uses helper process to assist gspawn() api. There are two versions of helpers, one with main() and another with WinMain() startup routines. Whenever gspawn() detects consoleless environment (and qemu-ga is running in such environment as

[Qemu-devel] [PATCH 1/2] qga: fix fd leak with guest-exec i/o channels

From: Yuriy Pudgorodskiy Signed-off-by: Yuriy Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth --- qga/commands.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands.c

[Qemu-devel] [PATCH for 2.6 0/2] qga: guest exec bugfixes

Signed-off-by: Yuriy Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth

[Qemu-devel] [FIX PATCH] spapr: Fix ibm,lrdr-capacity

ibm,lrdr-capacity has a field to describe the maximum address in bytes and therefore, the most memory that can be allocated to this guest. We are using maxmem for this field, but instead should use the actual RAM address corresponding to the end of hotplug region. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

On 5/4/16 23:31, Greg Kurz wrote: On Tue, 5 Apr 2016 23:27:33 +0800 Jevon Qiao wrote: Hi Greg, Any further comment? Thanks, Jevon Hi Jevon, Yes ! I could at last resume the review of your patch today. You can expect an answer this week. Ok, thanks. /Jevon Cheers.

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

The PowerVM machine I've been using for these tests has the following output: ubuntu@alpine01:~/kvm$ cat /proc/cpuinfo | grep platform platform: pSeries The PowerNV server has the following output: ubuntu@binacle:~$ cat /etc/issue; uname -a ; ppc64_cpu --smt ; cat /proc/cpuinfo |grep

Re: [Qemu-devel] 'make check' failure on Fedora 23

On 04/06/2016 07:35 AM, Eric Blake wrote: > Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this > installed, 'make check-qtest' (part of 'make check') now fails with: > > GTESTER check-qtest-x86_64 > ** > ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed: >

[Qemu-devel] [PATCH 2/3] nbd: Avoid bitrot in TRACE() usage

The compiler is smart enough to optimize out 'if (0)', but won't type-check our printfs if they are hidden behind #if. Signed-off-by: Eric Blake --- nbd/nbd-internal.h | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/nbd/nbd-internal.h

[Qemu-devel] [PATCH 0/3 for-2.6] more nbd fixups

Patch 1 fixes a minor bug (wrong error) on read-only exports, patch 2 and 3 fix up the debugging traces I used to find the root cause of patch 1. Maintainer's discretion on whether to take all three or just patch 1 in qemu 2.6 (but debug output improvements can't cause regressions...) Eric Blake

[Qemu-devel] [PATCH 3/3] nbd: Improve debug traces on little-endian

Print debug tracing messages while data is still in native ordering, rather than after we've potentially swapped it into network order for transmission. Also, it's nice if the server mentions what it is replying, to correlate it to with what the client says it is receiving. Signed-off-by: Eric

[Qemu-devel] [PATCH 1/3] nbd: Return correct error for write to read-only export

The NBD Protocol requires that servers should send EPERM for attempts to write (or trim) a read-only export. We were correct for TRIM (blk_co_discard() gave EPERM); but were manually setting EROFS which then got mapped to EINVAL over the wire on writes. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH for-2.6 0/2] Bug fixes for gluster

Bug fixes for gluster; second patch is to prevent a potential data loss when trying to recover from a recoverable error (such as ENOSPC). Jeff Cody (2): block/gluster: return correct error value block/gluster: prevent data loss after i/o error block/gluster.c | 29

[Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

Upon receiving an I/O error after an fsync, by default gluster will dump its cache. However, QEMU will retry the fsync, which is especially useful when encountering errors such as ENOSPC when using the werror=stop option. When using caching with gluster, however, the last written data will be

[Qemu-devel] [PATCH for-2.6 1/2] block/gluster: return correct error value

Upon error, gluster will call the aio callback function with a ret value of -1, with errno set to the proper error value. If we set the acb->ret value to the return value in the callback, that results in every error being EPERM (i.e. 1). Instead, set it to the proper error result.

[Qemu-devel] [PATCH 2/3] slirp: Propagate host TCP RST to the guest.

When the host aborts (RST) it's side of a TCP connection we need to propagate that RST to the guest. The current code can leave such guest connections dangling forever. Spotted by Jason Wessel. [ste...@steven676.net: coding style adjustments] Signed-off-by: Steven Luo

[Qemu-devel] [PATCH 3/3] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

slirp currently only handles ECONNREFUSED in the case where connect() returns immediately with that error; since we use non-blocking sockets, most of the time we won't receive the error until we later try to read from the socket. Ensure that we deliver the appropriate RST to the guest in this

[Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

QEMU's user-mode networking does not currently pass received TCP RSTs to guests, meaning that applications in guests hang if the remote server rejects their network connections. This is particularly noticeable when IPv6 is enabled, the guest is configured to prefer IPv6 and the remote server

[Qemu-devel] [PATCH 1/3] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

Signed-off-by: Steven Luo --- This prevents a crash that would be exposed by a later patch in this series. The removed check for non-null is clearly wrong, as it comes after the pointer has already been dereferenced in this function. slirp/tcp_subr.c | 7 +-- 1

[Qemu-devel] Possible bug: virtio-scsi + iothread (Former x-data-plane) = "Guest moved index from 0 to 61440" warning

Recently I hear that the experimental x-data-plane feature from virtio-blk was production-ready and that virtio-scsi also got support for it, so, after finding what the new syntax is: http://comments.gmane.org/gmane.comp.emulators.qemu/279118 ...I decided to test it. After all, it was supposed

[Qemu-devel] [PULL 5/5] filter-buffer: fix segfault when starting qemu with status=off property

From: zhanghailiang After commit 338d3f, we support 'status' property for filter object. The segfault can be triggered by starting qemu with 'status=off' property for filter, when the s->incoming_queue is NULL, we reference it directly in qemu_net_queue_flush()

[Qemu-devel] [PULL 4/5] rtl8139: using CP_TX_OWN for ownership transferring during tx

Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use CP_TX_OWN for tx descriptor handling. Signed-off-by: Jason Wang --- hw/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index

[Qemu-devel] [PULL 2/5] net: Allocating Large sized arrays to heap

From: Pooja Dhannawat nc_sendv_compat has a huge stack usage of 69680 bytes approx. Moving large arrays to heap to reduce stack usage. Reviewed-by: Stefan Hajnoczi Signed-off-by: Pooja Dhannawat Signed-off-by: Jason

[Qemu-devel] [PULL 0/5] Net patches

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 3/5] net: fix OptsVisitor memory leak

From: Paolo Bonzini Fixes 96a1616("qapi-dealloc: Reduce use outside of generated code") Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 1 + 1 file changed, 1

[Qemu-devel] [PULL 1/5] util: Improved qemu_hexmap() to include an ascii dump of the buffer

From: Isaac Lozano <109loza...@gmail.com> qemu_hexdump() in util/hexdump.c has been changed to give also include a ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have been replaced with calls to qemu_hexdump(). This takes care of two misc BiteSized Tasks. Reviewed-by: Thomas

Re: [Qemu-devel] [PATCH 0/6] fix some coverity complains

Hi Paolo, Would you pls pick patch 1,3,4,5 to qemu-2.6 ? It seems the trivial-branch maintainer didn't notice them. :( Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, March 03, 2016 5:44 PM > To: qemu-devel@nongnu.org > Cc: pbonz...@redhat.com;

[Qemu-devel] [PATCH for-2.6] qemu-nbd: Document -x option

Commit 3d4b2f9c added -x to force qemu-nbd to use new-style negotiation, but while it documented it in the man page, it omitted docs in the --help output. Signed-off-by: Eric Blake --- qemu-nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-nbd.c b/qemu-nbd.c

Re: [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel

On 04/05/2016 11:54 PM, Greg Kurz wrote: > On Mon, 21 Mar 2016 13:25:53 +0800 > Jason Wang wrote: >> > Hi: >> > >> > This series enable vhost-kernel busy polling support. It's done >> > through introducing a new property for tap backend - 'vhost_poll_us' >> > which is the

Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000

On 04/05/2016 09:32 PM, Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: >> On (Tue) 23 Feb 2016 [15:02:58], Jason Wang wrote: > This means that 2.5 cannot migrate 2.4 virtual machines, right? Is that > something we want to rectify in 2.6 by making e1000-82540em

Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt

On Wed, 2016-04-06 at 01:02 +0200, Paolo Bonzini wrote: > > On 22/03/2016 10:45, Wei Jiangang wrote: > > The scale line should align with A line's end, > > No, A ends at 0x7fff so the line should end just before. See what > happens for B/C/D/E. Yes, you're right. Thanks for your reply.

Re: [Qemu-devel] [RFC PATCH v2.1 11/12] xics, xics_kvm: Handle CPU unplug correctly

On Tue, Apr 05, 2016 at 07:24:39PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2016-03-31 03:39:20) > > XICS is setup for each CPU during initialization. Provide a routine > > to undo the same when CPU is unplugged. While here, move ss->cs management > > into xics from xics_kvm since there

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On Tue, Apr 05, 2016 at 14:08:13 -0700, Richard Henderson wrote: > But the point is that we can do better than dropping data into memory. > Particularly for those hosts that do not support unaligned data, such as you > created with the packed structure. If we made sure the fields in the struct

[Qemu-devel] [PATCH V2] tests: ignore test-logging

Commit 3514552e added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore

Re: [Qemu-devel] [RFC PATCH v2.1 11/12] xics, xics_kvm: Handle CPU unplug correctly

Quoting Bharata B Rao (2016-03-31 03:39:20) > XICS is setup for each CPU during initialization. Provide a routine > to undo the same when CPU is unplugged. While here, move ss->cs management > into xics from xics_kvm since there is nothing KVM specific in it. > Also ensure xics reset doesn't set

Re: [Qemu-devel] [RFC PATCH v2.1 10/12] spapr: CPU hotplug support

Quoting Bharata B Rao (2016-03-31 03:39:19) > Set up device tree entries for the hotplugged CPU core and use the > exising RTAS event logging infrastructure to send CPU hotplug notification > to the guest. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c

[Qemu-devel] [PATCH v2] tpm: Fix write to file descriptor function

Fix a bug introduced in commit 46f296c while moving send_all to the tpm_passthrough code. Fix the name of the variable used in the loop. Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] acpi: tpm: Fix TPM ACPI description

On 04/04/2016 12:00 PM, Michael S. Tsirkin wrote: On Mon, Apr 04, 2016 at 06:31:43AM -0400, Stefan Berger wrote: On 04/04/2016 05:04 AM, Michael S. Tsirkin wrote: On Sun, Apr 03, 2016 at 09:37:54PM -0400, Stefan Berger wrote: This series of patches fixes some problems with the TPM's ACPI

[Qemu-devel] 'make check' failure on Fedora 23

Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this installed, 'make check-qtest' (part of 'make check') now fails with: GTESTER check-qtest-x86_64 ** ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed: (block_name) GTester: last random seed:

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

Eric (sic - sorry - long day). On 5 Apr 2016, at 22:26, Eric Blake wrote: > Ah, you were faster than my reply mail; looks like everything I pointed > out now gets to be a followup patch :) I agree with all but one of the the changes you put in. As Wouter is the fastest gun

Re: [Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

Quoting Mike Rushton (2016-04-05 17:22:24) > Sorry, I copied the wrong thing: > > sudo qemu-system-ppc64 -enable-kvm -m 256 -display none -nographic -net nic > -net user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 -machine pseries > -drive

Re: [Qemu-devel] Question about hw/timer/hpet.c, hw/intc/ioapic.c and polarity

On 05/04/2016 20:30, Bill Paul wrote: >>> Researching the code history, I see that the inversion logic was added in >>> 2013 in order to fix a problem with HPET usage in Linux. However >>> something about the way this was done looks wrong to me. In the case >>> where we actually want to signal

Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt

On 22/03/2016 10:45, Wei Jiangang wrote: > The scale line should align with A line's end, No, A ends at 0x7fff so the line should end just before. See what happens for B/C/D/E. However, the space between 7000 and 8000 is indede 7 characters instead of 6, so I will take your patch and also

Re: [Qemu-devel] [PATCH] doc: Allow NBD_CMD_FLAG_NO_HOLE during NBD_CMD_WRITE

On 04/04/2016 16:15, Eric Blake wrote: > qemu already has an existing server implementation option that will > explicitly search the payload of NBD_CMD_WRITE for large blocks of > zeroes, and punch holes in the underlying file. For old clients > that don't know how to use the new

[Qemu-devel] [PATCH] hw/timer: Revert "hpet: inverse polarity when pin above ISA_NUM_IRQS"

This reverts commit 0d63b2dd31464cfccc80bbeedc24e3863fe4c895. This change was originally intended to correct the HPET behavior in conjunction with Linux, however the behavior that it actually creates doesn't match what happens with real hardware, the logic doesn't seem compatible with the

Re: [Qemu-devel] powerpc: Clear user CPU feature bits if TM is disabled at runtime

On 5 April 2016 7:56:23 pm AEST, Benjamin Herrenschmidt wrote: >On Tue, 2016-04-05 at 19:35 +1000, Michael Ellerman wrote: >> Shouldn't we be clearing the user feature there too? >> >> The ibm_pa_features array and the logic in scan_features() knows to >> flip the >>

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

Sorry, I copied the wrong thing: sudo qemu-system-ppc64 -enable-kvm -m 256 -display none -nographic -net nic -net user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 -machine pseries -drive file=xenial-server-cloudimg-ppc64el-disk1.img,if=virtio -drive file=seed.iso,if=virtio

Re: [Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

Quoting Mike Rushton (2016-04-05 16:47:29) > @mdroth > > I don't think PPC supports kvm the same way as x86: > > ubuntu@alpine01:~/kvm$ qemu-system-ppc64 -enable-kvm -m 256 -display none > -nographic -net nic -net > user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 -machine pseries >

[Qemu-devel] [ANNOUNCE] QEMU 2.6.0-rc1 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 2.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.6.0-rc1.tar.bz2 You can help

Re: [Qemu-devel] [RFC PATCH v2.1 00/12] Core based CPU hotplug for PowerPC sPAPR

On Tue, 5 Apr 2016 20:25:57 +0530 Bharata B Rao wrote: > On Mon, Apr 04, 2016 at 04:44:27PM +0200, Igor Mammedov wrote: > > On Thu, 31 Mar 2016 14:09:09 +0530 > > Bharata B Rao wrote: > > > > > Hi, > > > > > > This is v2.1 of "Core based

[Qemu-devel] Any progress with the Cortex-M4 emulation?

(I know that from time to time this question pops up, but) is there anyone working or planning to work on the M4 emulation? If not, I might give it a try, perhaps it is not as mission impossible as it looks like. Except the lazy processing of exception save/restore which must be implemented,

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

@serge-hallyn ubuntu@alpine01:~/kvm$ cat /etc/issue; uname -a ; ppc64_cpu --smt Ubuntu Xenial Xerus (development branch) \n \l Linux alpine01 4.4.0-17-generic #33-Ubuntu SMP Tue Mar 29 17:15:31 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux SMT is off ubuntu@alpine01:~/kvm$ qemu-system-ppc64 -m 256

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

@mdroth I don't think PPC supports kvm the same way as x86: ubuntu@alpine01:~/kvm$ qemu-system-ppc64 -enable-kvm -m 256 -display none -nographic -net nic -net user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 -machine pseries -drive

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 for-2.6] tci: Fix build regression

Quoting Stefan Weil (2016-04-05 15:29:37) > Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include > statements which resulted in a wrong order of assert.h and the definition > of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert > macro, but here this definition

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On Mon, Apr 04, 2016 at 05:32:34PM -0600, Eric Blake wrote: > On 04/04/2016 05:08 PM, Wouter Verhelst wrote: > > On Mon, Apr 04, 2016 at 10:54:02PM +0300, Denis V. Lunev wrote: > >> saying about dirtiness, we would soon come to the fact, that > >> we can have several dirtiness states regarding

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

On 04/05/2016 03:03 PM, Wouter Verhelst wrote: > On Tue, Apr 05, 2016 at 09:42:26PM +0100, Alex Bligh wrote: >> Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as >> follows: >> >> >> * Make the documentation much more concise. >> >> Signed-off-by: Alex Bligh > [...] > >

Re: [Qemu-devel] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

On 04/05/2016 02:42 PM, Alex Bligh wrote: > Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as > follows: > > * Make the documentation much more concise. > > Signed-off-by: Alex Bligh > --- > doc/proto.md | 142 >

Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

On Tue, Apr 5, 2016 at 7:40 PM, Sebastian Andrzej Siewior wrote: > On 04/05/2016 07:11 PM, Antonio Borneo wrote: >> Hi, > Hi, > >> I'm not expert on the x86 memory map at boot and during kernel >> boot; I found easy to just append the dtb to the kernel image. >>>From my

[Qemu-devel] [PATCH] hw/i386: add device tree support

With "-dtb" on command-line: - append the device tree blob to the kernel image; - pass the blob's pointer to the kernel through setup_data, as requested by upstream kernel commit da6b737b9ab7 ("x86: Add device tree support"). The device tree blob is passed as-is to the guest; none of its

Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

On 04/05/2016 07:11 PM, Antonio Borneo wrote: > Hi, Hi, > I'm not expert on the x86 memory map at boot and during kernel > boot; I found easy to just append the dtb to the kernel image. >>From my tests this patch is working fine. > If you have any hint for a different loading address for dtb, I >

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On 04/05/2016 12:40 PM, Emilio G. Cota wrote: On Tue, Apr 05, 2016 at 09:07:57 -0700, Richard Henderson wrote: On 04/05/2016 08:48 AM, Paolo Bonzini wrote: I think it's fine to use the struct. The exact size of the struct varies from 3 to 5 32-bit words, so it's hard to write nice

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

On Tue, Apr 05, 2016 at 09:42:26PM +0100, Alex Bligh wrote: > Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as > follows: > > * Change NBD_OPT_SELECT to be called NBD_OPT_INFO > > * Remove the 'selection' aspect of that command, so that > it now merely returns information. This is to

Re: [Qemu-devel] [Nbd] [PATCHv5] Improve the documentation of NBD_CMD_FLUSH and NBD_CMD_FLAG_FUA.

On Tue, Apr 05, 2016 at 05:43:14PM +0100, Alex Bligh wrote: > Improve the documentation of NBD_CMD_FLUSH and NBD_CMD_FLAG_FUA. Specifically > the latter may be set on any command, and its semantics on commands other > than NBD_CMD_WRITE need explaining. Further, explain how these relate to >

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On Tue, Apr 05, 2016 at 08:14:01AM -0600, Eric Blake wrote: > On 04/05/2016 03:24 AM, Markus Pargmann wrote: > > >> +requested. > >> + > >> +The client SHOULD NOT read from an area that has both > >> +`NBD_STATE_HOLE` set and `NBD_STATE_ZERO` clear. > > > > Why not? If we don't

Re: [Qemu-devel] [PULL for-2.6] tcg/mips fix

) warning > (2016-04-05 17:49:41 +0100) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tcg-20160405 > > for you to fetch changes up to 2dc7553d0c0a3915c649e1a91b0f0be70b4674b3: > > tcg/mips: Fix type o

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Allow NBD_CMD_FLAG_NO_HOLE during NBD_CMD_WRITE

On Tue, Apr 05, 2016 at 10:43:14AM -0600, Eric Blake wrote: > On 04/05/2016 03:38 AM, Markus Pargmann wrote: > > Hi, > > > > On Monday 04 April 2016 16:15:43 Eric Blake wrote: > >> qemu already has an existing server implementation option that will > >> explicitly search the payload of

Re: [Qemu-devel] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On Tue, 2016-04-05 at 09:03 +0200, Cédric Le Goater wrote: > > Well, yes, but cpu_ppc_set_papr() only handles the AMOR setting, the LPCR  > settings were kept for later as they were not bug fixes.  > > As for now, powerpc_excp() checks the ILE bit and uses the AIL bits to  > calculate the vector

Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

On Tue, Apr 05, 2016 at 07:11:28PM +0200, Antonio Borneo wrote: > With "-dtb" on command-line: > - append the device tree blob to the kernel image; > - pass the blob's pointer to the kernel through setup_data, as > requested by upstream kernel commit da6b737b9ab7 ("x86: Add > device tree

[Qemu-devel] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as follows: * Change NBD_OPT_SELECT to be called NBD_OPT_INFO * Remove the 'selection' aspect of that command, so that it now merely returns information. This is to avoid the server storing state. * Allow a name to be specified on

[Qemu-devel] [PATCH v2 for-2.6] tci: Fix build regression

Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include statements which resulted in a wrong order of assert.h and the definition of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert macro, but here this definition comes too late which results in a failing build.

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

Richard Henderson writes: > On 04/05/2016 12:02 PM, Lluís Vilanova wrote: >> Peter Maydell writes: >> >>> On 5 April 2016 at 17:31, Richard Henderson wrote: On 04/05/2016 09:23 AM, Lluís Vilanova wrote: > > Got it! > > gcc -march=native --help=params -v

Re: [Qemu-devel] [PATCH for-2.6] Fix NBD unsupported options

On 04/05/2016 12:55 PM, Alex Bligh wrote: > nbd-client.c currently fails to handle unsupported options properly. > If during option haggling the server finds an option that is > unsupported, it returns an NBD_REP_ERR_UNSUP reply. > > According to nbd's proto.md, the format for such a reply >

[Qemu-devel] Error when attempting to perform TLS NBD connection

When I attempt to connect via TLS like this (using today's qemu master): ./qemu-img info --object tls-creds-x509,id=tls0,dir=../certs,endpoint=client --image-opts driver=nbd,host=127.0.0.1,port=,export=foo,tls-creds=tls0 (command line from Daniel over IRC) I get the rather opaque error:

[Qemu-devel] [PULL for-2.6] tcg/mips: Fix type of tcg_target_reg_alloc_order[]

From: James Hogan The MIPS TCG backend is the only one to have tcg_target_reg_alloc_order[] elements of type TCGReg rather than int. This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base temporaries in a different order") breaking the build on MIPS since the

[Qemu-devel] [PULL for-2.6] tcg/mips fix

tags/pull-tcg-20160405 for you to fetch changes up to 2dc7553d0c0a3915c649e1a91b0f0be70b4674b3: tcg/mips: Fix type of tcg_target_reg_alloc_order[] (2016-04-05 12:47:47 -0700) tcg/mips compilation fix

Re: [Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

Quoting Mike Rushton (2016-04-05 13:10:17) > ubuntu@alpine01:~$ sudo ppc64_cpu --smt=1 > ubuntu@alpine01:~$ ppc64_cpu --info > Core 0:0*1 2 3 4 5 6 7 > Core 1:8*9101112131415 > Core 2: 16* 1718192021

Re: [Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

If you can reproduce this with the ppc64 xenial iso or a rootfs installed from that, using 4.4 kernel, please let us know. Otherwise, I think the fix will be for cloud images to be updated with a 4.4 kernel. -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On Tue, Apr 05, 2016 at 09:07:57 -0700, Richard Henderson wrote: > On 04/05/2016 08:48 AM, Paolo Bonzini wrote: > >I think it's fine to use the struct. The exact size of the struct > >varies from 3 to 5 32-bit words, so it's hard to write nice > >size-dependent code for the hash. > > I don't

[Qemu-devel] [PATCH] TLS: provide slightly more information when TLS certificate loading fails

Give slightly more information when certification loading fails. Rather than have no information, you now get gnutls's only slightly less unhelpful error messages. Signed-off-by: Alex Bligh --- crypto/tlscredsx509.c | 17 +++-- 1 file changed, 11 insertions(+), 6

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

On Tue, Apr 05, 2016 at 19:01:07 +0100, Peter Maydell wrote: > On 5 April 2016 at 18:24, Emilio G. Cota wrote: > > So how about this: > > we add these defaults, and also add an optional --configure > > parameter to override said defaults. > > I think this definitely doesn't merit

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

On 04/05/2016 12:02 PM, Lluís Vilanova wrote: > Peter Maydell writes: > >> On 5 April 2016 at 17:31, Richard Henderson wrote: >>> On 04/05/2016 09:23 AM, Lluís Vilanova wrote: Got it! gcc -march=native --help=params -v 2>&1 | grep "param

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

Peter Maydell writes: > On 5 April 2016 at 17:31, Richard Henderson wrote: >> On 04/05/2016 09:23 AM, Lluís Vilanova wrote: >>> >>> Got it! >>> >>> gcc -march=native --help=params -v 2>&1 | grep "param >>> l1-cache-line-size" | sed -e 's/.* --param

Re: [Qemu-devel] [PATCH] Amend NBD_OPT_SELECT and NBD_OPT_GO documentation

Eric, In brief I agree with all of that. I'm tempted to redo it so it's much simpler now we all seem to agree that carrying state is a bad thing. Alex On 5 Apr 2016, at 18:48, Eric Blake wrote: > On 04/05/2016 10:38 AM, Alex Bligh wrote: >> Amend the NBD_OPT_SELECT and

[Qemu-devel] [PATCH] Fix NBD unsupported options

nbd-client.c currently fails to handle unsupported options properly. If during option haggling the server finds an option that is unsupported, it returns an NBD_REP_ERR_UNSUP reply. According to nbd's proto.md, the format for such a reply should be: S: 64 bits, 0x3e889045565a9 (magic number

Re: [Qemu-devel] [RFC PATCH v2.1 00/12] Core based CPU hotplug for PowerPC sPAPR

On Tue, 5 Apr 2016 20:25:57 +0530 Bharata B Rao wrote: > On Mon, Apr 04, 2016 at 04:44:27PM +0200, Igor Mammedov wrote: > > On Thu, 31 Mar 2016 14:09:09 +0530 > > Bharata B Rao wrote: > > > > > Hi, > > > > > > This is v2.1 of "Core based

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

ubuntu@alpine01:~$ sudo ppc64_cpu --smt=1 ubuntu@alpine01:~$ ppc64_cpu --info Core 0:0*1 2 3 4 5 6 7 Core 1:8*9101112131415 Core 2: 16* 17181920212223 Core 3: 24* 25262728

Re: [Qemu-devel] Question about hw/timer/hpet.c, hw/intc/ioapic.c and polarity

Of all the gin joints in all the towns in all the world, Paolo Bonzini had to walk into mine at 06:20:05 on Tuesday 05 April 2016 and say: > On 04/04/2016 23:42, Bill Paul wrote: > > I'm testing some of the HPET handling code in VxWorks using QEMU 2.4.1 > > and I've encountered something which

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

On 5 April 2016 at 18:24, Emilio G. Cota wrote: > On Tue, Apr 05, 2016 at 08:57:45 +0100, Peter Maydell wrote: >> On 5 April 2016 at 06:30, Emilio G. Cota wrote: >> > +#define QEMU_CACHELINE (64) >> >> Why 64? Does anything bad happen if the host's cache line >>

Re: [Qemu-devel] [PATCH] Amend NBD_OPT_SELECT and NBD_OPT_GO documentation

On 04/05/2016 10:38 AM, Alex Bligh wrote: > Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as > follows: > > * Allow a name to be specified on NBD_OPT_GO > > * Make clear the rules for default device selection > > * Remove the provision concerning TLS resetting device selection > > *

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

On Tue, Apr 05, 2016 at 08:57:45 +0100, Peter Maydell wrote: > On 5 April 2016 at 06:30, Emilio G. Cota wrote: > > +#define QEMU_CACHELINE (64) > > Why 64? Does anything bad happen if the host's cache line > size turns out to be greater than the value here ? Defining a number

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On 04/05/2016 09:33 AM, Laurent Desnogues wrote: > The 'flags' field is 64-bit. You're thinking of cflags, I guess. Well that's silly. Since it's filled in via static inline void cpu_get_tb_cpu_state(CPUMIPSState *env, target_ulong *pc, target_ulong

Re: [Qemu-devel] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning

On 5 April 2016 at 15:46, Ed Maste wrote: > This is the same change as b55266b5 in linux-user. > > Signed-off-by: Ed Maste > --- > bsd-user/uaccess.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bsd-user/uaccess.c

Re: [Qemu-devel] [PATCH] bsd-user: add qemu/cutils.h include after f348b6d

On 5 April 2016 at 15:01, Ed Maste wrote: > Signed-off-by: Ed Maste > --- > bsd-user/uaccess.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c > index 7cb6d17..b7b3a06 100644 > --- a/bsd-user/uaccess.c >

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

On 5 April 2016 at 17:31, Richard Henderson wrote: > On 04/05/2016 09:23 AM, Lluís Vilanova wrote: >> >> Got it! >> >>gcc -march=native --help=params -v 2>&1 | grep "param >> l1-cache-line-size" | sed -e 's/.* --param l1-cache-line-size=\([0-9]\+\) >> .*/\1/' > > > That will

Re: [Qemu-devel] [PULL 0/4] Block layer patches for 2.6

On 5 April 2016 at 16:41, Kevin Wolf wrote: > The following changes since commit 2e3a76ae3e47d502f9f0c4424b719945fba9d459: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160404' into staging (2016-04-04 > 17:43:39 +0100) > > are available in the

Re: [Qemu-devel] [PATCH] tests: ignore test-logging

On 04/05/2016 01:24 AM, Changlong Xie wrote: > On 04/05/2016 02:35 PM, Changlong Xie wrote: >> Commit 3514552e added a new test, but did not mark it for >> exclusion in .gitignore. >> >> Signed-off-by: Changlong Xie >> --- >> tests/.gitignore | 1 + >> 1 file

[Qemu-devel] [PATCHv5] Improve the documentation of NBD_CMD_FLUSH and NBD_CMD_FLAG_FUA.

Improve the documentation of NBD_CMD_FLUSH and NBD_CMD_FLAG_FUA. Specifically the latter may be set on any command, and its semantics on commands other than NBD_CMD_WRITE need explaining. Further, explain how these relate to reordering of commands. Reviewed-by: Eric Blake

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Allow NBD_CMD_FLAG_NO_HOLE during NBD_CMD_WRITE

On 04/05/2016 03:38 AM, Markus Pargmann wrote: > Hi, > > On Monday 04 April 2016 16:15:43 Eric Blake wrote: >> qemu already has an existing server implementation option that will >> explicitly search the payload of NBD_CMD_WRITE for large blocks of >> zeroes, and punch holes in the underlying

[Qemu-devel] [PATCH] Amend NBD_OPT_SELECT and NBD_OPT_GO documentation

Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as follows: * Allow a name to be specified on NBD_OPT_GO * Make clear the rules for default device selection * Remove the provision concerning TLS resetting device selection * Remove NBD_REP_ERR_INVALID as a reply to NBD_OPT_GO as there

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On Tue, Apr 5, 2016 at 5:41 PM, Richard Henderson wrote: > On 04/04/2016 10:30 PM, Emilio G. Cota wrote: >> >> Tests show that the other element checked for in tb_find_physical, >> cs_base, is always a match when tb_phys+pc+flags are a match, >> so hashing cs_base is wasteful.

  1   2   3   >