Re: [Qemu-devel] [PATCH v5 04/11] mptsas: change .realize function name

forget to cc some maintainers On 05/06/2016 12:20 PM, Cao jin wrote: All the other devices` .realize function name are xxx_realize, except this one. cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin ---

Re: [Qemu-devel] [PATCH v5 02/11] change pvscsi_init_msi() type to void

forget to cc some maintainers On 05/06/2016 12:20 PM, Cao jin wrote: Nobody use its return value, so change the type to void. cc: Paolo Bonzini Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

On 04/29/2016 10:03 AM, Jason Wang wrote: On 04/28/2016 05:04 PM, Zhang Chen wrote: On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: +static void

Re: [Qemu-devel] [PATCH v5 03/11] megasas: Fix

sorry, forget to cc some maintainers On 05/06/2016 12:20 PM, Cao jin wrote: msi_init returns non-zero value on both failure and success. cc: Hannes Reinecke cc: Paolo Bonzini Signed-off-by: Cao jin --- hw/scsi/megasas.c | 2 +-

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

Fam, Any objections to this one? -- Janne On Tue, May 3, 2016 at 12:43 PM, Janne Karhunen wrote: > From: Janne Karhunen > > Vmdk images have metadata to indicate the vmware virtual > hardware version image was created/tested to run with. >

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

On Fri, May 6, 2016 at 6:14 AM, Fam Zheng wrote: > On Thu, 05/05 15:06, Jeff Cody wrote: > > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > > From

Re: [Qemu-devel] [PATCH v2 2/2] xen: add pvUSB backend

On 05/05/16 12:13, Anthony PERARD wrote: > On Wed, May 04, 2016 at 10:25:03AM +0200, Juergen Gross wrote: >> On 03/05/16 17:06, Anthony PERARD wrote: >>> On Thu, Mar 10, 2016 at 04:19:30PM +0100, Juergen Gross wrote: +static void usbback_bh(void *opaque) +{ +struct usbback_info

Re: [Qemu-devel] TCP Segementation Offloading

> On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: >> Good Mayday Qemu Developers, >> >> today I tried to find a reference to a networking problem, that seems to be >> of quite general nature: TCP Segmentation Offloading (TSO) in virtual >> environments. >> >> When I setup TAP

Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor

On 05/04/2016 09:45 AM, Markus Armbruster wrote: > +void json_output_visitor_reset(JsonOutputVisitor *v); Hmm. Why is "reset" not a Visitor method? I think this would let us put the things enforced by your "qmp: Tighten output visitor rules" in the Visitor contract.

[Qemu-devel] [PATCH v5 04/11] mptsas: change .realize function name

All the other devices` .realize function name are xxx_realize, except this one. cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability

ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Signed-off-by: Cao jin --- hw/pci/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4

[Qemu-devel] [PATCH v5 06/11] intel-hda: change msi property type

>From uint32 to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/audio/intel-hda.c | 7 --- 1 file

[Qemu-devel] [PATCH v5 11/11] pci: Convert msi_init() to Error and fix callers to check it

msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don`t handle the failure, it might happen: when user want msi on, but he doesn`t get what he

[Qemu-devel] [PATCH v5 01/11] fix some coding style problems

It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it more readable. cc: Dmitry Fleytman cc: Jason Wang

[Qemu-devel] [PATCH v5 08/11] megasas: change msi/msix property type

>From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Markus Armbruster Signed-off-by: Cao jin --- hw/scsi/megasas.c | 28 +++- 1 file changed, 11 insertions(+), 17

[Qemu-devel] [PATCH v5 05/11] usb xhci: change msi/msix property type

>From bit to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/usb/hcd-xhci.c | 16 +--- 1 file

[Qemu-devel] [PATCH v5 00/11] Add param Error ** for msi_init()

This patchset is for 2.7. This version has a huge change, so I hope to get some comments first. The change mostly is: 1. According suggestions, modify devices` msi/msix property type. its type mostly bit or uint, now change it to enum OnOffAuto, and default to "auto". So we will know if

[Qemu-devel] [PATCH v5 03/11] megasas: Fix

msi_init returns non-zero value on both failure and success. cc: Hannes Reinecke cc: Paolo Bonzini Signed-off-by: Cao jin --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c

[Qemu-devel] [PATCH v5 09/11] pci bridge dev: change msi property type

>From bit to enum OnOffAuto. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- Actually, I am not quite sure this device need this change, RFC.

[Qemu-devel] [PATCH v5 07/11] mptsas: change msi property type

>From uint32 to enum OnOffAuto, and give it a shorter name. cc: Paolo Bonzini cc: Markus Armbruster Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- hw/scsi/mptsas.h | 3 ++- 2 files changed, 4 insertions(+), 3

[Qemu-devel] [PATCH v5 02/11] change pvscsi_init_msi() type to void

Nobody use its return value, so change the type to void. cc: Paolo Bonzini Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/vmw_pvscsi.c | 4 +--- 1 file changed, 1

[Qemu-devel] [PATCH v3 5/5] adb.c: add power key support

Add support for the power key. It has to be handled differently from the other keys because it is the only 16-bit value key. Signed-off-by: John Arbuckle --- v3 change Add several suggested comments. Moved the location of an else statement in the adb_keyboard_event()

[Qemu-devel] [PATCH v3 4/5] adb.c: prevent NO_KEY value from going to guest

The NO_KEY value should not be sent to the guest. This patch drops that value. Signed-off-by: John Arbuckle --- hw/input/adb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/adb.c b/hw/input/adb.c index 6d4f4dc..37728b3 100644 --- a/hw/input/adb.c +++

[Qemu-devel] [PATCH v3 3/5] adb.c: correct several key assignments

The original pc_to_adb_keycode mapping did have several keys that were incorrectly mapped. This patch fixes these mappings. Signed-off-by: John Arbuckle --- hw/input/adb.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff

[Qemu-devel] [PATCH v3 2/5] adb.c: add support for QKeyCode

The old pc scancode translation is replaced with QEMU's QKeyCode. Signed-off-by: John Arbuckle --- *v3 changes Kept original pc_to_adb_keycode mapping. *v2 changes Changed order of this patch. hw/input/adb.c | 222

[Qemu-devel] [PATCH v3 1/5] adb-keys.h: initial commit

Add the adb-keys.h file. It maps ADB transition key codes with values. Signed-off-by: John Arbuckle --- *v3 changes: Removed note. *v2 changes: Changed order of this patch. include/hw/input/adb-keys.h | 142 1 file

[Qemu-devel] [PATCH v3 0/5] ADB improvements

This patch series makes several improvements to the ADB code. To test this code, please implement the patches in the order below. John Arbuckle (5): adb-keys.h: initial commit adb.c: add support for QKeyCode adb.c: correct several key assignments adb.c: prevent NO_KEY value from going to

Re: [Qemu-devel] [patch v6 11/12] vfio: register aer resume notification handler for aer resume

On 04/26/2016 10:48 PM, Alex Williamson wrote: On Tue, 26 Apr 2016 11:39:02 +0800 Chen Fan wrote: On 04/14/2016 09:02 AM, Chen Fan wrote: On 04/12/2016 05:38 AM, Alex Williamson wrote: On Tue, 5 Apr 2016 19:42:02 +0800 Cao jin wrote:

Re: [Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

> This series of patches provides a framework for testing migration > performance characteristics. The motivating factor for this is planning that > is > underway in OpenStack wrt making use of QEMU migration features such as > compression, auto-converge and post-copy. The primary aim for

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

On Thu, 05/05 15:06, Jeff Cody wrote: > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > > From: Vikhyat Umrao > >

Re: [Qemu-devel] [PATCH qemu v16 02/19] memory: Call region_del() callbacks on memory listener unregistering

On Wed, 4 May 2016 16:52:14 +1000 Alexey Kardashevskiy wrote: > When a new memory listener is registered, listener_add_address_space() > is called and which in turn calls region_add() callbacks of memory regions. > However when unregistering the memory listener, it is just

Re: [Qemu-devel] [PATCH qemu v16 01/19] vfio: Delay DMA address space listener release

On Wed, 4 May 2016 16:52:13 +1000 Alexey Kardashevskiy wrote: > This postpones VFIO container deinitialization to let region_del() > callbacks (called via vfio_listener_release) do proper clean up > while the group is still attached to the container. Any mappings within the

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

On Wed, May 04, 2016 at 07:22:16 -1000, Richard Henderson wrote: > On 05/04/2016 05:36 AM, Emilio G. Cota wrote: > >BTW in the last couple of days I did some more work beyond v4: > > > >- Added a benchmark (not a correctness test) to measure parallel > > performance of QHT (recall that

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pfs does not honor open file handles on unlinked files Status in

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

I would appreciate this patch being committed as I *think* it's affecting a system i'm building now. I have a backup host with 2 VMs. For business reasons they need to be network isolated from each other and the host, so each is passed through a physical NIC. Each VM does need access to a

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

On Thu, May 05, 2016 at 01:19:45PM -0600, Alex Williamson wrote: > [cc +Intel,NVIDIA] > > On Thu, 5 May 2016 18:29:08 +0800 > Dong Jia wrote: > > > On Wed, 4 May 2016 13:26:53 -0600 > > Alex Williamson wrote: > > > > > On Wed, 4 May

Re: [Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

On Thu, May 05, 2016 at 09:24:26AM +, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Thursday, May 05, 2016 1:06 AM > > > > > + > > > > > +static int vgpu_dev_mmio_fault(struct vm_area_struct *vma, struct > > > > > vm_fault > > *vmf) > > > > > +{ > > > > > + int ret = 0; > > > > >

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

[cc +Intel,NVIDIA] On Thu, 5 May 2016 18:29:08 +0800 Dong Jia wrote: > On Wed, 4 May 2016 13:26:53 -0600 > Alex Williamson wrote: > > > On Wed, 4 May 2016 17:26:29 +0800 > > Dong Jia wrote: > > > > > On

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > From: Vikhyat Umrao > > Date: Mon, 2 May 2016 21:47:31 +0530 > >

Re: [Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init

On Thu, May 05, 2016 at 11:05:27AM +, Catalin Vasile wrote: > When the virtio-net and virtio-scsi drivers have done the probe() primitive > they set the DRIVER_OK flag. > > If the vhost kernel backend is used, the set_status() primitive in qemu will > be triggered with DRIVER_OK status and

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > From: Vikhyat Umrao > Date: Mon, 2 May 2016 21:47:31 +0530 > Subject: [PATCH] rbd:change error_setg() to error_setg_errno() > > Ceph RBD

Re: [Qemu-devel] TCP Segementation Offloading

On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: > Good Mayday Qemu Developers, > > today I tried to find a reference to a networking problem, that seems to be > of quite general nature: TCP Segmentation Offloading (TSO) in virtual > environments. > > When I setup TAP network

Re: [Qemu-devel] [Qemu-Devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

On Thu, Mar 24, 2016 at 12:02:03AM +0530, Md Haris Iqbal wrote: > Signed-off-by: Md Haris Iqbal > --- > linux-user/qemu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 6:04 PM, Michael S. Tsirkin wrote: > On Thu, May 05, 2016 at 05:27:03PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin wrote: >> > On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: >> >> On Thu,

Re: [Qemu-devel] [PATCH] gdbstub: avoid busy loop while waiting for gdb

On 3 May 2016 at 23:58, Peter Wu wrote: > While waiting for a gdb response, or while sending an acknowledgement > there is not much to do, so just mark the socket as non-blocking to > avoid a busy loop while paused at gdb. This only affects the user-mode > emulation (qemu-arm

Re: [Qemu-devel] [PATCH] disas/microblaze: Add missing 'const' attributes

On Wed, Apr 06, 2016 at 12:01:17PM +0200, Stefan Weil wrote: > Am 06.04.2016 um 11:16 schrieb Edgar E. Iglesias: > > On Tue, Mar 22, 2016 at 08:31:33AM +0100, Stefan Weil wrote: > >> Making the opcode list 'const' saves memory. > >> Some function arguments and local variables needed 'const', too.

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer

On Thu, May 05, 2016 at 10:48:57PM +0800, Chen Gang wrote: > On 5/5/16 00:05, Peter Maydell wrote: > > On 29 March 2016 at 15:13, wrote: > >> From: Chen Gang > >> > >> The return address is in target space, so the restorer address needs to >

[Qemu-devel] [PATCH v4 1/1] target-arm: A64: Create Instruction Syndromes for Data Aborts

From: "Edgar E. Iglesias" Add support for generating the ISS (Instruction Specific Syndrome) for Data Abort exceptions taken from AArch64. These syndromes are used by hypervisors for example to trap and emulate memory accesses. We save the decoded data out-of-band

[Qemu-devel] [PATCH v4 0/1] arm: Steps towards EL2 support round 6

From: "Edgar E. Iglesias" Hi, Another round of patches towards EL2 support. This one adds partial Instruction Syndrome generation for Data Aborts while running in AArch64. I don't feel very confident with the way I collect the regsize info used to fill out the SF

Re: [Qemu-devel] [PATCH] gdbstub: avoid busy loop while waiting for gdb

On Thu, May 05, 2016 at 04:37:40PM +0100, Peter Maydell wrote: > On 3 May 2016 at 23:58, Peter Wu wrote: > > While waiting for a gdb response, or while sending an acknowledgement > > there is not much to do, so just mark the socket as non-blocking to > > avoid a busy loop

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 05, 2016 at 05:27:03PM +0200, Ladi Prosek wrote: > On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin wrote: > > On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: > >> On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin wrote: > >> > On

Re: [Qemu-devel] [PATCH v3 7/7] target-arm: A64: Create Instruction Syndromes for Data Aborts

On Wed, May 04, 2016 at 06:38:49PM +0100, Peter Maydell wrote: > On 29 April 2016 at 13:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add support for generating the instruction syndrome for Data Aborts. > > These syndromes

[Qemu-devel] [PATCH] libqos: add qvirtqueue_cleanup()

qvirtqueue_setup() allocates the vring and virtqueue state. So far there has been no function to free it. Callers have been using guest_free() for the vring but forgot to free the QVirtQueue state. This patch solves the memory leak by introducing qvirtqueue_cleanup(). Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer

On 5/5/16 00:05, Peter Maydell wrote: > On 29 March 2016 at 15:13, wrote: >> From: Chen Gang >> >> The return address is in target space, so the restorer address needs to >> be target space, too. >> >> Signed-off-by: Chen Gang

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

On 05/05/16 18:25, Sergey Fedorov wrote: > On 05/05/16 18:03, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> On 05/04/16 18:32, Alex Bennée wrote: diff --git a/exec.c b/exec.c index f46e596..17f390e 100644 --- a/exec.c +++ b/exec.c @@ -826,6

Re: [Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

* Daniel P. Berrange (berra...@redhat.com) wrote: > This series of patches provides a framework for testing migration performance > characteristics. The motivating factor for this is planning that is underway > in OpenStack wrt making use of QEMU migration features such as compression, >

Re: [Qemu-devel] [PATCH] gdbstub: avoid busy loop while waiting for gdb

On 3 May 2016 at 23:58, Peter Wu wrote: > While waiting for a gdb response, or while sending an acknowledgement > there is not much to do, so just mark the socket as non-blocking to > avoid a busy loop while paused at gdb. This only affects the user-mode > emulation (qemu-arm

Re: [Qemu-devel] [PATCH v2 1/4] adb-keys.h - initial commit

On 5 May 2016 at 15:58, Programmingkid wrote: > Thank you for reviewing my patch. Just to sure, you want me to send > another patch that has the note removed? If that is the case, I give > you full permission to delete the note. That would definitely save us > some

Re: [Qemu-devel] [PATCH v2 4/4] adb.c: add power key support

On 24 March 2016 at 14:07, Programmingkid wrote: > Add support for the power key. It has to be handled differently from the other > keys because it is the only 16-bit value key. > > Signed-off-by: John Arbuckle > --- > hw/input/adb.c | 32

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin wrote: > On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin wrote: >> > On Thu, May 05, 2016 at 04:59:13PM +0200, Ladi Prosek wrote: >> >> On Thu,

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

On 05/05/16 18:03, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 05/04/16 18:32, Alex Bennée wrote: >>> diff --git a/exec.c b/exec.c >>> index f46e596..17f390e 100644 >>> --- a/exec.c >>> +++ b/exec.c >>> @@ -826,6 +826,7 @@ int cpu_breakpoint_insert(CPUState *cpu,

Re: [Qemu-devel] [PATCH v2 3/4] adb.c: NO_KEY

On 24 March 2016 at 14:06, Programmingkid wrote: > Sets keys that are not supported by ADB to an unusable value of 0xff. > > Signed-off-by: John Arbuckle > --- > hw/input/adb.c | 32 +++- > 1 file changed, 19

Re: [Qemu-devel] [PATCH v2 2/4] adb.c: add support for QKeyCode

On 24 March 2016 at 14:09, Programmingkid wrote: > The old pc scancode translation is replaced with QEMU's QKeyCode. > > Signed-off-by: John Arbuckle > --- > *v2 changes > Changed order of this patch. I wrote a quick test program to check

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: > On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin wrote: > > On Thu, May 05, 2016 at 04:59:13PM +0200, Ladi Prosek wrote: > >> On Thu, May 5, 2016 at 3:36 PM, Michael S. Tsirkin wrote: > >> > On

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin wrote: > On Thu, May 05, 2016 at 04:59:13PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 3:36 PM, Michael S. Tsirkin wrote: >> > On Thu, May 05, 2016 at 11:13:37AM +0200, Ladi Prosek wrote: >> >> There is

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

Sergey Fedorov writes: > On 05/04/16 18:32, Alex Bennée wrote: >> diff --git a/exec.c b/exec.c >> index f46e596..17f390e 100644 >> --- a/exec.c >> +++ b/exec.c >> @@ -826,6 +826,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int >> flags, >> { >>

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 05, 2016 at 04:59:13PM +0200, Ladi Prosek wrote: > On Thu, May 5, 2016 at 3:36 PM, Michael S. Tsirkin wrote: > > On Thu, May 05, 2016 at 11:13:37AM +0200, Ladi Prosek wrote: > >> There is a discrepancy between dataplane and no-dataplane virtio > >> behavior with

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 3:36 PM, Michael S. Tsirkin wrote: > On Thu, May 05, 2016 at 11:13:37AM +0200, Ladi Prosek wrote: >> There is a discrepancy between dataplane and no-dataplane virtio >> behavior with respect to the ISR status register and MSI-X >> capability. >> >> Without

Re: [Qemu-devel] [PATCH v2 1/4] adb-keys.h - initial commit

On May 5, 2016, at 10:54 AM, Peter Maydell wrote: > On 24 March 2016 at 14:03, Programmingkid wrote: >> Add the adb-keys.h file. It maps ADB transition key codes with values. >> >> Signed-off-by: John Arbuckle >> --- >> *v2 changes: >>

Re: [Qemu-devel] [PATCH v2 1/4] adb-keys.h - initial commit

On 24 March 2016 at 14:03, Programmingkid wrote: > Add the adb-keys.h file. It maps ADB transition key codes with values. > > Signed-off-by: John Arbuckle > --- > *v2 changes: > Changed order of this patch. > > include/hw/input/adb-keys.h |

[Qemu-devel] [PATCH v1 5/6] scripts: ensure monitor socket has SO_REUSEADDR set

If tests use a TCP based monitor socket, the connection will go into a TIMED_WAIT state when the test exits. This will randomly prevent the test from being re-run without a certain time period. Set the SO_REUSEADDR flag on the socket to ensure we can immediately re-run the tests ---

[Qemu-devel] [PATCH v1 6/6] tests: introduce a framework for testing migration performance

This introduces a moderately general purpose framework for testing performance of migration. The initial guest workload is provided by the included 'stress' program, which is configured to spawn one thread per guest CPU and run a maximally memory intensive workload. It will loop over GB of

[Qemu-devel] [PATCH v1 3/6] scripts: refactor the VM class in iotests for reuse

The iotests module has a python class for controlling QEMU processes. Pull the generic functionality out of this file and create a scripts/qemu.py module containing a QEMUMachine class. Put the QTest integration support into a subclass QEMUQtestMachine. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

This series of patches provides a framework for testing migration performance characteristics. The motivating factor for this is planning that is underway in OpenStack wrt making use of QEMU migration features such as compression, auto-converge and post-copy. The primary aim for OpenStack is to

[Qemu-devel] [PATCH v1 2/6] scripts: add a 'debug' parameter to QEMUMonitorProtocol

Add a 'debug' parameter to the QEMUMonitorProtocol class which will cause it to print out all JSON strings on sys.stderr Signed-off-by: Daniel P. Berrange --- scripts/qmp/qmp.py | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v1 4/6] scripts: set timeout when waiting for qemu monitor connection

If QEMU fails to launch for some reason, the QEMUMonitorProtocol class accept() method will wait forever in a socket accept call. Set a timeout of 15 seconds so that we fail more gracefully instead of hanging the test script forever Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PATCH v1 1/6] scripts: add __init__.py file to scripts/qmp/

When searching for modules to load, python will ignore any sub-directory which does not contain __init__.py. This means that both scripts and scripts/qmp/ have to be explicitly added to the python path. By adding a __init__.py file to scripts/qmp, we only need add scripts/ to the python path and

Re: [Qemu-devel] [PATCH v1 1/9] hw/intc: QOM'ify etraxfs_pic.c

On Thu, May 05, 2016 at 06:28:48PM +0800, xiaoqiang zhao wrote: > Drop the old SysBus init function and use instance_init > > Signed-off-by: xiaoqiang zhao Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias >

Re: [Qemu-devel] [PATCH v2 2/3] Add ENET/Gbps Ethernet support to FEC device

On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: > The ENET device (present in i.MX6) is "derived" from FEC and backward > compatible with it. > > This patch add the necessary support of the added feature in the ENET > device to allow Linux to use it (on supported

Re: [Qemu-devel] [V9 0/4] AMD IOMMU

On Wed, May 4, 2016 at 2:05 PM, Valentine Sinitsyn wrote: > On 04.05.2016 16:02, David Kiarie wrote: >> >> >> >> On 04/05/16 13:58, Valentine Sinitsyn wrote: >>> >>> On 04.05.2016 15:51, David Kiarie wrote: On Wed, May 4, 2016 at 10:39 AM, Valentine

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

On 05/04/16 18:32, Alex Bennée wrote: > diff --git a/exec.c b/exec.c > index f46e596..17f390e 100644 > --- a/exec.c > +++ b/exec.c > @@ -826,6 +826,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int > flags, > { > CPUBreakpoint *bp; > > +/* TODO: locking (RCU?) */ > bp =

Re: [Qemu-devel] [PATCH v2 1/3] net: improve UDP/TCP checksum computation.

On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: > This patch adds: > * based on Eth, UDP, TCP struct present in eth.h instead of hardcoded > indexes. > * based on various macros present in eth.h. > * allow to account for optional VLAN header. This is doing

Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices

> 在 2016年5月5日，20:51，Peter Maydell 写道： > >> On 5 May 2016 at 11:38, 赵小强 wrote: >> At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote: >>> This patch set trys to QOM'ify hw/char files, see commit messages >>> for more details >>>

Re: [Qemu-devel] [PATCH v7 0/6] Add i.MX6 (Single/Dual/Quad) support

On 2 April 2016 at 15:29, Jean-Christophe Dubois wrote: > This patch series adds support for the Freescale i.MX6 processor. > > For now we only support the following devices: > * up to 4 Cortex A9 cores > * A9 MPCORE (SCU, GIC, TWD) > * 5 i.MX UARTs > * 2 EPIT timers > * 1

Re: [Qemu-devel] [PATCH v2 3/3] Add ENET device to i.MX6 SOC.

On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: > This adds the ENET device to the i.MX6 SOC. > > This was tested by booting Linux on an Qemu i.MX6 instance and accessing > the internet from the linux guest. > > Signed-off-by: Jean-Christophe Dubois

Re: [Qemu-devel] [PATCH 1/2] migration: Move qjson.[ch] to migration/

* Markus Armbruster (arm...@redhat.com) wrote: > Type QJSON lets you build JSON text. Its interface mirrors (a subset > of) abstract JSON syntax. > > QAPI output visitors also produce JSON text. They assert their > preconditions and invariants, and therefore abort on incorrect use. > >

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

On Wed, May 04, 2016 at 08:44:37PM -0700, Yuanhan Liu wrote: > Hello, > > On Wed, May 04, 2016 at 10:13:49PM +0300, Michael S. Tsirkin wrote: > > How do you avoid it? > > > > > > Management is required to make this robust, auto-reconnect > > > > is handy for people bypassing management. > > > >

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 05, 2016 at 11:13:37AM +0200, Ladi Prosek wrote: > There is a discrepancy between dataplane and no-dataplane virtio > behavior with respect to the ISR status register and MSI-X > capability. > > Without dataplane the Queue interrupt ISR status bit is set > regardless of how the

Re: [Qemu-devel] [PATCH v8 0/5] ARM: Add NUMA support for machine virt

On 26 April 2016 at 12:21, Andrew Jones wrote: > On Tue, Apr 26, 2016 at 06:40:24PM +0800, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Add NUMA support for machine virt. Tested successfully running a guest >> Linux kernel with the following patch

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

On 5/5/2016 5:37 PM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Thursday, May 05, 2016 6:45 PM On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +

Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices

On 5 May 2016 at 11:38, 赵小强 wrote: > At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote: >>This patch set trys to QOM'ify hw/char files, see commit messages >>for more details >> >>Changes in v2: >>* rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is

Re: [Qemu-devel] [Qemu-arm] [PATCH RESEND 4/5] hw/display: QOM'ify milkymist-vgafb.c

On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move graphic_console_init into realize stage > > Signed-off-by: xiaoqiang zhao > --- Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c

On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move tmu2_glx_init into realize stage > > Signed-off-by: xiaoqiang zhao Reviewed-by: Peter Maydell > +static void

Re: [Qemu-devel] [Qemu-arm] [PATCH RESEND 2/5] hw/display: QOM'ify jazz_led.c

On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move graphic_console_init into realize stage > > Signed-off-by: xiaoqiang zhao > --- > hw/display/jazz_led.c | 18 +++--- > 1 file

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, May 05, 2016 6:45 PM > > > On 5/5/2016 2:36 PM, Tian, Kevin wrote: > >> From: Kirti Wankhede > >> Sent: Wednesday, May 04, 2016 9:32 PM > >> > >> Thanks Alex. > >> > >> >> +config VGPU_VFIO > >> >> +tristate > >> >> +

[Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init

When the virtio-net and virtio-scsi drivers have done the probe() primitive they set the DRIVER_OK flag. If the vhost kernel backend is used, the set_status() primitive in qemu will be triggered with DRIVER_OK status and it will trigger vhost_XXX_start(). How does the net and scsi solutions

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

> 在 2016年5月5日，18:46，Peter Maydell 写道： > >> On 5 May 2016 at 11:41, 赵小强 wrote: >> At 2016-05-05 18:39:52, "Peter Maydell" wrote: On 5 May 2016 at 11:28, xiaoqiang zhao wrote: This patch set

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

On 5 May 2016 at 11:41, 赵小强 wrote: > At 2016-05-05 18:39:52, "Peter Maydell" wrote: >>On 5 May 2016 at 11:28, xiaoqiang zhao wrote: >>> This patch set QOM'ify files under hw/intc directory. See each commit >>> message for

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +depends on VGPU >> +default n >> + > > This is a little bit convoluted, it seems like everything added in this > patch is

Re: [Qemu-devel] [RESEND PATCH v2 0/4] QOM'ify hw/audio files

At 2016-03-17 17:06:12, "xiaoqiang zhao" wrote: >This patch set QOM'ify some files under hw/audio directory. >See each patch's commit message for details. > >Changes in v2: >Move AUD_open_in/out function into device realize stage > >Sorry for the misoperation before,

  1   2   >