[Qemu-devel] [Bug 1579306] Re: usb-uas does not work in Windows (10) guest

2016-05-06 Thread Tom Yan
Also tried to "passthrough" the SCSI layer of an actual UASP drive with scsi-block. No luck either. ** Attachment added: "xhci-block.png" https://bugs.launchpad.net/qemu/+bug/1579306/+attachment/4657734/+files/xhci-block.png -- You received this bug notification because you are a member of

[Qemu-devel] [Bug 1579306] Re: usb-uas does not work in Windows (10) guest

2016-05-06 Thread Tom Yan
usb-bot works fine ** Attachment added: "xhci-bot.png" https://bugs.launchpad.net/qemu/+bug/1579306/+attachment/4657732/+files/xhci-bot.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1579306

[Qemu-devel] [Bug 1579306] [NEW] usb-uas does not work in Windows (10) guest

2016-05-06 Thread Tom Yan
Public bug reported: When I attach a "-device usb-uas" to a VM with Windows 10 10586, the device fail to start with the following error in the guest: "The device cannot start. (Code 10) {Operation Failed} The requested operation was unsuccessful" If the host controller is nec-usb-xhci, there

Re: [Qemu-devel] qcow2 resize with snapshots

2016-05-06 Thread zhangzhiming
sorry, i forgot to cc qemu-bl...@nongnu.org . zhangzhiming zhangzhimin...@meituan.com > On May 7, 2016, at 10:47 AM, zhangzhiming wrote: > > thank you for your reply, and i am glad to join to the development of qemu. > i will try my

Re: [Qemu-devel] qcow2 resize with snapshots

2016-05-06 Thread zhangzhiming
thank you for your reply, and i am so sorry, there are some problems with my email @163.com , it returned me some error and i thought that my email send failed. so, really sorry. this is my second email. i will use this one. zhangzhiming zhangzhimin...@meituan.com > On May

Re: [Qemu-devel] qcow2 resize with snapshots

2016-05-06 Thread zhangzhiming
thank you for your reply, and i am glad to join to the development of qemu. i will try my best to finish this new function. have a good day! zhangzhiming zhangzhimin...@meituan.com > On May 3, 2016, at 4:44 PM, Kevin Wolf wrote: > > [ Cc: qemu-block ] > > Am 29.04.2016 um

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-06 Thread Edgar E. Iglesias
On Fri, May 06, 2016 at 11:25:52PM +0100, Peter Maydell wrote: > On 6 May 2016 at 19:11, Alistair Francis wrote: > > Enable EL2 by default for the A53s and A57s. > > > > Signed-off-by: Alistair Francis > > I don't really want to do this

Re: [Qemu-devel] [PATCH v2 1/3] net: improve UDP/TCP checksum computation.

2016-05-06 Thread Peter Maydell
On 6 May 2016 at 21:25, Jean-Christophe DUBOIS wrote: > Le 05/05/2016 16:17, Peter Maydell a écrit : >> >> On 23 April 2016 at 11:58, Jean-Christophe Dubois >> wrote: >>> +if (length < eth_get_l2_hdr_length(data) + sizeof(struct ip_header)) >>> {

Re: [Qemu-devel] [PATCH 1/2] Use libtool instead of ar to create static libraries on Darwin.

2016-05-06 Thread Peter Maydell
On 6 May 2016 at 20:07, Michael Tokarev wrote: > Hmm. We removed libtool support just two moths ago... :) That was GNU libtool, which is a completely different thing from OSX libtool. They just have an unhelpful name clash. thanks -- PMM

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-06 Thread Peter Maydell
On 6 May 2016 at 19:11, Alistair Francis wrote: > Enable EL2 by default for the A53s and A57s. > > Signed-off-by: Alistair Francis I don't really want to do this until we actually have something approaching a workable EL2 implementation

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-06 Thread Richard Henderson
On 05/05/2016 11:41 AM, Emilio G. Cota wrote: This is tempting me to just kill the feature, since resizing works very well. And it would save ~90 lines of code. Is anyone against this? Not I. I think it'll nicely simplify things. r~

Re: [Qemu-devel] [PATCH 52/52] target-m68k: sr/ccr cleanup

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Can this be merged with patch 14, which is also cleaning up these same

Re: [Qemu-devel] [PATCH 51/52] target-m68k: add cmpm

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: +reg = AREG(insn, 0); +src = gen_load(s, opsize, reg, 1); +tcg_gen_addi_i32(reg, reg, opsize_bytes(opsize)); + +reg = AREG(insn, 9); +dest = gen_load(s, opsize, reg, 1); +tcg_gen_addi_i32(reg, reg, opsize_bytes(opsize));

Re: [Qemu-devel] [PATCH 50/52] target-m68k: immediate ops manage word and byte operands

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 57 ++--- 1 file changed, 35 insertions(+), 22 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 49/52] target-m68k: cmp manages word and bytes operands

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 48/52] target-m68k: add/sub manage word and byte operands

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 71 ++--- 1 file changed, 38 insertions(+), 33 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 47/52] target-m68k: add addressing modes to neg

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 46/52] target-m68k: introduce byte and word cc_ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 6 +-- target-m68k/helper.c| 25 + target-m68k/translate.c | 99 ++--- 3 files changed, 80 insertions(+), 50

Re: [Qemu-devel] [PATCH 45/52] target-m68k: suba/adda can manage word operand

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 43/52] target-m68k: or can manage word and byte operands

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 44/52] target-m68k: and can manage word and byte operands

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:21 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 42/52] target-m68k: eor can manage word and byte operands

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:20 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 41/52] target-m68k: add addressing modes to not

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:20 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 40/52] target-m68k: add exg ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:20 AM, Laurent Vivier wrote: +case 0x140: +/* exchange Dx and Dy */ +src = DREG(insn, 9); +reg = DREG(insn, 0); +tcg_gen_mov_i32(dest, src); +tcg_gen_mov_i32(src, reg); +tcg_gen_mov_i32(reg, dest); +break; +case

Re: [Qemu-devel] [PATCH 39/52] target-m68k: movem

2016-05-06 Thread Richard Henderson
A more verbose commit message is required here. On 05/04/2016 11:08 AM, Laurent Vivier wrote: @@ -1724,21 +1726,40 @@ DISAS_INSN(movem) addr = tcg_temp_new(); tcg_gen_mov_i32(addr, tmp); is_load = ((insn & 0x0400) != 0); -for (i = 0; i < 16; i++, mask >>= 1) { -if

Re: [Qemu-devel] [PATCH 38/52] target-m68k: add linkl

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:08 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 37/52] target-m68k: add cas/cas2 ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:08 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- linux-user/main.c | 193 target-m68k/cpu.h | 9 +++ target-m68k/qregs.def | 5 ++ target-m68k/translate.c | 175

[Qemu-devel] [PATCH 3/4] linux_headers: add MSI_X2APIC

2016-05-06 Thread Radim Krčmář
Signed-off-by: Radim Krčmář --- linux-headers/linux/kvm.h | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 3bae71a8743e..3d9ca622bec9 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm.h @@

[Qemu-devel] [PATCH 4/4] kvm: support MSI_X2APIC capability

2016-05-06 Thread Radim Krčmář
The capability alows us to express x2APIC destinations. Signed-off-by: Radim Krčmář --- include/sysemu/kvm.h | 1 + kvm-all.c| 14 +- target-i386/kvm.c| 4 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/include/sysemu/kvm.h

[Qemu-devel] [RFC 0/4] APIC, IOMMU, KVM: add x2APIC interface

2016-05-06 Thread Radim Krčmář
This series bases on Peter's IR v6 and depends on patches that were just posted to kvm-list, "[RFC 0/9] KVM: x86: break the xAPIC barrier". The kernel interface could use your comments, but internal QEMU one is in dire need of them. Please see [1/4]. I have tested the series and seems to work

[Qemu-devel] [PATCH 1/4] apic: add deliver_msi to APICCommonClass

2016-05-06 Thread Radim Krčmář
The only way to send interrupts from outside of APIC devices is to use the MSI-inspired memory mapped interface. The interface is not sufficient because interrupt remapping in extended mode can exceed 8 bit destination ids. The proper way to deliver interrupts would be to design a bus (QPI), but

[Qemu-devel] [PATCH 2/4] intel_iommu: use deliver_msi APIC callback

2016-05-06 Thread Radim Krčmář
The memory-mapped interface cannot express x2APIC destinations that are a result of remapping. Signed-off-by: Radim Krčmář --- hw/i386/intel_iommu.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/hw/i386/intel_iommu.c

Re: [Qemu-devel] [PATCH 36/52] target-m68k: inline shift ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:08 AM, Laurent Vivier wrote: -if (count == 0) { -count = 8; -} +count = ((count - 1) & 0x7) + 1; /* 1..8 */ How is that clearer, or even simpler? +tcg_gen_setcond_i32(TCG_COND_EQ, QREG_CC_V, reg, zero); +/* adjust V: (1,0)

Re: [Qemu-devel] [PATCH 35/52] target-m68k: inline rotate ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:08 AM, Laurent Vivier wrote: +static inline void rotate_x_flags(TCGv reg, int size) +{ +switch (size) { +case 8: +tcg_gen_ext8s_i32(reg, reg); +break; +case 16: +tcg_gen_ext16s_i32(reg, reg); +break; +default: +break; +

Re: [Qemu-devel] [PATCH v2 1/3] net: improve UDP/TCP checksum computation.

2016-05-06 Thread Jean-Christophe DUBOIS
Le 05/05/2016 16:17, Peter Maydell a écrit : On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: This patch adds: * based on Eth, UDP, TCP struct present in eth.h instead of hardcoded indexes. * based on various macros present in eth.h. * allow to account for

Re: [Qemu-devel] [PATCH 34/52] target-m68k: add 64bit mull

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:08 AM, Laurent Vivier wrote: +if (m68k_feature(s->env, M68K_FEATURE_M68000)) { +if (sign) { +tcg_gen_muls2_i32(QREG_CC_N, QREG_CC_V, src1, DREG(ext, 12)); +} else { +tcg_gen_mulu2_i32(QREG_CC_N, QREG_CC_V, src1, DREG(ext, 12)); +

Re: [Qemu-devel] [PATCH 33/52] target-m68k: inline divu/divs

2016-05-06 Thread Richard Henderson
On 05/04/2016 11:08 AM, Laurent Vivier wrote: -void HELPER(divu)(CPUM68KState *env, uint32_t word) -{ -uint32_t num; -uint32_t den; -uint32_t quot; -uint32_t rem; - -num = env->div1; -den = env->div2; -/* ??? This needs to make sure the throwing location is accurate.

Re: [Qemu-devel] [PATCH 32/52] target-m68k: bitfield ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/helper.c| 13 ++ target-m68k/helper.h| 4 + target-m68k/op_helper.c | 68 ++ target-m68k/translate.c | 560 4 files

Re: [Qemu-devel] [PATCH] 9p: drop unused declaration from coth.h

2016-05-06 Thread Michael Tokarev
03.05.2016 11:22, Greg Kurz wrote: > Commit "ebac1202c95a virtio-9p: use QEMU thread pool" dropped function > v9fs_init_worker_threads. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 1/2] Use libtool instead of ar to create static libraries on Darwin.

2016-05-06 Thread Michael Tokarev
Hmm. We removed libtool support just two moths ago... :) /mjt

Re: [Qemu-devel] [PATCH] iotests: fix the redirection order in 083

2016-05-06 Thread Michael Tokarev
26.04.2016 13:13, Wei Jiangang wrote: > It should redirect stdout to /dev/null first, > then redirect stderr to whatever stdout currently points at. Actually this is interesting. By doing this like it was done initially, we see any possible errors from grep or python, because errors will go to

Re: [Qemu-devel] [PATCH] smbios: fix typo

2016-05-06 Thread Michael Tokarev
29.03.2016 12:57, Cao jin wrote: > On 03/29/2016 05:48 PM, Cao jin wrote: >> The spec says: "on paragraph (16-byte) boundaries" (Finally!) applied to -trivial. I'm sorry this took too long. Thanks! /mjt

Re: [Qemu-devel] [PATCH v2] accel: make configure_accelerator return void

2016-05-06 Thread Michael Tokarev
14.04.2016 06:58, Wei Jiangang wrote: > Return the negated value of accel_initialised is meaningless, > and the caller vl doesn't check it. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] configure: Use uniform description for devel packages

2016-05-06 Thread Michael Tokarev
08.04.2016 19:11, Stefan Weil wrote: > As all other devel packages are written in the form "name devel", > use this form for libcap devel and libattr devel, too. (Finally) applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] ipack: Update e-mail address

2016-05-06 Thread Michael Tokarev
23.02.2016 11:44, Alberto Garcia wrote: > I'm not really using the old one anymore. > > Signed-off-by: Alberto Garcia Applied to -trivial, finally. I'm sorry this took so long. Thank you for the patience! /mjt

Re: [Qemu-devel] [PATCH v1] util: fix comment typos

2016-05-06 Thread Michael Tokarev
14.03.2016 12:58, Wei Jiangang wrote: [] (Finally) appiled to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries

2016-05-06 Thread Michael Tokarev
22.03.2016 18:39, Markus Armbruster wrote: > Peter Xu writes: > >> Here we use one g_strdup_printf() to replace the two stack allocated >> array, considering it's more convenient, safe, and as long as it's >> called rarely only when quorum device opens. This will remove the >>

Re: [Qemu-devel] [PATCH] Fix typo in variable name (found and fixed by codespell)

2016-05-06 Thread Michael Tokarev
21.03.2016 21:21, Stefan Weil wrote: [..] (Finally!) applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

2016-05-06 Thread Sergey Fedorov
On 05/04/16 18:32, Alex Bennée wrote: > From: Paolo Bonzini > > softmmu requires more functions to be thread-safe, because translation > blocks can be invalidated from e.g. notdirty callbacks. Probably the > same holds for user-mode emulation, it's just that no one has ever

[Qemu-devel] [PATCH v1 0/2] target-arm: Add support for HSTR_EL2

2016-05-06 Thread Alistair Francis
Now that EL3 is enabled by default for the A53s and A57s I see this error when booting Linux on the ZynqMP board: "Synchronous Abort" handler, esr 0x0200 By adding the HSTR_EL2 register (and EL2 support) the Linux boot progresses much further. Alistair Francis (2): target-arm: Add the

[Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-06 Thread Eduardo Habkost
Extend query-cpu-definitions schema to allow it to return two new optional fields: "runnable" and "unavailable-features". "runnable" will tell if the CPU model can be run in the current host. "unavailable-features" will contain a list of CPU properties that are preventing the CPU model from

[Qemu-devel] [PATCH v1 1/2] target-arm: Add the HSTR_EL2 register

2016-05-06 Thread Alistair Francis
Add the Hypervisor System Trap Register for EL2. This register is used early in the Linux boot and without it the kernel aborts with a "Synchronous Abort" error. Signed-off-by: Alistair Francis --- target-arm/helper.c | 7 +++ 1 file changed, 7 insertions(+)

[Qemu-devel] [PATCH 6/9] target-i386: Define CPUID filtering functions before x86_cpu_list()

2016-05-06 Thread Eduardo Habkost
Just move code to another place so the it can be reused by the query-cpu-definitions code. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git

[Qemu-devel] [PATCH 5/9] target-i386: Move warning code outside x86_cpu_filter_features()

2016-05-06 Thread Eduardo Habkost
x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 28

[Qemu-devel] [PATCH 9/9] target-i386: Return runnability information on query-cpu-definitions

2016-05-06 Thread Eduardo Habkost
Fill the "runnable" and "unavailable-features" fields on the x86 implementation of query-cpu-definitions. Example command output: { "return": [ { "runnable": true, "name": "host"}, { "runnable": true, "name": "qemu64"}, { "runnable": true, "name": "qemu32"},

[Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-06 Thread Alistair Francis
Enable EL2 by default for the A53s and A57s. Signed-off-by: Alistair Francis --- target-arm/cpu64.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 1635deb..59a2042 100644 --- a/target-arm/cpu64.c +++

[Qemu-devel] [PATCH 4/9] target-i386: List CPU models using subclass list

2016-05-06 Thread Eduardo Habkost
Instead of using the builtin_x86_defs array, use the QOM subclass list to list CPU models on "-cpu ?" and "query-cpu-definitions". Signed-off-by: Andreas Färber [ehabkost: copied code from a patch by Andreas: "target-i386: QOM'ify CPU", from March 2012] Signed-off-by: Eduardo

[Qemu-devel] [PATCH 1/9] target-i386: Move TCG initialization check to tcg_x86_init()

2016-05-06 Thread Eduardo Habkost
Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 +--- target-i386/translate.c | 6 ++ 2

[Qemu-devel] [PATCH 2/9] target-i386: Move TCG initialization to realize time

2016-05-06 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Move TCG initialization to realize time so it won't be called when just doing object_new() on a X86CPU subclass.

[Qemu-devel] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize

2016-05-06 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done

[Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

2016-05-06 Thread Eduardo Habkost
This makes the feature name tables in feature_word_info all match the actual QOM property names we use. This will make the command-line interface more consistent, allowing the QOM property names to be used as "-cpu" arguments directly. Add extra feat2prop() calls to x86_cpu_parse_featurestr() to

[Qemu-devel] [PATCH 0/9] Add runnability info to query-cpu-definitions

2016-05-06 Thread Eduardo Habkost
This series extends query-cpu-definitions to include two extra fields: "runnable", and "unavailable-features". This will return information based on the current machine and accelerator only. In the future we may extend these mechanisms to allow querying other machines and other accelerators

[Qemu-devel] [PATCH 08/10] configure: support vte-2.91

2016-05-06 Thread Cole Robinson
vte >= 0.37 expores API version 2.91, which is where all the active development is. qemu builds and runs fine with that version, so use it if it's available. Signed-off-by: Cole Robinson --- configure | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 02/10] ui: sdl2: Release grab before opening console window

2016-05-06 Thread Cole Robinson
sdl 2.0.4 currently has a bug which causes our UI shortcuts to fire rapidly in succession: https://bugzilla.libsdl.org/show_bug.cgi?id=3287 It's a toss up whether ctrl+alt+f or ctrl+alt+2 will fire an odd or even number of times, thus determining whether the action succeeds or fails. Opening

[Qemu-devel] [PATCH 10/10] ui: gtk: Fix some deprecation warnings

2016-05-06 Thread Cole Robinson
All device manager APIs are deprecated now. Much of our usage is just to get the current pointer, so centralize that logic and use the new seat APIs Signed-off-by: Cole Robinson --- The remaining warnings look like they'll take a bit more effort ui/gtk.c | 20

[Qemu-devel] [PATCH 06/10] configure: report GTK version

2016-05-06 Thread Cole Robinson
Signed-off-by: Cole Robinson --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 76600f4..55bd354 100755 --- a/configure +++ b/configure @@ -2157,6 +2157,7 @@ if test "$gtk" != "no"; then if $pkg_config

[Qemu-devel] [PATCH 09/10] ui: gtk: Fix a runtime warning on vte >= 0.37

2016-05-06 Thread Cole Robinson
inner-border was dropped in vte API 2.91, in favor of the standard padding style Signed-off-by: Cole Robinson --- ui/gtk.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 9876d89..d156c8a 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@

[Qemu-devel] [PATCH 04/10] configure: error on unknown --with-sdlabi value

2016-05-06 Thread Cole Robinson
I accidentally tried --with-sdlabi="1.0", and it failed much later in a weird way. Instead, throw an error if the value isn't in our whitelist. Signed-off-by: Cole Robinson --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure

[Qemu-devel] [PATCH 01/10] ui: gtk: fix crash when terminal inner-border is NULL

2016-05-06 Thread Cole Robinson
VTE terminal inner-border can be NULL. The vte-0.36 (API 2.90) code checks for the condition too so I assume it's not just a bug Fixes a crash on Fedora 24 with gtk 3.20 Signed-off-by: Cole Robinson --- ui/gtk.c | 10 ++ 1 file changed, 6 insertions(+), 4

[Qemu-devel] [PATCH 05/10] configure: add echo_version helper

2016-05-06 Thread Cole Robinson
Simplifies printing library versions, dependent on if the library was even found Signed-off-by: Cole Robinson --- configure | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 8e25a24..76600f4 100755 ---

[Qemu-devel] [PATCH 00/10] ui: gtk and sdl2 fixes

2016-05-06 Thread Cole Robinson
gtk and sdl2 are nearly unusable on Fedora 24 at the moment. The first two patches fix the worst issues. The remaining patches are just extra bits that came about while I was digging into this. Thanks, Cole Cole Robinson (10): ui: gtk: fix crash when terminal inner-border is NULL ui: sdl2:

[Qemu-devel] [PATCH 03/10] configure: build SDL if only SDL2 available

2016-05-06 Thread Cole Robinson
Right now if SDL2 is installed but not SDL1, default configure will entirely disable SDL. Check upfront for SDL2 using pkg-config, but still prefer SDL1 if both versions are installed. Signed-off-by: Cole Robinson --- configure | 12 +++- 1 file changed, 11

[Qemu-devel] [PATCH 07/10] configure: report SDL version

2016-05-06 Thread Cole Robinson
Signed-off-by: Cole Robinson --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 55bd354..22cf55c 100755 --- a/configure +++ b/configure @@ -2448,10 +2448,10 @@ fi if $pkg_config $sdlname --exists; then

Re: [Qemu-devel] [PATCH v9 05/11] block: allow block jobs in any arbitrary node

2016-05-06 Thread John Snow
On 05/06/2016 06:00 AM, Alberto Garcia wrote: > On Fri 29 Apr 2016 05:00:57 PM CEST, Kevin Wolf wrote: > >>> - Block jobs can now be identified by the node name of their >>> BlockDriverState in addition to the device name. Since both device >>> and node names live in the same namespace there's

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

2016-05-06 Thread Janne Karhunen
On Fri, May 6, 2016 at 2:05 PM, Kevin Wolf wrote: >> >> Reviewed-by: Fam Zheng > > Thanks, applied to block-next. Great, thanks everyone! -- Janne

Re: [Qemu-devel] [PATCH 30/52] target-m68k: add scc/dbcc

2016-05-06 Thread Andreas Schwab
Richard Henderson writes: > On 05/04/2016 10:12 AM, Laurent Vivier wrote: >> +DEST_EA(env, insn, OS_BYTE, dest, NULL); >> +tcg_temp_free(dest); >> +} >> + >> +DISAS_INSN(dbcc) >> +{ >> +TCGLabel *l1; >> +TCGv reg; >> +TCGv tmp; >> +int16_t offset; >> +

Re: [Qemu-devel] [PATCH 19/52] target-m68k: terminate cpu dump with newline

2016-05-06 Thread Andreas Schwab
Laurent Vivier writes: > From: Andreas Schwab > > Signed-off-by: Andreas Schwab > Signed-off-by: Laurent Vivier > --- > target-m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Qemu-devel] [PATCH v7 02/19] block: Switch blk_read_unthrottled() to byte interface

2016-05-06 Thread Eric Blake
Sector-based blk_read() should die; convert the one-off variant blk_read_unthrottled(). Signed-off-by: Eric Blake --- include/sysemu/block-backend.h | 4 ++-- block/block-backend.c | 8 hw/block/hd-geometry.c | 2 +- 3 files changed, 7 insertions(+),

Re: [Qemu-devel] [PATCH 31/52] target-m68k: some bit ops cleanup

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 30/52] target-m68k: add scc/dbcc

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index

Re: [Qemu-devel] [PATCH 29/52] target-m68k: factorize flags computing

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: + +#define COMPUTE_CCR(op, x, n, z, v, c) { \ +switch (op) { \ +case CC_OP_FLAGS: \ Please do

Re: [Qemu-devel] [PATCH 28/52] target-m68k: add addx/subx/negx ops

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: +tcg_gen_or_i32(QREG_CC_Z, QREG_CC_Z, QREG_CC_N); /* !Z is sticky */ +gen_ext(QREG_CC_Z, QREG_CC_Z, opsize, 0); Extending Z after the OR is a bug. The (old) high bits of Z might be set from a previous word operation (i.e. !Z) which is

Re: [Qemu-devel] TCP Segementation Offloading

2016-05-06 Thread Stefan Hajnoczi
On Fri, May 06, 2016 at 06:34:33AM +0200, Ingo Krabbe wrote: > > On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: > >> Good Mayday Qemu Developers, > >> > >> today I tried to find a reference to a networking problem, that seems to > >> be of quite general nature: TCP Segmentation

Re: [Qemu-devel] [PATCH v4 5/6] qemu-io: Add 'open -u' to set BDRV_O_UNMAP after the fact

2016-05-06 Thread Eric Blake
On 05/06/2016 10:21 AM, Eric Blake wrote: > On 05/06/2016 10:08 AM, Max Reitz wrote: >> On 05.05.2016 05:42, Eric Blake wrote: >>> When opening a file from the command line, qemu-io defaults >>> to BDRV_O_UNMAP but allows -d to give full control to disable >>> unmaps. But when opening via the

[Qemu-devel] [PATCH v7 15/19] atapi: Switch to byte-based block access

2016-05-06 Thread Eric Blake
Sector-based blk_read() should die; switch to byte-based blk_pread() instead. Add new defines ATAPI_SECTOR_BITS and ATAPI_SECTOR_SIZE to use anywhere we were previously scaling BDRV_SECTOR_* by 4, for better legibility. Signed-off-by: Eric Blake --- v4: add new defines for

Re: [Qemu-devel] [PATCH 26/52] target-m68k: Inline shifts

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: From: Richard Henderson Signed-off-by: Richard Henderson fix arithmetical/logical switch Signed-off-by: Laurent Vivier --- target-m68k/helper.c| 52 ---

Re: [Qemu-devel] [PATCH 21/52] target-m68k: Reorg flags handling

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:12 AM, Laurent Vivier wrote: From: Richard Henderson Separate all ccr bits. Continue to batch updates via cc_op. Signed-off-by: Richard Henderson Fix gen_logic_cc() to really extend the size of the result. Fix gen_get_ccr(): update cc_op

Re: [Qemu-devel] [PATCH 18/52] target-m68k: Some fixes to SR and flags management

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: -uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) +static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) { int flags; uint32_t src; @@ -271,6 +271,18 @@ set_x: return flags; } +uint32_t

Re: [Qemu-devel] [PATCH 19/52] target-m68k: terminate cpu dump with newline

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: From: Andreas Schwab Signed-off-by: Andreas Schwab Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [Qemu-devel] [PATCH 13/52] target-m68k: update CPU flags management

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Copied from target-i386 Signed-off-by: Laurent Vivier --- cpu-exec.c | 6 -- target-m68k/cpu-qom.h | 4 target-m68k/cpu.c | 2 -- target-m68k/cpu.h | 1 + target-m68k/helper.c| 20

Re: [Qemu-devel] [PATCH 16/52] target-m68k: update CPU flags management

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Copied from target-i386 Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 5 +- target-m68k/translate.c | 121 +--- 2 files changed, 86 insertions(+), 40 deletions(-)

Re: [Qemu-devel] [PATCH 15/52] target-m68k: don't update cc_dest in helpers

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 1 - target-m68k/helper.c| 28 ++-- target-m68k/helper.h| 2 +- target-m68k/translate.c | 4 ++-- 4 files changed, 17 insertions(+),

Re: [Qemu-devel] [PATCH 14/52] target-m68k: update move to/from ccr/sr

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 53 - 1 file changed, 22 insertions(+), 31 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 11/52] target-m68k: allow to update flags with operation on words and bytes

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 14 - target-m68k/helper.c| 139 ++-- target-m68k/translate.c | 82 ++-- 3 files changed,

[Qemu-devel] [Bug 1578192] Re: GTK+ interface doesn't translate keycodes properly with Wayland backend

2016-05-06 Thread wyzu
So here's my admittedly quick and dirty solution. This patch adds support for evdev keycodes using translate_evdev_keycode when GDK_WINDOWING_WAYLAND is defined. Affected functions: ui/gtk.c:gd_set_keycode_type ui/gtk.c:gd_map_keycode The caveat with this patch is that I don't see any good way

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

2016-05-06 Thread Max Reitz
On 01.04.2016 19:49, Olaf Hering wrote: > On Fri, Apr 01, Max Reitz wrote: > >> In any case, do you have a test case where a guest was able to submit a >> request that led to the overflow error you described in the commit message? > > mkfs -t ext4 /dev/sdb1 in a xen guest with qcow2 as backing

Re: [Qemu-devel] [PATCH 10/52] target-m68k: REG() macro cleanup

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 09/52] target-m68k: set PAGE_BITS to 12 for m68k

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 08/52] target-m68k: define operand sizes

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 8 target-m68k/translate.c | 46 ++ 2 files changed, 22 insertions(+), 32 deletions(-) Reviewed-by: Richard

Re: [Qemu-devel] [PATCH 07/52] target-m68k: add bkpt instruction

2016-05-06 Thread Richard Henderson
On 05/04/2016 10:11 AM, Laurent Vivier wrote: +INSN(bkpt, 4848, fff8, M68000); Do we care that this comes in with 68010 not 68000? Otherwise, Reviewed-by: Richard Henderson r~

  1   2   3   >