Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 15:20:51 +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 13:04:23 +0200 > Peter Krempa wrote: > > > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > > I don't think we should do that, unless users already had time to > > > update

Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, 12 May 2016 13:04:23 +0200 Peter Krempa wrote: > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > I don't think we should do that, unless users already had time to > > update their scripts and libvirt had time to implement code > > supporting the new

Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties

On Fri, Jan 29, 2016 at 12:15:12PM -0200, Eduardo Habkost wrote: > On Thu, Jan 28, 2016 at 07:01:12PM +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 28, 2016 at 01:02:26PM -0200, Eduardo Habkost wrote: > > > If the same GlobalProperty struct is registered twice, the list > > > entry gets

[Qemu-devel] [Bug 1455475] Re: Block Commit: [100 %]error: failed to pivot job for disk vda

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ubuntu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1455475 Title: Block

[Qemu-devel] [Bug 1455475] Re: Block Commit: [100 %]error: failed to pivot job for disk vda

** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1455475 Title: Block Commit: [100 %]error: failed to pivot job for disk vda

Re: [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was Re: [PATCH] target-i386: add Skylake-Client cpu mode)

On 12/05/2016 14:03, Eduardo Habkost wrote: > > Item number 2 on the other hand means that it's okay to add Skylake CPU > > models without XSAVES. Because of the large number of kernels in the > > wild that block XSAVES, I'm inclined to do that. > > Agreed. Now, should we name the CPU model

Re: [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was Re: [PATCH] target-i386: add Skylake-Client cpu mode)

On Mon, May 09, 2016 at 03:44:57PM +0200, Paolo Bonzini wrote: [...] > 2) KVM doesn't yet expose any XSAVES state save component, and the only > one defined in Skylake (processor tracing) probably will block migration > and will have to be added separately. > [...] > Item number 2 on the other

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

On Mon, May 09, 2016 at 06:44:00PM +0200, Aurelien Jarno wrote: > Recent versions of GCC report the following error when compiling > target-mips/helper.c: > > qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length > equal to number of elements without multiplication by element

Re: [Qemu-devel] [PATCH v2 1/2] exec: [tcg] Track which vCPU is performing translation and execution

On 11/05/2016 21:55, Lluís Vilanova wrote: > > diff --git a/translate-all.c b/translate-all.c > index 8329ea6..1c16b14 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -1092,6 +1092,8 @@ TranslationBlock *tb_gen_code(CPUState *cpu, > ti = profile_getclock(); > #endif > > +

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

On 12/05/2016 13:25, Paolo Bonzini wrote: >> > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, >> > r->sector, >> > scsi_dma_complete, r); > This is broken, it should be changed to an offset in the previous patch. > > Please rename the

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

On 06/05/2016 18:26, Eric Blake wrote: > @@ -340,11 +338,12 @@ static void scsi_do_read(SCSIDiskReq *r, int ret) > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, r->sector, > scsi_dma_complete, r); This is broken, it should be changed to

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Thu, May 12, 2016 at 09:19:48AM +0200, Jiri Denemark wrote: > On Wed, May 11, 2016 at 16:35:50 -0300, Eduardo Habkost wrote: > > # @CpuDefinitionInfo: > > # > > # Virtual CPU definition. > > # > > # @name: the name of the CPU definition > > # @runnable: #optional. whether the CPU model us

Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > I don't think we should do that, unless users already had time to > update their scripts and libvirt had time to implement code > supporting the new method. > > I believe libvirt (and people's scripts) use maxcpus only when > they

Re: [Qemu-devel] [PATCH v3] linux-user: add option to intercept execve() sys

Hi Petros, I'm sorry for the off-thread reply (I'm not subscribed at qemu-devel so please CC me in your replies). I believe that we should modify the envp array in order to include the Qemu-related variables that a user might define: >+return get_errno(execve(qemu_execve_path, new_argp,

Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 12:29:55PM +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 10:07:03 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, May 11, 2016 at 08:28:59PM -0300, Eduardo Habkost wrote: > > > On Thu, May 12, 2016 at 12:51:55AM +0300, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, 12 May 2016 10:05:54 +0300 "Michael S. Tsirkin" wrote: > On Wed, May 11, 2016 at 08:36:00PM -0300, Eduardo Habkost wrote: > > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > > On Tue, 10 May 2016 17:24:14 -0300 > > > Eduardo Habkost

Re: [Qemu-devel] [PATCH for 2.7 v3 1/1] qcow2: improve qcow2_co_write_zeroes()

Am 12.05.2016 um 11:00 hat Denis V. Lunev geschrieben: > On 05/11/2016 02:28 PM, Kevin Wolf wrote: > >Am 11.05.2016 um 09:00 hat Denis V. Lunev geschrieben: > >>There is a possibility that qcow2_co_write_zeroes() will be called > >>with the partial block. This could be synthetically triggered with

Re: [Qemu-devel] [PATCH for 2.7 v3 1/1] qcow2: improve qcow2_co_write_zeroes()

On 05/11/2016 02:28 PM, Kevin Wolf wrote: Am 11.05.2016 um 09:00 hat Denis V. Lunev geschrieben: There is a possibility that qcow2_co_write_zeroes() will be called with the partial block. This could be synthetically triggered with qemu-io -c "write -z 32k 4k" and can happen in the real

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

On Thu, 12 May 2016 11:09:02 +0100 Stefan Hajnoczi wrote: > On Tue, May 10, 2016 at 01:55:10PM +0200, Petr Tesarik wrote: > > On Tue, 10 May 2016 10:56:42 +0100 > > Stefan Hajnoczi wrote: > > > > > On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik

Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, 12 May 2016 10:07:03 +0300 "Michael S. Tsirkin" wrote: > On Wed, May 11, 2016 at 08:28:59PM -0300, Eduardo Habkost wrote: > > On Thu, May 12, 2016 at 12:51:55AM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > >

[Qemu-devel] [PATCH v3 2/3] exec: adjust rcu_read_lock requirement

qemu_ram_unset_idstr() doesn't need rcu lock anymore, meanwhile make the range of rcu lock in qemu_ram_set_idstr() as small as possible. Signed-off-by: Gonglei --- exec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/exec.c b/exec.c index

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

On Tue, May 10, 2016 at 01:55:10PM +0200, Petr Tesarik wrote: > On Tue, 10 May 2016 10:56:42 +0100 > Stefan Hajnoczi wrote: > > > On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: > > > On Mon, 9 May 2016 09:52:28 -0600 > > > Eric Blake wrote:

[Qemu-devel] [PATCH v3 3/3] memory: drop some wrappers that waste cpu cycle

For better performance, we can use RAMblock directly stored in memory_region at present. Signed-off-by: Gonglei --- exec.c | 33 ++--- hw/misc/ivshmem.c | 8 +--- hw/virtio/vhost-user.c | 13 -

[Qemu-devel] [PATCH v3 0/3] memory: some little optimizations

Please see the details in each patch. v3 -> v2: - rebase on the master - resend because Delivery has failed to these recipients or groups: qemu-devel@nongnu.org v2 -> v1: - rework an argument's name for clearity in patch 1. [Fam] - fix some typos in patch 2. [Fam] - touche block->fd

[Qemu-devel] [PATCH v3 1/3] memory: drop find_ram_block()

On the one hand, we have already qemu_get_ram_block() whose function is similar. On the other hand, we can directly use mr->ram_block but searching RAMblock by ram_addr which is a kind of waste. Signed-off-by: Gonglei Reviewed-by: Fam Zheng --- exec.c

[Qemu-devel] [PATCH v2 2/2] spice: fix coverity complains

Remove the unnecessary NULL check. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini --- ui/spice-display.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 242ab5f..1ffbec1 100644

[Qemu-devel] [PATCH v2 1/2] egl-helpers: fix possible resource leak

CID 1352419, using g_strdup_printf instead of asprintf. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini --- ui/egl-helpers.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index

[Qemu-devel] [PATCH v2 0/2] fix coverity complaint

Rebase on the latest master brunch. Gonglei (2): egl-helpers: fix possible resource leak spice: fix coverity complains ui/egl-helpers.c | 9 +++-- ui/spice-display.c | 4 +--- 2 files changed, 4 insertions(+), 9 deletions(-) -- 1.7.12.4

[Qemu-devel] [PATCH] virtio-pci: warn when both legacy and modern modes are disabled

Without presuming if we got there because of a user mistake or some more subtile bug in the tooling, it doesn't hurt to log somewhere that the device won't be functional. Signed-off-by: Greg Kurz --- hw/virtio/virtio-pci.c |4 1 file changed, 4 insertions(+)

Re: [Qemu-devel] [PATCH v2] rfifolock: no need to get thread identifier when nesting

On Tue, May 10, 2016 at 05:59:08PM +0800, Changlong Xie wrote: > Signed-off-by: Changlong Xie > --- > util/rfifolock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan

Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h

On Thu, May 12, 2016 at 02:39:50PM +0530, Ashi wrote: > On Wednesday 04 May 2016 02:09 PM, Daniel P. Berrange wrote: > > On Tue, May 03, 2016 at 11:43:58PM +0530, Ashi wrote: > > > > > > > > > On Tuesday 03 May 2016 07:31 PM, Daniel P. Berrange wrote: > > > > On Tue, May 03, 2016 at 07:04:17PM

Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h

On Wednesday 04 May 2016 02:09 PM, Daniel P. Berrange wrote: On Tue, May 03, 2016 at 11:43:58PM +0530, Ashi wrote: On Tuesday 03 May 2016 07:31 PM, Daniel P. Berrange wrote: On Tue, May 03, 2016 at 07:04:17PM +0530, Ashijeet Acharya wrote: From: Ashijeet

Re: [Qemu-devel] [PATCH v2 for-2.7 00/20] First batch of s390x patches

On 05/11/2016 04:57 PM, Cornelia Huck wrote: > Hi, > > here's an update of the s390x patches I have queued for 2.7. > > Changes from v1: > - Avoid the 'IplBlockCcw fcp;' error in patch 3 from the start > instead of fixing it in a later patch (as noted by Christian) > - Add Xiaoqiang Zhao's

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

On 05/12/2016 04:07 PM, Jason Wang wrote: On 2016年05月12日 14:33, Zhang Chen wrote: +ret = net_fill_rstate(>rs, buf, size); + +if (ret == -1) { +goto eoc; +} else if (ret == 1) { +if (qemu_send_packet_async(>nc, s->rs.buf, +

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

Hi, Kirti/Neo, any response for below comment? > From: Tian, Kevin > Sent: Wednesday, May 04, 2016 10:59 AM > > > From: Alex Williamson > > Sent: Wednesday, May 04, 2016 6:44 AM > > > +/** > > > + * struct gpu_device_ops - Structure to be registered for each physical > > > GPU to > > > + *

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

On 2016年05月12日 14:33, Zhang Chen wrote: +ret = net_fill_rstate(>rs, buf, size); + +if (ret == -1) { +goto eoc; +} else if (ret == 1) { +if (qemu_send_packet_async(>nc, s->rs.buf, + s->rs.packet_len, + net_socket_send_completed) ==

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

On 05/12/2016 04:01 PM, Jason Wang wrote: On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", +

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

On Thu, 12 May 2016 09:40:21 +0200 Christian Borntraeger wrote: > Maybe a topic for this years QEMU summit could be to talk about > release process and release criterias. +1 to that. > We could > a: allow more patches , e.g. I thing that this patch would be have >

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

On 05/12/2016 10:06 AM, Cornelia Huck wrote: > On Thu, 12 May 2016 09:40:21 +0200 > Christian Borntraeger wrote: > >> Maybe a topic for this years QEMU summit could be to talk about >> release process and release criterias. > > +1 to that. > >> We could >> a: allow

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

On 12 May 2016 at 08:40, Christian Borntraeger wrote: > Maybe a topic for this years QEMU summit could be to talk about > release process and release criterias. Yeah, I'm happy to talk about what we could do better with releases (both on the mailing list and at the

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, May 12, 2016 6:06 AM > > On Wed, 11 May 2016 17:15:15 +0800 > Jike Song wrote: > > > On 05/11/2016 12:02 AM, Neo Jia wrote: > > > On Tue, May 10, 2016 at 03:52:27PM +0800, Jike Song wrote: > > >>

[Qemu-devel] [PULL 19/23] qapi: Split visit_end_struct() into pieces

From: Eric Blake As mentioned in previous patches, we want to call visit_end_struct() functions unconditionally, so that visitors can release resources tied up since the matching visit_start_struct() without also having to worry about error priority if more than one error

[Qemu-devel] [PULL 16/23] spapr_drc: Expose 'null' in qom-get when there is no fdt

From: Eric Blake Now that the QMP output visitor supports an explicit null output, we should utilize it to make it easier to diagnose the difference between a missing fdt ('null') vs. a present-but-empty one ('{}'). (Note that this reverts the behavior of commit ab8bf1d,

[Qemu-devel] [PULL 14/23] qapi: Add visit_type_null() visitor

From: Eric Blake Right now, qmp-output-visitor happens to produce a QNull result if nothing is actually visited between the creation of the visitor and the request for the resulting QObject. A stronger protocol would require that a QMP output visit MUST visit something. But

[Qemu-devel] [PULL 18/23] qmp: Tighten output visitor rules

From: Eric Blake Tighten assertions in the QMP output visitor, so that: - qmp_output_get_qobject() can only be called after pairing a visit_end_* for every visit_start_* (rather than allowing it on a partially built object) - qmp_output_get_qobject() cannot be called unless

[Qemu-devel] [PULL 13/23] tests: Add check-qnull

From: Eric Blake Add a new test, for checking reference counting of qnull(). As part of the new file, move a previous reference counting change added in commit a861564 to a more logical place. Note that while most of the check-q*.c leave visitor stuff to the

[Qemu-devel] [PULL 22/23] qapi: Simplify semantics of visit_next_list()

From: Eric Blake The semantics of the list visit are somewhat baroque, with the following pseudocode when FooList is used: start() for (prev = head; cur = next(prev); prev = ) { visit(>value) } Note that these semantics (advance before visit) requires that the first call

[Qemu-devel] [PULL 07/23] qmp-input: Don't consume input when checking has_member

From: Eric Blake Commit e8316d7 mistakenly passed consume=true within qmp_input_optional() when checking if an optional member was present, but the mistake was silently ignored since the code happily let us extract a member more than once. Fix qmp_input_optional() to not

[Qemu-devel] [PULL 23/23] qapi: Change visit_type_FOO() to no longer return partial objects

From: Eric Blake Returning a partial object on error is an invitation for a careless caller to leak memory. We already fixed things in an earlier patch to guarantee NULL if visit_start fails ("qapi: Guarantee NULL obj on input visitor callback error"), but that does not help

[Qemu-devel] [PULL 04/23] qmp-input: Clean up stack handling

From: Eric Blake Management of the top of stack was a bit verbose; creating a temporary variable and adding some comments makes the existing code more legible before the next few patches improve things. No semantic changes other than asserting that we are always visiting a

[Qemu-devel] [PULL 17/23] qmp: Don't reuse qmp visitor after grabbing output

From: Eric Blake The testsuite was the only client that attempted to reuse a QmpOutputVisitor for a second visit after encountering an error and/or calling qmp_output_get_qobject() on a first visit. The next patch is about to tighten the semantics to be one-shot usage of the

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", + s->sec_indev); +return; +

[Qemu-devel] [PULL 08/23] qapi-commands: Wrap argument visit in visit_start_struct

From: Eric Blake The qmp-input visitor was allowing callers to play rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict; among the culprit callers was the generated marshal code on the 'arguments'

[Qemu-devel] [PULL 02/23] qapi: Guarantee NULL obj on input visitor callback error

From: Eric Blake Our existing input visitors were not very consistent on errors in a function taking 'TYPE **obj'. These are start_struct(), start_alternate(), type_str(), and type_any(). next_list() is similar, but can't fail (see commit 08f9541). While all of them set

[Qemu-devel] [PULL 01/23] qapi-visit: Add visitor.type classification

From: Eric Blake We have three classes of QAPI visitors: input, output, and dealloc. Currently, all implementations of these visitors have one thing in common based on their visitor type: the implementation used for the visit_type_enum() callback. But since we plan to add

[Qemu-devel] [PULL 11/23] qmp-input: Refactor when list is advanced

From: Eric Blake In the QMP input visitor, visiting a list traverses two objects: the QAPI GenericList of the caller (which gets advanced in visit_next_list() regardless of this patch), and the QList input that we are converting to QAPI. For consistency with QDict visits, we

[Qemu-devel] [PULL 12/23] qapi: Document visitor interfaces, add assertions

From: Eric Blake The visitor interface for mapping between QObject/QemuOpts/string and QAPI is scandalously under-documented, making changes to visitor core, individual visitors, and users of visitors difficult to coordinate. Among other questions: when is it safe to pass

[Qemu-devel] [PULL 06/23] qapi: Use strict QMP input visitor in more places

From: Eric Blake The following uses of a QMP input visitor should be strict (that is, excess keys in QDict input should be flagged if not converted to QAPI): - Testsuite code unrelated to explicitly testing non-strict mode (test-qmp-commands, test-visitor-serialization);

[Qemu-devel] [PULL 15/23] qmp: Support explicit null during visits

From: Eric Blake Implement the new type_null() callback for the qmp input and output visitors. While we don't yet have a use for this in QAPI input (the generator will need some tweaks first), some potential usages have already been discussed on the list. Meanwhile, the output

[Qemu-devel] [PULL 00/23] QAPI patches for 2016-05-12

The following changes since commit bfc766d38e1fae5767d43845c15c79ac8fa6d6af: Update version for v2.6.0 release (2016-05-11 16:44:26 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016-05-12 for you to fetch changes up to

[Qemu-devel] [PULL 20/23] tests/string-input-visitor: Add negative integer tests

Add two negative tests, one for int and one for int16List. The latter exposes a bug: nonsensical input results in an empty list instead of an error. Signed-off-by: Markus Armbruster Message-Id: <1461325048-14122-1-git-send-email-arm...@redhat.com> Signed-off-by: Eric Blake

[Qemu-devel] [PULL 03/23] qmp: Drop dead command->type

From: Eric Blake Ever since QMP was first added back in commit 43c20a43, we have never had any QmpCommandType other than QCT_NORMAL. It's pointless to carry around the cruft. Signed-off-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 21/23] qapi: Fix string input visitor handling of invalid list

From: Eric Blake As shown in the previous commit, the string input visitor was treating bogus input as an empty list rather than an error. Fix parse_str() to set errp, then the callers to exit early if an error was reported. Meanwhile, fix the testsuite to use the generated

[Qemu-devel] [PULL 05/23] qapi: Consolidate QMP input visitor creation

From: Eric Blake Rather than having two separate ways to create a QMP input visitor, where the safer approach has the more verbose name, it is better to consolidate things into a single function where the caller must explicitly choose whether to be strict or to ignore excess

[Qemu-devel] [PULL 09/23] qom: Wrap prop visit in visit_start_struct

From: Eric Blake The qmp-input visitor was allowing callers to play rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict; the final such culprit was the QOM code for converting to and from object

[Qemu-devel] [PULL 10/23] qmp-input: Require struct push to visit members of top dict

From: Eric Blake Don't embed the root of the visit into the stack of current containers being visited. That way, we no longer get confused on whether the first visit of a dictionary is to the dictionary itself or to one of the members of the dictionary, based on whether the

Re: [Qemu-devel] [PATCH] MAINTAINERS: update M68K entry

On 06.05.2016 12:30, Laurent Vivier wrote: > Add myself to be the M68K maintainer. > > Signed-off-by: Laurent Vivier > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 81e7fac..c79404c 100644 > ---

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

On Thu, May 12, 2016 at 03:32:03PM +0800, Peter Xu wrote: > On Thu, May 12, 2016 at 10:11:31AM +0300, Michael S. Tsirkin wrote: > > On Wed, May 11, 2016 at 02:53:18PM +0800, Peter Xu wrote: > > > On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > > > > Recently I encountered issue when

Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description

On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote: > The NBD protocol allows servers to advertise a human-readable > description alongside an export name during NBD_OPT_LIST. Add > an option to pass through the user's string to the NBD client. > > Doing this also makes it easier to test

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

Eduardo Habkost writes: > On Wed, May 11, 2016 at 09:11:33AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >>

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

On 05/12/2016 12:41 AM, Peter Maydell wrote: > On 11 May 2016 at 20:28, Christian Borntraeger wrote: >> On 05/09/2016 07:57 PM, Peter Maydell wrote: >>> On 9 May 2016 at 18:55, Peter Maydell wrote: On 9 May 2016 at 18:53, Stefan Weil

Re: [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device

On Wed, May 11, 2016 at 02:46:06PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard > --- > hw/ipmi/smbus_ipmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ipmi/smbus_ipmi.c b/hw/ipmi/smbus_ipmi.c >

Re: [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS

On Wed, May 11, 2016 at 02:46:05PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard > --- > hw/acpi/ipmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/acpi/ipmi.c b/hw/acpi/ipmi.c

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

On Thu, May 12, 2016 at 10:11:31AM +0300, Michael S. Tsirkin wrote: > On Wed, May 11, 2016 at 02:53:18PM +0800, Peter Xu wrote: > > On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > > > Recently I encountered issue when debugging Intel IOMMU IR codes, > > > that interrupts are not

Re: [Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling

On Wed, May 11, 2016 at 02:46:04PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard > --- > hw/acpi/aml-build.c | 42 ++ > include/hw/acpi/aml-build.h | 11 +++

[Qemu-devel] [PATCH] gtk: update grab code for gtk 3.20

Fixes the remaining gtk 3.20 warnings. Signed-off-by: Gerd Hoffmann Reviewed-by: Cole Robinson Tested-by: Cole Robinson --- ui/gtk.c | 49 +++-- 1 file changed, 43 insertions(+), 6

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Wed, May 11, 2016 at 16:35:50 -0300, Eduardo Habkost wrote: > # @CpuDefinitionInfo: > # > # Virtual CPU definition. > # > # @name: the name of the CPU definition > # @runnable: #optional. whether the CPU model us usable with the s/ us / is / > #current machine and accelerator.

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

On Wed, May 11, 2016 at 02:53:18PM +0800, Peter Xu wrote: > On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > > Recently I encountered issue when debugging Intel IOMMU IR codes, > > that interrupts are not working correctly with PCI bridges (reported > > by Radim). This patch fixes the

Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Wed, May 11, 2016 at 08:28:59PM -0300, Eduardo Habkost wrote: > On Thu, May 12, 2016 at 12:51:55AM +0300, Michael S. Tsirkin wrote: > > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > > On Tue, 10 May 2016 17:24:14 -0300 > > > Eduardo Habkost wrote: > >

Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Wed, May 11, 2016 at 08:36:00PM -0300, Eduardo Habkost wrote: > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > On Tue, 10 May 2016 17:24:14 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, May 02, 2016 at 02:33:21PM +0200, Igor Mammedov wrote: > > >

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device '%s' not found", + s->sec_indev); +return; +} + +s->chr_out =

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

> Updated to: > > ## > # @CpuDefinitionInfo: > # > # Virtual CPU definition. > # > # @name: the name of the CPU definition > # @runnable: #optional. whether the CPU model us usable with the > #current machine and accelerator. Omitted if we don't > #know the answer. (since

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

On 05/12/2016 09:11 AM, Jason Wang wrote: On 2016年05月11日 19:20, Zhang Chen wrote: On 05/11/2016 05:01 PM, Jason Wang wrote: On 2016年05月06日 18:56, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian

<    1   2   3   4