[Qemu-devel] [Bug 1581695] [NEW] getifaddrs: Address family not supported by protocol

2016-05-13 Thread chrisber
Public bug reported: Calling ip addr fails with the following error message: Cannot open netlink socket: Address family not supported by protocol My use case is running a docker raspberry pi arm container on Ubuntu 14.04 x64 with qemu-static. My steps to reproduce are the following: # docker

[Qemu-devel] [PATCH] target-arm/helper.c: fix access rights of SP_ELs

2016-05-13 Thread Tsung-Han Lin
Fix the access rights of SP_EL2 and SP_EL1, which should be able to be accessed from EL2 and EL1 respectively. Signed-off-by: Tsung-Han Lin --- target-arm/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c

Re: [Qemu-devel] [PATCH v2 2/2] trace: [all] Add "guest_mem_before" event

2016-05-13 Thread Lluís Vilanova
Lluís Vilanova writes: [...] > diff --git a/trace/mem-internal.h b/trace/mem-internal.h > new file mode 100644 > index 000..970d525 > --- /dev/null > +++ b/trace/mem-internal.h > @@ -0,0 +1,46 @@ > +/* > + * Helper functions for guest memory tracing > + * > + * Copyright (C) 2016 Lluís

[Qemu-devel] [PATCH v5 12/18] qht: QEMU's fast, resizable and scalable Hash Table

2016-05-13 Thread Emilio G. Cota
This is a fast, scalable chained hash table with optional auto-resizing, allowing reads that are concurrent with reads, and reads/writes that are concurrent with writes to separate buckets. A hash table with these features will be necessary for the scalability of the ongoing MTTCG work; before

[Qemu-devel] [PATCH v5 10/18] qdist: add module to represent frequency distributions of data

2016-05-13 Thread Emilio G. Cota
Sometimes it is useful to have a quick histogram to represent a certain distribution -- for example, when investigating a performance regression in a hash table due to inadequate hashing. The appended allows us to easily represent a distribution using Unicode characters. Further, the data

[Qemu-devel] [PATCH v5 15/18] qht: add qht-bench, a performance benchmark

2016-05-13 Thread Emilio G. Cota
This serves as a performance benchmark as well as a stress test for QHT. We can tweak quite a number of things, including the number of resize threads and how frequently resizes are triggered. A performance comparison of QHT vs CLHT[1] and ck_hs[2] using this same benchmark program can be found

[Qemu-devel] [PATCH v5 13/18] qht: support parallel writes

2016-05-13 Thread Emilio G. Cota
The appended increases write scalability by allowing concurrent writes to separate buckets. It also removes the need for an external lock when operating on the hash table. Lookup code remains the same; insert and remove fast paths get an extra smp_rmb() before reading the map pointer and a

[Qemu-devel] [PATCH v5 17/18] tb hash: track translated blocks with qht

2016-05-13 Thread Emilio G. Cota
Having a fixed-size hash table for keeping track of all translation blocks is suboptimal: some workloads are just too big or too small to get maximum performance from the hash table. The MRU promotion policy helps improve performance when the hash table is a little undersized, but it cannot make

[Qemu-devel] [PATCH v5 14/18] qht: add test program

2016-05-13 Thread Emilio G. Cota
Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- tests/.gitignore | 1 + tests/Makefile | 6 ++- tests/test-qht.c | 159 +++ 3 files

[Qemu-devel] [PATCH v5 18/18] translate-all: add tb hash bucket info to 'info jit' dump

2016-05-13 Thread Emilio G. Cota
Examples: - Good hashing, i.e. tb_hash_func5(phys_pc, pc, flags): TB count715135/2684354 [...] TB hash buckets 388775/524288 (74.15% head buckets used) TB hash occupancy 33.04% avg chain occ. Histogram: [0,10)%|▆ █ ▅▁▃▁▁|[90,100]% TB hash avg chain 1.017 buckets. Histogram:

[Qemu-devel] [PATCH v5 11/18] qdist: add test program

2016-05-13 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- tests/.gitignore | 1 + tests/Makefile | 6 +- tests/test-qdist.c | 369 + 3 files changed, 375 insertions(+), 1 deletion(-) create

[Qemu-devel] [PATCH v5 04/18] include/processor.h: define cpu_relax()

2016-05-13 Thread Emilio G. Cota
Taken from the linux kernel. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota --- include/qemu/processor.h | 34 ++ 1 file changed, 34 insertions(+) create mode

[Qemu-devel] [PATCH v5 16/18] qht: add test-qht-par to invoke qht-bench from 'check' target

2016-05-13 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- tests/.gitignore | 1 + tests/Makefile | 5 - tests/test-qht-par.c | 56 3 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 tests/test-qht-par.c diff --git

[Qemu-devel] [PATCH v5 06/18] atomics: add atomic_read_acquire and atomic_set_release

2016-05-13 Thread Emilio G. Cota
When __atomic is not available, we use full memory barriers instead of smp/wmb, since acquire/release barriers apply to all memory operations and not just to loads/stores, respectively. Signed-off-by: Emilio G. Cota --- include/qemu/atomic.h | 27 +++ 1

[Qemu-devel] [PATCH v5 05/18] atomics: add atomic_test_and_set_acquire

2016-05-13 Thread Emilio G. Cota
This new helper expands to __atomic_test_and_set with acquire semantics where available; otherwise it expands to __sync_test_and_set, which has acquire semantics. Signed-off-by: Emilio G. Cota --- include/qemu/atomic.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Qemu-devel] [PATCH v5 00/18] tb hash improvements

2016-05-13 Thread Emilio G. Cota
This patchset applies on top of tcg-next (8b1fe3f4 "cpu-exec: Clean up 'interrupt_request' reloading", tagged "pull-tcg-20160512"). For reference, here is v4: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg04670.html Changes from v4: - atomics.h: + Add atomic_read_acquire and

[Qemu-devel] [PATCH v5 09/18] tb hash: hash phys_pc, pc, and flags with xxhash

2016-05-13 Thread Emilio G. Cota
For some workloads such as arm bootup, tb_phys_hash is performance-critical. The is due to the high frequency of accesses to the hash table, originated by (frequent) TLB flushes that wipe out the cpu-private tb_jmp_cache's. More info:

[Qemu-devel] [PATCH v5 08/18] exec: add tb_hash_func5, derived from xxhash

2016-05-13 Thread Emilio G. Cota
This will be used by upcoming changes for hashing the tb hash. Add this into a separate file to include the copyright notice from xxhash. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/exec/tb-hash-xx.h | 94

[Qemu-devel] [PATCH v5 07/18] qemu-thread: add simple test-and-set spinlock

2016-05-13 Thread Emilio G. Cota
From: Guillaume Delbergue Signed-off-by: Guillaume Delbergue [Rewritten. - Paolo] Signed-off-by: Paolo Bonzini [Emilio's additions: use TAS instead of atomic_xchg; emit acquire/release barriers; call

[Qemu-devel] [PATCH v5 01/18] compiler.h: add QEMU_ALIGNED() to enforce struct alignment

2016-05-13 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota --- include/qemu/compiler.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index

[Qemu-devel] [PATCH v5 03/18] seqlock: rename write_lock/unlock to write_begin/end

2016-05-13 Thread Emilio G. Cota
It is a more appropriate name, now that the mutex embedded in the seqlock is gone. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- cpus.c | 28 ++--

[Qemu-devel] [PATCH v5 02/18] seqlock: remove optional mutex

2016-05-13 Thread Emilio G. Cota
This option is unused; besides, it bloats the struct when not needed. Let's just let writers define their own locks elsewhere. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- cpus.c

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer

2016-05-13 Thread Chen Gang
On 5/6/16 00:11, Edgar E. Iglesias wrote: > On Thu, May 05, 2016 at 10:48:57PM +0800, Chen Gang wrote: >> On 5/5/16 00:05, Peter Maydell wrote: >>> On 29 March 2016 at 15:13, wrote: From: Chen Gang The return address is in

[Qemu-devel] [Bug 1581334] Re: qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread chenwqin
Here are 'perf top -p `pgrep qemu` -a` output; I met tcmalloc problem on the osd host and fix it with a larger TCMALLOC_MAX_TOTAL_THREAD_CACHE_BYTES. The perf top of tcmalloc problem is a little bit different of my problem. --

Re: [Qemu-devel] [PATCH qemu v16 18/19] vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2)

2016-05-13 Thread Alex Williamson
On Wed, 4 May 2016 16:52:30 +1000 Alexey Kardashevskiy wrote: > New VFIO_SPAPR_TCE_v2_IOMMU type supports dynamic DMA window management. > This adds ability to VFIO common code to dynamically allocate/remove > DMA windows in the host kernel when new VFIO container is

Re: [Qemu-devel] [PATCH qemu v16 17/19] spapr_iommu, vfio, memory: Notify IOMMU about starting/stopping being used by VFIO

2016-05-13 Thread Alex Williamson
On Wed, 4 May 2016 16:52:29 +1000 Alexey Kardashevskiy wrote: > The sPAPR TCE tables manage 2 copies when VFIO is using an IOMMU - > a guest view of the table and a hardware TCE table. If there is no VFIO > presense in the address space, then just the guest view is used, if >

Re: [Qemu-devel] [PATCH qemu v16 14/19] vfio: spapr: Add DMA memory preregistering (SPAPR IOMMU v2)

2016-05-13 Thread Alex Williamson
On Wed, 4 May 2016 16:52:26 +1000 Alexey Kardashevskiy wrote: > This makes use of the new "memory registering" feature. The idea is > to provide the userspace ability to notify the host kernel about pages > which are going to be used for DMA. Having this information, the host >

Re: [Qemu-devel] [PATCH qemu v16 16/19] vfio: Add host side DMA window capabilities

2016-05-13 Thread Alex Williamson
On Wed, 4 May 2016 16:52:28 +1000 Alexey Kardashevskiy wrote: > There are going to be multiple IOMMUs per a container. This moves > the single host IOMMU parameter set to a list of VFIOHostDMAWindow. > > This should cause no behavioral change and will be used later by > the

Re: [Qemu-devel] [PATCH qemu v16 01/19] vfio: Delay DMA address space listener release

2016-05-13 Thread Alex Williamson
On Fri, 13 May 2016 17:16:48 +1000 Alexey Kardashevskiy wrote: > On 05/06/2016 08:39 AM, Alex Williamson wrote: > > On Wed, 4 May 2016 16:52:13 +1000 > > Alexey Kardashevskiy wrote: > > > >> This postpones VFIO container deinitialization to let region_del() >

[Qemu-devel] [PATCH v2 1/1] target-arm: Add the HSTR_EL2 register

2016-05-13 Thread Alistair Francis
Add the Hypervisor System Trap Register for EL2. This register is used early in the Linux boot and without it the kernel aborts with a "Synchronous Abort" error. Signed-off-by: Alistair Francis --- V2: - Add 32-bit access - Connect to a variable target-arm/cpu.h

[Qemu-devel] [PATCH v6 0/3] Add a generic loader

2016-05-13 Thread Alistair Francis
This work is based on the original work by Li Guang with extra features added by Peter C and myself. The idea of this loader is to allow the user to load multiple images or values into QEMU at startup. Memory values can be loaded like this: -device

[Qemu-devel] [PATCH v6 3/3] docs: Add a generic loader explanation document

2016-05-13 Thread Alistair Francis
Signed-off-by: Alistair Francis --- V6: - Fixup documentation V4: - Re-write to be more comprehensive docs/generic-loader.txt | 54 + 1 file changed, 54 insertions(+) create mode 100644 docs/generic-loader.txt diff

[Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect the ELF arch

2016-05-13 Thread Alistair Francis
If the caller didn't specify an architecture for the ELF machine the load_elf() function will auto detect it based on the ELF file. Signed-off-by: Alistair Francis --- hw/core/loader.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/core/loader.c

[Qemu-devel] [PATCH v6 2/3] generic-loader: Add a generic loader

2016-05-13 Thread Alistair Francis
Add a generic loader to QEMU which can be used to load images or set memory values. Signed-off-by: Alistair Francis --- V6: - Add error checking V5: - Rebase V4: - Allow the loader to work with every architecture - Move the file to hw/core - Increase the maximum

Re: [Qemu-devel] [PATCH v1 1/2] target-arm: Add the HSTR_EL2 register

2016-05-13 Thread Alistair Francis
On Fri, May 13, 2016 at 10:46 AM, Peter Maydell wrote: > On 6 May 2016 at 19:11, Alistair Francis wrote: >> Add the Hypervisor System Trap Register for EL2. >> >> This register is used early in the Linux boot and without it the kernel >>

Re: [Qemu-devel] [PATCH 00/10] RFCv3: vhost-user: simple reconnection support

2016-05-13 Thread Marc-André Lureau
Hi On Tue, May 10, 2016 at 6:28 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> On Tue, May 10, 2016 at 06:03:50PM +0200, marcandre.lur...@redhat.com wrote: >> > From: Marc-André Lureau >> > >> > Hi, >> > >> > In a previous

Re: [Qemu-devel] [PATCH v1 1/2] target-arm: Add the HSTR_EL2 register

2016-05-13 Thread Peter Maydell
On 6 May 2016 at 19:11, Alistair Francis wrote: > Add the Hypervisor System Trap Register for EL2. > > This register is used early in the Linux boot and without it the kernel > aborts with a "Synchronous Abort" error. > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH 2/4] intel_iommu: use deliver_msi APIC callback

2016-05-13 Thread Eduardo Habkost
On Fri, May 06, 2016 at 10:53:46PM +0200, Radim Krčmář wrote: > The memory-mapped interface cannot express x2APIC destinations that are > a result of remapping. > > Signed-off-by: Radim Krčmář > --- > hw/i386/intel_iommu.c | 29 ++--- > 1 file

Re: [Qemu-devel] [PATCH 1/4] apic: add deliver_msi to APICCommonClass

2016-05-13 Thread Eduardo Habkost
On Fri, May 06, 2016 at 10:53:45PM +0200, Radim Krčmář wrote: > The only way to send interrupts from outside of APIC devices is to use > the MSI-inspired memory mapped interface. The interface is not > sufficient because interrupt remapping in extended mode can exceed 8 bit > destination ids. >

Re: [Qemu-devel] [PATCH for 2.7 v3 1/1] qcow2: improve qcow2_co_write_zeroes()

2016-05-13 Thread Denis V. Lunev
On 05/13/2016 07:24 PM, Kevin Wolf wrote: Am 13.05.2016 um 18:09 hat Denis V. Lunev geschrieben: oops, the patch gets committed... that is unexpected but great ;) Oops, that was not intended, I just forgot to remove it from the queue when I realised that it's not ready yet. Should I stage a

[Qemu-devel] [Bug 1581334] Re: qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Jason Dillaman
Can you run 'perf top' against just the QEMU process? There was an email chain from nearly a year ago about tcmalloc causing extremely high '_raw_spin_lock' calls under high IOPS scenarios. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] Shouldn't cortex-a15 enable ARM_FEATURE_EL2?

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 17:41, Andrew Baumann wrote: > I'm trying to use the MRS/MSR banked register instructions you > recently implemented, but found that they raised an undefined > instruction exception on the cortex-a15 CPU model. This seems to > be caused by the check

Re: [Qemu-devel] [PATCH RFC 3/3] linux-user: add netlink audit

2016-05-13 Thread Peter Maydell
On 30 January 2016 at 22:27, Laurent Vivier wrote: > This is, for instance, needed to log in a container. > > Without this, the user cannot be identified and the console login > fails with "Login incorrect". > > Signed-off-by: Laurent Vivier > --- >

[Qemu-devel] [Bug 1581334] Re: qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread chenwqin
Here are gdb oupout with librbd1-dbg and librados2-dbg. - [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". 0x7ff8cf8dddff in ppoll () from

Re: [Qemu-devel] [PATCH RFC 2/3] linux-user: support netlink protocol NETLINK_KOBJECT_UEVENT

2016-05-13 Thread Peter Maydell
On 30 January 2016 at 22:26, Laurent Vivier wrote: > This is the protocol used by udevd to manage kernel events. > > Signed-off-by: Laurent Vivier > --- > linux-user/syscall.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/linux-user/syscall.c

[Qemu-devel] Shouldn't cortex-a15 enable ARM_FEATURE_EL2?

2016-05-13 Thread Andrew Baumann
Hi Peter, I'm trying to use the MRS/MSR banked register instructions you recently implemented, but found that they raised an undefined instruction exception on the cortex-a15 CPU model. This seems to be caused by the check in msr_banked_access_decode(), which looks for ARM_FEATURE_V8 or

Re: [Qemu-devel] [PATCH RFC 1/3] linux-user: add rtnetlink(7) support

2016-05-13 Thread Peter Maydell
On 30 January 2016 at 22:26, Laurent Vivier wrote: > rtnetlink is needed to use iproute package (ip addr, ip route) > and dhcp client. > > Examples: > > Without this patch: > # ip link > Cannot open netlink socket: Address family not supported by protocol > # ip

Re: [Qemu-devel] [PATCH for 2.7 v3 1/1] qcow2: improve qcow2_co_write_zeroes()

2016-05-13 Thread Denis V. Lunev
On 05/12/2016 01:37 PM, Kevin Wolf wrote: Am 12.05.2016 um 11:00 hat Denis V. Lunev geschrieben: On 05/11/2016 02:28 PM, Kevin Wolf wrote: Am 11.05.2016 um 09:00 hat Denis V. Lunev geschrieben: There is a possibility that qcow2_co_write_zeroes() will be called with the partial block. This

Re: [Qemu-devel] [PATCH for 2.7 v3 1/1] qcow2: improve qcow2_co_write_zeroes()

2016-05-13 Thread Kevin Wolf
Am 13.05.2016 um 18:09 hat Denis V. Lunev geschrieben: > oops, the patch gets committed... that is unexpected but great ;) Oops, that was not intended, I just forgot to remove it from the queue when I realised that it's not ready yet. Should I stage a revert or do you prefer to fix it on top? >

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Alex Williamson
On Fri, 13 May 2016 03:55:09 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, May 13, 2016 3:06 AM > > > > > > > > > > > > Based on above thought I'm thinking whether below would work: > > > (let's use gpa to

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 05:23:44PM +0800, Jike Song wrote: > On 05/13/2016 04:31 PM, Neo Jia wrote: > > On Fri, May 13, 2016 at 07:45:14AM +, Tian, Kevin wrote: > >> > >> We use page tracking framework, which is newly added to KVM recently, > >> to mark RAM pages as read-only so write accesses

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 05:46:17PM +0800, Jike Song wrote: > On 05/13/2016 04:12 AM, Neo Jia wrote: > > On Thu, May 12, 2016 at 01:05:52PM -0600, Alex Williamson wrote: > >> > >> If you're trying to equate the scale of what we need to track vs what > >> type1 currently tracks, they're

Re: [Qemu-devel] [PATCH 14/14] blockjob: Remove BlockJob.bs

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > There is a single remaining user in qemu-img, which can be trivially > converted to using BlockJob.blk instead. > > Signed-off-by: Kevin Wolf > --- > blockjob.c | 1 - > include/block/blockjob.h | 1 - > qemu-img.c

Re: [Qemu-devel] [PATCH 13/14] commit: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the commit block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the commit code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/commit.c | 42

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-05-13 Thread Peter Maydell
On 12 May 2016 at 02:46, 赵小强 wrote: > > 在 2016-03-31 16:15:17,"xiaoqiang zhao" 写道: >> >> >>> 在 2016年3月31日,16:05,Peter Maydell 写道: >>> On 31 March 2016 at 02:48, xiaoqiang zhao wrote: > 在

Re: [Qemu-devel] [PATCH 11/23] hw/intc/arm_gicv3: Implement GICv3 distributor registers

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 16:05, Shannon Zhao wrote: > On 2016年05月10日 01:29, Peter Maydell wrote: >> +static MemTxResult gicd_writeb(GICv3State *s, hwaddr offset, >> + uint64_t value, MemTxAttrs attrs) >> +{ >> +/* Most GICv3 distributor

Re: [Qemu-devel] [PATCH 12/14] backup: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the backup block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the backup code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/backup.c | 42 >

Re: [Qemu-devel] [Bug 1581334] [NEW] qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Serge Hallyn
affects ceph ** Also affects: ceph Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581334 Title: qemu + librbd takes high %sy cpu under high random io

[Qemu-devel] [Bug 1581334] Re: qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Josh Durgin
Since this works fine with krbd, it sounds like the bug may be in librbd. Could you install debug symbols (the librbd1-dbg package) and when this occurs, attach to the qemu process with gdb and get a backtrace of all threads (there will be a lot of them) via 'gdb -p $pid' and in gdb 'thread apply

Re: [Qemu-devel] [PATCH 11/14] block: Add blk_co_readv/writev()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 26 ++ > include/sysemu/block-backend.h | 4 > trace-events | 2 ++ > 3 files changed, 32 insertions(+) Reasonable in

Re: [Qemu-devel] [Bug 1581334] [NEW] qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Serge Hallyn
affects linux ** Also affects: linux Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581334 Title: qemu + librbd takes high %sy cpu under high random

Re: [Qemu-devel] [PATCH 10/14] backup: Remove bs parameter from backup_do_cow()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > Now that we pass the job to the function, bs is implied by that. > > Signed-off-by: Kevin Wolf > --- > block/backup.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 11/23] hw/intc/arm_gicv3: Implement GICv3 distributor registers

2016-05-13 Thread Shannon Zhao
On 2016年05月10日 01:29, Peter Maydell wrote: > +static MemTxResult gicd_writeb(GICv3State *s, hwaddr offset, > + uint64_t value, MemTxAttrs attrs) > +{ > +/* Most GICv3 distributor registers do not support byte accesses. */ > +switch (offset) { > +case

[Qemu-devel] [Bug 1581308] [NEW] ohci doesn't check the 'num-ports' property

2016-05-13 Thread Li Qiang
Public bug reported: command: qemu-system-x86_64 -m 1024 -enable-kvm /root/centos6.img -enable-kvm -device pci-ohci,num-ports=100,masterbus=1 The ohci doesn't check the 'num-ports' property and would case an out- of-bands write,crash the qemu process. ohci->num_ports = num_ports; if

Re: [Qemu-devel] [PATCH 09/14] backup: Pack Notifier within BackupBlockJob

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > From: John Snow > > Instead of relying on peeking at bs->job, we want to explicitly get > a reference to the job that was involved in this notifier callback. > > Pack the Notifier inside of the BackupBlockJob so we can use >

Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O

2016-05-13 Thread Eric Blake
On 05/13/2016 08:38 AM, Max Reitz wrote: > On 04.05.2016 11:39, Kevin Wolf wrote: >> This changes the mirror block job to use the job's BlockBackend for >> performing its I/O. job->bs isn't used by the mirroring code any more >> afterwards. >> >> Signed-off-by: Kevin Wolf >> ---

[Qemu-devel] [Bug 1581334] [NEW] qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread chenwqin
Public bug reported: I got an IO problem. When running Qemu + ceph(use librbd), and do a random IO benchmark or some high load random IO test, it will exhaust all my host cpu on %sy cpu. It doesn’t happen all the time, but when it appear it will reproduce every time I start a random IO

Re: [Qemu-devel] [PATCH 08/14] backup: Don't leak BackupBlockJob in error path

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/backup.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

[Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub

2016-05-13 Thread Sebastian Färber
Add support for reopen() by adding the .bdrv_reopen_prepare() stub Signed-off-by: Sebastian Färber Tested-by: Sebastian Färber --- block/rbd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index

[Qemu-devel] [PATCH] migration: fix ram decompression race deadlock

2016-05-13 Thread Maxim Nestratov
The way how decompress_data_with_multi_threads communicates with do_data_decompress is incorrect. Imagine the following scenario. The function do_data_decompress just finished decompression and released param->mutex and got preempted. In parallel, the function decompress_data_with_multi_threads

Re: [Qemu-devel] Make virtio-net.c ring size configurable?

2016-05-13 Thread xchenum
Luke, I might have a similar problem... I am wondering if you end up increasing the ring buffer size yourself. My problem is on the tx side. When sending many small udp packets, I am seeing "outgoing packets dropped" in "netstat -s" increase quickly. Increasing txqueue of the interface and

Re: [Qemu-devel] [PULL v2 00/17] ui patch queue

2016-05-13 Thread Peter Maydell
he following changes since commit 860a3b34854d8abe9af9f1eb584691de926ce897: > > Update version for v2.6.0-rc5 release (2016-05-09 14:08:12 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-ui-20160513-1 > > for you to fetch changes up to 6978dc

Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the mirror block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the mirroring code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 75 >

Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the mirror block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the mirroring code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 75 >

Re: [Qemu-devel] [PATCH 00/23] GICv3 emulation

2016-05-13 Thread Shannon Zhao
On 2016年05月12日 23:22, Peter Maydell wrote: > On 12 May 2016 at 16:01, Shannon Zhao wrote: >> On 2016年05月12日 22:35, Peter Maydell wrote: >>> Can you put the Image file somewhere I can download it, please? >> I just upload it to >>

Re: [Qemu-devel] [PATCH 06/14] mirror: Allow target that already has a BlockBackend

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > We had to forbid mirroring to a target BDS that already had a BB > attached because the node swapping at job completion would add a second > BB and we didn't support multiple BBs on a single BDS at the time. Now > we do, so we can lift the restriction. > As

Re: [Qemu-devel] [PATCH 05/14] stream: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the streaming block job to use the job's BlockBackend for > performing the COR reads. job->bs isn't used by the streaming code any > more afterwards. > > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 15

Re: [Qemu-devel] [PATCH 04/14] block: Convert block job core to BlockBackend

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This adds a new BlockBackend field to the BlockJob struct, which > coexists with the BlockDriverState while converting the individual jobs. > > When creating a block job, a new BlockBackend is created on top of the > given BlockDriverState, and it is

Re: [Qemu-devel] [PATCH 0/3] Fix recent qemu-iotests issues

2016-05-13 Thread Eric Blake
On 05/13/2016 06:06 AM, Max Reitz wrote: > On 12.05.2016 23:39, Eric Blake wrote: >> I introduced a couple of bugs in my recent qemu-io enhancements; >> time to fix them back up now that the broken patches are already >> part of mainline. >> >> Eric Blake (3): >> qemu-io: Fix missing getopt()

Re: [Qemu-devel] [PATCH 03/14] block: Default to enabled write cache in blk_new()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > The existing users of the function are: > > 1. blk_new_open(), which already enabled the write cache > 2. Some test cases that don't care about the setting > 3. blockdev_init() for empty drives, where the cache mode is overridden >with the value from

Re: [Qemu-devel] [PATCH 02/14] block: Cancel jobs first in bdrv_close_all()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > So far, bdrv_close_all() first removed all root BlockDriverStates of > BlockBackends and monitor owned BDSes, and then assumed that the > remaining BDSes must be related to jobs and cancelled these jobs. > > This order doesn't work that well any more when

Re: [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS

2016-05-13 Thread Corey Minyard
On 05/12/2016 08:39 AM, Michael S. Tsirkin wrote: On Thu, May 12, 2016 at 08:29:53AM -0500, Corey Minyard wrote: On 05/12/2016 02:33 AM, Michael S. Tsirkin wrote: On Wed, May 11, 2016 at 02:46:05PM -0500, miny...@acm.org wrote: From: Corey Minyard Signed-off-by: Corey

Re: [Qemu-devel] [PATCH 01/14] block: keep a list of block jobs

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > From: Alberto Garcia > > The current way to obtain the list of existing block jobs is to > iterate over all root nodes and check which ones own a job. > > Since we want to be able to support block jobs in other nodes as well, > this

[Qemu-devel] [PATCH v3 3/6] smbios: Move table build tools into an include file.

2016-05-13 Thread minyard
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77

[Qemu-devel] [PATCH v3 0/6] Add ACPI and SMBIOS tables for IPMI

2016-05-13 Thread minyard
This rework is based on Michael's comments on the SMBus series. This patch series modifies the way the tables are added so that they are scanned from the ACPI code handling that particular bus instead of all being added at the end. This way the IPMI ACPI code doesn't have to know the ACPI scope

[Qemu-devel] [PATCH v3 5/6] acpi: Add IPMI table entries

2016-05-13 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not

[Qemu-devel] [PATCH v3 4/6] ipmi: Add SMBIOS table entry

2016-05-13 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- hw/smbios/Makefile.objs | 2 ++ hw/smbios/ipmi.c | 76

[Qemu-devel] [PATCH v3 1/6] ipmi fwinfo: Remove ACPI parent, add the device

2016-05-13 Thread minyard
From: Corey Minyard Instead of storing the ACPI parent, store the device in the fwinfo structure for IPMI. This way a future change that scans the IPMI devices for firmware can select the devices on a particular bus. This will let the ACPI scope be defined by the calling

[Qemu-devel] [PATCH v3 2/6] pc: Postpone SMBIOS table installation to post machine init

2016-05-13 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

[Qemu-devel] [PULL v2 07/17] configure: report SDL version

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Signed-off-by: Cole Robinson Message-id: 98e4a3b98dc824bfaff96db43b172272c780c15f.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PULL v2 05/17] configure: add echo_version helper

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Simplifies printing library versions, dependent on if the library was even found Signed-off-by: Cole Robinson Message-id: 3c9ab16123e06bb4109771ef6ee8acd82d449ba0.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL v2 09/17] ui: gtk: Fix a runtime warning on vte >= 0.37

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson inner-border was dropped in vte API 2.91, in favor of the standard padding style Signed-off-by: Cole Robinson Message-id: 60a6cdc337d611d902f53907e66a8f37ea374d65.1462557436.git.crobi...@redhat.com [ kraxel: Fix warning with old

[Qemu-devel] [PULL v2 12/17] spice/gl: add & use qemu_spice_gl_monitor_config

2016-05-13 Thread Gerd Hoffmann
Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/spice-display.h | 1 + ui/spice-display.c | 30 ++ 2 files changed, 31 insertions(+) diff --git

[Qemu-devel] [PULL v2 15/17] spice: fix coverity complains

2016-05-13 Thread Gerd Hoffmann
From: Gonglei Remove the unnecessary NULL check. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Message-id: 1463047028-123868-3-git-send-email-arei.gong...@huawei.com Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-border is NULL

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson VTE terminal inner-border can be NULL. The vte-0.36 (API 2.90) code checks for the condition too so I assume it's not just a bug Fixes a crash on Fedora 24 with gtk 3.20 Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL v2 10/17] ui: gtk: Fix some deprecation warnings

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson All device manager APIs are deprecated now. Much of our usage is just to get the current pointer, so centralize that logic and use the new seat APIs Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL v2 03/17] configure: build SDL if only SDL2 available

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Right now if SDL2 is installed but not SDL1, default configure will entirely disable SDL. Check upfront for SDL2 using pkg-config, but still prefer SDL1 if both versions are installed. Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL v2 00/17] ui patch queue

2016-05-13 Thread Gerd Hoffmann
:12 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20160513-1 for you to fetch changes up to 6978dc4adcdf27722aa6f9e13f88a903b30a3f8d: gtk: don't leak the GtkBorder with VTE 0.36 (2016-05-13 12:40:12 +0200

[Qemu-devel] [PULL v2 06/17] configure: report GTK version

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Signed-off-by: Cole Robinson Message-id: 4c464e20d69fdcf21927ceed31a8d749b4af0c49.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PULL v2 08/17] configure: support vte-2.91

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson vte >= 0.37 expores API version 2.91, which is where all the active development is. qemu builds and runs fine with that version, so use it if it's available. Signed-off-by: Cole Robinson Message-id:

  1   2   >