WARNING: architecture specific defines should be avoided
#574: FILE: target-avr/cpu.h:32:
+#if !defined(__CPU_AVR_H__)
it was not my invention, I took it from either target-alpha or target-ppc.
On Mon, Jun 6, 2016 at 10:49 PM, Michael Rolnik wrote:
> please advise.
> I have the following warnin
please advise.
I have the following warning. but all print_instn_XXX functions are
declared this way.
so, I am kind of confused. I can fix it, but the file won't look the same.
WARNING: space prohibited between function name and open parenthesis '('
#132: FILE: include/disas/bfd.h:424:
+int print_
When you say it's failing with qemu 2.6, are you using the official
release 2.6.0 or the current version from the git repository? Also,
which target machine are you emulating? x86_64? ppc64?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to Q
This commit causes qmp_blockdev_change_medium to report an error if an
attempt is made to open a device with a locked tray.
Signed-off-by: Colin Lord
This is based off my previous patch regarding the do_open_tray function
(currently at v3). Probably should have been submitted as a patch set
but I
On 06/06/2016 03:37 AM, Michael Rolnik wrote:
changes since v3
1. rampD/X/Y/Z registers are encoded as 0x00ff and not 0x00ff for
faster address manipulaton
2. ffs changed to ctz32
3. duplicate code removed at avr_cpu_do_interrupt
4. using andc instead of not + and
5. fixing V flag calcul
On 6 June 2016 at 20:22, Dr. David Alan Gilbert wrote:
> Sigh I see; so the configure test is run with a different set of compiler
> options than the main compiles? How is any configure test supposed to
> check that it's got a sane configuration?
I wasn't quite right -- we do run configure tests
Since TARGET_ERESTARTSYS and TARGET_ESIGRETURN are internal-to-QEMU
error numbers, handle them specially in target_strerror(), to avoid
confusing strace output like:
9521 rt_sigreturn(14,8,274886297808,8,0,268435456) = -1 errno=513 (Unknown
error 513)
Signed-off-by: Peter Maydell
---
linux-use
On Mon, 6 Jun 2016 10:44:25 -0700
Neo Jia wrote:
> On Mon, Jun 06, 2016 at 04:29:11PM +0800, Dong Jia wrote:
> > On Sun, 5 Jun 2016 23:27:42 -0700
> > Neo Jia wrote:
> >
> > 2. VFIO_DEVICE_CCW_CMD_REQUEST
> > This intends to handle an intercepted channel I/O instruction. It
> > basically need t
Use the safe_syscall wrapper for epoll_wait and epoll_pwait syscalls.
Since we now directly use the host epoll_pwait syscall for both
epoll_wait and epoll_pwait, we don't need the configure machinery
to check whether glibc supports epoll_pwait(). (The kernel has
supported the syscall since 2.6.19
On Mon, Jun 6, 2016 at 10:17 PM, Richard Henderson wrote:
> On 06/05/2016 11:52 PM, Michael Rolnik wrote:
>
>> truth table shows that these computations are different.
>>
>
> You're not giving the right inputs to the truth table.
>
> you can't look onto 4th bit because 4th bits in the input were
Use the safe_syscall wrapper for the send, sendto, sendmsg, recv,
recvfrom and recvmsg syscalls.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index b649a8
On Mon, Jun 06, 2016 at 05:57:35PM +0100, Peter Maydell wrote:
> On 6 June 2016 at 15:55, Peter Maydell wrote:
> > Ping!
>
> Thanks for the review, Sergey. Unless anybody else wants to review
> or wants to take it through their tree (Riku?), I propose to apply
> this to master sometime later this
Use the safe_syscall wrapper for fcntl. This is straightforward now
that we always use 'struct fcntl64' on the host, as we don't need
to select whether to call the host's fcntl64 or fcntl syscall
(a detail that the libc previously hid for us).
Signed-off-by: Peter Maydell
---
linux-user/syscall.
Use the safe_syscall wrapper for mq_timedsend and mq_timedreceive syscalls.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 3735d7d..cdc7428 100644
--
On Mon, Jun 6, 2016 at 3:23 PM, Richard Henderson wrote:
> On 06/06/2016 10:11 AM, Pranith Kumar wrote:
>>
>> If I read it correctly TCG_BAR_SYNC is equivalent to OR of all the
>> other four barriers. I am not sure if we can just construct SYNC like
>> this or if we need to define it explicitly th
Use the safe_syscall wrapper for the clock_nanosleep and nanosleep
syscalls.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 300edc4..c87665a 100644
--- a/li
Use the safe_syscall wrapper for readv and writev syscalls.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 31a9484..28f7244 100644
--- a/linux-user/syscall.c
+++ b/l
Use the __get_user() and __put_user() to handle reading and writing the
guest structures in do_ioctl(). This has two benefits:
* avoids possible errors due to misaligned guest pointers
* correctly sign extends signed fields (like l_start in struct flock)
which might be different sizes between
Use the safe_syscall wrapper for the accept and accept4 syscalls.
accept4 has been in the kernel since 2.6.28 so we can assume it
is always present.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/
On 06/06/2016 10:11 AM, Pranith Kumar wrote:
If I read it correctly TCG_BAR_SYNC is equivalent to OR of all the
other four barriers. I am not sure if we can just construct SYNC like
this or if we need to define it explicitly though.
AFAICS, sparc membar #sync is stronger.
Compare PowerPC hwsyn
On 06/06/2016 06:34 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hw/scsi/scsi-disk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index d5e8c8b..4b596d2 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On 6 June 2016 at 18:35, Paolo Bonzini wrote:
> > The following changes since commit 76462405809d29bab65a3699686998ba124ab942:
> >
> > Merge remote-tracking branch
> > 'remotes/pmaydell/tags/pull-target-arm-2
The l_start and l_len fields in the various target_flock structures are
supposed to be '__kernel_off_t' or '__kernel_loff_t', which means they
should be signed, not unsigned. Correcting the structure definitions means
that __get_user() and __put_user() will correctly sign extend them if
the guest i
On 06/05/2016 11:52 PM, Michael Rolnik wrote:
truth table shows that these computations are different.
You're not giving the right inputs to the truth table.
you can't look onto 4th bit because 4th bits in the input were not 0s.
What did you think the xor's do? They remove the non-zero inp
On 6 June 2016 at 18:35, Paolo Bonzini wrote:
> The following changes since commit 76462405809d29bab65a3699686998ba124ab942:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20160606-1' into staging (2016-06-06
> 17:02:42 +0100)
>
> are
Use the safe_syscall wrapper for the semop syscall or IPC operation.
(We implement via the semtimedop syscall to make it easier to
implement the guest semtimedop syscall later.)
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-
Use the safe_syscall wrapper for the rt_sigtimedwait syscall.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 559b4f7..300edc4 100644
--- a/linux-user/syscall.c
+++ b/l
On Mon, Jun 6, 2016 at 7:21 AM, wrote:
> From: KONRAD Frederic
>
> This is the implementation of the DisplayPort.
> It has an aux-bus to access dpcd and edid.
>
> Graphic plane is connected to the channel 3.
> Video plane is connected to the channel 0.
> Audio stream are connected to the channel
Use the safe_syscall wrapper for msgsnd and msgrcv syscalls.
This is made slightly awkward by some host architectures providing
only a single 'ipc' syscall rather than separate syscalls per
operation; we provide safe_msgsnd() and safe_msgrcv() as wrappers
around safe_ipc() to handle this if needed.
Make target_strerror() return 'const char *' rather than just 'char *';
this will allow us to return constant strings from it for some special
cases.
Signed-off-by: Peter Maydell
---
linux-user/qemu.h| 2 +-
linux-user/strace.c | 4 ++--
linux-user/syscall.c | 2 +-
3 files changed, 4 inser
Use the safe_syscall wrapper to implement the ioctl syscall.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index aac2bbd..4cf67c8 100644
--- a/lin
Use the safe_syscall wrapper for the connect syscall.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 28f7244..b649a8c 100644
--- a/linux-user/syscall.c
+++ b/linux-user
This set of pretty dull patches extends the use of the safe_syscall
wrapper to every syscall listed in the signal(7) manpage as being
interruptible.
Most of the patches are just straightforward "use the wrapper" changes.
For a few things get a little more complicated because we need to use
the dir
Use the safe_syscall wrapper for the poll and ppoll syscalls.
Since not all host architectures will have a poll syscall, we
have to rewrite the TARGET_NR_poll handling to use ppoll instead
(we can assume everywhere has ppoll by now).
We take the opportunity to switch to the code structure
already
Use the safe_syscall wrapper for the flock syscall.
Signed-off-by: Peter Maydell
---
linux-user/syscall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index cdc7428..559b4f7 100644
--- a/linux-user/syscall.c
+++ b/linux-user/sy
Use cfi directives in the x86-64 safe_syscall to allow gdb to get
backtraces right from within it. (In particular this will be
quite a common situation if the user interrupts QEMU while it's
in a blocked safe-syscall: at the point of the syscall insn RBP
is in use for something else, and so gdb can
On 05/25/2016 04:36 AM, Fam Zheng wrote:
On Tue, 05/24 11:05, Jason J. Herne wrote:
Thread 13 (Thread 0x3ff989ff910 (LWP 29452)):
#0 0x03ff99abe2c0 in raise () from /lib64/libc.so.6
#1 0x03ff99abfc26 in abort () from /lib64/libc.so.6
#2 0x80427d80 in qemu_coroutine_enter (co=0
On Mon, Jun 6, 2016 at 7:21 AM, wrote:
> From: KONRAD Frederic
>
> This introduces a new bus: aux-bus.
>
> It contains an address space for aux slaves devices and a bridge to an I2C bus
> for I2C through AUX transactions.
>
> Signed-off-by: KONRAD Frederic
> Tested-By: Hyun Kwon
> ---
> defau
On Mon, 6 Jun 2016 16:09:11 +0800
Peter Xu wrote:
> On Thu, Jun 02, 2016 at 07:34:17AM -0600, Alex Williamson wrote:
> > On Thu, 02 Jun 2016 13:09:27 +
> > "Aviv B.D." wrote:
> >
> > > Hi,
> > >
> > > In case of hot plug vfio device there should not be any active mapping
> > > to this de
On 06/06/2016 19:26, Alex Bennée wrote:
>
> Paolo Bonzini writes:
>
>> On 06/06/2016 18:05, Alex Bennée wrote:
- rename qemu_cpu_kick_no_halt to qemu_cpu_kick_rr_cpu and
tcg_current_cpu to tcg_current_rr_cpu; possibly move functions around
>>>
>>> That is this patch isn't it?
>>
>> T
Returns negative error codes and accompanying error messages in cases where
the device has no tray or the tray is locked and isn't forced open. This
extra information should result in better flexibility in functions that
call do_open_tray.
Signed-off-by: Colin Lord
Suggested by: Markus Armbruster
On 06/06/2016 19:55, Peter Maydell wrote:
>> > Signed-off-by: Paolo Bonzini
>> > ---
>> > hw/intc/aspeed_vic.c | 1 -
>> > hw/net/net_tx_pkt.c| 1 +
>> > hw/net/net_tx_pkt.h| 1 -
>> > hw/timer/mc146818rtc.c | 1 -
>> > hw/usb/xen-usb.c | 5 +
>> > include/exec/hwaddr.h | 2
On 6 June 2016 at 18:16, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hw/intc/aspeed_vic.c | 1 -
> hw/net/net_tx_pkt.c| 1 +
> hw/net/net_tx_pkt.h| 1 -
> hw/timer/mc146818rtc.c | 1 -
> hw/usb/xen-usb.c | 5 +
> include/exec/hwaddr.h | 2 --
> include/hw/xen
On 6 June 2016 at 18:15, Paolo Bonzini wrote:
> qemu/osdep.h checks whether MAP_ANONYMOUS is defined, but this check
> is bogus without a previous inclusion of sys/mman.h. Include it in
> sysemu/os-posix.h and remove it from everywhere else.
>
> Signed-off-by: Paolo Bonzini
> diff --git a/block
Andrew Jones writes:
> Allow a thread to wait some specified amount of time. Can
> specify in cycles, usecs, and msecs.
I wonder if delay() and mdelay() can be in common code with just the
freq and count getting functions in specific code? I guess that would
need a lib/arm-generic/ or some such
On Mon, Jun 06, 2016 at 06:39:50PM +0100, Alex Bennée wrote:
>
> Andrew Jones writes:
>
> > Allow a thread to wait some specified amount of time. Can
> > specify in cycles, usecs, and msecs.
>
> I wonder if delay() and mdelay() can be in common code with just the
> freq and count getting functi
From: "Dr. David Alan Gilbert"
Use the avx2 primitives during the test, thus making sure that the
compiler and assembler could actually use avx2.
This also detects the failure case on gcc 4.8.x with -save-temps
and avoids the need for the gcc version check in cutils.
Signed-off-by: Dr. David Al
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 6724cbf..1881969 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequ
On Mon, Jun 06, 2016 at 04:29:11PM +0800, Dong Jia wrote:
> On Sun, 5 Jun 2016 23:27:42 -0700
> Neo Jia wrote:
>
> 2. VFIO_DEVICE_CCW_CMD_REQUEST
> This intends to handle an intercepted channel I/O instruction. It
> basically need to do the following thing:
May I ask how and when QEMU knows that
From: Fam Zheng
Signed-off-by: Fam Zheng
Message-Id: <1464774261-648-2-git-send-email-f...@redhat.com>
Signed-off-by: Paolo Bonzini
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ae75dd2..59af636 100644
--- a/Makefile
+++ b/Makefile
@
From: Fam Zheng
Currently, if not specified in "./configure", QEMU_PKGVERSION will be
empty. Write a rule in Makefile to generate a value from "git describe"
combined with a possible git tree cleanness suffix, and write into a new
header.
$ cat qemu-version.h
#define QEMU_PKGVERSION "-v2
From: "Dr. David Alan Gilbert"
When configured with --extra-cflags=-O2 gcc optimised out the test
and the readelf failed the check leaving avx2 disabled.
Signed-off-by: Dr. David Alan Gilbert
Message-Id: <1464792879-30954-2-git-send-email-dgilb...@redhat.com>
Reviewed-by: Liang Li
Signed-off-b
The following changes since commit 76462405809d29bab65a3699686998ba124ab942:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20160606-1' into staging (2016-06-06
17:02:42 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/fo
From: Fam Zheng
The file is only included from the top Makefile. Rename it to reflect
this more obviously.
Signed-off-by: Fam Zheng
Message-Id: <1464747811-26917-1-git-send-email-f...@redhat.com>
Signed-off-by: Paolo Bonzini
---
Makefile | 2 +-
tests/{Makefile =>
From: Robert Ho
Signed-off-by: Robert Ho
Message-Id: <1464678190-9290-2-git-send-email-robert...@intel.com>
Signed-off-by: Paolo Bonzini
---
qemu-options.hx | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 9f33361..c433143 100644
--- a/qemu-opt
Suggested-by: Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index ab7cf9c..6724cbf 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -284
From: xiaoqiang zhao
The previous commit e7c9136977cb99c6eb52c9139f7b8d8b5fa87db9
(hw/char: QOM'ify escc.c) cause qemu-system-ppc/ppc64
OpenBIOS to freeze on startup, this commit fix it.
Signed-off-by: xiaoqiang zhao
Tested-by: Mark Cave-Ayland
Message-Id: <1464767898-30526-1-git-send-email-zx
On Mon, 6 Jun 2016 15:38:25 +0800
Peter Xu wrote:
> Some questions not quite related to this patch content but vfio...
>
> On Mon, May 23, 2016 at 11:53:42AM -0600, Alex Williamson wrote:
> > On Sat, 21 May 2016 19:19:50 +0300
> > "Aviv B.D" wrote:
>
> [...]
>
> > > +#if 0
> > > static hwa
From: Gerd Hoffmann
This patch extends the functionality of the max-ram-below-4g option
to also allow increasing lowmem. Use case: Give as much memory as
possible to legacy non-PAE guests.
While being at it also rework the lowmem calculation logic and add a
longish comment describing how it wor
From: Prasad J Pandit
The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte
FIFO buffers. One is used to handle commands and other is for
information transfer. Three control variables 'ti_rptr',
'ti_wptr' and 'ti_size' are used to control r/w access to the
information transfer buffer ti
Andrew Jones writes:
> On Mon, Jun 06, 2016 at 05:22:49PM +0100, Alex Bennée wrote:
>>
>> Andrew Jones writes:
>>
>> > Signed-off-by: Andrew Jones
>> > ---
>> > arm/run | 19 ---
>> > arm/selftest.c| 5 -
>> > lib/arm/asm/processor.h | 9 +
Signed-off-by: Paolo Bonzini
---
hw/intc/aspeed_vic.c | 1 -
hw/net/net_tx_pkt.c| 1 +
hw/net/net_tx_pkt.h| 1 -
hw/timer/mc146818rtc.c | 1 -
hw/usb/xen-usb.c | 5 +
include/exec/hwaddr.h | 2 --
include/hw/xen/xen.h | 1 -
include/qemu/fifo32.h | 1 -
replay/replay-char.
Paolo Bonzini writes:
> On 06/06/2016 18:05, Alex Bennée wrote:
>> > - rename qemu_cpu_kick_no_halt to qemu_cpu_kick_rr_cpu and
>> > tcg_current_cpu to tcg_current_rr_cpu; possibly move functions around
>>
>> That is this patch isn't it?
>
> There's some renaming left in patch 14 which complicat
Peter Maydell writes:
> On 6 June 2016 at 16:24, Alex Bennée wrote:
>>
>> Paolo Bonzini writes:
>>
>>> On travis-ci.org, all builds fail with
>>>/usr/include/features.h:324:11: error: unable to open
>>>bits/predefs.h
>>
>> Hmm when did this start failing?
>
> I've seen it before and as
Mark Rutland writes:
> On Mon, Jun 06, 2016 at 05:22:49PM +0100, Alex Bennée wrote:
>> Andrew Jones writes:
>> > +#define MPIDR_LEVEL_SHIFT(level) \
>> > + (((1 << level) >> 1) << 3)
>> > +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>> > + ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & 0xff)
>>
>> D
On 06/06/2016 08:59 AM, Kevin Wolf wrote:
> This patch changes the units that qcow2_get_cluster_offset() uses
> internally, without touching the interface just yet. This will be done
> in another patch.
>
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2-cluster.c | 44 +++-
On 06.06.2016 13:09, Peter Maydell wrote:
On 27 May 2016 at 18:03, Dmitry Osipenko wrote:
Bump VMSD version since a new VMState member is added.
I'm afraid you can't do that -- the ptimer code is used by a lot of
platforms including some which do not permit migration compatibility
breaks (at
On Mon, 6 Jun 2016 21:43:17 +0800
Peter Xu wrote:
> On Mon, Jun 06, 2016 at 07:11:41AM -0600, Alex Williamson wrote:
> > On Mon, 6 Jun 2016 13:04:07 +0800
> > Peter Xu wrote:
> [...]
> > > Besides the reason that there might have guests that do not support
> > > CM=1, will there be performance
On 17/05/16 17:18, Peter Maydell wrote:
> The exception_action() function in user-exec.c is just a call to
> cpu_loop_exit() for every target CPU except i386. Since this
> function is only called if the target's handle_mmu_fault() hook has
> indicated an MMU fault, and that hook is only called fro
On Mon, 6 Jun 2016 16:04:57 +1000
Alexey Kardashevskiy wrote:
> On 04/06/16 02:13, Alex Williamson wrote:
> > On Wed, 1 Jun 2016 18:57:38 +1000
> > Alexey Kardashevskiy wrote:
> >
> >> This makes use of the new "memory registering" feature. The idea is
> >> to provide the userspace ability t
From: Marc-André Lureau
The initial vhost-user connection sets the features to be negotiated
with the driver. Renegotiation isn't possible without device reset.
To handle reconnection of vhost-user backend, ensure the same set of
features are provided, and reuse already acked features.
Signed-o
qemu/osdep.h checks whether MAP_ANONYMOUS is defined, but this check
is bogus without a previous inclusion of sys/mman.h. Include it in
sysemu/os-posix.h and remove it from everywhere else.
Signed-off-by: Paolo Bonzini
---
audio/ossaudio.c| 1 -
block/qcow2-cache.c
From: Tetsuya Mukawa
The patch introduces qemu_chr_disconnect(). The function is used for
closing a fd accepted by listen fd. Though we already have qemu_chr_delete(),
but it closes not only accepted fd but also listen fd. This new function
is used when we still want to keep listen fd.
Signed-of
On Mon, Jun 6, 2016 at 12:14 PM, Sergey Fedorov wrote:
> On 06/06/16 18:58, Pranith Kumar wrote:
>> On Mon, Jun 6, 2016 at 11:49 AM, Sergey Fedorov wrote:
>>> On 06/06/16 18:47, Pranith Kumar wrote:
On Mon, Jun 6, 2016 at 11:44 AM, Sergey Fedorov
wrote:
> On 03/06/16 21:27, Pranit
From: Marc-André Lureau
This patch is a similar solution to what Yuanhan Liu/Huawei Xie have
suggested for DPDK. When vubr quits (killed or crashed), a restart of
vubr would get stale vring base from QEMU. That would break the kernel
virtio net completely, making it non-work any more, unless a dr
From: Tetsuya Mukawa
Current QEMU cannot detect vhost-user backend disconnection. The
patch adds ability to know it.
To know disconnection, add watcher to detect G_IO_HUP event. When
G_IO_HUP event is detected, the disconnected socket will be read
to cause a CHR_EVENT_CLOSED.
Signed-off-by: Tets
On 17/05/16 17:18, Peter Maydell wrote:
> Add a comment to do_interrupt_user() along the same lines as the
> existing one for do_interrupt_all() noting that the next_eip
> argument is not used unless is_int is true or intno is EXCP_SYSCALL.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Sergey Fed
On 06/06/2016 18:05, Alex Bennée wrote:
> > - rename qemu_cpu_kick_no_halt to qemu_cpu_kick_rr_cpu and
> > tcg_current_cpu to tcg_current_rr_cpu; possibly move functions around
>
> That is this patch isn't it?
There's some renaming left in patch 14 which complicates things.
Paolo
>> > - extra
On Mon, Jun 06, 2016 at 05:22:49PM +0100, Alex Bennée wrote:
>
> Andrew Jones writes:
>
> > Signed-off-by: Andrew Jones
> > ---
> > arm/run | 19 ---
> > arm/selftest.c| 5 -
> > lib/arm/asm/processor.h | 9 +++--
> > lib/arm/asm/setup.
On 6 June 2016 at 16:45, Greg Kurz wrote:
> I had added myself to the Cc: list and all the messages I received this
> way are ok. The cover letter has:
>
> Message-Id: <1465216365-13078-1-git-send-email-gk...@linux.vnet.ibm.com>
>
> while the same cover letter on the list has:
>
> Received: from p
On 6 June 2016 at 15:55, Peter Maydell wrote:
> Ping!
Thanks for the review, Sergey. Unless anybody else wants to review
or wants to take it through their tree (Riku?), I propose to apply
this to master sometime later this week.
thanks
-- PMM
> On 17 May 2016 at 15:18, Peter Maydell wrote:
>>
On 06/06/2016 18:34, P J P wrote:
> From: Prasad J Pandit
>
> The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte
> FIFO buffers. One is used to handle commands and other is for
> information transfer. Three control variables 'ti_rptr',
> 'ti_wptr' and 'ti_size' are used to control
From: Marc-André Lureau
Do not overwrite x86-64 tests, re-enable vhost-user-test.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index a3e20e3..932ad2a 100644
--- a
Public bug reported:
qemu/hw/scsi/scsi-disk.c:2741] -> [qemu/hw/scsi/scsi-disk.c:2745]: (warning)
Variable 'cdb1' is reassigned a value before the old one has been used.
'break;' missing?
qemu/hw/scsi/scsi-disk.c:2742] -> [qemu/hw/scsi/scsi-disk.c:2746]: (warning)
Variable 'group_number' is rea
From: Marc-André Lureau
A driver may change the vring enable state at run time but vhost-user
backend may not be present (a contrived example is when the backend is
disconnected and the device is reconfigured after driver rebinding)
Restore the vring state when the vhost-user backend is started,
From: Marc-André Lureau
This is a simple reconnect test, that simply checks if vhost-user
reconnection is possible and restore the state. A more complete test
would actually manipulate and check the ring contents (such extended
testing would benefit from the libvhost-user proposed in QEMU list to
From: Marc-André Lureau
If the backend failed to start (for example feature negociation failed),
do not exit, but disconnect the char device instead. Slightly more
robust for reconnect case.
Signed-off-by: Marc-André Lureau
Tested-by: Yuanhan Liu
Reviewed-by: Yuanhan Liu
---
net/vhost-user.c
The eval trick for defining DOCKER_SRC_COPY doesn't do anything
useful, as DOCKER_SRC_COPY is immediately expanded just after it
is defined, and CUR_TIME is already defined using ":=". Simply
define it using ":=" so it is evaluated only once.
The eval trick was also triggering an weird error on Tr
From: Marc-André Lureau
Hi,
In a previous series "RFCv2: vhost-user: shutdown and reconnection", I
proposed to add a new slave request to handle graceful shutdown, for
both qemu configuration, server or client, while keeping the guest
running with link down status.
However, for the simple case
From: Marc-André Lureau
Do not crash when backend is not present while enabling the ring. A
following patch will save the enabled state so it can be restored once
the backend is started.
Signed-off-by: Marc-André Lureau
Tested-by: Yuanhan Liu
Reviewed-by: Yuanhan Liu
---
hw/net/vhost_net.c |
From: Marc-André Lureau
If -c is specified, vubr will try to connect to the socket instead of
listening for connections.
Signed-off-by: Marc-André Lureau
Tested-by: Yuanhan Liu
Reviewed-by: Yuanhan Liu
---
tests/vhost-user-bridge.c | 38 ++
1 file changed,
On Mon, Jun 6, 2016 at 11:44 AM, Sergey Fedorov wrote:
> On 03/06/16 21:27, Pranith Kumar wrote:
>> On Thu, Jun 2, 2016 at 5:18 PM, Richard Henderson wrote:
>>>
>>> What if we have tcg_canonicalize_memop (or some such) split off the barriers
>>> into separate opcodes. E.g.
>>>
>>> MO_BAR_LD_B =
On Mon, Jun 06, 2016 at 05:22:49PM +0100, Alex Bennée wrote:
> Andrew Jones writes:
> > +#define MPIDR_LEVEL_SHIFT(level) \
> > + (((1 << level) >> 1) << 3)
> > +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
> > + ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & 0xff)
>
> Doesn't Aff3 break this little
On 6 June 2016 at 16:24, Alex Bennée wrote:
>
> Paolo Bonzini writes:
>
>> On travis-ci.org, all builds fail with
>>/usr/include/features.h:324:11: error: unable to open
>>bits/predefs.h
>
> Hmm when did this start failing?
I've seen it before and assumed it was another "random
transient
On 03/06/2016 22:40, Alex Bennée wrote:
> +/* Kick the currently round-robin scheduled vCPU */
> +static void qemu_cpu_kick_rr_cpu(void)
> +{
> +CPUState *cpu;
> +do {
> +cpu = atomic_mb_read(&tcg_current_rr_cpu);
> +if (cpu) {
> +cpu_exit(cpu);
> +}
>
;
>
> git://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/pull-target-arm-20160606-1
>
> for you to fetch changes up to 0c18c6c67e06859ef354b697cce567ebe29061f1:
>
> zynqmp: Add the ZCU102 board (2016-06-06 16:59:32 +0100)
>
Applied the v2 to master, thanks.
-- PMM
From: Prasad J Pandit
The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte
FIFO buffers. One is used to handle commands and other is for
information transfer. Three control variables 'ti_rptr',
'ti_wptr' and 'ti_size' are used to control r/w access to the
information transfer buffer ti
On 06/06/16 18:58, Pranith Kumar wrote:
> On Mon, Jun 6, 2016 at 11:49 AM, Sergey Fedorov wrote:
>> On 06/06/16 18:47, Pranith Kumar wrote:
>>> On Mon, Jun 6, 2016 at 11:44 AM, Sergey Fedorov
>>> wrote:
On 03/06/16 21:27, Pranith Kumar wrote:
> On Thu, Jun 2, 2016 at 5:18 PM, Richard He
considering that features are converted to
global properties and global properties are
automatically applied to every new instance
of created CPU (at object_new() time), there
is no point in parsing cpu_model string every
time a CPU created.
So move parsing outside CPU creation loop and
do it only
We're most probably seeing the same while migrating a machine running balanceng
but haven't thought this might be a qemu bug. Instead we're investigating with
balanceng people.
Waiting for your further results.
Greets,
Stefan
Excuse my typo sent from my mobile phone.
> Am 06.06.2016 um 17:51
101 - 200 of 473 matches
Mail list logo
