[Qemu-devel] [PULL 27/32] nvdimm acpi: check revision

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Currently only revision 1 is supported Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi

[Qemu-devel] [PULL 32/32] MAINTAINERS: add Marcel to PCI

2016-06-13 Thread Michael S. Tsirkin
Marcel is reviewing PCI patches anyway, things will be easier if people remember to Cc him. Cc: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index df990a8..fe2279e 100644 --- a/MAINTAINERS +++ b/

Re: [Qemu-devel] [PATCH v6 01/13] bitops: Add MAKE_64BIT_MASK macro

2016-06-13 Thread Alistair Francis
On Thu, Jun 9, 2016 at 11:46 AM, Peter Maydell wrote: > On 12 May 2016 at 23:45, Alistair Francis wrote: >> Add a macro that creates a 64bit value which has length number of ones >> shifted acrros by the value of shift. > > "across" > >> >> Signed-off-by: Alistair Francis >> Reviewed-by: Alex Be

[Qemu-devel] [PULL 20/32] nvdimm: support nvdimm label

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Introduce a parameter, 'label-size', which is the size of nvdimm label data area which is reserved at the end of backend memory. It is required at least 128k Two callbacks, read_label_data() and write_label_data(), are used to operate the label area Reviewed-by: Stefan Hajn

[Qemu-devel] [PULL 21/32] acpi: add aml_object_type

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Implement ObjectType which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 8 ++

Re: [Qemu-devel] [PATCH v3 0/4] enable iommu with -device

2016-06-13 Thread Michael S. Tsirkin
On Mon, Jun 13, 2016 at 05:36:56PM +0300, Marcel Apfelbaum wrote: > Create the iommu device with '-device intel-iommu' instead of > '-machine,iommu=on'. > > The device is part of the machine properties because we wanted > to ensure is created before any other PCI device. > > The alternative is

[Qemu-devel] [PULL 30/32] nvdimm acpi: support Set Namespace Label Data function

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Function 6 is used to set Namespace Label Data Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 44 ++

[Qemu-devel] [PULL 18/32] msi_init: change return value to 0 on success

2016-06-13 Thread Michael S. Tsirkin
From: Cao jin No caller use its return value as msi capability offset, also in order to make its return behaviour consistent with msix_init(). cc: Michael S. Tsirkin cc: Paolo Bonzini cc: Hannes Reinecke cc: Markus Armbruster cc: Marcel Apfelbaum Acked-by: Hannes Reinecke Reviewed-by: Mar

Re: [Qemu-devel] [PATCH 03/10] tests/vhost-user-bridge: workaround stale vring base

2016-06-13 Thread Michael S. Tsirkin
On Thu, Jun 09, 2016 at 12:25:54PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Jun 9, 2016 at 12:07 PM, Victor Kaplansky wrote: > > What if set_vring_base is called after set_vring_addr? > > Maybe it is worth to add the fixup to the set_vring_base as well? > > It would need to handle condit

[Qemu-devel] [PULL 17/32] fix some coding style problems

2016-06-13 Thread Michael S. Tsirkin
From: Cao jin It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it more readable. cc: Michael S. Tsirkin cc: Markus Armbru

[Qemu-devel] [PULL 28/32] nvdimm acpi: support Get Namespace Label Size function

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Function 4 is used to get Namespace label size Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 130 +

[Qemu-devel] [PULL 15/32] bios: Add tests for the IPMI ACPI and SMBIOS entries

2016-06-13 Thread Michael S. Tsirkin
From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test.c | 60 --- tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5575 bytes tests/acpi-test-data/q35/DSDT.ipmi

[Qemu-devel] [PULL 24/32] nvdimm acpi: save arg3 of _DSM method

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Check if the input Arg3 is valid then store it into ARG3 if it is needed Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 20 1 file changed, 20 inser

[Qemu-devel] [PULL 14/32] acpi: Add IPMI table entries

2016-06-13 Thread Michael S. Tsirkin
From: Corey Minyard Use the ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called build_acpi_ipmi_devices to add an DSDT entry for IPMI if IPMI is compiled in and an IPMI device exists. It also adds a dummy function if IPMI is not compiled in. This conform

[Qemu-devel] [PULL 26/32] nvdimm acpi: abstract the operations for root & nvdimm devices

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong It separates the operations between root device and nvdimm devices in order to introducing label functions support for nvdimm device Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/

[Qemu-devel] [PULL 12/32] smbios: Move table build tools into an include file.

2016-06-13 Thread Michael S. Tsirkin
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/smbios/smbios_build.h | 87 hw/smbios/smbios.c

[Qemu-devel] [PULL 25/32] nvdimm acpi: check UUID

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Check arg0 which indicates UUID to see if it is valid Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 32 ++-- 1 file changed, 26 insertions(+

[Qemu-devel] [PULL 13/32] ipmi: Add SMBIOS table entry

2016-06-13 Thread Michael S. Tsirkin
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/smbios/ipmi.h | 15 ++ hw/smbios/no_smbios_type_38.c | 14 + hw/smbios/smbios.c| 2 + hw/smbio

[Qemu-devel] [PULL 22/32] acpi: add aml_call5

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong It will be used by NVDIMM ACPI Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi/aml-build.c | 14 ++ 2 files changed, 16 inse

[Qemu-devel] [PULL 09/32] vhost-net: save & restore vring enable state

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau A driver may change the vring enable state at run time but vhost-user backend may not be present (a contrived example is when the backend is disconnected and the device is reconfigured after driver rebinding) Restore the vring state when the vhost-user backend is started,

[Qemu-devel] [PULL 23/32] nvdimm acpi: set HDLE properly

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong Now we pass HDLE to Qemu properly, use 0 for root device and use the handle for nvdimm devices Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 22 --

[Qemu-devel] [PULL 08/32] vhost-net: save & restore vhost-user acked features

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau The initial vhost-user connection sets the features to be negotiated with the driver. Renegotiation isn't possible without device reset. To handle reconnection of vhost-user backend, ensure the same set of features are provided, and reuse already acked features. Signed-o

[Qemu-devel] [PULL 19/32] pc-dimm: introduce get_vmstate_memory_region callback

2016-06-13 Thread Michael S. Tsirkin
From: Xiao Guangrong This callback returns the MemoryRegion that is the memory of dimm should be kept during live migration nvdimm device is different with pc-dimm as its memory includes not only the MemoryRegion directly mapping to guest's address space but also the memory used as label data S

[Qemu-devel] [PULL 07/32] vhost-net: do not crash if backend is not present

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau Do not crash when backend is not present while enabling the ring. A following patch will save the enabled state so it can be restored once the backend is started. Signed-off-by: Marc-André Lureau Tested-by: Yuanhan Liu Reviewed-by: Yuanhan Liu Reviewed-by: Victor Kapla

[Qemu-devel] [PULL 16/32] pci core: assert ENOSPC when add capability

2016-06-13 Thread Michael S. Tsirkin
From: Cao jin ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Reviewed-by: Markus Armbruster Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin Reviewed-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Signed

[Qemu-devel] [PULL 06/32] vhost-user: disconnect on start failure

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau If the backend failed to start (for example feature negociation failed), do not exit, but disconnect the char device instead. Slightly more robust for reconnect case. Signed-off-by: Marc-André Lureau Tested-by: Yuanhan Liu Reviewed-by: Yuanhan Liu Reviewed-by: Victor K

[Qemu-devel] [PULL 03/32] tests/vhost-user-bridge: add client mode

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau If -c is specified, vubr will try to connect to the socket instead of listening for connections. Signed-off-by: Marc-André Lureau Tested-by: Yuanhan Liu Reviewed-by: Yuanhan Liu Reviewed-by: Victor Kaplansky Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. T

[Qemu-devel] [PULL 11/32] test: start vhost-user reconnect test

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau This is a simple reconnect test, that simply checks if vhost-user reconnection is possible and restore the state. A more complete test would actually manipulate and check the ring contents (such extended testing would benefit from the libvhost-user proposed in QEMU list to

[Qemu-devel] [PULL 02/32] vhost-user: add ability to know vhost-user backend disconnection

2016-06-13 Thread Michael S. Tsirkin
From: Tetsuya Mukawa Current QEMU cannot detect vhost-user backend disconnection. The patch adds ability to know it. To know disconnection, add watcher to detect G_IO_HUP event. When G_IO_HUP event is detected, the disconnected socket will be read to cause a CHR_EVENT_CLOSED. Signed-off-by: Tets

[Qemu-devel] [PULL 10/32] tests: append i386 tests

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau Do not overwrite x86-64 tests, re-enable vhost-user-test. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Victor Kaplansky Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/Makefile | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [PULL 04/32] tests/vhost-user-bridge: workaround stale vring base

2016-06-13 Thread Michael S. Tsirkin
From: Marc-André Lureau This patch is a similar solution to what Yuanhan Liu/Huawei Xie have suggested for DPDK. When vubr quits (killed or crashed), a restart of vubr would get stale vring base from QEMU. That would break the kernel virtio net completely, making it non-work any more, unless a dr

[Qemu-devel] [PULL 05/32] qemu-char: add qemu_chr_disconnect to close a fd accepted by listen fd

2016-06-13 Thread Michael S. Tsirkin
From: Tetsuya Mukawa The patch introduces qemu_chr_disconnect(). The function is used for closing a fd accepted by listen fd. Though we already have qemu_chr_delete(), but it closes not only accepted fd but also listen fd. This new function is used when we still want to keep listen fd. Signed-of

[Qemu-devel] [PULL 00/32] pc, pci, virtio: new features, cleanups, fixes

2016-06-13 Thread Michael S. Tsirkin
The following changes since commit c02d7030c3c538312c7f464cb79b72c29a20df74: virtio: move bi-endian target support to a single location (2016-06-07 15:39:28 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch

[Qemu-devel] [PULL 01/32] pci: fix pci_requester_id()

2016-06-13 Thread Michael S. Tsirkin
From: Peter Xu This fix SID verification failure when IOMMU IR is enabled with PCI bridges. Existing pci_requester_id() is more like getting BDF info only. Renaming it to pci_get_bdf(). Meanwhile, we provide the correct implementation to get requester ID. VT-d spec 5.1.1 is a good reference to go

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-13 Thread Andrew Jones
On Mon, Jun 13, 2016 at 07:04:01PM +0200, Paolo Bonzini wrote: > > > On 10/06/2016 19:40, Andrew Jones wrote: > > +if (sockets == -1 || cores == -1 || threads == -1 || > > +maxcpus == -1 || cpus == -1) { > > +error_report("cpu topology: " > > + "all machine

Re: [Qemu-devel] [PATCH v8 00/17] Add param Error ** for msi_init()

2016-06-13 Thread Michael S. Tsirkin
On Mon, Jun 13, 2016 at 10:45:18PM +0300, Michael S. Tsirkin wrote: > Thanks! > I applied 1-12. And reverted most of them except 1-2: make check fails. Pls rebase, retest and repost. Thanks! > One of the cleanups breaks cross-version migration, so > I decided to defer them all. Once 1st part is

[Qemu-devel] [PATCHv2 1/2] MAINTAINERS: add Artyom Tarasenko as SPARC maintainer

2016-06-13 Thread Mark Cave-Ayland
Artyom has been working on QEMU's SPARC emulation for several years, providing initial support for Solaris under qemu-system-sparc and more recently bugfixes for qemu-system-sparc64 and TCG patch reviews. As work progresses on improving emulation for sun4u machines and beyond, Artyom has agreed to

Re: [Qemu-devel] [PATCH 09/11] blockdev-backup: added support for data compression

2016-06-13 Thread Eric Blake
On 05/31/2016 03:15 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > +++ b/qapi/block-core.json > @@ -926,6 +926,9 @@ > #

Re: [Qemu-devel] [PATCH v6 08/11] target-avr: adding instruction translation

2016-06-13 Thread Michael Rolnik
what is the difference between tcg_gen_qemu_st16 and tcg_gen_qemu_st_tl On Mon, Jun 13, 2016 at 7:06 PM, Richard Henderson wrote: > On 06/12/2016 12:01 PM, Michael Rolnik wrote: > >> +void gen_push_ret(CPUAVRState *env, int ret) >> +{ >> +if (avr_feature(env, AVR_FEATURE_1_BYTE_PC)) { >> + >

[Qemu-devel] [PATCHv2 2/2] MAINTAINERS: remove Blue Swirl as SPARC maintainer

2016-06-13 Thread Mark Cave-Ayland
Blue is no longer active in the QEMU project, so remove him from the list of SPARC maintainers. Signed-off-by: Mark Cave-Ayland CC: Blue Swirl --- MAINTAINERS |1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 081bf20..fdd0057 100644 --- a/MAINTAINERS +++ b/MA

Re: [Qemu-devel] [PATCH 1/7] nios2: Add disas entries

2016-06-13 Thread Eric Blake
On 06/13/2016 02:11 PM, Sandra Loosemore wrote: >>> This is a non-starter. Qemu is a GPLv2-only project because of some of >>> the files it has already borrowed from other places, so we CANNOT use >>> GPLv3 files. You'll have to implement this from scratch, or pull from >>> binutils at the point

Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression

2016-06-13 Thread Eric Blake
On 05/31/2016 03:15 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > The patch adds a flag to the qmp/hmp drive-backup comm

Re: [Qemu-devel] [PATCH v7 3/3] docs: Add a generic loader explanation document

2016-06-13 Thread Alistair Francis
On Mon, Jun 13, 2016 at 10:49 AM, Peter Maydell wrote: > On 13 June 2016 at 18:45, Alistair Francis > wrote: >> On Thu, Jun 9, 2016 at 10:45 AM, Peter Maydell >> wrote: >>> On 25 May 2016 at 19:49, Alistair Francis >>> wrote: Signed-off-by: Alistair Francis --- V6: - Fi

[Qemu-devel] [PATCHv2 0/2] MAINTAINERS: update entries for SPARC

2016-06-13 Thread Mark Cave-Ayland
Update MAINTAINERS for SPARC: add Artyom Tarasenko and remove Blue Swirl. Signed-off-by: Mark Cave-Ayland Mark Cave-Ayland (2): MAINTAINERS: add Artyom Tarasenko as SPARC maintainer MAINTAINERS: remove Blue Swirl as SPARC maintainer MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-13 Thread Eric Blake
On 06/13/2016 07:11 AM, Stefan Hajnoczi wrote: > On Tue, May 31, 2016 at 12:15:26PM +0300, Denis V. Lunev wrote: >> diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h >> index 57df069..3d7b446 100644 >> --- a/include/sysemu/block-backend.h >> +++ b/include/sysemu/block-bac

Re: [Qemu-devel] [PATCH 03/11] qcow2: add qcow2_co_write_compressed

2016-06-13 Thread Eric Blake
On 05/31/2016 03:15 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Added implementation of the qcow2_co_write_compressed function that > will allow us to safely use compressed writes for the qcow2 from running VMs. > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: J

Re: [Qemu-devel] [PATCH 1/7] nios2: Add disas entries

2016-06-13 Thread Sandra Loosemore
On 06/13/2016 01:40 PM, Marek Vasut wrote: On 06/13/2016 09:15 PM, Eric Blake wrote: On 06/13/2016 01:05 PM, Marek Vasut wrote: Add nios2 disassembler support. This patch is composed from binutils files from commit "Opcodes and assembler support for Nios II R2". The files from binutils used in

[Qemu-devel] [PATCH] MAINTAINERS: add Marcel to PCI

2016-06-13 Thread Michael S. Tsirkin
Marcel is reviewing PCI patches anyway, things will be easier if people remember to Cc him. Cc: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index df990a8..fe2279e 100644 --- a/MAINTAINERS +++ b/

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Artyom Tarasenko as SPARC maintainer

2016-06-13 Thread Mark Cave-Ayland
On 08/06/16 17:15, Laurent Vivier wrote: > On 08/06/2016 17:02, Artyom Tarasenko wrote: >> On Wed, Jun 8, 2016 at 4:46 PM, Markus Armbruster wrote: >>> Mark Cave-Ayland writes: >>> Artyom has been working on QEMU's SPARC emulation for several years, providing initial support for

Re: [Qemu-devel] [PATCH 6/6] trace: enable tracing in qemu-img

2016-06-13 Thread Eric Blake
On 06/13/2016 10:58 AM, Denis V. Lunev wrote: > The command will work this way: > qemu-img --trace qcow2* create -f qcow2 1.img 64G > > Signed-off-by: Denis V. Lunev > Suggested by: Daniel P. Berrange > CC: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > Ma

Re: [Qemu-devel] [PATCH v8 00/17] Add param Error ** for msi_init()

2016-06-13 Thread Michael S. Tsirkin
Thanks! I applied 1-12. One of the cleanups breaks cross-version migration, so I decided to defer them all. Once 1st part is merged, please rebase and repost. On Fri, Jun 10, 2016 at 05:54:21PM +0800, Cao jin wrote: > v8 changelog: > 1. address all stylistic remarks (Markus) > 2. add two new patch

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables

2016-06-13 Thread Eduardo Habkost
On Mon, Jun 13, 2016 at 08:49:37PM +0200, Markus Armbruster wrote: > Eric Blake writes: [...] > >> > >> See, e.g.: > >> > >> void qmp_guest_suspend_disk(Error **errp) > >> { > >> Error *local_err = NULL; > >> GuestSuspendMode *mode = g_new(GuestSuspendMode, 1); > >> > >> *mode = GUE

Re: [Qemu-devel] [PATCH 5/6] qemu-img: move common options parsing before commands processing

2016-06-13 Thread Eric Blake
On 06/13/2016 10:58 AM, Denis V. Lunev wrote: > This is necessary to enable creation of common qemu-img options which will > be specified before command. > > The patch also enables '-V' alias to '--version' (exactly like in other > block utilities) and documents this change. > > Signed-off-by: De

Re: [Qemu-devel] [PATCH v8 15/17] vmw_pvscsi: remove unnecessary internal msi state flag

2016-06-13 Thread Michael S. Tsirkin
On Fri, Jun 10, 2016 at 05:54:36PM +0800, Cao jin wrote: > Internal flag msi_used is uncesessary, msi_uninit() could be called > directly, msi_enabled() is enough to check device msi state. > > cc: Paolo Bonzini > cc: Dmitry Fleytman > cc: Markus Armbruster > cc: Marcel Apfelbaum > cc: Michael

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables

2016-06-13 Thread Eduardo Habkost
On Mon, Jun 13, 2016 at 10:01:16AM -0600, Eric Blake wrote: > On 06/13/2016 09:52 AM, Eduardo Habkost wrote: [...] > > > > See, e.g.: > > > > void qmp_guest_suspend_disk(Error **errp) > > { > > Error *local_err = NULL; > > GuestSuspendMode *mode = g_new(GuestSuspendMode, 1); > > > >

Re: [Qemu-devel] [PATCH 1/7] nios2: Add disas entries

2016-06-13 Thread Marek Vasut
On 06/13/2016 09:15 PM, Eric Blake wrote: > On 06/13/2016 01:05 PM, Marek Vasut wrote: >> Add nios2 disassembler support. This patch is composed from binutils files >> from commit "Opcodes and assembler support for Nios II R2". The files from >> binutils used in this patch are: >> > >> +++ b/disas

Re: [Qemu-devel] [PATCH 4/6] trace: enable tracing in qemu-nbd

2016-06-13 Thread Eric Blake
On 06/13/2016 10:58 AM, Denis V. Lunev wrote: > Please note, trace_init_backends() must be called in the final process, > i.e. after daemonization. This is necessary to keep tracing thread in > the proper process. > > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Paolo Bonzini > CC: Stef

Re: [Qemu-devel] [PATCH 1/6] doc: move text describing --trace to specific .texi file

2016-06-13 Thread Eric Blake
On 06/13/2016 10:58 AM, Denis V. Lunev wrote: > This text will be included to qemu-nbd/qemu-img mans in the next patches. > > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > +++ b/qemu-option-trace.texi > @@ -0,0 +1,27 @@ > +@

Re: [Qemu-devel] [PATCH 1/7] nios2: Add disas entries

2016-06-13 Thread Eric Blake
On 06/13/2016 01:05 PM, Marek Vasut wrote: > Add nios2 disassembler support. This patch is composed from binutils files > from commit "Opcodes and assembler support for Nios II R2". The files from > binutils used in this patch are: > > +++ b/disas/nios2.c > @@ -0,0 +1,3620 @@ > +/* > + * This fil

[Qemu-devel] [PATCH 4/7] nios2: Add IIC interrupt controller emulation

2016-06-13 Thread Marek Vasut
From: Chris Wulff Add the Altera Nios2 internal interrupt controller model. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- hw/intc/Makefile.objs | 1 + hw/intc/nios2_iic.c | 103 +

[Qemu-devel] [PATCH 1/7] nios2: Add disas entries

2016-06-13 Thread Marek Vasut
Add nios2 disassembler support. This patch is composed from binutils files from commit "Opcodes and assembler support for Nios II R2". The files from binutils used in this patch are: include/opcode/nios2.h include/opcode/nios2r1.h include/opcode/nios2r2.h opcodes/nios2-opc.c op

[Qemu-devel] [PATCH 3/7] nios2: Add usermode binaries emulation

2016-06-13 Thread Marek Vasut
Add missing bits for qemu-user required for emulating Altera Nios2 userspace binaries. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- include/elf.h | 2 + linux-user/elfload.c |

[Qemu-devel] [PATCH 2/7] nios2: Add architecture emulation support

2016-06-13 Thread Marek Vasut
From: Chris Wulff Add support for emulating Altera NiosII R1 architecture into qemu. This patch is based on previous work by Chris Wulff from 2012 and updated to latest mainline QEMU. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves

[Qemu-devel] [PATCH 7/7] nios2: Add support for Nios-II R1

2016-06-13 Thread Marek Vasut
Add remaining bits of the Altera NiosII R1 support into qemu, which is documentation, MAINTAINERS file entry, configure bits, arch_init and configuration files for both linux-user (userland binaries) and softmmu (hardware emulation). Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva

[Qemu-devel] [PATCH 6/7] nios2: Add Altera 10M50 GHRD emulation

2016-06-13 Thread Marek Vasut
Add the Altera 10M50 Nios2 GHRD model. This allows emulating the 10M50 development kit with the Nios2 GHRD loaded in the FPGA. It is possible to boot Linux kernel and run userspace, thus far only from initrd as storage support is not yet implemented. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc

[Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-06-13 Thread Marek Vasut
From: Chris Wulff Add the Altera timer model. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- hw/timer/Makefile.objs | 1 + hw/timer/altera_timer.c | 225 2 fil

[Qemu-devel] [PATCH v2 0/2] Fix incomplete aio_preadv byte conversion in mirroring

2016-06-13 Thread Eric Blake
v2: Split the bug fix from the addition of assertions, add a BDRV_REQ_MASK constant [famz], stick assertions at the more common entry points Eric Blake (2): block: Avoid bogus flags during mirroring block: Assert that flags are in range include/block/block.h | 3 +++ block/io.c|

Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-06-13 Thread Eric Blake
On 06/13/2016 11:43 AM, Cédric Le Goater wrote: > On 06/13/2016 06:47 PM, Eric Blake wrote: >> On 06/13/2016 10:25 AM, Cédric Le Goater wrote: >> >>> >>> It seems that commit 243e6f69c129 ("m25p80: Switch to byte-based block >>> access") >>> is bringing another issue : >>> >>> qemu-system-arm: >

[Qemu-devel] [PATCH v2 2/2] block: Assert that flags are in range

2016-06-13 Thread Eric Blake
Add a new BDRV_REQ_MASK constant, and use it to make sure that caller flags are always valid. Tested with 'make check' and with qemu-iotests on both '-raw' and '-qcow2'; the only failure turned up was fixed in the previous commit. Signed-off-by: Eric Blake --- include/block/block.h | 3 +++ blo

[Qemu-devel] [PATCH v2 1/2] block: Avoid bogus flags during mirroring

2016-06-13 Thread Eric Blake
Commit e253f4b8 converted mirroring from sector-based bdrv_aio_* to byte-based blk_aio_*, but failed to account for the subtle difference in signatures (the former takes a semi-redundant length, the latter takes a flags parameter). Since all of our flags are currently smaller in size than BDRV_SEC

[Qemu-devel] [Bug 1591628] Re: 2.6.0 hangs linux vm using vfio for pci passthrough of graphics card

2016-06-13 Thread Peter Maloney
** Attachment added: "screenshot fail while booting memtest86+" https://bugs.launchpad.net/qemu/+bug/1591628/+attachment/4683121/+files/IMG_9592_qemu_fail_memtest.JPG -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

[Qemu-devel] [Bug 1591628] Re: 2.6.0 hangs linux vm using vfio for pci passthrough of graphics card

2016-06-13 Thread Peter Maloney
** Attachment added: "screenshot fail while booting linux grsec 4.1.6" https://bugs.launchpad.net/qemu/+bug/1591628/+attachment/4683120/+files/IMG_9591_qemu_fail_linux.JPG -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Qemu-devel] [Bug 1591628] Re: 2.6.0 hangs linux vm using vfio for pci passthrough of graphics card

2016-06-13 Thread Peter Maloney
** Attachment added: "grub.cfg with only memtest86+ entry remaining and set as default" https://bugs.launchpad.net/qemu/+bug/1591628/+attachment/4683122/+files/grub.cfg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables

2016-06-13 Thread Markus Armbruster
Eric Blake writes: > On 06/13/2016 09:52 AM, Eduardo Habkost wrote: > >>> >>> There is an (ugly) difference between >>> >>> error_setg(&local_err, ...); >>> error_propagate(errp, &local_err); >>> >>> and >>> >>> error_setg(errp, ...); >>> >>> The latter aborts when @errp already conta

[Qemu-devel] [Bug 1591628] Re: 2.6.0 hangs linux vm using vfio for pci passthrough of graphics card

2016-06-13 Thread Peter Maloney
(changed your command with a different iso, and without the usb-host, and with a pci passthrough of a usb controller, and with a vgarom for my gpu otherwise I find it hangs if I repeatedly reboot a VM) If I try with your command with an iso it works. If I replace the iso with the VM's disk, it fai

Re: [Qemu-devel] [PATCH 00/10] vhost-user: simple reconnection support

2016-06-13 Thread Michael S. Tsirkin
On Thu, Jun 09, 2016 at 05:14:42PM +0300, Victor Kaplansky wrote: > Hi MST, I've reviewed the patches and they are fine. > >From my perspective we can pull them into upstream. In the future please send: Reviewed-by: Victor Kaplansky Thanks! -- MST

Re: [Qemu-devel] [PATCH v7 2/3] generic-loader: Add a generic loader

2016-06-13 Thread Peter Maydell
On 13 June 2016 at 18:25, Alistair Francis wrote: > On Thu, Jun 9, 2016 at 10:50 AM, Peter Maydell > wrote: >> On 25 May 2016 at 19:49, Alistair Francis >> wrote: >>> +uint16_t cpu_num; >> >> (Why 16 bits in particular?) > > No reason in particular. Do you think it should be something else

Re: [Qemu-devel] [PATCH] block-backend: allow flush on devices with open tray

2016-06-13 Thread John Snow
On 06/10/2016 06:42 PM, Eric Blake wrote: > On 06/10/2016 03:59 PM, John Snow wrote: >> If a device still has an attached BDS because the medium has not yet >> been removed, we will be unable to migrate to a new host because >> blk_flush will return an error for that backend. >> >> Replace the ca

Re: [Qemu-devel] [PATCH v7 3/3] docs: Add a generic loader explanation document

2016-06-13 Thread Peter Maydell
On 13 June 2016 at 18:45, Alistair Francis wrote: > On Thu, Jun 9, 2016 at 10:45 AM, Peter Maydell > wrote: >> On 25 May 2016 at 19:49, Alistair Francis >> wrote: >>> Signed-off-by: Alistair Francis >>> --- >>> V6: >>> - Fixup documentation >>> V4: >>> - Re-write to be more comprehensive >>

Re: [Qemu-devel] [PATCH v4] spapr: Ensure all LMBs are represented in ibm, dynamic-memory

2016-06-13 Thread Nathan Fontenot
On 06/10/2016 12:14 AM, Bharata B Rao wrote: > Memory hotplug can fail for some combinations of RAM and maxmem when > DDW is enabled in the presence of devices like nec-usb-xhci. DDW depends > on maximum addressable memory returned by guest and this value is currently > being calculated wrongly by

Re: [Qemu-devel] [PATCH v7 3/3] docs: Add a generic loader explanation document

2016-06-13 Thread Alistair Francis
On Thu, Jun 9, 2016 at 10:45 AM, Peter Maydell wrote: > On 25 May 2016 at 19:49, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> --- >> V6: >> - Fixup documentation >> V4: >> - Re-write to be more comprehensive >> >> docs/generic-loader.txt | 54 >> +

Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-06-13 Thread Cédric Le Goater
On 06/13/2016 06:47 PM, Eric Blake wrote: > On 06/13/2016 10:25 AM, Cédric Le Goater wrote: > >> >> It seems that commit 243e6f69c129 ("m25p80: Switch to byte-based block >> access") >> is bringing another issue : >> >> qemu-system-arm: >> /home/legoater/work/qemu/qemu-ast2400-mainline.git/bloc

Re: [Qemu-devel] [PATCH v3 00/15] mirror: follow AioContext change gracefully

2016-06-13 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 6:05 PM, Stefan Hajnoczi wrote: > Daniel P. Berrange (1): > ui: fix regression in printing VNC host/port on startup > > Gerd Hoffmann (2): > vnc: drop unused depth arg for set_pixel_format > console: ignore ui_info updates which don't actually update something > > Ola

Re: [Qemu-devel] [PATCH v7 2/3] generic-loader: Add a generic loader

2016-06-13 Thread Alistair Francis
On Thu, Jun 9, 2016 at 10:50 AM, Peter Maydell wrote: > On 25 May 2016 at 19:49, Alistair Francis wrote: >> Add a generic loader to QEMU which can be used to load images or set >> memory values. >> >> Signed-off-by: Alistair Francis >> --- >> V7: >> - Rebase >> V6: >> - Add error checking >> V

Re: [Qemu-devel] [PATCH v7 1/3] loader: Allow ELF loader to auto-detect the ELF arch

2016-06-13 Thread Alistair Francis
On Thu, Jun 9, 2016 at 10:38 AM, Peter Maydell wrote: > On 25 May 2016 at 19:49, Alistair Francis wrote: >> If the caller didn't specify an architecture for the ELF machine >> the load_elf() function will auto detect it based on the ELF file. >> >> Signed-off-by: Alistair Francis >> --- >> V7: >

[Qemu-devel] [PATCH v3 14/15] blockjob: add AioContext attach/detach callbacks

2016-06-13 Thread Stefan Hajnoczi
Block jobs need callbacks to get their affairs in order when the AioContext is switched. Simple block jobs can get away without implementing these callbacks. The callbacks are needed if the block job accesses other BlockDriverStates. Other BDSes need to be moved to the new AioContext in the atta

[Qemu-devel] [PATCH v3 07/15] vnc: drop unused depth arg for set_pixel_format

2016-06-13 Thread Stefan Hajnoczi
From: Gerd Hoffmann Spotted by Coverity. Cc: Paolo Bonzini Signed-off-by: Gerd Hoffmann Message-id: 1465204725-31562-1-git-send-email-kra...@redhat.com --- ui/vnc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index c862fdc..942cfb9 100644 ---

[Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change gracefully

2016-06-13 Thread Stefan Hajnoczi
Add block_job_pause_point() calls to mark quiescent points and make sure to complete in-flight requests when switching AioContexts. This patch solves undefined behavior in the mirror block job when the BDS AioContext is changed by dataplane. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zhen

[Qemu-devel] [PATCH v3 13/15] blockjob: add pause points

2016-06-13 Thread Stefan Hajnoczi
Block jobs are coroutines that usually perform I/O but sometimes also sleep or yield. Currently only sleeping or yielded block jobs can be paused. This means jobs that do not sleep or yield (using block_job_yield()) are unaffected by block_job_pause(). Add block_job_pause_point() so that block j

[Qemu-devel] [PATCH v3 08/15] ui: fix regression in printing VNC host/port on startup

2016-06-13 Thread Stefan Hajnoczi
From: "Daniel P. Berrange" If VNC is chosen as the compile time default display backend, QEMU will print the host/port it listens on at startup. Previously this would look like VNC server running on '::1:5900' but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was accidentally replaced w

[Qemu-devel] [PATCH v3 10/15] ui/console-gl: Add support for big endian display surfaces

2016-06-13 Thread Stefan Hajnoczi
From: Thomas Huth This is required for running QEMU on big endian hosts (like PowerPC machines) that use RGB instead of BGR byte ordering. Ticket: https://bugs.launchpad.net/qemu/+bug/1581796 Signed-off-by: Thomas Huth Message-id: 1465243261-26731-1-git-send-email-th...@redhat.com Signed-off-by

[Qemu-devel] [PATCH v3 11/15] console: ignore ui_info updates which don't actually update something

2016-06-13 Thread Stefan Hajnoczi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Message-id: 1464597673-26464-1-git-send-email-kra...@redhat.com --- ui/console.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index bf38579..ce1e105 100644 --- a/ui/console.c +++ b/ui/conso

[Qemu-devel] [PATCH v3 06/15] target-i386: Move user-mode exception actions out of user-exec.c

2016-06-13 Thread Stefan Hajnoczi
From: Peter Maydell The exception_action() function in user-exec.c is just a call to cpu_loop_exit() for every target CPU except i386. Since this function is only called if the target's handle_mmu_fault() hook has indicated an MMU fault, and that hook is only called from the handle_cpu_signal()

[Qemu-devel] [PATCH v3 04/15] user-exec: Don't reextract sigmask from usercontext pointer

2016-06-13 Thread Stefan Hajnoczi
From: Peter Maydell Extracting the old signal mask from the usercontext pointer passed to a signal handler is a pain because it is OS and CPU dependent. Since we've already done it once and passed it to handle_cpu_signal(), there's no need to do it again in cpu_exit_tb_from_sighandler(). This the

[Qemu-devel] [PATCH v3 12/15] blockjob: move iostatus reset out of block_job_enter()

2016-06-13 Thread Stefan Hajnoczi
The QMP block-job-resume command and cancellation may want to reset the job's iostatus. The next patches add a user who does not want to reset iostatus so move it up to block_job_enter() callers. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 1 + blockjob.c | 2 +- 2 files changed, 2 insertio

[Qemu-devel] [PATCH v3 05/15] target-i386: Add comment about do_interrupt_user() next_eip argument

2016-06-13 Thread Stefan Hajnoczi
From: Peter Maydell Add a comment to do_interrupt_user() along the same lines as the existing one for do_interrupt_all() noting that the next_eip argument is not used unless is_int is true or intno is EXCP_SYSCALL. Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov Acked-by: Eduardo Habk

[Qemu-devel] [PATCH v3 01/15] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page()

2016-06-13 Thread Stefan Hajnoczi
From: Peter Maydell The user-mode-only function tb_invalidate_phys_page() is only called from two places: * page_unprotect(), which passes in a non-zero pc, a puc pointer and the value 'true' for the locked argument * page_set_flags(), which passes in a zero pc, a NULL puc pointer and a '

[Qemu-devel] [PATCH v3 03/15] cpu-exec: Rename cpu_resume_from_signal() to cpu_loop_exit_noexc()

2016-06-13 Thread Stefan Hajnoczi
From: Peter Maydell The function cpu_resume_from_signal() is now always called with a NULL puc argument, and is rather misnamed since it is never called from a signal handler. It is essentially forcing an exit to the top level cpu loop but without raising any exception, so rename it to cpu_loop_e

[Qemu-devel] [PATCH v3 00/15] mirror: follow AioContext change gracefully

2016-06-13 Thread Stefan Hajnoczi
v3: * Push infrastructure down into blockjob.c so other jobs can reuse it [Stefan] * Tested with drive_mirror + migration [Stefan] v2: * Fam introduced the concept of a synchronous aio_poll() loop to quiesce the block job during detach When dataplane is enabled or disabled the drive switche

[Qemu-devel] [PATCH 5/6] qemu-img: move common options parsing before commands processing

2016-06-13 Thread Denis V. Lunev
This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilities) and documents this change. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan

<    1   2   3   4   5   6   >