Re: [Qemu-devel] [PATCH 06/10] ppc: Rework generation of priv and inval interrupts

2016-06-14 Thread David Gibson
On Wed, Jun 15, 2016 at 02:31:56PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2016-06-15 at 11:19 +1000, David Gibson wrote: > > > > >  static void spr_noaccess(DisasContext *ctx, int gprn, int sprn) > > > @@ -4348,9 +4371,15 @@ static inline void gen_op_mfspr(DisasContext *ctx) > > >

Re: [Qemu-devel] [PATCH v4 1/9] qom: API to get instance_size of a type

2016-06-14 Thread David Gibson
On Fri, Jun 10, 2016 at 09:38:24AM +0200, Igor Mammedov wrote: > On Fri, 10 Jun 2016 14:04:41 +1000 > David Gibson wrote: > > > On Fri, Jun 10, 2016 at 06:29:00AM +0530, Bharata B Rao wrote: > > > Add an API object_type_get_size(const char *typename) that returns the

Re: [Qemu-devel] [PATCH 06/10] ppc: Rework generation of priv and inval interrupts

2016-06-14 Thread Benjamin Herrenschmidt
On Wed, 2016-06-15 at 11:19 +1000, David Gibson wrote: > > >  static void spr_noaccess(DisasContext *ctx, int gprn, int sprn) > > @@ -4348,9 +4371,15 @@ static inline void gen_op_mfspr(DisasContext *ctx) > >   TARGET_FMT_lx "\n", sprn, sprn, ctx->nip - 4); > >  

Re: [Qemu-devel] [Qemu-ppc] Determining interest in PPC e500spin, yield, and openpic patches

2016-06-14 Thread David Gibson
On Mon, Jun 13, 2016 at 06:08:30PM -0500, alar...@ddci.com wrote: > We've used older versions of QEMU for several years as a virtual > target for our OS. Many thanks to the community for providing this > platform. Hi, Thanks for your interest. > We've been working to get our OS running under

Re: [Qemu-devel] [Qemu-ppc] Bug in ppc/BookE wait instruction

2016-06-14 Thread David Gibson
On Mon, Jun 06, 2016 at 10:47:28AM +0200, Jakub Horak wrote: > > Hello, > > David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Jun 03, 2016 at 05:45:49PM +0200, Jakub Horak wrote: > > > Hello, > > > I think there's a bug in "wait" instruction code generator for PowerPC > > >

Re: [Qemu-devel] [PATCH 8/9] mirror: use synch scheme for drive mirror

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > Block commit of the active image to the backing store on a slow disk > could never end. For example with the guest with the following loop > inside > while true; do > dd bs=1k count=1 if=/dev/zero of=x > done > running above slow

Re: [Qemu-devel] [PATCH 7/9] mirror: allow to save buffer for QEMUIOVector in MirrorOp

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: In the subject: 'allow to save buffer' is not idiomatic English; better would be 'allow saving the buffer' or simply 'save the buffer' > Properly cook MirrorOp initialization/deinitialization. The field is not > yet used actually. Another "what" but

Re: [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev The commit message says what, but not why. It's useful to give reviewers a hint as to why a patch makes sense (such as a future patch being able to use the write notifier to make mirroring more

Re: [Qemu-devel] [PATCH 07/10] ppc: Add real mode CI load/store instructions for P7 and P8

2016-06-14 Thread David Gibson
On Mon, Jun 13, 2016 at 07:24:53AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Those instructions are only available in hypervisor real mode and > allow cache inhibited garded access to devices in that mode. > > Signed-off-by: Benjamin

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Silence deprecation message in qtest mode

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 07:23:03PM +0200, Thomas Huth wrote: > When running "make check", there is currently always an error message > saying "spapr-pci-vfio-host-bridge is deprecated". This happens because > the QOM tests are instantiating all possible devices, and the error > message is

Re: [Qemu-devel] [PATCH v2] ppc / sparc: Add a tester for checking whether OpenBIOS runs successfully

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 03:57:56PM +0200, Thomas Huth wrote: > Since the mac99 and g3beige PowerPC machines recently broke without > being noticed, it would be good to have a tester for "make check" > that detects such issues immediately. A simple way to test the firmware > of these machines is to

[Qemu-devel] [PATCH] ACPI: ARM: Present GIC version in MADT table

2016-06-14 Thread Shannon Zhao
From: Shannon Zhao In ACPI 5.1 Errata, it adds GIC version in GIC distributor structure. This is useful for guest kernel to identify which version GIC hardware is. Update GIC distributor structure and present GIC version in MADT table. Signed-off-by: Shannon Zhao

Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > We should not take into account zero blocks for delay calculations. > They are not read and thus IO throttling is not required. In the > other case VM migration with 16 Tb QCOW2 disk with 4 Gb of data takes > days. > > Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PATCH v3 18/20] hw/intc/arm_gicv3: Add IRQ handling CPU interface registers

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > Add the CPU interface registers which deal with acknowledging > and dismissing interrupts. > > Signed-off-by: Peter Maydell Reviewed-by: Shannon Zhao > --- > hw/intc/arm_gicv3_cpuif.c | 437 >

Re: [Qemu-devel] [PATCH 06/10] ppc: Rework generation of priv and inval interrupts

2016-06-14 Thread David Gibson
On Mon, Jun 13, 2016 at 07:24:52AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Recent server processors use the Hypervisor Emulation Assistance > interrupt for illegal instructions and *some* type of SPR accesses. > > Also the code was always

Re: [Qemu-devel] [PATCH 10/10] ppc: Add P7/P8 Power Management instructions

2016-06-14 Thread David Gibson
On Mon, Jun 13, 2016 at 07:24:56AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > This adds the ISA 2.06 and later power management instructions > (doze, nap, sleep and rvwinkle) and associated wakeup cause testing > in LPCR > > Signed-off-by:

Re: [Qemu-devel] [PATCH 05/10] ppc: Fix generation if ISI/DSI vs. HV mode

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 08:42:26AM +0200, Cédric Le Goater wrote: > On 06/14/2016 08:34 AM, David Gibson wrote: > > On Mon, Jun 13, 2016 at 07:24:51AM +0200, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> Under some circumstances, we need to direct

Re: [Qemu-devel] [PATCH 09/10] ppc: Move exception generation code out of line

2016-06-14 Thread David Gibson
On Mon, Jun 13, 2016 at 10:36:24AM +0200, Cédric Le Goater wrote: > On 06/13/2016 09:44 AM, Thomas Huth wrote: > > On 13.06.2016 07:24, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> There's no point inlining this, if you hit the exception case you

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote: > There are functions tlb_fill(), cpu_unaligned_access() and > do_unaligned_access() that are called with access type and mmu index > arguments. But these arguments are named 'is_write' and 'is_user' in their > declarations. The

Re: [Qemu-devel] [PATCH 03/10] ppc: Rework POWER7 & POWER8 exception model (part 2)

2016-06-14 Thread David Gibson
On Wed, Jun 15, 2016 at 07:19:39AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-06-14 at 16:25 +1000, David Gibson wrote: > > > Properly implement LPES0/1 handling for HV vs. !HV mode. > > >  > > > Signed-off-by: Benjamin Herrenschmidt > > > [clg: AIL

Re: [Qemu-devel] [PATCH 02/10] ppc: Create cpu_ppc_set_papr() helper (for LPCR)

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 08:52:12AM +0200, Cédric Le Goater wrote: > On 06/14/2016 08:15 AM, David Gibson wrote: > > On Mon, Jun 13, 2016 at 07:24:48AM +0200, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> And move the code adjusting the MSR mask and

Re: [Qemu-devel] [PATCH 4/9] mirror: efficiently zero out target

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > With a bdrv_co_write_zeroes method on a target BDS zeroes will not be placed > into the wire. Thus the target could be very efficiently zeroed out. This > is should be done with the largest chunk possible. > > This improves the performance of the

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > This series implements emulation of the GICv3 interrupt controller. > It is based to some extent on previous patches from Shlomo and > Pavel, but the bulk of it has turned out to be new code. (The > combination of changing the underlying data

Re: [Qemu-devel] [PATCH v3 16/20] hw/intc/arm_gicv3: Implement gicv3_cpuif_update()

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > Implement the gicv3_cpuif_update() function which deals with correctly > asserting IRQ and FIQ based on the current running priority of the CPU, > the priority of the highest priority pending interrupt and the CPU's > current exception level and

Re: [Qemu-devel] [PATCH v3 12/20] hw/intc/arm_gicv3: Implement GICv3 redistributor registers

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > From: Shlomo Pongratz > > Implement the redistributor registers of a GICv3. > > Signed-off-by: Shlomo Pongratz > [PMM: significantly overhauled/rewritten: > * use the new data structures > *

Re: [Qemu-devel] [PATCH v3 15/20] hw/intc/arm_gicv3: Implement GICv3 CPU interface registers

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > Implement the CPU interface registers for the GICv3; these are > CPU system registers, not MMIO registers. > > This commit implements all the registers which are simple > accessors for GIC state, but not those which act as interfaces > for

Re: [Qemu-devel] [PATCH v3 11/20] hw/intc/arm_gicv3: Implement GICv3 distributor registers

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > From: Shlomo Pongratz > > Implement the distributor registers of a GICv3. > > Signed-off-by: Shlomo Pongratz > [PMM: significantly overhauled/rewritten: > * use the new bitmap data structures

Re: [Qemu-devel] [PATCH v3 10/20] hw/intc/arm_gicv3: Implement functions to identify next pending irq

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > Implement the GICv3 logic to recalculate the highest priority pending > interrupt for each CPU after some part of the GIC state has changed. > We avoid unnecessary full recalculation where possible. > > Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 3/9] mirror: optimize dirty bitmap filling in mirror_run a bit

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > There is no need to scan allocation tables if we have mark_all_dirty flag > set. Just mark it all dirty. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy > CC: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3 08/20] hw/intc/arm_gicv3: Add vmstate descriptors

2016-06-14 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > From: Pavel Fedin > > Add state structure descriptors for the GICv3 state. We mark > the KVM GICv3 device as having a migration blocker until the > code to save and restore the state in the kernel is implemented. > >

Re: [Qemu-devel] [PATCH 2/9] mirror: create mirror_dirty_init helper for mirror_run

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > The code inside the helper will be extended in the next patch. mirror_run > itself is overbloated at the moment. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy > CC: Stefan

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-06-14 Thread Fam Zheng
On Tue, 06/14 16:49, Max Reitz wrote: > On 18.05.2016 07:53, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > > > Cc:

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-06-14 Thread Fam Zheng
On Tue, 06/14 16:49, Max Reitz wrote: > On 18.05.2016 07:53, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > > > Cc:

Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include

2016-06-14 Thread Eric Blake
On 06/14/2016 06:33 PM, Fam Zheng wrote: > On Tue, 06/14 16:05, Eric Blake wrote: >> On 05/31/2016 08:23 PM, Fam Zheng wrote: >>> The file is only included from the top Makefile. Rename it to reflect >>> this more obviously. >>> >>> Signed-off-by: Fam Zheng >>> --- >>> Makefile

Re: [Qemu-devel] [PATCH RFC 10/16] hw/ppc/spapr: don't use smp_cores, smp_threads

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 08:23:08AM +0200, Andrew Jones wrote: > On Tue, Jun 14, 2016 at 01:03:41PM +1000, David Gibson wrote: > > On Fri, Jun 10, 2016 at 07:40:21PM +0200, Andrew Jones wrote: > > > Use CPUState nr_cores,nr_threads and MachineState > > > cores,threads instead. > > > > > >

Re: [Qemu-devel] [PATCH RFC 05/16] hw/core/machine: add smp properites

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 08:08:07AM +0200, Andrew Jones wrote: > On Tue, Jun 14, 2016 at 12:00:26PM +1000, David Gibson wrote: > > On Fri, Jun 10, 2016 at 07:40:16PM +0200, Andrew Jones wrote: > > > Signed-off-by: Andrew Jones > > > --- > > > hw/core/machine.c | 81 > > >

Re: [Qemu-devel] [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 08:19:49AM +0200, Andrew Jones wrote: > On Tue, Jun 14, 2016 at 12:12:16PM +1000, David Gibson wrote: > > On Sun, Jun 12, 2016 at 03:48:10PM +0200, Andrew Jones wrote: > > > On Sat, Jun 11, 2016 at 08:54:35AM +0200, Thomas Huth wrote: > > > > On 10.06.2016 19:40, Andrew

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 04:03:29PM +0200, Andrew Jones wrote: > On Tue, Jun 14, 2016 at 01:53:05PM +0200, Paolo Bonzini wrote: > > > > > > On 14/06/2016 13:39, Andrew Jones wrote: > > > On Tue, Jun 14, 2016 at 10:17:49AM +0200, Paolo Bonzini wrote: > > >> On 13/06/2016 22:35, Andrew Jones wrote:

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 10:17:49AM +0200, Paolo Bonzini wrote: > > > On 13/06/2016 22:35, Andrew Jones wrote: > > On Mon, Jun 13, 2016 at 07:04:01PM +0200, Paolo Bonzini wrote: > >> On 10/06/2016 19:40, Andrew Jones wrote: > >>> +if (sockets == -1 || cores == -1 || threads == -1 || > >>> +

Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include

2016-06-14 Thread Fam Zheng
On Tue, 06/14 16:05, Eric Blake wrote: > On 05/31/2016 08:23 PM, Fam Zheng wrote: > > The file is only included from the top Makefile. Rename it to reflect > > this more obviously. > > > > Signed-off-by: Fam Zheng > > --- > > Makefile | 2 +- > >

Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.

2016-06-14 Thread Fam Zheng
On Tue, 06/14 11:07, Sean Bruno wrote: > The --quiet argument is not available on all operating systems. Use -s > instead to match the rest of the Makefile uses. This fixes a non-fatal > error seen on FreeBSD. > > Signed-off-by: Sean Bruno > --- > Makefile | 2 +- > 1 file

Re: [Qemu-devel] [PATCH v3 08/14] block/nbd: Accept SocketAddress

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > Add a new option "address" to the NBD block driver which accepts a > SocketAddress. > > "path", "host" and "port" are still supported as legacy options and are > mapped to their corresponding SocketAddress representation. The back-compat work is pretty

Re: [Qemu-devel] [PATCH v3 07/14] block/nbd: "address" in nbd_refresh_filename()

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > As of a future patch, the NBD block driver will accept a SocketAddress > structure for a new "address" option. In order to support this, > nbd_refresh_filename() needs some changes. > > The two TODOs introduced by this patch will be removed in the very

Re: [Qemu-devel] [PATCH v3 06/14] block/nbd: Add nbd_has_filename_options_conflict()

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > Right now, we have four possible options that conflict with specifying > an NBD filename, and a future patch will add another one ("address"). > This future option is a nested QDict that is flattened at this point, > requiring as to test each option

Re: [Qemu-devel] [PATCH 1/9] mirror: fix calling of blk_aio_pwritev/blk_aio_preadv

2016-06-14 Thread Eric Blake
On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > 4th argument is flags rather than size. Fortunately flags occupies > 5 less significant bits and they are always zero due to alignment. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir

Re: [Qemu-devel] [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for NBD

2016-06-14 Thread Eric Blake
On 05/03/2016 09:23 AM, Kevin Wolf wrote: > Am 06.04.2016 um 20:28 hat Max Reitz geschrieben: >> Turns out NBD is not so simple to do if you do it right. Anyway, this >> series adds blockdev-add support for NBD clients. > > What the series does seems to make sense to me, though things would be a

Re: [Qemu-devel] [PATCH v3 05/14] block/nbd: Use qdict_put()

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > Instead of inlining this nice macro (i.e. resorting to > qdict_put_obj(..., QOBJECT(...))), use it. > > Signed-off-by: Max Reitz > --- > block/nbd.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH v3 04/14] block/nbd: Default port in nbd_refresh_filename()

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > Instead of not emitting the port in nbd_refresh_filename(), just set it > to the default if the user did not specify it. This makes the logic a > bit simpler. > > Signed-off-by: Max Reitz > --- > block/nbd.c | 18 +++--- >

[Qemu-devel] [Bug 1592590] [NEW] Prevent qemu-img resize from causing "Active L1 table too large"

2016-06-14 Thread Nowaker
Public bug reported: This commit prevents qemu from overallocating if qcow2 image is too big (whatever that means): https://lists.gnu.org/archive/html/qemu- devel/2014-07/msg01481.html However, `qemu-img resize` isn't protected by the same code and allows to go beyond that. root@nwkr-laptop

Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.

2016-06-14 Thread Eric Blake
On 06/14/2016 12:07 PM, Sean Bruno wrote: > The --quiet argument is not available on all operating systems. Use -s > instead to match the rest of the Makefile uses. This fixes a non-fatal > error seen on FreeBSD. > > Signed-off-by: Sean Bruno > --- > Makefile | 2 +- > 1

Re: [Qemu-devel] [PATCH v3 01/14] qdict: Add qdict_change_key()

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > This is a shorthand function for changing a QDict's entry's key. > > Signed-off-by: Max Reitz > --- > include/qapi/qmp/qdict.h | 1 + > qobject/qdict.c | 23 +++ > 2 files changed, 24 insertions(+)

Re: [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 17:59, Alex Bligh wrote: > >> On 14 Jun 2016, at 16:11, Paolo Bonzini wrote: >> >>> To illustrate the problem, look consider what qemu itself would do as >>> a server if it can't buffer the entire read issued to it. >> >> Return ENOMEM? > > Well OK, qemu

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 23:32, Programmingkid wrote: > > On Jun 14, 2016, at 5:13 PM, BALATON Zoltan wrote: > >> On Tue, 14 Jun 2016, Programmingkid wrote: >>> On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote: smp_cores is only used by pseries and x86 machines. I expect machines

Re: [Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-14 Thread Eric Blake
On 06/14/2016 06:36 AM, Jeff Cody wrote: > On Tue, Jun 14, 2016 at 03:27:55PM +0530, Prasanna Kalever wrote: >> Hello, >> >> Can someone please help me in tracking the QAPI changes for union >> discriminator addition, >> the below [1] gluster related patches are awaiting from very long, >> because

Re: [Qemu-devel] [PATCH v3 02/14] block/nbd: Drop trailing "." in error messages

2016-06-14 Thread Eric Blake
On 04/06/2016 12:28 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/nbd.c | 4 ++-- > tests/qemu-iotests/051.out| 4 ++-- > tests/qemu-iotests/051.pc.out | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd

2016-06-14 Thread Eric Blake
On 06/14/2016 04:08 AM, Denis V. Lunev wrote: > Please note, trace_init_backends() must be called in the final process, > i.e. after daemonization. This is necessary to keep tracing thread in > the proper process. > > Signed-off-by: Denis V. Lunev > CC: Eric Blake

Re: [Qemu-devel] [PATCHv2 2/2] MAINTAINERS: remove Blue Swirl as SPARC maintainer

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 10:33, Markus Armbruster wrote: > The remaining ones are > effectively orphaned, but you can't see that in MAINTAINERS. I feel > keeping status there honest is important. > > Subsystems > -- > Checkpatch > M: Blue Swirl > S: Odd

Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include

2016-06-14 Thread Eric Blake
On 05/31/2016 08:23 PM, Fam Zheng wrote: > The file is only included from the top Makefile. Rename it to reflect > this more obviously. > > Signed-off-by: Fam Zheng > --- > Makefile | 2 +- > tests/{Makefile => Makefile.include} | 0 > 2 files

Re: [Qemu-devel] [PATCH 1/2] build-sys: define QEMU_SRC_PATH

2016-06-14 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2016-06-14 08:16:53) > From: Marc-André Lureau > > Define QEMU_SRC_PATH in config-host.h, to ease accessing of tests data > files. > > Signed-off-by: Marc-André Lureau I know this avoids the need to

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-14 Thread Mark Cave-Ayland
Thanks for the test case. It appears that this is a regression that occurred somewhere between 2.5 and 2.6 - bisecting now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1588328 Title: Qemu 2.6

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-14 Thread Eric Blake
On 06/14/2016 06:26 AM, Stefan Hajnoczi wrote: > On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote: >> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%) >> +$(call quiet-command,cat $^ > $@) > > $^ needs to be a stable ordering across make invocations and

Re: [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 20:38, Eduardo Habkost wrote: > On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote: >> Since iommu devices can be created with '-device' there is >> no need to keep iommu as machine and mch property. >> >> Signed-off-by: Marcel Apfelbaum > > On

Re: [Qemu-devel] [PATCH qemu v17 06/12] memory: Add reporting of supported page sizes

2016-06-14 Thread Alexey Kardashevskiy
On 08/06/16 16:05, Alexey Kardashevskiy wrote: > On 08/06/16 16:00, David Gibson wrote: >> On Mon, Jun 06, 2016 at 03:31:04PM +0200, Paolo Bonzini wrote: >>> >>> >>> On 02/06/2016 05:35, David Gibson wrote: On Wed, Jun 01, 2016 at 06:57:37PM +1000, Alexey Kardashevskiy wrote: >> Every

Re: [Qemu-devel] [PULL 5/8] target-sparc: Use global registers for the register window

2016-06-14 Thread Mark Cave-Ayland
On 23/02/16 18:33, Richard Henderson wrote: > Via indirection off cpu_regwptr. > > Tested-by: Mark Cave-Ayland > Signed-off-by: Richard Henderson > --- > target-sparc/translate.c | 57 > > 1

Re: [Qemu-devel] [PATCH 2/7] doc: sync help descriprion for --trace with man for qemu.1

2016-06-14 Thread Eric Blake
On 06/14/2016 04:08 AM, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > qemu-options.hx | 2 +- > 1 file

Re: [Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

2016-06-14 Thread Eric Blake
On 06/14/2016 04:08 AM, Denis V. Lunev wrote: > The command will work this way: > qemu-img --trace qcow2* create -f qcow2 1.img 64G > > Signed-off-by: Denis V. Lunev > Suggested by: Daniel P. Berrange > CC: Eric Blake > CC: Paolo

Re: [Qemu-devel] Handling errors caused by -global (was Re: [PATCH v2 4/6] cpu: use CPUClass->parse_features() as convertor to global properties)

2016-06-14 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Igor Mammedov" > Cc: qemu-devel@nongnu.org, "peter maydell" , "mark > cave-ayland" > , blauwir...@gmail.com, qemu-...@nongnu.org, >

Re: [Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specific .texi file

2016-06-14 Thread Eric Blake
On 06/14/2016 03:49 PM, Eric Blake wrote: > On 06/14/2016 04:08 AM, Denis V. Lunev wrote: >> This text will be included to qemu-nbd/qemu-img mans in the next patches. >> >> Signed-off-by: Denis V. Lunev >> CC: Eric Blake >> CC: Paolo Bonzini

Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used

2016-06-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 05:38:42PM -0400, Paolo Bonzini wrote: > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Paolo Bonzini" > > Cc: "Peter Maydell" , "Andreas Färber" > > ,

[Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
The raw block driver was blindly copying all limits from bs->file, even though: 1. the main bdrv_refresh_limits() already does this for many of gthe limits, and 2. blindly copying from the children can weaken any stricter limits that were already inherited from the backing dhain during the main

Re: [Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specific .texi file

2016-06-14 Thread Eric Blake
On 06/14/2016 04:08 AM, Denis V. Lunev wrote: > This text will be included to qemu-nbd/qemu-img mans in the next patches. > > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 08/17] blkdebug: Set request_alignment during .bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. qemu-iotests 77 is particularly sensitive to the fact that we

Re: [Qemu-devel] [PATCH 2/2] block: fix libvirt snapshot with existing bitmaps

2016-06-14 Thread Eric Blake
On 06/14/2016 11:08 AM, Vladimir Sementsov-Ogievskiy wrote: > Fix the following bug: > > # virsh start test > Domain test started > > # virsh qemu-monitor-command test \ > '{"execute":"block-dirty-bitmap-add",\ > "arguments":{"node":"drive0","name":"ab"}}' >

Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used

2016-06-14 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Paolo Bonzini" > Cc: "Peter Maydell" , "Andreas Färber" > , qemu-devel@nongnu.org, "Richard > Henderson" , "Igor Mammedov"

[Qemu-devel] [PATCH v2 09/17] iscsi: Set request_alignment during .bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric Blake --- v2: new

Re: [Qemu-devel] Handling errors caused by -global (was Re: [PATCH v2 4/6] cpu: use CPUClass->parse_features() as convertor to global properties)

2016-06-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 05:41:03PM -0400, Paolo Bonzini wrote: > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Igor Mammedov" > > Cc: qemu-devel@nongnu.org, "peter maydell" , > > "mark cave-ayland" > >

[Qemu-devel] [PATCH v2 10/17] qcow2: Set request_alignment during .bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric Blake --- v2: new

Re: [Qemu-devel] [PULL 00/10] X86 queue, 2016-06-14

2016-06-14 Thread Eduardo Habkost
x86-pull-request tag was updated (patch 10/10 was removed). See updated pull request info below. The following changes since commit 49237b856ae58ee7955be0b959c504c51b014f20: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20160614-tag' into staging (2016-06-14 16:32:32 +0100

[Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds to byte-based

2016-06-14 Thread Eric Blake
Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_transfer_length and opt_transfer_length. Rename them (dropping the _length suffix) so that the compiler will help us catch the change in semantics across any rebased code, and

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread Programmingkid
On Jun 14, 2016, at 5:13 PM, BALATON Zoltan wrote: > On Tue, 14 Jun 2016, Programmingkid wrote: >> On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote: >>> smp_cores is only used by pseries and x86 machines. I expect machines >>> that must be single-socket to disregard smp_sockets

[Qemu-devel] [PATCH v2 06/17] iscsi: Advertise realistic limits to block layer

2016-06-14 Thread Eric Blake
The function sector_limits_lun2qemu() returns a value in units of the block layer's 512-byte sector, and can be as large as 0x4000, which is much larger than the block layer's inherent limit of BDRV_REQUEST_MAX_SECTORS. The block layer already handles '0' as a synonym to the inherent limit,

[Qemu-devel] [PATCH v2 05/17] nbd: Advertise realistic limits to block layer

2016-06-14 Thread Eric Blake
We were basing the advertisement of maximum discard and transfer length off of UINT32_MAX, but since the rest of the block layer has signed int limits on a transaction, nothing could ever reach that maximum, and we risk overflowing an int once things are converted to byte-based rather than

[Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-14 Thread Eric Blake
Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_discard and discard_alignment. Rename them, using 'pdiscard' as an aid to track which remaining discard interfaces need conversion, and so that the compiler will help us catch the

[Qemu-devel] [PATCH v2 12/17] block: Set request_alignment during .bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Add a .bdrv_refresh_limits() to all four of our legacy devices

[Qemu-devel] [PATCH v2 17/17] block: Move request_alignment into BlockLimit

2016-06-14 Thread Eric Blake
It makes more sense to have ALL block size limit constraints in the same struct. Improve the documentation while at it. Signed-off-by: Eric Blake --- v2: drop hacks for save/restore of alignment, now that earlier patches handled setting up BlockLimits more sanely ---

[Qemu-devel] [PATCH v2 02/17] block: Document supported flags during bdrv_aligned_preadv()

2016-06-14 Thread Eric Blake
We don't pass any flags on to drivers to handle. Tighten an assert to explain why we pass 0 to bdrv_driver_preadv(), and add some comments on things to be aware of if we want to turn on per-BDS BDRV_REQ_FUA support during reads in the future. Also, document that we may want to consider using

[Qemu-devel] [PATCH v2 13/17] block: Set default request_alignment during bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Now that all drivers have been updated to supply an override

[Qemu-devel] [PATCH v2 11/17] raw-win32: Set request_alignment during .bdrv_refresh_limits()

2016-06-14 Thread Eric Blake
We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. In this case, raw_probe_alignment() already did what we

[Qemu-devel] [PATCH v2 01/17] block: Tighter assertions on bdrv_aligned_pwritev()

2016-06-14 Thread Eric Blake
For symmetry with bdrv_aligned_preadv(), assert that the caller really has aligned things properly. This requires adding an align parameter, which is used now only in the new asserts, but will come in handy in a later patch that adds auto-fragmentation to the max transfer size, since that value

[Qemu-devel] [PATCH v2 03/17] block: Fix harmless off-by-one in bdrv_aligned_preadv()

2016-06-14 Thread Eric Blake
If the amount of data to read ends exactly on the total size of the bs, then we were wasting time creating a local qiov to read the data in preparation for what would normally be appending zeroes beyond the end, even though this corner case has nothing further to do. Signed-off-by: Eric Blake

Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used

2016-06-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 05:16:40PM -0400, Paolo Bonzini wrote: > - Original Message - > > From: "Eduardo Habkost" > > To: "Peter Maydell" > > Cc: "Andreas Färber" , qemu-devel@nongnu.org, "Richard > > Henderson"

[Qemu-devel] [PATCH v2 07/17] block: Give nonzero result to blk_get_max_transfer_length()

2016-06-14 Thread Eric Blake
Making all callers special-case 0 as unlimited is awkward, and we DO have a hard maximum of BDRV_REQUEST_MAX_SECTORS given our current block layer API limits. In the case of scsi, this means that we now always advertise a limit to the guest, even in cases where the underlying layers previously

[Qemu-devel] [PATCH v2 04/17] nbd: Allow larger requests

2016-06-14 Thread Eric Blake
The NBD layer was breaking up request at a limit of 2040 sectors (just under 1M) to cater to old qemu-nbd. But the server limit was raised to 32M in commit 2d8214885 to match the kernel, more than three years ago; and the upstream NBD Protocol is proposing documentation that without any explicit

[Qemu-devel] [PATCH v2 00/17] Byte-based block limits

2016-06-14 Thread Eric Blake
BlockLimits is currently an ugly mix of byte limits vs. sector limits. Unify it. Fix some bugs I found in bdrv_aligned_preadv() while at it. Prequisite: Kevin's ongoing work to migrate bdrv_aligned_preadv() to be byte-based (commit 3de06b2 on his vmstate branch at the time of this email, but

Re: [Qemu-devel] [PATCH 1/1] cpu: report hyperv feature words through qom

2016-06-14 Thread Denis V. Lunev
On 06/14/2016 11:54 PM, Eduardo Habkost wrote: On Tue, Jun 14, 2016 at 11:45:08PM +0300, Denis V. Lunev wrote: On 06/14/2016 10:59 PM, Eduardo Habkost wrote: On Tue, Jun 14, 2016 at 01:28:40PM +0300, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread BALATON Zoltan
On Tue, 14 Jun 2016, Programmingkid wrote: On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote: smp_cores is only used by pseries and x86 machines. I expect machines that must be single-socket to disregard smp_sockets altogether. Could smp support be added to the beigeg3 and mac99

Re: [Qemu-devel] [PATCH 03/10] ppc: Rework POWER7 & POWER8 exception model (part 2)

2016-06-14 Thread Benjamin Herrenschmidt
On Tue, 2016-06-14 at 16:25 +1000, David Gibson wrote: > > Properly implement LPES0/1 handling for HV vs. !HV mode. > >  > > Signed-off-by: Benjamin Herrenschmidt > > [clg: AIL implementation was fixed in commit 5c94b2a5e5ef > >   fixed checkpatch.pl errors ] > >

[Qemu-devel] [PULL 09/10] target-i386: Consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-14 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 74

Re: [Qemu-devel] [PATCH 1/1] cpu: report hyperv feature words through qom

2016-06-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 11:59:18PM +0300, Denis V. Lunev wrote: > On 06/14/2016 11:54 PM, Eduardo Habkost wrote: > > On Tue, Jun 14, 2016 at 11:45:08PM +0300, Denis V. Lunev wrote: > > > On 06/14/2016 10:59 PM, Eduardo Habkost wrote: > > > > On Tue, Jun 14, 2016 at 01:28:40PM +0300, Denis V. Lunev

Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used

2016-06-14 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Peter Maydell" > Cc: "Andreas Färber" , qemu-devel@nongnu.org, "Richard > Henderson" , "Paolo > Bonzini" , "Igor Mammedov"

  1   2   3   4   5   6   >