On Wed, Jun 15, 2016 at 02:31:56PM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2016-06-15 at 11:19 +1000, David Gibson wrote:
> >
> > > static void spr_noaccess(DisasContext *ctx, int gprn, int sprn)
> > > @@ -4348,9 +4371,15 @@ static inline void gen_op_mfspr(DisasContext *ctx)
> > >
On Fri, Jun 10, 2016 at 09:38:24AM +0200, Igor Mammedov wrote:
> On Fri, 10 Jun 2016 14:04:41 +1000
> David Gibson wrote:
>
> > On Fri, Jun 10, 2016 at 06:29:00AM +0530, Bharata B Rao wrote:
> > > Add an API object_type_get_size(const char *typename) that returns the
On Wed, 2016-06-15 at 11:19 +1000, David Gibson wrote:
>
> > static void spr_noaccess(DisasContext *ctx, int gprn, int sprn)
> > @@ -4348,9 +4371,15 @@ static inline void gen_op_mfspr(DisasContext *ctx)
> > TARGET_FMT_lx "\n", sprn, sprn, ctx->nip - 4);
> >
On Mon, Jun 13, 2016 at 06:08:30PM -0500, alar...@ddci.com wrote:
> We've used older versions of QEMU for several years as a virtual
> target for our OS. Many thanks to the community for providing this
> platform.
Hi,
Thanks for your interest.
> We've been working to get our OS running under
On Mon, Jun 06, 2016 at 10:47:28AM +0200, Jakub Horak wrote:
>
> Hello,
>
> David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Fri, Jun 03, 2016 at 05:45:49PM +0200, Jakub Horak wrote:
> > > Hello,
> > > I think there's a bug in "wait" instruction code generator for PowerPC
> > >
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> Block commit of the active image to the backing store on a slow disk
> could never end. For example with the guest with the following loop
> inside
> while true; do
> dd bs=1k count=1 if=/dev/zero of=x
> done
> running above slow
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
In the subject: 'allow to save buffer' is not idiomatic English; better
would be 'allow saving the buffer' or simply 'save the buffer'
> Properly cook MirrorOp initialization/deinitialization. The field is not
> yet used actually.
Another "what" but
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev
The commit message says what, but not why. It's useful to give
reviewers a hint as to why a patch makes sense (such as a future patch
being able to use the write notifier to make mirroring more
On Mon, Jun 13, 2016 at 07:24:53AM +0200, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt
>
> Those instructions are only available in hypervisor real mode and
> allow cache inhibited garded access to devices in that mode.
>
> Signed-off-by: Benjamin
On Tue, Jun 14, 2016 at 07:23:03PM +0200, Thomas Huth wrote:
> When running "make check", there is currently always an error message
> saying "spapr-pci-vfio-host-bridge is deprecated". This happens because
> the QOM tests are instantiating all possible devices, and the error
> message is
On Tue, Jun 14, 2016 at 03:57:56PM +0200, Thomas Huth wrote:
> Since the mac99 and g3beige PowerPC machines recently broke without
> being noticed, it would be good to have a tester for "make check"
> that detects such issues immediately. A simple way to test the firmware
> of these machines is to
From: Shannon Zhao
In ACPI 5.1 Errata, it adds GIC version in GIC distributor structure.
This is useful for guest kernel to identify which version GIC hardware
is. Update GIC distributor structure and present GIC version in MADT
table.
Signed-off-by: Shannon Zhao
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> We should not take into account zero blocks for delay calculations.
> They are not read and thus IO throttling is not required. In the
> other case VM migration with 16 Tb QCOW2 disk with 4 Gb of data takes
> days.
>
> Signed-off-by: Denis V. Lunev
On 2016/6/14 22:38, Peter Maydell wrote:
> Add the CPU interface registers which deal with acknowledging
> and dismissing interrupts.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Shannon Zhao
> ---
> hw/intc/arm_gicv3_cpuif.c | 437
>
On Mon, Jun 13, 2016 at 07:24:52AM +0200, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt
>
> Recent server processors use the Hypervisor Emulation Assistance
> interrupt for illegal instructions and *some* type of SPR accesses.
>
> Also the code was always
On Mon, Jun 13, 2016 at 07:24:56AM +0200, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt
>
> This adds the ISA 2.06 and later power management instructions
> (doze, nap, sleep and rvwinkle) and associated wakeup cause testing
> in LPCR
>
> Signed-off-by:
On Tue, Jun 14, 2016 at 08:42:26AM +0200, Cédric Le Goater wrote:
> On 06/14/2016 08:34 AM, David Gibson wrote:
> > On Mon, Jun 13, 2016 at 07:24:51AM +0200, Cédric Le Goater wrote:
> >> From: Benjamin Herrenschmidt
> >>
> >> Under some circumstances, we need to direct
On Mon, Jun 13, 2016 at 10:36:24AM +0200, Cédric Le Goater wrote:
> On 06/13/2016 09:44 AM, Thomas Huth wrote:
> > On 13.06.2016 07:24, Cédric Le Goater wrote:
> >> From: Benjamin Herrenschmidt
> >>
> >> There's no point inlining this, if you hit the exception case you
On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote:
> There are functions tlb_fill(), cpu_unaligned_access() and
> do_unaligned_access() that are called with access type and mmu index
> arguments. But these arguments are named 'is_write' and 'is_user' in their
> declarations. The
On Wed, Jun 15, 2016 at 07:19:39AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2016-06-14 at 16:25 +1000, David Gibson wrote:
> > > Properly implement LPES0/1 handling for HV vs. !HV mode.
> > >
> > > Signed-off-by: Benjamin Herrenschmidt
> > > [clg: AIL
On Tue, Jun 14, 2016 at 08:52:12AM +0200, Cédric Le Goater wrote:
> On 06/14/2016 08:15 AM, David Gibson wrote:
> > On Mon, Jun 13, 2016 at 07:24:48AM +0200, Cédric Le Goater wrote:
> >> From: Benjamin Herrenschmidt
> >>
> >> And move the code adjusting the MSR mask and
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> With a bdrv_co_write_zeroes method on a target BDS zeroes will not be placed
> into the wire. Thus the target could be very efficiently zeroed out. This
> is should be done with the largest chunk possible.
>
> This improves the performance of the
On 2016/6/14 22:38, Peter Maydell wrote:
> This series implements emulation of the GICv3 interrupt controller.
> It is based to some extent on previous patches from Shlomo and
> Pavel, but the bulk of it has turned out to be new code. (The
> combination of changing the underlying data
On 2016/6/14 22:38, Peter Maydell wrote:
> Implement the gicv3_cpuif_update() function which deals with correctly
> asserting IRQ and FIQ based on the current running priority of the CPU,
> the priority of the highest priority pending interrupt and the CPU's
> current exception level and
On 2016/6/14 22:38, Peter Maydell wrote:
> From: Shlomo Pongratz
>
> Implement the redistributor registers of a GICv3.
>
> Signed-off-by: Shlomo Pongratz
> [PMM: significantly overhauled/rewritten:
> * use the new data structures
> *
On 2016/6/14 22:38, Peter Maydell wrote:
> Implement the CPU interface registers for the GICv3; these are
> CPU system registers, not MMIO registers.
>
> This commit implements all the registers which are simple
> accessors for GIC state, but not those which act as interfaces
> for
On 2016/6/14 22:38, Peter Maydell wrote:
> From: Shlomo Pongratz
>
> Implement the distributor registers of a GICv3.
>
> Signed-off-by: Shlomo Pongratz
> [PMM: significantly overhauled/rewritten:
> * use the new bitmap data structures
On 2016/6/14 22:38, Peter Maydell wrote:
> Implement the GICv3 logic to recalculate the highest priority pending
> interrupt for each CPU after some part of the GIC state has changed.
> We avoid unnecessary full recalculation where possible.
>
> Signed-off-by: Peter Maydell
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> There is no need to scan allocation tables if we have mark_all_dirty flag
> set. Just mark it all dirty.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> CC: Stefan Hajnoczi
On 2016/6/14 22:38, Peter Maydell wrote:
> From: Pavel Fedin
>
> Add state structure descriptors for the GICv3 state. We mark
> the KVM GICv3 device as having a migration blocker until the
> code to save and restore the state in the kernel is implemented.
>
>
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> The code inside the helper will be extended in the next patch. mirror_run
> itself is overbloated at the moment.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> CC: Stefan
On Tue, 06/14 16:49, Max Reitz wrote:
> On 18.05.2016 07:53, Fam Zheng wrote:
> > Otherwise the job is orphaned and block_job_cancel_sync in
> > bdrv_close_all() when quiting will hang.
> >
> > A simple reproducer is running blockdev-backup from null-co:// to
> > null-co://.
> >
> > Cc:
On Tue, 06/14 16:49, Max Reitz wrote:
> On 18.05.2016 07:53, Fam Zheng wrote:
> > Otherwise the job is orphaned and block_job_cancel_sync in
> > bdrv_close_all() when quiting will hang.
> >
> > A simple reproducer is running blockdev-backup from null-co:// to
> > null-co://.
> >
> > Cc:
On 06/14/2016 06:33 PM, Fam Zheng wrote:
> On Tue, 06/14 16:05, Eric Blake wrote:
>> On 05/31/2016 08:23 PM, Fam Zheng wrote:
>>> The file is only included from the top Makefile. Rename it to reflect
>>> this more obviously.
>>>
>>> Signed-off-by: Fam Zheng
>>> ---
>>> Makefile
On Tue, Jun 14, 2016 at 08:23:08AM +0200, Andrew Jones wrote:
> On Tue, Jun 14, 2016 at 01:03:41PM +1000, David Gibson wrote:
> > On Fri, Jun 10, 2016 at 07:40:21PM +0200, Andrew Jones wrote:
> > > Use CPUState nr_cores,nr_threads and MachineState
> > > cores,threads instead.
> > >
> > >
On Tue, Jun 14, 2016 at 08:08:07AM +0200, Andrew Jones wrote:
> On Tue, Jun 14, 2016 at 12:00:26PM +1000, David Gibson wrote:
> > On Fri, Jun 10, 2016 at 07:40:16PM +0200, Andrew Jones wrote:
> > > Signed-off-by: Andrew Jones
> > > ---
> > > hw/core/machine.c | 81
> > >
On Tue, Jun 14, 2016 at 08:19:49AM +0200, Andrew Jones wrote:
> On Tue, Jun 14, 2016 at 12:12:16PM +1000, David Gibson wrote:
> > On Sun, Jun 12, 2016 at 03:48:10PM +0200, Andrew Jones wrote:
> > > On Sat, Jun 11, 2016 at 08:54:35AM +0200, Thomas Huth wrote:
> > > > On 10.06.2016 19:40, Andrew
On Tue, Jun 14, 2016 at 04:03:29PM +0200, Andrew Jones wrote:
> On Tue, Jun 14, 2016 at 01:53:05PM +0200, Paolo Bonzini wrote:
> >
> >
> > On 14/06/2016 13:39, Andrew Jones wrote:
> > > On Tue, Jun 14, 2016 at 10:17:49AM +0200, Paolo Bonzini wrote:
> > >> On 13/06/2016 22:35, Andrew Jones wrote:
On Tue, Jun 14, 2016 at 10:17:49AM +0200, Paolo Bonzini wrote:
>
>
> On 13/06/2016 22:35, Andrew Jones wrote:
> > On Mon, Jun 13, 2016 at 07:04:01PM +0200, Paolo Bonzini wrote:
> >> On 10/06/2016 19:40, Andrew Jones wrote:
> >>> +if (sockets == -1 || cores == -1 || threads == -1 ||
> >>> +
On Tue, 06/14 16:05, Eric Blake wrote:
> On 05/31/2016 08:23 PM, Fam Zheng wrote:
> > The file is only included from the top Makefile. Rename it to reflect
> > this more obviously.
> >
> > Signed-off-by: Fam Zheng
> > ---
> > Makefile | 2 +-
> >
On Tue, 06/14 11:07, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno
> ---
> Makefile | 2 +-
> 1 file
On 04/06/2016 12:28 PM, Max Reitz wrote:
> Add a new option "address" to the NBD block driver which accepts a
> SocketAddress.
>
> "path", "host" and "port" are still supported as legacy options and are
> mapped to their corresponding SocketAddress representation.
The back-compat work is pretty
On 04/06/2016 12:28 PM, Max Reitz wrote:
> As of a future patch, the NBD block driver will accept a SocketAddress
> structure for a new "address" option. In order to support this,
> nbd_refresh_filename() needs some changes.
>
> The two TODOs introduced by this patch will be removed in the very
On 04/06/2016 12:28 PM, Max Reitz wrote:
> Right now, we have four possible options that conflict with specifying
> an NBD filename, and a future patch will add another one ("address").
> This future option is a nested QDict that is flattened at this point,
> requiring as to test each option
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> 4th argument is flags rather than size. Fortunately flags occupies
> 5 less significant bits and they are always zero due to alignment.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Vladimir
On 05/03/2016 09:23 AM, Kevin Wolf wrote:
> Am 06.04.2016 um 20:28 hat Max Reitz geschrieben:
>> Turns out NBD is not so simple to do if you do it right. Anyway, this
>> series adds blockdev-add support for NBD clients.
>
> What the series does seems to make sense to me, though things would be a
On 04/06/2016 12:28 PM, Max Reitz wrote:
> Instead of inlining this nice macro (i.e. resorting to
> qdict_put_obj(..., QOBJECT(...))), use it.
>
> Signed-off-by: Max Reitz
> ---
> block/nbd.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by:
On 04/06/2016 12:28 PM, Max Reitz wrote:
> Instead of not emitting the port in nbd_refresh_filename(), just set it
> to the default if the user did not specify it. This makes the logic a
> bit simpler.
>
> Signed-off-by: Max Reitz
> ---
> block/nbd.c | 18 +++---
>
Public bug reported:
This commit prevents qemu from overallocating if qcow2 image is too big
(whatever that means): https://lists.gnu.org/archive/html/qemu-
devel/2014-07/msg01481.html
However, `qemu-img resize` isn't protected by the same code and allows
to go beyond that.
root@nwkr-laptop
On 06/14/2016 12:07 PM, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno
> ---
> Makefile | 2 +-
> 1
On 04/06/2016 12:28 PM, Max Reitz wrote:
> This is a shorthand function for changing a QDict's entry's key.
>
> Signed-off-by: Max Reitz
> ---
> include/qapi/qmp/qdict.h | 1 +
> qobject/qdict.c | 23 +++
> 2 files changed, 24 insertions(+)
On 14/06/2016 17:59, Alex Bligh wrote:
>
>> On 14 Jun 2016, at 16:11, Paolo Bonzini wrote:
>>
>>> To illustrate the problem, look consider what qemu itself would do as
>>> a server if it can't buffer the entire read issued to it.
>>
>> Return ENOMEM?
>
> Well OK, qemu
On 14/06/2016 23:32, Programmingkid wrote:
>
> On Jun 14, 2016, at 5:13 PM, BALATON Zoltan wrote:
>
>> On Tue, 14 Jun 2016, Programmingkid wrote:
>>> On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote:
smp_cores is only used by pseries and x86 machines. I expect machines
On 06/14/2016 06:36 AM, Jeff Cody wrote:
> On Tue, Jun 14, 2016 at 03:27:55PM +0530, Prasanna Kalever wrote:
>> Hello,
>>
>> Can someone please help me in tracking the QAPI changes for union
>> discriminator addition,
>> the below [1] gluster related patches are awaiting from very long,
>> because
On 04/06/2016 12:28 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> block/nbd.c | 4 ++--
> tests/qemu-iotests/051.out| 4 ++--
> tests/qemu-iotests/051.pc.out | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
On 06/14/2016 04:08 AM, Denis V. Lunev wrote:
> Please note, trace_init_backends() must be called in the final process,
> i.e. after daemonization. This is necessary to keep tracing thread in
> the proper process.
>
> Signed-off-by: Denis V. Lunev
> CC: Eric Blake
On 14/06/2016 10:33, Markus Armbruster wrote:
> The remaining ones are
> effectively orphaned, but you can't see that in MAINTAINERS. I feel
> keeping status there honest is important.
>
> Subsystems
> --
> Checkpatch
> M: Blue Swirl
> S: Odd
On 05/31/2016 08:23 PM, Fam Zheng wrote:
> The file is only included from the top Makefile. Rename it to reflect
> this more obviously.
>
> Signed-off-by: Fam Zheng
> ---
> Makefile | 2 +-
> tests/{Makefile => Makefile.include} | 0
> 2 files
Quoting marcandre.lur...@redhat.com (2016-06-14 08:16:53)
> From: Marc-André Lureau
>
> Define QEMU_SRC_PATH in config-host.h, to ease accessing of tests data
> files.
>
> Signed-off-by: Marc-André Lureau
I know this avoids the need to
Thanks for the test case. It appears that this is a regression that
occurred somewhere between 2.5 and 2.6 - bisecting now.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1588328
Title:
Qemu 2.6
On 06/14/2016 06:26 AM, Stefan Hajnoczi wrote:
> On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote:
>> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%)
>> +$(call quiet-command,cat $^ > $@)
>
> $^ needs to be a stable ordering across make invocations and
On 14/06/2016 20:38, Eduardo Habkost wrote:
> On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote:
>> Since iommu devices can be created with '-device' there is
>> no need to keep iommu as machine and mch property.
>>
>> Signed-off-by: Marcel Apfelbaum
>
> On
On 08/06/16 16:05, Alexey Kardashevskiy wrote:
> On 08/06/16 16:00, David Gibson wrote:
>> On Mon, Jun 06, 2016 at 03:31:04PM +0200, Paolo Bonzini wrote:
>>>
>>>
>>> On 02/06/2016 05:35, David Gibson wrote:
On Wed, Jun 01, 2016 at 06:57:37PM +1000, Alexey Kardashevskiy wrote:
>> Every
On 23/02/16 18:33, Richard Henderson wrote:
> Via indirection off cpu_regwptr.
>
> Tested-by: Mark Cave-Ayland
> Signed-off-by: Richard Henderson
> ---
> target-sparc/translate.c | 57
>
> 1
On 06/14/2016 04:08 AM, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev
> CC: Eric Blake
> CC: Paolo Bonzini
> CC: Stefan Hajnoczi
> CC: Kevin Wolf
> ---
> qemu-options.hx | 2 +-
> 1 file
On 06/14/2016 04:08 AM, Denis V. Lunev wrote:
> The command will work this way:
> qemu-img --trace qcow2* create -f qcow2 1.img 64G
>
> Signed-off-by: Denis V. Lunev
> Suggested by: Daniel P. Berrange
> CC: Eric Blake
> CC: Paolo
- Original Message -
> From: "Eduardo Habkost"
> To: "Igor Mammedov"
> Cc: qemu-devel@nongnu.org, "peter maydell" , "mark
> cave-ayland"
> , blauwir...@gmail.com, qemu-...@nongnu.org,
>
On 06/14/2016 03:49 PM, Eric Blake wrote:
> On 06/14/2016 04:08 AM, Denis V. Lunev wrote:
>> This text will be included to qemu-nbd/qemu-img mans in the next patches.
>>
>> Signed-off-by: Denis V. Lunev
>> CC: Eric Blake
>> CC: Paolo Bonzini
On Tue, Jun 14, 2016 at 05:38:42PM -0400, Paolo Bonzini wrote:
>
>
> - Original Message -
> > From: "Eduardo Habkost"
> > To: "Paolo Bonzini"
> > Cc: "Peter Maydell" , "Andreas Färber"
> > ,
The raw block driver was blindly copying all limits from bs->file,
even though: 1. the main bdrv_refresh_limits() already does this
for many of gthe limits, and 2. blindly copying from the children
can weaken any stricter limits that were already inherited from
the backing dhain during the main
On 06/14/2016 04:08 AM, Denis V. Lunev wrote:
> This text will be included to qemu-nbd/qemu-img mans in the next patches.
>
> Signed-off-by: Denis V. Lunev
> CC: Eric Blake
> CC: Paolo Bonzini
> CC: Stefan Hajnoczi
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
qemu-iotests 77 is particularly sensitive to the fact that we
On 06/14/2016 11:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> Fix the following bug:
>
> # virsh start test
> Domain test started
>
> # virsh qemu-monitor-command test \
> '{"execute":"block-dirty-bitmap-add",\
> "arguments":{"node":"drive0","name":"ab"}}'
>
- Original Message -
> From: "Eduardo Habkost"
> To: "Paolo Bonzini"
> Cc: "Peter Maydell" , "Andreas Färber"
> , qemu-devel@nongnu.org, "Richard
> Henderson" , "Igor Mammedov"
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
Signed-off-by: Eric Blake
---
v2: new
On Tue, Jun 14, 2016 at 05:41:03PM -0400, Paolo Bonzini wrote:
>
>
> - Original Message -
> > From: "Eduardo Habkost"
> > To: "Igor Mammedov"
> > Cc: qemu-devel@nongnu.org, "peter maydell" ,
> > "mark cave-ayland"
> >
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
Signed-off-by: Eric Blake
---
v2: new
x86-pull-request tag was updated (patch 10/10 was removed). See
updated pull request info below.
The following changes since commit 49237b856ae58ee7955be0b959c504c51b014f20:
Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20160614-tag' into
staging (2016-06-14 16:32:32 +0100
Sector-based limits are awkward to think about; in our on-going
quest to move to byte-based interfaces, convert max_transfer_length
and opt_transfer_length. Rename them (dropping the _length suffix)
so that the compiler will help us catch the change in semantics
across any rebased code, and
On Jun 14, 2016, at 5:13 PM, BALATON Zoltan wrote:
> On Tue, 14 Jun 2016, Programmingkid wrote:
>> On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote:
>>> smp_cores is only used by pseries and x86 machines. I expect machines
>>> that must be single-socket to disregard smp_sockets
The function sector_limits_lun2qemu() returns a value in units of
the block layer's 512-byte sector, and can be as large as
0x4000, which is much larger than the block layer's inherent
limit of BDRV_REQUEST_MAX_SECTORS. The block layer already
handles '0' as a synonym to the inherent limit,
We were basing the advertisement of maximum discard and transfer
length off of UINT32_MAX, but since the rest of the block layer
has signed int limits on a transaction, nothing could ever reach
that maximum, and we risk overflowing an int once things are
converted to byte-based rather than
Sector-based limits are awkward to think about; in our on-going
quest to move to byte-based interfaces, convert max_discard and
discard_alignment. Rename them, using 'pdiscard' as an aid to
track which remaining discard interfaces need conversion, and so
that the compiler will help us catch the
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
Add a .bdrv_refresh_limits() to all four of our legacy devices
It makes more sense to have ALL block size limit constraints
in the same struct. Improve the documentation while at it.
Signed-off-by: Eric Blake
---
v2: drop hacks for save/restore of alignment, now that earlier
patches handled setting up BlockLimits more sanely
---
We don't pass any flags on to drivers to handle. Tighten an
assert to explain why we pass 0 to bdrv_driver_preadv(), and add
some comments on things to be aware of if we want to turn on
per-BDS BDRV_REQ_FUA support during reads in the future. Also,
document that we may want to consider using
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
Now that all drivers have been updated to supply an override
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
In this case, raw_probe_alignment() already did what we
For symmetry with bdrv_aligned_preadv(), assert that the caller
really has aligned things properly. This requires adding an align
parameter, which is used now only in the new asserts, but will
come in handy in a later patch that adds auto-fragmentation to the
max transfer size, since that value
If the amount of data to read ends exactly on the total size
of the bs, then we were wasting time creating a local qiov
to read the data in preparation for what would normally be
appending zeroes beyond the end, even though this corner case
has nothing further to do.
Signed-off-by: Eric Blake
On Tue, Jun 14, 2016 at 05:16:40PM -0400, Paolo Bonzini wrote:
> - Original Message -
> > From: "Eduardo Habkost"
> > To: "Peter Maydell"
> > Cc: "Andreas Färber" , qemu-devel@nongnu.org, "Richard
> > Henderson"
Making all callers special-case 0 as unlimited is awkward,
and we DO have a hard maximum of BDRV_REQUEST_MAX_SECTORS given
our current block layer API limits.
In the case of scsi, this means that we now always advertise a
limit to the guest, even in cases where the underlying layers
previously
The NBD layer was breaking up request at a limit of 2040 sectors
(just under 1M) to cater to old qemu-nbd. But the server limit
was raised to 32M in commit 2d8214885 to match the kernel, more
than three years ago; and the upstream NBD Protocol is proposing
documentation that without any explicit
BlockLimits is currently an ugly mix of byte limits vs.
sector limits. Unify it. Fix some bugs I found in
bdrv_aligned_preadv() while at it.
Prequisite: Kevin's ongoing work to migrate bdrv_aligned_preadv()
to be byte-based (commit 3de06b2 on his vmstate branch at the
time of this email, but
On 06/14/2016 11:54 PM, Eduardo Habkost wrote:
On Tue, Jun 14, 2016 at 11:45:08PM +0300, Denis V. Lunev wrote:
On 06/14/2016 10:59 PM, Eduardo Habkost wrote:
On Tue, Jun 14, 2016 at 01:28:40PM +0300, Denis V. Lunev wrote:
From: Evgeny Yakovlev
This change adds
On Tue, 14 Jun 2016, Programmingkid wrote:
On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote:
smp_cores is only used by pseries and x86 machines. I expect machines
that must be single-socket to disregard smp_sockets altogether.
Could smp support be added to the beigeg3 and mac99
On Tue, 2016-06-14 at 16:25 +1000, David Gibson wrote:
> > Properly implement LPES0/1 handling for HV vs. !HV mode.
> >
> > Signed-off-by: Benjamin Herrenschmidt
> > [clg: AIL implementation was fixed in commit 5c94b2a5e5ef
> > fixed checkpatch.pl errors ]
>
>
Signed-off-by: Eduardo Habkost
Reviewed-by: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
Signed-off-by: Eduardo Habkost
---
target-i386/cpu.c | 74
On Tue, Jun 14, 2016 at 11:59:18PM +0300, Denis V. Lunev wrote:
> On 06/14/2016 11:54 PM, Eduardo Habkost wrote:
> > On Tue, Jun 14, 2016 at 11:45:08PM +0300, Denis V. Lunev wrote:
> > > On 06/14/2016 10:59 PM, Eduardo Habkost wrote:
> > > > On Tue, Jun 14, 2016 at 01:28:40PM +0300, Denis V. Lunev
- Original Message -
> From: "Eduardo Habkost"
> To: "Peter Maydell"
> Cc: "Andreas Färber" , qemu-devel@nongnu.org, "Richard
> Henderson" , "Paolo
> Bonzini" , "Igor Mammedov"
1 - 100 of 569 matches
Mail list logo