Re: [Qemu-devel] Any topics for today's MTTCG sync-up call?

Hi Alex, I'm looking into the worries that Sergey issued in his review of the last LL/SC series. The target is to reduce the TLB flushes by using an exclusive history of dynamic length. I don't have anything ready yet though. Best regards, alvise On Mon, Jun 20, 2016 at 1:57 PM, Alex Bennée

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

On 20/06/2016 14:31, Stefan Hajnoczi wrote: > On Mon, Jun 20, 2016 at 08:54:10AM +0200, Paolo Bonzini wrote: > > I wonder if Linux could run as a multiboot-compliant ELF file, and what > > the performance would be... Multiboot omits the real mode stub. > > The Linux boot protocol does not

Re: [Qemu-devel] [PATCH 03/10] vl: Reject invalid class names on -global

On Wed, 15 Jun 2016 17:32:46 -0300 Eduardo Habkost wrote: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Signed-off-by: Eduardo Habkost You are removing check that's used

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: [...] diff --git a/qapi/trace.json b/qapi/trace.json index 01b0a52..25d8095 100644 --- a/qapi/trace.json +++

Re: [Qemu-devel] RE-SEND: [PATCH 0/7] Enable multimedia applications on x86_64 guests

On Sat, Jun 18, 2016 at 07:14:56PM -0500, Timothy Pearson wrote: > Note: This is a resend due to my prior messages being word-wrapped > accidentally. > Apologies for the duplicates! > -- Please use git config

Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

Stefan Hajnoczi writes: > On Fri, Jun 17, 2016 at 10:16:25PM +0200, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > On Tue, Jun 14, 2016 at 03:11:12PM +0200, Lluís Vilanova wrote: >> >> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv) >> >> gdbserver_start (gdbstub_port); >> >>

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- monitor.c

Re: [Qemu-devel] [PATCHv1] rtl8139: save/load RxMulOk counter (again)

On Fri, Jun 17, 2016 at 05:31:30PM +0100, David Vrabel wrote: > Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port > TallyCounters to vmstate) introduced in incompatibility in the v4 > format as it omitted the RxOkMul counter. > > There are presumably no users that were impacted by

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

On Mon, Jun 20, 2016 at 08:54:10AM +0200, Paolo Bonzini wrote: > I wonder if Linux could run as a multiboot-compliant ELF file, and what > the performance would be... Multiboot omits the real mode stub. The Linux boot protocol does not require real mode. I think "64-bit BOOT PROTOCOL" in

Re: [Qemu-devel] [PULL 00/01] seccomp branch queue

> 16:16:37 +0100) > > are available in the git repository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp-20160620 > > for you to fetch changes up to 3e684455032a748be261e5a2524147940af9b6d9: > > seccomp: Add sup

Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/17] iscsi: Advertise realistic limits to block layer

On Tue, Jun 14, 2016 at 03:30:28PM -0600, Eric Blake wrote: > The function sector_limits_lun2qemu() returns a value in units of > the block layer's 512-byte sector, and can be as large as > 0x4000, which is much larger than the block layer's inherent > limit of BDRV_REQUEST_MAX_SECTORS. The

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Signed-off-by: Lluís Vilanova >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> monitor.c |4 +- >>> qapi/trace.json |

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Signed-off-by: Lluís Vilanova >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> monitor.c |4 +- >>> qapi/trace.json |

Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/17] nbd: Advertise realistic limits to block layer

On Tue, Jun 14, 2016 at 03:30:27PM -0600, Eric Blake wrote: > We were basing the advertisement of maximum discard and transfer > length off of UINT32_MAX, but since the rest of the block layer > has signed int limits on a transaction, nothing could ever reach > that maximum, and we risk

Re: [Qemu-devel] [RFC PATCH 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

* Jason Wang (jasow...@redhat.com) wrote: > > > On 2016年06月14日 19:15, Zhang Chen wrote: > > We will rewrite tcp packet secondary received and sent. > > More verbose please. E.g which fields were rewrote and why. > > > Signed-off-by: Zhang Chen > > Signed-off-by:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests

On Tue, Jun 14, 2016 at 03:30:26PM -0600, Eric Blake wrote: > The NBD layer was breaking up request at a limit of 2040 sectors > (just under 1M) to cater to old qemu-nbd. But the server limit > was raised to 32M in commit 2d8214885 to match the kernel, more > than three years ago; and the upstream

Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/17] block: Fix harmless off-by-one in bdrv_aligned_preadv()

On Tue, Jun 14, 2016 at 03:30:25PM -0600, Eric Blake wrote: > If the amount of data to read ends exactly on the total size > of the bs, then we were wasting time creating a local qiov > to read the data in preparation for what would normally be > appending zeroes beyond the end, even though this

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] block: Document supported flags during bdrv_aligned_preadv()

On Tue, Jun 14, 2016 at 03:30:24PM -0600, Eric Blake wrote: > We don't pass any flags on to drivers to handle. Tighten an > assert to explain why we pass 0 to bdrv_driver_preadv(), and add > some comments on things to be aware of if we want to turn on > per-BDS BDRV_REQ_FUA support during reads

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/17] block: Tighter assertions on bdrv_aligned_pwritev()

On Tue, Jun 14, 2016 at 03:30:23PM -0600, Eric Blake wrote: > For symmetry with bdrv_aligned_preadv(), assert that the caller > really has aligned things properly. This requires adding an align > parameter, which is used now only in the new asserts, but will > come in handy in a later patch that

Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

On Fri, Jun 17, 2016 at 10:16:25PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Tue, Jun 14, 2016 at 03:11:12PM +0200, Lluís Vilanova wrote: > >> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv) > >> gdbserver_start (gdbstub_port); > >> gdb_handlesig(cpu, 0); > >> } > >> +

Re: [Qemu-devel] [PATCH 02/10] qdev: Eliminate qemu_add_globals() function

On Wed, 15 Jun 2016 17:32:45 -0300 Eduardo Habkost wrote: > The function is just a helper to handle the -global options, it > can stay in vl.c like most qemu_opts_foreach() calls. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov

[Qemu-devel] Any topics for today's MTTCG sync-up call?

Hi, We missed the last call (sorry I was travelling). Have we any topics we would like to cover this week? -- Alex Bennée

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend

On 20 June 2016 at 11:22, Sergey Fedorov wrote: > On 20/06/16 12:57, Peter Maydell wrote: >> Fix missing includes of qemu/log.h, which broke compilation with the >> simple trace backend (the default backend pulls in log.h implicitly >> via trace.h). >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v3 0/7] virtio-blk: multiqueue support

On 20/06/2016 12:36, Stefan Hajnoczi wrote: > On Tue, Jun 07, 2016 at 05:28:24PM +0100, Stefan Hajnoczi wrote: >> v3: >> * Drop Patch 1 to batch guest notify for non-dataplane >> >>The Linux AIO completion BH and the virtio-blk batch notify BH changed >> order >>in the

[Qemu-devel] [Bug 1191457] Re: broken build without sdl

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1191457 Title: broken build without sdl Status in QEMU: Fix Released Bug

[Qemu-devel] [Bug 1079080] Re: ARM instruction "srs" wrong behaviour

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1079080 Title: ARM instruction "srs" wrong behaviour Status in QEMU: Fix Released

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unhandled

Re: [Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set

On 06/20/2016 01:42 PM, Igor Mammedov wrote: On Sun, 19 Jun 2016 19:13:17 +0300 Marcel Apfelbaum wrote: On 06/17/2016 07:07 PM, Laszlo Ersek wrote: On 06/17/16 11:52, Igor Mammedov wrote: On Fri, 17 Jun 2016 11:17:54 +0200 Gerd Hoffmann wrote: On Fr,

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Markus Armbruster writes: > Lluís Vilanova writes: >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Stefan Hajnoczi >> --- >> monitor.c |4 +- >> qapi/trace.json | 20 ++-- >> qmp-commands.hx | 17 ++- >>

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Markus Armbruster writes: > Lluís Vilanova writes: >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Stefan Hajnoczi >> --- >> monitor.c |4 +- >> qapi/trace.json | 20 ++-- >> qmp-commands.hx | 17 ++- >>

[Qemu-devel] [PATCH-Block] rbd:disable we if rbd cache is off

rbd: disable wce if rbd cache is off wce will be enabled when cachemode is 'none', disable wce will NOT impact data consistency but will extremely improve the guest os db workload (write/fsync) performance since fsync will wait all in-flight io to complete introduced

Re: [Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set

On Sun, 19 Jun 2016 19:13:17 +0300 Marcel Apfelbaum wrote: > On 06/17/2016 07:07 PM, Laszlo Ersek wrote: > > On 06/17/16 11:52, Igor Mammedov wrote: > >> On Fri, 17 Jun 2016 11:17:54 +0200 > >> Gerd Hoffmann wrote: > >> > >>> On Fr, 2016-06-17 at 10:43

Re: [Qemu-devel] [PATCH v3 0/7] virtio-blk: multiqueue support

On Tue, Jun 07, 2016 at 05:28:24PM +0100, Stefan Hajnoczi wrote: > v3: > * Drop Patch 1 to batch guest notify for non-dataplane > >The Linux AIO completion BH and the virtio-blk batch notify BH changed > order >in the AioContext->first_bh list as a side-effect of moving the BH from >

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/06/2016 10:14, Chao Peng wrote: > > Basically: > > - it removes old ISA devices and support only PCI devices; > > I think you need to keep at least the RTC, otherwise where does Linux > get the time of day from? > > > - it removes 8259,

Re: [Qemu-devel] [Qemu-block] [PATCH] linux-aio: Cancel BH if not needed

On Fri, Jun 17, 2016 at 12:24:11PM +0200, Kevin Wolf wrote: > Am 17.06.2016 um 12:13 hat Stefan Hajnoczi geschrieben: > > On Wed, Jun 15, 2016 at 01:16:42PM +0200, Kevin Wolf wrote: > > > linux-aio uses a BH in order to make sure that the remaining completions > > > are processed even in nested

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend

On 20/06/16 12:57, Peter Maydell wrote: > Fix missing includes of qemu/log.h, which broke compilation with the > simple trace backend (the default backend pulls in log.h implicitly > via trace.h). > > Signed-off-by: Peter Maydell Tested-by: Sergey Fedorov

Re: [Qemu-devel] [PATCH v6 8/9] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D>

This patch is about NaN-2008 flavor of Mips instructions CEIL, CVT, FLOOR, ROUND, TRUNC only (its title is "Add nan2008 flavor..."). Legacy-NaN flavors of the same Mips instructions already operate correctly, and there is nothing to be fixed. The commit message is not description of another

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On Mon, 2016-06-20 at 18:02 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-06-20 at 17:08 +1000, Benjamin Herrenschmidt wrote: > >   > > That fixed, it dies elsewhere in something related to page faults, > > still digging. > >   > Next problem: Darwin kernel assumes DSISR is 0 on a 0x380

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Add missing break

On 20 June 2016 at 02:55, Shannon Zhao wrote: > From: Shannon Zhao > > These are spotted by coverity 1356936 and 1356937. > > Signed-off-by: Shannon Zhao Oops. Thanks, applied to target-arm.next. -- PMM

[Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend

Fix missing includes of qemu/log.h, which broke compilation with the simple trace backend (the default backend pulls in log.h implicitly via trace.h). Signed-off-by: Peter Maydell --- In particular, this broke travis builds. --- hw/intc/arm_gicv3_dist.c | 1 +

Re: [Qemu-devel] [PATCH v3 0/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

On Mon, 20 Jun 2016, Juergen Gross wrote: > In case the word size of the domU and qemu running the qdisk backend > differ BLKIF_OP_DISCARD will not work reliably, as the request > structure in the ring have different layouts for different word size. > > Correct this by copying the request

Re: [Qemu-devel] [PATCH v3 2/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

On Mon, 20 Jun 2016, Juergen Gross wrote: > In case the word size of the domU and qemu running the qdisk backend > differ BLKIF_OP_DISCARD will not work reliably, as the request > structure in the ring have different layouts for different word size. > > Correct this by copying the request

[Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"

Display an exception number, generally defined as an hexadecimal number (for instance, EXCP_HLT is 0x10001). Signed-off-by: Laurent Vivier --- Resent to fix qemu-trivial email address. linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v3 1/2] xen: fix style of hw/block/xen_blkif.h

On Mon, 20 Jun 2016, Juergen Gross wrote: > Fix hw/block/xen_blkif.h to match qemu coding style. > > Signed-off-by: Juergen Gross Acked-by: Stefano Stabellini > hw/block/xen_blkif.h | 151 > +++ > 1

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

On Mon, 20 Jun 2016, Juergen Gross wrote: > On 17/06/16 18:10, Stefano Stabellini wrote: > > On Fri, 17 Jun 2016, Paul Durrant wrote: > >>> -Original Message- > >>> From: Juergen Gross [mailto:jgr...@suse.com] > >>> Sent: 17 June 2016 11:40 > >>> To: Paul Durrant; Jan Beulich > >>> Cc:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On Mon, 2016-06-20 at 08:17 +0200, Cédric Le Goater wrote: >  > The current patch does not need fixing. I will send the OpenBIOS > patch  > shortly after I have looked at the FPU exception. > > Linux ppc behaves the same on a 970. So we will need to fix the > 'rfi's there also.  What do you mean

[Qemu-devel] [PATCH] iscsi: fix assertion in is_sector_request_lun_aligned

Commit 94d047a added an assertion the the request alignment check. This introduced 2 issues: a) A off-by-one error since a request of BDRV_REQUEST_MAX_SECTORS is actually allowed. b) The bdrv_get_block_status call in the read path to check the allocation status requests up to INT_MAX

Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

On 06/20/2016 04:52 PM, Paolo Bonzini wrote: On 20/06/2016 10:23, Zhang Chen wrote: We want to poll and handle chardev in another thread other than main loop. Can you explain this better? For example, we use this in codes: +qemu_chr_add_handlers(s->chr_sec_in, compare_chr_can_read, +

[Qemu-devel] [PULL 01/01] seccomp: Add support for ppc/ppc64

From: Michael Strosaker Support for ppc/ppc64 is official in libseccomp 2.3.0, so modify the configuration script to allow qemuu to enable seccomp for those platforms. Signed-off-by: Michael Strosaker Acked-by: Eduardo Otubo

[Qemu-devel] [PULL 00/01] seccomp branch queue

-20160620 for you to fetch changes up to 3e684455032a748be261e5a2524147940af9b6d9: seccomp: Add support for ppc/ppc64 (2016-06-20 11:04:09 +0200) seccomp branch queue

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

On 20.06.2016 10:56, Peter Maydell wrote: > On 20 June 2016 at 09:21, Thomas Huth wrote: >> Would it maybe make sense to add some tests for this stuff to the >> tests/tcg/ folder to make sure that such regressions do not sneak back >> in in the future? > > Wouldn't help very

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

On 20 June 2016 at 09:21, Thomas Huth wrote: > Would it maybe make sense to add some tests for this stuff to the > tests/tcg/ folder to make sure that such regressions do not sneak back > in in the future? Wouldn't help very much, because tests/tcg doesn't get run. (The

Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

On 20/06/2016 10:23, Zhang Chen wrote: > We want to poll and handle chardev in another thread > other than main loop. Can you explain this better? Paolo > But qemu_chr_add_handlers() can only > work for global default context other than thread default context. > So we use g_souce_attach(xx,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On 06/20/2016 09:47 AM, Thomas Huth wrote: > On 20.06.2016 08:17, Cédric Le Goater wrote: >> On 06/20/2016 04:19 AM, David Gibson wrote: >>> On Mon, Jun 20, 2016 at 07:12:38AM +1000, Benjamin Herrenschmidt wrote: On Sun, 2016-06-19 at 19:23 +0200, Cédric Le Goater wrote: >> You can run a

Re: [Qemu-devel] [PULL 00/42] Tracing patches

On 17 June 2016 at 16:59, Stefan Hajnoczi wrote: > The following changes since commit 585fcd4b11070b3220685fc54ecca1991cdeb161: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-06-16 17:58:45 +0100) > > are available in the git

[Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

We want to poll and handle chardev in another thread other than main loop. But qemu_chr_add_handlers() can only work for global default context other than thread default context. So we use g_souce_attach(xx, g_main_context_get_thread_default()) replace g_source_attach(xx, NULL) to attach g_source.

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

On 18.06.2016 06:02, Anton Blanchard wrote: > Hi, > Bother. I've tentatively put a revert into ppc-for-2.7. Richard, do you have a better idea how to fix it? >>> >>> Please try the following. >> >> Thanks! This passes my tests. Feel free to add: >> >> Tested-by: Anton Blanchard

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On Mon, 2016-06-20 at 09:47 +0200, Thomas Huth wrote: > > Linux ppc behaves the same on a 970. So we will need to fix the 'rfi's > > there also.  > > Really? Wow, that surprises me. That OpenBIOS code likely never ran on a > real 970 hardware, so that's not too much surprising that the "rfi" >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On Mon, 2016-06-20 at 08:10 +0200, Cédric Le Goater wrote: > That is how I feel also. So, why don't we just remove the op code in the  > instruction sets from the 32bit CPUs instead of leaving it and testing  > for PPC_SEGMENT_64B ? or is there some reasons we want to keep it around ?  Ah no

Re: [Qemu-devel] [PATCH 05/10] qdev: GlobalProperty.errp field

Eduardo Habkost writes: > The new field will allow error handling to be configured by > qdev_prop_register_global() callers: _fatal and > _abort can be used to make QEMU exit or abort if any errors > are reported when applying the properties. > > Suggested-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 0/2] tcg: Fix i686 booting sparc64 openbios

On 18.06.2016 07:03, Richard Henderson wrote: > There's a minor typo here that affects dumping of 64-bit > registers on 32-bit hosts. Kind of embarrasing that this > hasn't been seen previously. > > The main change takes care of cases wherein there's overlap > between the indirect base register

Re: [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the "git describe" output

On Mon, 06/20 12:50, Changlong Xie wrote: > For this patch, i think you forget to add qemu-version.h and/or > qemu-version.h.tmp in .gitignore > > changlox ~/w/qemu/qemu% gs > On branch master > Your branch is up-to-date with 'origin/master'. > > Untracked files: > (use "git add ..." to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On Mon, 2016-06-20 at 17:08 +1000, Benjamin Herrenschmidt wrote: >  > That fixed, it dies elsewhere in something related to page faults, > still digging. >  Next problem: Darwin kernel assumes DSISR is 0 on a 0x380 exception ! qemu was leaving it to whatever value it had before. Kaboom. Now it

Re: [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors applying globals

Eduardo Habkost writes: > The same Error* will be used in an error_propagate() call in the > future, so prepend a "can't apply global" prefix to it. What future? A future patch? > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties.c | 5

Re: [Qemu-devel] [PATCH 03/10] vl: Reject invalid class names on -global

Eduardo Habkost writes: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties.c | 7 --- > vl.c

[Qemu-devel] [PATCH v3 2/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

In case the word size of the domU and qemu running the qdisk backend differ BLKIF_OP_DISCARD will not work reliably, as the request structure in the ring have different layouts for different word size. Correct this by copying the request structure in case of different word size element by element

[Qemu-devel] [PATCH v3 1/2] xen: fix style of hw/block/xen_blkif.h

Fix hw/block/xen_blkif.h to match qemu coding style. Signed-off-by: Juergen Gross --- hw/block/xen_blkif.h | 151 +++ 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/hw/block/xen_blkif.h b/hw/block/xen_blkif.h

[Qemu-devel] [PATCH v3 0/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

In case the word size of the domU and qemu running the qdisk backend differ BLKIF_OP_DISCARD will not work reliably, as the request structure in the ring have different layouts for different word size. Correct this by copying the request structure in case of different word size element by element

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On 20.06.2016 08:17, Cédric Le Goater wrote: > On 06/20/2016 04:19 AM, David Gibson wrote: >> On Mon, Jun 20, 2016 at 07:12:38AM +1000, Benjamin Herrenschmidt wrote: >>> On Sun, 2016-06-19 at 19:23 +0200, Cédric Le Goater wrote: > You can run a 32-bit OS or firmware on ppc64, but it needs to

Re: [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on first error

Eduardo Habkost writes: > qdev_prop_set_globals_for_type() stops applying global properties > on the first error. It is a leftover from when QEMU exited on any > error when applying global property. Now we print a warning about > the first error, bug ignore all other global

Re: [Qemu-devel] [PATCH v8 11/12] vfio: register aer resume notification handler for aer resume

ping On 2016/6/12 10:38, Zhou Jie wrote: Hi, Alex It seems like we have a number of questions open in the thread with MST from the previous version, particularly whether we should actually drop the resume notifier and block the reset in the kernel. The concern being that it's not very well

Re: [Qemu-devel] [PATCH RFC 4/4] range: Replace internal representation of Range

"Michael S. Tsirkin" writes: > On Wed, Jun 15, 2016 at 10:41:50PM +0200, Markus Armbruster wrote: >> Range represents a range as follows. Member @start is the inclusive >> lower bound, member @end is the exclusive upper bound. Zero @end is >> special: if @start is also zero,

Re: [Qemu-devel] [PATCH RFC 3/4] range: Drop the previous commit's trickery

"Michael S. Tsirkin" writes: > On Wed, Jun 15, 2016 at 10:41:49PM +0200, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > Agree with Eric about squashing this. Sanity check since Eric wrote "may": I assume you prefer this patch be squashed

Re: [Qemu-devel] [PATCH v4 2/3] target-i386: add migration support for Intel LMCE

On 06/20/16 08:58, Paolo Bonzini wrote: > > > On 20/06/2016 04:11, Haozhong Zhang wrote: > >>> > > Does that mean we can automatically enable LMCE for "-cpu host"? > >> > > >> > We can automatically enable LMCE for "-cpu host" if and only if > >> > the host kernel supports LMCE. > >> > > >

Re: [Qemu-devel] [PATCH RFC 2/4] range: Eliminate direct Range member access

"Michael S. Tsirkin" writes: > On Wed, Jun 15, 2016 at 10:41:48PM +0200, Markus Armbruster wrote: >> Users of struct Range mess liberally with its members, which makes >> refactoring hard. Create a set of methods, and convert all users to >> call them instead of accessing

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

Lluís Vilanova writes: > Signed-off-by: Lluís Vilanova > Reviewed-by: Stefan Hajnoczi > --- > monitor.c |4 +- > qapi/trace.json | 20 ++-- > qmp-commands.hx | 17 ++- > trace/qmp.c | 143 >

Re: [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU

> On 18 Jun 2016, at 13:24 PM, KarimAllah Ahmed wrote: > > When a PCI device lives behind an IOMMU, it should use 'pci_dma_*' family of > functions when any transfer from/to guest memory is required while > 'cpu_physical_memory_*' family of functions completely bypass any

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

On 06/20/16 08:56, Paolo Bonzini wrote: > > > On 20/06/2016 05:09, Haozhong Zhang wrote: > > In the current nested VMX implementation in QEMU, setup > > MSR_IA32_FEATURE_CONTROL is left to guest. So I think, for LMCE which > > is another feature involving MSR_IA32_FEATURE_CONTROL, we may follow

Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup()

> On 20 Jun 2016, at 05:45 AM, Jason Wang wrote: > > > > On 2016年06月17日 01:17, Peter Maydell wrote: >> This patchset converts a handful of network devices to use >> ld*_p() and st*_p() instead of cpu_to_*w() and *_to_cpup(). >> >> This is the last lot of conversion

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On 20.06.16 09:08, Benjamin Herrenschmidt wrote: > On Mon, 2016-06-20 at 08:35 +1000, Benjamin Herrenschmidt wrote: >> , >> Ok so Darwin uses some of the HSPRG etc... that we don't emulate on >> the 970 so I suspect it never worked. I've added them but something >> else breaks, I'll dig, I have

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On Mon, 2016-06-20 at 08:35 +1000, Benjamin Herrenschmidt wrote: > , > Ok so Darwin uses some of the HSPRG etc... that we don't emulate on > the 970 so I suspect it never worked. I've added them but something > else breaks, I'll dig, I have the kernel source so it shouldn't be > too hard > ;-)

Re: [Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set

On 19/06/2016 05:36, Michael S. Tsirkin wrote: > > Making the guest's phys-bits larger than host-phys-bits would be okay if > > you reserve the area in the e820 and assume the guest doesn't touch it. > > How would it touch it if there's no RAM there? > PCI BARs is the only thing that comes to

Re: [Qemu-devel] [PATCH v4 2/3] target-i386: add migration support for Intel LMCE

On 20/06/2016 04:11, Haozhong Zhang wrote: >>> > > Does that mean we can automatically enable LMCE for "-cpu host"? >> > >> > We can automatically enable LMCE for "-cpu host" if and only if >> > the host kernel supports LMCE. >> > > According to our discussion for KVM Patch 3, we may have to

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

On 20/06/2016 05:09, Haozhong Zhang wrote: > In the current nested VMX implementation in QEMU, setup > MSR_IA32_FEATURE_CONTROL is left to guest. So I think, for LMCE which > is another feature involving MSR_IA32_FEATURE_CONTROL, we may follow > the existing code. > > Paolo and Radim, is there

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

On 20/06/2016 08:01, Chao Peng wrote: > On Fri, Jun 17, 2016 at 03:24:59PM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2016 10:14, Chao Peng wrote: >>> Basically: >>> - it removes old ISA devices and support only PCI devices; >> >> I think you need to keep at least the RTC, otherwise where

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

> > The combination of devices removed/supported seems a bit arbitrary to me. > The use in this text of "legacy" and non-"legacy" is also arbitrary if not > given a definition. The criterial here is to remove the devices that have poor performance. You can think legacy devices here as ISA

[Qemu-devel] [PATCH v9 08/13] pci: Convert msi_init() to Error and fix callers to check it

msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don't handle the failure, it might happen: when user want msi on, but he doesn't get what he

Re: [Qemu-devel] [RFC PATCH 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

On 2016年06月14日 19:15, Zhang Chen wrote: We will rewrite tcp packet secondary received and sent. More verbose please. E.g which fields were rewrote and why. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen

Re: [Qemu-devel] [PATCH v9 08/13] pci: Convert msi_init() to Error and fix callers to check it

On 06/20/2016 08:13 AM, Cao jin wrote: > msi_init() reports errors with error_report(), which is wrong > when it's used in realize(). > > Fix by converting it to Error. > > Fix its callers to handle failure instead of ignoring it. > > For those callers who don't handle the failure, it might

[Qemu-devel] [PATCH v9 11/13] vmxnet3: remove unnecessary internal msi state flag

Internal flag msi_used is unnecessary, it has the same effect as msi_enabled(). msi_uninit() could be called directly without risk. cc: Paolo Bonzini cc: Dmitry Fleytman cc: Markus Armbruster cc: Marcel Apfelbaum

Re: [Qemu-devel] [PATCH 2/3] replay: allow replay stopping and restarting

> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > From: "Pavel Dovgalyuk" > > This patch fixes bug with stopping and restarting replay > > through monitor. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > block/blkreplay.c| 18

[Qemu-devel] [PATCH v9 12/13] e1000e: remove unnecessary internal msi state flag

Internal big flag E1000E_USE_MSI is unnecessary, also is the helper function: e1000e_init_msi(), e1000e_cleanup_msi(), so, remove them all. cc: Dmitry Fleytman cc: Jason Wang cc: Markus Armbruster cc: Marcel Apfelbaum

[Qemu-devel] [PATCH v9 13/13] vmw_pvscsi: remove unnecessary internal msi state flag

Internal flag msi_used is uncesessary, msi_uninit() could be called directly, msi_enabled() is enough to check device msi state. But for migration compatibility, keep the field in structure. cc: Paolo Bonzini cc: Dmitry Fleytman cc: Markus Armbruster

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

On Sun, Jun 19, 2016 at 06:51:04AM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 17, 2016 at 04:14:08AM -0400, Chao Peng wrote: > > - it is FAST; > > Any numbers to demonstrate just how fast it is and fast at what? On a 2.30GHz Haswell server, guest kernel booting time is 59.9ms by following

[Qemu-devel] [PATCH v9 03/13] usb xhci: change msi/msix property type

>From bit to enum OnOffAuto cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin ---

[Qemu-devel] [PATCH v9 09/13] megasas: remove unnecessary megasas_use_msi()

megasas overwrites user configuration when msi_init fail to flag internal msi state, which is unsuitable. megasa_use_msi() is unnecessary, we can call msi_uninit() directly when unrealize, even no need to call msi_enabled() first. cc: Hannes Reinecke cc: Paolo Bonzini

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

On 06/20/2016 04:19 AM, David Gibson wrote: > On Mon, Jun 20, 2016 at 07:12:38AM +1000, Benjamin Herrenschmidt wrote: >> On Sun, 2016-06-19 at 19:23 +0200, Cédric Le Goater wrote: You can run a 32-bit OS or firmware on ppc64, but it needs to know that it's running on a 64-bit chip and do

[Qemu-devel] [PATCH v9 06/13] megasas: change msi/msix property type

>From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by:

[Qemu-devel] [PATCH v9 02/13] mptsas: change .realize function name

All the other devices` .realize function name are xxx_realize, except this one. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Paolo Bonzini cc: Markus Armbruster Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v9 06/13] megasas: change msi/msix property type

On 06/20/2016 08:13 AM, Cao jin wrote: > From bit to enum OnOffAuto. > > cc: Hannes Reinecke > cc: Paolo Bonzini > cc: Michael S. Tsirkin > cc: Markus Armbruster > cc: Marcel Apfelbaum > > Reviewed-by:

<    1   2   3   4   5   >