[Qemu-devel] [PULL 38/43] block: Convert bdrv_pread(v) to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block.c| 7 --- block/bochs.c | 6 +++--- block/cloop.c | 8 block/crypto.c | 2 +- block/dmg.c

Re: [Qemu-devel] [PATCH RFC v3 1/5] tests: New make target check-source

2016-07-05 Thread Sascha Silbe
Dear Markus, I looked into the s390x specific failures as it would be nice to get them fixed up right away. Fortunately it looks like all of them are related to known shortcomings of the header check rather than actual issues with the header files, so there's nothing for me to do. ;) Markus

Re: [Qemu-devel] [PATCH v8 0/5] Add a generic loader

2016-07-05 Thread Alistair Francis
On Mon, Jul 4, 2016 at 5:22 AM, Peter Maydell wrote: > On 2 July 2016 at 02:07, Alistair Francis wrote: >> This work is based on the original work by Li Guang with extra >> features added by Peter C and myself. >> >> The idea of this loader

[Qemu-devel] [PULL 42/43] block: Convert bdrv_co_preadv/pwritev to BdrvChild

2016-07-05 Thread Kevin Wolf
This is the final patch for converting the common I/O path to take a BdrvChild parameter instead of BlockDriverState. The completion of this conversion means that all users that perform I/O on an image need to actually hold a reference (in the form of BdrvChild, possible as part of a

[Qemu-devel] [PATCH v2 3/6] tcg: cpu-exec: remove tb_lock from the hot-path

2016-07-05 Thread Alex Bennée
Lock contention in the hot path of moving between existing patched TranslationBlocks is the main drag in multithreaded performance. This patch pushes the tb_lock() usage down to the two places that really need it: - code generation (tb_gen_code) - jump patching (tb_add_jump) The rest of the

Re: [Qemu-devel] [PATCH v8 11/12] vfio: register aer resume notification handler for aer resume

2016-07-05 Thread Alex Williamson
On Tue, 5 Jul 2016 09:36:27 +0800 Zhou Jie wrote: > ping Due to weekend and holiday in my country, there were zero regular working hours between your emails. > On 2016/7/3 12:00, Zhou Jie wrote: > > Hi Alex, > > > > On 2016/6/30 9:45, Zhou Jie wrote: > >> Hi

[Qemu-devel] [PULL 39/43] block: Convert bdrv_pwrite(v/_sync) to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/io.c | 17 - block/parallels.c | 6 +++--- block/qcow.c | 14 +++--- block/qcow2-cache.c| 2 +-

[Qemu-devel] [PATCH v2 1/6] tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock'

2016-07-05 Thread Alex Bennée
From: Sergey Fedorov First, ensure atomicity of CPU's 'tb_jmp_cache' access by: * using atomic_read() to look up a TB when not holding 'tb_lock'; * using atomic_write() to remove a TB from each CPU's local cache on TB invalidation. Second, add some memory barriers to

[Qemu-devel] [PATCH v2 2/6] tcg: set up tb->page_addr before insertion

2016-07-05 Thread Alex Bennée
This ensures that if we find the TB on the slow path that tb->page_addr is correctly set before being tested. Signed-off-by: Alex Bennée --- translate-all.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/translate-all.c b/translate-all.c

[Qemu-devel] [PULL 37/43] block: Convert bdrv_write() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Acked-by: Stefan Hajnoczi --- block/io.c | 5 +++-- block/qcow.c | 45 - block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 2 +- block/qcow2.c |

Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.

2016-07-05 Thread Paolo Bonzini
On 14/06/2016 20:07, Sean Bruno wrote: > The --quiet argument is not available on all operating systems. Use -s > instead to match the rest of the Makefile uses. This fixes a non-fatal > error seen on FreeBSD. > > Signed-off-by: Sean Bruno > --- > Makefile | 2 +- > 1

[Qemu-devel] [PATCH v1 3/2] crypto: don't open-code qcrypto_hash_supports

2016-07-05 Thread Daniel P. Berrange
Call the existing qcrypto_hash_supports method from qcrypto_hash_bytesv instead of open-coding it again. Signed-off-by: Daniel P. Berrange --- crypto/hash-gcrypt.c | 3 +-- crypto/hash-glib.c | 3 +-- crypto/hash-nettle.c | 3 +-- 3 files changed, 3 insertions(+), 6

[Qemu-devel] [PULL 36/43] block: Convert bdrv_read() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/io.c| 4 ++-- block/qcow2-cluster.c | 6 +++--- block/vdi.c | 4 ++-- block/vvfat.c | 2 +- include/block/block.h | 2 +-

Re: [Qemu-devel] [PATCH 1/1] Improve block job rate limiting for small bandwidth values

2016-07-05 Thread Max Reitz
On 04.07.2016 16:30, Sascha Silbe wrote: > Dear Max, > > Max Reitz writes: > >> On 28.06.2016 17:28, Sascha Silbe wrote: > [block/mirror.c] >>> @@ -416,7 +416,9 @@ static uint64_t coroutine_fn >>> mirror_iteration(MirrorBlockJob *s) >>> assert(io_sectors); >>>

[Qemu-devel] Login and Password Request

2016-07-05 Thread Shiv Arora
Hi Developers I use the qemu command to up my virtual OS. But after that command executes it ask for localhost.localdomain.localdomain login: Password: I don`t want to add the login and password manually as i have to launch mutliple virtual OS and adding the login and password to each is not an

[Qemu-devel] [PATCH v2 6/6] tcg: cpu-exec: roll-up tb_find_fast/slow

2016-07-05 Thread Alex Bennée
In an effort not to re-take locks I've re-factored the code so everything is done inside the new tb_find function. The fast path will only take a lock if the previous TB needs patching. The generation path will do the patching inside the generation critical section. Signed-off-by: Alex Bennée

[Qemu-devel] [PULL 29/43] block: Convert bdrv_co_readv() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/crypto.c| 2 +- block/io.c| 8 block/parallels.c | 2 +- block/qcow.c | 5 ++--- block/raw_bsd.c | 2 +-

[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message

2016-07-05 Thread Daniel Berrange
** Changed in: qemu Assignee: (unassigned) => Daniel Berrange (berrange) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in

[Qemu-devel] [PATCH v2 4/6] tcg: cpu-exec: factor out TB patching code

2016-07-05 Thread Alex Bennée
This is going to be useful in the next patch when rolling up the locking on the slow path into the TB patching. Signed-off-by: Alex Bennée --- cpu-exec.c | 59 +-- 1 file changed, 37 insertions(+), 22 deletions(-)

[Qemu-devel] [PULL 22/43] block: Fix error message style

2016-07-05 Thread Kevin Wolf
From: Eric Blake error_setg() is not supposed to be used for multi-sentence messages; tweak the message to append a hint instead. Signed-off-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf ---

Re: [Qemu-devel] [PULL v2 00/30] pc, pci, virtio: new features, cleanups, fixes

2016-07-05 Thread Peter Maydell
On 5 July 2016 at 16:46, Michael S. Tsirkin wrote: > The following changes since commit e2c8f9e44e07d8210049abaa6042ec3c956f1dd4: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2016-07-04 10:49:17 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH] linux-user: Correct type for LOOP_GET_STATUS{, 64} ioctls

2016-07-05 Thread Laurent Vivier
Le 05/07/2016 à 17:36, Peter Maydell a écrit : > The LOOP_GET_STATUS and LOOP_GET_STATUS64 ioctls were incorrectly > defined as IOC_W rather than IOC_R, which meant we weren't > correctly copying the information back from the kernel to the guest. > The loop_info64 structure definition was also

[Qemu-devel] [PULL 16/43] block: Switch transfer length bounds to byte-based

2016-07-05 Thread Kevin Wolf
From: Eric Blake Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_transfer_length and opt_transfer_length. Rename them (dropping the _length suffix) so that the compiler will help us catch the change in

[Qemu-devel] [Bug 1599214] [NEW] virtlogd: qemu 2.6.0 doesn't log boot message

2016-07-05 Thread Markus Zoeller (markus_z)
Public bug reported: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2)

[Qemu-devel] [PULL 11/43] iscsi: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric

[Qemu-devel] [PULL 43/43] block/qcow2: Don't use cpu_to_*w()

2016-07-05 Thread Kevin Wolf
From: Peter Maydell Don't use the cpu_to_*w() functions, which we are trying to deprecate. Instead either just use cpu_to_*() to do the byteswap, or use st*_be_p() if we need to do the store somewhere other than to a variable that's already the correct type.

Re: [Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Peter Maydell
On 5 July 2016 at 16:20, Tom Hanson wrote: > So, in the original minimal command line above (#3) is the transport/bus > missing? Or is mmio implied? Or? The virt board creates a collection of virtio-mmio transports, so if you create just a backend on the command line

[Qemu-devel] [PULL 10/43] blkdebug: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Note that when the user

[Qemu-devel] [PULL 41/43] block: Convert bdrv_prwv_co() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/io.c | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/block/io.c b/block/io.c index

Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-07-05 Thread Denis V. Lunev
On 06/24/2016 01:49 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through

[Qemu-devel] [PULL 12/43] qcow2: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric

[Qemu-devel] [PULL 06/43] nbd: Advertise realistic limits to block layer

2016-07-05 Thread Kevin Wolf
From: Eric Blake We were basing the advertisement of maximum discard and transfer length off of UINT32_MAX, but since the rest of the block layer has signed int limits on a transaction, nothing could ever reach that maximum, and we risk overflowing an int once things are

Re: [Qemu-devel] [PATCH v4 10/11] qemu-img: Set the ID of the block job in img_commit()

2016-07-05 Thread Max Reitz
On 05.07.2016 16:29, Alberto Garcia wrote: > img_commit() creates a block job without an ID. This is no longer > allowed now that we require it to be unique and well-formed. We were > solving this by having a fallback in block_job_create(), but now that > we extended the API of

[Qemu-devel] [PULL 35/43] block: Use BlockBackend for I/O in bdrv_commit()

2016-07-05 Thread Kevin Wolf
Just like block jobs, the HMP commit command should use its own BlockBackend for doing I/O on BlockDriverStates. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/commit.c | 34

[Qemu-devel] [PULL 05/43] nbd: Allow larger requests

2016-07-05 Thread Kevin Wolf
From: Eric Blake The NBD layer was breaking up request at a limit of 2040 sectors (just under 1M) to cater to old qemu-nbd. But the server limit was raised to 32M in commit 2d8214885 to match the kernel, more than three years ago; and the upstream NBD Protocol is proposing

[Qemu-devel] [PULL 31/43] block: Convert bdrv_aio_readv() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-- block/io.c| 6 +++--- block/qed-table.c | 2 +- block/qed.c | 6

Re: [Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Tom Hanson
What would a device path look like for an MMIO backend? On Jul 5, 2016 9:35 AM, "Laszlo Ersek (Red Hat)" wrote: > I don't think this difference is intentional. I think we're seeing an > interplay between the following two commits: > > *

Re: [Qemu-devel] [PATCH 2/2] cpu-exec: remove tb_lock from the hot-path

2016-07-05 Thread Alex Bennée
Sergey Fedorov writes: > On 05/07/16 16:42, Paolo Bonzini wrote: >> >> On 05/07/2016 15:11, Alex Bennée wrote: >>> Paolo Bonzini writes: >>> On 05/07/2016 13:14, Alex Bennée wrote: > /* > * Patch the last TB with a jump to the current

[Qemu-devel] [PULL 02/43] block: Tighter assertions on bdrv_aligned_pwritev()

2016-07-05 Thread Kevin Wolf
From: Eric Blake For symmetry with bdrv_aligned_preadv(), assert that the caller really has aligned things properly. This requires adding an align parameter, which is used now only in the new asserts, but will come in handy in a later patch that adds auto-fragmentation to the

[Qemu-devel] [PULL 23/43] block: Use bool as appropriate for BDS members

2016-07-05 Thread Kevin Wolf
From: Eric Blake Using int for values that are only used as booleans is confusing. While at it, rearrange a couple of members so that all the bools are contiguous. Signed-off-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 40/43] block: Convert bdrv_pwrite_zeroes() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/block-backend.c | 5 + block/io.c | 9 + block/parallels.c | 2 +- block/qcow2-cluster.c

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Laszlo Ersek (Red Hat)
I'll try to come up with a patch, if for nothing more than illustration. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1594239 Title: After adding more scsi disks for Aarch64 virtual machine,

[Qemu-devel] [PULL 01/43] qemu-img: fix failed autotests

2016-07-05 Thread Kevin Wolf
From: "Denis V. Lunev" There are 9 iotests failed on Ubuntu 15.10 at the moment. The problem is that options parsing in qemu-img is broken by the following commit: commit 10985131e337a0c52c5bd1e191fd7867a6ff8d02 Author: Denis V. Lunev Date: Fri

[Qemu-devel] [PULL 19/43] block: Drop raw_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake The raw block driver was blindly copying all limits from bs->file, even though: 1. the main bdrv_refresh_limits() already does this for many of the limits, and 2. blindly copying from the children can weaken any stricter limits that were already inherited from

[Qemu-devel] [PULL 24/43] block: fix return code for partial write for Linux AIO

2016-07-05 Thread Kevin Wolf
From: "Denis V. Lunev" Partial write most likely means that there is not space rather than "something wrong happens". Thus it would be more natural to return ENOSPC rather than EINVAL. The problem actually happens with NBD server, which has reported EINVAL rather then ENOSPC on

[Qemu-devel] [PULL 34/43] block: Move bdrv_commit() to block/commit.c

2016-07-05 Thread Kevin Wolf
No code changes, just moved from one file to another. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Acked-by: Stefan Hajnoczi --- block.c | 110 --- block/Makefile.objs |

[Qemu-devel] [PULL 32/43] block: Convert bdrv_aio_writev() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-- block/io.c| 6 +++--- block/qed-table.c | 2 +- block/qed.c | 6

Re: [Qemu-devel] [PATCH v3 04/32] blockdev: Move bochs probe into separate file

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote: > This puts the bochs probe function into its own separate file as part of > the process of modularizing block drivers. Having the probe functions > separate from the rest of the driver allows us to probe without having > to potentially

[Qemu-devel] [PULL 27/43] blkreplay: Convert to byte-based I/O

2016-07-05 Thread Kevin Wolf
The blkreplay driver only forwards the requests it gets, so converting it to byte granularity is trivial. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/blkreplay.c | 16 1 file

[Qemu-devel] [PULL 33/43] block: Convert bdrv_co_do_readv/writev to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/io.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/block/io.c b/block/io.c index e929521..d8b3c96

[Qemu-devel] [PULL v2 28/30] vmxnet3: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Internal flag msi_used is unnecessary, it has the same effect as msi_enabled(). msi_uninit() could be called directly without risk. cc: Paolo Bonzini cc: Dmitry Fleytman cc: Markus Armbruster

[Qemu-devel] [PULL 18/43] block: Switch discard length bounds to byte-based

2016-07-05 Thread Kevin Wolf
From: Eric Blake Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_discard and discard_alignment. Rename them, using 'pdiscard' as an aid to track which remaining discard interfaces need conversion, and so that

[Qemu-devel] [PULL 25/43] block/qdev: Fix NULL access when using BB twice

2016-07-05 Thread Kevin Wolf
BlockBackend has only a single pointer to its guest device, so it makes sure that only a single guest device is attached to it. device-add returns an error if you try to attach a second device to a BB. In order to make the error message nicer, -device that manually connects to a if=none block

[Qemu-devel] [PULL 30/43] block: Convert bdrv_co_writev() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/crypto.c| 2 +- block/io.c| 6 +++--- block/parallels.c | 2 +- block/qcow.c | 2 +- block/vhdx.c | 2 +-

[Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin internal flag msi_in_use in unnecessary, msi_uninit() could be called directly, and msi_enabled() is enough to check device msi state. cc: Markus Armbruster cc: Marcel Apfelbaum cc: Paolo Bonzini

[Qemu-devel] [PULL 14/43] block: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Add a

[Qemu-devel] [PULL 21/43] block: Move request_alignment into BlockLimit

2016-07-05 Thread Kevin Wolf
From: Eric Blake It makes more sense to have ALL block size limit constraints in the same struct. Improve the documentation while at it. Simplify a couple of conditionals, now that we have audited and documented that request_alignment is always non-zero. Signed-off-by: Eric

[Qemu-devel] [PULL 28/43] vhdx: Some more BlockBackend use in vhdx_create()

2016-07-05 Thread Kevin Wolf
This does some easy conversions from bdrv_* to blk_* functions in vhdx_create(). We should avoid bypassing the BlockBackend layer whenever possible. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi ---

[Qemu-devel] [PULL v2 25/30] pci: Convert msi_init() to Error and fix callers to check it

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don't handle the failure, it might happen: when

[Qemu-devel] [PULL 09/43] block: Give nonzero result to blk_get_max_transfer_length()

2016-07-05 Thread Kevin Wolf
From: Eric Blake Making all callers special-case 0 as unlimited is awkward, and we DO have a hard maximum of BDRV_REQUEST_MAX_SECTORS given our current block layer API limits. In the case of scsi, this means that we now always advertise a limit to the guest, even in cases

[Qemu-devel] [PULL 20/43] block: Split bdrv_merge_limits() from bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake During bdrv_merge_limits(), we were computing initial limits based on another BDS in two places. At first glance, the two computations are not identical (one is doing straight copying, the other is doing merging towards or away from zero) - but when you

[Qemu-devel] [PULL 26/43] vvfat: Use BdrvChild for s->qcow

2016-07-05 Thread Kevin Wolf
vvfat uses a temporary qcow file to cache written data in read-write mode. In order to do things properly, this should show up in the BDS graph and I/O should go through BdrvChild like for every other node. Signed-off-by: Kevin Wolf Acked-by: Stefan Hajnoczi

[Qemu-devel] [PULL v2 21/30] intel-hda: change msi property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From uint32 to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL v2 18/30] tests: add APIC.cphp and DSDT.cphp blobs

2016-07-05 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/APIC.cphp | Bin 0 -> 160 bytes tests/acpi-test-data/pc/DSDT.cphp | Bin

[Qemu-devel] [PULL 15/43] block: Set default request_alignment during bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Now that all drivers

[Qemu-devel] [PULL 03/43] block: Document supported flags during bdrv_aligned_preadv()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We don't pass any flags on to drivers to handle. Tighten an assert to explain why we pass 0 to bdrv_driver_preadv(), and add some comments on things to be aware of if we want to turn on per-BDS BDRV_REQ_FUA support during reads in the future. Also, document

[Qemu-devel] [PULL 13/43] raw-win32: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. In this case,

[Qemu-devel] [PULL v2 20/30] usb xhci: change msi/msix property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From bit to enum OnOffAuto cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v3 06/32] blockdev: Move luks probe to its own file

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 11:24:06AM -0400, Colin Lord wrote: > Isolates the luks probe function as part of the modularization process. > > Signed-off-by: Colin Lord > --- > block/Makefile.objs | 2 +- > block/crypto.c| 21 + > block/probe/luks.c

[Qemu-devel] [PULL 08/43] scsi: Advertise limits by blocksize, not 512

2016-07-05 Thread Kevin Wolf
From: Eric Blake s->blocksize may be larger than 512, in which case our tweaks to max_xfer_len and opt_xfer_len must be scaled appropriately. CC: qemu-sta...@nongnu.org Reported-by: Fam Zheng Signed-off-by: Eric Blake Reviewed-by: Fam

[Qemu-devel] [PULL v2 30/30] vmw_pvscsi: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Internal flag msi_used is uncesessary, msi_uninit() could be called directly, msi_enabled() is enough to check device msi state. But for migration compatibility, keep the field in structure. cc: Paolo Bonzini cc: Dmitry Fleytman

[Qemu-devel] [PULL 04/43] block: Fix harmless off-by-one in bdrv_aligned_preadv()

2016-07-05 Thread Kevin Wolf
From: Eric Blake If the amount of data to read ends exactly on the total size of the bs, then we were wasting time creating a local qiov to read the data in preparation for what would normally be appending zeroes beyond the end, even though this corner case has nothing further

[Qemu-devel] [PULL 17/43] block: Wording tweaks to write zeroes limits

2016-07-05 Thread Kevin Wolf
From: Eric Blake Improve the documentation of the write zeroes limits, to mention additional constraints that drivers should observe. Worth squashing into commit cf081fca, if that hadn't been pushed already :) Signed-off-by: Eric Blake Reviewed-by: Fam

[Qemu-devel] [PULL v2 16/30] log: Permit -dfilter 0..0xffffffffffffffff

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Works fine since the previous commit fixed the underlying range data type. Of course it filters out nothing, but so does 0..1,2..0x, and we don't bother rejecting that either. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL v2 29/30] e1000e: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Internal big flag E1000E_USE_MSI is unnecessary, also is the helper function: e1000e_init_msi(), e1000e_cleanup_msi(), so, remove them all. cc: Dmitry Fleytman cc: Jason Wang cc: Markus Armbruster

[Qemu-devel] [PULL 00/43] Block layer patches

2016-07-05 Thread Kevin Wolf
The following changes since commit 60a0f1af07d685c88f4ffa09370da5bd7514823e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ipxe-20160704-1' into staging (2016-07-05 12:46:18 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[Qemu-devel] [PULL 07/43] iscsi: Advertise realistic limits to block layer

2016-07-05 Thread Kevin Wolf
From: Eric Blake The function sector_limits_lun2qemu() returns a value in units of the block layer's 512-byte sector, and can be as large as 0x4000, which is much larger than the block layer's inherent limit of BDRV_REQUEST_MAX_SECTORS. The block layer already handles '0'

[Qemu-devel] [PULL v2 14/30] range: Eliminate direct Range member access

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Users of struct Range mess liberally with its members, which makes refactoring hard. Create a set of methods, and convert all users to call them instead of accessing members. The methods have carefully worded contracts, and use assertions to check

[Qemu-devel] [PULL v2 24/30] pci bridge dev: change msi property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From bit to enum OnOffAuto. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin

[Qemu-devel] [PULL v2 22/30] mptsas: change msi property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From uint32 to enum OnOffAuto, and give it a shorter name. cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL v2 11/30] Revert "virtio-net: unbreak self announcement and guest offloads after migration"

2016-07-05 Thread Michael S. Tsirkin
This reverts commit 1f8828ef573c83365b4a87a776daf8bcef1caa21. Cc: qemu-sta...@nongnu.org Reported-by: Robin Geuze Tested-by: Robin Geuze Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 40

[Qemu-devel] [PULL v2 19/30] change pvscsi_init_msi() type to void

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Nobody use its return value, so change the type to void. cc: Michael S. Tsirkin cc: Paolo Bonzini cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL v2 26/30] megasas: remove unnecessary megasas_use_msi()

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin megasas overwrites user configuration when msi_init fail to flag internal msi state, which is unsuitable. megasa_use_msi() is unnecessary, we can call msi_uninit() directly when unrealize, even no need to call msi_enabled() first. cc: Hannes Reinecke

[Qemu-devel] [PULL v2 08/30] pc: Eliminate PcPciInfo

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster PcPciInfo has two (ill-named) members: Range w32 is the PCI hole, and w64 is the PCI64 hole. Three users: * I440FXState and MCHPCIState have a member PcPciInfo pci_info, but only pci_info.w32 is actually used. This is confusing. Replace by Range

[Qemu-devel] [PULL v2 10/30] virtio: set low features early on load

2016-07-05 Thread Michael S. Tsirkin
virtio migrates the low 32 feature bits twice, the first copy is there for compatibility but ever since 019a3edbb25f1571e876f8af1ce4c55412939e5d: ("virtio: make features 64bit wide") it's ignored on load. This is wrong since virtio_net_load tests self announcement and guest offloads before the

[Qemu-devel] [PULL v2 23/30] megasas: change msi/msix property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus

[Qemu-devel] [PULL v2 17/30] tests: acpi: add CPU hotplug testcase

2016-07-05 Thread Michael S. Tsirkin
From: Igor Mammedov Test with: -smp 2,cores=3,sockets=2,maxcpus=6 to capture sparse APIC ID values that default AMD CPU has in above configuration. Signed-off-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum Reviewed-by:

[Qemu-devel] [PULL v2 06/30] machine: remove iommu property

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Since iommu devices can be created with '-device' there is no need to keep iommu as machine and mch property. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 02/30] hw/ppc: realize the PCI root bus as part of mac99 init

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Mac99's PCI root bus is not part of a host bridge, realize it manually. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ppc/mac_newworld.c

[Qemu-devel] [PULL v2 13/30] log: Clean up misuse of Range for -dfilter

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Range encodes an integer interval [a,b] as { begin = a, end = b + 1 }, where a \in [0,2^64-1] and b \in [1,2^64]. Thus, zero end is to be interpreted as 2^64. The implementation of -dfilter (commit 3514552) uses Range differently: it encodes [a,b] as

[Qemu-devel] [PULL v2 15/30] range: Replace internal representation of Range

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Range represents a range as follows. Member @start is the inclusive lower bound, member @end is the exclusive upper bound. Zero @end is special: if @start is also zero, the range is empty, else @end is to be interpreted as 2^64. No other empty ranges

[Qemu-devel] [PULL v2 05/30] hw/iommu: enable iommu with -device

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Use the standard '-device intel-iommu' to create the IOMMU device. The legacy '-machine,iommu=on' can still be used. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 01/30] xen: fix ram init regression

2016-07-05 Thread Michael S. Tsirkin
From: Gerd Hoffmann Commit "8156d48 pc: allow raising low memory via max-ram-below-4g option" causes a regression on xen, because it uses a different memory split. This patch initializes max-ram-below-4g to zero and leaves the initialization to the memory initialization

[Qemu-devel] [PULL v2 12/30] pci_register_bar: cleanup

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin place relevant code tegother, make the code easier to read Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini

[Qemu-devel] [PULL v2 09/30] virtio: revert host notifiers to old semantics

2016-07-05 Thread Michael S. Tsirkin
From: Cornelia Huck The host notifier rework tried both to unify host notifiers across transports and plug a possible hole during host notifier re-assignment. Unfortunately, this meant a change in semantics that breaks vhost and iSCSI+dataplane. As the minimal fix,

Re: [Qemu-devel] [PATCH v4 09/11] commit: Add 'job-id' parameter to 'block-commit'

2016-07-05 Thread Max Reitz
On 05.07.2016 16:29, Alberto Garcia wrote: > This patch adds a new optional 'job-id' parameter to 'block-commit', > allowing the user to specify the ID of the block job to be created. > > Signed-off-by: Alberto Garcia > Reviewed-by: Kevin Wolf > --- >

[Qemu-devel] [PULL v2 07/30] piix: Set I440FXState member pci_info.w32 in one place

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Range pci_info.w32 records the location of the PCI hole. It's initialized to empty when QOM zeroes I440FXState. That's a fine value for a still unknown PCI hole. i440fx_init() sets pci_info.w32.begin = below_4g_mem_size. Changes the PCI hole from

Re: [Qemu-devel] [PATCH v4 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror'

2016-07-05 Thread Max Reitz
On 05.07.2016 16:28, Alberto Garcia wrote: > This patch adds a new optional 'job-id' parameter to 'blockdev-mirror' > and 'drive-mirror', allowing the user to specify the ID of the block > job to be created. > > The HMP 'drive_mirror' command remains unchanged. > > Signed-off-by: Alberto Garcia

[Qemu-devel] [PULL v2 00/30] pc, pci, virtio: new features, cleanups, fixes

2016-07-05 Thread Michael S. Tsirkin
The following changes since commit e2c8f9e44e07d8210049abaa6042ec3c956f1dd4: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-07-04 10:49:17 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

Re: [Qemu-devel] [PATCH 2/2] cpu-exec: remove tb_lock from the hot-path

2016-07-05 Thread Sergey Fedorov
On 05/07/16 16:42, Paolo Bonzini wrote: > > On 05/07/2016 15:11, Alex Bennée wrote: >> Paolo Bonzini writes: >> >>> On 05/07/2016 13:14, Alex Bennée wrote: /* * Patch the last TB with a jump to the current TB. * * Modification of the TB has to be

<    1   2   3   4   5   >