[Qemu-devel] [PATCH v3] qemu-img: add the 'dd' subcommand

2016-07-18 Thread Reda Sallahi
This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The image format must be specified with -O for

Re: [Qemu-devel] [PATCH v5 07/14] nbd: Share common option-sending code in client

2016-07-18 Thread Fam Zheng
On Mon, 07/18 22:07, Eric Blake wrote: > Rather than open-coding each option request, it's easier to > have common helper functions do the work. That in turn requires > having convenient packed types for handling option requests > and replies. > > Signed-off-by: Eric Blake >

Re: [Qemu-devel] [PATCH V5 0/7] pxb: fix 64-bit MMIO allocation

2016-07-18 Thread Marcel Apfelbaum
On 07/17/2016 07:53 PM, Marcel Apfelbaum wrote: v4 -> v5: Addressed the pull request issues: (Peter Maydell) See: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00882.html - cland warning -> "hw/pci/pci.c:196:23: runtime error: shift exponent -1 is negative": The PCIe

Re: [Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NBD_REP_ERR errors

2016-07-18 Thread Fam Zheng
On Mon, 07/18 22:07, Eric Blake wrote: > nbd/server.c | 78 > +--- > 1 file changed, 59 insertions(+), 19 deletions(-) > > diff --git a/nbd/server.c b/nbd/server.c > index c8716f1..ad31c4a 100644 > --- a/nbd/server.c > +++ b/nbd/server.c >

Re: [Qemu-devel] [PATCH v5 05/14] nbd: Share common reply-sending code in server

2016-07-18 Thread Fam Zheng
On Mon, 07/18 22:07, Eric Blake wrote: > Rather than open-coding NBD_REP_SERVER, reuse the code we > already have by adding a length parameter. Additionally, > the refactoring will make adding NBD_OPT_GO in a later patch > easier. > > Signed-off-by: Eric Blake > > --- > v4:

Re: [Qemu-devel] [PATCH] ppc: Huge page detection mechanism fixes - Episode III

2016-07-18 Thread David Gibson
On Mon, Jul 18, 2016 at 03:19:04PM +0200, Thomas Huth wrote: > After already fixing two issues with the huge page detection mechanism > (see commit 159d2e39a860 and 86b50f2e1bef), Greg Kurz noticed another > case that caused the guest to crash where QEMU announces huge pages > though they should

Re: [Qemu-devel] [PULL 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-18 Thread Peter Xu
On Tue, Jul 19, 2016 at 01:42:28AM +0300, Michael S. Tsirkin wrote: > Should be last pull with features for 2.7. > I mulled including Igor's cpu hot-unplug series, but it > appears Eduardo started merging these already. > We do want them in 2.7 I think so if I misunderstood, I might > add them on

Re: [Qemu-devel] [RFC 0/2] cpu-add compatibility for query-hotpluggable-cpus implementations

2016-07-18 Thread Bharata B Rao
On Mon, Jul 18, 2016 at 06:20:35PM +0200, Igor Mammedov wrote: > On Mon, 18 Jul 2016 17:06:18 +0200 > Peter Krempa wrote: > > > On Mon, Jul 18, 2016 at 19:19:18 +1000, David Gibson wrote: > > > I'm not entirely sure if this is a good idea, and if it is whether > > > this is a

[Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-07-18 Thread Eric Blake
Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. Signed-off-by: Eric Blake --- v4: rebase, fix value for constant v3: abandon

[Qemu-devel] [PATCH v5 05/14] nbd: Share common reply-sending code in server

2016-07-18 Thread Eric Blake
Rather than open-coding NBD_REP_SERVER, reuse the code we already have by adding a length parameter. Additionally, the refactoring will make adding NBD_OPT_GO in a later patch easier. Signed-off-by: Eric Blake --- v4: no change v3: rebase to changes earlier in series ---

Re: [Qemu-devel] [PULL 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-18 Thread Eric Blake
On 07/18/2016 04:42 PM, Michael S. Tsirkin wrote: > Should be last pull with features for 2.7. > I mulled including Igor's cpu hot-unplug series, but it > appears Eduardo started merging these already. > We do want them in 2.7 I think so if I misunderstood, I might > add them on top and do another

[Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NBD_REP_ERR errors

2016-07-18 Thread Eric Blake
The NBD Protocol allows us to send human-readable messages along with any NBD_REP_ERR error during option negotiation; make use of this fact for clients that know what to do with our message. Signed-off-by: Eric Blake --- v5: don't leak 'msg' v4: new patch --- nbd/server.c |

[Qemu-devel] [PATCH v5 07/14] nbd: Share common option-sending code in client

2016-07-18 Thread Eric Blake
Rather than open-coding each option request, it's easier to have common helper functions do the work. That in turn requires having convenient packed types for handling option requests and replies. Signed-off-by: Eric Blake --- v4: rebase v3: rebase, tweak a debug message ---

[Qemu-devel] [PATCH v5 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client

2016-07-18 Thread Eric Blake
Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. The generic block code takes care of falling back to the obvious write of lots of zeroes if we return

[Qemu-devel] [PATCH v5 12/14] nbd: Improve server handling of shutdown requests

2016-07-18 Thread Eric Blake
NBD commit 6d34500b clarified how clients and servers are supposed to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN (for the server to announce it is about to go away during option haggling, so the client should quit sending NBD_OPT_* other than NBD_OPT_ABORT) and ESHUTDOWN

[Qemu-devel] [PATCH v5 03/14] nbd: Limit nbdflags to 16 bits

2016-07-18 Thread Eric Blake
Rather than asserting that nbdflags is within range, just give it the correct type to begin with :) nbdflags corresponds to the per-export portion of NBD Protocol "transmission flags", which is 16 bits in response to NBD_OPT_EXPORT_NAME and NBD_OPT_GO. Furthermore, upstream NBD has never passed

[Qemu-devel] [PATCH v5 10/14] nbd: Less allocation during NBD_OPT_LIST

2016-07-18 Thread Eric Blake
Since we know that the maximum name we are willing to accept is small enough to stack-allocate, rework the iteration over NBD_OPT_LIST responses to reuse a stack buffer rather than allocating every time. Furthermore, we don't even have to allocate if we know the server's length doesn't match what

[Qemu-devel] [PATCH v5 02/14] nbd: Add qemu-nbd -D for human-readable description

2016-07-18 Thread Eric Blake
The NBD protocol allows servers to advertise a human-readable description alongside an export name during NBD_OPT_LIST. Add an option to pass through the user's string to the NBD client. Doing this also makes it easier to test commit 200650d4, which is the client counterpart of receiving the

[Qemu-devel] [PATCH for-2.7 v5 00/14] nbd: efficient write zeroes

2016-07-18 Thread Eric Blake
The upstream NBD protocol is proposing an extension for efficient write zeroes; having a qemu implementation will be one of the reasons to promote the proposal from experimental to standard: https://github.com/yoe/nbd/blob/extension-write-zeroes/doc/proto.md v4 was here:

[Qemu-devel] [PATCH v5 11/14] nbd: Support shorter handshake

2016-07-18 Thread Eric Blake
The NBD Protocol allows the server and client to mutually agree on a shorter handshake (omit the 124 bytes of reserved 0), via the server advertising NBD_FLAG_NO_ZEROES and the client acknowledging with NBD_FLAG_C_NO_ZEROES (only possible in newstyle, whether or not it is fixed newstyle). It

[Qemu-devel] [PATCH v5 09/14] nbd: Let client skip portions of server reply

2016-07-18 Thread Eric Blake
The server has a nice helper function nbd_negotiate_drop_sync() which lets it easily ignore fluff from the client (such as the payload to an unknown option request). We can't quite make it common, since it depends on nbd_negotiate_read() which handles coroutine magic, but we can copy the idea

[Qemu-devel] [PATCH v5 04/14] nbd: Treat flags vs. command type as separate fields

2016-07-18 Thread Eric Blake
Current upstream NBD documents that requests have a 16-bit flags, followed by a 16-bit type integer; although older versions mentioned only a 32-bit field with masking to find flags. Since the protocol is in network order (big-endian over the wire), the ABI is unchanged; but dealing with the

[Qemu-devel] [PATCH v5 08/14] nbd: Let server know when client gives up negotiation

2016-07-18 Thread Eric Blake
The NBD spec says that a client should send NBD_OPT_ABORT rather than just dropping the connection, if the client doesn't like something the server sent during option negotiation. This is a best-effort attempt only, and can only be done in places where we know the server is still in sync with

[Qemu-devel] [PATCH v5 01/14] nbd: Fix bad flag detection on server

2016-07-18 Thread Eric Blake
Commit ab7c548e added a check for invalid flags, but used an early return on error instead of properly going through the cleanup label. Signed-off-by: Eric Blake --- v4: new patch --- nbd/server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [RFC 2/2] qmp: Implement cpu-add in terms of query-hotpluggable-cpus when available

2016-07-18 Thread Bharata B Rao
On Mon, Jul 18, 2016 at 04:01:18PM +0200, Peter Krempa wrote: > On Mon, Jul 18, 2016 at 19:19:20 +1000, David Gibson wrote: > > We've recently added a new device_add based cpu hotplug > > implementation, with the spapr machine type being the first user. In > > order to overcome the limitations of

Re: [Qemu-devel] [PATCH] compiler: never omit assertions if using a static analysis tool

2016-07-18 Thread Richard Henderson
On 07/15/2016 09:58 PM, Paolo Bonzini wrote: Assertions help both Coverity and the clang static analyzer avoid false positives, but on the other hand both are confused when the condition is compiled as (void)(x != FOO). Always expand assertion macros when using Coverity or clang, through a new

Re: [Qemu-devel] [RFC PATCH] tcg: Optimize fence instructions

2016-07-18 Thread Richard Henderson
On 07/15/2016 01:59 AM, Pranith Kumar wrote: This patch applies on top of the fence generation patch series. This commit optimizes fence instructions. Two optimizations are currently implemented. These are: 1. Unnecessary duplicate fence instructions If the same fence instruction is

Re: [Qemu-devel] [PATCH v3 0/9] Third try at fixing sparc register allocation

2016-07-18 Thread Richard Henderson
On 06/24/2016 09:18 AM, Richard Henderson wrote: I was unhappy about the complexity of the second try. Better to convert to normal temps, allowing in rare occasions, spilling the "globals" to the stack in order to satisfy register allocation. I can no longer provoke an allocation failure on

Re: [Qemu-devel] [RFC PATCH V7 6/7] colo-compare: introduce packet comparison thread

2016-07-18 Thread Zhang Chen
On 07/18/2016 04:37 PM, Daniel P. Berrange wrote: On Mon, Jul 18, 2016 at 03:40:49PM +0800, Zhang Chen wrote: If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and

Re: [Qemu-devel] [1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-18 Thread Sam Bobroff
On Fri, Jul 08, 2016 at 08:49:49PM +1000, Michael Ellerman wrote: > On Wed, 2016-06-07 at 06:05:54 UTC, Sam bobroff wrote: > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > > index 02416fe..06d79bc 100644 > > --- a/arch/powerpc/kvm/powerpc.c > > +++

[Qemu-devel] [PULL V2 5/6] MAINTAINERS: release Scott from being a rocker maintainer

2016-07-18 Thread Jason Wang
From: Jiri Pirko As requested by Scott, removing him. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko Signed-off-by: Jason Wang --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS

[Qemu-devel] [PULL V2 6/6] e1000e: fix building without CONFIG_VMXNET3_PCI

2016-07-18 Thread Jason Wang
e1000e needs net_tx_pkt.o and net_rx_pkt.o too. Cc: Dmitry Fleytman Cc: Leonid Bloch Signed-off-by: Jason Wang --- hw/net/Makefile.objs | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL V2 4/6] tap: fix memory leak on failure to create a multiqueue tap device

2016-07-18 Thread Jason Wang
From: Paolo Bonzini Reported by Coverity. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- net/tap.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/net/tap.c b/net/tap.c

[Qemu-devel] [PULL V2 2/6] net: fix incorrect access to pointer

2016-07-18 Thread Jason Wang
From: Paolo Bonzini This is not dereferencing the pointer, and instead checking only the value of the pointer. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- net/eth.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL V2 3/6] net: fix incorrect argument to iov_to_buf

2016-07-18 Thread Jason Wang
From: Paolo Bonzini Coverity reports a "suspicious sizeof" which is indeed wrong. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- net/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL V2 1/6] e1000e: fix incorrect access to pointer

2016-07-18 Thread Jason Wang
From: Paolo Bonzini This is not dereferencing the pointer, and instead checking only the value of the pointer. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [PULL V2 0/6] Net patches

2016-07-18 Thread Jason Wang
The following changes since commit 6b92bbfe812746fe7841a24c24e6460f5359ce72: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' into staging (2016-07-15 16:56:08 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

Re: [Qemu-devel] [PATCH] backup: block-job error BUG

2016-07-18 Thread Fam Zheng
On Tue, 07/19 00:26, Vladimir Sementsov-Ogievskiy wrote: > forget qemu-devel@nongnu.org.. add it. > > On 19.07.2016 00:22, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > This is a variant of existing test case which produces test failure. > > > > It looks like the reason is: > > > >

Re: [Qemu-devel] [RFC 0/2] cpu-add compatibility for query-hotpluggable-cpus implementations

2016-07-18 Thread David Gibson
On Mon, Jul 18, 2016 at 05:06:18PM +0200, Peter Krempa wrote: > On Mon, Jul 18, 2016 at 19:19:18 +1000, David Gibson wrote: > > I'm not entirely sure if this is a good idea, and if it is whether > > this is a good approach to it. But I'd like to discuss it and see if > > anyone has better ideas.

Re: [Qemu-devel] [RFC 2/2] qmp: Implement cpu-add in terms of query-hotpluggable-cpus when available

2016-07-18 Thread David Gibson
On Mon, Jul 18, 2016 at 04:01:18PM +0200, Peter Krempa wrote: > On Mon, Jul 18, 2016 at 19:19:20 +1000, David Gibson wrote: > > We've recently added a new device_add based cpu hotplug > > implementation, with the spapr machine type being the first user. In > > order to overcome the limitations of

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-18 Thread Matthew Garrett
On Jul 18, 2016 17:46, "Stefan Berger" wrote: > > > Matthew Garrett wrote on 07/18/2016 08:39:07 PM: > > > > > > On Jul 18, 2016 17:08, "Stefan Berger" wrote: > > > The point of the TPM is that the device that holds the state of > > the

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-18 Thread Stefan Berger
Matthew Garrett wrote on 07/18/2016 08:39:07 PM: > > On Jul 18, 2016 17:08, "Stefan Berger" wrote: > > The point of the TPM is that the device that holds the state of > the PCRs provides the signatures over their state rather than some > other 'entity'

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-18 Thread Matthew Garrett
On Jul 18, 2016 17:08, "Stefan Berger" wrote: > The point of the TPM is that the device that holds the state of the PCRs provides the signatures over their state rather than some other 'entity' whose trustworthiness wouldn't be clear. Admittedly the device comes with its own

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2016-07-18 Thread Luke Kim
Thanks for your feedback. I was running this on intel i7 Ubuntu 64bit. but I used 32bit qemu as you suspected. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-18 Thread Stefan Berger
Matthew Garrett wrote on 07/18/2016 07:52:22 PM: > Subject: Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware > > On Mon, Jul 18, 2016 at 4:40 PM, Stefan Berger wrote: > > The TPM security's model related to logs, the state of the PCRs,

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-18 Thread Stefan Berger
Matthew Garrett wrote on 07/18/2016 05:26:03 PM: > > On Fri, Jul 15, 2016 at 11:11 AM, Stefan Berger wrote: > > > > > > Typically the TPM is there for the reason: it is a hardware root > of trust that signs the current state of the PCRs that were >

[Qemu-devel] [PULL 3/4] tests: in IDE and AHCI tests perform DMA write before flushing

2016-07-18 Thread John Snow
From: Evgeny Yakovlev Due to changes in flush behaviour clean disks stopped generating flush_to_disk events and IDE and AHCI tests that test flush commands started to fail. This change adds additional DMA writes to affected tests before sending flush commands so that

[Qemu-devel] [PULL 0/4] Ide patches

2016-07-18 Thread John Snow
The following changes since commit 3913d3707e3debfbf0d2d014a1a793394993b088: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160718' into staging (2016-07-18 11:24:15 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request

[Qemu-devel] [PULL 55/55] virtio: Update migration docs

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Remove references to register_savevm. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 52/55] virtio-input: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-18 Thread Matthew Garrett
On Mon, Jul 18, 2016 at 4:40 PM, Stefan Berger wrote: > The TPM security's model related to logs, the state of the PCRs, and > attestation involves the following pieces: > > - PCRs > - measurement log > - EK + certificate > - platform certificate > - AIK + certificate > -

[Qemu-devel] [PULL 44/55] virtio: Migration helper function and macro

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" To make conversion of virtio devices to VMState simple at first add a helper function for the simple virtio_save case and a helper macro that defines the VMState structure. These will probably go away or change as more of the virtio code gets

[Qemu-devel] [PULL 43/55] virtio-serial: Remove old migration version support

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" virtio-serial-bus has had version 3 since 37f95bf3d0 in 0.13-rc0; it's time to clean it up a bit. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 42/55] virtio-net: Remove old migration version support

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" virtio-net has had version 11 since 0ce0e8f4 in 2009 (v0.11.0-rc0-1480-g0ce0e8f) - remove the code to support loading anything earlier. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah

[Qemu-devel] [PULL 40/55] Revert "mirror: Workaround for unexpected iohandler events during completion"

2016-07-18 Thread Michael S. Tsirkin
From: Fam Zheng This reverts commit ab27c3b5e7408693dde0b565f050aa55c4a1bcef. The virtio storage device host notifiers now work with bdrv_drained_begin/end, so we don't need this hack any more. Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 39/55] virtio-scsi: Call virtio_add_queue_aio

2016-07-18 Thread Michael S. Tsirkin
From: Fam Zheng AIO based handler is more appropriate here because it will then cooperate with bdrv_drained_begin/end. It is needed by the coming revert patch. Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 36/55] virtio: Add typedef for handle_output

2016-07-18 Thread Michael S. Tsirkin
From: Fam Zheng The function pointer signature has been repeated a few times, using a typedef may make coding easier. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 54/55] virtio-gpu: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 49/55] virtio-net: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 35/55] intel_iommu: disallow kernel-irqchip=on with IR

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu When user specify "intremap=on" with "-M kernel-irqchip=on", throw error and then quit. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 11 +++ 1 file changed, 11 insertions(+) diff

[Qemu-devel] [PULL 53/55] virtio-gpu: Use migrate_add_blocker for virgl migration blocking

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" virgl conditionally registers a vmstate as unmigratable when virgl is enabled; instead use the migrate_add_blocker mechanism. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 48/55] virtio-balloon: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 28/55] intel_iommu: add SID validation for IR

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu This patch enables SID validation. Invalid interrupts will be dropped. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 17 +++ hw/i386/intel_iommu.c | 69

Re: [Qemu-devel] [PATCH v4 10/14] nbd: Less allocation during NBD_OPT_LIST

2016-07-18 Thread Eric Blake
On 06/27/2016 06:16 AM, Paolo Bonzini wrote: > > > On 26/06/2016 00:15, Eric Blake wrote: >> +/* Return -1 if unrecoverable error occurs >> , 0 if NBD_OPT_LIST is unsupported, > > These two should return errp != NULL and negative errno. Not quite. It returns 0 if nbd_handle_reply_err()

[Qemu-devel] [PULL 50/55] virtio-serial: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 46/55] virtio-blk: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 24/55] intel_iommu: add support for split irqchip

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu In split irqchip mode, IOAPIC is working in user space, only update kernel irq routes when entry changed. When IR is enabled, we directly update the kernel with translated messages. It works just like a kernel cache for the remapping entries. Since KVM irqfd is

[Qemu-devel] [PULL 45/55] virtio-scsi: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 37/55] virtio: Introduce virtio_add_queue_aio

2016-07-18 Thread Michael S. Tsirkin
From: Fam Zheng Using this function instead of virtio_add_queue marks the vq as aio based. This differentiation will be useful in later patches. Distinguish between virtqueue processing in the iohandler context and main loop AioContext. iohandler context is isolated from

[Qemu-devel] [PULL 4/4] block: ignore flush requests when storage is clean

2016-07-18 Thread John Snow
From: Evgeny Yakovlev Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on host when calling fsync/fdatasync. This change introduces a write generation scheme in

[Qemu-devel] [PULL 21/55] intel_iommu: Add support for PCI MSI remap

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu This patch enables interrupt remapping for PCI devices. To play the trick, one memory region "iommu_ir" is added as child region of the original iommu memory region, covering range 0xfeeX (which is the address range for APIC). All the writes to this range

[Qemu-devel] [PULL 34/55] kvm-all: add trace events for kvm irqchip ops

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu These will help us monitoring irqchip route activities more easily. Signed-off-by: Peter Xu Reviewed-by: Paolo Bonzini Signed-off-by: Peter Xu Reviewed-by: Paolo Bonzini ---

[Qemu-devel] [PULL 41/55] virtio-scsi: Replace HandleOutput typedef

2016-07-18 Thread Michael S. Tsirkin
From: Fam Zheng There is a new common one in virtio.h, use it. Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by:

[Qemu-devel] [PULL 2/4] ide: set retry_unit for PIO and FLUSH requests

2016-07-18 Thread John Snow
From: Evgeny Yakovlev The following sequence of tests discovered a problem in IDE emulation: 1. Send DMA write to IDE device 0 2. Send CMD_FLUSH_CACHE to same IDE device which will be failed by block layer using blkdebug script in tests/ide-test:test_retry_flush When

[Qemu-devel] [PULL 20/55] intel_iommu: add IR translation faults defines

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Adding translation fault definitions for interrupt remapping. Please refer to VT-d spec section 7.1. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- hw/i386/intel_iommu_internal.h | 13 + 1 file changed,

[Qemu-devel] [PULL 38/55] virtio-blk: Call virtio_add_queue_aio

2016-07-18 Thread Michael S. Tsirkin
From: Fam Zheng AIO based handler is more appropriate here because it will then cooperate with bdrv_drained_begin/end. It is needed by the coming revert patch. Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 33/55] intel_iommu: support all masks in interrupt entry cache invalidation

2016-07-18 Thread Michael S. Tsirkin
From: Radim Krčmář Linux guests do not gracefully handle cases when the invalidation mask they wanted is not supported, probably because real hardware always allowed all. We can just say that all 16 masks are supported, because both ioapic_iec_notifier and

[Qemu-devel] [PULL 1/4] ide: refactor retry_unit set and clear into separate function

2016-07-18 Thread John Snow
From: Evgeny Yakovlev Code to set and clear state associated with retry in moved into ide_set_retry and ide_clear_retry to make adding retry setups easier. Signed-off-by: Evgeny Yakovlev Signed-off-by: Denis V. Lunev

[Qemu-devel] [PULL 19/55] intel_iommu: define several structs for IOMMU IR

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Several data structs are defined to better support the rest of the patches: IRTE to parse remapping table entries, and IOAPIC/MSI related structure bits to parse interrupt entries to be filled in by guest kernel. Signed-off-by: Peter Xu

[Qemu-devel] [PULL 29/55] kvm-irqchip: simplify kvm_irqchip_add_msi_route

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Changing the original MSIMessage parameter in kvm_irqchip_add_msi_route into the vector number. Vector index provides more information than the MSIMessage, we can retrieve the MSIMessage using the vector easily. This will avoid fetching MSIMessage every time

[Qemu-devel] [PULL 31/55] kvm-irqchip: x86: add msi route notify fn

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu One more IEC notifier is added to let msi routes know about the IEC changes. When interrupt invalidation happens, all registered msi routes will be updated for all PCI devices. Since both vfio and vhost are possible gsi route consumers, this patch will go one

[Qemu-devel] [PULL 18/55] intel_iommu: handle interrupt remap enable

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Handle writting to IRE bit in global command register. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 20 1 file changed, 20 insertions(+) diff --git

[Qemu-devel] [PULL 51/55] 9pfs: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Greg Kurz Reviewed-by:

[Qemu-devel] [PULL 27/55] intel_iommu: Add support for Extended Interrupt Mode

2016-07-18 Thread Michael S. Tsirkin
From: Jan Kiszka As neither QEMU nor KVM support more than 255 CPUs so far, this is simple: we only need to switch the destination ID translation in vtd_remap_irq_get if EIME is set. Once CFI support is there, it will have to take EIM into account as well. So far,

[Qemu-devel] [PULL 30/55] kvm-irqchip: i386: add hook for add/remove virq

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Adding two hooks to be notified when adding/removing msi routes. There are two kinds of MSI routes: - in kvm_irqchip_add_irq_route(): before assigning IRQFD. Used by vhost, vfio, etc. - in kvm_irqchip_send_msi(): when sending direct MSI message, if direct

[Qemu-devel] [PULL 47/55] virtio-rng: Wrap in vmstate

2016-07-18 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 16/55] acpi: add DMAR scope definition for root IOAPIC

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu To enable interrupt remapping for intel IOMMU device, each IOAPIC device in the system reported via ACPI MADT must be explicitly enumerated under one specific remapping hardware unit. This patch adds the root-complex IOAPIC into the default DMAR device. Please

[Qemu-devel] [PULL 23/55] ioapic: introduce ioapic_entry_parse() helper

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Abstract IOAPIC entry parsing logic into a helper function. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- hw/intc/ioapic.c | 110 +++ 1 file changed, 54

[Qemu-devel] [PULL 25/55] x86-iommu: introduce IEC notifiers

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu This patch introduces x86 IOMMU IEC (Interrupt Entry Cache) invalidation notifier list. When vIOMMU receives IEC invalidate request, all the registered units will be notified with specific invalidation requests. Intel IOMMU is the first provider that generates

[Qemu-devel] [PULL 15/55] intel_iommu: set IR bit for ECAP register

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Enable IR in IOMMU Extended Capability register. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- hw/i386/intel_iommu_internal.h | 2 ++ hw/i386/intel_iommu.c | 6 ++ 2 files changed, 8 insertions(+)

[Qemu-devel] [PULL 32/55] kvm-irqchip: do explicit commit when update irq

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu In the past, we are doing gsi route commit for each irqchip route update. This is not efficient if we are updating lots of routes in the same time. This patch removes the committing phase in kvm_irqchip_update_msi_route(). Instead, we do explicit commit after

[Qemu-devel] [PULL 17/55] intel_iommu: define interrupt remap table addr register

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Defined Interrupt Remap Table Address register to store IR table pointer. Also, do proper handling on global command register writes to store table pointer and its size. One more debug flag "DEBUG_IR" is added for interrupt remapping. Signed-off-by: Peter Xu

[Qemu-devel] [PULL 22/55] q35: ioapic: add support for emulated IOAPIC IR

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu This patch translates all IOAPIC interrupts into MSI ones. One pseudo ioapic address space is added to transfer the MSI message. By default, it will be system memory address space. When IR is enabled, it will be IOMMU address space. Currently, only emulated

[Qemu-devel] [PULL 14/55] intel_iommu: allow queued invalidation for IR

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Queued invalidation is required for IR. This patch add basic support for interrupt cache invalidate requests. Since we currently have no IR cache implemented yet, we can just skip all interrupt cache invalidation requests for now. Signed-off-by: Peter Xu

[Qemu-devel] [PULL 13/55] acpi: enable INTR for DMAR report structure

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu In ACPI DMA remapping report structure, enable INTR flag when specified. Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 2 ++ hw/i386/acpi-build.c | 14 +- 2

[Qemu-devel] [PULL 10/55] intel_iommu: rename VTD_PCI_DEVFN_MAX to x86-iommu

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Signed-off-by: Peter Xu Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 1 - include/hw/i386/x86-iommu.h | 2 ++ hw/i386/intel_iommu.c | 11 +++ 3 files changed, 9 insertions(+), 5

[Qemu-devel] [PULL 26/55] ioapic: register IOMMU IEC notifier for ioapic

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Let IOAPIC the first consumer of x86 IOMMU IEC invalidation notifiers. This is only used for split irqchip case, when vIOMMU receives IR invalidation requests, IOAPIC will be notified to update kernel irq routes. For simplicity, we just update all IOAPIC routes,

[Qemu-devel] [PULL 12/55] x86-iommu: introduce "intremap" property

2016-07-18 Thread Michael S. Tsirkin
From: Peter Xu Adding one property for intel-iommu devices to specify whether we should support interrupt remapping. By default, IR is disabled. To enable it, we should use (take Intel IOMMU as example): -device intel_iommu,intremap=on This property can be shared by Intel

[Qemu-devel] [PULL 06/55] hw/grackle: fix PCI bus initialization

2016-07-18 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Delay the host-bridge 'realization' until the PCI root bus is attached. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Tested-by: Mark Cave-Ayland

[Qemu-devel] [PULL 08/55] hw/versatile: realize the PCI root bus as part of the versatile init

2016-07-18 Thread Michael S. Tsirkin
From: Marcel Apfelbaum 'Realize' the PCI root bus manually since the 'realize' mechanism does not propagate to child devices yet. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

  1   2   3   4   >