Re: [Qemu-devel] [PATCH V2] hw/misc: Add simple measurement hardware

2016-08-05 Thread Stefan Berger
Matthew Garrett wrote on 08/05/2016 07:17:12 PM: > > Trusted Boot is based around having a trusted store of measurement data and > a secure communications channel between that store and an attestation > target. In actual hardware, that's a TPM. Since the TPM can only be

Re: [Qemu-devel] [PATCH V2] hw/misc: Add simple measurement hardware

2016-08-05 Thread Eric Blake
On 08/05/2016 05:17 PM, Matthew Garrett wrote: Generally, we recommend that v2 patches be sent as their own top-level thread, rather than in-reply-to v1, because several tooling scripts get confused and don't look for deep patches. > Trusted Boot is based around having a trusted store of

Re: [Qemu-devel] TCG and branches

2016-08-05 Thread Richard Henderson
On 07/31/2016 05:23 AM, Benjamin Herrenschmidt wrote: The first obvious thing that comes to mind is to avoid stopping the TB on a non-taken conditional branch. The reason that can't be done today, from my limited understanding of things, is because we only support index 0 and 1 today for

Re: [Qemu-devel] [PATCH 0/6] linux-user: Handle SEGV on signal entry/exit correctly

2016-08-05 Thread Richard Henderson
On 07/28/2016 09:14 PM, Peter Maydell wrote: Peter Maydell (6): linux-user: Recheck for pending synchronous signals too linux-user: Pass si_type information to queue_signal() explicitly linux-user: SIGSEGV on signal entry need not be fatal linux-user: ARM: Give SIGSEGV if signal frame

[Qemu-devel] [PULL 7/7] tcg: Lower indirect registers in a separate pass

2016-08-05 Thread Richard Henderson
Rather than rely on recursion during the middle of register allocation, lower indirect registers to loads and stores off the indirect base into plain temps. For an x86_64 host, with sufficient registers, this results in identical code, modulo the actual register assignments. For an i686 host,

[Qemu-devel] [PULL 2/7] tcg: Reorg TCGOp chaining

2016-08-05 Thread Richard Henderson
Instead of using -1 as end of chain, use 0, and link through the 0 entry as a fully circular double-linked list. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 +- tcg/optimize.c| 8 ++--

[Qemu-devel] [PULL 5/7] tcg: Include liveness info in the dumps

2016-08-05 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- include/qemu/log.h | 2 +- tcg/tcg.c | 68 +- util/log.c | 19 ++- 3 files changed, 61 insertions(+), 28

[Qemu-devel] [PULL 6/7] tcg: Require liveness analysis

2016-08-05 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index b0a88ba..3c1f526 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -23,7 +23,6 @@ */

[Qemu-devel] [PULL 1/7] tcg: Compress liveness data to 16 bits

2016-08-05 Thread Richard Henderson
This reduces both memory usage and per-insn cacheline usage during code generation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 58 ++ tcg/tcg.h | 16

[Qemu-devel] [PULL 4/7] tcg: Compress dead_temps and mem_temps into a single array

2016-08-05 Thread Richard Henderson
We only need two bits per temporary. Fold the two bytes into one, and reduce the memory and cachelines required during compilation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 119

[Qemu-devel] [PULL 3/7] tcg: Fold life data into TCGOp

2016-08-05 Thread Richard Henderson
Reduce the size of other bitfields to make room. This reduces the cache footprint of compilation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 9 +++-- tcg/tcg.h | 26 ++ 2 files changed, 17

[Qemu-devel] [PULL for-2.7 0/7] tcg: fix indirect register lowering

2016-08-05 Thread Richard Henderson
repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20160805 for you to fetch changes up to 5a18407f55ade924aa6397c9a043a9ffd59645fe: tcg: Lower indirect registers in a separate pass (2016-08-05 21:44:40 +0530) indirec

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

2016-08-05 Thread Fam Zheng
On Fri, 08/05 11:34, Paolo Bonzini wrote: > GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527. > This causes the API to break between a GCC-compiled ROM and > one that was obtained with clang. > > First, this patch fixes this by preventing clang's happy inlining (which > -Os

[Qemu-devel] [PATCH V2] hw/misc: Add simple measurement hardware

2016-08-05 Thread Matthew Garrett
Trusted Boot is based around having a trusted store of measurement data and a secure communications channel between that store and an attestation target. In actual hardware, that's a TPM. Since the TPM can only be accessed via the host system, this in turn requires that the TPM be able to perform

Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object

2016-08-05 Thread Benjamin Herrenschmidt
On Fri, 2016-08-05 at 18:48 +0200, Cédric Le Goater wrote: > The core initialization should be ok but building the device  > tree might be a bit of a burden if we have to 'cast' in the chip  > type we need. We will see. We don't cast, we use a method. > So what would be the big differences with

Re: [Qemu-devel] [PATCH] ppc: Rename #include'd .c files to .inc.c

2016-08-05 Thread Benjamin Herrenschmidt
On Fri, 2016-08-05 at 11:32 -0600, Eric Blake wrote: > Per http://wiki.qemu.org/Contribute/SubmitAPatch, if you would do: > > git config diff.renames true > > then your email would be MUCH smaller, calling our attention to what > changed to accommodate the rename rather than treating the entire

Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

2016-08-05 Thread Zheng, Lv
Hi, > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Subject: Re: [PATCH] debugcon: Add -debugport option to allow changing > debug console port number > > > > On 05/08/2016 12:19, Lv Zheng wrote: > > Changing debugcon port to 0x402 allows the seabios AML

Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

2016-08-05 Thread Zheng, Lv
Hi, > From: Igor Mammedov [mailto:imamm...@redhat.com] > Subject: Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to > allow changing debug console port number > > On Fri, 5 Aug 2016 18:19:39 +0800 > Lv Zheng wrote: > > > Changing debugcon port to 0x402 allows the

Re: [Qemu-devel] [PATCH v2 12/12] Drop qmp-commands.hx

2016-08-05 Thread Marc-André Lureau
Hi On Fri, Aug 5, 2016 at 6:58 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Only the documentation remains useful, so strip it. > > What about: > > The only remaining function of

[Qemu-devel] [PATCH v2] help: Update help to reflect that GTK is the default

2016-08-05 Thread Colin Lord
Updates the help messages to reflect that GTK is the default display (if enabled), not SDL. Signed-off-by: Colin Lord --- v2: Update to try to implement Paolo's suggested wordings. It looks to me like the subsections get wrapped at 72 lines, which mean there was a bit of a

Re: [Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes

2016-08-05 Thread Marc-André Lureau
Hi Peter, All patches have a reviewed-by tag now, Given the mix of domains, I can send you a pull request. What do you think? thanks On Fri, Aug 5, 2016 at 12:26 PM wrote: > From: Marc-André Lureau > > Hi, > > Thanks to

Re: [Qemu-devel] [PATCH COLO-Frame v18 12/34] COLO: Load VMState into buffer before restore it

2016-08-05 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should not destroy the state of SVM (Secondary VM) until we receive > the whole state from the PVM (Primary VM), in case the primary fails in > the middle of sending the state, so, here we cache the device state in > Secondary before

Re: [Qemu-devel] [PATCH] ppc: Rename #include'd .c files to .inc.c

2016-08-05 Thread Eric Blake
On 07/28/2016 04:30 PM, Benjamin Herrenschmidt wrote: > Also while at it, group the #include statements in translate.c > > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/translate.c | 40 +- > target-ppc/translate/dfp-impl.c | 212 -- >

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-05 Thread Eric Blake
On 08/05/2016 10:59 AM, Lluís Vilanova wrote: > QEMU detects when the guest uses 'mmap' on hypertrace's control channel > file, and then uses 'mprotect' to detect accesses to it, which are used > to trigger traceing event "guest_hypertrace". s/traceing/tracing/ I'll probably leave the technical

Re: [Qemu-devel] [PATCH 1/6] hypertrace: Add documentation

2016-08-05 Thread Eric Blake
On 08/05/2016 10:59 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > docs/hypertrace.txt | 141 > +++ > docs/tracing.txt|3 + > 2 files changed, 144 insertions(+) > create mode 100644

[Qemu-devel] [PATCH 6/6] hypertrace: Add guest-side Linux module

2016-08-05 Thread Lluís Vilanova
Provides guest Linux kernel module "qemu-hypertrace.ko" to abstract access to the hypertrace channel. Signed-off-by: Lluís Vilanova --- Makefile |4 - configure |4 +

[Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-05 Thread Lluís Vilanova
QEMU detects when the guest uses 'mmap' on hypertrace's control channel file, and then uses 'mprotect' to detect accesses to it, which are used to trigger traceing event "guest_hypertrace". Signed-off-by: Lluís Vilanova --- Makefile.objs|4 + bsd-user/main.c

[Qemu-devel] [PATCH 2/6] hypertrace: Add tracing event "guest_hypertrace"

2016-08-05 Thread Lluís Vilanova
Generates the "guest_hypertrace" event with a user-configurable number of arguments. Signed-off-by: Lluís Vilanova --- Makefile.objs |2 ++ configure | 36 trace/Makefile.objs |2 +- 3 files changed, 39

[Qemu-devel] [PATCH 4/6] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-05 Thread Lluís Vilanova
Uses a virtual device to trigger the hypertrace channel event. Signed-off-by: Lluís Vilanova --- hypertrace/Makefile.objs |5 + hypertrace/softmmu.c | 243 ++ include/hw/pci/pci.h |2 3 files changed, 249

[Qemu-devel] [PATCH 5/6] hypertrace: Add guest-side user-level library

2016-08-05 Thread Lluís Vilanova
Provides guest library "libqemu-hypertrace-guest.a" to abstract access to the hypertrace channel. Signed-off-by: Lluís Vilanova --- Makefile|6 + configure |2 hypertrace/guest/user/Makefile |

[Qemu-devel] [PATCH 1/6] hypertrace: Add documentation

2016-08-05 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/hypertrace.txt | 141 +++ docs/tracing.txt|3 + 2 files changed, 144 insertions(+) create mode 100644 docs/hypertrace.txt diff --git a/docs/hypertrace.txt b/docs/hypertrace.txt

[Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-05 Thread Lluís Vilanova
The hypertrace channel allows guest code to emit events in QEMU (the host) using its tracing infrastructure (see "docs/trace.txt"). This works in both 'system' and 'user' modes. That is, hypertrace is to tracing, what hypercalls are to system calls. You can use this to emit an event on both guest

Re: [Qemu-devel] [PATCH for-2.7 v4 04/36] qga: free the whole blacklist

2016-08-05 Thread Eric Blake
On 08/05/2016 05:25 AM, Markus Armbruster wrote: > Copying maintainer. > > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau >> >> Free the config blacklist list, not just the elements. Do it so in the >> more appropriate function config_free(). >> >>

Re: [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state

2016-08-05 Thread Eric Blake
On 08/05/2016 05:26 AM, Markus Armbruster wrote: > Copying maintainer. > > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> --- >> qga/guest-agent-command-state.c | 6 ++ >>

Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object

2016-08-05 Thread Cédric Le Goater
On 08/05/2016 11:44 AM, Benjamin Herrenschmidt wrote: > On Fri, 2016-08-05 at 11:15 +0200, Cédric Le Goater wrote: >> This is is an abstraction of a P8 chip which is a set of cores plus >> other 'units', like the pervasive unit, the interrupt controller, the >> memory controller, the on-chip

[Qemu-devel] in static link of qemu-img et al, complaint about 'overriding common' for libnfs

2016-08-05 Thread Peter Maydell
If you do a static build of QEMU which includes trying to build the helper tools, linking of qemu-io, qemu-img, etc produces among other things this warning: /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libc.a(rpc_common.o): warning: definition of `_null_auth' overriding common

[Qemu-devel] [RFC 2/2] vhost-vsock: add virtio sockets device

2016-08-05 Thread Stefan Hajnoczi
Implement the new virtio sockets device for host<->guest communication using the Sockets API. Most of the work is done in a vhost kernel driver so that virtio-vsock can hook into the AF_VSOCK address family. The QEMU vhost-vsock device handles configuration and live migration while the rx/tx

[Qemu-devel] [RFC 0/2] vhost-vsock: add vhost-vsock device

2016-08-05 Thread Stefan Hajnoczi
This patch series adds -device vhost-vsock,guest-cid= to QEMU. It uses the vhost_vsock.ko Linux kernel module for AF_VSOCK socket communications. There are still a few TODOs in the code which I will resolve. This is the latest version for anyone wishing to test or review vsock. For more

[Qemu-devel] [RFC 1/2] linux-headers: add virtio vsock headers

2016-08-05 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_vsock.h | 94 +++ linux-headers/linux/vhost.h | 5 ++ 3 files changed, 100 insertions(+) create mode

Re: [Qemu-devel] [PATCH] tests: Rename qtests which have names ending "error"

2016-08-05 Thread Peter Maydell
On 4 August 2016 at 12:31, Daniel P. Berrange wrote: > On Thu, Aug 04, 2016 at 11:39:38AM +0100, Peter Maydell wrote: >> We have three qtest tests which have test names ending with "error". >> This is awkward because the output of verbose test runs looks like >>

[Qemu-devel] QEMU 2.7rc2 planned for Monday

2016-08-05 Thread Peter Maydell
Hi; I'm planning to tag rc2 on Monday; please can you try to get patches aimed for 2.7 posted and reviewed on Monday if possible? There will be an rc3 but I'd rather we get patches into rc2 rather than rc3 where we can. thanks -- PMM

Re: [Qemu-devel] [PATCH v2 12/12] Drop qmp-commands.hx

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Only the documentation remains useful, so strip it. What about: The only remaining function of qmp-commands.hx is to let us generate qmp-commands.txt from it. Replace qmp-commands.hx by

Re: [Qemu-devel] [PATCH for-2.7 v5.1 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.

2016-08-05 Thread Prerna Saxena
On 04/08/16 9:41 am, "Michael S. Tsirkin" wrote: >On Sat, Jul 30, 2016 at 06:38:23AM +, Prerna Saxena wrote: >> >> >> >> >> >> On 30/07/16 2:19 am, "Eric Blake" wrote: >> >> >On 07/28/2016 01:07 AM, Prerna Saxena wrote: >> >> From: Prerna Saxena

Re: [Qemu-devel] [PATCH] spapr: Correctly set query_hotpluggable_cpus hook based on machine version

2016-08-05 Thread Bharata B Rao
On Fri, Aug 05, 2016 at 05:50:29PM +1000, David Gibson wrote: > Prior to c8721d3 "spapr: Error out when CPU hotplug is attempted on older > pseries machines", attempting to use query-hotpluggable-cpus on pseries-2.6 > and earlier machine types would SEGV. > > That change fixed that, but due to

Re: [Qemu-devel] [PATCH v2 10/12] monitor: use qmp_dispatch()

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Replace the old manual dispatch and validation code by the generic one > provided by qapi common code. > > Signed-off-by: Marc-André Lureau > --- > monitor.c| 319 >

Re: [Qemu-devel] [PATCH v2 11/12] qmp: update qmp_query_spice fallback

2016-08-05 Thread Markus Armbruster
Marc-André Lureau writes: > - Original Message - >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > There are a few commands that are undef #ifdef conditions in >> >> under #ifdef >> >> > qmp-commands.hx.

Re: [Qemu-devel] [PATCH v2 for-2.7] wxx: Fix handling of files used for character devices

2016-08-05 Thread Peter Maydell
On 2 August 2016 at 07:47, Paolo Bonzini wrote: > > > On 02/08/2016 07:14, Stefan Weil wrote: >> On Windows, such files were not truncated like on all other hosts. >> Now we also test whether truncation is needed when running on Windows. >> >> The append case was also

[Qemu-devel] [PATCH for-2.7 1/1] s390x/pci: fix null pointer bug

2016-08-05 Thread Cornelia Huck
From: Yi Min Zhao We should make sure that it's not NULL firstly. Signed-off-by: Yi Min Zhao Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 2 +-

[Qemu-devel] [PATCH for-2.7 0/1] s390x fix for 2.7

2016-08-05 Thread Cornelia Huck
One more s390x fix for a bug in the pci rework. Plan to send a pull req early next week. Yi Min Zhao (1): s390x/pci: fix null pointer bug hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.2

Re: [Qemu-devel] [PATCH v2 06/12] monitor: remove mhandler.cmd_new

2016-08-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > This is no longer necessary, now that middle mode has been removed. >> >> Well, middle mode hasn't

Re: [Qemu-devel] [PATCH v2 04/12] monitor: remove usage of generated marshal functions

2016-08-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Once the middle mode is removed, the generated marshal functions will no >> > longer be exported. >>

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

2016-08-05 Thread Paolo Bonzini
> I sort of question whether anyone would do this (mix different > compilers and expect migration to work). And if we do allow it, why > don't we copy the ROMs across with the rest of the memory? We do, but the sizes need to match. Paolo > It seems > to me as if migration would still break if

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

2016-08-05 Thread Paolo Bonzini
On 05/08/2016 14:30, Peter Maydell wrote: > On 5 August 2016 at 13:22, Richard W.M. Jones wrote: >> I sort of question whether anyone would do this (mix different >> compilers and expect migration to work). > > If we support cross-QEMU-version migration I would certainly >

Re: [Qemu-devel] [PATCH v2 11/12] qmp: update qmp_query_spice fallback

2016-08-05 Thread Marc-André Lureau
- Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > There are a few commands that are undef #ifdef conditions in > > under #ifdef > > > qmp-commands.hx. Move all the qmp_query_spice fallback in the same > >

Re: [Qemu-devel] [PATCH v2 11/12] qmp: update qmp_query_spice fallback

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > There are a few commands that are undef #ifdef conditions in under #ifdef > qmp-commands.hx. Move all the qmp_query_spice fallback in the same > location, return an error and update the comment. > >

Re: [Qemu-devel] [PATCH v2 09/12] qapi: remove the "middle" mode

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Now that the register function is always generated, we can > remove the so-called "middle" mode from the generator script. > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH v2 07/12] monitor: implement 'qmp_query_commands' without qmp_cmds

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > So we can get rid of the static qmp_cmds table. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 32 ++-- > 1 file changed, 14

Re: [Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

2016-08-05 Thread Kevin Zhao
Hi Claudio, Could you tell me what host and guest OS are you using? And the hardware is 96board or other Hisilicon Server? I use SoftIron. 8 cores AArch64 servers. On 5 August 2016 at 18:32, Claudio Fontana wrote: > On 05.08.2016 12:27, Claudio Fontana

Re: [Qemu-devel] [PULL 0/3] Block layer patches for 2.7.0-rc2

2016-08-05 Thread Peter Maydell
On 5 August 2016 at 10:32, Kevin Wolf wrote: > The following changes since commit 42e0d60f1615ef63d16e41bb1668805560c37870: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160804' > into staging (2016-08-04 18:36:05 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v2 06/12] monitor: remove mhandler.cmd_new

2016-08-05 Thread Marc-André Lureau
Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > This is no longer necessary, now that middle mode has been removed. > > Well, middle mode hasn't been removed just yet, only its use. Perhaps: > > This

Re: [Qemu-devel] [PATCH] hw/sparc/leon3: Don't call get_image_size() on a NULL pointer

2016-08-05 Thread Fabien Chouteau
On 08/05/2016 12:03 PM, Peter Maydell wrote: > get_image_size() doesn't handle being passed a NULL pointer, so > avoid doing that. Spotted by the clang ub sanitizer (which notices > the attempt to pass NULL to open()). > Looks good. Thanks Peter! > Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 06/12] monitor: remove mhandler.cmd_new

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This is no longer necessary, now that middle mode has been removed. Well, middle mode hasn't been removed just yet, only its use. Perhaps: This is no longer necessary now that we aren't using

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

2016-08-05 Thread Andrew Jones
On Fri, Aug 05, 2016 at 11:46:33AM +0200, Laurent Vivier wrote: > > > On 05/08/2016 11:26, Andrew Jones wrote: > > On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: > >> > >> > >> On 04/08/2016 04:38, David Gibson wrote: > >>> On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent

Re: [Qemu-devel] [PATCH v2 05/12] monitor: register the qapi generated commands

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > from generated qapi commands registry. > > Note: this commit requires a 'make clean' prior to make, since the > generated files

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

2016-08-05 Thread Peter Maydell
On 5 August 2016 at 13:22, Richard W.M. Jones wrote: > I sort of question whether anyone would do this (mix different > compilers and expect migration to work). If we support cross-QEMU-version migration I would certainly expect to support migration where the same version of

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

2016-08-05 Thread Richard W.M. Jones
On Fri, Aug 05, 2016 at 08:02:25AM -0400, Paolo Bonzini wrote: > > > On Fri, Aug 05, 2016 at 11:34:57AM +0200, Paolo Bonzini wrote: > > > GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527. > > > This causes the API to break between a GCC-compiled ROM and > > > one that was

Re: [Qemu-devel] [PATCH v2 04/12] monitor: remove usage of generated marshal functions

2016-08-05 Thread Marc-André Lureau
Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Once the middle mode is removed, the generated marshal functions will no > > longer be exported. > > > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 04/12] monitor: remove usage of generated marshal functions

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Once the middle mode is removed, the generated marshal functions will no > longer be exported. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

2016-08-05 Thread Paolo Bonzini
On 05/08/2016 12:19, Lv Zheng wrote: > Changing debugcon port to 0x402 allows the seabios AML table pre-defined > DBUG() control method to be able to dump the AML debugging information to > the re-directed debugging console. > > If the debug port number is configurable, users can further

Re: [Qemu-devel] [PATCH v2 02/12] qapi-schema: add 'device_add'

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Even though device_add is not fully qapi'fied, we may add it to the json > schema with 'gen': false, so registration and documentation can be > generated. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PULL for-2.7 0/5] Block patches

2016-08-05 Thread Peter Maydell
On 5 August 2016 at 10:24, Stefan Hajnoczi wrote: > The following changes since commit 42e0d60f1615ef63d16e41bb1668805560c37870: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160804' > into staging (2016-08-04 18:36:05 +0100) > > are available in

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

2016-08-05 Thread Paolo Bonzini
> On Fri, Aug 05, 2016 at 11:34:57AM +0200, Paolo Bonzini wrote: > > GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527. > > This causes the API to break between a GCC-compiled ROM and > > one that was obtained with clang. > > I don't understand this justification. Which API?

Re: [Qemu-devel] [PATCH v4 for-2.7 2/7] tcg: Reorg TCGOp chaining

2016-08-05 Thread Aurelien Jarno
On 2016-08-04 21:56, Richard Henderson wrote: > Instead of using -1 as end of chain, use 0, and link through the 0 > entry as a fully circular double-linked list. > > Signed-off-by: Richard Henderson Thanks for the new patchset. It looks fine to me. Reviewed-by: Aurelien

Re: [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink()

2016-08-05 Thread Peter Maydell
On 5 August 2016 at 12:19, Markus Armbruster wrote: > Peter Maydell writes: > >> The unlink() function doesn't accept a NULL pointer, so >> don't pass it one. Spotted by the clang sanitizer. >> >> Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH v3] balloon: Fix failure of updating guest memory status

2016-08-05 Thread Ladi Prosek
The stats_vq_elem field keeps track of the state of the balloon stats virtqueue protocol but it wasn't preserved across migrations, resulting in losing guest memory status updates on the receiving VM. This commit adds a new VM state change handler which resets stats_vq_elem to NULL when the VM is

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

2016-08-05 Thread David Gibson
On Fri, Aug 05, 2016 at 11:26:47AM +0200, Andrew Jones wrote: > On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: > > > > > > On 04/08/2016 04:38, David Gibson wrote: > > > On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: > > >> If we don't provide the page size in

Re: [Qemu-devel] [PATCH for-2.7 v4 32/36] tests: add qtest_add_data_func_full

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Allows one to specify a destroy function for the test data. > > Signed-off-by: Marc-André Lureau Since Eric's okay with the function type punning in the compatibility

Re: [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state

2016-08-05 Thread Markus Armbruster
Copying maintainer. marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qga/guest-agent-command-state.c | 6 ++ > qga/guest-agent-core.h | 1 + > qga/main.c

Re: [Qemu-devel] [PATCH for-2.7 v4 04/36] qga: free the whole blacklist

2016-08-05 Thread Markus Armbruster
Copying maintainer. marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Free the config blacklist list, not just the elements. Do it so in the > more appropriate function config_free(). > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH for-2.7 v4 03/36] glib-compat: add g_(s)list_free_full()

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Those functions are only available since glib 2.28. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH for-2.7] tests: Test blockjob IDs

2016-08-05 Thread Kevin Wolf
Am 29.07.2016 um 16:31 hat Alberto Garcia geschrieben: > Since 7f0317cfc8da6 we have API to specify the ID of block jobs and we > also guarantee that they are well-formed and unique. > > This patch adds tests to check some common scenarios. > > Signed-off-by: Alberto Garcia

Re: [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink()

2016-08-05 Thread Markus Armbruster
Peter Maydell writes: > The unlink() function doesn't accept a NULL pointer, so > don't pass it one. Spotted by the clang sanitizer. > > Signed-off-by: Peter Maydell > --- > tests/hd-geo-test.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

2016-08-05 Thread Igor Mammedov
On Fri, 5 Aug 2016 18:19:39 +0800 Lv Zheng wrote: > Changing debugcon port to 0x402 allows the seabios AML table pre-defined > DBUG() control method to be able to dump the AML debugging information to > the re-directed debugging console. > > If the debug port number is

[Qemu-devel] [PATCH for-2.7 v7 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.

2016-08-05 Thread Prerna Saxena
From: Prerna Saxena This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK. If negotiated, client applications should send a u64 payload in response to any message that contains the "need_reply" bit set on the message flags. Setting the payload to "zero" indicates the

[Qemu-devel] [PATCH for-2.7 v7 0/2]vhost-user: Extend protocol to receive replies on any command.

2016-08-05 Thread Prerna Saxena
From: Prerna Saxena [ This series incorporates all suggestions around documentation that were suggested.] vhost-user: Extend protocol to receive replies on any command. The current vhost-user protocol requires the client to send reply to only a few commands. For the

[Qemu-devel] [PATCH for-2.7 v7 2/2] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-05 Thread Prerna Saxena
From: Prerna Saxena The set_mem_table command currently does not seek a reply. Hence, there is no easy way for a remote application to notify to QEMU when it finished setting up memory, or if there were errors doing so. As an example: (1) Qemu sends a SET_MEM_TABLE to

Re: [Qemu-devel] [PATCH v2 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities'

2016-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > qapi'fy the 'qmp_capabilities' command. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake > --- > monitor.c| 4 ++-- >

Re: [Qemu-devel] [PULL 0/2] Docker patches

2016-08-05 Thread Peter Maydell
On 5 August 2016 at 10:04, Fam Zheng wrote: > The following changes since commit 42e0d60f1615ef63d16e41bb1668805560c37870: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160804' > into staging (2016-08-04 18:36:05 +0100) > > are available in the git

[Qemu-devel] [PATCH for-2.7] qtest.c: Allow zero size in memset qtest commands

2016-08-05 Thread Peter Maydell
Some tests use the qtest protocol "memset" command with a zero size, expecting it to do nothing. However in the current code this will result in calling memset() with a NULL pointer, which is undefined behaviour. Detect and specially handle zero sizes to avoid this. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH for-2.7 v2] block/qdev: Let 'drive' property fall back to node name

2016-08-05 Thread Kevin Wolf
Am 04.08.2016 um 14:09 hat Kevin Wolf geschrieben: > If a qdev block device is created with an anonymous BlockBackend (i.e. > a node name rather than a BB name was given for the drive property), > qdev used to return an empty string when the property was read. This > patch fixes it to return the

Re: [Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive

2016-08-05 Thread Kevin Wolf
Am 04.08.2016 um 18:03 hat Eric Blake geschrieben: > On 08/01/2016 01:47 PM, Kevin Wolf wrote: > > Am 14.07.2016 um 21:48 hat Eric Blake geschrieben: > >> On 07/14/2016 07:49 AM, Kevin Wolf wrote: > >>> This allows to create an empty ide-cd device without manually creating a > >>> BlockBackend. >

Re: [Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

2016-08-05 Thread Claudio Fontana
On 05.08.2016 12:27, Claudio Fontana wrote: > Hi, > > On 05.08.2016 10:28, Daniel P. Berrange wrote: >> On Fri, Aug 05, 2016 at 10:23:58AM +0800, Kevin Zhao wrote: >>> Hi All, >>> I have a problem may about Qemu and kindly need your help. Does >>> qemu-system-aarch64 support virtio-9p ? >>>

[Qemu-devel] [PATCH] spapr: Correctly set query_hotpluggable_cpus hook based on machine version

2016-08-05 Thread David Gibson
Prior to c8721d3 "spapr: Error out when CPU hotplug is attempted on older pseries machines", attempting to use query-hotpluggable-cpus on pseries-2.6 and earlier machine types would SEGV. That change fixed that, but due to some unexpected interactions in init order and a brown-paper-bag worthy

Re: [Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

2016-08-05 Thread Claudio Fontana
Hi, On 05.08.2016 10:28, Daniel P. Berrange wrote: > On Fri, Aug 05, 2016 at 10:23:58AM +0800, Kevin Zhao wrote: >> Hi All, >> I have a problem may about Qemu and kindly need your help. Does >> qemu-system-aarch64 support virtio-9p ? >> Recently I have tried to use qemu remapped the

[Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

2016-08-05 Thread Lv Zheng
Changing debugcon port to 0x402 allows the seabios AML table pre-defined DBUG() control method to be able to dump the AML debugging information to the re-directed debugging console. If the debug port number is configurable, users can further specify a proper IO port number for it to make external

Re: [Qemu-devel] [PATCH for-2.7 v4 19/36] char: free the tcp connection data when closing

2016-08-05 Thread Paolo Bonzini
On 05/08/2016 10:24, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Make sure the connection data got freed when closing the chardev, to > avoid leaks. Introduce tcp_chr_free_connection() to clean all connection > related data, and move some

Re: [Qemu-devel] xen-20160804-tag

2016-08-05 Thread Peter Maydell
On 4 August 2016 at 18:44, Stefano Stabellini wrote: > The following changes since commit 09704e6ded83fa0bec14baf32f800f6512156ca0: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-08-04 10:24:27 +0100) > > are available in the

[Qemu-devel] [PATCH] hw/sparc/leon3: Don't call get_image_size() on a NULL pointer

2016-08-05 Thread Peter Maydell
get_image_size() doesn't handle being passed a NULL pointer, so avoid doing that. Spotted by the clang ub sanitizer (which notices the attempt to pass NULL to open()). Signed-off-by: Peter Maydell --- hw/sparc/leon3.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

2016-08-05 Thread Kevin Zhao
Hi Daniel && Peter && All, Thanks for your help. I've changed to 9p2000.u but also met the problem. The qemu of booting the guests is here: http://paste.openstack.org/show/550382/ After booting *Debian 8* OS, enter into the guests and run the command( changed to 9p2000.u): [image:

Re: [Qemu-devel] [PATCH] macio: set res_count value to 0 after non-block ATAPI DMA transfers

2016-08-05 Thread David Gibson
On Fri, Aug 05, 2016 at 08:30:02AM +0100, Mark Cave-Ayland wrote: > res_count should be set to the number of outstanding bytes after a DBDMA > request. Unfortunately this wasn't being set to zero by the non-block > transfer codepath meaning drivers that checked the descriptor result for > such

  1   2   3   >